[PATCH] D44823: [libcxx] Improving std::vector and std::deque perfomance

danlark added a comment. In D44823#1375590 , @mclow.lists wrote: > I just tried this (on Compiler Explorer) using LLVM 7, and the code for my > original test in https://bugs.llvm.org/show_bug.cgi?id=35637 is now optimal. > Looking briefly at your test

[PATCH] D33841: [clang-tidy] redundant keyword check

koldaniel marked an inline comment as done. koldaniel added inline comments. Comment at: docs/clang-tidy/checks/readability-redundant-keyword.rst:8 + +`extern` is redundant in function declarations + alexfh wrote: > xazax.hun wrote: > > alexfh wrote: > > > Could

[PATCH] D56611: [clangd] A code action to swap branches of an if statement

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/SourceCode.h:63 +/// Turns a token range into a half-open range and checks its correctness. +/// The resulting range will

[PATCH] D57392: [clangd] Mention indexing in docs.

kadircet updated this revision to Diff 184104. kadircet added a comment. - Change ordering of sentences Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57392/new/ https://reviews.llvm.org/D57392 Files: docs/clangd.rst Index: docs/clangd.rst

[PATCH] D44823: [libcxx] Improving std::vector and std::deque perfomance

mclow.lists added a comment. Herald added a subscriber: libcxx-commits. I just tried this (on Compiler Explorer) using LLVM 7, and the code for my original test in https://bugs.llvm.org/show_bug.cgi?id=35637 is now optimal. Looking briefly at your test case, it seems to be fixed now too. Can you

[PATCH] D57392: [clangd] Mention indexing in docs.

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D57392 Files: docs/clangd.rst Index: docs/clangd.rst

[PATCH] D54604: Automatic variable initialization

jfb added a comment. In D54604#1375514 , @glider wrote: > Not sure if a similar problem was mentioned already or not, but the following > program: Yes please file a bug. Seems like the optimizer should sink the store enough that it appears only once

[PATCH] D57390: OpenCL: Don't promote vector args to printf

arsenm created this revision. arsenm added reviewers: rjmccall, Anastasia. Herald added subscribers: yaxunl, wdng. This reverts commit r348083. This was based on misreading the spec for printf specifiers. Start respecting the length modifier for vectors. The warnings are still

[PATCH] D57101: [OpenCL] Add generic addr space to the return of implicit assignment

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57101/new/ https://reviews.llvm.org/D57101 ___ cfe-commits mailing list

[PATCH] D54604: Automatic variable initialization

rjmccall added a comment. I think it's absolutely fair game to file bugs for this. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54604/new/ https://reviews.llvm.org/D54604 ___ cfe-commits mailing list

[libunwind] r352514 - Adjust documentation for git migration.

Author: jyknight Date: Tue Jan 29 08:37:27 2019 New Revision: 352514 URL: http://llvm.org/viewvc/llvm-project?rev=352514=rev Log: Adjust documentation for git migration. This fixes most references to the paths: llvm.org/svn/ llvm.org/git/ llvm.org/viewvc/ github.com/llvm-mirror/

[PATCH] D57330: Adjust documentation for git migration.

This revision was automatically updated to reflect the committed changes. jyknight marked 2 inline comments as done. Closed by commit rC352514: Adjust documentation for git migration. (authored by jyknight, committed by ). Changed prior to commit:

[libclc] r352514 - Adjust documentation for git migration.

Author: jyknight Date: Tue Jan 29 08:37:27 2019 New Revision: 352514 URL: http://llvm.org/viewvc/llvm-project?rev=352514=rev Log: Adjust documentation for git migration. This fixes most references to the paths: llvm.org/svn/ llvm.org/git/ llvm.org/viewvc/ github.com/llvm-mirror/

r352514 - Adjust documentation for git migration.

Author: jyknight Date: Tue Jan 29 08:37:27 2019 New Revision: 352514 URL: http://llvm.org/viewvc/llvm-project?rev=352514=rev Log: Adjust documentation for git migration. This fixes most references to the paths: llvm.org/svn/ llvm.org/git/ llvm.org/viewvc/ github.com/llvm-mirror/

[clang-tools-extra] r352514 - Adjust documentation for git migration.

Author: jyknight Date: Tue Jan 29 08:37:27 2019 New Revision: 352514 URL: http://llvm.org/viewvc/llvm-project?rev=352514=rev Log: Adjust documentation for git migration. This fixes most references to the paths: llvm.org/svn/ llvm.org/git/ llvm.org/viewvc/ github.com/llvm-mirror/

[PATCH] D57330: Adjust documentation for git migration.

jyknight marked 8 inline comments as done. jyknight added a comment. In D57330#1375096 , @labath wrote: > I am not sure we should be recommending to people to place the build folder > under the llvm-project checkout. Is that how people use the monorepo

[PATCH] D54604: Automatic variable initialization

glider added a comment. (Overall, since this is an "unsupported" feature, is it ok to file Bugzilla bugs for it?) Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54604/new/ https://reviews.llvm.org/D54604 ___

[PATCH] D57388: [clangd] Implement textDocument/declaration from LSP 3.14

sammccall updated this revision to Diff 184096. sammccall added a comment. Add server capability declarationProvider. Technically an extension, but that's probably just a protocol bug. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57388/new/

[PATCH] D54604: Automatic variable initialization

glider added a comment. Not sure if a similar problem was mentioned already or not, but the following program: void alloc_sock(int *err); int try_send(); int send(int len) { int err; if (len) { err = -1; alloc_sock(); err = try_send(); } return -1;

[clang-tools-extra] r352511 - [clangd] Remove extra '; ' to fix -Wpedantic warning. NFC

Author: ibiryukov Date: Tue Jan 29 08:04:39 2019 New Revision: 352511 URL: http://llvm.org/viewvc/llvm-project?rev=352511=rev Log: [clangd] Remove extra ';' to fix -Wpedantic warning. NFC Modified: clang-tools-extra/trunk/clangd/refactor/Tweak.cpp Modified:

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

jhibbits added a comment. @vit9696 sure thing. We'll need to get all these patches in together before any are actually useful. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49754/new/ https://reviews.llvm.org/D49754

[clang-tools-extra] r352510 - [clangd] Attempt to fix failing buildbots after r352494

Author: ibiryukov Date: Tue Jan 29 07:57:14 2019 New Revision: 352510 URL: http://llvm.org/viewvc/llvm-project?rev=352510=rev Log: [clangd] Attempt to fix failing buildbots after r352494 For failures see:

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

vit9696 added a subscriber: hfinkel. vit9696 added a comment. That's pretty good. Do you think it is possible to land it in 8.0 release? @hfinkel? @jhibbits could you please include this change too: https://reviews.llvm.org/D49754#1364865? We would prefer to continue using Linux target to be

[clang-tools-extra] r352509 - [clangd] Make -clang-tidy-checks a non-hidden command-line arg

Author: ibiryukov Date: Tue Jan 29 07:52:05 2019 New Revision: 352509 URL: http://llvm.org/viewvc/llvm-project?rev=352509=rev Log: [clangd] Make -clang-tidy-checks a non-hidden command-line arg Summary: This looks like a useful user-facing configuration parameter, which should be discoverable.

[PATCH] D57384: [clangd] Make -clang-tidy-checks a non-hidden command-line arg

This revision was automatically updated to reflect the committed changes. Closed by commit rL352509: [clangd] Make -clang-tidy-checks a non-hidden command-line arg (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

Re: r346652 - Make clang-based tools find libc++ on MacOS

So this happens because c-index-test would silently drop argv[0] and not pass it to the driver (this happens in write_pch_file from 'c-index-test.'c). The fix that comes to mind is starting to pas argv[0] there (it's simple apart from argv manipulation in C, which might require some boilerplate).

[PATCH] D57162: [DEBUG_INFO][NVPTX] Generate correct data about variable address class.

ABataev added a comment. Ping! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57162/new/ https://reviews.llvm.org/D57162 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D57388: [clangd] Implement textDocument/declaration from LSP 3.14

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ioeric, javed.absar, ilya-biryukov. LSP now reflects the declaration/definition distinction. Language server changes: - textDocument/definition now

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

jhibbits added a comment. Hi Kei, that's fantastic! There's one more thing to add to this, which is to predefine __NO_FPRS__, and it should be a good replacement for gcc for 90+% of cases. I'll add your changes and this, and resubmit this review. Thanks for all your help! Repository: rC

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

MyDeveloperDay added a comment. I checked this out and built this and it works really well. The thing I really like is that it helps to format Windows resource include files e.g. 'Resource.h' better than before. Which changes the current clang-formatted version #define

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

kthomsen added a comment. With this modification for SPE in VAARG, I was now able to compile all OS-9 libraries for SPE and tested them with whetstone. The results of the whetstone are the same like with a real FPU and they are correctly shown with printf. Also the performance of CLANG is about

[PATCH] D57384: [clangd] Make -clang-tidy-checks a non-hidden command-line arg

ilya-biryukov created this revision. ilya-biryukov added a reviewer: hokein. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric. This looks like a useful user-facing configuration parameter, which should be discoverable. Also fix a small typo in the description.

[PATCH] D57223: [Tooling] Handle #pragma once header guard in include insertion.

This revision was automatically updated to reflect the committed changes. Closed by commit rL352503: [Tooling] Handle #pragma once header guard in include insertion. (authored by ioeric, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

r352503 - [Tooling] Handle #pragma once header guard in include insertion.

Author: ioeric Date: Tue Jan 29 06:40:01 2019 New Revision: 352503 URL: http://llvm.org/viewvc/llvm-project?rev=352503=rev Log: [Tooling] Handle #pragma once header guard in include insertion. Reviewers: ilya-biryukov Subscribers: cfe-commits Differential Revision:

[PATCH] D57223: [Tooling] Handle #pragma once header guard in include insertion.

ioeric updated this revision to Diff 184076. ioeric marked an inline comment as done. ioeric added a comment. - fix typo Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57223/new/ https://reviews.llvm.org/D57223 Files: lib/Tooling/Inclusions/HeaderIncludes.cpp

[clang-tools-extra] r352501 - [clangd] Unit test for sourceLocationInMainFile.

Author: ibiryukov Date: Tue Jan 29 06:31:19 2019 New Revision: 352501 URL: http://llvm.org/viewvc/llvm-project?rev=352501=rev Log: [clangd] Unit test for sourceLocationInMainFile. This should have been part of r352494, which added the corresponding function. The unit test ended up as a separate

[PATCH] D56267: [clangd] Interfaces for writing code actions

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE352494: [clangd] Interfaces for writing code tweaks (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D56267?vs=184039=184074#toc Repository: rCTE Clang

[clang-tools-extra] r352494 - [clangd] Interfaces for writing code tweaks

Author: ibiryukov Date: Tue Jan 29 06:17:36 2019 New Revision: 352494 URL: http://llvm.org/viewvc/llvm-project?rev=352494=rev Log: [clangd] Interfaces for writing code tweaks Summary: The code tweaks are an implementation of mini-refactorings exposed via the LSP code actions. They run in two

Re: [libunwind] r352016 - [libunwind] Don't abort if encoutering invalid .eh_frame_hdr

Should we merge this to 8.0? On Wed, Jan 23, 2019 at 10:04 PM Petr Hosek via cfe-commits wrote: > > Author: phosek > Date: Wed Jan 23 19:04:42 2019 > New Revision: 352016 > > URL: http://llvm.org/viewvc/llvm-project?rev=352016=rev > Log: > [libunwind] Don't abort if encoutering invalid

[PATCH] D57380: [clang-tools-extra] add missing .clang-format and .clang-tidy for use with git monorepo

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: JonasToth, alexfh, hokein, aaron.ballman. MyDeveloperDay added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Before git monorepo, clang-tools-extra inherited its .clang-format and .clang-tidy files from

Re: r351740 - [AArch64] Use LL for 64-bit intrinsic arguments

Thanks! I'll merge it after it's been in trunk for a little. Please let me know if there are any issues or follow-up commits. Cheers, Hans On Tue, Jan 29, 2019 at 4:04 AM Sam Parker wrote: > > Hi Hans, > > > I've recommitted the change in r352463. > > > cheers, > > Sam > > > Sam Parker > >

[PATCH] D57369: [CUDA][HIP] Do not diagnose use of _Float16

This revision was automatically updated to reflect the committed changes. Closed by commit rC352488: [CUDA][HIP] Do not diagnose use of _Float16 (authored by yaxunl, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57369/new/

r352488 - [CUDA][HIP] Do not diagnose use of _Float16

Author: yaxunl Date: Tue Jan 29 05:20:23 2019 New Revision: 352488 URL: http://llvm.org/viewvc/llvm-project?rev=352488=rev Log: [CUDA][HIP] Do not diagnose use of _Float16 r352221 caused regressions in CUDA/HIP since device function may use _Float16 whereas host does not support it. In this

[PATCH] D57343: lit: Let lit.util.which() return a normcase()ed path

thakis added a comment. In D57343#1374063 , @zturner wrote: > Shouldn't the hash be case-insensitive on windows? I'm not sure: I think case-sensitive file systems on Windows are becoming more common with WSL. This seemed like the less intrusive change

r352486 - Re-commit "[AST] Introduce GenericSelectionExpr::Association"

Author: brunoricci Date: Tue Jan 29 04:57:11 2019 New Revision: 352486 URL: http://llvm.org/viewvc/llvm-project?rev=352486=rev Log: Re-commit "[AST] Introduce GenericSelectionExpr::Association" This time with a fix to make gcc 4.8 happy. Modified: cfe/trunk/include/clang/AST/Expr.h

[PATCH] D57106: [AST] Introduce GenericSelectionExpr::Association

riccibruno marked an inline comment as done. riccibruno added a comment. In D57106#1375142 , @steveire wrote: > This was subsequently reverted. Is there a status update? Rebasing and > committing D56959 would unblock

[PATCH] D57057: [clangd] Log clang-tidy configuration, NFC

hokein added a comment. In D57057#1375249 , @sammccall wrote: > This turns out to be excessively spammy in unit tests, can we change this to > dlog()? Sure, done in rL352485 . Repository: rL LLVM CHANGES SINCE

[clang-tools-extra] r352485 - [clangd] dlog clang-tidy configuration

Author: hokein Date: Tue Jan 29 04:32:32 2019 New Revision: 352485 URL: http://llvm.org/viewvc/llvm-project?rev=352485=rev Log: [clangd] dlog clang-tidy configuration vlog seems to be too spammy in unittests. Modified: clang-tools-extra/trunk/clangd/ClangdUnit.cpp Modified:

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

VelocityRa updated this revision to Diff 184010. VelocityRa added a comment. I extracted the logic of `AlignTokens` and `AlignTokenSequence` that aligning macros uses to the best of my ability. This new logic now resides in `AlignTokensAll` and `AlignTokenSequenceAll` (so that it may be

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

vit9696 added a comment. Thanks for pointing it out. You could use hasFeature from there during construction: return SetCGInfo( new PPC32TargetCodeGenInfo(Types, CodeGenOpts.FloatABI == "soft" || getTarget().hasFeature("spe"))); It works for me, but probably a separate argument is

[PATCH] D57057: [clangd] Log clang-tidy configuration, NFC

sammccall added a comment. This turns out to be excessively spammy in unit tests, can we change this to dlog()? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57057/new/ https://reviews.llvm.org/D57057 ___

[PATCH] D57228: [clangd] Make USRs for macros to be position independent

This revision was automatically updated to reflect the committed changes. Closed by commit rL352481: [clangd] Make USRs for macros to be position independent (authored by kadircet, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

[clang-tools-extra] r352481 - [clangd] Make USRs for macros to be position independent

Author: kadircet Date: Tue Jan 29 03:19:15 2019 New Revision: 352481 URL: http://llvm.org/viewvc/llvm-project?rev=352481=rev Log: [clangd] Make USRs for macros to be position independent Summary: USRs for macros were not cannonical due to usage of cursor location instead of definition location.

[PATCH] D56723: [CodeComplete] Propagate preferred types through parser in more cases

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM from my side CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56723/new/ https://reviews.llvm.org/D56723 ___ cfe-commits mailing

[PATCH] D57101: [OpenCL] Add generic addr space to the return of implicit assingment

Anastasia updated this revision to Diff 184052. Anastasia retitled this revision from "[AST] Fix addr space of result type for dereference operator " to "[OpenCL] Add generic addr space to the return of implicit assingment ". Anastasia edited the summary of this revision. Anastasia added a

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

kthomsen added a comment. The desired function for this va_arg is not in lib/Target/PowerPC/*.cpp, it is in tools/clang/lib/CodeGen/TargetInfo.cpp , a little bit unexpected to me. PPC32_SVR4_ABIInfo::EmitVAArg() is doing the va_arg handling. For testing, I have added a hasSPE = true and treat

Re: r346652 - Make clang-based tools find libc++ on MacOS

This change got reverted, but the follow-up r348365 might be causing the issues. I wonder why the Driver can't detect install dir on its own, will take a look, thanks. On Mon, Jan 28, 2019 at 7:20 PM Nico Weber wrote: > This seems to fix it, but I don't know if it's the right fix: > > diff

[PATCH] D57230: [analyzer] Toning down invalidation a bit

xazax.hun added a comment. Thanks for all the reviews. Do you have any preference about the spelling of the annotation mentioned in the description? There were two ideas so far: `uses_offsetof`, `may_use_offsetof` While I like those, I wonder if it is a good idea to have `offsetof` in the

[PATCH] D57230: [analyzer] Toning down invalidation a bit

This revision was automatically updated to reflect the committed changes. Closed by commit rL352473: [analyzer] Toning down invalidation a bit (authored by xazax, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r352473 - [analyzer] Toning down invalidation a bit

Author: xazax Date: Tue Jan 29 02:27:14 2019 New Revision: 352473 URL: http://llvm.org/viewvc/llvm-project?rev=352473=rev Log: [analyzer] Toning down invalidation a bit When a function takes the address of a field the analyzer will no longer assume that the function will change other fields of

[PATCH] D52984: [analyzer] Checker reviewer's checklist

This revision was automatically updated to reflect the committed changes. Closed by commit rL352470: [analyzer] Added a checklist to help checker authors and reviewers (authored by xazax, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r352470 - [analyzer] Added a checklist to help checker authors and reviewers

Author: xazax Date: Tue Jan 29 02:21:49 2019 New Revision: 352470 URL: http://llvm.org/viewvc/llvm-project?rev=352470=rev Log: [analyzer] Added a checklist to help checker authors and reviewers Differential Revision: https://reviews.llvm.org/D52984 Modified:

[PATCH] D56612: [clangd] A code action to remove 'using namespace'

ilya-biryukov updated this revision to Diff 184043. ilya-biryukov added a comment. - Update license header CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56612/new/ https://reviews.llvm.org/D56612 Files: clang-tools-extra/clangd/AST.cpp clang-tools-extra/clangd/AST.h

[PATCH] D56611: [clangd] A code action to swap branches of an if statement

ilya-biryukov updated this revision to Diff 184041. ilya-biryukov added a comment. - Update the license header CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56611/new/ https://reviews.llvm.org/D56611 Files: clang-tools-extra/clangd/SourceCode.cpp

[PATCH] D56610: [clangd] A code action to qualify an unqualified name

ilya-biryukov updated this revision to Diff 184040. ilya-biryukov added a comment. - Update license header CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56610/new/ https://reviews.llvm.org/D56610 Files: clang-tools-extra/clangd/refactor/tweaks/CMakeLists.txt

r352468 - [analyzer] Fix a typo in docs

Author: xazax Date: Tue Jan 29 02:15:52 2019 New Revision: 352468 URL: http://llvm.org/viewvc/llvm-project?rev=352468=rev Log: [analyzer] Fix a typo in docs Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/CheckerDocumentation.cpp Modified:

[PATCH] D56267: [clangd] Interfaces for writing code actions

ilya-biryukov updated this revision to Diff 184039. ilya-biryukov added a comment. - Update license headers in new files - Add an empty cpp file to avoid cmake errors due to empty inputs - clang-format - Update the 'fixits-command.test' to unbreak it (the line number was larger than the number

[PATCH] D46421: [analyzer][CrossTU] Extend CTU to VarDecls with initializer

r.stahl added a comment. In D46421#1374807 , @NoQ wrote: > At the same time, i don't have any test cases for the actual change in > behavior that such canonicalization causes. If the test case that you had in > mind is indeed demonstrating this problem,

[PATCH] D57106: [AST] Introduce GenericSelectionExpr::Association

steveire added a comment. This was subsequently reverted. Is there a status update? Rebasing and committing D56959 would unblock traverser work and would allow this to progress separately in parallel. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D56723: [CodeComplete] Propagate preferred types through parser in more cases

ilya-biryukov updated this revision to Diff 184038. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - Get rid of the RAII object CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56723/new/ https://reviews.llvm.org/D56723 Files:

[PATCH] D56723: [CodeComplete] Propagate preferred types through parser in more cases

ilya-biryukov marked 2 inline comments as done. ilya-biryukov added inline comments. Comment at: clang/include/clang/Sema/Sema.h:319-346 +class PreferredTypeBuilder::RestoreRAII { +public: + RestoreRAII(RestoreRAII const &) = delete; + RestoreRAII =(RestoreRAII const &) =

[PATCH] D57330: Adjust documentation for git migration.

labath added a comment. I am not sure we should be recommending to people to place the build folder under the llvm-project checkout. Is that how people use the monorepo build nowadays? This is not an full out-of-source build, since the build folder is still a subfolder of the repo root (and

Re: r351740 - [AArch64] Use LL for 64-bit intrinsic arguments

Hi Hans, I've recommitted the change in r352463. cheers, Sam Sam Parker Compilation Tools Engineer | Arm . . . . . . . . . . . . . . . . . . . . . . . . . . . Arm.com From: Hans Wennborg Sent: 25 January 2019 18:26:48 To: Sam Parker Cc: cfe-commits

[PATCH] D56852: [AArch64] Use LL for 64-bit arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rL352463: [AArch64] Update int64_t ACLE builtin arguments (authored by sam_parker, committed by ). Changed prior to commit: https://reviews.llvm.org/D56852?vs=183820=184031#toc Repository: rL LLVM

r352463 - [AArch64] Update int64_t ACLE builtin arguments

Author: sam_parker Date: Tue Jan 29 01:04:03 2019 New Revision: 352463 URL: http://llvm.org/viewvc/llvm-project?rev=352463=rev Log: [AArch64] Update int64_t ACLE builtin arguments Re-applying r351740 with fixes (changing LL to W). Differential Revision: https://reviews.llvm.org/D56852

[PATCH] D57001: [libunwind] Don't define unw_fpreg_t to uint64_t for __ARM_DWARF_EH__

This revision was automatically updated to reflect the committed changes. Closed by commit rUNW352461: Dont define unw_fpreg_t to uint64_t for __ARM_DWARF_EH__ (authored by mstorsjo, committed by ). Repository: rUNW libunwind CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57001/new/

[libunwind] r352461 - Don't define unw_fpreg_t to uint64_t for __ARM_DWARF_EH__

Author: mstorsjo Date: Tue Jan 29 01:00:32 2019 New Revision: 352461 URL: http://llvm.org/viewvc/llvm-project?rev=352461=rev Log: Don't define unw_fpreg_t to uint64_t for __ARM_DWARF_EH__ The existing typedef of unw_fpreg_t to uint64_t might work and be correct for the ARM_EHABI case, but for

[PATCH] D56928: Support attribute used in member funcs of class templates

rafauler updated this revision to Diff 184029. rafauler added a comment. Rebase + Aaron's suggestions. Thanks for the suggestions! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56928/new/ https://reviews.llvm.org/D56928 Files:

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

vit9696 added a comment. Right, I noticed the same thing yesterday. There is an override calling LowerVAARG for 64-bit integers, yet that is not a thing that does lowering for all the rest. I believe it is derived somewhere from td calling conventions. I will check it out later this evening

<    1   2