r352733 - Revert "[CMake] Unify scripts for generating VCS headers"

Author: phosek Date: Wed Jan 30 23:12:43 2019 New Revision: 352733 URL: http://llvm.org/viewvc/llvm-project?rev=352733=rev Log: Revert "[CMake] Unify scripts for generating VCS headers" This reverts commits r352729 and r352731: this broke Sanitizer Windows bots Modified:

r352729 - [CMake] Unify scripts for generating VCS headers

Author: phosek Date: Wed Jan 30 22:21:01 2019 New Revision: 352729 URL: http://llvm.org/viewvc/llvm-project?rev=352729=rev Log: [CMake] Unify scripts for generating VCS headers Previously, there were two different scripts for generating VCS headers: one used by LLVM and one used by Clang. They

[PATCH] D57497: [RISCV] Passing -G value to RISCV backend

shiva0217 created this revision. shiva0217 added reviewers: asb, apazos. Herald added subscribers: jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, kito-cheng, niosHD, sabuasal, simoncook, johnrusso, rbar. Passing -G value to

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

craig.topper commandeered this revision. craig.topper edited reviewers, added: jyu2; removed: craig.topper. craig.topper added a comment. Commandeering so I can update to match an IRBuilder interface change in the llvm patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56571/new/

[PATCH] D56935: [NewPM] Add support for new-PM plugins to clang

melver added a comment. Gentle ping. Need someone to land this on my behalf, as I do not have commit access. Many thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56935/new/ https://reviews.llvm.org/D56935 ___ cfe-commits mailing

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

craig.topper updated this revision to Diff 184447. craig.topper added a comment. Pass FunctionType into the IRBuilder::CreateCallBr to avoid needing to make an opaque pointer update later CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56571/new/ https://reviews.llvm.org/D56571 Files:

[PATCH] D51329: [Attribute/Diagnostics] Print macro instead of whole attribute for address_space

leonardchan added inline comments. Comment at: clang/lib/AST/Type.cpp:382-386 +QualType QualType::IgnoreMacroDefinitions(QualType T) { + while (const auto *MDT = T->getAs()) +T = MDT->getUnderlyingType(); + return T; +} rsmith wrote: > This doesn't seem

[PATCH] D51329: [Attribute/Diagnostics] Print macro instead of whole attribute for address_space

leonardchan updated this revision to Diff 184439. leonardchan marked 15 inline comments as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51329/new/ https://reviews.llvm.org/D51329 Files: clang/include/clang/AST/ASTContext.h

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Dosi-Dough updated this revision to Diff 184437. Dosi-Dough added a comment. based on feedback: fixed whitespacing / formatting. Removed .DS_Store Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/ https://reviews.llvm.org/D57435 Files:

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Eugene.Zelenko added inline comments. Comment at: clang-tidy/abseil/WrapUniqueCheck.cpp:80 + if (cons) { +if (cons->isListInitialization()) { + return; Please elide braces. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Dosi-Dough updated this revision to Diff 184431. Dosi-Dough marked 11 inline comments as done. Dosi-Dough added a comment. fixed white space/ formatting issues. removed .DS_Store. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/ https://reviews.llvm.org/D57435 Files:

[PATCH] D57487: [CUDA] Propagate detected version of CUDA to cc1

tra updated this revision to Diff 184416. tra added a comment. Addressed Justin's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57487/new/ https://reviews.llvm.org/D57487 Files: clang/include/clang/Basic/Cuda.h clang/include/clang/Basic/TargetOptions.h

[PATCH] D57086: Ignore trailing NullStmts in StmtExprs for GCC compatibility

domdom marked an inline comment as not done. domdom added inline comments. Comment at: clang/include/clang/AST/Stmt.h:1259 + // the index of the last one. + unsigned getLastNonNullStmt() const { +assert(!body_empty() && "getLastNonNullStmt"); aaron.ballman

[PATCH] D57488: [CUDA] add support for the new kernel launch API in CUDA-9.2+.

jlebar accepted this revision. jlebar added a comment. This revision is now accepted and ready to land. LGTM, mostly nits. Comment at: clang/include/clang/Sema/Sema.h:10316 + /// Returns the name of the launch configuration function. + std::string

[PATCH] D57086: Ignore trailing NullStmts in StmtExprs for GCC compatibility

domdom updated this revision to Diff 184414. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57086/new/ https://reviews.llvm.org/D57086 Files: clang/include/clang/AST/Stmt.h clang/lib/CodeGen/CGStmt.cpp clang/lib/Parse/ParseStmt.cpp clang/lib/Sema/SemaExpr.cpp

[PATCH] D57086: Ignore trailing NullStmts in StmtExprs for GCC compatibility

domdom updated this revision to Diff 184413. domdom marked 6 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57086/new/ https://reviews.llvm.org/D57086 Files: clang/include/clang/AST/Stmt.h clang/lib/CodeGen/CGStmt.cpp Index: clang/lib/CodeGen/CGStmt.cpp

[PATCH] D57487: [CUDA] Propagate detected version of CUDA to cc1

jlebar accepted this revision. jlebar added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Basic/Cuda.h:108 +enum class CudaFeature { + CUDA_USES_NEW_LAUNCH, +}; Should this enum be documented?

[PATCH] D55673: [darwin] parse the SDK settings from SDKSettings.json if it exists and pass in the -target-sdk-version to the compiler and backend

tra added a comment. > I would be ok with reusing that option, as long as it's documented that there > is a difference in terms of how it can be used. The patch is in https://reviews.llvm.org/D57487 It does not look like we're formally documenting CC1 options anywhere. I've added some comments

[PATCH] D57487: [CUDA] Propagate detected version of CUDA to cc1

tra updated this revision to Diff 184412. tra added a comment. Updated the comment about SDKVersion use. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57487/new/ https://reviews.llvm.org/D57487 Files: clang/include/clang/Basic/Cuda.h clang/include/clang/Basic/TargetOptions.h

[PATCH] D57343: lit: Let lit.util.which() return a normcase()ed path

This revision was automatically updated to reflect the committed changes. Closed by commit rL352704: lit: Let lit.util.which() return a normcase()ed path (authored by nico, committed by ). Changed prior to commit: https://reviews.llvm.org/D57343?vs=183912=184408#toc Repository: rL LLVM

r352690 - [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls

Author: yln Date: Wed Jan 30 15:42:13 2019 New Revision: 352690 URL: http://llvm.org/viewvc/llvm-project?rev=352690=rev Log: [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls Summary: UBSan wants to detect when unreachable code is actually reached, so it

[PATCH] D57488: [CUDA] add support for the new kernel launch API in CUDA-9.2+.

tra created this revision. tra added a reviewer: jlebar. Herald added subscribers: bixia, sanjoy. Instead of calling CUDA runtime to arrange function arguments, the new API constructs arguments in a local array and the kernels are launched with __cudaLaunchKernel(). The old API has been

[PATCH] D57487: [CUDA] Propagate detected version of CUDA to cc1

tra created this revision. tra added a reviewer: jlebar. Herald added subscribers: bixia, sanjoy. ..and use it to control that parts of CUDA compilation that depend on the specific version of CUDA SDK. This patch has a placeholder for a 'new launch API' support which is in a separate patch (I'll

[PATCH] D56581: [ASTImporter] Set the described template if not set

shafik added a comment. @martong have you had a chance to look at this some more? We ran into another problem that this fixes partially. Can I help in any way? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56581/new/ https://reviews.llvm.org/D56581

r352693 - [analyzer] Make NullReturnedFromNonnullChecker depend on NullabilityBase

Author: szelethus Date: Wed Jan 30 15:48:37 2019 New Revision: 352693 URL: http://llvm.org/viewvc/llvm-project?rev=352693=rev Log: [analyzer] Make NullReturnedFromNonnullChecker depend on NullabilityBase Accidentally left this dependency out after D54438. Added:

[PATCH] D57278: [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls

This revision was automatically updated to reflect the committed changes. Closed by commit rC352690: [Sanitizers] UBSan unreachable incompatible with ASan in the presence of… (authored by yln, committed by ). Changed prior to commit: https://reviews.llvm.org/D57278?vs=184168=184393#toc

[PATCH] D57464: Generalize method overloading on addr spaces to C++

ebevhan added inline comments. Comment at: lib/Parse/ParseDeclCXX.cpp:2309 + attr.getScopeName(), attr.getScopeLoc(), , + attr.getNumArgs(), ParsedAttr::AS_GNU); +attr.setInvalid(); Are we

[PATCH] D57476: [CodeGenObjC] Use an invoke instead of a call when calling `objc_alloc` or `objc_allocWithZone`

This revision was automatically updated to reflect the committed changes. Closed by commit rC352687: [CodeGenObjC] Handle exceptions when calling objc_alloc or objc_allocWithZone (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D57476?vs=184381=184385#toc

[PATCH] D56650: [lld] [ELF] Support customizing behavior on target triple

krytarowski added a comment. > chandlerc added a comment. > > There was a long discussion between two NetBSD maintainers about this (both > already in the reviewers list of this patch). I'm not sure if there is an > existing thread that would be better to follow up on as opposed to starting a

[libunwind] r352688 - [CMake] Use correct visibility for linked libraries in CMake

Author: phosek Date: Wed Jan 30 15:18:05 2019 New Revision: 352688 URL: http://llvm.org/viewvc/llvm-project?rev=352688=rev Log: [CMake] Use correct visibility for linked libraries in CMake When linking library dependencies, we shouldn't need to export linked libraries to dependents. We should be

r352687 - [CodeGenObjC] Handle exceptions when calling objc_alloc or objc_allocWithZone

Author: epilk Date: Wed Jan 30 15:17:38 2019 New Revision: 352687 URL: http://llvm.org/viewvc/llvm-project?rev=352687=rev Log: [CodeGenObjC] Handle exceptions when calling objc_alloc or objc_allocWithZone objc_alloc and objc_allocWithZone may throw exceptions if the underlying method does. If

[PATCH] D57476: [CodeGenObjC] Use an invoke instead of a call when calling `objc_alloc` or `objc_allocWithZone`

pete accepted this revision. pete added a comment. This revision is now accepted and ready to land. LGTM. Thanks for fixing this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57476/new/ https://reviews.llvm.org/D57476 ___ cfe-commits

[PATCH] D57476: [CodeGenObjC] Use an invoke instead of a call when calling `objc_alloc` or `objc_allocWithZone`

erik.pilkington updated this revision to Diff 184381. erik.pilkington added a comment. Fix a mistake in the tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57476/new/ https://reviews.llvm.org/D57476 Files: clang/lib/CodeGen/CGObjC.cpp

[PATCH] D57476: [CodeGenObjC] Use an invoke instead of a call when calling `objc_alloc` or `objc_allocWithZone`

erik.pilkington marked an inline comment as done. erik.pilkington added inline comments. Comment at: clang/test/CodeGenObjC/convert-messages-to-runtime-calls.m:43-44 +void check_invoke() { + // MSGS: {{call.*@objc_msgSend}} + // MSGS: {{call.*@objc_msgSend}} + // CALLS:

[PATCH] D57476: [CodeGenObjC] Use an invoke instead of a call when calling `objc_alloc` or `objc_allocWithZone`

erik.pilkington created this revision. erik.pilkington added reviewers: rjmccall, pete, ahatanak. Herald added subscribers: dexonsmith, jkorous. `objc_alloc` and `objc_allocWithZone` may throw exceptions if the underlying method does. If we're in a `@try` block, then make sure we emit an

[PATCH] D57474: Update SanitizerCoverage doc regarding the issue with pc-table and gc-sections.

Dor1s added a comment. I'm not sure if I wrote down the information correctly, PTAL :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57474/new/ https://reviews.llvm.org/D57474 ___ cfe-commits mailing list

[PATCH] D57474: Update SanitizerCoverage doc regarding the issue with pc-table and gc-sections.

Dor1s created this revision. Dor1s added a reviewer: morehouse. Herald added a subscriber: cfe-commits. There is a bug for this: https://bugs.llvm.org/show_bug.cgi?id=34636 But it would be also helpful to leave a note in the docs to prevent users from running into issues, e.g.

[PATCH] D57472: [AST] Extract ASTDumpTraverser class from ASTDumper

steveire marked an inline comment as done. steveire added inline comments. Comment at: lib/AST/ASTDumper.cpp:63 - if (const auto *C = dyn_cast(D)) -for (const auto *I : C->inits()) - Visit(I); - - if (D->doesThisDeclarationHaveABody()) -

[PATCH] D56932: [Driver] [NetBSD] Pass default library search paths to linker

chandlerc added a comment. There was a long discussion between two NetBSD maintainers about this (both already in the reviewers list of this patch). I'm not sure if there is an existing thread that would be better to follow up on as opposed to starting a fresh thread. I think the question

[PATCH] D57472: [AST] Extract ASTDumpTraverser class from ASTDumper

steveire updated this revision to Diff 184363. steveire added a comment. Fix comment Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57472/new/ https://reviews.llvm.org/D57472 Files: include/clang/AST/ASTDumpTraverser.h lib/AST/ASTDumper.cpp Index:

[PATCH] D57472: [AST] Extract ASTDumpTraverser class from ASTDumper

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added subscribers: cfe-commits, jfb. This new traverser class allows clients to re-use the traversal logic which was previously part of ASTDumper. This means that alternative visit logic may be implemented, such as

r352676 - [ASTDump] Inline traverse methods into class

Author: steveire Date: Wed Jan 30 13:48:32 2019 New Revision: 352676 URL: http://llvm.org/viewvc/llvm-project?rev=352676=rev Log: [ASTDump] Inline traverse methods into class This API will be extracted into a new template class. This change will make the follow-up commit easier to review.

[PATCH] D57458: [docs][mips] Clang 8.0 Release notes

This revision was automatically updated to reflect the committed changes. Closed by commit rL352675: [docs][mips] Clang 8.0 Release notes (authored by atanasyan, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

Re: r352672 - Don't define __has_feature(objc_fixed_enum) in non-objc mode

Hans, can you cherry-pick this into LLVM 8? Thanks! On 1/30/19 1:14 PM, Erik Pilkington via cfe-commits wrote: Author: epilk Date: Wed Jan 30 13:14:08 2019 New Revision: 352672 URL: http://llvm.org/viewvc/llvm-project?rev=352672=rev Log: Don't define __has_feature(objc_fixed_enum) in non-objc

[PATCH] D52339: Support enums with a fixed underlying type in all language modes

erik.pilkington added a comment. In D52339#1377527 , @arphaman wrote: > @erik.pilkington the change to make `objc_fixed_enum` true in non-ObjC mode > turned out to be problematic for our adoption. Could you please fix it before > LLVM8 is wrapped up so

r352672 - Don't define __has_feature(objc_fixed_enum) in non-objc mode

Author: epilk Date: Wed Jan 30 13:14:08 2019 New Revision: 352672 URL: http://llvm.org/viewvc/llvm-project?rev=352672=rev Log: Don't define __has_feature(objc_fixed_enum) in non-objc mode This is only a formal language feature in ObjC, otherwise its just an extension. Making this change was also

[PATCH] D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class

baloghadamsoftware added a comment. In D57100#1373440 , @JonasToth wrote: > @baloghadamsoftware Do you see any problems with the refactoring, especially > the new `FunctionDecl*`-Caching is not exactly a refactoring. If you have any > thoughts on that

r352669 - [OPENMP]Fix PR40536: Do not emit __kmpc_push_target_tripcount if not

Author: abataev Date: Wed Jan 30 12:49:52 2019 New Revision: 352669 URL: http://llvm.org/viewvc/llvm-project?rev=352669=rev Log: [OPENMP]Fix PR40536: Do not emit __kmpc_push_target_tripcount if not required. Function __kmpc_push_target_tripcount should be emitted only if the offloading entry is

[PATCH] D56760: Add a new builtin: __builtin_dynamic_object_size

This revision was automatically updated to reflect the committed changes. Closed by commit rL352665: Add a new builtin: __builtin_dynamic_object_size (authored by epilk, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D56650: [lld] [ELF] Support customizing behavior on target triple

krytarowski added a comment. In D56650#1377546 , @ruiu wrote: > If you still need to patch GNU ld, it doesn't seems like this patch makes > things easier for you. (But even if this would make it easier for you, this > patch's approach is not okay by

r352664 - Add a 'dynamic' parameter to the objectsize intrinsic

Author: epilk Date: Wed Jan 30 12:34:35 2019 New Revision: 352664 URL: http://llvm.org/viewvc/llvm-project?rev=352664=rev Log: Add a 'dynamic' parameter to the objectsize intrinsic This is meant to be used with clang's __builtin_dynamic_object_size. When 'true' is passed to this parameter, the

r352665 - Add a new builtin: __builtin_dynamic_object_size

Author: epilk Date: Wed Jan 30 12:34:53 2019 New Revision: 352665 URL: http://llvm.org/viewvc/llvm-project?rev=352665=rev Log: Add a new builtin: __builtin_dynamic_object_size This builtin has the same UI as __builtin_object_size, but has the potential to be evaluated dynamically. It is meant to

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

jyu2 updated this revision to Diff 184349. jyu2 marked an inline comment as done. jyu2 added a comment. Change test for BE IR change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56571/new/ https://reviews.llvm.org/D56571 Files: include/clang/AST/Expr.h

[PATCH] D57353: [clang-tidy] Add the abseil-duration-double-conversion check

hwright marked 2 inline comments as done. hwright added inline comments. Comment at: docs/clang-tidy/checks/abseil-duration-double-conversion.rst:20 + + + // Original - Conversion to integer and back again MyDeveloperDay wrote: > hwright wrote: > >

LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D56650: [lld] [ELF] Support customizing behavior on target triple

krytarowski added a comment. If we pass flags from clang, we sacrifice: - lld usable as a standalone executable - gcc capable to use lld as a functional linker - clang driver not capable to call unpatched gnu ld/gold as we grow local flags to workaroud the customization (such as -z nognustack)

r352663 - [ASTDump] Make method definition order matches declaration order

Author: steveire Date: Wed Jan 30 12:06:52 2019 New Revision: 352663 URL: http://llvm.org/viewvc/llvm-project?rev=352663=rev Log: [ASTDump] Make method definition order matches declaration order This will make follow-up changes easier to review. Modified: cfe/trunk/lib/AST/ASTDumper.cpp

r352661 - [ASTDump] Re-arrange method declarations to group Visit together

Author: steveire Date: Wed Jan 30 12:03:47 2019 New Revision: 352661 URL: http://llvm.org/viewvc/llvm-project?rev=352661=rev Log: [ASTDump] Re-arrange method declarations to group Visit together This will make follow-up commits easier to review. Modified: cfe/trunk/lib/AST/ASTDumper.cpp

[libunwind] r352658 - Revert "[CMake] Use correct visibility for linked libraries in CMake"

Author: phosek Date: Wed Jan 30 11:51:18 2019 New Revision: 352658 URL: http://llvm.org/viewvc/llvm-project?rev=352658=rev Log: Revert "[CMake] Use correct visibility for linked libraries in CMake" This reverts commit r352654: this broke libcxx and sanitizer bots. Modified:

r352657 - [ASTDump] Rename methods which are conceptually Visits

Author: steveire Date: Wed Jan 30 11:49:49 2019 New Revision: 352657 URL: http://llvm.org/viewvc/llvm-project?rev=352657=rev Log: [ASTDump] Rename methods which are conceptually Visits This is consistent with the TextNodeDumper, and is the appropriate name for the traverser class which will be

r352656 - [ASTDump] NFC: Inline vestigial methods

Author: steveire Date: Wed Jan 30 11:41:04 2019 New Revision: 352656 URL: http://llvm.org/viewvc/llvm-project?rev=352656=rev Log: [ASTDump] NFC: Inline vestigial methods This was a porting aid. Modified: cfe/trunk/lib/AST/ASTDumper.cpp Modified: cfe/trunk/lib/AST/ASTDumper.cpp URL:

[PATCH] D57419: [ASTDump] Move Decl node dumping to TextNodeDumper

steveire added a comment. In D57419#1377187 , @lebedev.ri wrote: > Needs rebasing for rL352631 . Thanks. Rebased and re-tested. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57419/new/

r352655 - [ASTDump] Move Decl node dumping to TextNodeDumper

Author: steveire Date: Wed Jan 30 11:32:48 2019 New Revision: 352655 URL: http://llvm.org/viewvc/llvm-project?rev=352655=rev Log: [ASTDump] Move Decl node dumping to TextNodeDumper Reviewers: aaron.ballman Subscribers: jfb, cfe-commits Differential Revision: https://reviews.llvm.org/D57419

[PATCH] D57419: [ASTDump] Move Decl node dumping to TextNodeDumper

This revision was automatically updated to reflect the committed changes. Closed by commit rL352655: [ASTDump] Move Decl node dumping to TextNodeDumper (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D56650: [lld] [ELF] Support customizing behavior on target triple

ruiu added a comment. If you still need to patch GNU ld, it doesn't seems like this patch makes things easier for you. (But even if this would make it easier for you, this patch's approach is not okay by design though.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56650/new/

[libunwind] r352654 - [CMake] Use correct visibility for linked libraries in CMake

Author: phosek Date: Wed Jan 30 11:27:26 2019 New Revision: 352654 URL: http://llvm.org/viewvc/llvm-project?rev=352654=rev Log: [CMake] Use correct visibility for linked libraries in CMake When linking library dependencies, we shouldn't need to export linked libraries to dependents. We should be

[PATCH] D52339: Support enums with a fixed underlying type in all language modes

arphaman added a comment. We could introduce a new extension flag like `c_fixed_enum` that can be set for all language modes. `objc_fixed_enum` should apply to ObjC only. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52339/new/ https://reviews.llvm.org/D52339

[PATCH] D53076: [analyzer] Enhance ConditionBRVisitor to write out more information

Charusso added a comment. Thanks you @NoQ! Luckily it is rely on `ProgramPoints` now. The only problem as I see the mentioned Z3-test, where I have no idea what happened. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53076/new/ https://reviews.llvm.org/D53076

[PATCH] D52339: Support enums with a fixed underlying type in all language modes

arphaman added a comment. Herald added a subscriber: jkorous. @erik.pilkington the change to make `objc_fixed_enum` true in non-ObjC mode turned out to be problematic for our adoption. Could you please fix it before LLVM8 is wrapped up so that we don't ship this extension as on by default for

[PATCH] D56650: [lld] [ELF] Support customizing behavior on target triple

mgorny added a comment. In D56650#1377494 , @ruiu wrote: > But that's only adding missing `-L` and perhaps a few more, no? That doesn't > seem too hard to do in gcc. Probably not, provided nobody will block it. I'm not the one opposed to it. > I don't

Re: r352610 - [clang] [Driver] [NetBSD] Append -rpath for shared compiler-rt runtimes

Merged to 8.0 in r352650. On Wed, Jan 30, 2019 at 3:20 AM Michal Gorny via cfe-commits wrote: > > Author: mgorny > Date: Wed Jan 30 00:20:24 2019 > New Revision: 352610 > > URL: http://llvm.org/viewvc/llvm-project?rev=352610=rev > Log: > [clang] [Driver] [NetBSD] Append -rpath for shared

[PATCH] D56650: [lld] [ELF] Support customizing behavior on target triple

ruiu added a comment. But that's only adding missing `-L` and perhaps a few more, no? That doesn't seem too hard to do in gcc. I don't want to repeat what compiler drivers do in the linker. Also, even with this patch, you need to make a change to gcc to pass `--target` parameter to the linker,

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Eugene.Zelenko added inline comments. Comment at: clang-tidy/abseil/AbseilTidyModule.cpp:61 +"abseil-wrap-unique"); + + } Unnecessary empty line. Comment at: clang-tidy/abseil/WrapUniqueCheck.cpp:10 + +#include +#include

[PATCH] D57427: [CodeGen][ObjC] Fix assert on calling `__builtin_constant_p` with ObjC objects.

vsapsai updated this revision to Diff 184334. vsapsai added a comment. - Add in the test `-disable-llvm-passes` and relax FileCheck expectations to accept alloca-store-load. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57427/new/ https://reviews.llvm.org/D57427 Files:

[PATCH] D56650: [lld] [ELF] Support customizing behavior on target triple

mgorny added a comment. I think the main concern is that if we link `ld -> ld.lld`, gcc will no longer work out of the box. So we would have to repeat all the logic in gcc and in any other compiler that calls `ld` directly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56650/new/

[PATCH] D55673: [darwin] parse the SDK settings from SDKSettings.json if it exists and pass in the -target-sdk-version to the compiler and backend

arphaman added a comment. In D55673#1377404 , @tra wrote: > Would that be OK to use target_sdk_version to pass *CUDA* SDK version to the > CC1 compilations? > I have upcoming changes that need to know the version to generate correct > glue IR for CUDA.

[PATCH] D56650: [lld] [ELF] Support customizing behavior on target triple

ruiu added a comment. Kamil, I understand how adding `--target` option to the linker would make target-specific customization easier, but that's as I said not acceptable by design in lld. The code we have for FreeBSD just sets one bit in the output file, and that's fundamentally different

[PATCH] D55673: [darwin] parse the SDK settings from SDKSettings.json if it exists and pass in the -target-sdk-version to the compiler and backend

tra added a comment. Would that be OK to use target_sdk_version to pass *CUDA* SDK version to the CC1 compilations? I have upcoming changes that need to know the version to generate correct glue IR for CUDA. The driver currently figures out detected CUDA version in

[PATCH] D57464: Generalize method overloading on addr spaces to C++

Anastasia created this revision. Anastasia added reviewers: rjmccall, ebevhan. Here is my attempt to generalize the earlier work on method overloading with address spaces https://reviews.llvm.org/D55850 to work in C++ mode (not just OpenCL!). This implementation doesn't apply yet to templated

[PATCH] D57162: [DEBUG_INFO][NVPTX] Generate correct data about variable address class.

tra added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:4235 CGM.getContext().getTargetAddressSpace(D->getType()); +if (CGM.getLangOpts().CUDA && CGM.getLangOpts().CUDAIsDevice) { + if (D->hasAttr()) probinson wrote: > Can a variable

[PATCH] D53329: Generate DIFile with main program if source is not available

yonghong-song abandoned this revision. yonghong-song added a comment. Abandon this patch as the proposed fix is not correct. I have put relative information in the bug https://bugs.llvm.org/show_bug.cgi?id=40170. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D57458: [docs][mips] Clang 8.0 Release notes

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Looks good from my perspective. Let me know if you'd like me to commit, otherwise go and commit directly to the branch when you're ready. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D56932: [Driver] [NetBSD] Pass default library search paths to linker

ruiu added a comment. Looks good but I'm probably not the right person to approve a change to this file. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56932/new/ https://reviews.llvm.org/D56932 ___ cfe-commits

[PATCH] D57458: [docs][mips] Clang 8.0 Release notes

atanasyan created this revision. atanasyan added reviewers: hans, petarj, abeserminji, smaksimovic. Herald added subscribers: arichardson, sdardis. MIPS specific part of Clang 8.0 Release notes. Feel free to add more notes if I miss something. Repository: rC Clang

[PATCH] D57162: [DEBUG_INFO][NVPTX] Generate correct data about variable address class.

probinson added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:4235 CGM.getContext().getTargetAddressSpace(D->getType()); +if (CGM.getLangOpts().CUDA && CGM.getLangOpts().CUDAIsDevice) { + if (D->hasAttr()) Can a variable have one of

[PATCH] D57343: lit: Let lit.util.which() return a normcase()ed path

zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land. I think it's possible to detect the case insensitivity of the file system itself, rather than relying on the operating system which as you point out is neither necessary nor sufficient to

[PATCH] D57343: lit: Let lit.util.which() return a normcase()ed path

thakis added a comment. zturner: ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57343/new/ https://reviews.llvm.org/D57343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Looked this over once more. To me this looks pretty straight-forward. The caching seems ok, too. As long as `ExceptionAnalyzer` does not outlive it's `TU`, everything should be fine.

[PATCH] D57419: [ASTDump] Move Decl node dumping to TextNodeDumper

lebedev.ri added a comment. Needs rebasing for rL352631 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57419/new/ https://reviews.llvm.org/D57419 ___ cfe-commits mailing list

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

VelocityRa added a comment. In D28462#1376710 , @enyquist wrote: > Looks fine to me, although I confess I did not build and run it because I > don't have the time to set up the environment again, took a few hours last > time I built from scratch (side

Re: r352631 - [ASTDumper][OpenMP] CapturedDecl has a 'nothrow' bit

On Wed, Jan 30, 2019 at 10:49 AM Roman Lebedev wrote: > > On Wed, Jan 30, 2019 at 6:46 PM Aaron Ballman wrote: > > > > On Wed, Jan 30, 2019 at 10:41 AM Roman Lebedev via cfe-commits > > wrote: > > > > > > Author: lebedevri > > > Date: Wed Jan 30 07:41:20 2019 > > > New Revision: 352631 > > > >

Re: r352631 - [ASTDumper][OpenMP] CapturedDecl has a 'nothrow' bit

On Wed, Jan 30, 2019 at 6:46 PM Aaron Ballman wrote: > > On Wed, Jan 30, 2019 at 10:41 AM Roman Lebedev via cfe-commits > wrote: > > > > Author: lebedevri > > Date: Wed Jan 30 07:41:20 2019 > > New Revision: 352631 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=352631=rev > > Log: > >

Re: r352631 - [ASTDumper][OpenMP] CapturedDecl has a 'nothrow' bit

On Wed, Jan 30, 2019 at 10:41 AM Roman Lebedev via cfe-commits wrote: > > Author: lebedevri > Date: Wed Jan 30 07:41:20 2019 > New Revision: 352631 > > URL: http://llvm.org/viewvc/llvm-project?rev=352631=rev > Log: > [ASTDumper][OpenMP] CapturedDecl has a 'nothrow' bit > > Summary: > Was trying

[PATCH] D57452: [ASTDumper][OpenMP] CapturedDecl has a 'nothrow' bit

This revision was automatically updated to reflect the committed changes. Closed by commit rL352631: [ASTDumper][OpenMP] CapturedDecl has a nothrow bit (authored by lebedevri, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r352631 - [ASTDumper][OpenMP] CapturedDecl has a 'nothrow' bit

Author: lebedevri Date: Wed Jan 30 07:41:20 2019 New Revision: 352631 URL: http://llvm.org/viewvc/llvm-project?rev=352631=rev Log: [ASTDumper][OpenMP] CapturedDecl has a 'nothrow' bit Summary: Was trying to understand how complicated it would be to write a clang-tidy

[PATCH] D57452: [ASTDumper][OpenMP] CapturedDecl has a 'nothrow' bit

lebedev.ri added a comment. In D57452#1377140 , @ABataev wrote: > LG Thank you for the review. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57452/new/ https://reviews.llvm.org/D57452

[PATCH] D57452: [ASTDumper][OpenMP] CapturedDecl has a 'nothrow' bit

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57452/new/ https://reviews.llvm.org/D57452 ___ cfe-commits

[PATCH] D57452: [ASTDumper][OpenMP] CapturedDecl has a 'nothrow' bit

lebedev.ri created this revision. lebedev.ri added reviewers: aaron.ballman, steveire. lebedev.ri added projects: OpenMP, clang. Herald added a subscriber: guansong. Was trying to understand how complicated it would be to write a clang-tidy `openmp-exception-escape`-ish check once D57100

[PATCH] D57242: [RISCV] Specify MaxAtomicInlineWidth for RISC-V

asb added a comment. Thanks Lewis, I actually had a patch for this which I forgot to clean up and submit. I've done so now: D57450 . That adds tests, and sets MaxAtomicInlineWidth and MaxAtomicPromoteWidth conditionally based on whether the target has the

[PATCH] D57450: [RISCV] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth for RV32/RV64 targets with atomics

asb created this revision. asb added reviewers: jfb, jyknight, wmi. Herald added subscribers: jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, apazos, simoncook, johnrusso, rbar. This ensures that libcalls

  1   2   >