[PATCH] D58321: [WIP] Support for relative vtables

leonardchan created this revision. Herald added subscribers: cfe-commits, jdoerfert. Herald added a project: clang. This is a revisit to D20749 which introduces a flag that enables the relative ABI described in https://bugs.llvm.org/show_bug.cgi?id=26723.

[PATCH] D58320: [Darwin] Introduce a new flag, -flink-builtins-rt that forces linking of the builtins library.

aemerson created this revision. aemerson added reviewers: peter.smith, dexonsmith, ab. aemerson added a project: clang. Herald added subscribers: jdoerfert, jfb. This driver flag is useful when users want to link against the compiler's builtins, but nothing else, and so use flags like -nostdlib.

[PATCH] D56411: [CUDA][HIP][Sema] Fix template kernel with function as template parameter

rjmccall added a comment. Okay, but it's not great design to have a kind of overloading that can't be resolved to an exact intended declaration even by an explicit cast. That's why I think making *optional* host/device typing is a good idea. And I strongly want to caution you against doing

[PATCH] D56411: [CUDA][HIP][Sema] Fix template kernel with function as template parameter

yaxunl added a comment. In D56411#1400251 , @rjmccall wrote: > It is totally unreasonable, at the time you are resolving a template > argument, to investigate how the corresponding template parameter is used > within the template and use that to shape

[PATCH] D57080: [clang-tidy] Delete obsolete objc-property-declaration options ✂️

This revision was automatically updated to reflect the committed changes. Closed by commit rL354195: [clang-tidy] Delete obsolete objc-property-declaration options ✂️ (authored by stephanemoore, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

jyu2 updated this revision to Diff 187124. jyu2 marked 5 inline comments as done. jyu2 added a comment. Herald added a subscriber: rnkovacs. Review comments addressed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56571/new/ https://reviews.llvm.org/D56571 Files:

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

jyu2 added inline comments. Comment at: lib/AST/StmtProfile.cpp:324 VisitStringLiteral(S->getClobberStringLiteral(I)); + ID.AddInteger(S->getNumLabels()); } rsmith wrote: > Don't we also need to profile the labels themselves? How this can be lost? :-(

[PATCH] D56411: [CUDA][HIP][Sema] Fix template kernel with function as template parameter

rjmccall added a comment. It is totally unreasonable, at the time you are resolving a template argument, to investigate how the corresponding template parameter is used within the template and use that to shape how the template argument is resolved. That is simply not how the C++ template

[PATCH] D58289: [clang] Only provide C11 features in starting with C++17

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58289/new/ https://reviews.llvm.org/D58289 ___

[PATCH] D57850: [analyzer] Emit an error rather than assert on invalid checker option input

NoQ added inline comments. Herald added a subscriber: jdoerfert. Comment at: lib/StaticAnalyzer/Checkers/PaddingChecker.cpp:352-355 + if (Checker->AllowedPad < 0) + Mgr.getDiagnostics().Report(diag::err_analyzer_checker_option_invalid_input) +<< (llvm::Twine() +

[PATCH] D58121: [analyzer][WIP] Attempt to fix traversing bindings of non-base regions in ClusterAnalysis

NoQ added a comment. After staring at this for an hour or two, i didn't manage to force myself to understand how our cluster analysis works here, but i totally agree that it's most likely broken; i guess, we should eventually move away from the idea that everything works through base regions,

r354192 - Fix some tests I broke in r354190

Author: epilk Date: Fri Feb 15 17:51:19 2019 New Revision: 354192 URL: http://llvm.org/viewvc/llvm-project?rev=354192=rev Log: Fix some tests I broke in r354190 This was breaking on MSVC, since long double and double have the same semantics there. Modified:

[PATCH] D58317: [clang] Add install targets for development headers

smeenai added a comment. I'm not entirely happy with the name clang-dev-headers, and am open to suggestions. It's unfortunate clang-headers was already taken for something different, but renaming that target or increasing its scope seems bad for existing users. Other possibilities I thought of

[PATCH] D58317: [clang] Add install targets for development headers

smeenai created this revision. smeenai added reviewers: beanz, phosek. Herald added subscribers: jdoerfert, mgorny. Herald added a project: clang. smeenai added a comment. I'm not entirely happy with the name clang-dev-headers, and am open to suggestions. It's unfortunate clang-headers was

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

rsmith added inline comments. Herald added a reviewer: martong. Comment at: lib/AST/StmtProfile.cpp:324 VisitStringLiteral(S->getClobberStringLiteral(I)); + ID.AddInteger(S->getNumLabels()); } Don't we also need to profile the labels themselves?

[PATCH] D58254: [Sema] Diagnose floating point conversions based on target semantics

This revision was automatically updated to reflect the committed changes. Closed by commit rC354190: [Sema] Diagnose floating point conversions based on target semantics (authored by epilk, committed by ). Herald added a project: clang. Changed prior to commit:

r354190 - [Sema] Diagnose floating point conversions based on target semantics

Author: epilk Date: Fri Feb 15 17:11:47 2019 New Revision: 354190 URL: http://llvm.org/viewvc/llvm-project?rev=354190=rev Log: [Sema] Diagnose floating point conversions based on target semantics ...instead of just comparing rank. Also, fix a bad warning about _Float16, since its declared out of

[PATCH] D57075: [ObjC] For type substitution in generics use a regular recursive type visitor.

vsapsai added a comment. Thanks for the review, Erik. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57075/new/ https://reviews.llvm.org/D57075 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D57076: [ObjC generics] Fix applying `__kindof` to the type parameter.

This revision was automatically updated to reflect the committed changes. vsapsai marked an inline comment as done. Closed by commit rC354189: [ObjC generics] Fix applying `__kindof` to the type parameter. (authored by vsapsai, committed by ). Herald added a subscriber: jdoerfert. Herald added a

r354189 - [ObjC generics] Fix applying `__kindof` to the type parameter.

Author: vsapsai Date: Fri Feb 15 17:01:08 2019 New Revision: 354189 URL: http://llvm.org/viewvc/llvm-project?rev=354189=rev Log: [ObjC generics] Fix applying `__kindof` to the type parameter. Fixes the warning about incompatible pointer types on assigning to a subclass of type argument an

[PATCH] D58314: [Driver] Sync ARM behavior between clang-as and gas.

danalbert created this revision. danalbert added reviewers: peter.smith, kristof.beyls, srhines, pirama. Herald added a subscriber: javed.absar. Herald added a project: clang. The ARM gas driver previously enabled NEON for ARMv7 and up, and a handful of other extensions for ARMv8 and up (although

[PATCH] D58065: [analyzer] Document the frontend library

NoQ added a comment. Had a look. Great stuff, just as planned :) Old fanboy wisdom: Try to avoid documenting bugs you want to fix! But i don't have many high-level comments here - only appreciation of the effort. In D58065#1394864 , @Szelethus wrote: >

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

tmroeder updated this revision to Diff 187113. tmroeder added a comment. Updated Registry.cpp, regenerated the documentation, and added direct tests for the matcher. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58292/new/ https://reviews.llvm.org/D58292

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

tmroeder added a comment. In D58292#1399774 , @shafik wrote: > This looks reasonable, I will wait for @martong and/or @a_sidorin to review. > > FYI LLDB is the other big user of ASTImpoter so it is helpful if you can run > `check-lldb` especially on

[PATCH] D56411: [CUDA][HIP][Sema] Fix template kernel with function as template parameter

yaxunl added a comment. In D56411#1398586 , @rjmccall wrote: > But what we've just been talking about is not a validity rule, it's an > overload-resolution rule. It's not *invalid* to use a device function as a > template argument to a host function

[PATCH] D57579: [analyzer][WIP] Enable subcheckers to possess checker options

NoQ accepted this revision. NoQ added a comment. Herald added a subscriber: jdoerfert. > since I couldn't reproduce the error Me neither, actually :/ This patch does provide a backup plan and it makes the code prettier, so we should definitely land it and i'm really greatful for it, but the

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

mgrang added a comment. I hacked around the run_experiments.py to set CMAKE_C_FLAGS and now I see the following error in stats.html. Note: I see the same error with an existing checker like PointerArithmChecker. And I do not hit this assert when I run the checker outside of csa-testbench.

Re: r354091 - Fix implementation of [temp.local]p4.

> On Feb 15, 2019, at 1:53 PM, Richard Smith wrote: > > On Fri, 15 Feb 2019 at 09:56, Richard Smith > wrote: >> >> On Thu, 14 Feb 2019, 18:35 Francis Visoiu Mistrih via cfe-commits, >> wrote: >>> >>> Hi Richard, >>> >>> This seems to now emit an error when

[PATCH] D58236: Make address space conversions a bit stricter.

rjmccall added inline comments. Comment at: lib/Sema/SemaCast.cpp:2306 + SrcPPointee.getAddressSpace()) || + !DestPPtr->isAddressSpaceOverlapping(*SrcPPtr)) { +Self.Diag(OpRange.getBegin(), This should `if (Nested ?

[PATCH] D57662: [clang-tidy] Parallelise clang-tidy-diff.py

alexfh added inline comments. Comment at: clang-tidy/tool/clang-tidy-diff.py:98 + parser.add_argument('-j', type=int, default=0, + help='number of tidy instances to be run in parallel.') zinovy.nis wrote: > alexfh wrote: > > The

[PATCH] D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. In D58074#1399881 , @lildmh wrote: > Thanks for the catch! I also change the name from `OMPMappableExprListLocTy` > to `OMPVarListLocTy` to be more

[PATCH] D57112: [ASTTypeTraits] OMPClause handling

alexfh added a comment. In D57112#1399516 , @lebedev.ri wrote: > Ping @hokein / @alexfh (as per git blame). > Not sure who is best suited to review this. I only made a couple of random fixes to these files, so I don't feel particularly competent to

[PATCH] D57655: clang-format with UseTab: Always sometimes doesn't insert the right amount of tabs.

This revision was automatically updated to reflect the committed changes. Closed by commit rC354183: clang-format with UseTab: Always sometimes doesnt insert the right amount of… (authored by alexfh, committed by ). Changed prior to commit: https://reviews.llvm.org/D57655?vs=186629=187096#toc

r354183 - clang-format with UseTab: Always sometimes doesn't insert the right amount of tabs.

Author: alexfh Date: Fri Feb 15 15:07:43 2019 New Revision: 354183 URL: http://llvm.org/viewvc/llvm-project?rev=354183=rev Log: clang-format with UseTab: Always sometimes doesn't insert the right amount of tabs. Trailing comments are not always aligned properly when UseTab is set to Always.

[PATCH] D58307: [Clang Driver] Add support for "-static-pie" argument to the Clang driver.

sivachandra created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change mimics GCC's support for the "-static-pie" argument. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D58307 Files: clang/include/clang/Driver/Options.td

Re: [PATCH] D56850: [ASTMatchers][NFC] Add tests for assorted `CXXMemberCallExpr` matchers.

It broke on the first commit and is broken even after all of them. // Martin On Fri, 15 Feb 2019, Yitzhak Mandelbaum wrote: Was it the complete diff or one of the intermediate commits? I accidentally committed the diff as a series of commits rather than one (squashed) commit.  On Fri, Feb

[PATCH] D57659: [Sema] SequenceChecker: Add some comments + related small NFCs in preparation of the following patches

riccibruno updated this revision to Diff 187090. riccibruno marked an inline comment as done. riccibruno added a comment. Rebased and fixed a comment. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57659/new/ https://reviews.llvm.org/D57659 Files:

[PATCH] D58297: [Sema] SequenceChecker: C++17 sequencing rules for built-in operators <<, >>, .*, ->*, =, op=

riccibruno updated this revision to Diff 187089. riccibruno added a comment. 1. Only call `note{Pre,Post}{Use, Mod}` if we have a valid memory location. 2. Fixed 2 tests in `CXX/drs` which I initially missed. Repository: rC Clang CHANGES SINCE LAST ACTION

r354180 - [ObjC] For type substitution in generics use a regular recursive type visitor.

Author: vsapsai Date: Fri Feb 15 14:14:58 2019 New Revision: 354180 URL: http://llvm.org/viewvc/llvm-project?rev=354180=rev Log: [ObjC] For type substitution in generics use a regular recursive type visitor. Switch to the inheritance-based visitor from the lambda-based visitor to allow both

[PATCH] D57075: [ObjC] For type substitution in generics use a regular recursive type visitor.

This revision was automatically updated to reflect the committed changes. Closed by commit rL354180: [ObjC] For type substitution in generics use a regular recursive type visitor. (authored by vsapsai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D53633: [AArch64] Implement FP16FML intrinsics

ab added inline comments. Comment at: cfe/trunk/test/CodeGen/aarch64-neon-fp16fml.c:12 + +float32x2_t test_vfmlal_low_u32(float32x2_t a, float16x4_t b, float16x4_t c) { +// CHECK-LABEL: define <2 x float> @test_vfmlal_low_u32(<2 x float> %a, <4 x half> %b, <4 x half> %c)

Re: [PATCH] D56850: [ASTMatchers][NFC] Add tests for assorted `CXXMemberCallExpr` matchers.

Was it the complete diff or one of the intermediate commits? I accidentally committed the diff as a series of commits rather than one (squashed) commit. On Fri, Feb 15, 2019 at 4:51 PM Martin Storsjö via Phabricator < revi...@reviews.llvm.org> wrote: > mstorsjo added a comment. > > This broke

[PATCH] D58306: [AArch64] Change size suffix for FP16FML intrinsics.

ab created this revision. ab added reviewers: SjoerdMeijer, bryanpkc. ab added a project: clang. Herald added a subscriber: javed.absar. These currently use _u32, but they should instead use _f32 or _f16, the types of the accumulator, and of the multiplication. I'm starting with _f16 (because

[PATCH] D57910: [ASTImporter] Find previous friend function template

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM, I just ran `check-lldb` and I don't see any regressions. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57910/new/ https://reviews.llvm.org/D57910

Re: r354091 - Fix implementation of [temp.local]p4.

On Fri, 15 Feb 2019 at 09:56, Richard Smith wrote: > > On Thu, 14 Feb 2019, 18:35 Francis Visoiu Mistrih via cfe-commits, > wrote: >> >> Hi Richard, >> >> This seems to now emit an error when building the sanitizer tests: >>

r354176 - Fix implementation of [temp.local]p4.

Author: rsmith Date: Fri Feb 15 13:53:07 2019 New Revision: 354176 URL: http://llvm.org/viewvc/llvm-project?rev=354176=rev Log: Fix implementation of [temp.local]p4. When a template-name is looked up, we need to give injected-class-name declarations of class templates special treatment, as they

[PATCH] D56850: [ASTMatchers][NFC] Add tests for assorted `CXXMemberCallExpr` matchers.

mstorsjo added a comment. This broke compilation with GCC 5.4 on Ubuntu 16.04: ../tools/clang/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp:474:243: warning: missing terminating " character ../tools/clang/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp:474:3: error: missing

[PATCH] D58294: [clangd] Enable indexing of template type parameters

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric. Herald added a project: clang. Fixes https://bugs.llvm.org/show_bug.cgi?id=36285 Repository: rCTE Clang Tools Extra

[PATCH] D58291: [clangd] Include textual diagnostic ID as Diagnostic.code.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, jdoerfert, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Herald added a project: clang. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D58291 Files:

[PATCH] D45978: dllexport const variables must have external linkage.

aaron.ballman added inline comments. Comment at: lib/Sema/SemaDecl.cpp:11370 +// In Microsoft C++ mode, a const variable defined in namespace scope has +// external linkage by default if the variable is declared with zahiraam wrote: > aaron.ballman

[PATCH] D57948: [Sema] Fix a regression introduced in "[AST][Sema] Remove CallExpr::setNumArgs"

riccibruno added a comment. Done, thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57948/new/ https://reviews.llvm.org/D57948 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier

ABataev added inline comments. Comment at: include/clang/Sema/Sema.h:9347 ArrayRef MapTypeModifiersLoc, + CXXScopeSpec , DeclarationNameInfo , OpenMPMapClauseKind MapType, bool IsMapTypeImplicit, ABataev wrote: > Also would be good to pack

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

mgrang added a comment. The error I now get is: clang is not able to compile a simple test program. /usr/bin/ld: unrecognised emulation mode: armelf_linux_eabi Supported emulations: elf_x86_64 elf32_x86_64 elf_i386 elf_iamcu i386linux elf_l1om elf_k1om i386pep i386pe This is because

r354169 - Revert r354075 "[clang][FileManager] fillRealPathName even if we aren't opening the file"

Author: rnk Date: Fri Feb 15 12:48:12 2019 New Revision: 354169 URL: http://llvm.org/viewvc/llvm-project?rev=354169=rev Log: Revert r354075 "[clang][FileManager] fillRealPathName even if we aren't opening the file" The new test doesn't pass on Windows. Modified:

Re: r354075 - [clang][FileManager] fillRealPathName even if we aren't opening the file

Reverted: http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/4351 On Fri, Feb 15, 2019 at 11:07 AM Galina Kistanova via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hello Jan, > > It looks like this commit broke tests on couple of win builders: > >

[PATCH] D58153: [Driver] Default all Android ARM targets to NEON.

This revision was automatically updated to reflect the committed changes. Closed by commit rL354166: [Driver] Default all Android ARM targets to NEON. (authored by danalbert, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r354166 - [Driver] Default all Android ARM targets to NEON.

Author: danalbert Date: Fri Feb 15 12:31:54 2019 New Revision: 354166 URL: http://llvm.org/viewvc/llvm-project?rev=354166=rev Log: [Driver] Default all Android ARM targets to NEON. Summary: There are an insignificant number of ARM Android devices that don't support NEON. Default to using NEON

r354165 - Relax assertion to account for private framework modules, too.

Author: adrian Date: Fri Feb 15 12:24:26 2019 New Revision: 354165 URL: http://llvm.org/viewvc/llvm-project?rev=354165=rev Log: Relax assertion to account for private framework modules, too. rdar://problem/48116069 Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D57270: [ObjC] Fix non-canonical types preventing type arguments substitution.

This revision was automatically updated to reflect the committed changes. Closed by commit rL354164: [ObjC] Fix non-canonical types preventing type arguments substitution. (authored by vsapsai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

r354164 - [ObjC] Fix non-canonical types preventing type arguments substitution.

Author: vsapsai Date: Fri Feb 15 12:17:45 2019 New Revision: 354164 URL: http://llvm.org/viewvc/llvm-project?rev=354164=rev Log: [ObjC] Fix non-canonical types preventing type arguments substitution. `QualType::substObjCTypeArgs` doesn't go past non-canonical types and as the result misses some

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. Please be sure to update Registry.cpp to expose the new AST matcher to the dynamic matcher infrastructure, regenerate the AST matcher documentation (run clang\docs\tools\dump_ast_matchers.py), and add tests for the

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

shafik added a comment. This looks reasonable, I will wait for @martong and/or @a_sidorin to review. FYI LLDB is the other big user of ASTImpoter so it is helpful if you can run `check-lldb` especially on MacOS so you can to catch regressions before committing. After committing please make

[PATCH] D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier

ABataev added inline comments. Comment at: include/clang/AST/OpenMPClause.h:3666 + OMPMappableExprListClause( + OpenMPClauseKind K, OMPMappableExprListLocTy Locs, + OMPMappableExprListSizeTy Sizes, Pass those new structures by const reference, not by

[PATCH] D17444: [MSVC] Recognize "static_assert" keyword in C mode

This revision was automatically updated to reflect the committed changes. Closed by commit rC354162: [MSVC] Recognize `static_assert` keyword in C and C++98 (authored by rnk, committed by ). Changed prior to commit: https://reviews.llvm.org/D17444?vs=186741=187061#toc Repository: rC Clang

r354162 - [MSVC] Recognize `static_assert` keyword in C and C++98

Author: rnk Date: Fri Feb 15 11:59:45 2019 New Revision: 354162 URL: http://llvm.org/viewvc/llvm-project?rev=354162=rev Log: [MSVC] Recognize `static_assert` keyword in C and C++98 Summary: The main effect is that clang now accepts the following conforming C11 code with MSVC headers: #include

[PATCH] D57747: [Sema] SequenceChecker: Fix handling of operator ||, && and ?:

riccibruno updated this revision to Diff 187057. riccibruno marked an inline comment as done. riccibruno added a comment. Herald added a subscriber: jdoerfert. Rebased Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57747/new/ https://reviews.llvm.org/D57747

[PATCH] D58297: [Sema] SequenceChecker: C++17 sequencing rules for built-in operators <<, >>, .*, ->*, =, op=

riccibruno created this revision. riccibruno added reviewers: rsmith, rjmccall, aaron.ballman. riccibruno added a project: clang. Herald added subscribers: cfe-commits, jdoerfert. Implement the C++17 sequencing rules for the built-in operators `<<`, `>>`, `.*`, `->*`, `=` and `op=`.

[PATCH] D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier

lildmh added inline comments. Comment at: include/clang/AST/OpenMPClause.h:3682-3685 + OpenMPClauseKind K, SourceLocation StartLoc, SourceLocation LParenLoc, + SourceLocation EndLoc, OMPMappableExprListSizeTy Sizes, + NestedNameSpecifierLoc *MapperQualifierLocP =

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

raj.khem added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:476 for (const auto : DebugPrefixMap) -if (Path.startswith(Entry.first)) - return (Twine(Entry.second) + Path.substr(Entry.first.size())).str(); - return Path.str(); +if

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

raj.khem added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:476 for (const auto : DebugPrefixMap) -if (Path.startswith(Entry.first)) - return (Twine(Entry.second) + Path.substr(Entry.first.size())).str(); - return Path.str(); +if

Re: r354075 - [clang][FileManager] fillRealPathName even if we aren't opening the file

Hello Jan, It looks like this commit broke tests on couple of win builders: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/23655 http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win . . . Failing Tests (1): Clang-Unit ::

[PATCH] D58291: [clangd] Include textual diagnostic ID as Diagnostic.code.

sammccall updated this revision to Diff 187048. sammccall added a comment. Unit test. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58291/new/ https://reviews.llvm.org/D58291 Files: clangd/Diagnostics.cpp clangd/Diagnostics.h

[PATCH] D58293: [clang][Index] Enable indexing of Template Type Parameters behind a flag

kadircet created this revision. kadircet added reviewers: ilya-biryukov, akyrtzi. Herald added subscribers: cfe-commits, arphaman, ioeric, kristof.beyls, javed.absar. Herald added a project: clang. clangd uses indexing api to provide references and it was not possible to perform symbol

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

tmroeder created this revision. Herald added a reviewer: shafik. Herald added subscribers: cfe-commits, jdoerfert. Herald added a project: clang. This allows ASTs to be merged when they contain ChooseExpr (the GNU __builtin_choose_expr construction). This is needed, for example, for cross-CTU

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

jyu2 added inline comments. Comment at: lib/Sema/JumpDiagnostics.cpp:675 + // asm-goto. + //if (!IsAsmGoto && IndirectJumpTargets.empty()) { + if (JumpTargets.empty()) { efriedma wrote: > Commented-out code? > > We probably don't need a diagnostic for an asm

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

jyu2 updated this revision to Diff 187036. jyu2 marked an inline comment as done. jyu2 added a comment. Review comment addressed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56571/new/ https://reviews.llvm.org/D56571 Files: include/clang/AST/Stmt.h

[PATCH] D57948: [Sema] Fix a regression introduced in "[AST][Sema] Remove CallExpr::setNumArgs"

aaron.ballman added a subscriber: hansw. aaron.ballman added a comment. In D57948#1399403 , @riccibruno wrote: > (Following up on a discussion on IRC) I have looked at what would be needed > to revert the set of patches which introduced this change, but

[PATCH] D57660: [Sema] SequenceChecker: Handle references and members

riccibruno updated this revision to Diff 187035. riccibruno added a comment. Herald added a subscriber: jdoerfert. Rebased. Does this implementation make sense ? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57660/new/ https://reviews.llvm.org/D57660 Files:

r354151 - [Sema][NFC] SequenceChecker: Add tests for references/members, and prepare for the C++17 tests

Author: brunoricci Date: Fri Feb 15 10:12:58 2019 New Revision: 354151 URL: http://llvm.org/viewvc/llvm-project?rev=354151=rev Log: [Sema][NFC] SequenceChecker: Add tests for references/members, and prepare for the C++17 tests Add some tests for unsequenced operations with members and

Re: r354091 - Fix implementation of [temp.local]p4.

On Thu, 14 Feb 2019, 18:35 Francis Visoiu Mistrih via cfe-commits, < cfe-commits@lists.llvm.org> wrote: > Hi Richard, > > This seems to now emit an error when building the sanitizer tests: > http://green.lab.llvm.org/green/job/clang-stage1-configure-RA/53965/consoleFull > . > > I managed to

[PATCH] D58149: [clang] Make sure C99/C11 features in are provided in C++11

ldionne added a comment. I agree with the comments. I think we should strive to be strictly conforming. I make that argument all the time for libc++, so I'll be consistent :-). https://reviews.llvm.org/D58289 Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D58062: Support framework import/include auto-completion

dgoldman added a comment. In D58062#1399499 , @sammccall wrote: > Great, thank you! Want me to land this? > > (You can certainly get your own commit access at this point if you like: > https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access

[PATCH] D58218: Variable auto-init of blocks capturing self after init bugfix

This revision was automatically updated to reflect the committed changes. Closed by commit rL354147: Variable auto-init of blocks capturing self after init bugfix (authored by jfb, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM

r354147 - Variable auto-init of blocks capturing self after init bugfix

Author: jfb Date: Fri Feb 15 09:26:29 2019 New Revision: 354147 URL: http://llvm.org/viewvc/llvm-project?rev=354147=rev Log: Variable auto-init of blocks capturing self after init bugfix Summary: Blocks that capture themselves (and escape) after initialization currently codegen wrong because

[PATCH] D57112: [ASTTypeTraits] OMPClause handling

lebedev.ri added a subscriber: alexfh. lebedev.ri added a comment. Herald added a subscriber: jdoerfert. Ping @hokein / @alexfh (as per git blame). Not sure who is best suited to review this. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57112/new/

[PATCH] D58062: Support framework import/include auto-completion

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Great, thank you! Want me to land this? (You can certainly get your own commit access at this point if you like: https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access and

[PATCH] D58239: [clangd] Cache include fixes for diagnostics caused by the same unresolved name or incomplete type.

sammccall added a comment. (big thumbs up to the caching overall of course!) Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58239/new/ https://reviews.llvm.org/D58239 ___ cfe-commits mailing list

[PATCH] D58179: [OpenCL][PR40707] Allow OpenCL C types in C++ mode

keryell added a comment. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58179/new/ https://reviews.llvm.org/D58179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D58239: [clangd] Cache include fixes for diagnostics caused by the same unresolved name or incomplete type.

sammccall added inline comments. Comment at: clangd/IncludeFixer.cpp:130 + // FIXME: consider batching the requests for all diagnostics. llvm::Optional Matched; Index.lookup(Req, [&](const Symbol ) { oops - this seems broken (in both the old and new

[PATCH] D58284: [clang] Switch to LLVM_ENABLE_IDE

smeenai added a comment. In D58284#1399446 , @lebedev.ri wrote: > In D58284#1399443 , @smeenai wrote: > > > CC @lebedev.ri, since I believe you raised some issues during the > > corresponding LLVM change but those

[PATCH] D57855: [analyzer] Reimplement checker options

Szelethus added a comment. I guess removing some of the checker option descriptions from `lib/StataicAnalyzer/Checkers/` would be nice too, to easy on maintenance. One could always just use `-analyzer-checker-option-help` whenever in doubt. CHANGES SINCE LAST ACTION

[PATCH] D58284: [clang] Switch to LLVM_ENABLE_IDE

lebedev.ri added a comment. In D58284#1399443 , @smeenai wrote: > CC @lebedev.ri, since I believe you raised some issues during the > corresponding LLVM change but those were addressed. Yeah, i don't think i have any comments here. The logic to pick

[PATCH] D58284: [clang] Switch to LLVM_ENABLE_IDE

smeenai added a subscriber: lebedev.ri. smeenai added a comment. CC @lebedev.ri, since I believe you raised some issues during the corresponding LLVM change but those were addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58284/new/

[PATCH] D58284: [clang] Switch to LLVM_ENABLE_IDE

smeenai created this revision. smeenai added reviewers: beanz, phosek. Herald added subscribers: jdoerfert, arphaman, mgorny. Herald added a project: clang. r344555 switched LLVM to guarding install targets with LLVM_ENABLE_IDE instead of CMAKE_CONFIGURATION_TYPES, which expresses the intent more

[PATCH] D58269: [clang] Add build and install targets for clang libraries

This revision was automatically updated to reflect the committed changes. Closed by commit rC354141: [clang] Add build and install targets for clang libraries (authored by smeenai, committed by ). Changed prior to commit: https://reviews.llvm.org/D58269?vs=186957=187019#toc Repository: rC

[PATCH] D58268: [clang] Create install targets for non-shared libraries

This revision was automatically updated to reflect the committed changes. Closed by commit rC354140: [clang] Create install targets for non-shared libraries (authored by smeenai, committed by ). Changed prior to commit: https://reviews.llvm.org/D58268?vs=186955=187018#toc Repository: rC

r354141 - [clang] Add build and install targets for clang libraries

Author: smeenai Date: Fri Feb 15 07:59:04 2019 New Revision: 354141 URL: http://llvm.org/viewvc/llvm-project?rev=354141=rev Log: [clang] Add build and install targets for clang libraries This is modeled after the existing llvm-libraries target. It's a convenient way to include all clang

r354140 - [clang] Create install targets for non-shared libraries

Author: smeenai Date: Fri Feb 15 07:59:02 2019 New Revision: 354140 URL: http://llvm.org/viewvc/llvm-project?rev=354140=rev Log: [clang] Create install targets for non-shared libraries I don't see a reason for these to not have install targets created, which in turn allows them to be bundled in

[PATCH] D57948: [Sema] Fix a regression introduced in "[AST][Sema] Remove CallExpr::setNumArgs"

riccibruno added a subscriber: hans. riccibruno added a comment. (Following up on a discussion on IRC) I have looked at what would be needed to revert the set of patches which introduced this change, but this results in a >1k lines diff which do not apply cleanly. I think it might be safer to

[PATCH] D56851: [ASTMatchers] Adds `CXXMemberCallExpr` matcher `invokedAtType`.

ymandel marked 3 inline comments as done. ymandel added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3300 +/// matches `x.m()` and `p->m()`. +AST_MATCHER_P_OVERLOAD(clang::CXXMemberCallExpr, invokedAtType, +

  1   2   >