[clang-tools-extra] r356974 - [clangd][xpc][cmake] Respect explicit value of CLANGD_BUILD_XPC

Author: jkorous Date: Mon Mar 25 20:48:25 2019 New Revision: 356974 URL: http://llvm.org/viewvc/llvm-project?rev=356974=rev Log: [clangd][xpc][cmake] Respect explicit value of CLANGD_BUILD_XPC We shouldn't prevent user from disabling XPC framework build on Darwin. However, by keeping it on by

[PATCH] D59765: [Lex] Warn about invisible Hangul whitespace

ruiu added a comment. I wonder if we should handle Unicode codepoints that are in the whitespace category as a whole, instead of handling each codepoint individually. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59765/new/ https://reviews.llvm.org/D59765

[PATCH] D59622: [analyzer] C++17: PR41142: Ignore transparent InitListExprs in ExprEngine as well.

NoQ added a comment. (the commit message shouldn't have said "CFG", sry) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59622/new/ https://reviews.llvm.org/D59622 ___ cfe-commits mailing list

[PATCH] D59802: [clang-tidy] Add new checker: llvm-avoid-cast-in-conditional

hintonda updated this revision to Diff 192238. hintonda added a comment. - Address additional comments, and move to LLVM.h. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59802/new/ https://reviews.llvm.org/D59802 Files:

[PATCH] D59347: [DebugInfo] Combine Trivial and NonTrivial flags

asmith added a comment. Either way. It was fewer changes to use FlagNonTrivial. Which flag do people want to keep? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59347/new/ https://reviews.llvm.org/D59347 ___

Re: [clang-tools-extra] r356849 - [pp-trace] Modernize the code

There was another change rCTE356893 which rewrote this part. On Tue, Mar 26, 2019 at 1:24 AM wrote: > > Hi, > > Yes, it appears to have been fixed as of r356878. > > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/24580 > > Douglas Yung > > -Original

[PATCH] D59802: [clang-tidy] Add new checker: llvm-avoid-cast-in-conditional

hintonda marked an inline comment as done. hintonda added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/HeaderFileExtensionsUtils.h:17 +using llvm::SmallSet; + hintonda wrote: > Eugene.Zelenko wrote: > > It'll be easier to use llvm::SmallSet

[PATCH] D59802: [clang-tidy] Add new checker: llvm-avoid-cast-in-conditional

hintonda marked an inline comment as done. hintonda added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/HeaderFileExtensionsUtils.h:17 +using llvm::SmallSet; + Eugene.Zelenko wrote: > It'll be easier to use llvm::SmallSet in using statement.

[PATCH] D57072: Don't codegen an unreachable return block

bmoody added a comment. Herald added a subscriber: jdoerfert. Herald added a project: clang. Ping! Any chance you could commit this on my behalf? Otherwise I can try the mailing list. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57072/new/

[PATCH] D59806: [clang-tidy] Add a check for [super self] in initializers 

stephanemoore created this revision. Herald added subscribers: cfe-commits, jdoerfert, xazax.hun, mgorny. Herald added a project: clang. stephanemoore edited the summary of this revision. This check aims to address a relatively common benign error where Objective-C subclass initializers call

[PATCH] D59802: [clang-tidy] Add new checker: llvm-avoid-cast-in-conditional

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/HeaderFileExtensionsUtils.h:17 +using llvm::SmallSet; + It'll be easier to use llvm::SmallSet in using statement. Comment at:

[PATCH] D59802: [clang-tidy] Add new checker: llvm-avoid-cast-in-conditional

hintonda updated this revision to Diff 192234. hintonda added a comment. - Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59802/new/ https://reviews.llvm.org/D59802 Files:

[PATCH] D59754: [Sema] Add c++2a designated initializer warnings

hintonda updated this revision to Diff 192233. hintonda added a comment. - Missed one set of braces. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59754/new/ https://reviews.llvm.org/D59754 Files: clang/lib/Sema/SemaInit.cpp

[PATCH] D59754: [Sema] Add c++2a designated initializer warnings

hintonda updated this revision to Diff 192232. hintonda added a comment. - Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59754/new/ https://reviews.llvm.org/D59754 Files: clang/lib/Sema/SemaInit.cpp

[PATCH] D59725: Additions to creduce script

akhuang updated this revision to Diff 192230. akhuang added a comment. fix issue with grouping two command line args together CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59725/new/ https://reviews.llvm.org/D59725 Files: clang/utils/creduce-clang-crash.py Index:

[PATCH] D59725: Additions to creduce script

akhuang marked 2 inline comments as done. akhuang added inline comments. Comment at: clang/utils/creduce-clang-crash.py:223 + if len(x) > 0 and x[-1].startswith('-') and not y.startswith('-'): +x[-1] += ' ' + y +return x george.burgess.iv

[PATCH] D59754: [Sema] Add c++2a designated initializer warnings

hintonda marked an inline comment as done. hintonda added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:2044 + : std::distance(RD->field_begin(), RD->field_end()); + if (VerifyOnly && (LastIdx >= NextIdx || HasNonDesignatedInit) && +

[PATCH] D59803: [CMake][Fuchsia] Merge static libunwind and libc++abi into libc++ on Darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rC356970: [CMake][Fuchsia] Merge static libunwind and libc++abi into libc++ on Darwin (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D59803?vs=192225=192229#toc

r356970 - [CMake][Fuchsia] Merge static libunwind and libc++abi into libc++ on Darwin

Author: phosek Date: Mon Mar 25 17:43:29 2019 New Revision: 356970 URL: http://llvm.org/viewvc/llvm-project?rev=356970=rev Log: [CMake][Fuchsia] Merge static libunwind and libc++abi into libc++ on Darwin We want to distribute only a single archive so -lc++ does the right thing and users don't

[PATCH] D59622: [analyzer] C++17: PR41142: Ignore transparent InitListExprs in ExprEngine as well.

This revision was automatically updated to reflect the committed changes. Closed by commit rC356969: [CFG] [analyzer] pr41142: C++17: Skip transparent InitListExprs in ExprEngine. (authored by dergachev, committed by ). Changed prior to commit:

r356969 - [CFG] [analyzer] pr41142: C++17: Skip transparent InitListExprs in ExprEngine.

Author: dergachev Date: Mon Mar 25 17:36:53 2019 New Revision: 356969 URL: http://llvm.org/viewvc/llvm-project?rev=356969=rev Log: [CFG] [analyzer] pr41142: C++17: Skip transparent InitListExprs in ExprEngine. r356634 didn't fix all the problems caused by r356222 - even though simple

[PATCH] D59754: [Sema] Add c++2a designated initializer warnings

hintonda marked an inline comment as done. hintonda added inline comments. Comment at: clang/test/SemaCXX/cxx2a-initializer-aggregates.cpp:30 +// out of order designators +A a1 = {.y = 1, .x = 2}; // expected-warning {{designated initializers are a C99 feature}} +

[PATCH] D59797: [COFF] Reorder fields in Chunk and SectionChunk to reduce their size

smeenai added inline comments. Comment at: lld/COFF/Chunks.cpp:47 +namespace { +// This class exists just for the purpose of calculating the expected size of pcc wrote: > rnk wrote: > > ruiu wrote: > > > rnk wrote: > > > > ruiu wrote: > > > > > rnk wrote: > >

[PATCH] D53701: [Analyzer] Instead of recording comparisons in interator checkers do an eager state split

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:822-831 +assignToContainer(C, CE, LVal, Cont); +if (!(LPos = getIteratorPosition(State, LVal))) return; -State = saveComparison(State, Condition, LVal, RVal, Op ==

[PATCH] D59008: [AMDGPU] Switch default dwarf version to 5

dblaikie added a comment. In D59008#1442256 , @t-tye wrote: > In D59008#1442014 , @dblaikie wrote: > > > In D59008#1441903 , @t-tye wrote: > > > > > LGTM > > > > > > Do we

[PATCH] D59803: [CMake][Fuchsia] Merge static libunwind and libc++abi into libc++ on Darwin

phosek created this revision. phosek added reviewers: juliehockett, jakehehrlich. Herald added subscribers: cfe-commits, mgorny. Herald added a reviewer: EricWF. Herald added a project: clang. We want to distribute only a single archive so -lc++ does the right thing and users don't have to

[PATCH] D54978: Move the SMT API to LLVM

aprantl added a comment. I'm afraid this broke some bots that build with `LLVM_ENABLE_MODULES=1`. For example: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/22411/consoleFull#710926295dd1929ea-7054-4089-b7ef-4624c3781fa4 Undefined symbols for architecture x86_64:

[PATCH] D59797: [COFF] Reorder fields in Chunk and SectionChunk to reduce their size

pcc added inline comments. Comment at: lld/COFF/Chunks.cpp:47 +namespace { +// This class exists just for the purpose of calculating the expected size of rnk wrote: > ruiu wrote: > > rnk wrote: > > > ruiu wrote: > > > > rnk wrote: > > > > > ruiu wrote: > > > >

[PATCH] D59797: [COFF] Reorder fields in Chunk and SectionChunk to reduce their size

rnk marked 4 inline comments as done. rnk added inline comments. Comment at: lld/COFF/Chunks.cpp:47 +namespace { +// This class exists just for the purpose of calculating the expected size of ruiu wrote: > rnk wrote: > > ruiu wrote: > > > rnk wrote: > > > >

[PATCH] D59797: [COFF] Reorder fields in Chunk and SectionChunk to reduce their size

rnk updated this revision to Diff 192223. rnk added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. - replace struct with current size Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59797/new/

r356964 - [MS] Add frontend support for __declspec(allocator)

Author: rnk Date: Mon Mar 25 16:20:18 2019 New Revision: 356964 URL: http://llvm.org/viewvc/llvm-project?rev=356964=rev Log: [MS] Add frontend support for __declspec(allocator) The intention is to add metadata to direct call sites of functions marked with __declspec(allocator), which will

[PATCH] D59725: Additions to creduce script

george.burgess.iv marked an inline comment as done. george.burgess.iv added inline comments. Comment at: clang/utils/creduce-clang-crash.py:223 + if len(x) > 0 and x[-1].startswith('-') and not y.startswith('-'): +x[-1] += ' ' + y +return x

[PATCH] D59802: [clang-tidy] Add new checker: llvm-avoid-cast-in-conditional

hintonda marked an inline comment as done. hintonda added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/HeaderFileExtensionsUtils.h:23 -typedef llvm::SmallSet HeaderFileExtensionsSet; +typedef SmallSet HeaderFileExtensionsSet; hintonda

[PATCH] D59725: Additions to creduce script

akhuang updated this revision to Diff 192218. akhuang marked an inline comment as done. akhuang added a comment. Style nits, added comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59725/new/ https://reviews.llvm.org/D59725 Files: clang/utils/creduce-clang-crash.py Index:

[PATCH] D59725: Additions to creduce script

rnk added a comment. I recently discovered NamedTemporaryFile, maybe that would help simplify up the various mkstemp usages. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59725/new/ https://reviews.llvm.org/D59725 ___ cfe-commits mailing

[PATCH] D59802: [clang-tidy] Add new checker: llvm-avoid-cast-in-conditional

hintonda marked an inline comment as done. hintonda added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/HeaderFileExtensionsUtils.h:23 -typedef llvm::SmallSet HeaderFileExtensionsSet; +typedef SmallSet HeaderFileExtensionsSet;

[PATCH] D59802: [clang-tidy] Add new checker: llvm-avoid-cast-in-conditional

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/HeaderFileExtensionsUtils.h:23 -typedef llvm::SmallSet HeaderFileExtensionsSet; +typedef SmallSet HeaderFileExtensionsSet; Please use using. See modernize-use-using.

[PATCH] D59802: [clang-tidy] Add new checker: llvm-avoid-cast-in-conditional

hintonda created this revision. hintonda added reviewers: alexfh, rjmccall. Herald added subscribers: xazax.hun, mgorny. Herald added a project: clang. Finds cases of cast<> used as the condition of a conditional statements which will assert on failure in Debug builds. The use of cast<> implies

[PATCH] D59754: [Sema] Add c++2a designated initializer warnings

Rakete added inline comments. Comment at: clang/test/SemaCXX/cxx2a-initializer-aggregates.cpp:30 +// out of order designators +A a1 = {.y = 1, .x = 2}; // expected-warning {{designated initializers are a C99 feature}} + hintonda wrote: > lebedev.ri wrote: >

[PATCH] D53701: [Analyzer] Instead of recording comparisons in interator checkers do an eager state split

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:822-831 +assignToContainer(C, CE, LVal, Cont); +if (!(LPos = getIteratorPosition(State, LVal))) return; -State = saveComparison(State, Condition, LVal, RVal, Op ==

[PATCH] D59725: Additions to creduce script

akhuang marked 15 inline comments as done. akhuang added inline comments. Comment at: clang/utils/creduce-clang-crash.py:137 + +# If no message was found, use the top five stack trace functions, +# ignoring some common functions george.burgess.iv wrote:

[PATCH] D59754: [Sema] Add c++2a designated initializer warnings

hintonda marked an inline comment as done. hintonda added inline comments. Comment at: clang/test/SemaCXX/cxx2a-initializer-aggregates.cpp:30 +// out of order designators +A a1 = {.y = 1, .x = 2}; // expected-warning {{designated initializers are a C99 feature}} +

[PATCH] D59754: [Sema] Add c++2a designated initializer warnings

lebedev.ri added inline comments. Comment at: clang/test/SemaCXX/cxx2a-initializer-aggregates.cpp:30 +// out of order designators +A a1 = {.y = 1, .x = 2}; // expected-warning {{designated initializers are a C99 feature}} + hintonda wrote: > Rakete wrote: >

[PATCH] D59754: [Sema] Add c++2a designated initializer warnings

hintonda marked 2 inline comments as done. hintonda added a comment. Thanks for the review. Comment at: clang/lib/Sema/SemaInit.cpp:2017 + auto LastIdx = Field != FieldEnd + ? Field->getFieldIndex() Rakete wrote: > Can

[PATCH] D57265: [PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting

vsk updated this revision to Diff 192210. vsk edited the summary of this revision. vsk added a comment. Herald added subscribers: jdoerfert, dexonsmith, steven_wu, eraman. Use a function attribute to implement the -fsplit-cold-code option. This removes some complexity from the old/new PMs and

[PATCH] D59776: [Sema] Don't check for array bounds when the types in the base expression are dependent.

This revision was automatically updated to reflect the committed changes. Closed by commit rL356957: [Sema] Dont check for array bounds when the types in the base expression are… (authored by brunoricci, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

r356957 - [Sema] Don't check for array bounds when the types in the base expression are dependent

Author: brunoricci Date: Mon Mar 25 14:37:10 2019 New Revision: 356957 URL: http://llvm.org/viewvc/llvm-project?rev=356957=rev Log: [Sema] Don't check for array bounds when the types in the base expression are dependent Bail-out of CheckArrayAccess when the types of the base expression before

[PATCH] D59555: [analyzer] Add yaml parser to GenericTaintChecker

boga95 marked an inline comment as done. boga95 added a comment. Why is it better not to use `static` functions/variables? Has it any performance impact? Comment at: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:73-75 static const unsigned InvalidArgIndex = UINT_MAX;

[PATCH] D59665: Call to HandleNameConflict in VisitEnumDecl mistakeningly using Name instead of SearchName

shafik marked an inline comment as done. shafik added a comment. @martong your idea does not work b/c default construction `DeclarationName()` treats it the same as being empty. So `if (!Name)` is still `true`. Comment at: lib/AST/ASTImporter.cpp:2463 if

[PATCH] D46140: [coroutines] std::task type (WIP)

lewissbaker updated this revision to Diff 192208. lewissbaker added a comment. Fix race condition in __oneshot_event::set() method used by sync_wait(). Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D46140/new/ https://reviews.llvm.org/D46140 Files:

[PATCH] D59195: [analyzer] Remove the default value arg from getChecker*Option

NoQ accepted this revision. NoQ added inline comments. Comment at: lib/StaticAnalyzer/Core/AnalyzerOptions.cpp:148-150 + assert(Ret && + "This option should be either 'true' or 'false', and should've been " + "validated by CheckerRegisrty!");

[PATCH] D46140: [coroutines] std::task type (WIP)

lewissbaker updated this revision to Diff 192203. lewissbaker edited the summary of this revision. lewissbaker added a comment. Herald added subscribers: libcxx-commits, jdoerfert. - Don't use __allocator as variable name (it is #defined to NASTY_MACRO). - Remove workaround in test for

[PATCH] D53076: [analyzer] ConditionBRVisitor: enhance to write out more information

NoQ added a comment. Btw, did you try running this patch against big projects? 'Cause it's a high-impact change and we'd have to be careful with it. I ran it on LLVM real quick and noticed that 97.3% (!) of reports contained at least one of the new notes, with number of HTML path pieces

[PATCH] D59754: [Sema] Add c++2a designated initializer warnings

Rakete added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:2017 + auto LastIdx = Field != FieldEnd + ? Field->getFieldIndex() Can `Field` ever be `FieldEnd` at this point? Comment at:

[PATCH] D59743: [WebAssembly] Don't use default GetLinkerPath

This revision was automatically updated to reflect the committed changes. Closed by commit rC356953: [WebAssembly] Dont use default GetLinkerPath (authored by sbc, committed by ). Changed prior to commit: https://reviews.llvm.org/D59743?vs=192126=192201#toc Repository: rC Clang CHANGES

r356953 - [WebAssembly] Don't use default GetLinkerPath

Author: sbc Date: Mon Mar 25 14:14:26 2019 New Revision: 356953 URL: http://llvm.org/viewvc/llvm-project?rev=356953=rev Log: [WebAssembly] Don't use default GetLinkerPath We can't (don't want to) honor the same set of "-fuse-ld" flags with WebAssembly since the ELF linkers (ld.lld, ld.gnu, etc)

[PATCH] D59008: [AMDGPU] Switch default dwarf version to 5

kzhuravl accepted this revision. kzhuravl added a comment. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59008/new/ https://reviews.llvm.org/D59008 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59008: [AMDGPU] Switch default dwarf version to 5

t-tye added a comment. In D59008#1442014 , @dblaikie wrote: > In D59008#1441903 , @t-tye wrote: > > > LGTM > > > > Do we know the state of split DWARF and DWARF compression for DWARF 5 > > (compared to DWARF 2)? >

[PATCH] D59494: AMDGPU: Add support for cross address space synchronization scopes (clang)

This revision was automatically updated to reflect the committed changes. Closed by commit rC356947: AMDGPU: Add support for cross address space synchronization scopes (clang) (authored by kzhuravl, committed by ). Herald added a subscriber: ebevhan. Herald added a project: clang. Repository:

r356947 - AMDGPU: Add support for cross address space synchronization scopes (clang)

Author: kzhuravl Date: Mon Mar 25 13:54:00 2019 New Revision: 356947 URL: http://llvm.org/viewvc/llvm-project?rev=356947=rev Log: AMDGPU: Add support for cross address space synchronization scopes (clang) Differential Revision: https://reviews.llvm.org/D59494 Modified:

[PATCH] D59798: Add analyzer option to limit the number of imported TUs

gamesh411 created this revision. Herald added subscribers: cfe-commits, jdoerfert, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware, whisperity. Herald added a reviewer: martong. Herald added a project: clang. During CTU analysis of complex projects, the loaded AST-contents of

[PATCH] D57978: [CodeGen] Generate follow-up metadata for loops with more than one transformation.

Meinersbur added a comment. In D57978#1440894 , @dmgreen wrote: > This could maybe do with a few extra tests. Am I correct in saying something > like this: > > #pragma unroll_and_jam(4) > for(int j = 0; j < n; j++) { > #pragma unroll(4) >

[PATCH] D57978: [CodeGen] Generate follow-up metadata for loops with more than one transformation.

Meinersbur updated this revision to Diff 192194. Meinersbur marked 5 inline comments as done. Meinersbur added a comment. - Rebase - Add two test cases for all attributes combined (as inner and outer loop for of an unroll-and-jam) - Of two nested unroll-and-jams, apply the inner first - Typos

[PATCH] D59627: [clang-format] Keep protobuf "package" statement on one line

dchai added a comment. Just to confirm, the regression is in the number of spaces before a trailing comment? Before (2 spaces): package foo.bar; // foo.bar package After (1 space): package foo.bar; // foo.bar package Top-level options are handled the same way. I'll see if I can

[PATCH] D59523: Thread Safety: also look at ObjC methods

This revision was automatically updated to reflect the committed changes. Closed by commit rL356940: Thread Safety: also look at ObjC methods (authored by jfb, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

r356940 - Thread Safety: also look at ObjC methods

Author: jfb Date: Mon Mar 25 13:06:32 2019 New Revision: 356940 URL: http://llvm.org/viewvc/llvm-project?rev=356940=rev Log: Thread Safety: also look at ObjC methods Summary: SExprBuilder::translateDeclRefExpr was only looking at FunctionDecl and not also looking at ObjCMethodDecl. It should

[PATCH] D59776: [Sema] Don't check for array bounds when the types in the base expression are dependent.

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59776/new/ https://reviews.llvm.org/D59776 ___

[PATCH] D59371: [LibTooling] Add Stencil library for format-string style codegen.

ymandel added a comment. gentle ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59371/new/ https://reviews.llvm.org/D59371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59725: Additions to creduce script

george.burgess.iv added a comment. Thanks for this! Comment at: clang/utils/creduce-clang-crash.py:137 + +# If no message was found, use the top five stack trace functions, +# ignoring some common functions Please expand a bit on why 5 was chosen (is

[PATCH] D59329: [LibTooling] Add NodeId, a strong type for AST-matcher node identifiers.

ymandel added a comment. gentle ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59329/new/ https://reviews.llvm.org/D59329 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59008: [AMDGPU] Switch default dwarf version to 5

dblaikie added a comment. In D59008#1441903 , @t-tye wrote: > LGTM > > Do we know the state of split DWARF and DWARF compression for DWARF 5 > (compared to DWARF 2)? State of them in what sense? Compression is pretty orthogonal to any DWARF version -

[PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

ymandel marked 10 inline comments as done. ymandel added a comment. Addressed the most major comments. Still working on some smaller ones. PTAL. Thanks! Comment at: clang/include/clang/Tooling/Refactoring/Transformer.h:54 +/// boolean expression language for constructing

[PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

ymandel updated this revision to Diff 192172. ymandel marked an inline comment as done. ymandel added a comment. Split RewriteRule into two classes, remove support for where clause, support multi-token targets, and add corresponding tests. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D56803: clang -dumpversion returns 4.2.1 for legacy reason, update it

rnk added a comment. In D56803#1441876 , @sylvestre.ledru wrote: > @rnk btw, do you think it should be added to the clang release notes? I think it is release-note worthy. If you change __VERSION__, you can mention that as well.

[PATCH] D59008: [AMDGPU] Switch default dwarf version to 5

t-tye accepted this revision. t-tye added a comment. This revision is now accepted and ready to land. LGTM Do we know the state of split DWARF and DWARF compression for DWARF 5 (compared to DWARF 2)? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59008/new/

[PATCH] D56803: clang -dumpversion returns 4.2.1 for legacy reason, update it

This revision was automatically updated to reflect the committed changes. Closed by commit rL356931: clang -dumpversion returns 4.2.1 for legacy reason, update it (authored by sylvestre, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM

r356931 - clang -dumpversion returns 4.2.1 for legacy reason, update it

Author: sylvestre Date: Mon Mar 25 11:06:20 2019 New Revision: 356931 URL: http://llvm.org/viewvc/llvm-project?rev=356931=rev Log: clang -dumpversion returns 4.2.1 for legacy reason, update it Summary: It has been introduced in 2011 for gcc compat:

[PATCH] D56803: clang -dumpversion returns 4.2.1 for legacy reason, update it

sylvestre.ledru updated this revision to Diff 192159. sylvestre.ledru marked 3 inline comments as done. sylvestre.ledru edited the summary of this revision. sylvestre.ledru added a comment. Improve the test (thanks rnk) Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D56803: clang -dumpversion returns 4.2.1 for legacy reason, update it

sylvestre.ledru updated this revision to Diff 192160. sylvestre.ledru added a comment. Remove the empty directories Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56803/new/ https://reviews.llvm.org/D56803 Files: lib/Driver/Driver.cpp

[PATCH] D56803: clang -dumpversion returns 4.2.1 for legacy reason, update it

sylvestre.ledru added a comment. @rnk btw, do you think it should be added to the clang release notes? Comment at: lib/Driver/Driver.cpp:1631 -// introduce a non-pedantically GCC compatible mode to Clang in which we -// provide sensible definitions for -dumpversion,

[PATCH] D59725: Additions to creduce script

akhuang updated this revision to Diff 192149. akhuang added a comment. reuploaded diff with full context CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59725/new/ https://reviews.llvm.org/D59725 Files: clang/utils/creduce-clang-crash.py Index: clang/utils/creduce-clang-crash.py

r356929 - Moved everything SMT-related to LLVM and updated the cmake scripts.

Author: mramalho Date: Mon Mar 25 10:47:45 2019 New Revision: 356929 URL: http://llvm.org/viewvc/llvm-project?rev=356929=rev Log: Moved everything SMT-related to LLVM and updated the cmake scripts. Differential Revision: https://reviews.llvm.org/D54978 Added:

[PATCH] D59008: [AMDGPU] Switch default dwarf version to 5

scott.linder added a comment. Ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59008/new/ https://reviews.llvm.org/D59008 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59725: Additions to creduce script

akhuang updated this revision to Diff 192145. akhuang added a comment. Fix some typos, pass --tidy flag to creduce CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59725/new/ https://reviews.llvm.org/D59725 Files: clang/utils/creduce-clang-crash.py Index:

[PATCH] D59492: [OpenCL] Allow variadic macros as Clang feature

arsenm accepted this revision. arsenm added a comment. Herald added a subscriber: wdng. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59492/new/ https://reviews.llvm.org/D59492 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59774: [clang-format] Refine structured binding detection

This revision was automatically updated to reflect the committed changes. Closed by commit rL356928: [clang-format] Refine structured binding detection (authored by krasimir, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES

r356928 - [clang-format] Refine structured binding detection

Author: krasimir Date: Mon Mar 25 10:29:16 2019 New Revision: 356928 URL: http://llvm.org/viewvc/llvm-project?rev=356928=rev Log: [clang-format] Refine structured binding detection Summary: Revision r356575 had the unfortunate consequence that now clang-format never detects an ObjC call

RE: [clang-tools-extra] r356849 - [pp-trace] Modernize the code

Hi, Yes, it appears to have been fixed as of r356878. http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/24580 Douglas Yung -Original Message- From: Fāng-ruì Sòng Sent: Monday, March 25, 2019 4:41 To: Yung, Douglas Cc: cfe-commits Subject: Re:

[PATCH] D59734: [clang-tidy] Handle missing yaml module in run-clang-tidy.py

zinovy.nis updated this revision to Diff 192137. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59734/new/ https://reviews.llvm.org/D59734 Files: clang-tidy/tool/run-clang-tidy.py test/clang-tidy/run-clang-tidy.cpp Index: test/clang-tidy/run-clang-tidy.cpp

[PATCH] D59734: [clang-tidy] Handle missing yaml module in run-clang-tidy.py

zinovy.nis marked an inline comment as done. zinovy.nis added inline comments. Comment at: clang-tidy/tool/run-clang-tidy.py:210 +help='Create a yaml file to store suggested fixes in, ' +'which can be applied with

[PATCH] D56803: clang -dumpversion returns 4.2.1 for legacy reason, update it

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Code lgtm, with a suggestion to tighten the test. Comment at: lib/Driver/Driver.cpp:1631 -// introduce a non-pedantically GCC compatible mode to Clang in which we -//

[PATCH] D58827: [Sema][NFCI] Don't allocate storage for the various CorrectionCandidateCallback unless we are going to do some typo correction

This revision was automatically updated to reflect the committed changes. Closed by commit rL356925: [Sema][NFCI] Dont allocate storage for the various CorrectionCandidateCallback… (authored by brunoricci, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

r356925 - [Sema][NFCI] Don't allocate storage for the various CorrectionCandidateCallback unless we are going to do some typo correction

Author: brunoricci Date: Mon Mar 25 10:08:51 2019 New Revision: 356925 URL: http://llvm.org/viewvc/llvm-project?rev=356925=rev Log: [Sema][NFCI] Don't allocate storage for the various CorrectionCandidateCallback unless we are going to do some typo correction The various

[clang-tools-extra] r356923 - Attempt to fix sphinx bot after r356897

Author: nico Date: Mon Mar 25 09:50:24 2019 New Revision: 356923 URL: http://llvm.org/viewvc/llvm-project?rev=356923=rev Log: Attempt to fix sphinx bot after r356897 Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst URL:

r356920 - [clang] Remove cmake warning message (NFC)

Author: evandro Date: Mon Mar 25 09:38:48 2019 New Revision: 356920 URL: http://llvm.org/viewvc/llvm-project?rev=356920=rev Log: [clang] Remove cmake warning message (NFC) Recognize an empty string for CLANG_DEFAULT_UNWINDLIB as a valid option. Modified: cfe/trunk/CMakeLists.txt Modified:

[PATCH] D59743: [WebAssembly] Don't use default GetLinkerPath

sbc100 added inline comments. Comment at: clang/lib/Driver/ToolChains/Fuchsia.h:89 - const char *getDefaultLinker() const override { -return "ld.lld"; - } + const char *getDefaultLinker() const override { return "ld.lld"; } phosek wrote: > This seems

[PATCH] D59743: [WebAssembly] Don't use default GetLinkerPath

sbc100 updated this revision to Diff 192126. sbc100 marked 4 inline comments as done. sbc100 added a comment. - feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59743/new/ https://reviews.llvm.org/D59743 Files:

[PATCH] D59743: [WebAssembly] Don't use default GetLinkerPath

sbc100 updated this revision to Diff 192125. sbc100 marked an inline comment as done. sbc100 added a comment. - feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59743/new/ https://reviews.llvm.org/D59743 Files:

[PATCH] D59774: [clang-format] Refine structured binding detection

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59774/new/ https://reviews.llvm.org/D59774 ___ cfe-commits

[PATCH] D59759: [clangd] Add .cu files to VSCode extension

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE356916: [clangd] Add .cu files to VSCode extension (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D59759?vs=192109=192124#toc Repository: rCTE Clang

  1   2   >