[PATCH] D59802: [clang-tidy] Add new checker: llvm-avoid-cast-in-conditional

hintonda updated this revision to Diff 192778. hintonda added a comment. - Add isa and dyn_cast when matching for dyn_cast_or_null replacement. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59802/new/ https://reviews.llvm.org/D59802 Files:

[PATCH] D59923: [Driver] Simplify -g level computation and its interaction with -gsplit-dwarf

MaskRay updated this revision to Diff 192777. MaskRay edited the summary of this revision. MaskRay added a comment. Update description Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59923/new/ https://reviews.llvm.org/D59923 Files:

[PATCH] D59923: [Driver] Simplify -g level computation and its interaction with -gsplit-dwarf

MaskRay added a comment. In D59923#1447245 , @dblaikie wrote: > OK - could you include/describe which sets of options disable split-dwarf, > then? (adding that to the patch description along with the matrix of g1/2, > etc? I've already updated the

[PATCH] D59900: [Sema] Fix a crash when nonnull checking

This revision was automatically updated to reflect the committed changes. Closed by commit rL357236: [Sema] Fix a crash when nonnull checking (authored by hliao, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r357236 - [Sema] Fix a crash when nonnull checking

Author: hliao Date: Thu Mar 28 20:55:52 2019 New Revision: 357236 URL: http://llvm.org/viewvc/llvm-project?rev=357236=rev Log: [Sema] Fix a crash when nonnull checking Summary: - If a parameter is used, nonnull checking needs function prototype to retrieve the corresponding parameter's

[PATCH] D59923: [Driver] Simplify -g level computation and its interaction with -gsplit-dwarf

dblaikie added a comment. In D59923#1447198 , @MaskRay wrote: > In D59923#1446508 , @dblaikie wrote: > > > What's the general motivation for this work/changes? > > > The current -gsplit-dwarf handling is a bit

[PATCH] D59923: [Driver] Simplify -g level computation and its interaction with -gsplit-dwarf

MaskRay updated this revision to Diff 192770. MaskRay edited the summary of this revision. MaskRay added a comment. Handle -gsplit-dwarf= Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59923/new/ https://reviews.llvm.org/D59923 Files:

[PATCH] D59955: gn build: Add check-clang-tools to run clang-tools-extra lit tests

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE357232: gn build: Add check-clang-tools to run clang-tools-extra lit tests (authored by nico, committed by ). Herald added a project: clang. Changed prior to commit:

[clang-tools-extra] r357232 - gn build: Add check-clang-tools to run clang-tools-extra lit tests

Author: nico Date: Thu Mar 28 19:49:13 2019 New Revision: 357232 URL: http://llvm.org/viewvc/llvm-project?rev=357232=rev Log: gn build: Add check-clang-tools to run clang-tools-extra lit tests Only runs the clang-tools-extra lit tests; not yet the unit tests. Add a build file for clangd-indexer

[PATCH] D59953: Add .py extension to clang-tools-extra lit cfg files

This revision was automatically updated to reflect the committed changes. Closed by commit rL357231: Add .py extension to clang-tools-extra lit cfg files (authored by nico, committed by ). Herald added subscribers: llvm-commits, mstorsjo. Herald added a project: LLVM. Changed prior to commit:

[PATCH] D59923: [Driver] Simplify -g level computation and its interaction with -gsplit-dwarf

MaskRay marked an inline comment as done. MaskRay added a comment. In D59923#1446508 , @dblaikie wrote: > What's the general motivation for this work/changes? The current -gsplit-dwarf handling is a bit complex and the motivation is to make it less

[clang-tools-extra] r357231 - Add .py extension to clang-tools-extra lit cfg files

Author: nico Date: Thu Mar 28 19:46:31 2019 New Revision: 357231 URL: http://llvm.org/viewvc/llvm-project?rev=357231=rev Log: Add .py extension to clang-tools-extra lit cfg files Follow-up to r313892, which did this for clang and llvm. Differential Revision: https://reviews.llvm.org/D59953

[PATCH] D58797: [Sema] Add some compile time _FORTIFY_SOURCE diagnostics

erik.pilkington added a comment. Ah, looks like the problem is we're sending a dependent expression to the constant evaluator, we should just bail out in that case. I'll fix this tomorrow morning, thanks for tracking this down! Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D59121: [analyzer] Fix macro names in diagnostics within bigger macros.

NoQ updated this revision to Diff 192765. NoQ added a comment. An elegant solution for a more civilized age. Unfortunately, doesn't preserve the `UINT32_MAX` macro in the newly added test - i'll try a bit harder to preserve it. Relies on D59977 to work.

[PATCH] D59977: [Lexer] Fix an off-by-one bug in Lexer::getAsCharRange() - NFC.

NoQ created this revision. NoQ added reviewers: rsmith, dcoughlin, Szelethus. Herald added subscribers: cfe-commits, jdoerfert. Herald added a project: clang. As the unit test demonstrates, the `.getLocWithOffset(-1)` part was unnecessary. @rsmith - you introduced these functions, WDYT?, hope i

[PATCH] D59900: [Sema] Fix a crash when nonnull checking

hliao added a comment. just search bugzilla and, fortunately, found this issue is reported 2+ years ago @ https://bugs.llvm.org/show_bug.cgi?id=30559. I will revise the test case to PR30559 and move it into test/SemaCXX/nonnull.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D58797: [Sema] Add some compile time _FORTIFY_SOURCE diagnostics

phosek added a comment. This is triggering a Clang assertion failure in Fuchsia build: clang/lib/AST/ExprConstant.cpp:5032: bool (anonymous namespace)::ExprEvaluatorBase<(anonymous namespace)::PointerExprEvaluator>::VisitMemberExpr(const clang::MemberExpr *) [Derived = (anonymous

[PATCH] D59802: [clang-tidy] Add new checker: llvm-avoid-cast-in-conditional

hintonda added a comment. If the `dyn_cast_or_null<>` replacement is acceptable, I'll update the documentation and warning message -- suggestions are appreciated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59802/new/

[PATCH] D59802: [clang-tidy] Add new checker: llvm-avoid-cast-in-conditional

hintonda updated this revision to Diff 192761. hintonda added a comment. - Remove spurious auto's. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59802/new/ https://reviews.llvm.org/D59802 Files:

[PATCH] D59802: [clang-tidy] Add new checker: llvm-avoid-cast-in-conditional

hintonda added a comment. In D59802#1447127 , @Eugene.Zelenko wrote: > In D59802#1447108 , @hintonda wrote: > > > > > > It's good idea to follow modernize-use-auto convention without introducing > exceptions.

[PATCH] D59975: [fuchsia] Add clang-doc to Fuchsia distribution

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59975/new/ https://reviews.llvm.org/D59975 ___ cfe-commits mailing list

[PATCH] D59974: [clang-doc] Build as clang_tool

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59974/new/ https://reviews.llvm.org/D59974 ___ cfe-commits mailing list

[PATCH] D59974: [clang-doc] Build as clang_tool

juliehockett created this revision. juliehockett added reviewers: phosek, leonardchan. juliehockett added a project: clang-tools-extra. Herald added a subscriber: mgorny. Instead of as clang_executable. https://reviews.llvm.org/D59974 Files: clang-tools-extra/clang-doc/tool/CMakeLists.txt

[PATCH] D59802: [clang-tidy] Add new checker: llvm-avoid-cast-in-conditional

Eugene.Zelenko added a comment. In D59802#1447108 , @hintonda wrote: > It's good idea to follow modernize-use-auto convention without introducing exceptions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D54978: Move the SMT API to LLVM

gou4shi1 added a comment. My own out-of-tree pass `#include ` and use cmake's `add_llvm_library` to compile it into a `.so` However, `opt -load-pass-plugin=my-pass.so -passes="foo" bar.ll` fails: `opt: symbol lookup error: Passes/libStackPasses.so: undefined symbol: _ZN4llvm14CreateZ3SolverEv`

[PATCH] D59802: [clang-tidy] Add new checker: llvm-avoid-cast-in-conditional

hintonda marked an inline comment as done. hintonda added a comment. Comment at: clang-tools-extra/clang-tidy/llvm/AvoidCastInConditionalCheck.cpp:73 + Result.Nodes.getNodeAs("cast-assign")) { +auto StartLoc = MatchedDecl->getCallee()->getExprLoc(); +auto

[PATCH] D59802: [clang-tidy] Add new checker: llvm-avoid-cast-in-conditional

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/llvm/AvoidCastInConditionalCheck.cpp:73 + Result.Nodes.getNodeAs("cast-assign")) { +auto StartLoc = MatchedDecl->getCallee()->getExprLoc(); +auto EndLoc =

[PATCH] D59802: [clang-tidy] Add new checker: llvm-avoid-cast-in-conditional

hintonda updated this revision to Diff 192756. hintonda added a comment. - Remove commented code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59802/new/ https://reviews.llvm.org/D59802 Files:

[PATCH] D59802: [clang-tidy] Add new checker: llvm-avoid-cast-in-conditional

hintonda updated this revision to Diff 192754. hintonda added a comment. - Add replacement of `y && cast(y)` with `dyn_cast_or_null(y)`, which is at least as efficient, and can be a big win if `y` is a function call. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D59407: [clangd] Add RelationSlab

nridge added a comment. @sammccall, thank you for having a look at this. I have no objection to revising the data model if there's agreement on a better one. In D59407#1446464 , @sammccall wrote: > - I don't think we yet know what the more

[PATCH] D59797: [COFF] Reorder fields in Chunk and SectionChunk to reduce their size

rnk added a comment. I added one last size optimization, replacing a std::vector with a forward linked list and a custom iterator for it. PTAL Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59797/new/ https://reviews.llvm.org/D59797

[PATCH] D59797: [COFF] Reorder fields in Chunk and SectionChunk to reduce their size

rnk updated this revision to Diff 192752. rnk added a comment. - Replace std::vector<> with singly linked list Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59797/new/ https://reviews.llvm.org/D59797 Files: lld/COFF/Chunks.cpp

[PATCH] D53076: [analyzer] ConditionBRVisitor: enhance to write out more information

NoQ added a comment. Instead of having those as events similar to "Assuming", we could turn the new "Knowing" pieces into floating pop-ups - imagine you hover the mouse over a condition `foo()` and it says "`foo()` is false". That is, instead of `PathDiagnosticsEventPiece`, a new kind of piece

[PATCH] D59761: [ASTImporter] Convert ODR diagnostics inside ASTImporter implementation

shafik accepted this revision. shafik added a comment. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59761/new/ https://reviews.llvm.org/D59761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r357229 - [CodeGen][ObjC] Adjust the addresses passed to calls to synthesized

Author: ahatanak Date: Thu Mar 28 17:23:20 2019 New Revision: 357229 URL: http://llvm.org/viewvc/llvm-project?rev=357229=rev Log: [CodeGen][ObjC] Adjust the addresses passed to calls to synthesized copy/move constructor/assignment operator functions for non-trivial C structs. This commit fixes a

r357228 - Fix typos and formatting. NFC.

Author: ahatanak Date: Thu Mar 28 17:23:17 2019 New Revision: 357228 URL: http://llvm.org/viewvc/llvm-project?rev=357228=rev Log: Fix typos and formatting. NFC. Modified: cfe/trunk/lib/CodeGen/CGNonTrivialStruct.cpp Modified: cfe/trunk/lib/CodeGen/CGNonTrivialStruct.cpp URL:

[PATCH] D59922: [Attributor] Deduce "no-capture" argument attribute

jdoerfert marked 2 inline comments as done. jdoerfert added inline comments. Comment at: llvm/test/Transforms/FunctionAttrs/arg_nocapture.ll:103 -; FIXME: returned missing for %a ; FIXME: We should *not* derive any attributes for the return value not present on the argument!

[PATCH] D59919: [Attributor] Deduce "returned" argument attribute

jdoerfert updated this revision to Diff 192738. jdoerfert added a comment. Fix the last bug exposed by llvm-test-suite & SPEC2006 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59919/new/ https://reviews.llvm.org/D59919 Files:

[PATCH] D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior.

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. Hello Raphael, I think we should accept this change. I don't see an easy way to merge the LLDB stuff into ASTImporter; also, this patch provides a good extension point for ASTImporter

[PATCH] D59761: [ASTImporter] Convert ODR diagnostics inside ASTImporter implementation

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. Yes, I think this is fine. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59761/new/ https://reviews.llvm.org/D59761

r357220 - [MS] Make __iso_volatile_* available on all targets

Author: rnk Date: Thu Mar 28 15:59:09 2019 New Revision: 357220 URL: http://llvm.org/viewvc/llvm-project?rev=357220=rev Log: [MS] Make __iso_volatile_* available on all targets Future versions of MSVC make these intrinsics available on x86 & x64, according to:

[PATCH] D59665: Call to HandleNameConflict in VisitEnumDecl mistakeningly using Name instead of SearchName

a_sidorin accepted this revision. a_sidorin added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59665/new/ https://reviews.llvm.org/D59665 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59963: Add a clang-tidy module for the Linux kernel.

Eugene.Zelenko added a comment. I think linuxkernel name will be less ambiguous. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59963/new/ https://reviews.llvm.org/D59963 ___ cfe-commits mailing list

[PATCH] D59665: Call to HandleNameConflict in VisitEnumDecl mistakeningly using Name instead of SearchName

martong added a comment. In D59665#1446764 , @a_sidorin wrote: > Hi Shafik, > Thank you for the explanation, it is much more clear to me now. But, as I > see, D59692 is going to discard the changes > this patch

[PATCH] D59449: [clang-tidy] Integrate clang-tidy-diff.py machinery into run-clang-tidy.py

thakis added a comment. Can we delete clang-tidy-diff.py with this? (Or delete most of its contents and make it forward to this script?) Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59449/new/ https://reviews.llvm.org/D59449

[PATCH] D59900: [Sema] Fix a crash when nonnull checking

tra added inline comments. Comment at: clang/test/SemaTemplate/decltype.cpp:1 +// RUN: %clang_cc1 -std=c++11 -fsyntax-only -verify %s +// no crash & no diag Rakete wrote: > test/SemaCXX/nonnull.cpp would be a better place to put this test.

[PATCH] D59963: Add a clang-tidy module for the Linux kernel.

lebedev.ri added a comment. Missing `docs/ReleaseNotes.rst` and `docs/clang-tidy/index.rst` changes. Comment at: clang-tools-extra/clang-tidy/linux/LinuxTidyModule.cpp:13 + +using namespace clang::ast_matchers; + You don't need this here. Repository: rG

[PATCH] D59963: Add a clang-tidy module for the Linux kernel.

tmroeder added reviewers: aaron.ballman, gribozavr. tmroeder added a comment. Not sure if you are the right reviewers; I just looked back in the commit history to see who reviewed clang-tidy changes recently. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D59955: gn build: Add check-clang-tools to run clang-tools-extra lit tests

mbonadei accepted this revision. mbonadei added a comment. This revision is now accepted and ready to land. Really nice work! LGTM (also patched locally and tested). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59955/new/ https://reviews.llvm.org/D59955

[PATCH] D59879: [ARM][CMSE] Add commandline option and feature macro

snidertm added inline comments. Comment at: lib/Basic/Targets/ARM.cpp:438 +} else if (Feature == "+8msecext") { + if ((CPUProfile != "M" && CPUProfile != "B") || ArchVersion != 8) { +Diags.Report(diag::err_target_unsupported_mcmse) << CPU; How

[PATCH] D59963: Add a clang-tidy module for the Linux kernel.

tmroeder created this revision. Herald added subscribers: cfe-commits, jdoerfert, mgorny. Herald added a project: clang. Now that clang is going to be able to build the Linux kernel again on x86, and we have gen_compile_commands.py upstream for generating compile_commands.json, clang-tidy can be

[PATCH] D59845: Fix IsStructuralMatch specialization for EnumDecl to prevent re-importing an EnumDecl while trying to complete it

a_sidorin added a comment. Post-LGTM with some stylish nits. Comment at: cfe/trunk/lib/AST/ASTImporter.cpp:1950 + // Eliminate a potential failure point where we attempt to re-import + // something we're trying to import while completin ToEnum + if (Decl *ToOrigin =

[PATCH] D59900: [Sema] Fix a crash when nonnull checking

Rakete accepted this revision. Rakete added a comment. This revision is now accepted and ready to land. Otherwise LGTM. Comment at: clang/test/SemaTemplate/decltype.cpp:1 +// RUN: %clang_cc1 -std=c++11 -fsyntax-only -verify %s +// no crash & no diag

[PATCH] D59665: Call to HandleNameConflict in VisitEnumDecl mistakeningly using Name instead of SearchName

a_sidorin added a comment. Hi Shafik, Thank you for the explanation, it is much more clear to me now. But, as I see, D59692 is going to discard the changes this patch introduces. @martong Gabor, do you expect the changes of this patch to be merged into yours,

[PATCH] D59692: [ASTImporter] Fix name conflict handling

a_sidorin added a comment. Thanks for the fixes! I'd like to clarify one moment, however. Comment at: lib/AST/ASTImporter.cpp:2154 +return NameOrErr.takeError(); } } Should we write `else Name = *NameOrError`? Repository: rC Clang CHANGES

[PATCH] D59934: Compare SourceLocations from different TUs by FileID

Szelethus added a reviewer: Szelethus. Szelethus added a comment. In D59934#1446051 , @gamesh411 wrote: > Hi! > > This issue came up during the generation BugReports of BugPaths containing > macro-expansions, where the spelling location and expansion

Re: r356598 - Recommit "Support attribute used in member funcs of class templates"

Full LTO. Oh, so your build bot is using thinLTO. I’ll keep an eye in thinLTO builds. From: Michael Spencer Date: Thursday, March 28, 2019 at 1:27 PM To: Rafael Auler Cc: "cfe-commits@lists.llvm.org" Subject: Re: r356598 - Recommit "Support attribute used in member funcs of class templates"

Re: r356598 - Recommit "Support attribute used in member funcs of class templates"

On Tue, Mar 26, 2019 at 7:40 PM Rafael Auler wrote: > I’m familiar with this issue as I had to fix a memory bug in LLVM IRLinker > that was exposed by this commit. That’s why I initially reverted it. > However, after fixing it, I was able to do the full clang LTO self-hosting > with lld on

[PATCH] D59628: Add support for __attribute__((objc_class_stub))

slavapestov added a comment. I don't know what the etiquette is around here about pinging reviewers for a re-review, but this CL is ready for another look. Your feedback is much appreciated! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59628/new/ https://reviews.llvm.org/D59628

[PATCH] D59955: gn build: Add check-clang-tools to run clang-tools-extra lit tests

thakis created this revision. thakis added a reviewer: mbonadei. Herald added subscribers: kadircet, arphaman, jkorous, ioeric, ilya-biryukov, mgorny. Herald added a project: LLVM. Only runs the clang-tools-extra lit tests; not yet the unit tests. Add a build file for clangd-indexer too, since

r357205 - [OPENMP]Add check for undefined behavior with thread allocators on

Author: abataev Date: Thu Mar 28 12:15:36 2019 New Revision: 357205 URL: http://llvm.org/viewvc/llvm-project?rev=357205=rev Log: [OPENMP]Add check for undefined behavior with thread allocators on target and task-based directives. According to OpenMP 5.0, 2.11.4 allocate Clause, Restrictions, For

[PATCH] D59953: Add .py extension to clang-tools-extra lit cfg files

thakis updated this revision to Diff 192698. thakis retitled this revision from "Rename clang-tools-extra lit cfg files to lit.site.cfg.py" to "Add .py extension to clang-tools-extra lit cfg files". thakis added a comment. Ok, ptal. CHANGES SINCE LAST ACTION

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

VelocityRa updated this revision to Diff 192694. VelocityRa marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D28462/new/ https://reviews.llvm.org/D28462 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/Format.cpp

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

VelocityRa added inline comments. Comment at: lib/Format/WhitespaceManager.cpp:520 + + AlignMacroSequence(StartOfSequence, EndOfSequence, MinColumn, MaxColumn, + FoundMatchOnLine, AlignMacrosMatches, Changes); klimek wrote: > Why are we

[PATCH] D59953: Rename clang-tools-extra lit cfg files to lit.site.cfg.py

thakis added a comment. Actually, let me rename lit.cfg to lit.cfg.py too, one sec... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59953/new/ https://reviews.llvm.org/D59953 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59953: Rename clang-tools-extra lit cfg files to lit.site.cfg.py

thakis created this revision. thakis added a reviewer: zturner. Herald added a subscriber: mgorny. thakis added a comment. Actually, let me rename lit.cfg to lit.cfg.py too, one sec... Follow-up to r313892, which did this for clang and llvm. https://reviews.llvm.org/D59953 Files:

[PATCH] D59932: [clang-tidy] **Prototype**: Add fix description to clang-tidy checks.

Eugene.Zelenko added a comment. In D59932#1446533 , @JonasToth wrote: > I think the idea is good and implementation, too. If we iterate all checks > anyway (probably?) we could think about adding a severity to the checks, too? > > I know that

[PATCH] D59870: [clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop-variable

JonasToth added a comment. > I think it's the easiest way to specify the bits of the ineteger type to > limit the catches. In real life, I met with this overflow / infinite loop > problem with 16-bit short type, so I think the real use cases are 8 and 16 > bit integers. It seems intuitive to

[PATCH] D59932: [clang-tidy] **Prototype**: Add fix description to clang-tidy checks.

JonasToth added a comment. I think the idea is good and implementation, too. If we iterate all checks anyway (probably?) we could think about adding a severity to the checks, too? I know that code-checker and code-compass have something like this to signal importance of problems (say bugprone

[PATCH] D59932: [clang-tidy] **Prototype**: Add fix description to clang-tidy checks.

Eugene.Zelenko added inline comments. Comment at: clang-tidy/ClangTidyCheck.h:107 + /// fixes for different cases. + /// - clang compiler diagnostics and clang static analyzer diagnostics are + /// not supported. I think Clang and Clang Static

[PATCH] D59923: [Driver] Simplify -g level computation and its interaction with -gsplit-dwarf

dblaikie requested changes to this revision. dblaikie added a comment. This revision now requires changes to proceed. What's the general motivation for this work/changes? > -gmlt -gsplit-dwarf -fno-split-dwarf-inlining => special: 1 (before) 2 (after) This ^ is the only semantic change due to

[PATCH] D59008: [AMDGPU] Switch default dwarf version to 5

scott.linder updated this revision to Diff 192688. scott.linder added a comment. Add a test to confirm split-dwarf is supported for the amdhsa OS in the driver. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59008/new/ https://reviews.llvm.org/D59008 Files:

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

gribozavr added inline comments. Comment at: clang/include/clang/Tooling/Syntax/TokenBuffer.h:69 + /// The tokens after preprocessor replacements. + llvm::ArrayRef tokens(const TokenBuffer ) const; + /// Tokens that appear in the text of the file, i.e. a name of an

[PATCH] D53343: [Driver] Default Android toolchains to noexecstack.

This revision was automatically updated to reflect the committed changes. Closed by commit rC357197: [Driver] Default Android toolchains to noexecstack. (authored by danalbert, committed by ). Changed prior to commit: https://reviews.llvm.org/D53343?vs=169901=192686#toc Repository: rC Clang

[PATCH] D59407: [clangd] Add RelationSlab

sammccall added a comment. (Sorry to arrive late at this discussion, I'm just back from leave. I have some suggestions and would appreciate your thoughts, but if simply this feels too much like going around in circles I'm happy to work out how we can address this after this patch lands instead.

r357197 - [Driver] Default Android toolchains to noexecstack.

Author: danalbert Date: Thu Mar 28 11:08:28 2019 New Revision: 357197 URL: http://llvm.org/viewvc/llvm-project?rev=357197=rev Log: [Driver] Default Android toolchains to noexecstack. Android does not support executable stacks. Reviewers: srhines, pirama Reviewed By: pirama Subscribers:

[PATCH] D59811: [clangd] Add fallback mode for code completion when compile command or preamble is not ready.

ioeric added a comment. In D59811#1445701 , @ilya-biryukov wrote: > I think this option should be configurable (and off by default) for the > transition period. A few reasons to do so: > > - Before we have an actual implementation of fallback

[PATCH] D59811: [clangd] Add fallback mode for code completion when compile command or preamble is not ready.

ioeric updated this revision to Diff 192683. ioeric marked 9 inline comments as done. ioeric added a comment. - address review comments. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59811/new/ https://reviews.llvm.org/D59811 Files:

r357195 - [WebAssembly] Reland of rL356953 (4dcf3acce6)

Author: sbc Date: Thu Mar 28 10:45:18 2019 New Revision: 357195 URL: http://llvm.org/viewvc/llvm-project?rev=357195=rev Log: [WebAssembly] Reland of rL356953 (4dcf3acce6) The previous patch was missing GetProgramPath() in the return value of getLinkerPath(). See https://reviews.llvm.org/D59743

r357187 - Make helper functions static. NFC.

Author: d0k Date: Thu Mar 28 10:18:42 2019 New Revision: 357187 URL: http://llvm.org/viewvc/llvm-project?rev=357187=rev Log: Make helper functions static. NFC. Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp cfe/trunk/lib/Sema/SemaOpenMP.cpp

[PATCH] D59814: [Testing] Move clangd::Annotations to llvm testing support

ilya-biryukov added a comment. I've added a FIXME to the class. Also want to add some basic tests before landing this. Comment at: clang-tools-extra/unittests/clangd/Annotations.h:8 //===--===// -// -//

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

klimek added inline comments. Comment at: lib/Format/WhitespaceManager.cpp:520 + + AlignMacroSequence(StartOfSequence, EndOfSequence, MinColumn, MaxColumn, + FoundMatchOnLine, AlignMacrosMatches, Changes); Why are we calling

[PATCH] D59814: [Testing] Move clangd::Annotations to llvm testing support

ilya-biryukov updated this revision to Diff 192673. ilya-biryukov marked 4 inline comments as done. ilya-biryukov added a comment. - Move Range into the body of Annotations - Use triple-slash comments - Added a FIXME that we might want to change the syntax - Move the doc comment to the class

[PATCH] D59935: Disable warnings when indexing as a standalone action.

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rL357186: Disable warnings when indexing as a standalone action. (authored by sammccall, committed by ). Herald added a project: LLVM. Herald added a subscriber:

[PATCH] D54881: [clang-format] Prevent Clang-Format from editing leading whitespace on lines outside of the format range

klimek added a comment. I just verified why this doesn't break for our CI: The trick is that if the indent is actually off (as opposed to being correct, but tab vs spaces), we do re-indent until we find an indent that's correct. The fix that would make me happier, I think, is to do the same

[clang-tools-extra] r357186 - Disable warnings when indexing as a standalone action.

Author: sammccall Date: Thu Mar 28 10:07:28 2019 New Revision: 357186 URL: http://llvm.org/viewvc/llvm-project?rev=357186=rev Log: Disable warnings when indexing as a standalone action. Summary: - we don't record the warnings at all - we don't want to stop indexing if we hit error-limit due to

[PATCH] D59873: Add additional mangling for struct members of non trivial structs

This revision was automatically updated to reflect the committed changes. Closed by commit rL357184: [CodeGen] Add additional mangling for struct members of non trivial structs (authored by smeenai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D59725: Additions to creduce script

akhuang updated this revision to Diff 192669. akhuang marked 3 inline comments as done. akhuang added a comment. Add preprocessing with clang -E only; use `with` for opening files CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59725/new/ https://reviews.llvm.org/D59725 Files:

r357184 - [CodeGen] Add additional mangling for struct members of non trivial structs

Author: smeenai Date: Thu Mar 28 10:01:20 2019 New Revision: 357184 URL: http://llvm.org/viewvc/llvm-project?rev=357184=rev Log: [CodeGen] Add additional mangling for struct members of non trivial structs In https://bugs.llvm.org/show_bug.cgi?id=41206 we observe bad codegen when embedding a

[PATCH] D59725: Additions to creduce script

akhuang added inline comments. Comment at: clang/utils/creduce-clang-crash.py:212 + +cmd = self.get_crash_cmd() + ['-E', '-P'] +try: arichardson wrote: > Some crash messages might include the line numbers, do you think it makes > sense to fall back to

[PATCH] D59814: [Testing] Move clangd::Annotations to llvm testing support

gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: llvm/include/llvm/Testing/Support/Annotations.h:9 // // Annotations lets you mark points and ranges inside source code, for tests: //

[PATCH] D59899: gn build: Add some build files for clangd

This revision was automatically updated to reflect the committed changes. Closed by commit rL357182: gn build: Add some build files for clangd (authored by nico, committed by ). Changed prior to commit: https://reviews.llvm.org/D59899?vs=192509=192663#toc Repository: rL LLVM CHANGES SINCE

[clang-tools-extra] r357182 - gn build: Add some build files for clangd

Author: nico Date: Thu Mar 28 09:53:32 2019 New Revision: 357182 URL: http://llvm.org/viewvc/llvm-project?rev=357182=rev Log: gn build: Add some build files for clangd Enough to build the clangd binaries, but this is still missing build files for: - fuzzer - indexer - index/dex/dexp - benchmarks

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

ilya-biryukov updated this revision to Diff 192661. ilya-biryukov added a comment. - s/macroMacroInvocation/something else... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59887/new/ https://reviews.llvm.org/D59887 Files:

[PATCH] D59899: gn build: Add some build files for clangd

thakis marked 2 inline comments as done. thakis added a comment. Thanks! Landing with comments addressed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59899/new/ https://reviews.llvm.org/D59899 ___ cfe-commits mailing list

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

ilya-biryukov updated this revision to Diff 192660. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - Rename macro expansion to macro invocation everywhere - Tweak comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D59873: Add additional mangling for struct members of non trivial structs

smeenai added a comment. Looks good. I'll commit this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59873/new/ https://reviews.llvm.org/D59873 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59935: Disable warnings when indexing as a standalone action.

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clangd/index/IndexAction.cpp:138 CI.getLangOpts().CommentOpts.ParseAllComments = true; +// Index the whole file even if there are warnings and

[PATCH] D59923: [Driver] Simplify -g level computation and its interaction with -gsplit-dwarf

probinson accepted this revision. probinson added a comment. This revision is now accepted and ready to land. LGTM. I wish it had occurred to me to pass both OPT_g_Group and OPT_gsplit_dwarf to the same getLastArgs call in the first place. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D59873: Add additional mangling for struct members of non trivial structs

danzimm added a comment. @smeenai good idea on the third level! Yep, I'll need somebody to commit this for me, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59873/new/ https://reviews.llvm.org/D59873

  1   2   >