[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev added a comment. In D58675#1449053 , @thakis wrote: > ps: Hooray for landing this, and thanks for the cool feature! Thanks! It's @aras_p accomplishment. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev added a comment. In D58675#1449051 , @thakis wrote: > Looks like this landed without tests. Please add tests in a follow-up. > > Also, it looks like the flag is currently a cc1 flag. This should probably be > a CoreOption instead so that

[PATCH] D60040: [clangd] Use capacity() instead of size() in RefSlab::bytes()

nridge added a comment. This was suggested in this comment . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60040/new/ https://reviews.llvm.org/D60040

[PATCH] D60040: [clangd] Use capacity() instead of size() in RefSlab::bytes()

nridge created this revision. nridge added a reviewer: gribozavr. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D60040 Files:

[PATCH] D57560: [clangd] Link libclangAST into clangd tool

nridge abandoned this revision. nridge added a comment. Herald added a subscriber: cfe-commits. Abandoning as this has been fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57560/new/ https://reviews.llvm.org/D57560

[PATCH] D60038: gn build: Add build files for most clang-tools-extra unit tests

thakis created this revision. thakis added a reviewer: mbonadei. Herald added subscribers: jdoerfert, kadircet, arphaman, jkorous, ioeric, mgorny, srhines. Herald added a project: LLVM. https://reviews.llvm.org/D60038 Files: clang-tools-extra/unittests/clang-tidy/CMakeLists.txt

[PATCH] D59934: Compare SourceLocations from different TUs by FileID

gamesh411 added a comment. In D59934#1446059 , @lebedev.ri wrote: > Test? Thanks for the remark :) I agree, that there should be at least a unit test asserting the right behaviour. I am working on it. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

thakis added a comment. ps: Hooray for landing this, and thanks for the cool feature! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58675/new/ https://reviews.llvm.org/D58675 ___ cfe-commits mailing list

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

thakis added a comment. Looks like this landed without tests. Please add tests in a follow-up. Also, it looks like the flag is currently a cc1 flag. This should probably be a CoreOption instead so that both the gcc-style and the cl-style drivers expose it. Right now, users can't really use

[clang-tools-extra] r357356 - Rename IncludeFixerTests to ClangIncludeFixerTests and ChangeNamespaceTests to ClangChangeNamespaceTests

Author: nico Date: Sat Mar 30 16:09:10 2019 New Revision: 357356 URL: http://llvm.org/viewvc/llvm-project?rev=357356=rev Log: Rename IncludeFixerTests to ClangIncludeFixerTests and ChangeNamespaceTests to ClangChangeNamespaceTests Follow-up to r356897 and r356254. Modified:

[PATCH] D59934: Compare SourceLocations from different TUs by FileID

gamesh411 added a comment. Just have a bit more context, I have the following information from a debug session at the execution point of the unreachable: (rr) p LHS.dump(*this) ./tmux-2.8/compat/tree.h:721:9 (rr) p RHS.dump(*this)

[PATCH] D59934: Compare SourceLocations from different TUs by FileID

gamesh411 added a comment. In D59934#1446736 , @Szelethus wrote: > In D59934#1446051 , @gamesh411 wrote: > > > Hi! > > > > This issue came up during the generation BugReports of BugPaths containing > >

[PATCH] D59919: [Attributor] Deduce "returned" argument attribute

xbolva00 added inline comments. Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:394 + +indicateFixpoint(/* Optimistic */ true); +return; Maybe enum here ? So you could call indicateFixpoint(Fixpoint::optimistic) ? Or maybe even better,

[PATCH] D59467: [clang] Adding the Likelihood Attribute from C++2a

riccibruno added a subscriber: NoQ. riccibruno added a comment. It seems that the tests are not present in this diff ? Also, again, could you please: 1. Use `clang-format`, and 2. Make sure that the comments are full sentences with appropriate punctuation, and 3. Follow the style guide

[PATCH] D60029: Add const children() accessors to Stmts

riccibruno added a comment. In D60029#1448944 , @nicolas wrote: > In D60029#1448938 , @riccibruno > wrote: > > > Did you go over all the statements on `Stmt.h` systematically ? > > > Yes. > > > You could also do

[PATCH] D60029: Add const children() accessors to Stmts

nicolas added a comment. In D60029#1448938 , @riccibruno wrote: > Did you go over all the statements on `Stmt.h` systematically ? Yes. > You could also do the same thing for all of the statements/expressions in > `StmtCXX.h`, `Expr.h`, `ExprCXX.h`,

[PATCH] D59806: [clang-tidy] Add a check for [super self] in initializers 

aaron.ballman added a comment. In D59806#1447929 , @jordan_rose wrote: > I don't think there's ever a reason to call `[super self]`, and doing so > through a macro could easily indicate a bug. Thank you for the verification! And agreed about the macro

[PATCH] D60029: Add const children() accessors to Stmts

riccibruno added a comment. +1. I wanted to do this but never bothered. Did you go over all the statements on `Stmt.h` systematically ? You could also do the same thing for all of the statements/expressions in `StmtCXX.h`, `Expr.h`, `ExprCXX.h`, and so on. Apart from this did you run

[PATCH] D59467: [clang] Adding the Likelihood Attribute from C++2a

Tyker updated this revision to Diff 192979. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59467/new/ https://reviews.llvm.org/D59467 Files: clang/include/clang/AST/Stmt.h clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td

r357348 - [cmake] Change deprecated $ to $. NFC

Author: maskray Date: Sat Mar 30 07:38:51 2019 New Revision: 357348 URL: http://llvm.org/viewvc/llvm-project?rev=357348=rev Log: [cmake] Change deprecated $ to $. NFC See rL357338 for a similar change. The informational expression $ has been deprecated since CMake 3.0 Modified:

r357344 - [clang-format]: Add NonEmptyParentheses spacing option

Author: reuk Date: Sat Mar 30 05:32:35 2019 New Revision: 357344 URL: http://llvm.org/viewvc/llvm-project?rev=357344=rev Log: [clang-format]: Add NonEmptyParentheses spacing option This patch aims to add support for the following rules from the JUCE coding standards: - Always put a space

r357340 - Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps.

Author: anton-afanasyev Date: Sat Mar 30 01:42:48 2019 New Revision: 357340 URL: http://llvm.org/viewvc/llvm-project?rev=357340=rev Log: Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps. This change adds hierarchical "time trace"

[PATCH] D60029: Add const children() accessors to Stmts

nicolas created this revision. nicolas added reviewers: bkramer, rsmith. nicolas added a project: clang. Herald added a subscriber: cfe-commits. Exprs already have children() const but not Stmts. All the changes are very simple, except for `DeclStmt` where I used a `const_cast`. Repository:

[PATCH] D59684: [clang-format] [PR41187] moves Java import statements to the wrong location if code contains statements that start with the word import

This revision was automatically updated to reflect the committed changes. Closed by commit rC357345: [clang-format] [PR41187] moves Java import statements to the wrong location if… (authored by paulhoad, committed by ). Herald added a project: clang. Changed prior to commit:

[PATCH] D55170: [clang-format]: Add NonEmptyParentheses spacing option

This revision was automatically updated to reflect the committed changes. Closed by commit rL357344: [clang-format]: Add NonEmptyParentheses spacing option (authored by reuk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D60023: [libcxx] [test] Fix inability to rebind poca_alloc in string.cons/copy_alloc.pass.cpp.

BillyONeal marked an inline comment as done. BillyONeal added inline comments. Comment at: test/std/strings/basic.string/string.cons/copy_alloc.pass.cpp:125 test_assign(s1, s2); assert(s1 == p1); assert(s2 == p2); This particular assert tests that

[PATCH] D60023: [libcxx] [test] Fix inability to rebind poca_alloc in string.cons/copy_alloc.pass.cpp.

BillyONeal marked 2 inline comments as done. BillyONeal added inline comments. Comment at: test/std/strings/basic.string/string.cons/copy_alloc.pass.cpp:123 imp2.deactivate(); test_assign(s1, s2); BillyONeal wrote: > We still fail this test in debug

[PATCH] D60023: [libcxx] [test] Fix inability to rebind poca_alloc in string.cons/copy_alloc.pass.cpp.

BillyONeal added inline comments. Comment at: test/std/strings/basic.string/string.cons/copy_alloc.pass.cpp:123 imp2.deactivate(); test_assign(s1, s2); We still fail this test in debug mode because we need to allocate a new _Container_proxy from

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

This revision was automatically updated to reflect the committed changes. Closed by commit rL357340: Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing`… (authored by anton-afanasyev, committed by ). Herald added a subscriber: kristina. Changed prior to commit:

[PATCH] D59922: [Attributor] Deduce "no-capture" argument attribute

jdoerfert updated this revision to Diff 192962. jdoerfert added a comment. Closed a side-channel through "integers" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59922/new/ https://reviews.llvm.org/D59922 Files: clang/test/CodeGenObjC/os_log.m