ilya-biryukov added a comment.
Found an issue today.
Input (break a line at ^):
// here is my comment ^// another comment
Expected:
// here is my comment
^// another comment
Actual (an extra comment marker is added):
// here is my comment
// // another comment
Repository:
rCTE
Author: kadircet
Date: Wed Apr 24 02:42:53 2019
New Revision: 359079
URL: http://llvm.org/viewvc/llvm-project?rev=359079&view=rev
Log:
[clangd] Fix handling of include paths in windows tests
Modified:
clang-tools-extra/trunk/unittests/clangd/CodeCompleteTests.cpp
clang-tools-extra/trunk/u
Author: kadircet
Date: Wed Apr 24 02:23:31 2019
New Revision: 359078
URL: http://llvm.org/viewvc/llvm-project?rev=359078&view=rev
Log:
[clang][HeaderSuggestion] Handle the case of dotdot with an absolute path
Summary:
Include insertion in clangd was inserting absolute paths when the
include direc
This revision was automatically updated to reflect the committed changes.
Closed by commit rL359078: [clang][HeaderSuggestion] Handle the case of dotdot
with an absolute path (authored by kadircet, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prio
Author: kadircet
Date: Wed Apr 24 02:23:31 2019
New Revision: 359078
URL: http://llvm.org/viewvc/llvm-project?rev=359078&view=rev
Log:
[clang][HeaderSuggestion] Handle the case of dotdot with an absolute path
Summary:
Include insertion in clangd was inserting absolute paths when the
include direc
This revision was automatically updated to reflect the committed changes.
Closed by commit rC359077: Fix unquoted spaces in args in clang --verbose
output (authored by hans, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D60997?vs=196191&id=196398#toc
Repository:
rC Clang
Author: hans
Date: Wed Apr 24 02:06:03 2019
New Revision: 359077
URL: http://llvm.org/viewvc/llvm-project?rev=359077&view=rev
Log:
Fix unquoted spaces in args in clang --verbose output
The behaviour of not quoting spaces appears to have been introduced by
mistake in r190620.
Patch by Brad Moody!
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61029/new/
https://reviews.llvm.org/D61029
___
cfe-commits mailing list
cfe-commits@lists
Reverted in r359076.
On Wed, Apr 24, 2019 at 10:28 AM Ilya Biryukov wrote:
> Hi Richard,
>
> This seems to break libc++, found while doing an integrate. The errors are:
>
> In file included from valarray:4:
> .../include/c++/v1/valarray:1062:60: error: explicit instantiation
> declaration of 'va
Author: ibiryukov
Date: Wed Apr 24 01:50:24 2019
New Revision: 359076
URL: http://llvm.org/viewvc/llvm-project?rev=359076&view=rev
Log:
Revert r359048: C++ DR2387: a variable template declared wthi
The change breaks libc++ with the follwing error:
In file included from valarray:4:
.../include/c+
Author: kadircet
Date: Wed Apr 24 01:45:03 2019
New Revision: 359075
URL: http://llvm.org/viewvc/llvm-project?rev=359075&view=rev
Log:
[clang][HeaderSearch] Make sure there are no backslashes in suggestedPath
Reviewers: sammccall
Differential Revision: https://reviews.llvm.org/D60995
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL359075: [clang][HeaderSearch] Make sure there are no
backslashes in suggestedPath (authored by kadircet, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prio
Hi Richard,
This seems to break libc++, found while doing an integrate. The errors are:
In file included from valarray:4:
.../include/c++/v1/valarray:1062:60: error: explicit instantiation
declaration of 'valarray<_Tp>' with internal linkage
_LIBCPP_EXTERN_TEMPLATE(_LIBCPP_FUNC_VIS valarray::vala
kadircet updated this revision to Diff 196393.
kadircet added a comment.
- Update comments to focus on forward slashes
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60995/new/
https://reviews.llvm.org/D60995
Files:
clang/include/clang/Lex/Header
sammccall added inline comments.
Comment at: clang/include/clang/Lex/HeaderSearch.h:710
+ /// Suggest a path by which the specified file could be found, for use in
+ /// diagnostics to suggest a #include. Returned path will be valid for
+ /// include-directive.
---
kadircet updated this revision to Diff 196392.
kadircet added a comment.
- Update documentation
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60995/new/
https://reviews.llvm.org/D60995
Files:
clang/include/clang/Lex/HeaderSearch.h
clang/lib/Le
nikic added inline comments.
Comment at: llvm/trunk/unittests/IR/ConstantRangeTest.cpp:398-401
+#if defined(__GNUC__) && __GNUC__ >= 7
+// Silence warning: variable 'HaveInterrupt3' set but not used
+(void)&HaveInterrupt3;
+#endif
tstellar wrote:
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Thanks!
Can you document this in `HeaderSearch.h`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60995/new/
https://reviews.llvm.org/D6099
101 - 118 of 118 matches
Mail list logo
