[PATCH] D61963: [clang][Darwin] Refactor header search path logic into the driver

This revision was automatically updated to reflect the committed changes. Closed by commit rC361278: [clang][Darwin] Refactor header search path logic into the driver (authored by ldionne, committed by ). Changed prior to commit: https://reviews.llvm.org/D61963?vs=200311&id=200539#toc Reposito

r361278 - [clang][Darwin] Refactor header search path logic into the driver

Author: ldionne Date: Tue May 21 10:48:04 2019 New Revision: 361278 URL: http://llvm.org/viewvc/llvm-project?rev=361278&view=rev Log: [clang][Darwin] Refactor header search path logic into the driver Summary: This commit moves the logic for determining system, resource and C++ header search paths

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ymandel marked 4 inline comments as done. ymandel added a comment. Thanks for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61386/new/ https://reviews.llvm.org/D61386 ___ cfe-commits mailin

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ymandel updated this revision to Diff 200536. ymandel added a comment. Renamed TransformerTidy to TransformerClangTidyCheck; classes and files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61386/new/ https://reviews.llvm.org/D61386 Files: clang

r361275 - [CMake] One more stab at fixing BUILD_SHARED_LIBS

Author: cbieneman Date: Tue May 21 10:30:59 2019 New Revision: 361275 URL: http://llvm.org/viewvc/llvm-project?rev=361275&view=rev Log: [CMake] One more stab at fixing BUILD_SHARED_LIBS If clang's libraries are build SHARED, we need to grab their `PRIVATE_LINK_LIBRARIES` properties and add those

r361274 - Do not use the incorrect attribute spelling list index when translating a no_sanitize_foo attribute into a no_sanitize("foo") attribute.

Author: aaronballman Date: Tue May 21 10:24:49 2019 New Revision: 361274 URL: http://llvm.org/viewvc/llvm-project?rev=361274&view=rev Log: Do not use the incorrect attribute spelling list index when translating a no_sanitize_foo attribute into a no_sanitize("foo") attribute. This fixes a crash w

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

gribozavr added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/TransformerTidy.h:32 +// }; +class TransformerTidy : public ClangTidyCheck { +public: ymandel wrote: > gribozavr wrote: > > I'd prefer a name like "TransformerClangTidyCheck", it will

[PATCH] D62208: [OpenCL] Enable queue_t and clk_event_t comparisons in C++ mode

svenvh created this revision. svenvh added a reviewer: Anastasia. Herald added subscribers: cfe-commits, yaxunl. Herald added a project: clang. Support queue_t and clk_event_t comparisons in C++ for OpenCL mode, to preserve backwards compatibility with OpenCL C. Repository: rC Clang https://r

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ymandel marked 2 inline comments as done. ymandel added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/TransformerTidy.h:32 +// }; +class TransformerTidy : public ClangTidyCheck { +public: gribozavr wrote: > I'd prefer a name like "TransformerCla

[PATCH] D62202: Work around a Visual C++ bug

dblaikie added a comment. In D62202#1510449 , @probinson wrote: > In D62202#1510414 , @dblaikie wrote: > > > Technically this violates the LLVM style guide which says "make anonymous > > namespaces as small as poss

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

gribozavr added inline comments. Comment at: clang/lib/DirectoryWatcher/linux/DirectoryWatcher-linux.cpp:136 + +const int PollResult = poll(&PollReq, 1, TimeoutMs); +// There are inotify events waiting to be read! jkorous wrote: > gribozav

[PATCH] D62202: Work around a Visual C++ bug

probinson added a comment. In D62202#1510414 , @dblaikie wrote: > Technically this violates the LLVM style guide which says "make anonymous > namespaces as small as possible, and only use them for class declarations." > (preferring static for functions)

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/utils/TransformerTidy.h:32 +// }; +class TransformerTidy : public ClangTidyCheck { +public: I'd prefer a n

[PATCH] D61909: Add Clang shared library with C++ exports

beanz added a comment. @E5ten, I just pushed r361271, which should resolve your issue. I have a better longer-term fix in mind that I'll put up for review this week. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61909/new/ https://reviews.llvm.org/D61909

[PATCH] D62202: Work around a Visual C++ bug

dblaikie added a comment. In D62202#1510394 , @probinson wrote: > To provide some missing details: > The original source gets a bogus compile-time error with Visual Studio 2017, > prior to version 15.8. I have 15.2, so I need this patch to build Clang.

r361271 - Fix BUILD_SHARED_LIBS for clang which broke in D61909

Author: cbieneman Date: Tue May 21 08:56:17 2019 New Revision: 361271 URL: http://llvm.org/viewvc/llvm-project?rev=361271&view=rev Log: Fix BUILD_SHARED_LIBS for clang which broke in D61909 llvm_add_library ignores `BUILD_SHARED_LIBS` `STATIC` is explicitly specified. This restores the `BUILD_SH

[PATCH] D62192: [clang-tidy]: Add cert-oop54-cpp alias for bugprone-unhandled-self-assignment

Eugene.Zelenko added a comment. Please mention alias (in aliases list) in Release Notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62192/new/ https://reviews.llvm.org/D62192 ___ cfe-commits mailing

[PATCH] D62202: Work around a Visual C++ bug

probinson added a comment. To provide some missing details: The original source gets a bogus compile-time error with Visual Studio 2017, prior to version 15.8. I have 15.2, so I need this patch to build Clang. Our current minimum-version requirement (per CheckCompilerVersion.cmake) is Visual St

[PATCH] D61909: Add Clang shared library with C++ exports

beanz added a comment. @E5ten, I see what is going on. Give me 30 minutes and I’ll have a fix pushed. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61909/new/ https://reviews.llvm.org/D61909 ___ cfe-commits mailing l

[PATCH] D61643: [PragmaHandler][NFC] Expose `#pragma` location

jdenny marked an inline comment as done. jdenny added inline comments. Comment at: clang/docs/ClangPlugins.rst:58 ExamplePragmaHandler() : PragmaHandler("example_pragma") { } -void HandlePragma(Preprocessor &PP, PragmaIntroducerKind Introducer, +void HandlePragma(Pre

[PATCH] D58920: [Modules][PR39287] Consolidate multiple std's

modocache updated this revision to Diff 200518. modocache added a comment. Hmm... alright, I'm not really sure how I could implement a test that fails without this, but I added a check in the FindExistingResult destructor. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D62202: Work around a Visual C++ bug

probinson created this revision. probinson added reviewers: aaron.ballman, rnk. Herald added a project: clang. Herald added a subscriber: cfe-commits. Put up for review because I'm not clear whether this should be considered a permanent fix, or if I should put some sort of comment here indicating

[PATCH] D61643: [PragmaHandler][NFC] Expose `#pragma` location

lebedev.ri accepted this revision. lebedev.ri added a comment. No one raised any concerns, so let's do **this**. Comment at: clang/docs/ClangPlugins.rst:58 ExamplePragmaHandler() : PragmaHandler("example_pragma") { } -void HandlePragma(Preprocessor &PP, PragmaIntroduce

r361269 - [OPENMP][NVPTX]Mark more functions as always_inline for better

Author: abataev Date: Tue May 21 08:11:58 2019 New Revision: 361269 URL: http://llvm.org/viewvc/llvm-project?rev=361269&view=rev Log: [OPENMP][NVPTX]Mark more functions as always_inline for better performance. Internally generated functions must be marked as always_inlines in most cases. Patch ma

[PATCH] D62201: [LibTooling] Adjust dependencies for unittests.

ymandel created this revision. ymandel added a reviewer: thakis. Herald added a subscriber: mgorny. Herald added a project: clang. Fix a redundant dependency and move another to its proper place. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D62201 Files: clang/unittests/Too

Re: r361152 - [LibTooling] Add RangeSelector library for defining source ranges based on bound AST nodes.

https://reviews.llvm.org/D62201 On Tue, May 21, 2019 at 10:15 AM Nico Weber wrote: > I'm suggesting you make the below change. For testing, I'd just try > building locally. > > $ git diff > diff --git a/clang/unittests/Tooling/CMakeLists.txt > b/clang/unittests/Tooling/CMakeLists.txt > index 8c3

[PATCH] D62200: [Driver][Windows] Add dependent lib argument for -fprofile-generate and -fcs-profile-generate

russell.gallop created this revision. russell.gallop added reviewers: rnk, hans, bogner. russell.gallop added a project: clang. Follows on from r360674 which added it for -fprofile-instr-generate. Identified when doing: https://reviews.llvm.org/D62063 Repository: rG LLVM Github Monorepo http

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

Fznamznon updated this revision to Diff 200513. Fznamznon added a comment. Herald added a subscriber: mgorny. Added semantics for new attributes - Added semantics for new attributes. Now complier can separate SYCL device code from host code using new arrtributes. - Removed spelling for sycl_dev

[PATCH] D61643: [PragmaHandler][NFC] Expose `#pragma` location

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/docs/ClangPlugins.rst:58 ExamplePragmaHandler() : PragmaHandler("example_pragma") { } -void HandlePragma(Preprocessor &PP, Prag

[PATCH] D62192: [clang-tidy]: Add cert-oop54-cpp alias for bugprone-unhandled-self-assignment

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some nits, thank you for this! Comment at: clang-tools-extra/clang-tidy/bugprone/UnhandledSelfAssignmentCheck.cpp:89-91 +AdditionalMatcher

[PATCH] D61637: [Syntax] Introduce syntax trees

ilya-biryukov added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Corpus.h:38 + std::pair> + tokenizeBuffer(std::unique_ptr Buffer); + sammccall wrote: > ilya-biryukov wrote: > > sammccall wrote: > > > Are you planning to have a way to add tok

[PATCH] D62174: [Analysis] Link library dependencies to Analysis plugins

hintonda accepted this revision. hintonda added a comment. This revision is now accepted and ready to land. LGTM. Build and check-llvm were both clean on my Mac for static build. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62174/new/ https://reviews.l

[PATCH] D62197: [OpenCL] Fix file-scope const sampler variable for 2.0

yaxunl updated this revision to Diff 200509. yaxunl added a comment. Add full diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62197/new/ https://reviews.llvm.org/D62197 Files: lib/Sema/SemaType.cpp test/CodeGenOpenCL/sampler.cl test/SemaOpenCL/sampler_t.cl Index: test/SemaOp

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

ABataev accepted this revision. ABataev added a comment. LG. Please, commit it only after the runtime part is committed. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 ___ cf

r361265 - Add support for dumping AST comment nodes to JSON.

Author: aaronballman Date: Tue May 21 07:38:29 2019 New Revision: 361265 URL: http://llvm.org/viewvc/llvm-project?rev=361265&view=rev Log: Add support for dumping AST comment nodes to JSON. Added: cfe/trunk/test/AST/ast-dump-comment-json.cpp Modified: cfe/trunk/include/clang/AST/JSONNodeD

[PATCH] D62197: [OpenCL] Fix file-scope const sampler variable for 2.0

yaxunl created this revision. yaxunl added a reviewer: Anastasia. OpenCL spec v2.0 s6.13.14: Samplers can also be declared as global constants in the program source using the following syntax. const sampler_t = This works fine for OpenCL 1.2 but fails for 2.0, because clang duduces

r361264 - [Syntax] Rename TokensTest to SyntaxTests. NFC

Author: ibiryukov Date: Tue May 21 07:37:41 2019 New Revision: 361264 URL: http://llvm.org/viewvc/llvm-project?rev=361264&view=rev Log: [Syntax] Rename TokensTest to SyntaxTests. NFC To be more consistent with conventions used in the codebase. The new name will be a better fit when more bits of t

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

ilya-biryukov added a comment. In D59887#1508991 , @thakis wrote: > Out of interest: The RecursiveASTVisitorTests are part of the ToolingTests > binary while this adds a new binary TokensTest. Can you say why? > > (No change needed, just curious.) The s

[PATCH] D61643: [PragmaHandler][NFC] Expose `#pragma` location

jdenny marked an inline comment as done. jdenny added inline comments. Comment at: clang/docs/ClangPlugins.rst:58 ExamplePragmaHandler() : PragmaHandler("example_pragma") { } -void HandlePragma(Preprocessor &PP, PragmaIntroducerKind Introducer, +void HandlePragma(Pre

[PATCH] D61865: [clangd] improve help message for limit-results

umanwizard added a comment. @kadircet what are the next steps? This is my first diff in llvm. I'm not a project member so presumably someone else will have to land it for me. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61865/new/ https://reviews.

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea updated this revision to Diff 200504. gtbercea added a comment. - Remove new option. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h lib/

[PATCH] D61637: [Syntax] Introduce syntax trees

sammccall added a comment. Definitely like the choice of CompositeNode owning the concrete storage! Comment at: clang/include/clang/Tooling/Syntax/Arena.h:1 +//===- Arena.h - memory arena and bookkeeping for syntax trees --- C++ -*-===// +// From a user's point

[PATCH] D61643: [PragmaHandler][NFC] Expose `#pragma` location

jdenny marked an inline comment as done. jdenny added inline comments. Comment at: clang/docs/ClangPlugins.rst:58 ExamplePragmaHandler() : PragmaHandler("example_pragma") { } -void HandlePragma(Preprocessor &PP, PragmaIntroducerKind Introducer, +void HandlePragma(Pre

[PATCH] D59879: [ARM][CMSE] Add commandline option and feature macro

This revision was automatically updated to reflect the committed changes. Closed by commit rC361261: [ARM][CMSE] Add commandline option and feature macro (authored by javed.absar, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59879/new/ https://rev

[PATCH] D62152: [ARM][AArch64] Fix incorrect handling of alignment in va_arg code generation

john.brawn added a comment. In D62152#1508979 , @efriedma wrote: > Please verify my understanding of the following is correct: > > 1. getTypeUnadjustedAlign() is currently only used to compute calling > convention alignment for ARM and AArch64. Yes, the

r361261 - [ARM][CMSE] Add commandline option and feature macro

Author: javed.absar Date: Tue May 21 07:21:26 2019 New Revision: 361261 URL: http://llvm.org/viewvc/llvm-project?rev=361261&view=rev Log: [ARM][CMSE] Add commandline option and feature macro Defines macro ARM_FEATURE_CMSE to 1 for v8-M targets and introduces -mcmse option which for v8-M targets s

Re: r361152 - [LibTooling] Add RangeSelector library for defining source ranges based on bound AST nodes.

I'm suggesting you make the below change. For testing, I'd just try building locally. $ git diff diff --git a/clang/unittests/Tooling/CMakeLists.txt b/clang/unittests/Tooling/CMakeLists.txt index 8c383be2d74..af8a35d9251 100644 --- a/clang/unittests/Tooling/CMakeLists.txt +++ b/clang/unittests/Too

[PATCH] D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files

shixiao added a comment. @JonasToth, does this look reasonable to you? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61989/new/ https://reviews.llvm.org/D61989 ___ cfe-commits mailing list cfe-

[PATCH] D60763: Prototype OpenCL BIFs using Tablegen

Pierre updated this revision to Diff 200499. Pierre marked 9 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60763/new/ https://reviews.llvm.org/D60763 Files: clang/include/clang/Basic/CMakeLists.txt clang/include/clang/Basic/LangOptions.def clang/include/cla

[PATCH] D60763: Prototype OpenCL BIFs using Tablegen

Pierre added a comment. The wrong patch was uploaded. Sorry for this. Comment at: clang/utils/TableGen/ClangOpenCLBuiltinEmitter.cpp:107 + //<, 35>. + // TODO: Check the other types of vector available for performance purpose + std::vector, unsigned>> SignatureSet; -

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: lib/Frontend/CompilerInvocation.cpp:2840 Opts.OpenMP && Args.hasArg(options::OPT_fopenmp_is_device); + Opts.OpenMPHasTargets = + Opts.OpenMP && Args.hasArg(options::OPT_fopenmp_tar

[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values

djtodoro updated this revision to Diff 200486. djtodoro added a comment. -Use `SPCache` instead of `DeclCache` -Refactor the code by addressing suggestions CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58035/new/ https://reviews.llvm.org/D58035 Files: lib/CodeGen/CGDebugInfo.cpp li

[PATCH] D62135: [clangd] Turn no-parse-completion on by when preamble isn't ready. Add flag to force it.

This revision was automatically updated to reflect the committed changes. Closed by commit rL361258: [clangd] Turn no-parse-completion on by when preamble isn't ready. Add flag to… (authored by sammccall, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repos

[clang-tools-extra] r361258 - [clangd] Turn no-parse-completion on by when preamble isn't ready. Add flag to force it.

Author: sammccall Date: Tue May 21 06:40:31 2019 New Revision: 361258 URL: http://llvm.org/viewvc/llvm-project?rev=361258&view=rev Log: [clangd] Turn no-parse-completion on by when preamble isn't ready. Add flag to force it. Reviewers: kadircet Subscribers: ilya-biryukov, MaskRay, jkorous, arph

[PATCH] D58033: Add option for emitting dbg info for call site parameters

djtodoro updated this revision to Diff 200485. djtodoro added a comment. -Set `EnableDebugEntryValues` only for a higher level of optimizations (-O1 and higher) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58033/new/ https://reviews.llvm.org/D58033 Files: include/clang/Basic/CodeGe

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

ABataev added inline comments. Comment at: lib/Frontend/CompilerInvocation.cpp:2840 Opts.OpenMP && Args.hasArg(options::OPT_fopenmp_is_device); + Opts.OpenMPHasTargets = + Opts.OpenMP && Args.hasArg(options::OPT_fopenmp_targets_EQ); We already have `

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ymandel added a comment. Ping. Is anyone willing to be the reviewer for this revision? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61386/new/ https://reviews.llvm.org/D61386 ___ cfe-commits

[PATCH] D56933: [Tooling][RFC] Introduce Stencil library to simplify source code generation in refactorings.

ymandel abandoned this revision. ymandel added a comment. This ideas in this revisions are gradually being committed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56933/new/ https://reviews.llvm.org/D56933 __

[PATCH] D43576: Solution to fix PR27066 - Redefinition with same mangled name as another definition (dllexport and uuid)

zahiraam updated this revision to Diff 200484. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43576/new/ https://reviews.llvm.org/D43576 Files: include/clang/AST/Decl.h include/clang/AST/RecursiveASTVisitor.h include/clang/Basic/Attr.td include/clang/Basic/DeclNodes.td include/c

[PATCH] D43576: Solution to fix PR27066 - Redefinition with same mangled name as another definition (dllexport and uuid)

zahiraam added a comment. And this patch actually fixes the bug. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43576/new/ https://reviews.llvm.org/D43576 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D59329: [LibTooling] Add NodeId, a strong type for AST-matcher node identifiers.

ymandel abandoned this revision. ymandel marked an inline comment as done. ymandel added inline comments. Comment at: clang/include/clang/Tooling/Refactoring/NodeId.h:29 +public: + explicit NodeId(std::string Id) : Id(std::move(Id)) {} + ilya-biryukov wrote: > W

[PATCH] D61909: Add Clang shared library with C++ exports

E5ten added a comment. I might be doing something wrong but this seems to have broken BUILD_SHARED_LIBS for me in that even with that enabled clang is built as a bunch of static libraries linked into a shared one like this patch is supposed to make it do, while I thought that BUILD_SHARED_LIBS

[PATCH] D62115: fix a issue that clang is incompatible with gcc with -H option.

lebedev.ri added inline comments. Comment at: lib/Frontend/HeaderIncludeGen.cpp:55 + // Simplify Filename that starts with "./" + if (Filename.startswith("./")); +Filename=Filename.substr(2); skan wrote: > lebedev.ri wrote: > > skan wrote: > > > craig.toppe

[PATCH] D62115: fix a issue that clang is incompatible with gcc with -H option.

skan marked an inline comment as done. skan added inline comments. Comment at: lib/Frontend/HeaderIncludeGen.cpp:55 + // Simplify Filename that starts with "./" + if (Filename.startswith("./")); +Filename=Filename.substr(2); lebedev.ri wrote: > skan wrote:

[PATCH] D62192: [clang-tidy]: Add cert-oop54-cpp alias for bugprone-unhandled-self-assignment

ztamas created this revision. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Added WarnOnlyIfThisHasSuspiciousField option to allow to catch any copy assignment operator independently from the container class's fields. Added the cert alias using this option. Rep

[clang-tools-extra] r361252 - [clangd] Add tweak to convert normal to raw string literal, when it contains escapes.

Author: sammccall Date: Tue May 21 06:04:24 2019 New Revision: 361252 URL: http://llvm.org/viewvc/llvm-project?rev=361252&view=rev Log: [clangd] Add tweak to convert normal to raw string literal, when it contains escapes. Reviewers: ilya-biryukov Subscribers: mgorny, MaskRay, jkorous, arphaman,

[PATCH] D62151: [clangd] Add tweak to convert normal to raw string literal, when it contains escapes.

This revision was automatically updated to reflect the committed changes. Closed by commit rL361252: [clangd] Add tweak to convert normal to raw string literal, when it contains… (authored by sammccall, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Reposit

[PATCH] D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard

aaron.ballman added a comment. In D61508#1509368 , @trixirt wrote: > Latest change addresses most of issues. > Outstanding is adding a test when garbage GuardStyle value is fed into > config. > The trial testcase used only CHECK-*-NOT which caused compl

[PATCH] D62187: Delete default constructors, copy constructors, move constructors, copy assignment, move assignment operators on Expr, Stmt and Decl

gribozavr created this revision. gribozavr added reviewers: ilya-biryukov, rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D62187 Files: clang/include/clang/AST/DeclBase.h clang/include/clang/AST/Ex

[PATCH] D60672: [libclang] visit c++14 lambda capture init expressions

milianw added a comment. thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60672/new/ https://reviews.llvm.org/D60672 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

r361242 - [CodeGenModule] BlockByrefHelpers - add missing uninitialized variables to constructor. NFCI.

Author: rksimon Date: Tue May 21 04:37:54 2019 New Revision: 361242 URL: http://llvm.org/viewvc/llvm-project?rev=361242&view=rev Log: [CodeGenModule] BlockByrefHelpers - add missing uninitialized variables to constructor. NFCI. Modified: cfe/trunk/lib/CodeGen/CodeGenModule.h Modified: cfe/t

r361238 - [CGBuiltin] dumpRecord - remove unused field offset. NFCI.

Author: rksimon Date: Tue May 21 03:48:42 2019 New Revision: 361238 URL: http://llvm.org/viewvc/llvm-project?rev=361238&view=rev Log: [CGBuiltin] dumpRecord - remove unused field offset. NFCI. Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp URL: h

[PATCH] D60763: Prototype OpenCL BIFs using Tablegen

Pierre marked an inline comment as done. Pierre added inline comments. Comment at: clang/include/clang/Basic/OpenCLBuiltins.td:298-302 +def write_imagef : Builtin<"write_imagef", +[void_t, + image2d_WO_t, +

[PATCH] D62181: [OpenCL] Support pipe keyword in C++ mode

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62181/new/ https://reviews.llvm.org/D62181 ___

[PATCH] D62184: [AST] Add RecoveryExpr; produce it on overload resolution failure and missing member.

sammccall created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman, ilya-biryukov. Herald added a project: clang. In many places, Sema refuses to create an Expr if it encounters an error. This means that broken code has no representation in the AST. As well as the broken no

[PATCH] D60763: Prototype OpenCL BIFs using Tablegen

Anastasia added inline comments. Comment at: clang/include/clang/Basic/OpenCLBuiltins.td:243 +// == Builtin definitions == +// This section defines builtin functions found in the OpenCL 1.2 specification + Anastasia wrote: > found in -> from ping!

[PATCH] D62115: fix a issue that clang is incompatible with gcc with -H option.

skan added a comment. In D62115#1509536 , @kimgr wrote: > Should you also consider Windows path separators here? Do you mean "\\" separator? i build llvm on windows, and use clang to complie file with -H option. The output pathname also use "/" as path

[PATCH] D62181: [OpenCL] Support pipe keyword in C++ mode

svenvh created this revision. svenvh added a reviewer: Anastasia. Herald added subscribers: cfe-commits, yaxunl. Herald added a project: clang. Support the OpenCL C pipe feature in C++ for OpenCL mode, to preserve backwards compatibility with OpenCL C. Repository: rC Clang https://reviews.ll

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

Rakete updated this revision to Diff 200440. Rakete added a comment. Add support for implicit typenames of the form T::template U Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53847/new/ https://reviews.llvm.org/D53847 Files: clang/inclu

[PATCH] D62135: [clangd] Turn no-parse-completion on by when preamble isn't ready. Add flag to force it.

sammccall updated this revision to Diff 200438. sammccall marked an inline comment as done. sammccall added a comment. deduplicate default Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62135/new/ https://reviews.llvm.org/D62135 Files: clangd/Clan

[PATCH] D62135: [clangd] Turn no-parse-completion on by when preamble isn't ready. Add flag to force it.

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clangd/CodeComplete.h:128 +/// Always use text-based completion. +NeverParse, + } RunParser = ParseIfReady; kadircet wrote: > Do we really have any real use case for

[PATCH] D62064: [ASTImporter] Fix unhandled cases in ASTImporterLookupTable

martong marked 2 inline comments as done. martong added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:4259 static const RecordDecl * getRecordDeclOfFriend(FriendDecl *FD) { QualType Ty = FD->getFriendType()->getType(); + if (auto *Inner = dyn_cast(Ty.g

[PATCH] D62064: [ASTImporter] Fix unhandled cases in ASTImporterLookupTable

martong updated this revision to Diff 200435. martong marked an inline comment as done. martong added a comment. - Remove getUnderlyingType Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62064/new/ https://reviews.llvm.org/D62064 Files: clang/lib

[PATCH] D48116: [libclang] Allow skipping warnings from all included files

nik added a comment. Jan? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48116/new/ https://reviews.llvm.org/D48116 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D50993: [clangd] Increase stack size of the new threads on macOS

Dmitry.Kozhevnikov updated this revision to Diff 200432. Dmitry.Kozhevnikov changed the repository for this revision from rCTE Clang Tools Extra to rG LLVM Github Monorepo. Dmitry.Kozhevnikov added a comment. moved to the monorepo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D60672: [libclang] visit c++14 lambda capture init expressions

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC361234: [libclang] visit c++14 lambda capture init expressions (authored by nik, committed by ). Changed prior to commit:

r361234 - [libclang] visit c++14 lambda capture init expressions

Author: nik Date: Tue May 21 02:21:35 2019 New Revision: 361234 URL: http://llvm.org/viewvc/llvm-project?rev=361234&view=rev Log: [libclang] visit c++14 lambda capture init expressions Patch by Milian Wolff. Differential Revision: https://reviews.llvm.org/D60672 Added: cfe/trunk/test/Index/

[PATCH] D60672: [libclang] visit c++14 lambda capture init expressions

milianw added a comment. Do you have commit rights? Can you push that for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60672/new/ https://reviews.llvm.org/D60672 ___ cfe-commits mailing list cfe-c

[PATCH] D62151: [clangd] Add tweak to convert normal to raw string literal, when it contains escapes.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62151/new/ https://reviews.llvm.org/D62151 __

[PATCH] D60672: [libclang] visit c++14 lambda capture init expressions

nik added a comment. > Are you sure you have compiled this patch? If I comment out the visit of the > InitExpr in CIndex.cpp again, then I get the same failure as you... Huch, I've indeed somehow missed to compile. Sorry for that. Works fine after compilation :) LGTM. Repository: rG LLVM G

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

Rakete marked an inline comment as done. Rakete added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:4859 // recurse to handle whatever we get. -if (TryAnnotateTypeOrScopeToken()) +if (TryAnnotateTypeOrScopeToken(!getCurScope()->isTemplateParamSco

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

Rakete updated this revision to Diff 200423. Rakete marked 10 inline comments as done. Rakete added a comment. - Addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53847/new/ https://reviews.llvm.org/D53847 Files:

[PATCH] D61865: [clangd] improve help message for limit-results

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61865/new/ https://reviews.llvm.org/D61865 ___

[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT

nik added a comment. Ping. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61487/new/ https://reviews.llvm.org/D61487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module.

srhines added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/android-cloexec-pipe2.rst:19 + + pipe2(pipefd, O_CLOEXEC); Shouldn't this be "O_NONBLOCK | O_CLOEXEC" instead? Why drop the O_NONBLOCK? Repository: rG LLVM Github Monorepo

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

This revision was automatically updated to reflect the committed changes. Closed by commit rC361226: [Preamble] Reuse preamble even if an unsaved file does not exist (authored by nik, committed by ). Changed prior to commit: https://reviews.llvm.org/D41005?vs=198809&id=200415#toc Repository:

r361226 - [Preamble] Reuse preamble even if an unsaved file does not exist

Author: nik Date: Tue May 21 00:26:59 2019 New Revision: 361226 URL: http://llvm.org/viewvc/llvm-project?rev=361226&view=rev Log: [Preamble] Reuse preamble even if an unsaved file does not exist When a preamble is created an unsaved file not existing on disk is already part of PrecompiledPreamble

[PATCH] D61851: [clang-tidy] New option for misc-throw-by-value-catch-by-reference

This revision was automatically updated to reflect the committed changes. Closed by commit rL361225: [clang-tidy] New option for misc-throw-by-value-catch-by-reference (authored by baloghadamsoftware, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[clang-tools-extra] r361225 - [clang-tidy] New option for misc-throw-by-value-catch-by-reference

Author: baloghadamsoftware Date: Tue May 21 00:25:06 2019 New Revision: 361225 URL: http://llvm.org/viewvc/llvm-project?rev=361225&view=rev Log: [clang-tidy] New option for misc-throw-by-value-catch-by-reference Catching trivial objects by value is not dangerous but may be inefficient if they are

[PATCH] D60763: Prototype OpenCL BIFs using Tablegen

AlexeySotkin added inline comments. Comment at: clang/include/clang/Basic/OpenCLBuiltins.td:298-302 +def write_imagef : Builtin<"write_imagef", +[void_t, + image2d_WO_t, + VectorType, +

<    1   2   3   >