[PATCH] D62615: [CodeComplete] Include more text into typed chunks of pattern completions

ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added a project: clang. To allow filtering on any of the words in the editors. In particular, the following completions were changed: - 'using namespace <#name#>' Typed text before: 'using', after: 'using name

[PATCH] D62559: [WebAssembly] Support VPtr sanitizer for Emscripten

This revision was automatically updated to reflect the committed changes. Closed by commit rL362004: [WebAssembly] Support VPtr sanitizer for Emscripten (authored by tlively, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://

[PATCH] D62496: [analyzer] print() JSONify: CFG implementation

This revision was automatically updated to reflect the committed changes. Closed by commit rL362003: [analyzer] print() JSONify: CFG implementation (authored by Charusso, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revi

r362004 - [WebAssembly] Support VPtr sanitizer for Emscripten

Author: tlively Date: Wed May 29 11:31:50 2019 New Revision: 362004 URL: http://llvm.org/viewvc/llvm-project?rev=362004&view=rev Log: [WebAssembly] Support VPtr sanitizer for Emscripten Summary: After https://github.com/emscripten-core/emscripten/pull/8651, Emscripten supports the full UBSan runt

r362003 - [analyzer] print() JSONify: CFG implementation

Author: charusso Date: Wed May 29 11:29:31 2019 New Revision: 362003 URL: http://llvm.org/viewvc/llvm-project?rev=362003&view=rev Log: [analyzer] print() JSONify: CFG implementation Summary: - Reviewers: NoQ, xazax.hun, ravikandhadai, baloghadamsoftware, Szelethus Reviewed By: NoQ Subscribers:

[PATCH] D62496: [analyzer] print() JSONify: CFG implementation

Charusso added a comment. In D62496#1518696 , @NoQ wrote: > It's just for escaping weird symbols in pretty-prints, right? Fair enough! Yea, because it writes out both Decl and Stmt craziness. Repository: rC Clang CHANGES SINCE LAST ACTION https://

[PATCH] D62495: [analyzer] print() JSONify: Decl revision

This revision was automatically updated to reflect the committed changes. Closed by commit rL362002: [analyzer] print() JSONify: Decl revision (authored by Charusso, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.l

[PATCH] D62580: [OpenCL] Use long instead of long long in x86 builtins

alexbatashev added a comment. In D62580#1521234 , @erichkeane wrote: > 'O' is an interesting choice. Any real justification for it, or just "what > was available"? It definitely needs to be documented in the top of > Builtins.def however. O is for **

r362002 - [analyzer] print() JSONify: Decl revision

Author: charusso Date: Wed May 29 11:21:14 2019 New Revision: 362002 URL: http://llvm.org/viewvc/llvm-project?rev=362002&view=rev Log: [analyzer] print() JSONify: Decl revision Summary: - Reviewers: NoQ, xazax.hun, ravikandhadai, baloghadamsoftware, Szelethus Reviewed By: NoQ Subscribers: cfe-

[PATCH] D62494: [analyzer][AST] print() JSONify: Stmt implementation

This revision was automatically updated to reflect the committed changes. Closed by commit rC362000: [analyzer][AST] print() JSONify: Stmt implementation (authored by Charusso, committed by ). Changed prior to commit: https://reviews.llvm.org/D62494?vs=201909&id=201996#toc Repository: rC Cla

r362000 - [analyzer][AST] print() JSONify: Stmt implementation

Author: charusso Date: Wed May 29 11:17:18 2019 New Revision: 362000 URL: http://llvm.org/viewvc/llvm-project?rev=362000&view=rev Log: [analyzer][AST] print() JSONify: Stmt implementation Summary: This patch also adds a function called `JsonFormat()` which: - Flattens the string so removes the ne

[PATCH] D62551: [analyzer][Dominator] Add post dominator tree builder for the CFG + a debug checker

Szelethus updated this revision to Diff 201995. Szelethus added a comment. Cascade the test file readability improvement from the previous patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62551/new/ https://reviews.llvm.org/D62551 Files: clang/include/clang/Analysis/Analyses/Domi

[PATCH] D62507: [Dominators] PR42041: Skip nullpointer successors

Szelethus updated this revision to Diff 201994. Szelethus added a comment. Drastically improve the readability of the test files. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62507/new/ https://reviews.llvm.org/D62507 Files: clang/include/clang/Analysis/Analyses/Dominators.h clang

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D62346: [analyzer] print() JSONify: getNodeLabel implementation

This revision was automatically updated to reflect the committed changes. Closed by commit rC361997: [analyzer] print() JSONify: getNodeLabel implementation (authored by Charusso, committed by ). Changed prior to commit: https://reviews.llvm.org/D62346?vs=201988&id=201990#toc Repository: rC

r361997 - [analyzer] print() JSONify: getNodeLabel implementation

Author: charusso Date: Wed May 29 11:05:53 2019 New Revision: 361997 URL: http://llvm.org/viewvc/llvm-project?rev=361997&view=rev Log: [analyzer] print() JSONify: getNodeLabel implementation Summary: This patch also rewrites the ProgramPoint printing. Reviewers: NoQ, xazax.hun, ravikandhadai, ba

[PATCH] D62611: [analyzer][Dominators] Add unittests

NoQ added inline comments. Comment at: clang/unittests/Analysis/CFGDominatorTree.cpp:37 +TEST(CFGDominatorTree, DomTree) { + const char *Code = "enum Kind {\n" + " A\n" kuhar wrote: > You can use a raw string literal to make it more readable

[PATCH] D62346: [analyzer] print() JSONify: getNodeLabel implementation

Charusso updated this revision to Diff 201988. Charusso marked 4 inline comments as done. Charusso added a comment. - Remove unintended spaces. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62346/new/ https://reviews.llvm.org/D62346 Files: clang/include/clang/Analysis/ProgramPoint.h

[PATCH] D62611: [analyzer][Dominators] Add unittests

kuhar added inline comments. Comment at: clang/unittests/Analysis/CFGDominatorTree.cpp:95 + CFGPostDomTree PostDom; + PostDom.buildDominatorTree(cfg); + Why not have a constructor that takes the cfg and constructs a domtree straight away? But this should proba

[PATCH] D62611: [analyzer][Dominators] Add unittests

kuhar added inline comments. Comment at: clang/unittests/Analysis/CFGDominatorTree.cpp:37 +TEST(CFGDominatorTree, DomTree) { + const char *Code = "enum Kind {\n" + " A\n" You can use a raw string literal to make it more readable: https://en

[PATCH] D62579: [Index] Compute correct symbol kind for variable templates

This revision was automatically updated to reflect the committed changes. Closed by commit rC361996: [Index] Compute correct symbol kind for variable templates (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D62579?vs=201980&id=201981#toc Repository:

[PATCH] D62346: [analyzer] print() JSONify: getNodeLabel implementation

NoQ added a comment. > What do you mean by consistent spacing? I meant `BlockEntrance` vs. `Block Entrance`, etc. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62346/new/ https://reviews.llvm.org/D62346 ___ cfe-comm

r361996 - [Index] Compute correct symbol kind for variable templates

Author: ibiryukov Date: Wed May 29 10:49:30 2019 New Revision: 361996 URL: http://llvm.org/viewvc/llvm-project?rev=361996&view=rev Log: [Index] Compute correct symbol kind for variable templates Summary: The index library itself seems to never pass variable templates as input, however clangd does

[clang-tools-extra] r361996 - [Index] Compute correct symbol kind for variable templates

Author: ibiryukov Date: Wed May 29 10:49:30 2019 New Revision: 361996 URL: http://llvm.org/viewvc/llvm-project?rev=361996&view=rev Log: [Index] Compute correct symbol kind for variable templates Summary: The index library itself seems to never pass variable templates as input, however clangd does

[PATCH] D62579: [Index] Compute correct symbol kind for variable templates

ilya-biryukov updated this revision to Diff 201980. ilya-biryukov marked 4 inline comments as done. ilya-biryukov added a comment. - Add a test for static variable template member Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62579/new/ https://rev

[PATCH] D62580: [OpenCL] Use long instead of long long in x86 builtins

craig.topper added a comment. In D62580#1521277 , @erichkeane wrote: > A different (perhaps silly) question is why 'W' isn't sufficient? It > represents int64_t, which I wonder if is sufficient. I had asked in a separate conversation not to change the

[PATCH] D62580: [OpenCL] Use long instead of long long in x86 builtins

craig.topper added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:9308 case 'L': assert(!IsSpecial && "Can't use 'L' with 'W', 'N' or 'Z' modifiers"); assert(HowLong <= 2 && "Can't have modifier"); O should be mentioned here =

[PATCH] D62611: [analyzer][Dominators] Add unittests

Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, rnkovacs, baloghadamsoftware, Charusso, dcoughlin. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, kuhar, whisperity, mgorny. Ex

[PATCH] D62603: [CUDA][HIP] Skip setting `externally_initialized` for static device variables.

tra added a comment. Note for the future -- it would be great if we could finish discussing the patch before landing it. I would still like to see the host-side test. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62603/new/ https://reviews.llvm.org/D62603 __

[PATCH] D62603: [CUDA][HIP] Skip setting `externally_initialized` for static device variables.

tra added a comment. In D62603#1521484 , @hliao wrote: > thanks, but that `static __device__` variable won't have shadow in host > anymore. Why not? Your change only changes whether `externally_initialized` is applied to the variable during device-side

[PATCH] D62603: [CUDA][HIP] Skip setting `externally_initialized` for static device variables.

This revision was automatically updated to reflect the committed changes. Closed by commit rC361994: [CUDA][HIP] Skip setting `externally_initialized` for static device variables. (authored by hliao, committed by ). Changed prior to commit: https://reviews.llvm.org/D62603?vs=201938&id=201975#to

[PATCH] D62045: Revise the google-objc-global-variable-declaration check to match the style guide.

yaqiji updated this revision to Diff 201973. yaqiji added a comment. Added to check no fixit is generated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 Files: clang-tools-extra/clang-tidy/google/Global

[PATCH] D61912: [analyzer] print() JSONify: Store implementation

Charusso added a comment. In D61912#1521476 , @Szelethus wrote: > I think cfe-commits is added automatically if you add "Clang" to the > "Repository" field when creating a new Differential. Exactly, thanks! Repository: rC Clang CHANGES SINCE LAST A

r361994 - [CUDA][HIP] Skip setting `externally_initialized` for static device variables.

Author: hliao Date: Wed May 29 10:23:27 2019 New Revision: 361994 URL: http://llvm.org/viewvc/llvm-project?rev=361994&view=rev Log: [CUDA][HIP] Skip setting `externally_initialized` for static device variables. Summary: - By declaring device variables as `static`, we assume they won't be addres

[PATCH] D62045: Revise the google-objc-global-variable-declaration check to match the style guide.

yaqiji updated this revision to Diff 201972. yaqiji added a comment. Remove cmake content Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 Files: clang-tools-extra/clang-tidy/google/GlobalVariableDeclarati

[PATCH] D62045: Revise the google-objc-global-variable-declaration check to match the style guide.

yaqiji updated this revision to Diff 201971. yaqiji added a comment. Removed check-fixes for those without fixithint. Changed name of Y2Good to Y2Bad to match meaning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.o

[PATCH] D62603: [CUDA][HIP] Skip setting `externally_initialized` for static device variables.

hliao added a comment. thanks, but that `static __device__` variable won't have shadow in host anymore. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62603/new/ https://reviews.llvm.org/D62603 ___ cfe-

[PATCH] D62579: [Index] Compute correct symbol kind for variable templates

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Index/IndexSymbol.cpp:99 + if (auto *VT = dyn_cast(D)) { +Info.Properties |= (SymbolPropertySet)SymbolProperty::Generic; ---

[PATCH] D61912: [analyzer] print() JSONify: Store implementation

Szelethus added a comment. In D61912#1521411 , @Charusso wrote: > >> In D61912#1521306 , @lebedev.ri > >> wrote: > >> > >>> All these patches bypassed cfe-commits. > >> > >> > >> Bypassed? It is only added when

[PATCH] D62603: [CUDA][HIP] Skip setting `externally_initialized` for static device variables.

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/CodeGenCUDA/device-var-init.cu:39 +static __device__ int d_s_v_i = 1; +// DEVICE: @_ZL7d_s_v_i = internal addrspace(1) global i32 1, + P

r361992 - Add curley brackets to case statement that declares a variable.

Author: erichkeane Date: Wed May 29 10:04:48 2019 New Revision: 361992 URL: http://llvm.org/viewvc/llvm-project?rev=361992&view=rev Log: Add curley brackets to case statement that declares a variable. Modified: cfe/trunk/lib/AST/ItaniumMangle.cpp Modified: cfe/trunk/lib/AST/ItaniumMangle.cpp

[PATCH] D62606: [Driver] -static-pie: add -z text

sivachandra accepted this revision. sivachandra added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62606/new/ https://reviews.llvm.org/D62606 ___ cfe-

[PATCH] D62045: Revise the google-objc-global-variable-declaration check to match the style guide.

yaqiji updated this revision to Diff 201969. yaqiji added a comment. Added check-fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 Files: clang-tools-extra/clang-tidy/google/GlobalVariableDeclarationChe

[PATCH] D62045: Revise the google-objc-global-variable-declaration check to match the style guide.

yaqiji updated this revision to Diff 201968. yaqiji added a comment. Updated warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 Files: clang-tools-extra/clang-tidy/google/GlobalVariableDeclarationChe

[PATCH] D59673: [Clang] Harmonize Split DWARF options with llc

dblaikie added a comment. Might be easier as a few patches - renaming the existing option, adding the new one, then removing the single split dwarf flag handling in favor of implying that by the absence of an output file name. (if I'm reading what this patch does) Comment at

[PATCH] D61912: [analyzer] print() JSONify: Store implementation

Charusso added a comment. >> In D61912#1521306 , @lebedev.ri >> wrote: >> >>> All these patches bypassed cfe-commits. >> >> >> Bypassed? It is only added when you push your stuff, which is happened as >> expected. > > That is pretty much the opposite

[PATCH] D57184: [clang-format] Allow configuring list of function-like macros that resolve to a type

This revision was automatically updated to reflect the committed changes. Closed by commit rC361986: [clang-format] Allow configuring list of function-like macros that resolve to a… (authored by Typz, committed by ). Changed prior to commit: https://reviews.llvm.org/D57184?vs=201395&id=201962#t

r361986 - [clang-format] Allow configuring list of function-like macros that resolve to a type

Author: typz Date: Wed May 29 09:30:47 2019 New Revision: 361986 URL: http://llvm.org/viewvc/llvm-project?rev=361986&view=rev Log: [clang-format] Allow configuring list of function-like macros that resolve to a type Summary: Adds a `TypenameMacros` configuration option that causes certain identi

[PATCH] D61912: [analyzer] print() JSONify: Store implementation

lebedev.ri added a comment. In D61912#1521352 , @Charusso wrote: > Hey @lebedev.ri, thanks for the review! > > In D61912#1521306 , @lebedev.ri > wrote: > > > All these patches bypassed cfe-commits. > > > Bypassed?

[PATCH] D62087: [analyzer] print() JSONify: Program state implementation

This revision was automatically updated to reflect the committed changes. Closed by commit rC361983: [analyzer] print() JSONify: Program state implementation (authored by Charusso, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D62087?v

[PATCH] D37813: clang-format: better handle namespace macros

Typz marked 2 inline comments as done. Typz added inline comments. Comment at: unittests/Format/NamespaceEndCommentsFixerTest.cpp:526 EXPECT_EQ("namespace A {\n" " int i;\n" "} // namespace A", klimek wrote: > Typz wrote: > > Should

[PATCH] D62509: [Driver] Render -fuse-init-array for -fembed-bitcode

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Sounds safe enough to me. I think that it would be nice to add a test that checks the hexagon flags as well. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/

r361984 - [NFC] clang-format: Use LLVM style in NamespaceEndCommentsFixerTest

Author: typz Date: Wed May 29 09:22:43 2019 New Revision: 361984 URL: http://llvm.org/viewvc/llvm-project?rev=361984&view=rev Log: [NFC] clang-format: Use LLVM style in NamespaceEndCommentsFixerTest As pointed out in https://reviews.llvm.org/D37813#inline-555026, the code which is formatted does

r361983 - [analyzer] print() JSONify: Program state implementation

Author: charusso Date: Wed May 29 09:22:21 2019 New Revision: 361983 URL: http://llvm.org/viewvc/llvm-project?rev=361983&view=rev Log: [analyzer] print() JSONify: Program state implementation Summary: - Reviewers: NoQ, xazax.hun, ravikandhadai, baloghadamsoftware, Szelethus Reviewed By: NoQ Su

[PATCH] D61912: [analyzer] print() JSONify: Store implementation

Charusso added a comment. Hey @lebedev.ri, thanks for the review! In D61912#1521306 , @lebedev.ri wrote: > All these patches bypassed cfe-commits. Bypassed? It is only added when you push your stuff, which is happened as expected. > Why does this inve

[PATCH] D61974: [ObjC] Fix encoding of ObjC pointer types that are pointers to typedefs

theraven accepted this revision. theraven added a comment. This revision is now accepted and ready to land. LGTM. I wonder if we have any other ugly GCC bug compatibility parts in clang's Objective-C implementation... Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D62606: [Driver] -static-pie: add -z text

MaskRay created this revision. MaskRay added reviewers: saugustine, sivachandra. Herald added a project: clang. Herald added a subscriber: cfe-commits. gcc -static-pie adds -z text. In ld.bfd and gold, default/-z text/-z notext are tri-state. By default, text relocations (and DF_TEXTREL) are emit

[PATCH] D61912: [analyzer] print() JSONify: Store implementation

lebedev.ri added a comment. All these patches bypassed cfe-commits. Why does this invent a yet another json formatter instead of using `"llvm/Support/JSON.h"`, in particular it's lightweight `json::OStream` ? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61912/ne

[PATCH] D62603: [CUDA][HIP] Skip setting `externally_initialized` for static device variables.

yaxunl added a comment. LGTM. The externally initializable attribute causes some optimizations disabled. For static device variables it seems reasonable to remove the externaly initializable attribute. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

r361982 - [analyzer] print() JSONify: Checker messages implementation

Author: charusso Date: Wed May 29 09:02:33 2019 New Revision: 361982 URL: http://llvm.org/viewvc/llvm-project?rev=361982&view=rev Log: [analyzer] print() JSONify: Checker messages implementation Summary: - Reviewers: NoQ, xazax.hun, ravikandhadai, baloghadamsoftware, Szelethus Reviewed By: NoQ

[PATCH] D62085: [analyzer] print() JSONify: Constructing objects implementation

This revision was automatically updated to reflect the committed changes. Closed by commit rC361980: [analyzer] print() JSONify: Constructing objects implementation (authored by Charusso, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D

r361980 - [analyzer] print() JSONify: Constructing objects implementation

Author: charusso Date: Wed May 29 08:58:26 2019 New Revision: 361980 URL: http://llvm.org/viewvc/llvm-project?rev=361980&view=rev Log: [analyzer] print() JSONify: Constructing objects implementation Summary: - Reviewers: NoQ, xazax.hun, ravikandhadai, baloghadamsoftware, Szelethus Reviewed By:

[PATCH] D62459: [clangd] Serialization support for RelationSlab

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/index/Serialization.h:81 +// Used for serializing SymbolRole as used in Relation. +enum class RelationKind : uint8_t { ChildOf = 1, BaseOf }; +llvm::Expected symbolRoleToRe

[PATCH] D62580: [OpenCL] Use long instead of long long in x86 builtins

erichkeane added a comment. A different (perhaps silly) question is why 'W' isn't sufficient? It represents int64_t, which I wonder if is sufficient. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62580/new/ https://reviews.llvm.org/D62580

[PATCH] D62582: [CodeComplete] Improve overload handling for C++ qualified and ref-qualified methods.

ilya-biryukov added inline comments. Comment at: lib/Sema/SemaCodeComplete.cpp:1300 +auto &OverloadSet = +OverloadMap[std::make_pair(CurContext, Method->getName())]; +for (const DeclIndexPair& Entry : OverloadSet) { Won't this crash on

r361979 - [analyzer] print() JSONify: Type information implementation

Author: charusso Date: Wed May 29 08:53:12 2019 New Revision: 361979 URL: http://llvm.org/viewvc/llvm-project?rev=361979&view=rev Log: [analyzer] print() JSONify: Type information implementation Summary: - Reviewers: NoQ, xazax.hun, ravikandhadai, baloghadamsoftware, Szelethus Reviewed By: NoQ

[PATCH] D62603: [CUDA][HIP] Skip setting `externally_initialized` for static device variables.

hliao created this revision. hliao added a reviewer: yaxunl. Herald added a project: clang. Herald added a subscriber: cfe-commits. - By declaring device variables as `static`, we assume they won't be addressable from the host side. Thus, no `externally_initialized` is required. Repository: r

[PATCH] D62082: [analyzer] print() JSONify: Constraints implementation

This revision was automatically updated to reflect the committed changes. Closed by commit rC361978: [analyzer] print() JSONify: Constraints implementation (authored by Charusso, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D62082?vs=

[PATCH] D37813: clang-format: better handle namespace macros

Typz updated this revision to Diff 201936. Typz marked an inline comment as done. Typz added a comment. - Rebase - Fix NamespaceEndCommentsFixerTest to match LLVM indent style Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D37813/new/ https://reviews.llvm.org/D3781

[PATCH] D62335: [OpenCL][PR41963] Add overloads of old atomics with generic pointer type in C++ mode

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM, please address style issue before committing. Comment at: test/Headers/opencl-c-header.cl:79 +{ +atomic_add(a, 1); +} Probably better to follow the

[PATCH] D62580: [OpenCL] Use long instead of long long in x86 builtins

erichkeane added a comment. 'O' is an interesting choice. Any real justification for it, or just "what was available"? It definitely needs to be documented in the top of Builtins.def however. Comment at: clang/lib/AST/ASTContext.cpp:9362 +case 'O': + assert(!IsSpec

r361978 - [analyzer] print() JSONify: Constraints implementation

Author: charusso Date: Wed May 29 08:43:26 2019 New Revision: 361978 URL: http://llvm.org/viewvc/llvm-project?rev=361978&view=rev Log: [analyzer] print() JSONify: Constraints implementation Summary: - Reviewers: NoQ, xazax.hun, ravikandhadai, baloghadamsoftware, Szelethus Reviewed By: NoQ Subs

r361976 - [analyzer] print() JSONify: Environment implementation

Author: charusso Date: Wed May 29 08:36:58 2019 New Revision: 361976 URL: http://llvm.org/viewvc/llvm-project?rev=361976&view=rev Log: [analyzer] print() JSONify: Environment implementation Summary: - Reviewers: NoQ, xazax.hun, ravikandhadai, baloghadamsoftware, Szelethus Reviewed By: NoQ Subs

r361974 - [CodeComplete] Add semicolon when completing patterns for 'static_assert' and 'typedef

Author: ibiryukov Date: Wed May 29 08:32:17 2019 New Revision: 361974 URL: http://llvm.org/viewvc/llvm-project?rev=361974&view=rev Log: [CodeComplete] Add semicolon when completing patterns for 'static_assert' and 'typedef This is a trivial follow-up to r360042, which added semicolons to other p

[PATCH] D61912: [analyzer] print() JSONify: Store implementation

This revision was automatically updated to reflect the committed changes. Closed by commit rC361972: [analyzer] print() JSONify: Store implementation (authored by Charusso, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D61912?vs=201564

r361972 - [analyzer] print() JSONify: Store implementation

Author: charusso Date: Wed May 29 08:25:19 2019 New Revision: 361972 URL: http://llvm.org/viewvc/llvm-project?rev=361972&view=rev Log: [analyzer] print() JSONify: Store implementation Summary: - Reviewers: NoQ, xazax.hun, ravikandhadai, baloghadamsoftware, Szelethus Reviewed By: NoQ Subscriber

[clang-tools-extra] r361969 - [clangd] Map typedefs to the same LSP completion kind as VSCode

Author: ibiryukov Date: Wed May 29 08:10:19 2019 New Revision: 361969 URL: http://llvm.org/viewvc/llvm-project?rev=361969&view=rev Log: [clangd] Map typedefs to the same LSP completion kind as VSCode For consistency and, more importantly, to get a nicer icon for those in VSCode. Modified: cl

[PATCH] D62579: [Index] Compute correct symbol kind for variable templates

ilya-biryukov added inline comments. Comment at: clang/lib/Index/IndexSymbol.cpp:99 + if (auto *VT = dyn_cast(D)) { +Info.Properties |= (SymbolPropertySet)SymbolProperty::Generic; kadircet wrote: > what about function and class templates? Are they handled

r361967 - [mips] Check argument for __builtin_msa_ctcmsa / __builtin_msa_cfcmsa

Author: atanasyan Date: Wed May 29 07:59:32 2019 New Revision: 361967 URL: http://llvm.org/viewvc/llvm-project?rev=361967&view=rev Log: [mips] Check argument for __builtin_msa_ctcmsa / __builtin_msa_cfcmsa The `__builtin_msa_ctcmsa` and `__builtin_msa_cfcmsa` builtins are mapped to the `ctcmsa` a

[PATCH] D62579: [Index] Compute correct symbol kind for variable templates

kadircet added inline comments. Comment at: clang/lib/Index/IndexSymbol.cpp:99 + if (auto *VT = dyn_cast(D)) { +Info.Properties |= (SymbolPropertySet)SymbolProperty::Generic; what about function and class templates? Are they handled in somewhere else? Re

[PATCH] D62582: [CodeComplete] Improve overload handling for C++ qualified and ref-qualified methods.

sammccall updated this revision to Diff 201910. sammccall added a comment. Remove debug Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62582/new/ https://reviews.llvm.org/D62582 Files: lib/Sema/SemaCodeComplete.cpp test/CodeCompletion/member-access.cpp Index

[clang-tools-extra] r361960 - [clangd] Fix buildbot error.

Author: hokein Date: Wed May 29 07:11:53 2019 New Revision: 361960 URL: http://llvm.org/viewvc/llvm-project?rev=361960&view=rev Log: [clangd] Fix buildbot error. Modified: clang-tools-extra/trunk/clangd/index/CanonicalIncludes.cpp Modified: clang-tools-extra/trunk/clangd/index/CanonicalInclu

[PATCH] D62591: [OpenCL][PR42031] Prevent deducing addr space in type alias.

Anastasia created this revision. Anastasia added reviewers: rjmccall, mantognini. Herald added subscribers: ebevhan, yaxunl. Similar to typedefs we shouldn't deduce addr space in type alias. https://reviews.llvm.org/D62591 Files: lib/Sema/SemaType.cpp test/SemaOpenCLCXX/address-space-deduct

[PATCH] D62588: [OpenCL] Support logical vector operators in C++ mode

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62588/new/ https://reviews.llvm.org/D62588 ___

[PATCH] D62490: clang-cl: Fix mangling of catchable types with names longer than 4kiB

This revision was automatically updated to reflect the committed changes. Closed by commit rC361959: clang-cl: Fix mangling of catchable types with names longer than 4kiB (authored by nico, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D62490?v

[PATCH] D62121: [PowerPC] [Clang] Port SSE intrinsics to PowerPC

jsji requested changes to this revision. jsji added a comment. This revision now requires changes to proceed. TEST 'Clang :: CodeGen/ppc-mm-malloc.c' FAILED Script: -- : 'RUN: at line 9'; /home/buildslave/buildslave1a/clang-with-lto-ubuntu/buil

[PATCH] D62588: [OpenCL] Support logical vector operators in C++ mode

svenvh created this revision. svenvh added a reviewer: Anastasia. Herald added subscribers: cfe-commits, yaxunl. Herald added a project: clang. Support logical operators on vectors in C++ for OpenCL mode, to preserve backwards compatibility with OpenCL C. Repository: rC Clang https://reviews.

[PATCH] D62121: [PowerPC] [Clang] Port SSE intrinsics to PowerPC

jsji reopened this revision. jsji added a comment. This revision is now accepted and ready to land. This has been reverted in https://reviews.llvm.org/rL361930 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62121/new/ https://reviews.llvm.org/D62121 _

r361959 - clang-cl: Fix mangling of catchable types with names longer than 4kiB

Author: nico Date: Wed May 29 06:48:19 2019 New Revision: 361959 URL: http://llvm.org/viewvc/llvm-project?rev=361959&view=rev Log: clang-cl: Fix mangling of catchable types with names longer than 4kiB The mangling used to contain the MD5 name of both the RTTI type descriptor and the name of the c

[PATCH] D62584: [OpenCL][PR42033] Deducing addr space of pointer/reference with template parameter types

Anastasia created this revision. Anastasia added reviewers: rjmccall, mantognini. Herald added subscribers: ebevhan, yaxunl. If dependent types appear in pointers or references we have to allow the addr space deduction because the addr space in template argument will belong to the pointee and no

[PATCH] D62582: [CodeComplete] Improve overload handling for C++ qualified and ref-qualified methods.

sammccall created this revision. sammccall added a reviewer: ilya-biryukov. Herald added a project: clang. Herald added a subscriber: cfe-commits. - when a method is not available because of the target value kind (e.g. an && method on a Foo& variable), then don't offer it. - when a method is effe

[PATCH] D62419: [LibTooling] Add `before` and `after` selectors for selecting point-ranges relative to nodes.

This revision was automatically updated to reflect the committed changes. ymandel marked 2 inline comments as done. Closed by commit rL361955: [LibTooling] Add `before` and `after` selectors for selecting point-ranges… (authored by ymandel, committed by ). Herald added a project: LLVM. Herald adde

r361955 - [LibTooling] Add `before` and `after` selectors for selecting point-ranges relative to nodes.

Author: ymandel Date: Wed May 29 05:40:36 2019 New Revision: 361955 URL: http://llvm.org/viewvc/llvm-project?rev=361955&view=rev Log: [LibTooling] Add `before` and `after` selectors for selecting point-ranges relative to nodes. Summary: The `before` and `after` selectors allow users to specify a

[PATCH] D62579: [Index] Compute correct symbol kind for variable templates

ilya-biryukov created this revision. ilya-biryukov added a reviewer: kadircet. Herald added subscribers: arphaman, jkorous. Herald added a project: clang. The index library itself seems to never pass variable templates as input, however clangd does. Repository: rG LLVM Github Monorepo https:/

[PATCH] D62527: [clangd] Remove the whitelist std symbols in CanonicalIncludes.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE361952: [clangd] Remove the whitelist std symbols in CanonicalIncludes. (authored by hokein, committed by ). Changed prior to commit: https://reviews.llvm.org/D62527?vs=201869&id=201870#toc Repositor

[clang-tools-extra] r361952 - [clangd] Remove the whitelist std symbols in CanonicalIncludes.

Author: hokein Date: Wed May 29 05:08:11 2019 New Revision: 361952 URL: http://llvm.org/viewvc/llvm-project?rev=361952&view=rev Log: [clangd] Remove the whitelist std symbols in CanonicalIncludes. Summary: These symbols have been included via StdSymbolMap.inc. Reviewers: sammccall Subscribers:

[PATCH] D62527: [clangd] Remove the whitelist std symbols in CanonicalIncludes.

hokein updated this revision to Diff 201869. hokein added a comment. Remove more symbols. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62527/new/ https://reviews.llvm.org/D62527 Files: clang-tools-extra/clangd/index/CanonicalIncludes.cpp Inde

[PATCH] D62575: [clangd] Another improvement for std include mapping.

This revision was automatically updated to reflect the committed changes. Closed by commit rL361951: [clangd] Another improvement for std include mapping. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[PATCH] D62490: clang-cl: Fix mangling of catchable types with names longer than 4kiB

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62490/new/ https://reviews.llvm.org/D62490 ___ cfe-commits mailing list cfe-commits@lists

[clang-tools-extra] r361951 - [clangd] Another improvement for std include mapping.

Author: hokein Date: Wed May 29 05:03:41 2019 New Revision: 361951 URL: http://llvm.org/viewvc/llvm-project?rev=361951&view=rev Log: [clangd] Another improvement for std include mapping. Summary: Improve the way of checking a symbol name is in the first cell. The previous way is not very robost f

<    1   2   3   >