[PATCH] D62471: [clangd] SymbolCollector support for relations

nridge added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:298 + + processRelations(*ND, *ID, Relations); + kadircet wrote: > why do we want to process these relations for references? The `RelationBaseOf` is not present in the

[PATCH] D62471: [clangd] SymbolCollector support for relations

nridge updated this revision to Diff 202371. nridge marked 11 inline comments as done. nridge added a comment. Addressed most review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62471/new/ https://reviews.llvm.org/D62471 Files:

[PATCH] D62459: [clangd] Serialization support for RelationSlab

nridge added inline comments. Comment at: clang-tools-extra/clangd/index/Serialization.h:81 +// Used for serializing SymbolRole as used in Relation. +enum class RelationKind : uint8_t { ChildOf = 1, BaseOf }; +llvm::Expected symbolRoleToRelationKind(index::SymbolRole);

[PATCH] D62459: [clangd] Serialization support for RelationSlab

nridge updated this revision to Diff 202370. nridge marked 8 inline comments as done. nridge added a comment. Addressed most review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62459/new/ https://reviews.llvm.org/D62459 Files:

[PATCH] D59407: [clangd] Add RelationSlab

nridge updated this revision to Diff 202369. nridge added a comment. Address latest review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59407/new/ https://reviews.llvm.org/D59407 Files: clang-tools-extra/clangd/CMakeLists.txt

[PATCH] D62121: [PowerPC] [Clang] Port SSE intrinsics to PowerPC

jsji accepted this revision. jsji added a comment. This revision is now accepted and ready to land. LGTM. Thanks for fixing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62121/new/ https://reviews.llvm.org/D62121 ___ cfe-commits mailing

[PATCH] D62367: [X86] VP2INTERSECT clang

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62367/new/ https://reviews.llvm.org/D62367 ___

[PATCH] D62716: [analyzer] Fix JSON dumps for dynamic types, add test.

NoQ created this revision. NoQ added a reviewer: Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Now they're valid JSON. Repository: rC Clang

[PATCH] D62367: [X86] VP2INTERSECT clang

xiangzhangllvm marked 3 inline comments as done. xiangzhangllvm added a comment. Done, Thank you very much! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62367/new/ https://reviews.llvm.org/D62367 ___ cfe-commits

[PATCH] D62367: [X86] VP2INTERSECT clang

xiangzhangllvm updated this revision to Diff 202359. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62367/new/ https://reviews.llvm.org/D62367 Files: docs/ClangCommandLineReference.rst include/clang/Basic/BuiltinsX86.def include/clang/Driver/Options.td

[PATCH] D60748: Fix i386 struct and union parameter alignment

wxiao3 added a comment. Thanks for the information! We have reverted the patch and will resubmit it when we have a complete fix. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60748/new/ https://reviews.llvm.org/D60748

[PATCH] D62156: [Sema][PR41730] Diagnose addr space mismatch while constructing objects

rjmccall added inline comments. Comment at: lib/Sema/SemaDeclCXX.cpp:8219 + // to allow skipping it. However we are not visiting all qual + // currently and therefore there is no condition yet. Diag(SL, diag::err_invalid_qualified_constructor)

r362187 - Redirect test output to /dev/null

Author: rtrieu Date: Thu May 30 19:23:33 2019 New Revision: 362187 URL: http://llvm.org/viewvc/llvm-project?rev=362187=rev Log: Redirect test output to /dev/null Modified: cfe/trunk/test/Driver/armv8.1m.main.s Modified: cfe/trunk/test/Driver/armv8.1m.main.s URL:

[PATCH] D62367: [X86] VP2INTERSECT clang

craig.topper added inline comments. Comment at: lib/Headers/avx512vlvp2intersectintrin.h:39 + +/// This instruction writes an even/odd pair of mask registers. The mask +/// register destination indicated in the MODRM.REG field is used to form This doesn't really

[PATCH] D60748: Fix i386 struct and union parameter alignment

pengfei reopened this revision. pengfei added a comment. This revision is now accepted and ready to land. Reverted by https://reviews.llvm.org/rL362186 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60748/new/ https://reviews.llvm.org/D60748

[PATCH] D62622: [CMake] Provide an option to use relative paths in debug info

This revision was automatically updated to reflect the committed changes. Closed by commit rL362185: [CMake] Provide an option to use relative paths in debug info (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D62622?vs=202310=202351#toc Repository:

r362185 - [CMake] Provide an option to use relative paths in debug info

Author: phosek Date: Thu May 30 18:34:51 2019 New Revision: 362185 URL: http://llvm.org/viewvc/llvm-project?rev=362185=rev Log: [CMake] Provide an option to use relative paths in debug info CMake always uses absolute file paths in the generated compiler invocation which results in absolute file

[PATCH] D62367: [X86] VP2INTERSECT clang

xiangzhangllvm added a comment. Hi Dear friends, could you help merge this patch? Thank you very much! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62367/new/ https://reviews.llvm.org/D62367 ___ cfe-commits mailing

[PATCH] D62367: [X86] VP2INTERSECT clang

xiangzhangllvm updated this revision to Diff 202350. xiangzhangllvm added a comment. rebase Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62367/new/ https://reviews.llvm.org/D62367 Files: docs/ClangCommandLineReference.rst

r362184 - PR39728: When completing a class, complete the destructor first.

Author: rsmith Date: Thu May 30 18:25:16 2019 New Revision: 362184 URL: http://llvm.org/viewvc/llvm-project?rev=362184=rev Log: PR39728: When completing a class, complete the destructor first. We need to know whether the destructor is trivial in order to tell whether other parts of the class are

r362183 - Fix the predefined exponent limit macros for the 16-bit IEEE format.

Author: rjmccall Date: Thu May 30 18:21:36 2019 New Revision: 362183 URL: http://llvm.org/viewvc/llvm-project?rev=362183=rev Log: Fix the predefined exponent limit macros for the 16-bit IEEE format. The magnitude range of normalized _Float16 is 2^-14 (~6e-5) to (2-2^-10)*2^15 (65504). You might

[PATCH] D62708: Fix the predefined exponent limit macros for the 16-bit IEEE format.

rjmccall closed this revision. rjmccall added a comment. r362183 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62708/new/ https://reviews.llvm.org/D62708 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D62658: [analyzer] print() JSONify: ExplodedNode revision

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Great, thx! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62658/new/ https://reviews.llvm.org/D62658 ___ cfe-commits

[PATCH] D62712: [CMake][Fuchsia] Use libc++ ABI v2 on Darwin as well

This revision was automatically updated to reflect the committed changes. Closed by commit rL362181: [CMake][Fuchsia] Use libc++ ABI v2 on Darwin as well (authored by phosek, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

Re: r362119 - Add Attribute NoThrow as an Exception Specifier Type

Hello, this causes this diagnostic when building on Windows: In file included from ../../ui/accessibility/platform/ax_platform_node_textchildprovider_win.cc:10: ../..\ui/accessibility/platform/ax_platform_node_textprovider_win.h(22,3): error: 'nothrow' attribute conflicts with exception

r362182 - Defer building 'this' captures until we have left the capturing region

Author: rsmith Date: Thu May 30 18:17:04 2019 New Revision: 362182 URL: http://llvm.org/viewvc/llvm-project?rev=362182=rev Log: Defer building 'this' captures until we have left the capturing region and returned to the context in which 'this' should be captured. This means we now always mark

r362181 - [CMake][Fuchsia] Use libc++ ABI v2 on Darwin as well

Author: phosek Date: Thu May 30 18:16:43 2019 New Revision: 362181 URL: http://llvm.org/viewvc/llvm-project?rev=362181=rev Log: [CMake][Fuchsia] Use libc++ ABI v2 on Darwin as well Since we share headers between host and target builds, we need to use the same version for both. Differential

[PATCH] D62712: [CMake][Fuchsia] Use libc++ ABI v2 on Darwin as well

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62712/new/ https://reviews.llvm.org/D62712 ___

[PATCH] D62712: [CMake][Fuchsia] Use libc++ ABI v2 on Darwin as well

phosek created this revision. phosek added reviewers: mcgrathr, jakehehrlich, juliehockett. Herald added subscribers: cfe-commits, mgorny. Herald added a reviewer: EricWF. Herald added a project: clang. Since we share headers between host and target builds, we need to use the same version for

[PATCH] D62709: Fix -DBUILD_SHARED_LIBS=ON build after rL362160

This revision was automatically updated to reflect the committed changes. Closed by commit rL362180: Fix -DBUILD_SHARED_LIBS=ON build after rL362160 (authored by sbc, committed by ). Changed prior to commit: https://reviews.llvm.org/D62709?vs=202335=202343#toc Repository: rL LLVM CHANGES

r362180 - Fix -DBUILD_SHARED_LIBS=ON build after rL362160

Author: sbc Date: Thu May 30 18:04:00 2019 New Revision: 362180 URL: http://llvm.org/viewvc/llvm-project?rev=362180=rev Log: Fix -DBUILD_SHARED_LIBS=ON build after rL362160 Differential Revision: https://reviews.llvm.org/D62709 Modified: cfe/trunk/lib/CodeGen/CMakeLists.txt Modified:

r362179 - Defer capture initialization for captured regions until after we've left

Author: rsmith Date: Thu May 30 17:45:10 2019 New Revision: 362179 URL: http://llvm.org/viewvc/llvm-project?rev=362179=rev Log: Defer capture initialization for captured regions until after we've left the captured region scope. This removes a case where we would build expressions (and mark

r362178 - Defer capture initialization for blocks until after we've left the

Author: rsmith Date: Thu May 30 17:45:09 2019 New Revision: 362178 URL: http://llvm.org/viewvc/llvm-project?rev=362178=rev Log: Defer capture initialization for blocks until after we've left the function scope. This removes one of the last few cases where we build expressions in the wrong

[PATCH] D62709: Fix -DBUILD_SHARED_LIBS=ON build after rL362160

thegameg accepted this revision. thegameg added a comment. This revision is now accepted and ready to land. Sorry about this! This LGTM, thanks for fixing it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62709/new/ https://reviews.llvm.org/D62709

[PATCH] D62709: Fix -DBUILD_SHARED_LIBS=ON build after rL362160

sbc100 created this revision. Herald added subscribers: llvm-commits, cfe-commits, dang, dexonsmith, steven_wu, aheejin, hiraditya, mgorny, mehdi_amini. Herald added projects: clang, LLVM. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D62709 Files:

Buildbot numbers for the week of 05/19/2019 - 05/25/2019

Hello everyone, Below are some buildbot numbers for the last week of 05/19/2019 - 05/25/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from

Buildbot numbers for the week of 05/12/2019 - 05/18/2019

Hello everyone, Below are some buildbot numbers for the week of 05/12/2019 - 05/18/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed

[PATCH] D62708: Fix the predefined exponent limit macros for the 16-bit IEEE format.

rjmccall created this revision. rjmccall added a reviewer: scanon. Herald added subscribers: cfe-commits, Anastasia. Herald added a project: clang. Fix the predefined exponent limit macros for the 16-bit IEEE format. The magnitude range of normalized _Float16 is 2^-14 (~6e-5) to

r362172 - Refactor OpenMP stack management.

Author: rsmith Date: Thu May 30 16:21:14 2019 New Revision: 362172 URL: http://llvm.org/viewvc/llvm-project?rev=362172=rev Log: Refactor OpenMP stack management. Instead of duplicating access to the directive stack throughout SemaOpenMP.cpp, consolidate it to a few methods and call those

r362171 - Fix "fallthrough annotation in unreachable code" warning.

Author: rsmith Date: Thu May 30 16:21:13 2019 New Revision: 362171 URL: http://llvm.org/viewvc/llvm-project?rev=362171=rev Log: Fix "fallthrough annotation in unreachable code" warning. Modified: cfe/trunk/lib/Sema/SemaType.cpp Modified: cfe/trunk/lib/Sema/SemaType.cpp URL:

[PATCH] D61939: AArch64: add support for arm64_23 (ILP32) IR generation

fhahn added a comment. Hi Tim. Would it be possible to split this in the 'trivial' changes (extending the triple handling for example) and the arm64_32 related changes to size, ABI stuff and so on? The trivial changes look good to me and by splitting them off people can focus on reviewing the

[PATCH] D62693: Support codesigning bundles and forcing

This revision was automatically updated to reflect the committed changes. Closed by commit rL362169: Support codesigning bundles and forcing (authored by cbieneman, committed by ). Changed prior to commit: https://reviews.llvm.org/D62693?vs=202239=202320#toc Repository: rL LLVM CHANGES

[clang-tools-extra] r362169 - Support codesigning bundles and forcing

Author: cbieneman Date: Thu May 30 15:25:48 2019 New Revision: 362169 URL: http://llvm.org/viewvc/llvm-project?rev=362169=rev Log: Support codesigning bundles and forcing Summary: Clangd's framework is assembled by copying binaries from the lib and bin directories into a bundle shape. This

[PATCH] D61939: AArch64: add support for arm64_23 (ILP32) IR generation

t.p.northover added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61939/new/ https://reviews.llvm.org/D61939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D62635: Add enums as global variables in the IR metadata.

This revision was automatically updated to reflect the committed changes. Closed by commit rL362166: Add enums as global variables in the IR metadata. (authored by akhuang, committed by ). Changed prior to commit: https://reviews.llvm.org/D62635?vs=202079=202312#toc Repository: rL LLVM

r362166 - Add enums as global variables in the IR metadata.

Author: akhuang Date: Thu May 30 15:04:11 2019 New Revision: 362166 URL: http://llvm.org/viewvc/llvm-project?rev=362166=rev Log: Add enums as global variables in the IR metadata. Summary: Keeps track of the enums that were used by saving them as DIGlobalVariables, since CodeView emits debug info

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim added a comment. Looks like this also broke an armv8 bot, due to a maximum number of threads issue. Have filed rL362163 to attempt to fix. If that doesn't work, I'll just disable the test for armv8. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D62622: [CMake] Provide an option to use relative paths in debug info

phosek added a comment. In D62622#1523269 , @aprantl wrote: > I like LLVM_USE_RELATIVE_PATHS_IN_DEBUG_INFO. Done CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62622/new/ https://reviews.llvm.org/D62622

[PATCH] D62622: [CMake] Provide an option to use relative paths in debug info

phosek updated this revision to Diff 202310. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62622/new/ https://reviews.llvm.org/D62622 Files: clang/cmake/caches/Fuchsia-stage2.cmake llvm/cmake/modules/HandleLLVMOptions.cmake llvm/cmake/modules/LLVMExternalProjectUtils.cmake

r362160 - [Remarks][NFC] Move the serialization to lib/Remarks

Author: thegameg Date: Thu May 30 14:45:59 2019 New Revision: 362160 URL: http://llvm.org/viewvc/llvm-project?rev=362160=rev Log: [Remarks][NFC] Move the serialization to lib/Remarks Separate the remark serialization to YAML from the LLVM Diagnostics. This adds a new serialization abstraction:

[PATCH] D62665: Fix constexpr __builtin_*_overflow issue when unsigned->signed operand.

This revision was automatically updated to reflect the committed changes. Closed by commit rL362157: Fix constexpr __builtin_*_overflow issue when unsigned-signed operand. (authored by erichkeane, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

r362157 - Fix constexpr __builtin_*_overflow issue when unsigned->signed operand.

Author: erichkeane Date: Thu May 30 14:35:32 2019 New Revision: 362157 URL: http://llvm.org/viewvc/llvm-project?rev=362157=rev Log: Fix constexpr __builtin_*_overflow issue when unsigned->signed operand. As reported here https://bugs.llvm.org/show_bug.cgi?id=42000, it was possible to get the

[PATCH] D62635: Add enums as global variables in the IR metadata.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm That was... easier and more painless than I would've imagined. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62635/new/

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:326 +self._dump('Program point:') +self._dump('' + '') Charusso wrote: > I would create a

[PATCH] D62665: Fix constexpr __builtin_*_overflow issue when unsigned->signed operand.

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62665/new/ https://reviews.llvm.org/D62665 ___ cfe-commits mailing list

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim added a comment. Looks like this broke an autoconf bot . Have submitted rL362149 , which should hopefully fix the issue. Repository: rL LLVM CHANGES SINCE LAST ACTION

Re: r361329 - [c++20] P1330R0: permit simple-assignments that change the active member

On Thu, 30 May 2019 at 04:31, Stephan Bergmann via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On 22/05/2019 01:15, Richard Smith via cfe-commits wrote: > > Author: rsmith > > Date: Tue May 21 16:15:20 2019 > > New Revision: 361329 > > > > URL:

r362147 - [c++2a] Fix assertion failure if we would walk over more than one level

Author: rsmith Date: Thu May 30 13:45:12 2019 New Revision: 362147 URL: http://llvm.org/viewvc/llvm-project?rev=362147=rev Log: [c++2a] Fix assertion failure if we would walk over more than one level of derived-to-base conversion path when implicitly starting union subobject lifetimes in constant

Re: r361997 - [analyzer] print() JSONify: getNodeLabel implementation

Hi all, I'm perfectly fine with reducing this test case to only test the `conj_$3\{int, LC3, no stmt, #1\}` part and drop everything else, because that's what i've been testing when i originally introduced this test. The lack of determinism here indeed only affects our own self-debugging

[PATCH] D62697: AMDGPU: Disable errno by default

arsenm created this revision. arsenm added a reviewer: yaxunl. Herald added subscribers: t-tye, tpr, dstuttard, nhaehnle, wdng, jvesely, kzhuravl. https://reviews.llvm.org/D62697 Files: lib/Driver/ToolChains/AMDGPU.h test/Driver/fast-math.c Index: test/Driver/fast-math.c

r362140 - Mark test as requiring an ARM target.

Author: dyung Date: Thu May 30 13:02:51 2019 New Revision: 362140 URL: http://llvm.org/viewvc/llvm-project?rev=362140=rev Log: Mark test as requiring an ARM target. Modified: cfe/trunk/test/Driver/armv8.1m.main.s Modified: cfe/trunk/test/Driver/armv8.1m.main.s URL:

[PATCH] D62696: AMDGPU: Use AMDGPU toolchain for other OSes

arsenm created this revision. arsenm added a reviewer: yaxunl. Herald added subscribers: t-tye, tpr, dstuttard, nhaehnle, wdng, jvesely, kzhuravl. This would need more work to actually support them, but this is less wrong than the default. https://reviews.llvm.org/D62696 Files:

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

This revision was automatically updated to reflect the committed changes. Closed by commit rL362138: [GWP-ASan] Mutex implementation [2]. (authored by hctim, committed by ). Herald added a subscriber: delcypher. Changed prior to commit: https://reviews.llvm.org/D61923?vs=202275=202276#toc

r362138 - [GWP-ASan] Mutex implementation [2].

Author: hctim Date: Thu May 30 12:45:32 2019 New Revision: 362138 URL: http://llvm.org/viewvc/llvm-project?rev=362138=rev Log: [GWP-ASan] Mutex implementation [2]. Summary: See D60593 for further information. This patch pulls out the mutex implementation and the required definitions file. We

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim updated this revision to Diff 202275. hctim added a comment. Merged with tip-of-tree in preparation for submit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61923/new/ https://reviews.llvm.org/D61923 Files: clang/runtime/CMakeLists.txt

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

rsmith added inline comments. Comment at: lib/Sema/SemaExprCXX.cpp:7713-7714 + // Add the newly created typos to the TypoExprs list, even if they + // failed to apply. This allows them to be reaped although they won't + // emit any diagnostic. +

[PATCH] D62665: Fix constexpr __builtin_*_overflow issue when unsigned->signed operand.

erichkeane updated this revision to Diff 202268. erichkeane marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62665/new/ https://reviews.llvm.org/D62665 Files: clang/lib/AST/ExprConstant.cpp clang/test/SemaCXX/builtins-overflow.cpp Index:

[PATCH] D62574: Initial draft of target-configurable address spaces.

Anastasia added a comment. > This patch does not address the issue with the accessors > on Qualifiers (isAddressSpaceSupersetOf, compatiblyIncludes), > because I don't know how to solve it without breaking a ton of > rather nice encapsulation. Either, every mention of compatiblyIncludes >

[PATCH] D62665: Fix constexpr __builtin_*_overflow issue when unsigned->signed operand.

erichkeane marked an inline comment as done. erichkeane added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:9457 + LHS = APSInt(LHS.isSigned() ? LHS.sextOrSelf(MaxBits) + : LHS.zextOrSelf(MaxBits),

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

morehouse accepted this revision. morehouse added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61923/new/ https://reviews.llvm.org/D61923

[PATCH] D62665: Fix constexpr __builtin_*_overflow issue when unsigned->signed operand.

efriedma added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:9457 + LHS = APSInt(LHS.isSigned() ? LHS.sextOrSelf(MaxBits) + : LHS.zextOrSelf(MaxBits), !IsSigned); Can you just write `LHS =

[PATCH] D60499: [ASTImporter] Various source location and range import fixes.

shafik requested changes to this revision. shafik added a comment. This revision now requires changes to proceed. Actually I was mistaken, we can see the difference for `EnumDecl` and `ClassTemplateSpecializationDecl` as well. For `EnumDecl` before: EnumDecl 0x7fd0ae884800 col:6 referenced

r362129 - Reapply: LLVM IR: update Clang tests for byval being a typed attribute.

Author: tnorthover Date: Thu May 30 11:49:19 2019 New Revision: 362129 URL: http://llvm.org/viewvc/llvm-project?rev=362129=rev Log: Reapply: LLVM IR: update Clang tests for byval being a typed attribute. Since byval is now a typed attribute it gets sorted slightly differently by LLVM when the

[PATCH] D62435: Add Attribute NoThrow as an Exception Specifier Type

This revision was automatically updated to reflect the committed changes. erichkeane marked 2 inline comments as done. Closed by commit rL362119: Add Attribute NoThrow as an Exception Specifier Type (authored by erichkeane, committed by ). Herald added a project: LLVM. Herald added a subscriber:

[PATCH] D62654: [Docs] Modernize references to macOS

This revision was automatically updated to reflect the committed changes. Closed by commit rL362113: [Docs] Modernize references to macOS (authored by jryans, committed by ). Changed prior to commit: https://reviews.llvm.org/D62654?vs=202161=202247#toc Repository: rL LLVM CHANGES SINCE

[PATCH] D62657: [OpenCL] Fix OpenCL/SPIR version metadata

This revision was automatically updated to reflect the committed changes. Closed by commit rC362102: [OpenCL] Fix OpenCL/SPIR version metadata in C++ mode. (authored by stulova, committed by ). Herald added a project: clang. Changed prior to commit:

[PATCH] D62550: [coroutines][PR41909] Don't build dependent coroutine statements for generic lambda

GorNishanov accepted this revision. GorNishanov added a comment. This revision is now accepted and ready to land. LGTM! Thank you for the fix Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62550/new/ https://reviews.llvm.org/D62550

[PATCH] D62693: Support codesigning bundles and forcing

bogner accepted this revision. bogner added a comment. This revision is now accepted and ready to land. Seems straightforward enough Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62693/new/ https://reviews.llvm.org/D62693

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

Anastasia added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1017 + let LangOpts = [SYCL]; + let Documentation = [Undocumented]; +} Undocumented -> SYCLKernelDocs Comment at: clang/include/clang/Basic/AttrDocs.td:269 + +

[PATCH] D62693: Support codesigning bundles and forcing

beanz created this revision. beanz added reviewers: jkorous, bogner. Herald added subscribers: kadircet, arphaman, dexonsmith, ilya-biryukov, mgorny. Herald added projects: clang, LLVM. Clangd's framework is assembled by copying binaries from the lib and bin directories into a bundle shape. This

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim added inline comments. Comment at: compiler-rt/lib/gwp_asan/tests/driver.cpp:14 + return RUN_ALL_TESTS(); +} morehouse wrote: > hctim wrote: > > morehouse wrote: > > > Can we just link with gtest_main instead of having this? > > Unfortunately not easily.

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim updated this revision to Diff 202237. hctim marked 7 inline comments as done. hctim added a comment. - Updated from Matt's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61923/new/ https://reviews.llvm.org/D61923 Files:

r362119 - Add Attribute NoThrow as an Exception Specifier Type

Author: erichkeane Date: Thu May 30 10:31:54 2019 New Revision: 362119 URL: http://llvm.org/viewvc/llvm-project?rev=362119=rev Log: Add Attribute NoThrow as an Exception Specifier Type In response to https://bugs.llvm.org/show_bug.cgi?id=33235, it became clear that the current mechanism of

[PATCH] D62435: Add Attribute NoThrow as an Exception Specifier Type

erichkeane marked 6 inline comments as done. erichkeane added inline comments. Comment at: clang/include/clang/Sema/DeclSpec.h:1547 + bool hasAttr(ParsedAttr::Kind Kind) const { +return llvm::find_if(getAttrs(), [Kind](const ParsedAttr ) { aaron.ballman

[PATCH] D62690: Modify StepsLeft counter behaivior for constexprs

wasiher created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When I was trying to remove limits from constexpr steps (I wanted to give compiler as much time as it it needs), I found -fconstexpr-steps option. Naively i decided that -fconstexpr-steps=-1 is

[libunwind] r362113 - [Docs] Modernize references to macOS

Author: jryans Date: Thu May 30 09:46:22 2019 New Revision: 362113 URL: http://llvm.org/viewvc/llvm-project?rev=362113=rev Log: [Docs] Modernize references to macOS Summary: This updates all places in documentation that refer to "Mac OS X", "OS X", etc. to instead use the modern name "macOS"

r362113 - [Docs] Modernize references to macOS

Author: jryans Date: Thu May 30 09:46:22 2019 New Revision: 362113 URL: http://llvm.org/viewvc/llvm-project?rev=362113=rev Log: [Docs] Modernize references to macOS Summary: This updates all places in documentation that refer to "Mac OS X", "OS X", etc. to instead use the modern name "macOS"

[PATCH] D60748: Fix i386 struct and union parameter alignment

jyknight added a comment. I don't think this was correct (where by "correct", there, I mean "what GCC does", as this patch is intended to match GCC behavior). I think this change may well break more cases than it fixes, so IMO, this should be reverted, until it's implemented properly.

[PATCH] D62654: [Docs] Modernize references to macOS

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62654/new/ https://reviews.llvm.org/D62654

[PATCH] D60763: Prototype OpenCL BIFs using Tablegen

svenvh added inline comments. Comment at: clang/include/clang/Basic/OpenCLBuiltins.td:298-302 +def write_imagef : Builtin<"write_imagef", +[void_t, + image2d_WO_t, + VectorType, +

[PATCH] D62688: [Analyzer] Iterator Checkers - Model `empty()` method of containers

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: NoQ, Szelethus. baloghadamsoftware added a project: clang. Herald added subscribers: Charusso, gamesh411, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, whisperity. Modeling of the `empty()`

[PATCH] D62435: Add Attribute NoThrow as an Exception Specifier Type

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from some minor nits. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2789 InGroup; +def warn_nothrow_attribute_ignored : Warning<"nothrow attribute conflicts with" + " exception

Re: r361997 - [analyzer] print() JSONify: getNodeLabel implementation

I have not said there is determinism to print out a map as Static Analyzer cannot provide that. We have no plans to make it deterministic, as it is just dumping out the ExplodedGraph in JSON format, which is an internal stuff. This non-deterministic behaviour has been seen first only some days

r362106 - Revert "clang support gnu asm goto."

Author: erichkeane Date: Thu May 30 08:38:02 2019 New Revision: 362106 URL: http://llvm.org/viewvc/llvm-project?rev=362106=rev Log: Revert "clang support gnu asm goto." This reverts commit 954ec09aed4f2be04bb5f4e10dbb4ea8bd19ef9a. Reverting due to test failures as requested by Jennifer Yu.

[PATCH] D62622: [CMake] Provide an option to use relative paths in debug info

aprantl added a comment. I like LLVM_USE_RELATIVE_PATHS_IN_DEBUG_INFO. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62622/new/ https://reviews.llvm.org/D62622 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r361997 - [analyzer] print() JSONify: getNodeLabel implementation

Hi Csaba, I see what Roman means. Output should be deterministic for given input (unless there is a very good reason not to (e.g. timing or deliberate randomness)). You can check whether the output is the same with a script like below. It looks like the node numbers are different every time. Is

Re: r361997 - [analyzer] print() JSONify: getNodeLabel implementation

I think we're still talking past each other. I'm saying that *any* commit that does not fix the underlying nondeterminizm, but only hides it by deleting tests that showed that said determinism exists in the first place, is not a fix. Roman. On Thu, May 30, 2019 at 6:14 PM Csaba Dabis wrote: >

Re: r361997 - [analyzer] print() JSONify: getNodeLabel implementation

Hm, the first `CHECK: constructing_objects` contains only one element, which is fine, the second `CHECK: constructing_objects` has two, which could be non-determinism, but surprisingly it is worked as excepted. Because of the edge-case I have changed my mind:

r362102 - [OpenCL] Fix OpenCL/SPIR version metadata in C++ mode.

Author: stulova Date: Thu May 30 08:18:07 2019 New Revision: 362102 URL: http://llvm.org/viewvc/llvm-project?rev=362102=rev Log: [OpenCL] Fix OpenCL/SPIR version metadata in C++ mode. C++ is derived from OpenCL v2.0 therefore set the versions identically. Differential Revision:

r362101 - [analyzer] print() JSONify chain: Fix possible build-bot breaks

Author: charusso Date: Thu May 30 08:15:57 2019 New Revision: 362101 URL: http://llvm.org/viewvc/llvm-project?rev=362101=rev Log: [analyzer] print() JSONify chain: Fix possible build-bot breaks Summary: Printing constructing_objects could be non-deterministic as it is a map. Modified:

  1   2   >