[PATCH] D60463: [ASTImporter] Add check for correct import of source locations.

balazske added a comment. In the current state there are failing AST tests. This test can be added after the problems are fixed. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60463/new/ https://reviews.llvm.org/D60463

[PATCH] D60463: [ASTImporter] Add check for correct import of source locations.

balazske updated this revision to Diff 202197. balazske added a comment. New patch and check the first line of AST dump only. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60463/new/ https://reviews.llvm.org/D60463 Files: unittests/AST/ASTImporterFixtures.cpp

r362100 - Follow up of r362096

Author: sjoerdmeijer Date: Thu May 30 08:04:06 2019 New Revision: 362100 URL: http://llvm.org/viewvc/llvm-project?rev=362100=rev Log: Follow up of r362096 The new tests were failing, because I missed dependent patch D60697. I have removed the failing cases for now, which I will restore once

[PATCH] D62525: [Analyzer] Add new visitor to the iterator checkers

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:281-282 + + // `FoundChange` becomes true when we find the statement the results in the + // current state of the

[PATCH] D62525: [Analyzer] Add new visitor to the iterator checkers

baloghadamsoftware added a comment. In D62525#1519868 , @NoQ wrote: > In D62525#1519475 , > @baloghadamsoftware wrote: > > > Before someone asks: `NoteTag`s are not applicable here since invalidation > > and

Re: r361997 - [analyzer] print() JSONify: getNodeLabel implementation

On Thu, May 30, 2019 at 5:48 PM Csaba Dabis via cfe-commits wrote: > > Thanks you! > > Fixed by > https://github.com/llvm/llvm-project/commit/17604c3486cbe7c27cadac1757cd0a9109a92792 The non-determinism is still there though, so this isn't correct fix. > On Thu, May 30, 2019 at 4:16 PM Russell

Re: r361997 - [analyzer] print() JSONify: getNodeLabel implementation

Thanks you! Fixed by https://github.com/llvm/llvm-project/commit/17604c3486cbe7c27cadac1757cd0a9109a92792 On Thu, May 30, 2019 at 4:16 PM Russell Gallop wrote: > Hi Csaba, > > Failing example attached. Note that the output is different every time so > there is potentially more than one failure

[PATCH] D62156: [Sema][PR41730] Diagnose addr space mismatch while constructing objects

Anastasia marked 4 inline comments as done. Anastasia added inline comments. Comment at: lib/Sema/SemaDeclCXX.cpp:8229 + if (FTI.hasMethodTypeCVRUQualifiers()) { +FTI.MethodQualifiers->forEachCVRUQualifier( [&](DeclSpec::TQ TypeQual, StringRef QualName,

[PATCH] D62156: [Sema][PR41730] Diagnose addr space mismatch while constructing objects

Anastasia updated this revision to Diff 202193. Anastasia marked 3 inline comments as done. Anastasia added a comment. - Improved diagnostic - Added more comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62156/new/ https://reviews.llvm.org/D62156 Files:

[PATCH] D49074: [Analyzer] [WIP] Basic support for multiplication and division in the constraint manager

baloghadamsoftware updated this revision to Diff 202192. baloghadamsoftware removed a reviewer: george.karpenkov. baloghadamsoftware added a comment. Herald added a subscriber: Charusso. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49074/new/ https://reviews.llvm.org/D49074

r362098 - [analyzer] print() JSONify chain: Fix build-bot breaks

Author: charusso Date: Thu May 30 07:48:43 2019 New Revision: 362098 URL: http://llvm.org/viewvc/llvm-project?rev=362098=rev Log: [analyzer] print() JSONify chain: Fix build-bot breaks Summary: Printing out a map structure different in different environments so that this patch generalize the

[PATCH] D50256: [Analyzer] [WIP] Basic support for multiplication and division in the constraint manager (for == and != only)

baloghadamsoftware updated this revision to Diff 202191. baloghadamsoftware added a comment. Herald added a subscriber: Charusso. Multipliers limited to less or equal to 255. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50256/new/ https://reviews.llvm.org/D50256 Files:

[PATCH] D62665: Fix constexpr __builtin_*_overflow issue when unsigned->signed operand.

erichkeane created this revision. erichkeane added reviewers: eli.friedman, efriedma, craig.topper. As reported here https://bugs.llvm.org/show_bug.cgi?id=42000, it was possible to get the constexpr version of __builtin_*_overflow to give the wrong answer. This was because when extending the

[PATCH] D60699: [ARM] add CLI support for 8.1-M and MVE.

This revision was automatically updated to reflect the committed changes. Closed by commit rL362096: [ARM] Add CLI support for Armv8.1-M and MVE (authored by SjoerdMeijer, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r362096 - [ARM] Add CLI support for Armv8.1-M and MVE

Author: sjoerdmeijer Date: Thu May 30 07:22:26 2019 New Revision: 362096 URL: http://llvm.org/viewvc/llvm-project?rev=362096=rev Log: [ARM] Add CLI support for Armv8.1-M and MVE Given the existing infrastructure in LLVM side for +fp and +fp.dp, this is more or less trivial, needing only one tiny

Re: r361997 - [analyzer] print() JSONify: getNodeLabel implementation

Hi Csaba, Failing example attached. Note that the output is different every time so there is potentially more than one failure mode. Thanks Russ On Thu, 30 May 2019 at 15:05, Csaba Dabis wrote: > Hey! > > When it fails, could you provide the DOT dump? The path > is: >

[PATCH] D62035: [AST] const-ify ObjC inherited class search

jyknight added a comment. I don't really have much to say about this, and the patch is probably fine, but I do note that most of the other accessors on this class also return mutable objects. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62035/new/

[PATCH] D43576: Solution to fix PR27066 - Redefinition with same mangled name as another definition (dllexport and uuid)

zahiraam added a comment. A review please :-) Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43576/new/ https://reviews.llvm.org/D43576 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r361997 - [analyzer] print() JSONify: getNodeLabel implementation

Hey! When it fails, could you provide the DOT dump? The path is: llvm-project/build/tools/clang/test/Analysis/Output/dump_egraph.cpp.tmp.dot Thanks, Csaba. On Thu, May 30, 2019 at 4:00 PM Russell Gallop wrote: > Hi Csaba, > > The test dump_egraph.cpp appears to be flaky on Windows. For

Re: r361997 - [analyzer] print() JSONify: getNodeLabel implementation

Hi Csaba, The test dump_egraph.cpp appears to be flaky on Windows. For example here: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/26183 .

[PATCH] D62657: [OpenCL] Fix OpenCL/SPIR version metadata

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62657/new/ https://reviews.llvm.org/D62657 ___ cfe-commits mailing list

[PATCH] D62658: [analyzer] print() JSONify: ExplodedNode revision

Charusso created this revision. Charusso added reviewers: NoQ, xazax.hun, ravikandhadai, baloghadamsoftware, Szelethus. Charusso added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet. Revert node-ID removal. Repository:

[PATCH] D62654: [Docs] Modernize references to macOS

mclow.lists added a comment. I'm fine with the libc++ changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62654/new/ https://reviews.llvm.org/D62654 ___ cfe-commits mailing list

[PATCH] D62657: [OpenCL] Fix OpenCL/SPIR version metadata

Anastasia created this revision. Anastasia added a reviewer: svenvh. Herald added subscribers: ebevhan, yaxunl. C++ is derived from OpenCL v2.0 therefore set the versions to the same. In the future we might need to add extra version for CXX. https://reviews.llvm.org/D62657 Files:

[PATCH] D61743: New clang option -MD-filter=prefix to filter files from make dependencies

mibintc abandoned this revision. mibintc added a comment. I'll modify this to be a cc1 only option, there doesn't seem to be community interest. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61743/new/ https://reviews.llvm.org/D61743 ___

[PATCH] D62588: [OpenCL] Support logical vector operators in C++ mode

This revision was automatically updated to reflect the committed changes. Closed by commit rL362087: [OpenCL] Support logical vector operators in C++ mode (authored by svenvh, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r362087 - [OpenCL] Support logical vector operators in C++ mode

Author: svenvh Date: Thu May 30 05:35:19 2019 New Revision: 362087 URL: http://llvm.org/viewvc/llvm-project?rev=362087=rev Log: [OpenCL] Support logical vector operators in C++ mode Support logical operators on vectors in C++ for OpenCL mode, to preserve backwards compatibility with OpenCL C.

[PATCH] D62654: [Docs] Modernize references to macOS

jryans created this revision. jryans added a reviewer: JDevlieghere. Herald added subscribers: llvm-commits, libcxx-commits, lldb-commits, cfe-commits, arphaman, christof, mgorny. Herald added projects: clang, LLDB, libc++, LLVM. This updates all places in documentation that refer to "Mac OS X",

[PATCH] D62580: [OpenCL] Use long instead of long long in x86 builtins

Anastasia added a comment. Do you think it's possible to add a test? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62580/new/ https://reviews.llvm.org/D62580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D60748: Fix i386 struct and union parameter alignment

joerg added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:1501 +// +// Exclude other System V OS (e.g Darwin, PS4 and FreeBSD) since we don't +// want to spend any effort dealing with the ramifications of ABI breaks. krytarowski wrote: >

Re: r361329 - [c++20] P1330R0: permit simple-assignments that change the active member

On 22/05/2019 01:15, Richard Smith via cfe-commits wrote: Author: rsmith Date: Tue May 21 16:15:20 2019 New Revision: 361329 URL: http://llvm.org/viewvc/llvm-project?rev=361329=rev Log: [c++20] P1330R0: permit simple-assignments that change the active member of a union within constant

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

Charusso added a comment. Sorry for that much rewrite request but in a script language you have to name your stuff properly or you will be completely lost. I have not written a single Python class yet, but trust me. I really like that `DotDumpVisitor` semantic, but it would be a lot better at

r362085 - Fix Wdocumentation warning. NFCI.

Author: rksimon Date: Thu May 30 03:44:36 2019 New Revision: 362085 URL: http://llvm.org/viewvc/llvm-project?rev=362085=rev Log: Fix Wdocumentation warning. NFCI. Modified: cfe/trunk/include/clang/StaticAnalyzer/Core/CheckerManager.h Modified:

[PATCH] D60499: [ASTImporter] Various source location and range import fixes.

balazske added a comment. It looks like that the same test can be applied as in D60463 but check only the first line of the AST dump. The first line contains information about the actual Decl only. This checks less than checking the full AST dump but finds

Re: r362067 - asm goto: fix out-of-bounds read of Constraints after rC362045

You beat me to it.. Reverted On Thu, May 30, 2019 at 5:41 PM Benjamin Kramer wrote: > Is this still necessary after r362062? > > On Thu, May 30, 2019 at 10:00 AM Fangrui Song via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: maskray >> Date: Thu May 30 01:03:02 2019 >> New

r362079 - Revert "asm goto: fix out-of-bounds read of Constraints after rC362045"

Author: maskray Date: Thu May 30 03:05:52 2019 New Revision: 362079 URL: http://llvm.org/viewvc/llvm-project?rev=362079=rev Log: Revert "asm goto: fix out-of-bounds read of Constraints after rC362045" It was fixed by rC362062. Modified: cfe/trunk/lib/Parse/ParseStmtAsm.cpp Modified:

Re: r362067 - asm goto: fix out-of-bounds read of Constraints after rC362045

Is this still necessary after r362062? On Thu, May 30, 2019 at 10:00 AM Fangrui Song via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: maskray > Date: Thu May 30 01:03:02 2019 > New Revision: 362067 > > URL: http://llvm.org/viewvc/llvm-project?rev=362067=rev > Log: > asm goto: fix

r362076 - Fix MSVC "not all control paths return a value" warning.

Author: rksimon Date: Thu May 30 02:39:45 2019 New Revision: 362076 URL: http://llvm.org/viewvc/llvm-project?rev=362076=rev Log: Fix MSVC "not all control paths return a value" warning. Modified: cfe/trunk/include/clang/Basic/ObjCRuntime.h Modified:

[PATCH] D60763: Prototype OpenCL BIFs using Tablegen

AlexeySotkin added inline comments. Comment at: clang/include/clang/Basic/OpenCLBuiltins.td:298-302 +def write_imagef : Builtin<"write_imagef", +[void_t, + image2d_WO_t, + VectorType, +

[PATCH] D62623: Reduce memory consumption of coverage dumps

serge-sans-paille added a comment. @kwk: looks like you're still compiling with clang-7, this patch is to be applied on the master version of LLVM/clang, then you can install it and use it to recompile llvm/lld with coverage info. Does it make sense to you? Repository: rG LLVM Github

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

dgoldman created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As Typo Resolution can create new TypoExprs while resolving typos, it is necessary to recurse through the expression to search for more typos. This should fix the assertion failure in

r362067 - asm goto: fix out-of-bounds read of Constraints after rC362045

Author: maskray Date: Thu May 30 01:03:02 2019 New Revision: 362067 URL: http://llvm.org/viewvc/llvm-project?rev=362067=rev Log: asm goto: fix out-of-bounds read of Constraints after rC362045 When parsing goto labels, Names and Exprs are expanded but Constraints is not, this may cause a

[libunwind] r362065 - [CMake] Use find_package(LLVM) instead of LLVMConfig

Author: phosek Date: Thu May 30 00:34:39 2019 New Revision: 362065 URL: http://llvm.org/viewvc/llvm-project?rev=362065=rev Log: [CMake] Use find_package(LLVM) instead of LLVMConfig This addresses an issues introduced in r362047. Differential Revision: https://reviews.llvm.org/D62640 Modified:

r362062 - [AST] asm goto labels don't have constraints, don't try to copy them.

Author: d0k Date: Thu May 30 00:21:08 2019 New Revision: 362062 URL: http://llvm.org/viewvc/llvm-project?rev=362062=rev Log: [AST] asm goto labels don't have constraints, don't try to copy them. Found by asan. Modified: cfe/trunk/lib/AST/Stmt.cpp Modified: cfe/trunk/lib/AST/Stmt.cpp URL:

r362059 - Mark CodeGen/asm-goto.c as x86 specific after r362045

Author: maskray Date: Wed May 29 23:48:13 2019 New Revision: 362059 URL: http://llvm.org/viewvc/llvm-project?rev=362059=rev Log: Mark CodeGen/asm-goto.c as x86 specific after r362045 Modified: cfe/trunk/test/CodeGen/asm-goto.c Modified: cfe/trunk/test/CodeGen/asm-goto.c URL:

<    1   2