[PATCH] D58880: [clangd] Type hierarchy subtypes

nridge updated this revision to Diff 204208. nridge added a comment. Get disabled tests passing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58880/new/ https://reviews.llvm.org/D58880 Files: clang-tools-extra/clangd/ClangdServer.cpp

[PATCH] D6833: Clang-format: Braces Indent Style Whitesmith

timwoj added a comment. I updated this patch to remove all of the code from `ContinuationIndenter` and to use the newer `BraceWrapping` style option instead of setting each one individually in `UnwrappedLineParser`. I still have the same issue with enums. Looking at the `RootToken` in

[PATCH] D63180: [clang-doc] Adds HTML generator

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich, lebedev.ri. DiegoAstiazaran added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, mgorny. Implement a simple HMTL generator based on the existing Markdown generator.

[PATCH] D63164: [HIP] Add option to force lambda nameing following ODR in HIP/CUDA.

hliao added a comment. In D63164#1538968 , @tra wrote: > So, in short, what you're saying is that lambda type may leak into the > mangled name of a `__global__` function and ne need to ensure that the > mangled name is identical for both host and

[PATCH] D59744: Fix i386 ABI "__m64" type bug

This revision was automatically updated to reflect the committed changes. Closed by commit rL363116: [X86] [ABI] Fix i386 ABI __m64 type bug (authored by pengfei, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r363116 - [X86] [ABI] Fix i386 ABI "__m64" type bug

Author: pengfei Date: Tue Jun 11 18:52:23 2019 New Revision: 363116 URL: http://llvm.org/viewvc/llvm-project?rev=363116=rev Log: [X86] [ABI] Fix i386 ABI "__m64" type bug According to System V i386 ABI: the __m64 type paramater and return value are passed by MMX registers. But current

[PATCH] D62988: Add an attribute to allow fields of non-trivial types in C unions

ahatanak added a comment. In D62988#1538577 , @rsmith wrote: > How do you write correct (non-leaking, non-double-freeing, > non-releasing-invalid-pointers) code with this attribute? For example, > suppose I have a `__strong` union member: does storing

[PATCH] D62225: [clang][NewPM] Fixing remaining -O0 tests that are broken under new PM

leonardchan added a comment. In D62225#1537248 , @chandlerc wrote: > I think this ultimately needs to be split up into smaller patches. A bunch of > these things can be landed independently. Here is my first cut at things to > split out, each one into

[PATCH] D58880: [WIP] [clangd] Type hierarchy subtypes

nridge updated this revision to Diff 204201. nridge added a comment. Rebase, add lit test, and post for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58880/new/ https://reviews.llvm.org/D58880 Files:

[PATCH] D62978: [analyzer] trackExpressionValue(): Handle unknown values better

NoQ added a comment. This problem is fairly complicated. We clearly need both behaviors (sometimes track until the definition, sometimes track until the collapse-to-null), and it's not clear to me right now when exactly do we need each of them. This is also not a high priority for GSoC because

[PATCH] D62225: [clang][NewPM] Fixing remaining -O0 tests that are broken under new PM

leonardchan updated this revision to Diff 204198. leonardchan retitled this revision from "[clang][NewPM] Fixing -O0 tests that are broken under new PM" to "[clang][NewPM] Fixing remaining -O0 tests that are broken under new PM". leonardchan edited the summary of this revision. Repository: rG

[PATCH] D59744: Fix i386 ABI "__m64" type bug

wxiao3 added a comment. Thanks for the comments! Updated for landing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59744/new/ https://reviews.llvm.org/D59744 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59744: Fix i386 ABI "__m64" type bug

wxiao3 updated this revision to Diff 204197. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59744/new/ https://reviews.llvm.org/D59744 Files: lib/CodeGen/TargetInfo.cpp test/CodeGen/x86_32-arguments-linux.c test/CodeGen/x86_32-m64.c Index: test/CodeGen/x86_32-m64.c

[PATCH] D59673: [Clang] Harmonize Split DWARF options with llc

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59673/new/ https://reviews.llvm.org/D59673 ___

[PATCH] D63167: [Clang] Remove obsolete -enable-split-dwarf={single,split}

dblaikie added inline comments. Comment at: include/clang/Basic/CodeGenOptions.def:263 -ENUM_CODEGENOPT(SplitDwarfMode, DwarfFissionKind, 2, NoFission) ///< DWARF fission mode to use. +CODEGENOPT(EnableSplitDwarf, 1, 0) ///< Whether to enable split DWARF.

[PATCH] D63130: [Clang] Rename -split-dwarf-file to -split-dwarf-output

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good - thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63130/new/ https://reviews.llvm.org/D63130

[PATCH] D61809: [BPF] Preserve debuginfo array/union/struct type/access index

efriedma added a comment. The general idea of restricting the intrinsics to specific contexts makes sense. I'm not sure it makes sense to mark expressions, as opposed to types, though; can we really expect the user to know which expressions to apply this to? I'd like to see an actual

[PATCH] D62926: [analyzer] ReturnVisitor: Bypass everything to see inlined calls

NoQ added a comment. All right, it seems that i'm completely misunderstanding this problem and we've been talking past each other this whole time. The problem is not that we need to skip the `CXXConstructExpr`. The problem is that we need to skip `CXXNewExpr` (!!). CFG elements for an

[PATCH] D63176: [SemaObjC] Infer availability of stuff declared in categories from the availability of the enclosing category

arphaman added inline comments. Comment at: clang/test/SemaObjC/unguarded-availability.m:365 +// FIXME: The pretty-printing for categories sucks. +@interface HasCat () // expected-note 3 {{'' has been marked as being introduced in macOS 10.11 here, but the deployment target is

[PATCH] D62761: [analyzer] exploded-graph-rewriter: Implement a --diff mode.

Charusso added a comment. In D62761#1539143 , @NoQ wrote: > In D62761#1539137 , @Charusso wrote: > > > I asked for the new behavior, but I think it should be cool. > > > The new behavior is on the original

[PATCH] D61809: [BPF] Preserve debuginfo array/union/struct type/access index

yonghong-song added a comment. @rsmith @eli.friedman Ping again. Do you have any comments on my proposed clang/IR intrinsics? Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61809/new/ https://reviews.llvm.org/D61809

[PATCH] D63176: [SemaObjC] Infer availability of stuff declared in categories from the availability of the enclosing category

erik.pilkington created this revision. erik.pilkington added reviewers: arphaman, steven_wu. Herald added subscribers: dexonsmith, jkorous. Herald added a project: clang. These extend the class, but (unlike methods in @interfaces) can be referenced without mentioning the the category, so we

[PATCH] D62761: [analyzer] exploded-graph-rewriter: Implement a --diff mode.

NoQ added a comment. In D62761#1539137 , @Charusso wrote: > I asked for the new behavior, but I think it should be cool. The new behavior is on the original screenshot, i just uploaded the wrong patch initially >.< CHANGES SINCE LAST ACTION

[PATCH] D62761: [analyzer] exploded-graph-rewriter: Implement a --diff mode.

Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. I asked for the new behavior, but I think it should be cool. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62761/new/ https://reviews.llvm.org/D62761

[PATCH] D62761: [analyzer] exploded-graph-rewriter: Implement a --diff mode.

NoQ added a comment. In D62761#1525923 , @Charusso wrote: > In D62761#1525917 , @NoQ wrote: > > > Remove "-" from program point dumps because it resembles a removal marker > > in diffs. > > > Could you add an

[PATCH] D63175: [MS] Pretend constexpr variable template specializations are inline

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/AST/ASTContext.cpp:9809 + // variable template specializations inline. + if (isa(VD) && VD->isConstexpr()) +return

Re: r363086 - For DR712: store on a DeclRefExpr whether it constitutes an odr-use.

Thanks, should be fixed by r363113. On Tue, 11 Jun 2019 at 16:21, Reid Kleckner via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > The new assert is firing across Chromium, please fix or revert. This is a > reduced test case: > > int a; > struct Foo { > template void operator()(b, c = >

r363113 - Mark declarations as referenced by a default argument in a

Author: rsmith Date: Tue Jun 11 16:51:46 2019 New Revision: 363113 URL: http://llvm.org/viewvc/llvm-project?rev=363113=rev Log: Mark declarations as referenced by a default argument in a potentially-evaluated context. This applies even if the use of the default argument is within an unevaluated

[PATCH] D63175: [MS] Pretend constexpr variable template specializations are inline

rnk created this revision. rnk added a reviewer: rsmith. Herald added a project: clang. Fixes link errors with clang and the latest Visual C++ 14.21.27702 headers, which was reported as PR42027. I chose to intentionally make these things linkonce_odr, i.e. discardable, so that we don't emit

[PATCH] D62839: [clangd] Index API and implementations for relations

nridge updated this revision to Diff 204189. nridge marked 9 inline comments as done. nridge added a comment. Address remaining review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62839/new/ https://reviews.llvm.org/D62839 Files:

[PATCH] D62839: [clangd] Index API and implementations for relations

nridge added inline comments. Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:250 Path, llvm::make_unique(std::move(Symbols)), - llvm::make_unique(), /*CountReferences=*/false); + llvm::make_unique(), llvm::make_unique(), +

[PATCH] D63174: [clang][NewPM] Add RUNS for tests that produce slightly different IR under new PM

leonardchan created this revision. leonardchan added reviewers: chandlerc, echristo, phosek, serge-sans-paille. leonardchan added a project: clang. Herald added subscribers: dmgreen, Anastasia. With the new pass manager enabled by default, some tests produce slightly different IR from the legacy

Re: r363086 - For DR712: store on a DeclRefExpr whether it constitutes an odr-use.

The new assert is firing across Chromium, please fix or revert. This is a reduced test case: int a; struct Foo { template void operator()(b, c = a); }; Foo d; bool e; decltype(d(e)) gv; This causes the "missing non-odr-use marking for unevaluated decl ref" assertion on SemaExpr.cpp:16227 to

[PATCH] D60974: Clang IFSO driver action.

plotfi marked 3 inline comments as done. plotfi added a comment. In D60974#1534662 , @rupprecht wrote: > Can you upload this patch with context? Either use arc or upload w/ -U9 Thanks for the review. > I seem to have a lot of comments, but they're

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 204187. plotfi marked 11 inline comments as done. plotfi added a comment. addressing @rupprecht's feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 Files:

[PATCH] D62611: [analyzer][Dominators] Add unittests

Szelethus added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62611/new/ https://reviews.llvm.org/D62611 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D63164: [HIP] Add option to force lambda nameing following ODR in HIP/CUDA.

tra added a comment. So, in short, what you're saying is that lambda type may leak into the mangled name of a `__global__` function and ne need to ensure that the mangled name is identical for both host and device, hence the need for consistent naming of lambdas. If that's the case, shouldn't

[PATCH] D63170: [clang][NewPM] Fix broken -O0 test from missing assumptions

leonardchan updated this revision to Diff 204174. Herald added subscribers: dexonsmith, steven_wu, mehdi_amini. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63170/new/ https://reviews.llvm.org/D63170 Files:

[PATCH] D59963: [clang-tidy] Add a module for the Linux kernel.

nickdesaulniers added a comment. See also: https://github.com/ClangBuiltLinux/linux/issues/520 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59963/new/ https://reviews.llvm.org/D59963 ___ cfe-commits

[PATCH] D62750: Show note for -Wmissing-prototypes for functions with parameters

aaronpuchert updated this revision to Diff 204171. aaronpuchert added a comment. Add checks that we don't emit the fix-it when we shouldn't. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62750/new/ https://reviews.llvm.org/D62750 Files:

[PATCH] D63170: [clang][NewPM] Fix broken -O0 test from missing assumptions

leonardchan created this revision. leonardchan added reviewers: chandlerc, echristo, phosek, serge-sans-paille. leonardchan added a project: clang. Herald added subscribers: llvm-commits, hiraditya, eraman. Herald added a project: LLVM. leonardchan added a parent revision: D62225: [clang][NewPM]

[PATCH] D62738: [HIP] Support texture type

tra added a comment. So, the only thing this patch appears to do is make everything with this attribute uninitialized on device side and give protected visibility. If I understand it correctly, you're using the attribute in order to construct something that's sort of opposite of the currently

[PATCH] D63168: [clang][NewPM] Fix

leonardchan created this revision. leonardchan added reviewers: chandlerc, echristo, phosek, serge-sans-paille. leonardchan added a project: clang. Herald added a subscriber: aprantl. This contains the part of D62225 which fixes CodeGen/split-debug-single-file.c

[PATCH] D59673: [Clang] Harmonize Split DWARF options with llc

aaronpuchert marked 2 inline comments as done. aaronpuchert added a comment. In D59673#1521413 , @dblaikie wrote: > Might be easier as a few patches - renaming the existing option, D63130 > adding the new one, This

[PATCH] D63167: [Clang] Remove obsolete -enable-split-dwarf={single,split}

aaronpuchert created this revision. aaronpuchert added reviewers: dblaikie, echristo. aaronpuchert added a project: clang. Herald added a subscriber: aprantl. The changes in D59673 make the choice redundant, since we can achieve single-file split DWARF just by

[PATCH] D63010: [OpenMP] Add task alloc function

AlexEichenberger accepted this revision. AlexEichenberger added a comment. This revision is now accepted and ready to land. LGTM Repository: rOMP OpenMP CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63010/new/ https://reviews.llvm.org/D63010

[PATCH] D62437: [clang-tidy] Splits fuchsia-default-arguments

DiegoAstiazaran updated this revision to Diff 204157. DiegoAstiazaran added a comment. Improve format of documentation in ReleaseNotes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62437/new/ https://reviews.llvm.org/D62437 Files: clang-tools-extra/clang-tidy/fuchsia/CMakeLists.txt

[PATCH] D62738: [HIP] Support texture type

yaxunl updated this revision to Diff 204155. yaxunl marked 5 inline comments as done. yaxunl added a comment. Revised by Artem's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62738/new/ https://reviews.llvm.org/D62738 Files: include/clang/Basic/Attr.td

[PATCH] D63012: Use fully qualified name when printing S_CONSTANT records

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63012/new/ https://reviews.llvm.org/D63012 ___

[PATCH] D62970: [clang-doc] De-duplicate comments and locations

DiegoAstiazaran marked 4 inline comments as done. DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/clang-doc/Representation.cpp:124 + for (auto : Other.Description) { +bool IsCommentUnique = std::find(Description.begin(), Description.end(), +

[PATCH] D63164: [HIP] Add option to force lambda nameing following ODR in HIP/CUDA.

hliao created this revision. hliao added reviewers: tra, yaxunl. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Clang follows its own scheme for lambdas which don't need to follow ODR rule. That scheme will assign an unqiue ID within the TU scope and won't be unique or

[PATCH] D62970: [clang-doc] De-duplicate comments and locations

DiegoAstiazaran updated this revision to Diff 204146. DiegoAstiazaran retitled this revision from "[clang-doc] De-duplicate comments" to "[clang-doc] De-duplicate comments and locations". DiegoAstiazaran edited the summary of this revision. DiegoAstiazaran added a comment. Herald added a

[PATCH] D63143: [HIP] Enforce ODR rule for lambda in HIP/CUDA.

hliao updated this revision to Diff 204152. hliao added a comment. Add the comment for the motivation of this patch as well as reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63143/new/ https://reviews.llvm.org/D63143 Files:

[PATCH] D63161: Devirtualize destructor of final class.

rsmith added inline comments. Comment at: lib/CodeGen/CGExprCXX.cpp:1867-1868 - if (Dtor->isVirtual()) { + if (Dtor->isVirtual() && + !(Dtor->hasAttr() || RD->hasAttr())) { CGF.CGM.getCXXABI().emitVirtualObjectDelete(CGF, DE, Ptr, ElementType,

[PATCH] D63161: Devirtualize destructor of final class.

yamauchi created this revision. yamauchi added a reviewer: davidxl. Herald added a subscriber: Prazek. Herald added a project: clang. Take advantage of the final keyword to devirtualize destructor calls. Fix https://bugs.llvm.org/show_bug.cgi?id=21368 Repository: rC Clang

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

gtbercea updated this revision to Diff 204141. gtbercea added a comment. - Add tests. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63009/new/ https://reviews.llvm.org/D63009 Files: lib/CodeGen/CGOpenMPRuntime.cpp test/OpenMP/target_depend_codegen.cpp

[PATCH] D63010: [OpenMP] Add task alloc function

gtbercea updated this revision to Diff 204140. gtbercea added a comment. - Add temporary implementation. Repository: rOMP OpenMP CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63010/new/ https://reviews.llvm.org/D63010 Files: runtime/src/kmp.h runtime/src/kmp_tasking.cpp

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

gtbercea updated this revision to Diff 204139. gtbercea added a comment. Herald added a project: OpenMP. Herald added a subscriber: openmp-commits. - Add temporary implementation. Repository: rOMP OpenMP CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63009/new/

[PATCH] D63010: [OpenMP] Add task alloc function

gtbercea updated this revision to Diff 204138. gtbercea added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Add tests. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63010/new/ https://reviews.llvm.org/D63010 Files:

[PATCH] D63012: Use fully qualified name when printing S_CONSTANT records

akhuang updated this revision to Diff 204137. akhuang added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Change to not emit DIGlobalVariable for enums when they are defined in a class, which matches MSVC's behavior and gets around the issue of having to

[PATCH] D63157: C++ DR712 and others: handle non-odr-use resulting from an lvalue-to-rvalue conversion applied to a member access or similar not-quite-trivial lvalue expression.

rsmith created this revision. rsmith added a reviewer: rjmccall. Herald added a subscriber: jdoerfert. Herald added a project: clang. When a variable is named in a context where we can't directly emit a reference to it (because we don't know for sure that it's going to be defined, or it's from an

[PATCH] D62115: fix a issue that clang is incompatible with gcc with -H option.

kimgr added a comment. I think the test needs a bit more work. It's essentially checking the same thing twice to exercise the Windows path separators. It looks like there's already a test for `-H` in `FrontEnd/print-header-includes.c`. That also demonstrates the use of `--check-prefix` to

[PATCH] D63156: [clang][NewPM] Add -fno-experimental-new-pass-manager to tests

leonardchan created this revision. leonardchan added reviewers: chandlerc, echristo, phosek, serge-sans-paille. leonardchan added a project: clang. Herald added subscribers: dexonsmith, steven_wu, javed.absar, mehdi_amini. As per the discussion on D58375 , we

[PATCH] D63155: [clang][NewPM] Fix broken profile test

leonardchan created this revision. leonardchan added reviewers: chandlerc, echristo, phosek, serge-sans-paille. leonardchan added a project: clang. leonardchan added a parent revision: D62225: [clang][NewPM] Fixing -O0 tests that are broken under new PM. This contains the part of D62225

[PATCH] D62738: [HIP] Support texture type

tra added a comment. Syntactically the patch looks OK to me, but I think the purpose and meaning of the builtin type should be documented in more details. Based on this patch alone it's not clear at all what it's supposed to be used for and how. Comment at:

[PATCH] D62988: Add an attribute to allow fields of non-trivial types in C unions

rsmith added a comment. How do you write correct (non-leaking, non-double-freeing, non-releasing-invalid-pointers) code with this attribute? For example, suppose I have a `__strong` union member: does storing to it release the old value (which might be a different union member)? If so, how do

[PATCH] D62978: [analyzer] trackExpressionValue(): Handle unknown values better

Charusso marked 8 inline comments as done. Charusso added inline comments. Comment at: clang/test/Analysis/diagnostics/deref-track-symbolic-region.c:14 int m = 0; - syz.x = foo(); // expected-note{{Value assigned to 'syz.x'}} Here.

[PATCH] D62926: [analyzer] ReturnVisitor: Bypass everything to see inlined calls

Charusso marked 2 inline comments as done. Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:842-849 + if (Optional CEE = Node->getLocationAs()) if (CEE->getCalleeContext()->getCallSite() == S) break; -

[PATCH] D62926: [analyzer] ReturnVisitor: Bypass everything to see inlined calls

Charusso updated this revision to Diff 204111. Charusso marked an inline comment as done. Charusso added a comment. - I have used `LocationContext::isParentOf()`which is not worked well, so I thought we are out of our context. - With that I made some misleading assumptions about our code.

[PATCH] D62738: [HIP] Support texture type

yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62738/new/ https://reviews.llvm.org/D62738 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D63153: [clang][NewPM] Fix broken -O0 test from the AlwaysInliner

leonardchan created this revision. leonardchan added reviewers: chandlerc, echristo, phosek, serge-sans-paille. leonardchan added a project: clang. Herald added subscribers: kristof.beyls, javed.absar. This contains the part of D62225 which prevents insertion of

r363086 - For DR712: store on a DeclRefExpr whether it constitutes an odr-use.

Author: rsmith Date: Tue Jun 11 10:50:32 2019 New Revision: 363086 URL: http://llvm.org/viewvc/llvm-project?rev=363086=rev Log: For DR712: store on a DeclRefExpr whether it constitutes an odr-use. Begin restructuring to support the forms of non-odr-use reference permitted by DR712. Modified:

r363088 - Remove redundant check for whether a DeclRefExpr that names a capture

Author: rsmith Date: Tue Jun 11 10:50:37 2019 New Revision: 363088 URL: http://llvm.org/viewvc/llvm-project?rev=363088=rev Log: Remove redundant check for whether a DeclRefExpr that names a capture constitutes an odr-use. We now track this accurately on the DeclRefExpr. Modified:

r363087 - For DR712: store on a MemberExpr whether it constitutes an odr-use.

Author: rsmith Date: Tue Jun 11 10:50:36 2019 New Revision: 363087 URL: http://llvm.org/viewvc/llvm-project?rev=363087=rev Log: For DR712: store on a MemberExpr whether it constitutes an odr-use. Modified: cfe/trunk/include/clang/AST/Expr.h cfe/trunk/include/clang/AST/Stmt.h

[PATCH] D63149: Added AST matcher for ignoring elidable constructors

gribozavr added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:6455 +/// Matches expressions that match InnerMatcher after any elidable constructor are stripped off. +/// 80 columns Comment at:

[PATCH] D63149: Added AST matcher for ignoring elidable constructors

jvikstrom created this revision. jvikstrom added reviewers: hokein, gribozavr. Herald added a project: clang. Herald added a subscriber: cfe-commits. Added AST matcher for ignoring elidable move constructors Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D63149 Files:

[PATCH] D62831: [CodeGen][ObjC] Add attribute "arc_retain_agnostic" to ObjC globals that are retain-agnostic

rjmccall added a comment. Should `objc` be in the attribute somewhere to avoid any future awkwardness? I don't remember what we've called similar attributes. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62831/new/ https://reviews.llvm.org/D62831

[PATCH] D62988: Add an attribute to allow fields of non-trivial types in C unions

rjmccall added a comment. In D62988#1537401 , @ahatanak wrote: > In D62988#1537082 , @rjmccall wrote: > > > Does this lead to C/C++ ABI mismatches? Should we just honor this in C++ > > as well by ignoring it when

[PATCH] D59744: Fix i386 ABI "__m64" type bug

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Minor comments, then LGTM. Comment at: lib/CodeGen/TargetInfo.cpp:1094 +// FreeBSD) don't want to spend any effort dealing with the ramifications +// of ABI

Re: r363009 - [Frontend] SetUpDiagnosticLog should handle unowned diagnostic consumer

Hmm, the logging was meant to exercise the creation of chained diagnostic consumer, so without it the test is kind of pointless. I'll undo your change, but will set the file to "-" which will print the log to STDERR and won't create new files. Does that sound reasonable? Cheers, Alex On Tue, 11

Re: [PATCH] D60455: [SYCL] Implement SYCL device code outlining

Richard Smith, but his time is sometimes limited. John McCall would also be a great choice. Otherwise, I am happy to review when back next week. ~Aaron On Tue, Jun 11, 2019, 4:45 PM Bader, Alexey wrote: > Hi Aaron, > > > > I think Anastasia is on vacation. > > Could you recommend someone who

[PATCH] D63143: [HIP] Enforce ODR rule for lambda in HIP/CUDA.

hliao created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D63143 Files: clang/include/clang/Basic/LangOptions.def clang/include/clang/Driver/CC1Options.td

[PATCH] D63098: [CodeComplete] Allow completing enum values within case statements, and insert 'case' as a fixit.

ilya-biryukov added a comment. Notes from the offline discussion: - Sam: supporting multiple typed text chunks is hard, many clients that expect only one. Objective-C already does that, though, but in a way that does not break most targets. - Sam: supporting any other form of custom text for

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

serge-sans-paille added inline comments. Comment at: polly/lib/Support/RegisterPasses.cpp:727 +extern "C" ::llvm::PassPluginLibraryInfo LLVM_ATTRIBUTE_WEAK +llvmGetPassPluginInfo() { + return getPassPluginInfo(); Meinersbur wrote: > [serious] Unfortunately, the

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

serge-sans-paille updated this revision to Diff 204073. serge-sans-paille marked 3 inline comments as done. serge-sans-paille added a comment. @beanz : In addition to your suggested changes, I've renamed the cmake utility into `add_llvm_pass_plugin` to match other functions from `AddLLVM.cmake`

r363076 - Revert r344630 Disable code object version 3 for HIP toolchain.

Author: yaxunl Date: Tue Jun 11 08:05:11 2019 New Revision: 363076 URL: http://llvm.org/viewvc/llvm-project?rev=363076=rev Log: Revert r344630 Disable code object version 3 for HIP toolchain. Remove the workaround so that by default code object v3 is enabled. Modified:

[PATCH] D62804: [clangd] Enable extraction of system includes from custom toolchains

ilya-biryukov added a comment. In D62804#1538155 , @kadircet wrote: > For example a gcc cross compiling to arm comes with its own system includes > and has some mechanisms to discover that implicitly, without requiring any > "-I" flags. > Hence when

r363074 - Fix for r42230, MSVC test failure in DependencyDirectivesSourceMinimizerTest.cpp

Author: erichkeane Date: Tue Jun 11 07:58:26 2019 New Revision: 363074 URL: http://llvm.org/viewvc/llvm-project?rev=363074=rev Log: Fix for r42230, MSVC test failure in DependencyDirectivesSourceMinimizerTest.cpp r362459 introduced DependencyDirectivesSourceMinimizerTest.cpp, which hits an MSVC

RE: [PATCH] D60455: [SYCL] Implement SYCL device code outlining

Hi Aaron, I think Anastasia is on vacation. Could you recommend someone who can be “trusted reviewer” for this change, please? If no, we will wait for your/Anastasia review. Thanks, Alexey From: Aaron Ballman Sent: Tuesday, June 11, 2019 5:04 PM To:

[PATCH] D62804: [clangd] Enable extraction of system includes from custom toolchains

kadircet added a comment. In D62804#1533710 , @ilya-biryukov wrote: > Could you give more context on what the custom toolchains are? > One feasible alternative is to move this detection to clang's driver (where > the rest of include path detection

[PATCH] D63062: [clang-format] Added New Style Rule: OnePerLineBitFieldDecl

Manikishan updated this revision to Diff 204068. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63062/new/ https://reviews.llvm.org/D63062 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/ContinuationIndenter.cpp

[PATCH] D63140: [clangd] Return TextEdits from ClangdServer::applyTweak

ilya-biryukov created this revision. ilya-biryukov added a reviewer: kadircet. Herald added subscribers: arphaman, jkorous, MaskRay. Herald added a project: clang. Instead of tooling::Replacements. So that embedders do not need to store the contents of the file. This also aligns better

[PATCH] D62804: [clangd] Enable extraction of system includes from custom toolchains

kadircet updated this revision to Diff 204066. kadircet marked 27 inline comments as done. kadircet added a comment. Herald added a subscriber: mgorny. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62804/new/

r363070 - [NFC][PowerPC] Header-dependent test requires "native"

Author: hubert.reinterpretcast Date: Tue Jun 11 07:23:55 2019 New Revision: 363070 URL: http://llvm.org/viewvc/llvm-project?rev=363070=rev Log: [NFC][PowerPC] Header-dependent test requires "native" Two recently added tests mention complications for cross-compile, but they do not actually

r363069 - Reapply r362994 & co "[analyzer][tests] Add normalize_plist to replace diff_plist"

Author: hubert.reinterpretcast Date: Tue Jun 11 07:21:32 2019 New Revision: 363069 URL: http://llvm.org/viewvc/llvm-project?rev=363069=rev Log: Reapply r362994 & co "[analyzer][tests] Add normalize_plist to replace diff_plist" Following r363007, which reverted r362998, r362996, and r362994,

[PATCH] D63129: [clang-tidy] Fix invalid read on destruction

This revision was automatically updated to reflect the committed changes. Closed by commit rL363068: [clang-tidy] Fix invalid read on destruction (authored by nik, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST

[clang-tools-extra] r363068 - [clang-tidy] Fix invalid read on destruction

Author: nik Date: Tue Jun 11 07:19:09 2019 New Revision: 363068 URL: http://llvm.org/viewvc/llvm-project?rev=363068=rev Log: [clang-tidy] Fix invalid read on destruction ...in case the clang tidy plugin is linked into the clang binary. Valgrind's memcheck reports: 8949== Invalid read ==8866==

[PATCH] D63139: [Diagnostics] Implement -Wswitch-unreachable

xbolva00 created this revision. xbolva00 added reviewers: aaron.ballman, rsmith, rjmccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. Detects unreachable statements in switches. GCC supports this warning too, on by default. Repository: rC Clang

[PATCH] D48116: [libclang] Allow skipping warnings from all included files

This revision was automatically updated to reflect the committed changes. Closed by commit rL363067: [libclang] Allow skipping warnings from all included files (authored by nik, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r363067 - [libclang] Allow skipping warnings from all included files

Author: nik Date: Tue Jun 11 07:14:24 2019 New Revision: 363067 URL: http://llvm.org/viewvc/llvm-project?rev=363067=rev Log: [libclang] Allow skipping warnings from all included files Depending on the included files and the used warning flags, e.g. - Weverything, a huge number of warnings can be

  1   2   >