[PATCH] D64276: [ItaniumMangle] Replace useFloat128ManglingForLongDouble() with getManglingForLongDouble() and getManglingForFloat128()

MaskRay created this revision. MaskRay added reviewers: awilfox, echristo, erichkeane, hfinkel, majnemer, rnk, rsmith. Herald added subscribers: cfe-commits, erik.pilkington, jdoerfert, jsji, kbarton, nemanjai. Herald added a project: clang. On PowerPC, long double has 3 mangling schemes:

[PATCH] D64271: [analyzer] Don't track the right hand side of the last store for conditions

NoQ added a comment. Consider: int flag; bool coin(); void foo() { flag = coin(); } void test() { int *x = 0; int local_flag; flag = 1; foo(); local_flag = flag; if (local_flag) x = new int; foo(); local_flag = flag; if

[PATCH] D64270: [analyzer][NFC] Prepare visitors for different tracking kinds

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Approve! > null pointer dereference ...should in my opinion be tracked in a mild manner, as if it's a condition, because D62978 . I think the definition we're

[PATCH] D63756: [AMDGPU] Increased the number of implicit argument bytes for both OpenCL and HIP (CLANG).

cdevadas added a comment. The backend changes, D63886 are in the upstream now with revision rL365217 . Please review this patch. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63756/new/

[PATCH] D59919: [Attributor] Deduce "returned" argument attribute

hfinkel accepted this revision. hfinkel added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/CodeGenOpenCL/as_type.cl:3 +// Once the attributor is on by default remove the following run line and change the prefixes below. +// RUN:

r365258 - [Rewrite] Extend to further accept CharSourceRange

Author: jdenny Date: Fri Jul 5 19:55:06 2019 New Revision: 365258 URL: http://llvm.org/viewvc/llvm-project?rev=365258=rev Log: [Rewrite] Extend to further accept CharSourceRange Some Rewrite functions are already overloaded to accept CharSourceRange, and this extends others in the same manner.

[PATCH] D61467: [Rewrite] Extend to further accept CharSourceRange

This revision was automatically updated to reflect the committed changes. Closed by commit rL365258: [Rewrite] Extend to further accept CharSourceRange (authored by jdenny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64274: [analyzer] VirtualCallChecker overhaul.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet. Herald added a project: clang. This is slightly controversial,

[PATCH] D64128: [CodeGen] Generate llvm.ptrmask instead of inttoptr(and(ptrtoint, C)) if possible.

hfinkel added a comment. In D64128#1570609 , @rjmccall wrote: > In D64128#1569836 , @hfinkel wrote: > > > In D64128#1569817 , @rjmccall > > wrote: > > > > > The

[PATCH] D61467: [Rewrite] Extend to further accept CharSourceRange

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. The comments help a lot. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61467/new/ https://reviews.llvm.org/D61467 ___

[PATCH] D61467: [Rewrite] Extend to further accept CharSourceRange

jdenny updated this revision to Diff 208247. jdenny added a comment. @jdoerfert Thanks for your reply. I added some comments to the tests. Let me know whether that's what you're looking for. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61467/new/ https://reviews.llvm.org/D61467

[PATCH] D64272: [analyzer] Note last writes to a condition only in a nested stackframe

Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, rnkovacs, dcoughlin, Charusso, baloghadamsoftware. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity. Szelethus added a

[PATCH] D64271: [analyzer] Don't track the right hand side of the last store for conditions

Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, baloghadamsoftware, rnkovacs, Charusso, dcoughlin. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity. Szelethus added a

[PATCH] D64270: [analyzer][NFC] Prepare visitors for different tracking kinds

Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, rnkovacs, Charusso, baloghadamsoftware, dcoughlin. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity. When we're

r365248 - Improve MSVC visualization of annot_template_id tokens

Author: mps Date: Fri Jul 5 14:41:30 2019 New Revision: 365248 URL: http://llvm.org/viewvc/llvm-project?rev=365248=rev Log: Improve MSVC visualization of annot_template_id tokens Now shows the actual annotated template. E.g., {annot_template_id (A)} Also a few miscellaneous fixes to

[PATCH] D64264: [analyzer] exploded-graph-rewriter: Implement a topology-only mode.

NoQ updated this revision to Diff 208236. NoQ added a comment. Fxd! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64264/new/ https://reviews.llvm.org/D64264 Files: test/Analysis/exploded-graph-rewriter/topology.dot utils/analyzer/exploded-graph-rewriter.py Index:

[PATCH] D64264: [analyzer] exploded-graph-rewriter: Implement a topology-only mode.

Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. May you would remove the "Program points:" part as we only have that, but I think we have enough space for that tiny note. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D64263: [analyzer] exploded-graph-rewriter: Implement a single-path mode.

Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. Smart move! The left-most usually the shortest path, but what if not? I would calculate the length, other than that, cool. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D64263: [analyzer] exploded-graph-rewriter: Implement a single-path mode.

NoQ created this revision. NoQ added a reviewer: Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Instead of rewriting the whole graph, rewrite the leftmost path in

[PATCH] D64262: Bitstream reader: Fix undefined behavior seen after rL364464

This revision was automatically updated to reflect the committed changes. Closed by commit rL365239: Bitstream reader: Fix undefined behavior seen after rL364464 (authored by bjope, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64264: [analyzer] exploded-graph-rewriter: Implement a topology-only mode.

NoQ created this revision. NoQ added a reviewer: Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. In this mode the rewriter will only rewrite program points and omit

r365239 - Bitstream reader: Fix undefined behavior seen after rL364464

Author: bjope Date: Fri Jul 5 13:22:40 2019 New Revision: 365239 URL: http://llvm.org/viewvc/llvm-project?rev=365239=rev Log: Bitstream reader: Fix undefined behavior seen after rL364464 Summary: After rL364464 the following tests started to fail when running the clang-doc tests with an ubsan

[clang-tools-extra] r365239 - Bitstream reader: Fix undefined behavior seen after rL364464

Author: bjope Date: Fri Jul 5 13:22:40 2019 New Revision: 365239 URL: http://llvm.org/viewvc/llvm-project?rev=365239=rev Log: Bitstream reader: Fix undefined behavior seen after rL364464 Summary: After rL364464 the following tests started to fail when running the clang-doc tests with an ubsan

[PATCH] D63845: [WIP] Create a clang attribute that lets users specify LLVM attributes

jdoerfert added a comment. I think we should postpone a detailed discussion until we are ready to send an RFC on this. Nevertheless, I inlined some responses below. In D63845#1570639 , @aaron.ballman wrote: > In D63845#1566987

[PATCH] D63518: BitStream reader: propagate errors

bjope added inline comments. Comment at: clang-tools-extra/trunk/clang-doc/BitcodeReader.cpp:619 +// FIXME check that the enum is in range. +auto Code = static_cast(MaybeCode.get()); + jfb wrote: > jfb wrote: > > bjope wrote: > > > This has caused

[PATCH] D64262: Bitstream reader: Fix undefined behavior seen after rL364464

jfb accepted this revision. jfb added a comment. This revision is now accepted and ready to land. Thanks for catching this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64262/new/ https://reviews.llvm.org/D64262

[PATCH] D64262: Bitstream reader: Fix undefined behavior seen after rL364464

bjope created this revision. bjope added a reviewer: jfb. Herald added subscribers: kadircet, dexonsmith, ilya-biryukov. Herald added a project: clang. After rL364464 the following tests started to fail when running the clang-doc tests with an ubsan

[PATCH] D61467: [Rewrite] Extend to further accept CharSourceRange

jdoerfert added a comment. Could you describe the unit tests a little, what is tested and why. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61467/new/ https://reviews.llvm.org/D61467 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D63518: BitStream reader: propagate errors

jfb marked an inline comment as done. jfb added inline comments. Comment at: clang-tools-extra/trunk/clang-doc/BitcodeReader.cpp:619 +// FIXME check that the enum is in range. +auto Code = static_cast(MaybeCode.get()); + jfb wrote: > bjope wrote: > >

[PATCH] D63518: BitStream reader: propagate errors

jfb marked 2 inline comments as done. jfb added inline comments. Comment at: clang-tools-extra/trunk/clang-doc/BitcodeReader.cpp:619 +// FIXME check that the enum is in range. +auto Code = static_cast(MaybeCode.get()); + bjope wrote: > This has caused

[PATCH] D64257: [clangd] Added highlighting for non-builtin types

jvikstrom created this revision. jvikstrom added reviewers: hokein, sammccall, ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Added highlighting for non-builtin types using VisitTypeLoc. Ignoring namespace qualifiers as

[PATCH] D64256: Teach some warnings to respect gsd::Pointer and gsl::Owner attributes

xazax.hun created this revision. xazax.hun added reviewers: mgehre, rsmith, gribozavr. Herald added subscribers: cfe-commits, Charusso, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a project: clang. This patch extends some existing warnings to utilize the knowledge about the

[PATCH] D61809: [BPF] Preserve debuginfo array/union/struct type/access index

yonghong-song added a comment. @rsmith Ping again, do you have any comments on this patch? Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61809/new/ https://reviews.llvm.org/D61809 ___ cfe-commits mailing

[PATCH] D61879: WIP: Prototype of DSE optimizations for -ftrivial-auto-var-init

glider added inline comments. Comment at: llvm/lib/Transforms/Scalar/DeadStoreEliminationExp.cpp:556 + LocationSize LS = MemoryLocation::getForDest(MSI).Size; + ConstantRange Range(PointerSizeInBits, false); + if (!LS.isPrecise() || An assertion

[PATCH] D63773: [clangd] dummy variable extraction on a function scope

SureYeaah added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:90 +bool isAFunctionRef(const clang::Expr *Expr) { + const clang::DeclRefExpr *DeclRef = dyn_cast_or_null(Expr); + if (DeclRef && isa(DeclRef->getDecl()))

[PATCH] D64253: Let unaliased Args track which Alias they were created from, and use that in Arg::getAsString() for diagnostics

thakis created this revision. thakis added a reviewer: rnk. Herald added subscribers: MaskRay, hiraditya, arichardson, javed.absar, emaste. Herald added a reviewer: espindola. Herald added a project: LLVM. With this, `clang-cl /source-charset:utf-16 test.cc` now prints `invalid value 'utf-16' in

[PATCH] D63518: BitStream reader: propagate errors

bjope added inline comments. Comment at: clang-tools-extra/trunk/clang-doc/BitcodeReader.cpp:619 +// FIXME check that the enum is in range. +auto Code = static_cast(MaybeCode.get()); + This has caused problem for our sanitizer tests the last couple of

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

martong added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:8503 +llvm::Expected ASTImporter::Import(const APValue ) { + APValue Result; Tyker wrote: > martong wrote: > > Tyker wrote: > > > martong wrote: > > > > Looks okay, but could we have

[PATCH] D63538: [CFG] Add a new function to get the proper condition of a CFGBlock

RKSimon added a comment. In D63538#1571454 , @Szelethus wrote: > In D63538#1571451 , @Szelethus wrote: > > > Since the followup patches test this roughly anyways, and the fact that the > > AST's lifetime ends

[PATCH] D64222: [sanitizers] Use covering ObjectFormatType switches

sfertile accepted this revision. sfertile added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64222/new/ https://reviews.llvm.org/D64222

r365212 - Add a comment explaining why a function exists

Author: nico Date: Fri Jul 5 08:12:31 2019 New Revision: 365212 URL: http://llvm.org/viewvc/llvm-project?rev=365212=rev Log: Add a comment explaining why a function exists Modified: cfe/trunk/lib/Driver/Driver.cpp Modified: cfe/trunk/lib/Driver/Driver.cpp URL:

[PATCH] D64232: [analyzer] Prune calls to functions with linear CFGs that return a non-zero constrained value

Szelethus marked 2 inline comments as done. Szelethus added a comment. In D64232#1570938 , @NoQ wrote: > I'm slightly worried that we're fighting the symptoms rather than the root > cause here: why were these values tracked that far in the first place

[PATCH] D55793: [clang-tidy] Add duplicated access specifier readability check (PR25403)

aaron.ballman added a comment. In D55793#1535895 , @m4tx wrote: > @JonasToth thanks for asking! Yes, since I do not have commit access, I need > someone to do the commit for me. I'm sorry for the terribly long delay on getting this committed -- it fell

[PATCH] D57086: Ignore trailing NullStmts in StmtExprs for GCC compatibility

aaron.ballman added a comment. In D57086#1551354 , @domdom wrote: > In D57086#1550514 , @aaron.ballman > wrote: > > > In D57086#1549632 , @domdom wrote: > > > > >

r365210 - NFC: Add an explicit return for safety and consistency

Author: hamzasood Date: Fri Jul 5 07:36:08 2019 New Revision: 365210 URL: http://llvm.org/viewvc/llvm-project?rev=365210=rev Log: NFC: Add an explicit return for safety and consistency This case implicitly falls-through, which is fine now as it's at the end of the function, but it seems like an

[PATCH] D63538: [CFG] Add a new function to get the proper condition of a CFGBlock

Szelethus added a comment. In D63538#1571451 , @Szelethus wrote: > Since the followup patches test this roughly anyways, and the fact that the > AST's lifetime ends right after the CFG's construction makes the remaining > tests pretty much pointless, if

[PATCH] D63538: [CFG] Add a new function to get the proper condition of a CFGBlock

Szelethus added a comment. In D63538#1571418 , @RKSimon wrote: > @Szelethus This is causing problems on windows buildbots > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast > - revert? Apologies, I thought my followup

r365209 - Removed the test case added in D63538 due to windows buildbot failures

Author: szelethus Date: Fri Jul 5 07:22:10 2019 New Revision: 365209 URL: http://llvm.org/viewvc/llvm-project?rev=365209=rev Log: Removed the test case added in D63538 due to windows buildbot failures Modified: cfe/trunk/unittests/Analysis/CFGTest.cpp Modified:

[PATCH] D63773: [clangd] dummy variable extraction on a function scope

SureYeaah updated this revision to Diff 208174. SureYeaah marked 21 inline comments as done. SureYeaah added a comment. Added whitelist for computeInsertionPoint Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63773/new/

[PATCH] D64247: [clangd] Filter out non-governed files from broadcast

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This also turns off implicit discovery of additional compilation databases. Repository: rG LLVM Github

[PATCH] D63642: [analyzer] Add a debug analyzer config to place an event for each tracked condition

This revision was automatically updated to reflect the committed changes. Closed by commit rGb55745606fa6: [analyzer] Add a debug analyzer config to place an event for each tracked… (authored by Szelethus). Changed prior to commit: https://reviews.llvm.org/D63642?vs=205966=208171#toc

[PATCH] D64242: [AArch64] Fix scalar vuqadd intrinsics operands

john.brawn accepted this revision. john.brawn added a comment. This revision is now accepted and ready to land. LGTM, with one nitpick. Comment at: test/CodeGen/aarch64-neon-vuqadd-float-conversion-warning.c:2 +// RUN: %clang_cc1 -triple arm64-none-linux-gnu -target-feature

r365208 - [analyzer] Add a debug analyzer config to place an event for each tracked condition

Author: szelethus Date: Fri Jul 5 07:00:08 2019 New Revision: 365208 URL: http://llvm.org/viewvc/llvm-project?rev=365208=rev Log: [analyzer] Add a debug analyzer config to place an event for each tracked condition Differential Revision: https://reviews.llvm.org/D63642 Modified:

[PATCH] D63538: [CFG] Add a new function to get the proper condition of a CFGBlock

RKSimon added a comment. @Szelethus This is causing problems on windows buildbots http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast - revert? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63538/new/

[PATCH] D64239: [AArch64] Fix vsqadd scalar intrinsics operands

john.brawn accepted this revision. john.brawn added a comment. This revision is now accepted and ready to land. LGTM, with a couple of nitpicks. > The existing unsigned argument can cause faulty code as float to unsigned > conversion is undefined, > which llvm/clang optimizes away. It's

[PATCH] D62883: [analyzer] Track terminator conditions on which a tracked expressions depends

This revision was automatically updated to reflect the committed changes. Closed by commit rL365207: [analyzer] Track terminator conditions on which a tracked expression depends (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

r365207 - [analyzer] Track terminator conditions on which a tracked expression depends

Author: szelethus Date: Fri Jul 5 06:29:54 2019 New Revision: 365207 URL: http://llvm.org/viewvc/llvm-project?rev=365207=rev Log: [analyzer] Track terminator conditions on which a tracked expression depends This patch is a major part of my GSoC project, aimed to improve the bug reports of the

[PATCH] D61879: WIP: Prototype of DSE optimizations for -ftrivial-auto-var-init

glider added inline comments. Comment at: llvm/lib/Transforms/Scalar/DeadStoreEliminationExp.cpp:709 + size_t argN) { + const Function *F = cast(Callee); + if (argN >= F->arg_size()) This cast fails in the following case: ``` %21 = call i64

[PATCH] D64199: [clangd] Added highlighting for variable references (declrefs)

This revision was automatically updated to reflect the committed changes. jvikstrom marked an inline comment as done. Closed by commit rL365205: [clangd] Added highlighting for variable references (declrefs) (authored by jvikstrom, committed by ). Herald added a project: LLVM. Herald added a

[clang-tools-extra] r365205 - [clangd] Added highlighting for variable references (declrefs)

Author: jvikstrom Date: Fri Jul 5 06:06:03 2019 New Revision: 365205 URL: http://llvm.org/viewvc/llvm-project?rev=365205=rev Log: [clangd] Added highlighting for variable references (declrefs) Summary: Added highlighting for variable references using VisitDeclRefExpr. Reviewers: hokein,

[PATCH] D64127: [clangd] Deduplicate clang-tidy diagnostic messages.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:427 } + // Deduplicate clang-tidy diagnostics -- some clang-tidy checks may emit + // duplicated messages due to various reasons (e.g. the check

[PATCH] D64127: [clangd] Deduplicate clang-tidy diagnostic messages.

This revision was automatically updated to reflect the committed changes. Closed by commit rL365204: [clangd] Deduplicate clang-tidy diagnostic messages. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[clang-tools-extra] r365204 - [clangd] Deduplicate clang-tidy diagnostic messages.

Author: hokein Date: Fri Jul 5 05:57:56 2019 New Revision: 365204 URL: http://llvm.org/viewvc/llvm-project?rev=365204=rev Log: [clangd] Deduplicate clang-tidy diagnostic messages. Summary: Clang-tidy checks may emit duplicated messages (clang-tidy tool deduplicate them in its custom diagnostic

[PATCH] D64127: [clangd] Deduplicate clang-tidy diagnostic messages.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:427 } + // Deduplicate clang-tidy diagnostics -- some clang-tidy checks may emit + // duplicated messages

[PATCH] D64127: [clangd] Deduplicate clang-tidy diagnostic messages.

hokein updated this revision to Diff 208158. hokein marked 2 inline comments as done. hokein added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64127/new/ https://reviews.llvm.org/D64127 Files:

[PATCH] D64127: [clangd] Deduplicate clang-tidy diagnostic messages.

hokein added inline comments. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:427 } + // Deduplicate clang-tidy diagnostics -- some clang-tidy checks may emit + // duplicated messages due to various reasons (e.g. the check doesn't handle sammccall

[PATCH] D62619: [analyzer][IDF] Add a control dependency calculator + a new debug checker

This revision was automatically updated to reflect the committed changes. Szelethus marked 11 inline comments as done. Closed by commit rL365197: [analyzer][IDF] Add a control dependency calculator + a new debug checker (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald

r365197 - [analyzer][IDF] Add a control dependency calculator + a new debug checker

Author: szelethus Date: Fri Jul 5 05:17:44 2019 New Revision: 365197 URL: http://llvm.org/viewvc/llvm-project?rev=365197=rev Log: [analyzer][IDF] Add a control dependency calculator + a new debug checker I intend to improve the analyzer's bug reports by tracking condition expressions. 01 bool

[PATCH] D64199: [clangd] Added highlighting for variable references (declrefs)

hokein accepted this revision. hokein added a comment. thanks, looks good. Comment at: clang-tools-extra/clangd/unittests/SemanticHighlightingTests.cpp:52 R"cpp( -struct A { - double SomeMember; -}; -struct { -} $Variable[[HStruct]]; -void

[PATCH] D64243: [NFC][AArch64] Fix vector vqtb[lx][1-4]_s8 operand

dnsampaio created this revision. dnsampaio added a reviewer: LukeCheeseman. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. Change the vqtb[lx][1-4]_s8 instrinsics to have the last argument as vector of unsigned valuse, not signed, accordingly to

r365189 - [NFC] Test commit access

Author: gamesh411 Date: Fri Jul 5 05:00:52 2019 New Revision: 365189 URL: http://llvm.org/viewvc/llvm-project?rev=365189=rev Log: [NFC] Test commit access Modified: cfe/trunk/include/clang/AST/ASTImporter.h Modified: cfe/trunk/include/clang/AST/ASTImporter.h URL:

[PATCH] D64156: Make joined instances of JoinedOrSeparate flags point to the unaliased args, like all other arg types do

This revision was automatically updated to reflect the committed changes. Closed by commit rL365186: Make joined instances of JoinedOrSeparate flags point to the unaliased args… (authored by nico, committed by ). Changed prior to commit: https://reviews.llvm.org/D64156?vs=207873=208146#toc

r365186 - Make joined instances of JoinedOrSeparate flags point to the unaliased args, like all other arg types do

Author: nico Date: Fri Jul 5 04:45:24 2019 New Revision: 365186 URL: http://llvm.org/viewvc/llvm-project?rev=365186=rev Log: Make joined instances of JoinedOrSeparate flags point to the unaliased args, like all other arg types do This fixes an 8-year-old regression. r105763 made it so that

[PATCH] D64156: Make joined instances of JoinedOrSeparate flags point to the unaliased args, like all other arg types do

ruiu accepted this revision. ruiu added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64156/new/ https://reviews.llvm.org/D64156 ___ cfe-commits mailing list

[PATCH] D64199: [clangd] Added highlighting for variable references (declrefs)

jvikstrom marked 4 inline comments as done. jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:61 +} +if(isa(D)) { + addToken(Loc, HighlightingKind::Function); hokein wrote: > sammccall wrote: > >

[PATCH] D64242: [AArch64] Fix scalar vuqadd intrinsics operands

dnsampaio updated this revision to Diff 208144. dnsampaio added a comment. - Fix previously existing tests Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64242/new/ https://reviews.llvm.org/D64242 Files: include/clang/Basic/arm_neon.td

[PATCH] D64127: [clangd] Deduplicate clang-tidy diagnostic messages.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:427 } + // Deduplicate clang-tidy diagnostics -- some clang-tidy checks may emit + // duplicated messages due to various reasons (e.g. the check doesn't handle This

[PATCH] D64199: [clangd] Added highlighting for variable references (declrefs)

jvikstrom updated this revision to Diff 208143. jvikstrom added a comment. Separated into three testcases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64199/new/ https://reviews.llvm.org/D64199 Files:

[PATCH] D64199: [clangd] Added highlighting for variable references (declrefs)

jvikstrom updated this revision to Diff 208140. jvikstrom added a comment. Made tests more readable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64199/new/ https://reviews.llvm.org/D64199 Files:

[PATCH] D64242: [AArch64] Fix scalar vuqadd intrinsics operands

dnsampaio created this revision. dnsampaio added a reviewer: LukeCheeseman. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. Change the vuqadd scalar instrinsics to have the second argument as unsigned values, not signed, accordingly to

r365181 - Fix a buildbot failure due to the AST's lifetime ending before the test

Author: szelethus Date: Fri Jul 5 04:14:57 2019 New Revision: 365181 URL: http://llvm.org/viewvc/llvm-project?rev=365181=rev Log: Fix a buildbot failure due to the AST's lifetime ending before the test Modified: cfe/trunk/unittests/Analysis/CFGTest.cpp Modified:

[PATCH] D64241: [ASTImporter] Fix inequivalence of ClassTemplateInstantiations

martong created this revision. martong added a reviewer: a_sidorin. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a project: clang. We falsely state inequivalence if the template parameter is a

[PATCH] D64239: [AArch64] Fix vsqadd scalar intrinsics operands

dnsampaio created this revision. dnsampaio added a reviewer: LukeCheeseman. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. Change the vsqadd scalar instrinsics to have the second argument as signed values, not unsigned, accordingly to

[PATCH] D62611: [analyzer][Dominators] Add unittests

This revision was automatically updated to reflect the committed changes. Closed by commit rL365179: [analyzer][Dominators][NFC] Add unit tests (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r365179 - [analyzer][Dominators][NFC] Add unit tests

Author: szelethus Date: Fri Jul 5 03:16:36 2019 New Revision: 365179 URL: http://llvm.org/viewvc/llvm-project?rev=365179=rev Log: [analyzer][Dominators][NFC] Add unit tests Differential Revision: https://reviews.llvm.org/D62611 Added: cfe/trunk/unittests/Analysis/CFGBuildResult.h

[PATCH] D63538: [CFG] Add a new function to get the proper condition of a CFGBlock

This revision was automatically updated to reflect the committed changes. Closed by commit rL365177: [CFG] Add a new function to get the proper condition of a CFGBlock (authored by Szelethus, committed by ). Changed prior to commit: https://reviews.llvm.org/D63538?vs=207904=208130#toc

r365177 - [CFG] Add a new function to get the proper condition of a CFGBlock

Author: szelethus Date: Fri Jul 5 02:52:00 2019 New Revision: 365177 URL: http://llvm.org/viewvc/llvm-project?rev=365177=rev Log: [CFG] Add a new function to get the proper condition of a CFGBlock getTerminatorCondition() returned a condition that may be outside of the block, while the new

[PATCH] D64211: [ARM] Fix vector vuqadd intrinsics operands

dnsampaio updated this revision to Diff 208127. dnsampaio added a comment. - Added tests Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64211/new/ https://reviews.llvm.org/D64211 Files: include/clang/Basic/arm_neon.td test/CodeGen/aarch64-neon-intrinsics.c

[PATCH] D64210: [NFC][ARM] Fix vector vsqadd intrinsics operands

dnsampaio added a comment. In D64210#1570515 , @LukeCheeseman wrote: > Are there some changes/addition to tests attached to this? Hi, I can see no difference in the CodeGen test in tools/clang/test/CodeGen/aarch64-neon-intrinsics.c, which already

[PATCH] D64199: [clangd] Added highlighting for variable references (declrefs)

hokein added a comment. the implementation looks good, a few comments on the test. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:61 +} +if(isa(D)) { + addToken(Loc, HighlightingKind::Function); sammccall wrote: > jvikstrom wrote: >

[PATCH] D64123: Add clang-llvm-rename tool.

michaelplatings added a comment. Hi @ruiu, Can you comment on how this compares to clang-tidy? I had assumed that the readability-identifier-naming clang-tidy rule would largely do the trick. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D64199: [clangd] Added highlighting for variable references (declrefs)

jvikstrom updated this revision to Diff 208123. jvikstrom added a comment. Added additional testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64199/new/ https://reviews.llvm.org/D64199 Files:

r365174 - Silence gcc warning "control reaches end of non-void function" [NFCI]

Author: uabelho Date: Thu Jul 4 23:12:24 2019 New Revision: 365174 URL: http://llvm.org/viewvc/llvm-project?rev=365174=rev Log: Silence gcc warning "control reaches end of non-void function" [NFCI] Without this fix gcc (7.4) complains with /data/repo/master/clang/lib/CodeGen/CGObjCMac.cpp: In