[PATCH] D65227: clang-format: Support `if CONSTEXPR` if CONSTEXPR is a macro.

This revision was automatically updated to reflect the committed changes. Closed by commit rL367167: clang-format: Support `if CONSTEXPR` if CONSTEXPR is a macro. (authored by nico, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D65227: clang-format: Support `if CONSTEXPR` if CONSTEXPR is a macro.

thakis marked an inline comment as done. thakis added a comment. Thanks, landing with your suggestion applied. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65227/new/ https://reviews.llvm.org/D65227 ___ cfe-commits mailing list

r367167 - clang-format: Support `if CONSTEXPR` if CONSTEXPR is a macro.

Author: nico Date: Fri Jul 26 19:41:40 2019 New Revision: 367167 URL: http://llvm.org/viewvc/llvm-project?rev=367167=rev Log: clang-format: Support `if CONSTEXPR` if CONSTEXPR is a macro. This is like r305666 (which added support for `if constexpr`) except that it allows a macro name after the

[PATCH] D64301: Use `ln -n` to prevent forming a symlink cycle, instead of rm'ing the source

hubert.reinterpretcast added a comment. In D64301#1603499 , @thakis wrote: > Which platforms doesn't it work on? `ln -n` means something different on AIX: https://www.ibm.com/support/knowledgecenter/en/ssw_aix_72/l_commands/ln.html `-n` is not

[PATCH] D64301: Use `ln -n` to prevent forming a symlink cycle, instead of rm'ing the source

thakis added a comment. In D64301#1602660 , @hubert.reinterpretcast wrote: > `ln -n` is not a standard option that is portably supported. I'll be > restoring the use of `rm` (with `-f` instead of `-rf`) and the associated > comment for removing

[PATCH] D65000: [ARM] Set default alignment to 64bits

phosek added a comment. Reverted in rL367166 . Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65000/new/ https://reviews.llvm.org/D65000 ___ cfe-commits mailing list

r367166 - Revert "[ARM] Set default alignment to 64bits"

Author: phosek Date: Fri Jul 26 18:59:23 2019 New Revision: 367166 URL: http://llvm.org/viewvc/llvm-project?rev=367166=rev Log: Revert "[ARM] Set default alignment to 64bits" This reverts commit r367119. This broke several bots:

[PATCH] D65361: [analyzer] Trust global initializers when analyzing main().

NoQ updated this revision to Diff 212035. NoQ added a comment. Actually add the logic for C++. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65361/new/ https://reviews.llvm.org/D65361 Files: clang/lib/StaticAnalyzer/Core/RegionStore.cpp clang/test/Analysis/main.c

[PATCH] D65361: [analyzer] Trust global initializers when analyzing main().

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:157 ClusterBindings::Factory *CBFactory; + bool IsMainAnalysis; We could have put this flag into `RegionStoreManager` instead - after

[PATCH] D65361: [analyzer] Trust global initializers when analyzing main().

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, JDevlieghere, szepet. Herald added a project: clang. This is inspired by

r367165 - driver: Don't warn about assembler flags being unused when not assembling; different approach

Author: nico Date: Fri Jul 26 18:13:00 2019 New Revision: 367165 URL: http://llvm.org/viewvc/llvm-project?rev=367165=rev Log: driver: Don't warn about assembler flags being unused when not assembling; different approach This morally relands r365703 (and r365714), originally reviewed at

[PATCH] D65108: Reland "driver: Don't warn about assembler flags being unused when not assembling"

thakis abandoned this revision. thakis added a comment. We're going with D65233 instead. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65108/new/ https://reviews.llvm.org/D65108 ___ cfe-commits mailing

[PATCH] D65249: [NFC] use C++11 in AlignOf.h

BillyONeal added a comment. (In fact I observe many patterns in this review like: enum { Foo = alignof(void*); } aligned_storage_t<1234, Foo> x; and then a bunch of casting to treat it as a char buffer; if it was just born as a char buffer you can remove both the casts and the enum hack:

[PATCH] D65249: [NFC] use C++11 in AlignOf.h

BillyONeal added a comment. In D65249#1603335 , @jfb wrote: > @rnk: how about I add a bit of code that wraps `aligned_storage` on all > platforms except MSVC (where I'd implement it as Billy suggests). That would > mean updating all the uses of

[PATCH] D64671: [clang-tidy] New check: misc-init-local-variables

alexfh added a comment. A general comment: "misc" is a sort of a heap of checks that otherwise don't have a good home. This one would probably better go to bugprone (or maybe there's a relevant CERT or C++ Core Guidelines rule?). CHANGES SINCE LAST ACTION

[PATCH] D65065: [clang-tidy] Possibility of displaying duplicate warnings

alexfh added a comment. I think it will be a strict improvement to include the check name into the deduplication key (probably after the file and offset and before the message). I don't see any reason to hide this behind a flag or otherwise retain the old behavior. As for expanding the key to

[PATCH] D60943: Delay diagnosing asm constraints that require immediates until after inlining

void added a comment. That was intentional. We want to do this for more than just the `n` constraint. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60943/new/ https://reviews.llvm.org/D60943 ___ cfe-commits mailing

[PATCH] D64146: [ConstExprPreter][WIP] Initial patch for the constexpr interpreter

rsmith added a comment. How do you intend to represent pointers cast to integer types? Allocating 64 bits of state for a 64-bit integer is insufficient to model that case. Comment at: clang/include/clang/AST/ASTContext.h:583-584 + /// Returns the constexpr VM context. +

[PATCH] D65359: [Sema] Map from a variable template specialization in a pattern to a variable template specialization in an instantiation properly

erik.pilkington created this revision. erik.pilkington added a reviewer: rsmith. Herald added subscribers: dexonsmith, jkorous. Previously, when instantiating `S::mf` below, we would emit a reference to the declaration of S::v, when we really ought to make a new declaration for `v` in the

[PATCH] D65000: [ARM] Set default alignment to 64bits

phosek added inline comments. Comment at: cfe/trunk/test/CodeGen/ARM/exception-alignment.cpp:9 +// A16-NEXT: store <2 x i64> , <2 x i64>* [[BC]], align 16 +#include + thegameg wrote: > thakis wrote: > > This fails on some bots: > > > >

[PATCH] D65022: [Sema] Always instantiate the initializer of a variable template with undeduced type (8.0 regression)

erik.pilkington updated this revision to Diff 212026. erik.pilkington added a comment. Fix the type of the MemberExpr/DeclRefExpr after instantiating the variable initializer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65022/new/ https://reviews.llvm.org/D65022 Files:

Buildbot numbers for the week of 07/14/2019 - 07/20/2019

Hello everyone, Below are some buildbot numbers for the last week of 07/14/2019 - 07/20/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from

Buildbot numbers for the week of 07/07/2019 - 07/13/2019

Hello everyone, Below are some buildbot numbers for the week of 07/07/2019 - 07/13/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed

[PATCH] D65249: [NFC] use C++11 in AlignOf.h

jfb added a comment. In D65249#1603278 , @BillyONeal wrote: > > @BillyONeal do you know if 19.11 has the aligned_storage issue on x86? > > aligned_storage is still capped at what the library can fake with unions. It > would be an ABI break to change it

[PATCH] D50256: [Analyzer] Basic support for multiplication and division in the constraint manager (for == and != only)

NoQ added inline comments. Comment at: test/Analysis/multiplicative-folding.c:140-142 +clang_analyzer_eval(n == -1); //expected-warning{{FALSE}} +clang_analyzer_eval(n == 0); //expected-warning{{TRUE}} +clang_analyzer_eval(n == 1); //expected-warning{{FALSE}}

[PATCH] D58164: Block+lambda: allow reference capture

ahatanak updated this revision to Diff 212016. ahatanak added a comment. Rebase. I think the fix is correct. When the lambda expression for the generic lambda is built, `BuildLambdaExpr` passes a `Capture` object in `LambdaScopeInfo::Captures` to `BuildCaptureField` to build the closure class

[PATCH] D65249: [NFC] use C++11 in AlignOf.h

BillyONeal added a comment. > @BillyONeal do you know if 19.11 has the aligned_storage issue on x86? aligned_storage is still capped at what the library can fake with unions. It would be an ABI break to change it to use alignas, so things where the x86 stack temporarily breaks T's usual

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

ziangwan updated this revision to Diff 212015. ziangwan added a comment. Fix typos. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64666/new/ https://reviews.llvm.org/D64666 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D64838: [Attr] Support _attribute__ ((fallthrough))

Nathan-Huckleberry updated this revision to Diff 212012. Nathan-Huckleberry added a comment. Herald added a subscriber: arphaman. - Rework attribute parsing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64838/new/ https://reviews.llvm.org/D64838

[PATCH] D64838: [Attr] Support _attribute__ ((fallthrough))

Nathan-Huckleberry updated this revision to Diff 212014. Nathan-Huckleberry added a comment. - Formatting fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64838/new/ https://reviews.llvm.org/D64838 Files: clang/include/clang/Basic/Attr.td

[PATCH] D65341: [OpenMP] Add support for close map modifier in Clang

gtbercea updated this revision to Diff 212011. gtbercea added a comment. - Improve test. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65341/new/ https://reviews.llvm.org/D65341 Files: lib/CodeGen/CGOpenMPRuntime.cpp test/OpenMP/target_data_codegen.cpp

[PATCH] D65343: [clang-tidy] Fix the documentation for linuxkernel-must-use-errs.

tmroeder added a comment. Apologies about D59963 ; I should have waited longer to make sure things were resolved. My submission raced with a flip from being approved to land to not approved to land. I'll wait longer next time to make sure comments and approvals

[PATCH] D59963: [clang-tidy] Add a module for the Linux kernel.

tmroeder marked an inline comment as done. tmroeder added inline comments. Comment at: clang-tools-extra/clang-tidy/linuxkernel/MustCheckErrsCheck.cpp:12 +#include "clang/ASTMatchers/ASTMatchFinder.h" +#include + tmroeder wrote: > nickdesaulniers wrote: > >

[PATCH] D65302: [clang][docs][release notes] mention asm goto support

This revision was automatically updated to reflect the committed changes. Closed by commit rL367158: [clang][docs][release notes] mention asm goto support (authored by hans, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D65302: [clang][docs][release notes] mention asm goto support

hans added a comment. > I don't have an SVN checkout; would you be so kind as to please merge this on > my behalf? Committed in r367158. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65302/new/ https://reviews.llvm.org/D65302

[PATCH] D65302: [clang][docs][release notes] mention asm goto support

nickdesaulniers added a comment. > Go ahead and commit directly to the branch (I think it can only be done with > SVN still), or let me know if you'd like me to do it. Thanks again for the review and tips. I was going to ask how does committing work now... I don't have an SVN checkout; would

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

xbolva00 added a comment. (But please wait for @aaron.ballman) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64666/new/ https://reviews.llvm.org/D64666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

xbolva00 added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:11653 + // Propagate whether we are in a c++ list initialization expression. + // If so, we do not issue warnings for implicit int-flaot conversion + // precision loss because c++11 narrowing already

[PATCH] D65302: [clang][docs][release notes] mention asm goto support

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Looks great! Go ahead and commit directly to the branch (I think it can only be done with SVN still), or let me know if you'd like me to do it. Comment at:

[PATCH] D65110: [NewPM] Run avx*-builtins.c tests under the new pass manager only

This revision was automatically updated to reflect the committed changes. Closed by commit rL367157: [NewPM] Run avx*-builtins.c tests under the new pass manager only (authored by leonardchan, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

r367157 - [NewPM] Run avx*-builtins.c tests under the new pass manager only

Author: leonardchan Date: Fri Jul 26 14:19:37 2019 New Revision: 367157 URL: http://llvm.org/viewvc/llvm-project?rev=367157=rev Log: [NewPM] Run avx*-builtins.c tests under the new pass manager only This patch changes the following tests to run under the new pass manager only: ``` Clang ::

[PATCH] D65110: [NewPM] Run avx*-builtins.c tests under the new pass manager only

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65110/new/ https://reviews.llvm.org/D65110

[PATCH] D65270: [CMake] Fix source path generation for install in multi-config (MSBuild)

beanz requested changes to this revision. beanz added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Headers/CMakeLists.txt:190 +if(CMAKE_CONFIGURATION_TYPES) + string(REPLACE "${CMAKE_CFG_INTDIR}" "$" output_dir "${output_dir}")

[PATCH] D65349: [analyzer] Be more careful with destructors of non-regions.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet. Herald added a project: clang. It turns out that we crash all over

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

xbolva00 accepted this revision. xbolva00 added a comment. Nice simple fix :) thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64666/new/ https://reviews.llvm.org/D64666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D65345: [analyzer] exploded-graph-rewriter: Implement manual graph trimming.

Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. It is a great idea, thanks! Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:918 +# TargetedTrimmer keeps paths that lead to specific nodes and discards all

[PATCH] D65302: [clang][docs][release notes] mention asm goto support

nickdesaulniers marked an inline comment as done. nickdesaulniers added a comment. Thanks for the tips, how does that look @hans ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65302/new/ https://reviews.llvm.org/D65302

[PATCH] D65302: [clang][docs][release notes] mention asm goto support

nickdesaulniers updated this revision to Diff 212002. nickdesaulniers added a comment. Herald added a reviewer: alexshap. - add details about ClangBuiltLinux Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65302/new/ https://reviews.llvm.org/D65302

[PATCH] D65249: [NFC] use C++11 in AlignOf.h

jfb added a subscriber: BillyONeal. jfb added a comment. In D65249#1603133 , @rnk wrote: > I still think this concern applies: > https://reviews.llvm.org/D64417#1576675 > > I'm not sure how to track down an 19.11 release to test if we can pass >

[PATCH] D65000: [ARM] Set default alignment to 64bits

thegameg added inline comments. Comment at: cfe/trunk/test/CodeGen/ARM/exception-alignment.cpp:9 +// A16-NEXT: store <2 x i64> , <2 x i64>* [[BC]], align 16 +#include + thakis wrote: > This fails on some bots: > >

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

ziangwan updated this revision to Diff 212001. ziangwan added a comment. Update diff. 1. Silence the warning when C++11 narrowing is in effect on intialization-list expression. 2. Add test cases to test "no duplicated warnings for c++11 narrowing" 3. Updated test cases to handle 32-bit host

Re: r367134 - [Sema] Fix -Wuninitialized for struct assignment from GNU C statement expression

Merged to release_90 in r367150. On Fri, Jul 26, 2019 at 10:28 AM Nathan Huckleberry via cfe-commits wrote: > > Author: nathan-huckleberry > Date: Fri Jul 26 10:29:35 2019 > New Revision: 367134 > > URL: http://llvm.org/viewvc/llvm-project?rev=367134=rev > Log: > [Sema] Fix -Wuninitialized for

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. Looks good in general, but commit the runtime part at first. Comment at: test/OpenMP/declare_mapper_codegen.cpp:44-48 +// CK0-DAG: store i8* %0, i8** [[HANDLEADDR:%[^,]+]]

[PATCH] D65249: [NFC] use C++11 in AlignOf.h

rnk added a comment. I still think this concern applies: https://reviews.llvm.org/D64417#1576675 I'm not sure how to track down an 19.11 release to test if we can pass std::aligned_storage values through function calls on x86. We might be better off raising the minimum to 19.14, which is a

r367149 - [CodeGen] fix test that broke with rL367146

Author: spatel Date: Fri Jul 26 13:36:57 2019 New Revision: 367149 URL: http://llvm.org/viewvc/llvm-project?rev=367149=rev Log: [CodeGen] fix test that broke with rL367146 This should be fixed properly to not depend on LLVM (so much). Modified: cfe/trunk/test/CodeGen/complex-math.c

[PATCH] D65343: [clang-tidy] Fix the documentation for linuxkernel-must-use-errs.

Eugene.Zelenko added a comment. Sorry, I didn't notice that D59963 was committed. In general it's not good idea to commit changes when patch was not approved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

r367147 - Partially revert rC365414; `ln -n` is not portable

Author: hubert.reinterpretcast Date: Fri Jul 26 13:09:37 2019 New Revision: 367147 URL: http://llvm.org/viewvc/llvm-project?rev=367147=rev Log: Partially revert rC365414; `ln -n` is not portable This restores the use of `rm` instead of the non-portable `ln -n`. Such use being the status quo for

[PATCH] D65343: [clang-tidy] Fix the documentation for linuxkernel-must-use-errs.

Eugene.Zelenko added a comment. Looks OK, but please make this changes in D59963 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65343/new/ https://reviews.llvm.org/D65343

[PATCH] D65250: [analyzer] exploded-graph-rewriter: Improve user-friendliness.

Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. I like the HTML output, thanks! Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:846 +print(' $ dot -Tsvg input.dot -o output.svg') +

[PATCH] D65344: [analyzer] exploded-graph-rewriter: NFC: Replace explorers with trimmers.

NoQ updated this revision to Diff 211992. NoQ added a comment. Fxd. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65344/new/ https://reviews.llvm.org/D65344 Files: clang/test/Analysis/exploded-graph-rewriter/explorers.dot clang/test/Analysis/exploded-graph-rewriter/trimmers.dot

[PATCH] D65344: [analyzer] exploded-graph-rewriter: NFC: Replace explorers with trimmers.

Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. In my mind an explorer would trim me a graph so I like the new abstraction to differentiate the two. Thanks! Comment at:

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

lildmh updated this revision to Diff 211991. lildmh added a comment. Make `emitUDMapperArrayInitOrDel` private CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59474/new/ https://reviews.llvm.org/D59474 Files: include/clang/AST/GlobalDecl.h lib/AST/ASTContext.cpp

[PATCH] D65270: [CMake] Fix source path generation for install in multi-config (MSBuild)

phosek added a comment. LGTM, @beanz and @smeenai do you have any further comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65270/new/ https://reviews.llvm.org/D65270 ___ cfe-commits mailing

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

emmettneyman updated this revision to Diff 211988. emmettneyman marked 6 inline comments as done. emmettneyman added a comment. Addressed comments and feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64380/new/

[PATCH] D65345: [analyzer] exploded-graph-rewriter: Implement manual graph trimming.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet. Herald added a project: clang. NoQ added a parent revision: D65344:

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

emmettneyman marked 16 inline comments as done. emmettneyman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1948 +def RequiresDesignator : InheritableAttr { + let Spellings = [Clang<"requires_designator">, GCC<"designated_init">]; + let Subjects =

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

Nathan-Huckleberry updated this revision to Diff 211987. Nathan-Huckleberry added a comment. - Order swap and elif Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64454/new/ https://reviews.llvm.org/D64454 Files:

[PATCH] D65308: [NFC][clang] Refactor getCompilationPhases()+Types.def step 3.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65308/new/ https://reviews.llvm.org/D65308

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

kpn added a comment. I actually don't have much of an opinion on what the command line argument form should be. It may be helpful for it to be the same as one of the commonly deployed compilers. The worst I think would be pretty close but with subtle differences. So if it can be made to work

[PATCH] D65344: [analyzer] exploded-graph-rewriter: NFC: Replace explorers with trimmers.

NoQ created this revision. NoQ added a reviewer: Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Explorers aren't the right abstraction. For the purposes of

[PATCH] D65341: [OpenMP] Add support for close map modifier in Clang

gtbercea marked 2 inline comments as done. gtbercea added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:7695 Flags &= ~(OMP_MAP_TO | OMP_MAP_FROM | OMP_MAP_ALWAYS | - OMP_MAP_DELETE); + OMP_MAP_DELETE

[PATCH] D64958: [clang-doc] Fix link generation

DiegoAstiazaran updated this revision to Diff 211979. DiegoAstiazaran edited the summary of this revision. DiegoAstiazaran added a comment. Change attribute used to check special case of global namespace; IsPathValid changed to IsInGlobalNamespace. This attribute is true when its first parent is

[PATCH] D65308: [NFC][clang] Refactor getCompilationPhases()+Types.def step 3.

plotfi updated this revision to Diff 211981. plotfi marked an inline comment as done. plotfi added a comment. addressing @compnerd 's feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65308/new/ https://reviews.llvm.org/D65308 Files:

[PATCH] D59963: [clang-tidy] Add a module for the Linux kernel.

tmroeder marked an inline comment as done. tmroeder added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:77 + + This is important in the Linux kernel because ``ERR_PTR``, ``PTR_ERR``, + ``IS_ERR``, ``IS_ERR_OR_NULL``, ``ERR_CAST``, and ``PTR_ERR_OR_ZERO``

[PATCH] D65343: [clang-tidy] Fix the documentation for linuxkernel-must-use-errs.

tmroeder created this revision. tmroeder added a reviewer: Eugene.Zelenko. Herald added a subscriber: xazax.hun. Herald added a project: clang. This changes ReleaseNotes.txt to have the first sentence of the full documentation from linuxkernel-must-use-errs.rst. This addresses a comment from the

[PATCH] D64838: [Attr] Support _attribute__ ((fallthrough))

rsmith added a comment. In D64838#1602840 , @Nathan-Huckleberry wrote: > I agree that parsing according to attribute name/type is not a good solution. > > It sounds like we have narrowed it down to two choices: > Do we want to follow the gcc method of

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc marked 3 inline comments as done. mibintc added a comment. Thanks for your review >>! In D62731#1601408 , @kpn wrote: > In D62731#1601310 , @mibintc wrote: > >> I think it would be convenient to have an

[PATCH] D64811: Warn when NumParams overflows

rjmccall added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:6673 + // Avoid exceeding the maximum function parameters + // See https://bugs.llvm.org/show_bug.cgi?id=19607 + if (ParamInfo.size() > Type::getMaxNumParams()) { rjmccall wrote: > We

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

aaron.ballman added a comment. When I run the script locally, I still get issues with `subprocess.run()`. c:\llvm\tools\clang\tools\extra\docs\clang-tidy\checks>python gen-static-analyzer-docs.py Traceback (most recent call last): File "gen-static-analyzer-docs.py", line 148, in

[PATCH] D65234: [CodeGen]: don't treat structures returned in registers as memory inputs

efriedma added inline comments. Comment at: clang/test/CodeGen/PR42672.c:50 + struct { +long long int v1, v2, v3, v4; + } str; glider wrote: > The acceptable size actually depends on the target platform. Not sure we can > test for all of them, and we'll

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:815 + /// code generation. + void emitUDMapperArrayInitOrDel(CodeGenFunction , + llvm::Value *Handle, llvm::Value *BasePtr, lildmh wrote: > ABataev wrote:

[PATCH] D61466: [Rewrite][NFC] Add FIXMEs and tests for RemoveLineIfEmpty bug

jdenny added a comment. In D61466#1602917 , @jkorous wrote: > Hi @jdenny, thanks for the warning! Hi. Thanks for the review. > I think having the test disabled is fine - the main upside I see is that we > won't check it fails over and over on our CI

[PATCH] D64811: Warn when NumParams overflows

rjmccall added inline comments. Comment at: clang/include/clang/AST/Type.h:1523 + enum { NumParamsBits = 16 }; + This should probably go in `FunctionTypeBitfields`. Comment at: clang/lib/Parse/ParseDecl.cpp:6673 + // Avoid exceeding the

[PATCH] D64932: [Parser] Emit descriptive diagnostic for misplaced pragma

rjmccall added inline comments. Comment at: clang/lib/Basic/TokenKinds.cpp:55 +return std::strncmp(#X, "pragma_", sizeof("pragma_") - 1) == 0; +#include "clang/Basic/TokenKinds.def" + default: The right way to do this is to make a `PRAGMA_ANNOTATION` macro

[PATCH] D65000: [ARM] Set default alignment to 64bits

thakis added inline comments. Comment at: cfe/trunk/test/CodeGen/ARM/exception-alignment.cpp:9 +// A16-NEXT: store <2 x i64> , <2 x i64>* [[BC]], align 16 +#include + This fails on some bots:

[PATCH] D61104: [clang][ASTContext] Try to avoid sorting comments for code completion

jkorous abandoned this revision. jkorous added a comment. Abandoned in favor of https://reviews.llvm.org/D65301 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61104/new/ https://reviews.llvm.org/D61104 ___

[PATCH] D61103: [clang] Add tryToAttachCommentsToDecls method to ASTContext

jkorous abandoned this revision. jkorous added a comment. Abandoned in favor of https://reviews.llvm.org/D65301 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61103/new/ https://reviews.llvm.org/D61103 ___ cfe-commits mailing list

[PATCH] D61466: [Rewrite][NFC] Add FIXMEs and tests for RemoveLineIfEmpty bug

jkorous added a comment. Hi @jdenny, thanks for the warning! I think having the test disabled is fine - the main upside I see is that we won't check it fails over and over on our CI systems. Could you please mention the test/reproducer in those FIXMEs? Otherwise LGTM.

[PATCH] D65309: [clang-format] Fix style of css file paths

This revision was automatically updated to reflect the committed changes. Closed by commit rL367137: [clang-format] Fix style of css file paths (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

lildmh marked an inline comment as done. lildmh added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:815 + /// code generation. + void emitUDMapperArrayInitOrDel(CodeGenFunction , + llvm::Value *Handle, llvm::Value *BasePtr,

[clang-tools-extra] r367137 - [clang-format] Fix style of css file paths

Author: diegoastiazaran Date: Fri Jul 26 11:02:42 2019 New Revision: 367137 URL: http://llvm.org/viewvc/llvm-project?rev=367137=rev Log: [clang-format] Fix style of css file paths CSS files included in HTML should have a path in posix style, it should not be different for Windows. Differential

[PATCH] D65309: [clang-format] Fix style of css file paths

DiegoAstiazaran updated this revision to Diff 211971. DiegoAstiazaran added a comment. Add comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65309/new/ https://reviews.llvm.org/D65309 Files: clang-tools-extra/clang-doc/HTMLGenerator.cpp

[PATCH] D65341: [OpenMP] Add support for close map modifier in Clang

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:7695 Flags &= ~(OMP_MAP_TO | OMP_MAP_FROM | OMP_MAP_ALWAYS | - OMP_MAP_DELETE); + OMP_MAP_DELETE | OMP_MAP_CLOSE); Why?

[PATCH] D65184: [Sema] Thread Safety Analysis: Fix negative capability's LockKind representation.

ziangwan marked 4 inline comments as done. ziangwan added inline comments. Comment at: clang/lib/Analysis/ThreadSafety.cpp:2188-2190 +/// shared + exclusive = exclusive +/// generic + exclusive = exclusive +/// generic + shared = shared aaronpuchert wrote: >

[PATCH] D65341: [OpenMP] Add support for close map modifier in Clang

gtbercea created this revision. gtbercea added reviewers: ABataev, caomhin. Herald added subscribers: cfe-commits, guansong. Herald added a reviewer: jdoerfert. Herald added a project: clang. This patch adds support for the close map modifier in Clang. This ensures that the new map type is

[PATCH] D65030: [clang-doc] Add second index for sections within info's content

DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/unittests/clang-doc/HTMLGeneratorTest.cpp:47-52 + + Namespaces + Records + Functions + OneFunction + juliehockett wrote: > Formatting is a bit weird for sublists Fixed by D65005. It will be

[PATCH] D65110: [NewPM] Run avx*-builtins.c tests under the new pass manager only

leonardchan added a comment. *ping* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65110/new/ https://reviews.llvm.org/D65110 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

Nathan-Huckleberry updated this revision to Diff 211967. Nathan-Huckleberry added a comment. - Add in-tree as possible default location Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64454/new/ https://reviews.llvm.org/D64454 Files:

Re: [clang-tools-extra] r367112 - [clangd] Fix background index not triggering on windows due to case mismatch.

Merged to release_90 in r367135. On Fri, Jul 26, 2019 at 7:06 AM Sam McCall via cfe-commits wrote: > > Author: sammccall > Date: Fri Jul 26 07:07:11 2019 > New Revision: 367112 > > URL: http://llvm.org/viewvc/llvm-project?rev=367112=rev > Log: > [clangd] Fix background index not triggering on

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:815 + /// code generation. + void emitUDMapperArrayInitOrDel(CodeGenFunction , + llvm::Value *Handle, llvm::Value *BasePtr, Seems to me, this function is

  1   2   >