[PATCH] D64678: [Sema] Fix -Wuninitialized for struct assignment from GNU C statement expression

This revision was automatically updated to reflect the committed changes. Closed by commit rL367134: [Sema] Fix -Wuninitialized for struct assignment from GNU C statement expression (authored by Nathan-Huckleberry, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commi

r367134 - [Sema] Fix -Wuninitialized for struct assignment from GNU C statement expression

Author: nathan-huckleberry Date: Fri Jul 26 10:29:35 2019 New Revision: 367134 URL: http://llvm.org/viewvc/llvm-project?rev=367134&view=rev Log: [Sema] Fix -Wuninitialized for struct assignment from GNU C statement expression Summary: Do not automatically report self references of structs in stat

[PATCH] D64838: [Attr] Support _attribute__ ((fallthrough))

Nathan-Huckleberry added a comment. I agree that parsing according to attribute name/type is not a good solution. It sounds like we have narrowed it down to two choices: Do we want to follow the gcc method of parsing once and falling back if parsing fails? Do we want to parse attributes first an

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

aaron.ballman added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/gen-static-analyzer-docs.py:113 + file_path_help = ("Path to Checkers.td, defaults to ../../../../clang/include/clang/StaticAnalyzer/Checkers/") + parse.add_argument("file", type=str, he

[PATCH] D36767: Implement the standard for timeouts for std::condition_variable

tomcherry abandoned this revision. tomcherry added a comment. Herald added a subscriber: jfb. See https://reviews.llvm.org/D65339 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D36767/new/ https://reviews.llvm.org/D36767 ___ cfe-commits maili

[PATCH] D65302: [clang][docs][release notes] mention asm goto support

hans added a comment. Thanks! Do you want to write something more general for the release notes about the status of Clang and the Linux kernel? Comment at: clang/docs/ReleaseNotes.rst:116 + control flow from inline assembly. The main consumer of this construct is the + Linu

[PATCH] D64932: [Parser] Emit descriptive diagnostic for misplaced pragma

sepavloff added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64932/new/ https://reviews.llvm.org/D64932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D65337: [clangd] Disallow extraction of expression-statements.

sammccall created this revision. sammccall added a reviewer: SureYeaah. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. I split out the "extract parent instead of this" logic from the "this isn't worth extracting" logic (n

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

Nathan-Huckleberry updated this revision to Diff 211958. Nathan-Huckleberry added a comment. - Make filepath optionally user specified Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64454/new/ https://reviews.llvm.org/D64454 Files: clang-tools-e

[PATCH] D59963: [clang-tidy] Add a module for the Linux kernel.

tmroeder marked an inline comment as done. tmroeder added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:77 + + This is important in the Linux kernel because ``ERR_PTR``, ``PTR_ERR``, + ``IS_ERR``, ``IS_ERR_OR_NULL``, ``ERR_CAST``, and ``PTR_ERR_OR_ZERO``

[PATCH] D59963: [clang-tidy] Add a module for the Linux kernel.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:77 + + This is important in the Linux kernel because ``ERR_PTR``, ``PTR_ERR``, + ``IS_ERR``, ``IS_ERR_OR_NULL``, ``ERR_CAST``, and ``PTR_ERR_OR_ZERO`` return tmroeder wrot

[PATCH] D59963: [clang-tidy] Add a module for the Linux kernel.

tmroeder marked an inline comment as done. tmroeder added inline comments. Comment at: clang-tools-extra/clang-tidy/linuxkernel/MustCheckErrsCheck.cpp:12 +#include "clang/ASTMatchers/ASTMatchFinder.h" +#include + nickdesaulniers wrote: > tmroeder wrote: > > lebe

[PATCH] D59963: [clang-tidy] Add a module for the Linux kernel.

tmroeder marked an inline comment as done. tmroeder added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:77 + + This is important in the Linux kernel because ``ERR_PTR``, ``PTR_ERR``, + ``IS_ERR``, ``IS_ERR_OR_NULL``, ``ERR_CAST``, and ``PTR_ERR_OR_ZERO``

[PATCH] D65309: [clang-format] Fix style of css file paths

juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. LGTM after adding a comment to explain Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:234 llvm::sys::path::filename(FilePa

[PATCH] D65239: [analyzer] RangeConstraintManager: Apply constraint ranges of bitwise operations

Charusso marked 3 inline comments as done. Charusso added a comment. In D65239#1599889 , @NoQ wrote: > Aha, great, the overall structure of the code is correct! Thanks! Now it is more formal. The only problem it does not change anything on LLVM reports,

[PATCH] D65239: [analyzer] RangeConstraintManager: Apply constraint ranges of bitwise operations

Charusso updated this revision to Diff 211956. Charusso edited the summary of this revision. Charusso added a comment. - Restrict the generic contradiction-based range evaluation to only affect that left-hand side operands which constraint range are concrete zero. CHANGES SINCE LAST ACTION ht

[PATCH] D65043: [Format] Add C++20 standard to style options

Quuxplusone added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:13815 + verifyFormat("co_yield++ i;"); + verifyFormat("co_yield ++i;", Cpp20); + modocache wrote: > Quuxplusone wrote: > > If you're going to test C++11's behavior here, please

[PATCH] D65286: [OpenCL] Allow OpenCL C style vector initialization in C++

rjmccall added a comment. Okay. It seems reasonable to me to allow OpenCL vector initialization syntax in OpenCL C++, since we're treating OpenCL C++ as an ObjC++-like merge of the language extensions, but we shouldn't go further than that and start changing behavior in the non-OpenCL language

[PATCH] D65139: [clangd] Support extraction of binary "subexpressions" like a + [[b + c]].

This revision was automatically updated to reflect the committed changes. Closed by commit rL367121: [clangd] Support extraction of binary "subexpressions" like a + [[b + c]]. (authored by sammccall, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed p

[clang-tools-extra] r367121 - [clangd] Support extraction of binary "subexpressions" like a + [[b + c]].

Author: sammccall Date: Fri Jul 26 08:29:52 2019 New Revision: 367121 URL: http://llvm.org/viewvc/llvm-project?rev=367121&view=rev Log: [clangd] Support extraction of binary "subexpressions" like a + [[b + c]]. Summary: These aren't formally subexpressions in C++, in this case + is left-associati

[PATCH] D64301: Use `ln -n` to prevent forming a symlink cycle, instead of rm'ing the source

hubert.reinterpretcast added a comment. `ln -n` is not a standard option that is portably supported. I'll be restoring the use of `rm` (with `-f` instead of `-rf`) and the associated comment for removing `%t.fake`. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64

[PATCH] D65106: [OPENMP]Add support for analysis of reduction variables.

This revision was automatically updated to reflect the committed changes. Closed by commit rL367116: [OPENMP]Add support for analysis of reduction variables. (authored by ABataev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES

[PATCH] D65000: [ARM] Set default alignment to 64bits

This revision was automatically updated to reflect the committed changes. Closed by commit rL367119: [ARM] Set default alignment to 64bits (authored by simpal01, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D65149: [Format] Add test demonstrating PR42722

modocache marked an inline comment as done. modocache added a comment. Sure thing! Just to be clear: this test doesn't fail, it passes. My intention was to commit this, then commit a patch that improved the indentation behavior, which would also include a change to the test that demonstrated the

[PATCH] D65043: [Format] Add C++20 standard to style options

modocache marked 2 inline comments as done. modocache added inline comments. Comment at: clang/lib/Format/Format.cpp:2373 LangOpts.CPlusPlus17 = Style.Standard == FormatStyle::LS_Cpp03 ? 0 : 1; - LangOpts.CPlusPlus2a = Style.Standard == FormatStyle::LS_Cpp03 ? 0 : 1; + LangO

r367119 - [ARM] Set default alignment to 64bits

Author: simpal01 Date: Fri Jul 26 08:05:19 2019 New Revision: 367119 URL: http://llvm.org/viewvc/llvm-project?rev=367119&view=rev Log: [ARM] Set default alignment to 64bits The maximum alignment used by ARM arch is 64bits, not 128. This could cause overaligned memory access for 128 bit neon vect

r367116 - [OPENMP]Add support for analysis of reduction variables.

Author: abataev Date: Fri Jul 26 07:50:05 2019 New Revision: 367116 URL: http://llvm.org/viewvc/llvm-project?rev=367116&view=rev Log: [OPENMP]Add support for analysis of reduction variables. Summary: Reduction variables are the variables, for which the private copies must be created in the OpenMP

[PATCH] D65332: [Clangd] Disable ExtractVariable for all types of assignments

This revision was automatically updated to reflect the committed changes. Closed by commit rL367113: [Clangd] Disable ExtractVariable for all types of assignments (authored by SureYeaah, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit

[PATCH] D65320: [clangd] Fix background index not triggering on windows due to case mismatch.

This revision was automatically updated to reflect the committed changes. sammccall marked 2 inline comments as done. Closed by commit rL367112: [clangd] Fix background index not triggering on windows due to case mismatch. (authored by sammccall, committed by ). Herald added a project: LLVM. Heral

[clang-tools-extra] r367113 - [Clangd] Disable ExtractVariable for all types of assignments

Author: sureyeaah Date: Fri Jul 26 07:08:27 2019 New Revision: 367113 URL: http://llvm.org/viewvc/llvm-project?rev=367113&view=rev Log: [Clangd] Disable ExtractVariable for all types of assignments Reviewers: sammccall, kadircet Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, cfe-commits

[clang-tools-extra] r367112 - [clangd] Fix background index not triggering on windows due to case mismatch.

Author: sammccall Date: Fri Jul 26 07:07:11 2019 New Revision: 367112 URL: http://llvm.org/viewvc/llvm-project?rev=367112&view=rev Log: [clangd] Fix background index not triggering on windows due to case mismatch. Summary: This isn't a general fix to all paths where we assume case-sensitivity, it

[PATCH] D64736: [clang-tidy] New bugprone-infinite-loop check for detecting obvious infinite loops

baloghadamsoftware marked 15 inline comments as done. baloghadamsoftware added a comment. Thank you for the very throughout review. I updated my patch according to your comments and tried to answer your concerns. Comment at: test/clang-tidy/bugprone-infinite-loop.cpp:156 + }

[PATCH] D64736: [clang-tidy] New bugprone-infinite-loop check for detecting obvious infinite loops

baloghadamsoftware updated this revision to Diff 211933. baloghadamsoftware marked 3 inline comments as done. baloghadamsoftware added a comment. Updated according to the comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64736/new/ https://reviews.llvm.org/D64736 Files: clang-t

[PATCH] D63276: [AST] Add FunctionDecl::getParametersSourceRange()

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Decl.h:1928 + /// macro. Otherwise, it returns the location of the end of the ellipsis. + SourceRange getEllipsisSourceRange() const { +const auto *FPT = getType()->getAs(); Why a sour

[PATCH] D65320: [clangd] Fix background index not triggering on windows due to case mismatch.

sammccall marked 4 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp:168 std::lock_guard Lock(Mutex); +CachedCDB *Entry; if (CompileCommandsDir) { hokein wrote: > nit: set de

[PATCH] D65333: [clangd] Refactor computation of extracted expr in ExtractVariable tweak. NFC

sammccall created this revision. sammccall added a reviewer: SureYeaah. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This takes this logic out of the Tweak class, and simplifies the signature of the function where the m

[PATCH] D65320: [clangd] Fix background index not triggering on windows due to case mismatch.

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp:168 std::lock_guard Lock(Mutex); +CachedCDB *Entry; if (CompileCommandsDir) { ---

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1948 +def RequiresDesignator : InheritableAttr { + let Spellings = [Clang<"requires_designator">, GCC<"designated_init">]; + let Subjects = SubjectList<[Record]>; Why does this h

[PATCH] D65332: [Clangd] Disable ExtractVariable for all types of assignments

SureYeaah created this revision. SureYeaah added reviewers: sammccall, kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D65332 Files: clang-tools-extra/clan

[PATCH] D65320: [clangd] Fix background index not triggering on windows due to case mismatch.

sammccall updated this revision to Diff 211921. sammccall added a comment. Fix bug where CDB wasn't being marked as broadcast due to case differences. Having getCDBLocked() return CachedCDB seems much cleaner to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D65234: [CodeGen]: don't treat structures returned in registers as memory inputs

glider updated this revision to Diff 211920. glider added a comment. Make big_struct() test triple-specific Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65234/new/ https://reviews.llvm.org/D65234 Files: clang/lib/CodeGen/CGStmt.cpp clang/test

r367103 - Make the CXXABIs respect the target's default calling convention.

Author: erichkeane Date: Fri Jul 26 05:36:12 2019 New Revision: 367103 URL: http://llvm.org/viewvc/llvm-project?rev=367103&view=rev Log: Make the CXXABIs respect the target's default calling convention. SPIR targets need to have all functions be SPIR calling convention, however the CXXABIs were j

[PATCH] D65234: [CodeGen]: don't treat structures returned in registers as memory inputs

glider updated this revision to Diff 211919. glider marked 2 inline comments as done. glider added a comment. Fixed comments from Eli and Nick, added tests for unusual struct sizes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65234/new/ https://re

[PATCH] D65294: Make the CXXABIs respect the target's default calling convention.

erichkeane added a comment. Committed, 9.0 release request here: https://bugs.llvm.org/show_bug.cgi?id=42774 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65294/new/ https://reviews.llvm.org/D65294 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D65234: [CodeGen]: don't treat structures returned in registers as memory inputs

glider marked 2 inline comments as done. glider added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:1989 std::vector Args; + std::vector ResultTypeRequiresCast; nickdesaulniers wrote: > Are we able to use something other than `std::vector` here

[PATCH] D65286: [OpenCL] Allow OpenCL C style vector initialization in C++

Anastasia added a comment. In D65286#1601404 , @rjmccall wrote: > Wait, plain C++? Do we currently allow this syntax outside of OpenCL? Ok I looked into this again and it seems apparently vector initialization and literals in C++ have different syntax.

[PATCH] D65294: Make the CXXABIs respect the target's default calling convention.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! This should probably go to release 9.0? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65294/new/ https://reviews.llvm.org/D65294 __

[PATCH] D65320: [clangd] Fix background index not triggering on windows due to case mismatch.

sammccall planned changes to this revision. sammccall marked an inline comment as done. sammccall added a comment. Sorry, this has a hideous bug that rebroadcasts CDBs over and over. Working on a fix... Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp:195

[PATCH] D65139: [clangd] Support extraction of binary "subexpressions" like a + [[b + c]].

sammccall updated this revision to Diff 211905. sammccall added a comment. Improve testcase, expand comment to clarify RHS non-traversal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65139/new/ https://reviews.llvm.org/D65139 Files: clang-tools

[PATCH] D65139: [clangd] Support extraction of binary "subexpressions" like a + [[b + c]].

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:305 + const SelectionTree::Node *Start = Op.SelectedOperands.front(); // LHS + const SelectionTree::Node *End = Op.SelectedOpera

[PATCH] D65139: [clangd] Support extraction of binary "subexpressions" like a + [[b + c]].

SureYeaah added inline comments. Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:448 + + // Binary subexpressions + {R"cpp(void f() { sammccall wrote: > SureYeaah wrote: > > Can we have some tests with macros as well? > Added a sim

[PATCH] D65139: [clangd] Support extraction of binary "subexpressions" like a + [[b + c]].

SureYeaah added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:50 // Generate Replacement for declaring the selected Expr as a new variable - tooling::Replacement insertDeclaration(llvm::StringRef VarName) const; + tooling::Replacem

[PATCH] D64475: [clangd] Duplicate lines of semantic highlightings sent removed.

jvikstrom added a comment. In D64475#1593481 , @ilya-biryukov wrote: > The fix for a race condition on remove has landed in rL366577 > , this revision would need a small update > after it. Fixed to work with that pat

[PATCH] D64475: [clangd] Duplicate lines of semantic highlightings sent removed.

jvikstrom updated this revision to Diff 211890. jvikstrom marked 2 inline comments as done. jvikstrom added a comment. Made tests more readable. Updated to work with rL366577 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D65320: [clangd] Fix background index not triggering on windows due to case mismatch.

sammccall created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This isn't a general fix to all paths where we assume case-sensitivity, it's a minimally-invasive fix targeting the llvm 9 branch. Reposito

<    1   2