[PATCH] D65545: Handle some fs::remove failures

jfb marked 2 inline comments as done. jfb added inline comments. Comment at: clang/lib/Frontend/PrecompiledPreamble.cpp:107-111 TemporaryFiles::~TemporaryFiles() { llvm::MutexGuard Guard(Mutex); for (const auto : Files) -llvm::sys::fs::remove(File.getKey()); +if

[PATCH] D65699: [Driver] Prioritize SYSROOT/usr/include over RESOURCE_DIR/include on linux-musl

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65699/new/ https://reviews.llvm.org/D65699 ___ cfe-commits

[PATCH] D65776: [Clang] Pragma vectorize_predicate implies vectorize

SjoerdMeijer added a comment. Thanks for pointing this all out! I am not entirely sure yet what to think about all this as I am new to the loop pragma business, but I think it looks inconsistent to me! I think I find `allowReordering()` a little bit ugly, because it is also checking

[PATCH] D64089: [Driver] Introduce -stdlib++-isystem

phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64089/new/ https://reviews.llvm.org/D64089 ___ cfe-commits mailing list

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL367979: [clang][DirectoryWatcher] Adding llvm::Expected error handling to create. (authored by zer0, committed by ).

r367979 - [clang][DirectoryWatcher] Adding llvm::Expected error handling to create.

Author: zer0 Date: Mon Aug 5 22:12:23 2019 New Revision: 367979 URL: http://llvm.org/viewvc/llvm-project?rev=367979=rev Log: [clang][DirectoryWatcher] Adding llvm::Expected error handling to create. Prior to this patch Unix style errno error reporting from the inotify layer was used by

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

plotfi updated this revision to Diff 213520. plotfi added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. add another assert Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65704/new/ https://reviews.llvm.org/D65704

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

compnerd added inline comments. Comment at: clang/lib/DirectoryWatcher/mac/DirectoryWatcher-mac.cpp:218 +return llvm::make_error( +std::string("Path.empty() error: ") + strerror(errno), +llvm::inconvertibleErrorCode()); compnerd wrote: >

r367973 - Builtins: Start adding half versions of math builtins

Author: arsenm Date: Mon Aug 5 20:28:37 2019 New Revision: 367973 URL: http://llvm.org/viewvc/llvm-project?rev=367973=rev Log: Builtins: Start adding half versions of math builtins The implementation of the OpenCL builtin currently library uses 2 different hacks to get to the corresponding IR

[PATCH] D65597: WIP: Builtins: Start adding half versions of math builtins

arsenm closed this revision. arsenm added a comment. r367973 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65597/new/ https://reviews.llvm.org/D65597 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D65545: Handle some fs::remove failures

bruno added a comment. Thanks for working on this JF! Comment at: clang/lib/Frontend/PrecompiledPreamble.cpp:107-111 TemporaryFiles::~TemporaryFiles() { llvm::MutexGuard Guard(Mutex); for (const auto : Files) -llvm::sys::fs::remove(File.getKey()); +if

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

plotfi updated this revision to Diff 213515. plotfi added a comment. Improve comments, change Path.empty() errors for asserts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65704/new/ https://reviews.llvm.org/D65704 Files:

[PATCH] D65690: [clang-doc] Add index in each info html file

DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/clang-doc/Generators.cpp:79 + +bool Generator::createResources(ClangDocContext ) { + std::error_code OK; juliehockett wrote: > Why is this implementation in the generic Generator? It's fairly

[PATCH] D65030: [clang-doc] Add second index for sections within info's content

DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/unittests/clang-doc/HTMLGeneratorTest.cpp:47-52 + + Namespaces + Records + Functions + OneFunction + juliehockett wrote: > DiegoAstiazaran wrote: > > juliehockett wrote: > > > Formatting is

[PATCH] D64089: [Driver] Introduce -stdlib++-isystem

smeenai added a reviewer: rnk. smeenai added a subscriber: rnk. smeenai added a comment. Adding @rnk as someone familiar with the driver/frontend :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64089/new/ https://reviews.llvm.org/D64089

[PATCH] D65690: [clang-doc] Add index in each info html file

DiegoAstiazaran updated this revision to Diff 213513. DiegoAstiazaran marked 3 inline comments as done. DiegoAstiazaran added a comment. Moved serialization of Index to HTML generator. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65690/new/ https://reviews.llvm.org/D65690 Files:

[PATCH] D63907: [clang-scan-deps] Implementation of dependency scanner over minimized sources

arphaman added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:156 +/// this subclass. +class MinimizedVFSFile final : public llvm::vfs::File { +public: aganea wrote: > This makes only a short-lived objects, is

[PATCH] D63907: [clang-scan-deps] Implementation of dependency scanner over minimized sources

arphaman updated this revision to Diff 213511. arphaman marked 3 inline comments as done. arphaman added a comment. Fix comment typo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63907/new/ https://reviews.llvm.org/D63907 Files: clang/include/clang/Basic/FileManager.h

[PATCH] D65030: [clang-doc] Add second index for sections within info's content

DiegoAstiazaran updated this revision to Diff 213509. DiegoAstiazaran marked 2 inline comments as done. DiegoAstiazaran edited the summary of this revision. DiegoAstiazaran added a parent revision: D65690: [clang-doc] Add index in each info html file. DiegoAstiazaran added a comment. Changed

[PATCH] D65708: [NFC][DirectoryWatchedTests] Unlocking mutexes before signaling condition variable.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL367968: [NFC][DirectoryWatchedTests] Unlocks mutexes before signaling condition variable (authored by zer0, committed by

r367968 - [NFC][DirectoryWatchedTests] Unlocks mutexes before signaling condition variable

Author: zer0 Date: Mon Aug 5 18:26:46 2019 New Revision: 367968 URL: http://llvm.org/viewvc/llvm-project?rev=367968=rev Log: [NFC][DirectoryWatchedTests] Unlocks mutexes before signaling condition variable This should not affect actual behavior, but should pessimize the threading less by

Buildbot numbers for the week of 07/28/2019 - 08/03/2019

Hello everyone, Below are some buildbot numbers for the last week of 07/28/2019 - 08/03/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from

Buildbot numbers for the week of 07/21/2019 - 07/27/2019

Hello everyone, Below are some buildbot numbers for the week of 07/21/2019 - 07/27/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed

[PATCH] D65003: [clang-doc] Add index in each info html file

DiegoAstiazaran abandoned this revision. DiegoAstiazaran added a comment. D65690 replaces this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65003/new/ https://reviews.llvm.org/D65003 ___

[PATCH] D65410: [PassManager] First Pass implementation at -O1 pass pipeline

chandlerc added a comment. One high level point that is at least worth clarifying, and maybe others will want to suggest a different approach: The overall approach here is to have as small of a difference between the O1 and O2

[PATCH] D65708: [NFC][DirectoryWatchedTests] Unlocking mutexes before signaling condition variable.

jkorous added a comment. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65708/new/ https://reviews.llvm.org/D65708 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

plotfi marked 3 inline comments as done. plotfi added inline comments. Comment at: clang/include/clang/DirectoryWatcher/DirectoryWatcher.h:102 /// Returns nullptr if \param Path doesn't exist or isn't a directory. /// Returns nullptr if OS kernel API told us we can't

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

jkorous added a comment. Please just update the comment, otherwise LGTM. Comment at: clang/unittests/DirectoryWatcher/DirectoryWatcherTest.cpp:283 /*waitForInitialSync=*/true); + if (!DW) return; jkorous wrote: > IIUC this is silently dropping

[PATCH] D65622: [clang-doc] Update documentation

juliehockett added a comment. Sorry for the delayed review, but a few things I caught :) Also, please make sure to update the the release notes/flag documentation for the patches you have in progress that add features or flags. Comment at:

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

jkorous added a comment. Thanks for the patch! Comment at: clang/include/clang/DirectoryWatcher/DirectoryWatcher.h:102 /// Returns nullptr if \param Path doesn't exist or isn't a directory. /// Returns nullptr if OS kernel API told us we can't start watching. In such

[clang-tools-extra] r367958 - [clang-doc] Fix link generation

Author: diegoastiazaran Date: Mon Aug 5 17:11:34 2019 New Revision: 367958 URL: http://llvm.org/viewvc/llvm-project?rev=367958=rev Log: [clang-doc] Fix link generation Before making a link to a reference it is required to check that the reference has a path (eg. primitives won't have paths).

[PATCH] D64958: [clang-doc] Fix link generation

This revision was automatically updated to reflect the committed changes. Closed by commit rL367958: [clang-doc] Fix link generation (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D65690: [clang-doc] Add index in each info html file

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/Generators.cpp:79 + +bool Generator::createResources(ClangDocContext ) { + std::error_code OK; Why is this implementation in the generic Generator? It's fairly HTML-specific -- neither

[PATCH] D64958: [clang-doc] Fix link generation

DiegoAstiazaran updated this revision to Diff 213498. DiegoAstiazaran marked 2 inline comments as done. DiegoAstiazaran added a comment. Fix comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64958/new/ https://reviews.llvm.org/D64958 Files:

[PATCH] D65545: Handle some fs::remove failures

jfb updated this revision to Diff 213497. jfb marked 8 inline comments as done. jfb added a comment. - Return llvm::Error from ASTUnit::Save - Update per comments. - Address Volodymyr's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D65545: Handle some fs::remove failures

jfb added inline comments. Comment at: clang/lib/Frontend/CompilerInstance.cpp:1444-1445 // Remove the file. - llvm::sys::fs::remove(File->path()); + if ((EC = llvm::sys::fs::remove(File->path( +break; vsapsai wrote: > jfb wrote: >

[PATCH] D65030: [clang-doc] Add second index for sections within info's content

juliehockett added inline comments. Comment at: clang-tools-extra/unittests/clang-doc/HTMLGeneratorTest.cpp:47-52 + + Namespaces + Records + Functions + OneFunction + DiegoAstiazaran wrote: > juliehockett wrote: > > Formatting is a bit weird for sublists >

[PATCH] D64958: [clang-doc] Fix link generation

juliehockett accepted this revision. juliehockett added a comment. LGTM with a comment correction Comment at: clang-tools-extra/clang-doc/Representation.h:117 Reference(llvm::StringRef Name) : Name(Name) {} - Reference(llvm::StringRef Name, StringRef Path) : Name(Name),

[PATCH] D65483: [clang-doc] Add link to source code in file definitions

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:377-378 + "href", (FileURL + "#" + std::to_string(L.LineNumber)).str()); + Node->Children.emplace_back(std::move(LocNumberNode)); +

[PATCH] D65628: [clang-doc] Parallelize reducing phase

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp:72 +static llvm::cl::opt ThreadCount( +"thread-count", Can we use the pre-existing concurrency flag instead

[PATCH] D63889: Check possible warnings on global initializers for reachability

Nathan-Huckleberry marked an inline comment as done. Nathan-Huckleberry added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:352 SetParamDefaultArgument(Param, DefaultArg, EqualLoc); + CurContext->removeDecl(Param); + CurContext = Cur; rsmith

[PATCH] D65770: hwasan: Instrument globals.

pcc added a comment. The AOSP side of this is https://android-review.googlesource.com/c/platform/bionic/+/1096613 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65770/new/ https://reviews.llvm.org/D65770

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

ABataev added inline comments. Comment at: clang/include/clang/Driver/Action.h:74 OffloadUnbundlingJobClass, +OffloadWrapperJobClass, Do we really need this new kind of job here, can we use bundler instead? Comment at:

r367947 - [Sema] attempt to appease buildbots after r367940

Author: gbiv Date: Mon Aug 5 16:19:15 2019 New Revision: 367947 URL: http://llvm.org/viewvc/llvm-project?rev=367947=rev Log: [Sema] attempt to appease buildbots after r367940 A buildbot got angry about this new test, with error messages like: warn-nullchar-nullptr.c Line 16: use of undeclared

[PATCH] D65130: [clang][OpenMP] Add clang-offload-wrapper tool

sdmitriev updated this revision to Diff 213481. sdmitriev added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65130/new/ https://reviews.llvm.org/D65130 Files: clang/test/Driver/clang-offload-wrapper.ll clang/tools/CMakeLists.txt

[PATCH] D65300: [clang] [CodeGen] clang-misexpect prototype for compiler warnings

xbolva00 added a comment. In D65300#1608147 , @lebedev.ri wrote: > Thank you for working on this! > > I'm guessing this doesn't have a `-Werror=` mode? > > I still believe this should output a remark. > It will still be visible in the compiler console

[PATCH] D65770: hwasan: Instrument globals.

pcc updated this revision to Diff 213477. pcc added a comment. - Increment num_descriptions_printed in the right place Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65770/new/ https://reviews.llvm.org/D65770 Files:

[PATCH] D65776: [Clang] Pragma vectorize_predicate implies vectorize

Meinersbur added a comment. Mmmh, I would have expected this to work the same way as `vectorize_width`. According to the docs: > The following example implicitly enables vectorization and interleaving by > specifying a vector width and interleaving count: > `#pragma clang loop

r367940 - [Sema] Add -Wpointer-compare

Author: gbiv Date: Mon Aug 5 15:15:40 2019 New Revision: 367940 URL: http://llvm.org/viewvc/llvm-project?rev=367940=rev Log: [Sema] Add -Wpointer-compare This patch adds a warning that diagnoses comparisons of pointers to '\0'. This is often indicative of a bug (e.g. the user might've forgotten

[PATCH] D60943: Delay diagnosing asm constraints that require immediates until after inlining

void added a comment. In D60943#1612083 , @joerg wrote: > The combination of D60942 , D06943 and > D65280 solves the problems for me on all > targets I have. Excellent! I submitted

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D65699: [Driver] Prioritize SYSROOT/usr/include over RESOURCE_DIR/include on linux-musl

dalias added a comment. It's not just infeasible; it's impossible by design. musl's headers do not support any contract with compiler-provided versions of the std headers, and won't. Attempting to use them in place of the libc ones is unsupported usage and will periodically break.

[PATCH] D65770: hwasan: Instrument globals.

pcc updated this revision to Diff 213472. pcc added a comment. - Switch to an enum Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65770/new/ https://reviews.llvm.org/D65770 Files: clang/lib/Driver/SanitizerArgs.cpp

[PATCH] D65180: [analyzer] VirtualCallChecker: Improve warning messages.

a_sidorin accepted this revision. a_sidorin added a comment. Hi Artem, The patch looks good to me. I prefer a fully qualified name, however, but it is a matter of taste. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65180/new/ https://reviews.llvm.org/D65180

[PATCH] D65770: hwasan: Instrument globals.

pcc marked 3 inline comments as done. pcc added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan.cpp:221 + s32 gv_relptr; + u32 info; +}; vitalybuka wrote: > Can this be just following? > u32 size:24; > u8 tag; It could, but since these structs

[PATCH] D65776: [Clang] Pragma vectorize_predicate implies vectorize

SjoerdMeijer added a comment. Forgot that this requires a doc change too. Will add that once we're happy with the proposed behaviour. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65776/new/ https://reviews.llvm.org/D65776 ___ cfe-commits

[PATCH] D65770: hwasan: Instrument globals.

vitalybuka added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:1203 + Constant *Initializer = GV->getInitializer(); + uint64_t SizeInBytes = + M.getDataLayout().getTypeAllocSize(Initializer->getType()); what is

[PATCH] D65776: [Clang] Pragma vectorize_predicate implies vectorize

SjoerdMeijer created this revision. SjoerdMeijer added reviewers: Meinersbur, hsaito, fhahn. New pragma "vectorize_predicate(enable)" now implies "vectorize(enable)", and it is ignored when vectorization is disabled with e.g. "vectorize(disable) vectorize_predicate(enable)".

[PATCH] D65770: hwasan: Instrument globals.

vitalybuka added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan.cpp:221 + s32 gv_relptr; + u32 info; +}; Can this be just following? u32 size:24; u8 tag; Comment at: compiler-rt/lib/hwasan/hwasan.cpp:236 -using namespace

[PATCH] D65699: [Driver] Prioritize SYSROOT/usr/include over RESOURCE_DIR/include on linux-musl

phosek added a comment. This looks reasonable to me; I'd prefer to clean up Clang's internal headers to be compatible with both FreeBSD's and musl's standard headers as suggested in http://lists.llvm.org/pipermail/llvm-dev/2019-August/134353.html, but I'm not sure how feasible or doable that

[PATCH] D62445: [test] Fix plugin tests

hintonda added a comment. In D62445#1613268 , @NoQ wrote: > Ugh, there seems to be one more forgotten buildbot with plugins problems: > http://green.lab.llvm.org/green/job/clang-stage2-cmake-RgSan/6406/consoleText > It got suddenly fixed in >

[PATCH] D65234: [CodeGen]: don't treat structures returned in registers as memory inputs

efriedma added a comment. For the "=x" thing I was talking about, try the following testcase: void a() { struct S { unsigned x[4]; } z; asm volatile("%0":"=x"(z)); } void a2() { struct S { unsigned x[8]; } z; asm volatile("%0":"=x"(z)); } clang trunk gives "error: couldn't allocate output

[PATCH] D65753: Builtins: Add some v2f16 variants

rjmccall added a comment. Hmm, sorry, that's a C++ spec, and it looks like the (abandoned) C attempt at data parallelism (http://www.open-std.org/jtc1/sc22/wg14/www/docs/n2081.htm) doesn't introduce vector types. Talking about it internally, I think there are two reasonable approaches: - Add

Re: r367889 - [docs] document -Weveything more betterer

Ugh this is silly… fixed again. > On Aug 5, 2019, at 12:55 PM, Nico Weber wrote: > > Still sad, now with a different message: > http://lab.llvm.org:8011/builders/clang-sphinx-docs/builds/45220 > > >

r367918 - [docs] don't use :option: for Wall Wextra

Author: jfb Date: Mon Aug 5 12:59:07 2019 New Revision: 367918 URL: http://llvm.org/viewvc/llvm-project?rev=367918=rev Log: [docs] don't use :option: for Wall Wextra The bots are sad that they're not documented. Modified: cfe/trunk/docs/UsersManual.rst Modified:

Re: r367889 - [docs] document -Weveything more betterer

Still sad, now with a different message: http://lab.llvm.org:8011/builders/clang-sphinx-docs/builds/45220 /home/buildbot/llvm-build-dir/clang-sphinx-docs/llvm/src/tools/clang/docs/UsersManual.rst:1002: WARNING: unknown option: -Wall On Mon, Aug 5, 2019 at 3:46 PM JF Bastien wrote: > Fixed. I

[PATCH] D65753: Builtins: Add some v2f16 variants

rjmccall added a comment. You might want to look into ISO/IEC TS 19570 - 2018 to see what they're thinking. If it looks like there's a potential conflict, then maybe these should have an OpenCL-specific prefix on them. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65753/new/

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

dgoldman updated this revision to Diff 213438. dgoldman added a comment. - remove extra newline Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62648/new/ https://reviews.llvm.org/D62648 Files: include/clang/Sema/Sema.h lib/Sema/SemaExprCXX.cpp

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

dgoldman updated this revision to Diff 213437. dgoldman added a comment. Fix test failure via `TransformTypos` - Add a new property on Sema to track newly created Typos and use this from within TransformTypos in order to delete any Typos that are unreachable (tested in

[PATCH] D65753: Builtins: Add some v2f16 variants

rjmccall added a comment. Hmm. I think there are two reasonable concerns here, both arising from the fact that these names occupy (the builtin namespace parallel to) a namespace that the committee might want to occupy in the future: - Is a `v2fN` suffix sufficiently likely to avoid

Re: r367889 - [docs] document -Weveything more betterer

Fixed. I guess we should document those... > On Aug 5, 2019, at 10:51 AM, Nico Weber wrote: > > This breaks the sphinx bot: > > http://lab.llvm.org:8011/builders/clang-sphinx-docs/builds/45204/steps/docs-clang-html/logs/stdio > >

r367914 - [docs] don't use :option: for C++ compat

Author: jfb Date: Mon Aug 5 12:45:23 2019 New Revision: 367914 URL: http://llvm.org/viewvc/llvm-project?rev=367914=rev Log: [docs] don't use :option: for C++ compat The bots are sad that they're not documented. Modified: cfe/trunk/docs/UsersManual.rst Modified:

[PATCH] D65770: hwasan: Instrument globals.

pcc created this revision. pcc added reviewers: hctim, vitalybuka. Herald added subscribers: Sanitizers, cfe-commits, hiraditya, kubamracek, srhines. Herald added projects: clang, Sanitizers, LLVM. Globals are instrumented by adding a pointer tag to their symbol values and emitting metadata into

[PATCH] D64838: [Attr] Support _attribute__ ((fallthrough))

Nathan-Huckleberry updated this revision to Diff 213435. Nathan-Huckleberry added a comment. - Remove 'maybe', remove boolean and fix other call to ParseSimpleDeclaration Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64838/new/

Re: r367829 - [CrossTU][NFCI] Refactor loadExternalAST function

There was yet another uninit read: Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. FAIL: Clang-Unit :: CrossTU/./CrossTUTests/CrossTranslationUnit.RespectsLoadThreshold (13891 of 15323) TEST 'Clang-Unit ::

r367912 - Fix another uninit read found by msan after r367829

Author: nico Date: Mon Aug 5 12:35:59 2019 New Revision: 367912 URL: http://llvm.org/viewvc/llvm-project?rev=367912=rev Log: Fix another uninit read found by msan after r367829 Modified: cfe/trunk/include/clang/CrossTU/CrossTranslationUnit.h Modified:

[PATCH] D65628: [clang-doc] Parallelize reducing phase

DiegoAstiazaran updated this revision to Diff 213425. DiegoAstiazaran marked 2 inline comments as done. DiegoAstiazaran added a comment. Herald added a subscriber: jfb. Fix atomicity issues. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65628/new/ https://reviews.llvm.org/D65628

[PATCH] D65597: WIP: Builtins: Start adding half versions of math builtins

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65597/new/ https://reviews.llvm.org/D65597 ___ cfe-commits mailing list

r367906 - [DirectoryWatcher][linux] Fix build for older kernels

Author: jkorous Date: Mon Aug 5 11:44:07 2019 New Revision: 367906 URL: http://llvm.org/viewvc/llvm-project?rev=367906=rev Log: [DirectoryWatcher][linux] Fix build for older kernels Apparently kernel support for IN_EXCL_UNLINK in inotify_add_watch() doesn't imply it's defined in sys/inotify.h.

r367905 - [OpenMP 5.0] Codegen support for user-defined mappers.

Author: meinersbur Date: Mon Aug 5 11:43:21 2019 New Revision: 367905 URL: http://llvm.org/viewvc/llvm-project?rev=367905=rev Log: [OpenMP 5.0] Codegen support for user-defined mappers. This patch implements the code generation for OpenMP 5.0 declare mapper (user-defined mapper) constructs. For

[PATCH] D64838: [Attr] Support _attribute__ ((fallthrough))

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:1767 } return ParseSimpleDeclaration(Context, DeclEnd, attrs, true); Should this also be passed `DeclSpecStart`?

[PATCH] D65761: Add Windows Control Flow Guard checks (/guard:cf).

ajpaverd created this revision. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, steven_wu, hiraditya, kristof.beyls, javed.absar, mgorny, mehdi_amini. Herald added projects: clang, LLVM. A new module pass (Transforms/CFGuard/CFGuard.cpp) inserts CFGuard checks on indirect

[PATCH] D64838: [Attr] Support _attribute__ ((fallthrough))

xbolva00 added a comment. +1, looks good Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64838/new/ https://reviews.llvm.org/D64838 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64838: [Attr] Support _attribute__ ((fallthrough))

Nathan-Huckleberry updated this revision to Diff 213407. Nathan-Huckleberry added a comment. - Remove changes from accidentally formatted files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64838/new/ https://reviews.llvm.org/D64838 Files:

[PATCH] D64838: [Attr] Support _attribute__ ((fallthrough))

Nathan-Huckleberry updated this revision to Diff 213406. Nathan-Huckleberry added a comment. - Allow decl-specifier source location to propagate to decl parsing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64838/new/

Re: r367889 - [docs] document -Weveything more betterer

This breaks the sphinx bot: http://lab.llvm.org:8011/builders/clang-sphinx-docs/builds/45204/steps/docs-clang-html/logs/stdio Warning, treated as error: /home/buildbot/llvm-build-dir/clang-sphinx-docs/llvm/src/tools/clang/docs/UsersManual.rst:995: WARNING: unknown option: -Wno-c++98-compat On

[PATCH] D62829: [clang-tidy] Check for dynamically initialized statics in headers.

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/DynamicStaticInitializersCheck.cpp:47 +void DynamicStaticInitializersCheck::registerMatchers(MatchFinder *Finder) { + if (!getLangOpts().CPlusPlus || getLangOpts().ThreadsafeStatics) +

Re: [libclc] r367800 - Rename F_{None, Text, Append} to OF_{None, Text, Append}. NFC

I've reverted this change. It breaks libclc build using older LLVM version (which is still supported) and it was committed without review on phabricator or libclc mailing list. Please don't do that. Jan On Mon, Aug 5, 2019 at 1:43 AM Fangrui Song via cfe-commits < cfe-commits@lists.llvm.org>

[libclc] r367893 - Revert "Rename F_{None, Text, Append} to OF_{None, Text, Append}. NFC"

Author: jvesely Date: Mon Aug 5 10:23:23 2019 New Revision: 367893 URL: http://llvm.org/viewvc/llvm-project?rev=367893=rev Log: Revert "Rename F_{None,Text,Append} to OF_{None,Text,Append}. NFC" This reverts commit 58c814614d2ac69bcf79b09543505fac80ada4e6. Fixes build breakage using LLVM<7.

r367892 - [AST] Fix buildbot failure because of raw string inside macro from 367839.

Author: jvikstrom Date: Mon Aug 5 10:14:46 2019 New Revision: 367892 URL: http://llvm.org/viewvc/llvm-project?rev=367892=rev Log: [AST] Fix buildbot failure because of raw string inside macro from 367839. Modified:

[PATCH] D62829: [clang-tidy] Check for dynamically initialized statics in headers.

czhang marked an inline comment as done. czhang added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/DynamicStaticInitializersCheck.cpp:47 +void DynamicStaticInitializersCheck::registerMatchers(MatchFinder *Finder) { + if (!getLangOpts().CPlusPlus ||

[PATCH] D65706: [docs] Better documentation for -Weverything

xbolva00 added a comment. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65706/new/ https://reviews.llvm.org/D65706 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r367889 - [docs] document -Weveything more betterer

Author: jfb Date: Mon Aug 5 09:53:45 2019 New Revision: 367889 URL: http://llvm.org/viewvc/llvm-project?rev=367889=rev Log: [docs] document -Weveything more betterer Reviewers: aaron.ballman Subscribers: jkorous, dexonsmith, cfe-commits Tags: #clang Differential Revision:

[PATCH] D65706: [docs] Better documentation for -Weverything

This revision was automatically updated to reflect the committed changes. Closed by commit rL367889: [docs] document -Weveything more betterer (authored by jfb, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D65706: [docs] Better documentation for -Weverything

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/docs/UsersManual.rst:999-1000 +diagnostics contradict each other, users of :option:`-Weverything` therefore +often disable many

[PATCH] D65510: [clangd] Fix implicit template instatiations appearing as topLevelDecls.

jvikstrom updated this revision to Diff 213388. jvikstrom marked an inline comment as done. jvikstrom added a comment. Move isImplicitTemplateInstantiation and isExplicitTemplateSpecialization, also share implementation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D64696: Adds a warning when an inline Doxygen comment has no argument

Mordante added a comment. I think it should warn; according to the documentation [1] `\c` expects a word. Testing with Doxygen indeed gives a warning. Can you post the real comment where this occurs? [1] http://www.doxygen.nl/manual/commands.html#cmdc Repository: rL LLVM CHANGES SINCE

[PATCH] D62829: [clang-tidy] Check for dynamically initialized statics in headers.

lebedev.ri added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/DynamicStaticInitializersCheck.cpp:47 +void DynamicStaticInitializersCheck::registerMatchers(MatchFinder *Finder) { + if (!getLangOpts().CPlusPlus || getLangOpts().ThreadsafeStatics) +

[PATCH] D62829: [clang-tidy] Check for dynamically initialized statics in headers.

czhang marked an inline comment as done. czhang added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/DynamicStaticInitializersCheck.cpp:47 +void DynamicStaticInitializersCheck::registerMatchers(MatchFinder *Finder) { + if (!getLangOpts().CPlusPlus ||

[PATCH] D65706: [docs] Better documentation for -Weverything

jfb marked an inline comment as done. jfb added inline comments. Comment at: clang/docs/UsersManual.rst:999-1000 +diagnostics contradict each other, users of :option:`-Weverything` therefore +often disable many diagnostics such as :option:`-Wno-c++98-compat`

  1   2   >