[PATCH] D66384: [clang-format] Fix a bug that joins template closer and =

owenpan created this revision. owenpan added reviewers: Quuxplusone, MyDeveloperDay, sammccall, klimek, djasper. Herald added a project: clang. Herald added a subscriber: cfe-commits. Also fixes the documentation for `SpaceBeforeAssignmentOperators`. See the discussion here

[PATCH] D63852: [Clang] Move assembler into a separate file

aykevl added a comment. *friendly ping* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63852/new/ https://reviews.llvm.org/D63852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D66333: [analyzer] NonNullParamChecker and CStringChecker parameter number in checker message

bruntib marked 3 inline comments as done. bruntib added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp:202 + SVal l, + unsigned idx = -1u) const; ProgramStateRef

[PATCH] D66333: [analyzer] NonNullParamChecker and CStringChecker parameter number in checker message

bruntib updated this revision to Diff 215754. bruntib added a comment. The checker message has been changed according to the suggestion. The last parameter of checkNonNull() doesn't require a default or optional value, so it has been fixed. The parameter has been renamed from Idx to IdxOfArg.

[PATCH] D47419: [SemaDeclCXX] Allow inheriting constructor declaration that specify a cv-qualified type

This revision was automatically updated to reflect the committed changes. Closed by commit rL369196: [SemaDeclCXX] Allow inheriting constructor declaration to specify a cv… (authored by cpplearner, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

r369196 - [SemaDeclCXX] Allow inheriting constructor declaration to specify a cv-qualified type

Author: cpplearner Date: Sat Aug 17 13:57:52 2019 New Revision: 369196 URL: http://llvm.org/viewvc/llvm-project?rev=369196=rev Log: [SemaDeclCXX] Allow inheriting constructor declaration to specify a cv-qualified type Differential Revision: https://reviews.llvm.org/D47419 Modified:

[PATCH] D66067: Push lambda scope earlier when transforming lambda expression

Mordante added inline comments. Comment at: clang/test/SemaTemplate/default-arguments-cxx0x.cpp:1 -// RUN: %clang_cc1 -fsyntax-only -std=c++11 -verify %s +// RUN: %clang_cc1 -fsyntax-only -std=c++14 -verify %s // expected-no-diagnostics Wouldn't it be better to

[PATCH] D66381: [analyzer] Enable control dependency condition tracking by default

Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, dcoughlin, Charusso, baloghadamsoftware, rnkovacs. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity. Szelethus added a

[PATCH] D65287: [analyzer][CFG] Don't track the condition of asserts

Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: cfe/trunk/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1759 +if (isa(ElseCond)) { + assert(cast(ElseCond)->isLogicalOp()); + return isAssertlikeBlock(Else, Context);

r369195 - [analyzer] Turn an assert into an if condition

Author: szelethus Date: Sat Aug 17 09:49:54 2019 New Revision: 369195 URL: http://llvm.org/viewvc/llvm-project?rev=369195=rev Log: [analyzer] Turn an assert into an if condition Shocker, turns out that terminator conditions that are binary operators aren't always logical operators. Modified:

[PATCH] D41412: [libcxx] implement concat() and split()

grosser added a comment. Herald added a subscriber: sanjoy.google. @ericwf and @timshen, @Maxf and I are indeed very interested in seeing this library upstreamed soon. Over the last weeks, we developed a software prototype based on these bindings and already started to tune performance on

[PATCH] D64820: Avoids an assertion failure when an invalid conversion declaration is used

Mordante added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64820/new/ https://reviews.llvm.org/D64820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64874: Improve handling of function pointer conversions

Mordante added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64874/new/ https://reviews.llvm.org/D64874 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D65695: Implements CWG 1601 in [over.ics.rank/4.2]

Mordante updated this revision to Diff 215736. Mordante marked an inline comment as done. Mordante edited the summary of this revision. Mordante added a comment. Implemented the changes requested by @rsmith. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65695/new/

[PATCH] D65695: Implements CWG 1601 in [over.ics.rank/4.2]

Mordante marked 4 inline comments as done. Mordante added inline comments. Comment at: clang/test/CXX/drs/dr16xx.cpp:26 +namespace dr1601 { // dr1601: 10 c++11 +#if __cplusplus >= 201103L rsmith wrote: > No need for the "c++11" marker here. (We accept fixed