[PATCH] D66490: [NewPM] Enable the New Pass Manager by Default in Clang

hfinkel added a comment. In D66490#1638162 , @rupprecht wrote: > We already know that we don't want this enabled for tsan builds due to > https://bugs.llvm.org/show_bug.cgi?id=42877, but I don't even know if anyone > else will hit it (it's only when

[PATCH] D66423: [analyzer] CastValueChecker: Model isa(), isa_and_nonnull()

Charusso added a comment. Thanks for the reviews so far! I had a contradiction in my mind about regions, but now everything is okay and the notes are not misleading. Comment at: clang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp:183 + if (Body) +DRE = dyn_cast(Body);

[PATCH] D66423: [analyzer] CastValueChecker: Model isa(), isa_and_nonnull()

Charusso updated this revision to Diff 216322. Charusso marked 7 inline comments as done. Charusso added a comment. - Simplify the template argument obtaining. - Added a tiny new test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66423/new/ https://reviews.llvm.org/D66423 Files:

[PATCH] D66512: [OpenCL] Fix declaration of enqueue_marker

yaxunl created this revision. yaxunl added reviewers: Anastasia, bader, b-sumner. https://reviews.llvm.org/D66512 Files: lib/Headers/opencl-c.h Index: lib/Headers/opencl-c.h === --- lib/Headers/opencl-c.h +++

[PATCH] D66325: [analyzer] CastValueChecker: Store the dynamic types and casts

Charusso updated this revision to Diff 216317. Charusso added a comment. - Make the check-clang pass and simplify a test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66325/new/ https://reviews.llvm.org/D66325 Files: clang/include/clang/AST/Type.h

[PATCH] D66325: [analyzer] CastValueChecker: Store the dynamic types and casts

Charusso updated this revision to Diff 216314. Charusso added a comment. - Remove `CastFromTy` finally from the `getNoteTag()` API as it was uninformative. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66325/new/ https://reviews.llvm.org/D66325 Files: clang/include/clang/AST/Type.h

[PATCH] D66325: [analyzer] CastValueChecker: Store the dynamic types and casts

Charusso marked an inline comment as done. Charusso added inline comments. Comment at: clang/test/Analysis/cast-value-notes.cpp:34 + if (dyn_cast_or_null(C)) { +// no-note: 'Assuming 'C' is a 'Circle', not a 'Circle'' +return; NoQ wrote: > A circle is

[PATCH] D66325: [analyzer] CastValueChecker: Store the dynamic types and casts

Charusso added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/DynamicCastInfo.h:19 +public: + enum CastKind { Success, Fail }; + NoQ wrote: > I suggest `enum CastResult { Success, Failure }` ("a fail" is slang, also >

[PATCH] D66325: [analyzer] CastValueChecker: Store the dynamic types and casts

Charusso updated this revision to Diff 216312. Charusso marked 3 inline comments as done. Charusso added a comment. - Fix more and publish the previously forgotten comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66325/new/ https://reviews.llvm.org/D66325 Files:

[PATCH] D66511: [clang-scan-deps] Skip UTF-8 BOM in source minimizer

aganea created this revision. aganea added reviewers: arphaman, dexonsmith, Bigcheese. aganea added a project: clang. Herald added a subscriber: tschuett. As per title. Repository: rC Clang https://reviews.llvm.org/D66511 Files: lib/Lex/DependencyDirectivesSourceMinimizer.cpp

[PATCH] D62571: Implement codegen for MSVC unions with reference members

domdom added a comment. Ping! Cheers, Dom CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62571/new/ https://reviews.llvm.org/D62571 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D66488: [LTO] Always mark regular LTO units with EnableSplitLTOUnit=1 under the new pass manager

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. Lgtm. Thanks for fixing this! Not sure how I missed doing this for both PMs. As an aside, please upload future patches with context, it makes reviewing much easier. Repository: rG

[PATCH] D66122: [CodeGen] Emit dynamic initializers for static TLS vars in outlined scopes

efriedma added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:479 +return a_deps.find(b) != a_deps.end() +|| b->getLocation() < a->getLocation(); // ensure deterministic ordering + }); Prince781 wrote: > efriedma

Buildbot numbers for the week of 08/04/2019 - 08/10/2019

Hello everyone, Below are some buildbot numbers for the week of 08/04/2019 - 08/10/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed

Buildbot numbers for the week of 08/11/2019 - 08/17/2019

Hello everyone, Below are some buildbot numbers for the last week of 08/11/2019 - 08/17/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from

[PATCH] D65919: [clang-tidy] Add llvm-prefer-register-over-unsigned check and apply it to LLVM

dsanders updated this revision to Diff 216290. dsanders marked 2 inline comments as done. dsanders added a comment. - registerCheck<> order Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65919/new/ https://reviews.llvm.org/D65919 Files:

r369474 - Add triple to new test to try to pacify bots

Author: rnk Date: Tue Aug 20 16:32:51 2019 New Revision: 369474 URL: http://llvm.org/viewvc/llvm-project?rev=369474=rev Log: Add triple to new test to try to pacify bots Modified: cfe/trunk/test/CodeGenCXX/debug-info-atexit-stub.cpp Modified:

[PATCH] D66505: Make add_new_check.py's insertion of registerCheck<> more closely match the sort order

dsanders created this revision. dsanders added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. Following on from review comments in D65919 about the ordering of the registerCheck<> calls. Ignore namespaces when

[PATCH] D65724: [analyzer] Don't make ConditionBRVisitor events prunable when the condition is an interesting field

Szelethus updated this revision to Diff 216283. Szelethus added a comment. - Add the `FIXME` - Cascade test changes from D65575 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65724/new/ https://reviews.llvm.org/D65724 Files:

[PATCH] D65575: [analyzer] Mention whether an event is about a condition in a bug report part 1

Szelethus added a comment. In D65575#1638430 , @xazax.hun wrote: > LGTM! I think the UIs could do better displaying this info in the future but > this is not your job :) https://github.com/Ericsson/codechecker/pull/2279 CodeChecker now indents

[PATCH] D65575: [analyzer] Mention whether an event is about a condition in a bug report part 1

xazax.hun added a comment. LGTM! I think the UIs could do better displaying this info in the future but this is not your job :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65575/new/ https://reviews.llvm.org/D65575 ___ cfe-commits

[PATCH] D65575: [analyzer] Mention whether an event is about a condition in a bug report part 1

xazax.hun accepted this revision. xazax.hun added a comment. *actually accepting* CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65575/new/ https://reviews.llvm.org/D65575 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D65575: [analyzer] Mention whether an event is about a condition in a bug report part 1

Szelethus added a comment. Hmm-hmm, I kinda like the comma, but would happily concede on this. Its been a while since my english exam :^) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65575/new/ https://reviews.llvm.org/D65575 ___

[PATCH] D66122: [CodeGen] Emit dynamic initializers for static TLS vars in outlined scopes

Prince781 marked an inline comment as done. Prince781 added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:479 +return a_deps.find(b) != a_deps.end() +|| b->getLocation() < a->getLocation(); // ensure deterministic ordering + });

[PATCH] D63638: [clang][NewPM] Add new pass manager RUN lines to avx512f-builtins.c

craig.topper abandoned this revision. craig.topper added a comment. I don't think so. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63638/new/ https://reviews.llvm.org/D63638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D65575: [analyzer] Mention whether an event is about a condition in a bug report part 1

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks!! I also suspect we don't need the comma. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65575/new/ https://reviews.llvm.org/D65575

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

paulkirth updated this revision to Diff 216274. paulkirth added a comment. Herald added a subscriber: ormris. Update LLVM based implementation Adds LLVM based tests Cleans up existing tests in clang Adds new llvm flag -pgo-warn-misexpect Adds llvm flag when -Wmisexpect enabled in frontend Adds

[PATCH] D66068: cmake: Make building clang-shlib optional

beanz added a comment. In D66068#1636240 , @jvesely wrote: > sorry for the delay. I fully understand the need to reduce the number of > options. Having always used SHARED_LIBS build I remember weekly shared build > breakages. This is exactly what we

[PATCH] D66122: [CodeGen] Emit dynamic initializers for static TLS vars in outlined scopes

efriedma added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:479 +return a_deps.find(b) != a_deps.end() +|| b->getLocation() < a->getLocation(); // ensure deterministic ordering + }); Is the call to a_deps.find()

[PATCH] D65575: [analyzer] Mention whether an event is about a condition in a bug report part 1

Szelethus updated this revision to Diff 216273. Szelethus added a comment. - Change the condition postfix as discussed - `expected-note{{...}}` -> `expected-note-re^}}...{{$` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65575/new/ https://reviews.llvm.org/D65575 Files:

[PATCH] D66502: [clang-doc] Switch Generator::CreateResources to use llvm::Error

juliehockett created this revision. juliehockett added reviewers: DiegoAstiazaran, jakehehrlich. juliehockett added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman. https://reviews.llvm.org/D66502 Files: clang-tools-extra/clang-doc/Generators.cpp

[PATCH] D66328: [DebugInfo] Add debug location to dynamic atexit destructor

This revision was automatically updated to reflect the committed changes. Closed by commit rL369458: [DebugInfo] Add debug location to dynamic atexit destructor (authored by aganea, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r369458 - [DebugInfo] Add debug location to dynamic atexit destructor

Author: aganea Date: Tue Aug 20 15:09:49 2019 New Revision: 369458 URL: http://llvm.org/viewvc/llvm-project?rev=369458=rev Log: [DebugInfo] Add debug location to dynamic atexit destructor Fixes PR43012 Differential Revision: https://reviews.llvm.org/D66328 Added:

[PATCH] D66328: [DebugInfo] Add debug location to dynamic atexit destructor

aganea added a comment. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66328/new/ https://reviews.llvm.org/D66328 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D66486: [LifetimeAnalysis] Detect more cases when the address of a local variable escapes

xazax.hun added a comment. Ok, I think I know what is going on. Basically, we have a `MutableArrayRef` which is NOT a pointer as it is NOT annotated as `gsl::Pointer`. So in the AST we see a local non-pointer object, and we derive a pointer from this local object. This is why the warnings

[PATCH] D63638: [clang][NewPM] Add new pass manager RUN lines to avx512f-builtins.c

RKSimon added a comment. In D63638#1596313 , @leonardchan wrote: > I created D65110 if we're ok with just > using the new PM. @craig.topper Is this patch still relevant? CHANGES SINCE LAST ACTION

[PATCH] D65349: [analyzer] Be more careful with destructors of non-regions.

This revision was automatically updated to reflect the committed changes. Closed by commit rL369450: [analyzer] Fix a crash when destroying a non-region. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64274: [analyzer] VirtualCallChecker overhaul.

This revision was automatically updated to reflect the committed changes. Closed by commit rL369449: [analyzer] Improve VirtualCallChecker and enable parts of it by default. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

r369450 - [analyzer] Fix a crash when destroying a non-region.

Author: dergachev Date: Tue Aug 20 14:41:17 2019 New Revision: 369450 URL: http://llvm.org/viewvc/llvm-project?rev=369450=rev Log: [analyzer] Fix a crash when destroying a non-region. Add defensive check that prevents a crash when we try to evaluate a destructor whose this-value is a concrete

r369451 - [analyzer] NFC: Remove the BugTypes set from BugReporter.

Author: dergachev Date: Tue Aug 20 14:41:20 2019 New Revision: 369451 URL: http://llvm.org/viewvc/llvm-project?rev=369451=rev Log: [analyzer] NFC: Remove the BugTypes set from BugReporter. Its only purpose was to avoid a bug that's caused by making a virtual call in BugReporter's destructor.

r369449 - [analyzer] Improve VirtualCallChecker and enable parts of it by default.

Author: dergachev Date: Tue Aug 20 14:41:14 2019 New Revision: 369449 URL: http://llvm.org/viewvc/llvm-project?rev=369449=rev Log: [analyzer] Improve VirtualCallChecker and enable parts of it by default. Calling a pure virtual method during construction or destruction is undefined behavior. It's

[PATCH] D66486: [LifetimeAnalysis] Detect more cases when the address of a local variable escapes

xazax.hun added a comment. In D66486#1638213 , @mgehre wrote: > This change might be the cause for the false-positive in > https://github.com/mgehre/llvm-project/issues/45. Could you check? Sure, looking into it! Thanks for pointing this out.

[PATCH] D66486: [LifetimeAnalysis] Detect more cases when the address of a local variable escapes

mgehre added a comment. This change might be the cause for the false-positive in https://github.com/mgehre/llvm-project/issues/45. Could you check? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66486/new/ https://reviews.llvm.org/D66486

[PATCH] D66325: [analyzer] CastValueChecker: Store the dynamic types and casts

Charusso updated this revision to Diff 216250. Charusso added a comment. - Added a new test case and refactored that test file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66325/new/ https://reviews.llvm.org/D66325 Files: clang/include/clang/AST/Type.h

[PATCH] D66325: [analyzer] CastValueChecker: Store the dynamic types and casts

NoQ added a comment. Something went wrong with message generation, can you take a look? Comment at: clang/test/Analysis/cast-value-notes.cpp:24 + const auto = dyn_cast(S); + // expected-note@-1 {{Assuming 'S' is a 'Circle', not a 'Shape'}} + // expected-note@-2

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

sdmitriev added a comment. In D64943#1633164 , @ABataev wrote: > In D64943#1619958 , @sdmitriev wrote: > > > As I understand ‘atexit’ solution would be target dependent (‘__cxa_atexit’ > > on Linux and ‘atexit’ on

[PATCH] D66179: [LifetimeAnalysis] Support more STL idioms (template forward declaration and DependentNameType)

mgehre updated this revision to Diff 216247. mgehre marked 6 inline comments as done. mgehre added a comment. Herald added a subscriber: mgorny. - Put OwnerAttr/PointerAttr on all redeclarations - clang/lib/Sema/SemaAttr.cpp: Use Attribute::CreateImplicit as requested in review Repository:

[PATCH] D66179: [LifetimeAnalysis] Support more STL idioms (template forward declaration and DependentNameType)

mgehre added a comment. I now add the attributes to all redeclarations to make the logic a bit easier to follow. Comment at: clang/lib/Sema/SemaAttr.cpp:94 - Canonical->addAttr(::new (Context) Attribute(SourceRange{}, Context, -

[PATCH] D66325: [analyzer] CastValueChecker: Store the dynamic types and casts

Charusso updated this revision to Diff 216246. Charusso marked 15 inline comments as done. Charusso added a comment. Herald added a subscriber: mgorny. - Fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66325/new/ https://reviews.llvm.org/D66325 Files:

[PATCH] D66423: [analyzer] CastValueChecker: Model isa(), isa_and_nonnull()

Charusso marked 9 inline comments as done. Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp:216 + const NoteTag *Tag = C.getNoteTag( + [=](BugReport &) -> std::string { +SmallString<128> Msg; NoQ

[PATCH] D66490: [NewPM] Enable the New Pass Manager by Default in Clang

rupprecht added a comment. We already know that we don't want this enabled for tsan builds due to https://bugs.llvm.org/show_bug.cgi?id=42877, but I don't even know if anyone else will hit it (it's only when building one particular library). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D66460: [analyzer] Remove BugReporter.BugTypes.

xazax.hun accepted this revision. xazax.hun added a comment. LG! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66460/new/ https://reviews.llvm.org/D66460 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D63648: [Preprocessor] Honor absolute paths in diagnostics

aganea added a comment. In D63648#1593619 , @thakis wrote: > - Does fastbuild have something like distcc-pump? Fastbuild works like plain distcc and unfortunately it does not have pump mode. > - IIRC we used to use fdiagnostics-absolute-paths in

[PATCH] D66473: [analyzer] Removed some dead code in BugReporter and related files

gribozavr marked an inline comment as done. gribozavr added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:408 -public: - enum Kind { BasicBRKind, PathSensitiveBRKind }; - NoQ wrote: > gribozavr wrote: > > NoQ

[PATCH] D66493: [NewPM] Run ubsan-coroutines test under the legacy pass manager only

This revision was automatically updated to reflect the committed changes. Closed by commit rL369442: [NewPM] Run ubsan-coroutines test under the legacy pass manager only (authored by leonardchan, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

r369442 - [NewPM] Run ubsan-coroutines test under the legacy pass manager only

Author: leonardchan Date: Tue Aug 20 13:55:36 2019 New Revision: 369442 URL: http://llvm.org/viewvc/llvm-project?rev=369442=rev Log: [NewPM] Run ubsan-coroutines test under the legacy pass manager only The passes that lower the llvm.coro.* instrinsics have not yet been ported, so only run under

[PATCH] D66493: [NewPM] Run ubsan-coroutines test under the legacy pass manager only

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks, lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66493/new/ https://reviews.llvm.org/D66493

[PATCH] D66473: [analyzer] Removed some dead code in BugReporter and related files

NoQ accepted this revision. NoQ added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:408 -public: - enum Kind { BasicBRKind, PathSensitiveBRKind }; - gribozavr

[PATCH] D66328: [DebugInfo] Add debug location to dynamic atexit destructor

aganea updated this revision to Diff 216233. aganea marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66328/new/ https://reviews.llvm.org/D66328 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDeclCXX.cpp test/CodeGenCXX/debug-info-atexit-stub.cpp

[PATCH] D66328: [DebugInfo] Add debug location to dynamic atexit destructor

aganea added inline comments. Comment at: test/CodeGenCXX/debug-info-atexit-stub.cpp:14 + +// CHECK: define internal void @"??__Ff@?1??d@@YAPEAU?$c@UBXZ@YAXXZ"() +// CHECK-SAME: !dbg ![[SUBPROGRAM:[0-9]+]] { probinson wrote: > Do these Windows-mangled names

[PATCH] D62899: [analyzer][UninitializedObjectChecker] Mark uninitialized regions as interesting.

NoQ added a comment. In D62899#1634657 , @Szelethus wrote: > In D62899#1551312 , @NoQ wrote: > > > In D62899#1549715 , @Szelethus > > wrote: > > > > > Added a proper

[PATCH] D64274: [analyzer] VirtualCallChecker overhaul.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/CommonBugCategories.cpp:14-20 const char * const CoreFoundationObjectiveC = "Core Foundation/Objective-C"; const char * const LogicError = "Logic error"; const char *

[PATCH] D44672: [CodeGen] Disable UBSan for coroutine functions

leonardchan added a comment. In D44672#1637984 , @vsk wrote: > In D44672#1637891 , @leonardchan > wrote: > > > It seems that this test leads to an `UNREACHABLE` under the new pass > > manager (can check this by

[PATCH] D66493: [NewPM] Run ubsan-coroutines test under the legacy pass manager only

leonardchan created this revision. leonardchan added reviewers: vsk, modocache. leonardchan added a project: clang. Herald added a subscriber: EricWF. The passes that lower the `llvm.coro.*` instrinsics have not yet been ported, so only run under the legacy PM for now. See

[PATCH] D66364: Diagnose use of _Thread_local as an extension when appropriate

aaron.ballman added a comment. @rsmith are you fine with implementing the diagnostic for these keywords piecemeal based on the pattern from this patch, or do you want to see an omnibus patch that adds all of them at once? In D66364#1637635 , @ldionne

r369432 - [OPENMP]Fix delayed diagnostics for standalone declare target directive.

Author: abataev Date: Tue Aug 20 12:50:13 2019 New Revision: 369432 URL: http://llvm.org/viewvc/llvm-project?rev=369432=rev Log: [OPENMP]Fix delayed diagnostics for standalone declare target directive. If the function is marked as declare target in a standalone directive, the delayed diagnostics

[PATCH] D66492: [Clang][CodeGen] set alias linkage on QualType

nickdesaulniers created this revision. nickdesaulniers added a reviewer: rsmith. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. It seems that CodeGen was always using ExternalLinkage when emitting a GlobalDecl with __attribute__((alias)). This

[PATCH] D65211: [analyzer] Update the SARIF exporter to SARIF 2.1

aaron.ballman added a comment. In D65211#1606089 , @aaron.ballman wrote: > This LGTM, but I'd appreciate a second reviewer chiming in only because Joe > is a coworker. Sufficient time has passed that any concerns other reviewers have can be addressed

[PATCH] D65206: [analyzer] Fix text range end columns in SARIF to be exclusive

aaron.ballman added a comment. In D65206#1606072 , @aaron.ballman wrote: > This LGTM, but I'd appreciate a second reviewer chiming in only because Joe > is a coworker. Sufficient time has passed that any concerns other reviewers have can be addressed

[PATCH] D65209: [analyzer] Fix a SARIF exporter crash with macro expansions

aaron.ballman added a comment. In D65209#1606075 , @aaron.ballman wrote: > This LGTM, but I'd appreciate a second reviewer chiming in only because Joe > is a coworker. Sufficient time has passed that any concerns other reviewers have can be addressed

[PATCH] D44672: [CodeGen] Disable UBSan for coroutine functions

vsk added a comment. In D44672#1637891 , @leonardchan wrote: > It seems that this test leads to an `UNREACHABLE` under the new pass manager > (can check this by adding `-fexperimental-new-pass-manager` to the test. I > think this is because the passes

[PATCH] D65575: [analyzer] Mention whether an event is about a condition in a bug report part 1

NoQ added a comment. In D65575#1621425 , @Szelethus wrote: > I think it isn't crucial of getting rid of the "The" prefix, if we append ", > which participates in a condition later" (which sounds so much better than > what I added in this patch), so

[PATCH] D65481: NFCI: Simplify SourceManager::translateFile by removing code path that should never be taken

arphaman added a comment. Ping. I will commit it this week if there are no objections. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65481/new/ https://reviews.llvm.org/D65481 ___ cfe-commits mailing

[PATCH] D66490: [NewPM] Enable the New Pass Manager by Default in Clang

leonardchan added a comment. As of now, from running `check-llvm` and `check-clang` there's 2 failing tests, but I'm trying to get those addressed. - `Clang :: CodeGen/split-lto-unit.c` which should be resolved by D66488 - `Clang ::

[PATCH] D66490: [NewPM] Enable the New Pass Manager by Default in Clang

leonardchan created this revision. leonardchan added reviewers: chandlerc, echristo, hfinkel, lattner, rupprecht. leonardchan added a project: clang. Herald added subscribers: dexonsmith, mehdi_amini, mgorny. The new PM serves as a replacement for the legacy PM, and promises better codegen,

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

This revision was automatically updated to reflect the committed changes. Closed by commit rL369427: [Sema][Typo] Fix assertion failure for expressions with multiple typos (authored by dgoldman, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository:

[PATCH] D44672: [CodeGen] Disable UBSan for coroutine functions

leonardchan added a comment. It seems that this test leads to an `UNREACHABLE` under the new pass manager (can check this by adding `-fexperimental-new-pass-manager` to the test. I think this is because the passes for lowering the `llvm.coro` intrinsics are not yet ported to the new PM. Would

r369427 - [Sema][Typo] Fix assertion failure for expressions with multiple typos

Author: dgoldman Date: Tue Aug 20 12:03:15 2019 New Revision: 369427 URL: http://llvm.org/viewvc/llvm-project?rev=369427=rev Log: [Sema][Typo] Fix assertion failure for expressions with multiple typos Summary: As Typo Resolution can create new TypoExprs while resolving typos, it is necessary to

[PATCH] D66473: [analyzer] Removed some dead code in BugReporter and related files

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporter.cpp:2343 InterExplodedGraphMap ForwardMap; - TrimmedGraph = OriginalGraph->trim(Nodes, , ); gribozavr wrote: > NoQ wrote: > > Btw these days we strongly suspect that the

[PATCH] D66473: [analyzer] Removed some dead code in BugReporter and related files

Szelethus added a comment. No way the entire `NodeResolver` is dead code! I spent so much time trying to understand it! I mean, now that I think about it, we literally deep copy every `ExplodedNode`, so why would we need the mapping to the original, right? Wow. Thank you so much for clearing

[PATCH] D66473: Removed some dead code in BugReporter and related files

gribozavr marked 3 inline comments as done. gribozavr added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:408 -public: - enum Kind { BasicBRKind, PathSensitiveBRKind }; - NoQ wrote: > Hey, i just added that! :D

[PATCH] D66488: [LTO] Always mark regular LTO units with EnableSplitLTOUnit=1 under the new pass manager

leonardchan created this revision. leonardchan added reviewers: pcc, tejohnson. leonardchan added a project: clang. Herald added subscribers: dexonsmith, steven_wu, inglorion, mehdi_amini. Match the behavior of D65009 under the new pass manager also.

[PATCH] D66179: [LifetimeAnalysis] Support more STL idioms (template forward declaration and DependentNameType)

xazax.hun added inline comments. Comment at: clang/lib/Sema/SemaAttr.cpp:94 - Canonical->addAttr(::new (Context) Attribute(SourceRange{}, Context, - /*DerefType*/ nullptr, -

r369418 - Fix name of the error message, NFC.

Author: abataev Date: Tue Aug 20 10:50:13 2019 New Revision: 369418 URL: http://llvm.org/viewvc/llvm-project?rev=369418=rev Log: Fix name of the error message, NFC. Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td cfe/trunk/lib/Sema/SemaOpenMP.cpp Modified:

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 5PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D66303: [LifetimeAnalysis] Add support for free functions

xazax.hun marked 2 inline comments as done. xazax.hun added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:6622 +return false; + const auto *RD = FD->getParamDecl(0)->getType()->getPointeeCXXRecordDecl(); + if (!FD->isInStdNamespace() || !RD ||

[PATCH] D66486: [LifetimeAnalysis] Detect more cases when the address of a local variable escapes

xazax.hun created this revision. xazax.hun added reviewers: gribozavr, mgehre. xazax.hun added a project: clang. Herald added subscribers: Szelethus, Charusso, gamesh411, dkrupp, rnkovacs. This patch relaxes some of the checks so we can detect more cases where local variable escapes.

[PATCH] D64838: [Attr] Support _attribute__ ((fallthrough))

This revision was automatically updated to reflect the committed changes. Closed by commit rL369414: [Attr] Support _attribute__ ((fallthrough)) (authored by Nathan-Huckleberry, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D66485: [Clang][Bundler] Use llvm-objcopy for creating fat object files

sdmitriev created this revision. sdmitriev added a reviewer: ABataev. Herald added subscribers: cfe-commits, abrachet, mgorny. Herald added a reviewer: alexshap. Herald added a reviewer: jdoerfert. Herald added a project: clang. clang-offload-bundler currently uses partial linking for creating

r369414 - [Attr] Support _attribute__ ((fallthrough))

Author: nathan-huckleberry Date: Tue Aug 20 10:16:49 2019 New Revision: 369414 URL: http://llvm.org/viewvc/llvm-project?rev=369414=rev Log: [Attr] Support _attribute__ ((fallthrough)) Summary: Fixed extraneous matches of non-NullStmt Reviewers: aaron.ballman, rsmith, efriedma, xbolva00

[PATCH] D66303: [LifetimeAnalysis] Add support for free functions

This revision was automatically updated to reflect the committed changes. Closed by commit rL369408: [LifetimeAnalysis] Add support for free functions (authored by xazax, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r369408 - [LifetimeAnalysis] Add support for free functions

Author: xazax Date: Tue Aug 20 09:45:06 2019 New Revision: 369408 URL: http://llvm.org/viewvc/llvm-project?rev=369408=rev Log: [LifetimeAnalysis] Add support for free functions Differential Revision: https://reviews.llvm.org/D66303 Modified: cfe/trunk/lib/Sema/SemaInit.cpp

[PATCH] D66364: Diagnose use of _Thread_local as an extension when appropriate

ldionne added a comment. In D66364#1637570 , @aaron.ballman wrote: > In D66364#1635863 , @ldionne wrote: > > > In D66364#1635814 , @aaron.ballman > > wrote: > > > > > [

[PATCH] D66394: clang-cl: Enable /Zc:twoPhase by default if targeting MSVC 2017 update 3 or newer

This revision was automatically updated to reflect the committed changes. Closed by commit rL369402: win: Enable /Zc:twoPhase by default if targeting MSVC 2017 update 3 or newer (authored by nico, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

r369402 - win: Enable /Zc:twoPhase by default if targeting MSVC 2017 update 3 or newer

Author: nico Date: Tue Aug 20 09:28:11 2019 New Revision: 369402 URL: http://llvm.org/viewvc/llvm-project?rev=369402=rev Log: win: Enable /Zc:twoPhase by default if targeting MSVC 2017 update 3 or newer MSVC 2017 update 3 (_MSC_VER 1911) enables /Zc:twoPhase by default, and so should clang-cl:

[PATCH] D66302: [SVE][Inline-Asm] Support for SVE asm operands

kmclaughlin updated this revision to Diff 216178. kmclaughlin added a comment. - Added a new test file, aarch64-sve-asm-negative.ll - Updated description of the 'y' constraint in LangRef.rst CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66302/new/ https://reviews.llvm.org/D66302

[PATCH] D66481: [C++20] Support for lambdas in unevaluated context

krzysztof-jusiak added a comment. In D66481#1637530 , @lebedev.ri wrote: > Doesn't this inadvertently allow them in every standard? That seems wrong. Good point, you are right, will fix it and resubmit  Repository: rC Clang CHANGES SINCE LAST

[PATCH] D66481: [C++20] Support for lambdas in unevaluated context

krzysztof-jusiak added a comment. In D66481#1637525 , @riccibruno wrote: > Can you submit the patch with the full context (ie: git diff -U999) ? Sure, will do it Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D66364: Diagnose use of _Thread_local as an extension when appropriate

aaron.ballman added a comment. In D66364#1635863 , @ldionne wrote: > In D66364#1635814 , @aaron.ballman > wrote: > > > [ ...] > > > > Adding some libc++ maintainers to see if they have opinions. > > > >

r369397 - [clang] Use the new Regex::isValid() with no parameter

Author: jankratochvil Date: Tue Aug 20 09:07:31 2019 New Revision: 369397 URL: http://llvm.org/viewvc/llvm-project?rev=369397=rev Log: [clang] Use the new Regex::isValid() with no parameter Differential Revision: https://reviews.llvm.org/D66463 Modified:

  1   2   >