[PATCH] D66516: [clangd] Added highlighting to types dependant on templates.

nridge added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:177 return; +if (TP->isPointerType() || TP->isLValueReferenceType()) + // When highlighting dependant template types the type can be a pointer or ilya-bir

[PATCH] D66990: [clangd] Add distinct highlightings for declarations of functions and methods

nridge added a comment. There is precedent for highlighting declarations and uses differently in other C++ editors. For example, Eclipse CDT has separate highlightings for function and functions declarations (see screenshot below). Objectively speaking, I think it makes sense to style function

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev updated this revision to Diff 218250. sdmitriev added a comment. Removed trailing '.' from error messages and added few additional changes for better error handling. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67031/new/ https://reviews.llvm.org/D67031 Files: clang/test/

[PATCH] D66862: Make lround builtin constexpr (and others)

zoecarver updated this revision to Diff 218231. zoecarver added a comment. - add roundl builtins - add more tests - address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66862/new/ https://reviews.llvm.org/D66862 Files: clang/lib

[PATCH] D66862: Make lround builtin constexpr (and others)

zoecarver marked an inline comment as done. zoecarver added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:9617 +APFloat FPVal(0.0); +APSInt IVal(Info.Ctx.getIntWidth(E->getType()), 0); +bool isExact = true; rsmith wrote: > Please use `/*

[PATCH] D66862: Make lround builtin constexpr (and others)

zoecarver added a comment. > Are you intentionally excluding __builtin_lroundl/__builtin_llroundl? I //was// because `convertToDouble` could only return up to 64 bytes. But now that I am using the builtin APFloat round function, that works. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D66621: [clang] Devirtualization for classes with destructors marked as 'final'

xbolva00 added a comment. >> For now, I need help committing this, if anyone would be so kind! rL370597 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66621/new/ https://reviews.llvm.org/D66621 ___

[PATCH] D66621: [clang] Devirtualization for classes with destructors marked as 'final'

This revision was automatically updated to reflect the committed changes. Closed by commit rL370597: [clang] Devirtualization for classes with destructors marked as 'final' (authored by xbolva00, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

r370597 - [clang] Devirtualization for classes with destructors marked as 'final'

Author: xbolva00 Date: Sat Aug 31 11:52:44 2019 New Revision: 370597 URL: http://llvm.org/viewvc/llvm-project?rev=370597&view=rev Log: [clang] Devirtualization for classes with destructors marked as 'final' A class with a destructor marked final cannot be derived from, so it should afford the sa

[PATCH] D63960: [C++20] Add consteval-specifique semantic

Tyker marked 2 inline comments as done. Tyker added a comment. sorry i didn't realize the full complexity of immediate invocations. i am working on a patch fixing issues. Comment at: clang/lib/Sema/SemaExpr.cpp:5761-5762 // in ArgExprs. - if ((FDecl = -

r370595 - [NFC] Fix for rL370594

Author: xbolva00 Date: Sat Aug 31 11:35:44 2019 New Revision: 370595 URL: http://llvm.org/viewvc/llvm-project?rev=370595&view=rev Log: [NFC] Fix for rL370594 Modified: cfe/trunk/include/clang/Basic/DiagnosticGroups.td cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td Modified: cfe/tru

[PATCH] D66711: [clang] Warning for non-final classes with final destructors

This revision was automatically updated to reflect the committed changes. Closed by commit rL370594: [clang] Warning for non-final classes with final destructors (authored by xbolva00, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r370594 - [clang] Warning for non-final classes with final destructors

Author: xbolva00 Date: Sat Aug 31 11:31:19 2019 New Revision: 370594 URL: http://llvm.org/viewvc/llvm-project?rev=370594&view=rev Log: [clang] Warning for non-final classes with final destructors Marking a class' destructor final prevents the class from being inherited from. However, it is a sub

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:906 +Msg << ", unknown target triple '" << Triple << "'"; + reportError(createStringError(errc::invalid_argument, Msg.st

[PATCH] D59754: [Sema] Add c++2a designated initializer warnings

xbolva00 added inline comments. Comment at: cfe/trunk/lib/Sema/SemaInit.cpp:3112 SmallVector InitExpressions; + bool HasArrayDesignator = false; warning: variable ‘HasArrayDesignator’ set but not used [-Wunused-but-set-variable] bool HasArrayDesignator

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

MaskRay added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:906 +Msg << ", unknown target triple '" << Triple << "'"; + reportError(createStringError(errc::invalid_argument, Msg.str() + ".")); } I think t

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:41-44 -#include -#include -#include -#include Hahnfeld wrote: > The code still uses (in the order of marked incl

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev updated this revision to Diff 218224. sdmitriev retitled this revision from "[Clang][Bundler] Error reporting improvements [NFC]" to "[Clang][Bundler] Error reporting improvements". sdmitriev added a comment. Addressed review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.

r370588 - Revert [Clang Interpreter] Initial patch for the constexpr interpreter

Author: nand Date: Sat Aug 31 08:15:39 2019 New Revision: 370588 URL: http://llvm.org/viewvc/llvm-project?rev=370588&view=rev Log: Revert [Clang Interpreter] Initial patch for the constexpr interpreter This reverts r370584 (git commit afcb3de117265a69d21e5673356e925a454d7d02) Removed: cfe/tr

[PATCH] D67031: [Clang][Bundler] Error reporting improvements [NFC]

Hahnfeld added a comment. This changes error messages, so I'd say it's not NFC. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:41-44 -#include -#include -#include -#include The code still uses (in the order of marked includes) * `std

[PATCH] D64644: [Sema] Fixes an assertion failure while instantiation a template with an incomplete typo corrected type

Mordante updated this revision to Diff 218221. Mordante retitled this revision from "Fixes an assertion failure while instantiation a template with an incomplete typo corrected type" to "[Sema] Fixes an assertion failure while instantiation a template with an incomplete typo corrected type". Mor

[PATCH] D64480: [ASTImporter] Added visibility context check for TypedefNameDecl.

shafik added a comment. It is worth noting that: typedef int T; typedef int T; is not valid C99 see godbolt Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64480/new/ https://reviews.llvm.org/D64480 __

[PATCH] D65695: Implements CWG 1601 in [over.ics.rank/4.2]

Mordante updated this revision to Diff 218216. Mordante added a comment. Addresses the review remarks: - Use `S.Context.hasSameType` for the comparision - Simplify an `if` statement CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65695/new/ https://reviews.llvm.org/D65695 Files: clang

[PATCH] D64874: [Sema] Improve handling of function pointer conversions

Mordante updated this revision to Diff 218215. Mordante added a comment. Addresses the review remarks: - resultTy -> ResultTy - Move all unit tests in one file - Change the unit test to use `-verify` instead of `FileCheck` - Use PR40024 instead of link to Bugzilla CHANGES SINCE LAST ACTION ht

[PATCH] D64820: [Sema] Avoids an assertion failure when an invalid conversion declaration is used

Mordante updated this revision to Diff 218213. Mordante added a comment. Addresses the review remarks: - Moved the unit test to SemaCXX (also use the PR as name of the file) - Change the unit test to use `-verify` instead of `FileCheck` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6482

[PATCH] D67037: [ClangFormat] Add new style option IndentGotoLabels

tetsuo-cpp created this revision. tetsuo-cpp added a reviewer: klimek. Herald added a project: clang. Herald added a subscriber: cfe-commits. This option determines whether goto labels are indented according to scope. Setting this option to false causes goto labels to be flushed to the left. This

[PATCH] D65371: do not emit -Wunused-macros warnings in -frewrite-includes mode (PR15614)

llunak added a comment. Ping? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65371/new/ https://reviews.llvm.org/D65371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D63508: make -frewrite-includes also rewrite conditions in #if/#elif

llunak added a comment. Ping? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63508/new/ https://reviews.llvm.org/D63508 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li