[PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

shafik added inline comments. Comment at: clang/unittests/AST/ASTImporterODRStrategiesTest.cpp:151 +}; + +template martong wrote: > balazske wrote: > > `FunctionTemplate` and `FunctionTemplateSpec` are missing? > Yes, because `FunctionTemplates` overload with

[PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

shafik added inline comments. Comment at: clang/unittests/AST/ASTImporterODRStrategiesTest.cpp:118 + template + constexpr T X; + )"; shafik wrote: > Note this is not well-formed b/c it is not initialized, [see >

[PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

shafik added inline comments. Comment at: clang/unittests/AST/ASTImporterODRStrategiesTest.cpp:118 + template + constexpr T X; + )"; Note this is not well-formed b/c it is not initialized, [see godbolt](https://godbolt.org/z/8xvFwh)

[PATCH] D67425: [WebAssembly] Narrowing and widening SIMD ops

tlively planned changes to this revision. tlively added a comment. I missed the fact that the narrows are supposed to be binary operations. Oops. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67425/new/ https://reviews.llvm.org/D67425

[PATCH] D63607: [clang][driver] Add basic --driver-mode=fortran support for flang

hfinkel added inline comments. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:73 + } else { +assert(Output.isNothing() && "Input output."); + } Should this say "Invalid output"? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63607/new/

[PATCH] D67429: Improve code generation for thread_local variables:

rsmith created this revision. rsmith added a reviewer: rjmccall. Herald added a reviewer: jdoerfert. Herald added a project: clang. - Don't bother using a thread wrapper when the variable is known to have constant initialization. - Emit the thread wrapper as discardable-if-unused in TUs that

[PATCH] D59754: [Sema] Add c++2a designated initializer warnings

thakis added a comment. Another question about this, sorry. Do you know _why_ C++20 is more restrictive than C99 wrt "mixture of designated and non-designated initializers in the same initializer list is a C99 extension"? Is there some interaction with other C++ features that makes the C99

[PATCH] D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type

This revision was automatically updated to reflect the committed changes. Closed by commit rL371586: [CodeGen] Add alias for cpu_dispatch function with IFunc Fix resolver linkage… (authored by MaskRay, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

r371586 - [CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type

Author: maskray Date: Tue Sep 10 18:54:48 2019 New Revision: 371586 URL: http://llvm.org/viewvc/llvm-project?rev=371586=rev Log: [CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type Multi-versioned functions defined by cpu_dispatch and implemented with IFunc can

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

This revision was automatically updated to reflect the committed changes. Closed by commit rL371584: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM (authored by phosek, committed by ). Herald added a subscriber: delcypher. Changed prior to commit:

r371584 - clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

Author: phosek Date: Tue Sep 10 18:09:16 2019 New Revision: 371584 URL: http://llvm.org/viewvc/llvm-project?rev=371584=rev Log: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM This patch contains the basic functionality for reporting potentially incorrect usage of

[PATCH] D67304: Emit -Wmicrosoft-enum-value warning instead of error in MS ABI

This revision was automatically updated to reflect the committed changes. Closed by commit rL371581: Emit -Wmicrosoft-enum-value warning instead of error in MS ABI (authored by rnk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r371581 - Emit -Wmicrosoft-enum-value warning instead of error in MS ABI

Author: rnk Date: Tue Sep 10 18:01:06 2019 New Revision: 371581 URL: http://llvm.org/viewvc/llvm-project?rev=371581=rev Log: Emit -Wmicrosoft-enum-value warning instead of error in MS ABI Summary: The first NFC change is to replace a getCXXABI().isMicrosoft() check with

[PATCH] D67425: [WebAssembly] Narrowing and widening SIMD ops

aheejin added a comment. Can you give the link for the spec of these new instructions? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67425/new/ https://reviews.llvm.org/D67425 ___ cfe-commits mailing

[PATCH] D67426: Don't warn about selectany on implicitly inline variables

rnk created this revision. rnk added reviewers: epastor, thakis, hans. Herald added a project: clang. This avoids a -Wignored-attribute warning on the code pattern Microsoft recommends for integral const static data members defined in headers here:

r371578 - [clang-scan-deps][NFC] Fix tests - prevent FileCheck matching test dir path

Author: jkorous Date: Tue Sep 10 17:30:26 2019 New Revision: 371578 URL: http://llvm.org/viewvc/llvm-project?rev=371578=rev Log: [clang-scan-deps][NFC] Fix tests - prevent FileCheck matching test dir path Differential Revision: https://reviews.llvm.org/D67379 Modified:

[PATCH] D47956: [MS] Consder constexpr globals to be inline, as in C++17

rnk added a comment. In D47956#1138555 , @rnk wrote: > In D47956#1138521 , @rsmith wrote: > > > Can we now remove the corresponding MSVC-specific hacks elsewhere (eg, > >

[PATCH] D67425: [WebAssembly] Narrowing and widening SIMD ops

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: llvm-commits, cfe-commits, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added projects: clang, LLVM. Implements target-specific LLVM intrinsics and clang builtins for these new SIMD

[PATCH] D47956: [MS] Consder constexpr globals to be inline, as in C++17

rnk updated this revision to Diff 219638. rnk added a comment. Herald added a subscriber: mstorsjo. Herald added a project: clang. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47956/new/ https://reviews.llvm.org/D47956 Files:

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, Szelethus, baloghadamsoftware, Charusso, alexfh, gribozavr. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet. Herald added a project: clang. NoQ added a parent

[PATCH] D67421: [analyzer] NFC: Move IssueHash to libAnalysis.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, Szelethus, baloghadamsoftware, Charusso, alexfh, gribozavr. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, mgorny. Herald added a project: clang.

[PATCH] D67420: [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet. Herald added a project: clang. NoQ added reviewers: alexfh,

[PATCH] D67419: [analyzer] NFC: Move PathDiagnostic to libAnalysis.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, Szelethus, baloghadamsoftware, Charusso, alexfh, gribozavr. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, mgorny. Herald added a project: clang. NoQ added a

[PATCH] D67419: [analyzer] NFC: Move PathDiagnostic to libAnalysis.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidy.cpp:26 #include "clang/ASTMatchers/ASTMatchFinder.h" -#include "clang/Config/config.h" #include "clang/Format/Format.h" This needed to go up

[PATCH] D67304: Emit -Wmicrosoft-enum-value warning instead of error in MS ABI

rnk added a comment. In D67304#1664696 , @thakis wrote: > We have the old TODO of changing this warning to be emitted at enum use time > (e.g. when Foo_Val is compared to 0) instead of declaration time. Maybe > that's a better fix. Or is implementing

[PATCH] D67418: [analyzer] NFC: Move PathDiagnostic::resetDiagnosticLocationToMainFile to bug reporter.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet. Herald added a project: clang. NoQ added a parent revision: D67382:

[PATCH] D67395: [clang-format] Apply BAS_AlwaysBreak to C++11 braced lists

This revision was automatically updated to reflect the committed changes. Closed by commit rL371571: [clang-format] Apply BAS_AlwaysBreak to C++11 braced lists (authored by owenpan, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r371571 - [clang-format] Apply BAS_AlwaysBreak to C++11 braced lists

Author: owenpan Date: Tue Sep 10 16:26:45 2019 New Revision: 371571 URL: http://llvm.org/viewvc/llvm-project?rev=371571=rev Log: [clang-format] Apply BAS_AlwaysBreak to C++11 braced lists See PR18455. Differential Revision: https://reviews.llvm.org/D67395 Modified:

[PATCH] D66121: Debug Info: Nest Objective-C property function decls inside their container.

aprantl added a comment. In D66121#1656442 , @rjmccall wrote: > Can you prepare an NFC patch with just the changes relating to adding > `ObjCPropertyImplDecl::get{Getter,Setter}MethodDecl`? Sure, I will do that. > I don't get why the redeclaration

r371568 - Reland "Change the X86 datalayout to add three address spaces

Author: akhuang Date: Tue Sep 10 16:15:38 2019 New Revision: 371568 URL: http://llvm.org/viewvc/llvm-project?rev=371568=rev Log: Reland "Change the X86 datalayout to add three address spaces for 32 bit signed, 32 bit unsigned, and 64 bit pointers." This reverts

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

paulkirth updated this revision to Diff 219617. paulkirth added a comment. Add a new profdata file to use w/ misexpect-nonconst-switch.c ASAN exposed an issue where a function may hash the same even if the number of counters is different. This means that when a PGO profile is read in, it is

[PATCH] D64146: [Clang Interpreter] Initial patch for the constexpr interpreter

RKSimon added a comment. In D64146#1665003 , @nand wrote: > Totally missed that - thanks for noticing. I must have forgotten to remove > stuff from the header since clang/gcc don't warn about it. > I'll get hold of a Windows machine soon-ish and I'll

r371559 - Actually reorder not and env in crash-recovery-modules.m

Author: rnk Date: Tue Sep 10 14:54:16 2019 New Revision: 371559 URL: http://llvm.org/viewvc/llvm-project?rev=371559=rev Log: Actually reorder not and env in crash-recovery-modules.m Modified: cfe/trunk/test/Index/crash-recovery-modules.m Modified:

[PATCH] D66559: [OPENMP] Update the diagnosis message for canonical loop form

ABataev added a comment. In D66559#1665289 , @cchen wrote: > Oh, I was thinking that I could use "arc land" to commit my patch, but just > now realize that I don't have the commit privileges. Would you please commit > for me? Thanks. Sure, will do

[PATCH] D66559: [OPENMP] Update the diagnosis message for canonical loop form

cchen added a comment. Oh, I was thinking that I could use "arc land" to commit my patch, but just now realize that I don't have the commit privileges. Would you please commit for me? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D67249: [Modules][PCH] Hash input files content

bruno updated this revision to Diff 219607. bruno added a comment. Update the patch to use two ::Fixed, 32 in abbrev to encode hash. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67249/new/ https://reviews.llvm.org/D67249 Files:

Re: r359367 - Reinstate r359059, reverted in r359361, with a fix to properly prevent

Thanks, fixed in r371557. On Mon, 9 Sep 2019 at 19:12, Michael Spencer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Fri, Apr 26, 2019 at 7:56 PM Richard Smith via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: rsmith >> Date: Fri Apr 26 19:58:17 2019 >> New

r371557 - When evaluating a __builtin_constant_p conditional, always enter

Author: rsmith Date: Tue Sep 10 14:24:09 2019 New Revision: 371557 URL: http://llvm.org/viewvc/llvm-project?rev=371557=rev Log: When evaluating a __builtin_constant_p conditional, always enter constant-folding mode regardless of the original evaluation mode. In order for this to be correct, we

[PATCH] D67249: [Modules][PCH] Hash input files content

bruno marked an inline comment as done. bruno added inline comments. Comment at: clang/lib/Serialization/ASTWriter.cpp:1767 bool IsTopLevelModuleMap; + uint32_t ContentHash[2]; }; ributzka wrote: > bruno wrote: > > aprantl wrote: > > > Why is this not a

[PATCH] D67414: [AST] Treat "inline gnu_inline" the same way as "extern inline gnu_inline" in C++ mode

mstorsjo created this revision. mstorsjo added reviewers: dblaikie, pcc, efriedma. Herald added a project: clang. This matches how GCC handles it, see e.g. https://gcc.godbolt.org/z/HPplnl. The previous behaviour of gnu_inline in C++, without the extern keyword, can be traced back to the

[PATCH] D66856: [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd

erik.pilkington updated this revision to Diff 219598. erik.pilkington added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66856/new/ https://reviews.llvm.org/D66856 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/AST/Expr.cpp

r371553 - [OPENMP5.0]Allow teams directive outside of the target directives.

Author: abataev Date: Tue Sep 10 13:19:58 2019 New Revision: 371553 URL: http://llvm.org/viewvc/llvm-project?rev=371553=rev Log: [OPENMP5.0]Allow teams directive outside of the target directives. According to OpenMP 5.0, teams directives are allowed not only in the target context, but also in

r371552 - Re-land Remove REQUIRES:shell from tests that pass for me on Windows

Author: rnk Date: Tue Sep 10 13:15:45 2019 New Revision: 371552 URL: http://llvm.org/viewvc/llvm-project?rev=371552=rev Log: Re-land Remove REQUIRES:shell from tests that pass for me on Windows This reverts r371497 (git commit 3d7e9ab7b9f8c53aa41420c54970f0fb421004a2) Reorder `not` with `env`

[PATCH] D67246: clang-format: Add support for formatting lambdas with explicit template parameters.

thakis updated this revision to Diff 219589. thakis added a comment. fix nits CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67246/new/ https://reviews.llvm.org/D67246 Files: clang/lib/Format/TokenAnnotator.cpp clang/lib/Format/UnwrappedLineParser.cpp

[PATCH] D67395: [clang-format] Apply BAS_AlwaysBreak to C++11 braced lists

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Thank you for this patch, i've seen a number of PRs raise to this effect.. this looks to be a great start in this area LGTM Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D67246: clang-format: Add support for formatting lambdas with explicit template parameters.

thakis marked 3 inline comments as done. thakis added a comment. Thanks for the thorough review! Indeed, this still gets `[](A &){}();` wrong, for the reason you mention. Comment at: clang/lib/Format/TokenAnnotator.cpp:50 + // Skip <...> if present. + if (Left->Previous &&

[PATCH] D67037: [ClangFormat] Add new style option IndentGotoLabels

tetsuo-cpp added a comment. @MyDeveloperDay Thanks for your suggestions! I think it's better now. This is my first LLVM patch (hopefully first of many) so I don't have commit permissions yet. If you're still happy with this change, could you please commit on my behalf? Repository: rC Clang

[PATCH] D67037: [ClangFormat] Add new style option IndentGotoLabels

tetsuo-cpp updated this revision to Diff 219582. tetsuo-cpp added a comment. Addressed review comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67037/new/ https://reviews.llvm.org/D67037 Files: clang/docs/ClangFormatStyleOptions.rst

r371548 - Fix for PR43175: compiler crash when trying to emit noncapturable

Author: abataev Date: Tue Sep 10 12:16:56 2019 New Revision: 371548 URL: http://llvm.org/viewvc/llvm-project?rev=371548=rev Log: Fix for PR43175: compiler crash when trying to emit noncapturable constant. If the constexpr variable is partially initialized, the initializer can be emitted as the

[PATCH] D67135: [clang-tidy] performance-inefficient-vector-operation: Support proto repeated field

congliu updated this revision to Diff 219576. congliu marked 6 inline comments as done. congliu added a comment. Addressed Haojian's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67135/new/ https://reviews.llvm.org/D67135 Files:

[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

khchen created this revision. khchen added a project: clang. Herald added subscribers: pzheng, s.egerton, lenary, Jim, benna, psnobl, jocewei, PkmX, rkruppe, dexonsmith, the_o, brucehoult, MartinMosbeck, rogfer01, steven_wu, edward-jones, zzheng, MaskRay, jrtc27, shiva0217, kito-cheng, niosHD,

[PATCH] D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type

zsrkmyn marked 18 inline comments as done. zsrkmyn added a comment. All done IMO. :-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67058/new/ https://reviews.llvm.org/D67058 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64146: [Clang Interpreter] Initial patch for the constexpr interpreter

nand added a comment. Totally missed that - thanks for noticing. I must have forgotten to remove stuff from the header since clang/gcc don't warn about it. I'll get hold of a Windows machine soon-ish and I'll make sure to fix this problem. Thanks! Repository: rG LLVM Github Monorepo

[PATCH] D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type

zsrkmyn updated this revision to Diff 219568. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67058/new/ https://reviews.llvm.org/D67058 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/test/CodeGen/attr-cpuspecific.c clang/test/CodeGen/attr-target-mv-func-ptrs.c

[PATCH] D67140: [analyzer][NFC] Fix inconsistent references to checkers as "checks"

NoQ added a comment. In D67140#1664406 , @gribozavr wrote: > %select In D67140#1664921 , @aaron.ballman wrote: > `%select{}` Whoa, this could actually work then. I like it. Repository: rG LLVM Github

[PATCH] D67140: [analyzer][NFC] Fix inconsistent references to checkers as "checks"

aaron.ballman added a comment. In D67140#1664406 , @gribozavr wrote: > In D67140#1664106 , @NoQ wrote: > > > In D67140#1659982 , @gribozavr > > wrote: > > > > > We should

[PATCH] D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type

erichkeane added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3002 false); llvm::Constant *Resolver = GetOrCreateLLVMFunction( MangledName + ".resolver", ResolverType, GlobalDecl{}, zsrkmyn wrote: > erichkeane wrote: >

[PATCH] D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type

zsrkmyn added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3002 false); llvm::Constant *Resolver = GetOrCreateLLVMFunction( MangledName + ".resolver", ResolverType, GlobalDecl{}, erichkeane wrote: > zsrkmyn wrote: > >

[PATCH] D67405: Make FormatToken::Type private.

klimek created this revision. klimek added a reviewer: sammccall. Herald added a project: clang. This enables us to intercept changes to the token type via setType(), which is a precondition for being able to use multi-pass formatting for macro arguments. Repository: rG LLVM Github Monorepo

[PATCH] D67399: [ARM] Follow AACPS standard for volatile bitfields

jfb added inline comments. Comment at: clang/test/CodeGen/aapcs-bitfield.c:541 // BE-NEXT:[[TMP0:%.*]] = getelementptr inbounds [[STRUCT_ST9:%.*]], %struct.st9* [[M:%.*]], i32 0, i32 0 +// BE-NEXT:[[BF_LOAD:%.*]] = load volatile i8, i8* [[TMP0]], align 4 // BE-NEXT:

[PATCH] D67373: Don't emit .gnu_pubnames when tuning for LLDB

This revision was automatically updated to reflect the committed changes. Closed by commit rL371530: Dont emit .gnu_pubnames when tuning for LLDB. (authored by adrian, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r371530 - Don't emit .gnu_pubnames when tuning for LLDB.

Author: adrian Date: Tue Sep 10 08:53:18 2019 New Revision: 371530 URL: http://llvm.org/viewvc/llvm-project?rev=371530=rev Log: Don't emit .gnu_pubnames when tuning for LLDB. LLDB reads the various .apple* accelerator tables (and in the near future: the DWARF 5 accelerator tables) which should

[PATCH] D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type

erichkeane added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3002 false); llvm::Constant *Resolver = GetOrCreateLLVMFunction( MangledName + ".resolver", ResolverType, GlobalDecl{}, zsrkmyn wrote: > erichkeane wrote: >

[PATCH] D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type

zsrkmyn added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3002 false); llvm::Constant *Resolver = GetOrCreateLLVMFunction( MangledName + ".resolver", ResolverType, GlobalDecl{}, erichkeane wrote: > zsrkmyn wrote: > >

[PATCH] D67399: [ARM] Follow AACPS standard for volatile bitfields

lebedev.ri added a comment. In D67399#1664785 , @dnsampaio wrote: > @ostannard might prove me wrong, but according to the AACPS: > > When a volatile bit-field is written, and its container does not overlap > with any non-bit-field member, its >

[PATCH] D67399: [ARM] Follow AACPS standard for volatile bitfields

dnsampaio added a comment. @ostannard might prove me wrong, but according to the AACPS: When a volatile bit-field is written, and its container does not overlap with any non-bit-field member, its container must be read exactly once and written exactly once using the access width

[PATCH] D67399: [ARM] Follow AACPS standard for volatile bitfields

lebedev.ri resigned from this revision. lebedev.ri added a reviewer: jfb. lebedev.ri added a comment. Herald added a subscriber: dexonsmith. I'm not sure why i'm added as a reviewer here. That being said i don't see why that load is needed there. As i read it, the document only states that if

[PATCH] D67399: [ARM] Follow AACPS standard for volatile bitfields

dnsampaio added a comment. This patch could hack clang to generate an extra load. However, my knowledge in the clang code base is not extensive. How could we ensure that the width of loads and stores are the size of the container, and that they don't overlap non-bitfields? Repository: rG

[PATCH] D67399: [ARM] Follow AACPS standard for volatile bitfields

dnsampaio created this revision. dnsampaio added reviewers: lebedev.ri, ostannard. Herald added subscribers: cfe-commits, jfb, kristof.beyls. Herald added a project: clang. Bug 43264 This is a first draft to understand what has to be done to fix volatale bitfield access, as to conform to the

[PATCH] D67304: Emit -Wmicrosoft-enum-value warning instead of error in MS ABI

thakis added a comment. We have the old TODO of changing this warning to be emitted at enum use time (e.g. when Foo_Val is compared to 0) instead of declaration time. Maybe that's a better fix. Or is implementing that very involved? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

r371522 - [clang][codegen][NFC] Make test patterns more permissive.

Author: courbet Date: Tue Sep 10 07:20:08 2019 New Revision: 371522 URL: http://llvm.org/viewvc/llvm-project?rev=371522=rev Log: [clang][codegen][NFC] Make test patterns more permissive. See the discussion in: http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20190909/692736.html

[PATCH] D65050: [SemaTemplate] Mark a function type as dependent when its parameter list contains pack expansion

cpplearner added a comment. In D65050#1608777 , @efriedma wrote: > > this looks like it could be a Core Issue > > I think the issue is clang-specific. clang splits the standard notion of a > dependent type into two separate bits, for the sake of

[PATCH] D63607: [clang][driver] Add basic --driver-mode=fortran support for flang

peterwaller-arm updated this revision to Diff 219538. peterwaller-arm retitled this revision from "[clang][driver] Prototype --driver-mode=fortran support for new flang" to "[clang][driver] Add basic --driver-mode=fortran support for flang". peterwaller-arm added a comment. I updated this

[PATCH] D65050: [SemaTemplate] Mark a function type as dependent when its parameter list contains pack expansion

cpplearner added a comment. ping @rsmith CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65050/new/ https://reviews.llvm.org/D65050 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type

erichkeane added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3002 false); llvm::Constant *Resolver = GetOrCreateLLVMFunction( MangledName + ".resolver", ResolverType, GlobalDecl{}, zsrkmyn wrote: > erichkeane wrote: >

[PATCH] D67395: [clang-format] Apply BAS_AlwaysBreak to C++11 braced lists

owenpan created this revision. owenpan added reviewers: sammccall, MyDeveloperDay, klimek. Herald added a project: clang. Herald added a subscriber: cfe-commits. owenpan added a reviewer: djasper. See PR18455 and this message

[PATCH] D66524: [SVE][Inline-Asm] Add constraints for SVE predicate registers

kmclaughlin marked 3 inline comments as done. kmclaughlin added inline comments. Comment at: docs/LangRef.rst:3818 +- ``Upl``: One of the low eight SVE predicate registers (P0 to P7) +- ``Upa``: Any of the SVE predicate registers (P0 to P15) greened wrote: >

[PATCH] D66524: [SVE][Inline-Asm] Add constraints for SVE predicate registers

kmclaughlin updated this revision to Diff 219526. kmclaughlin added a comment. - Renamed the //isPredicateConstraint// function to //parsePredicateConstraint// - Added more thorough checks to the tests in aarch64-sve-asm.ll CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66524/new/

[PATCH] D67391: Fix the "git modified" issue on the preserve-comments-crlf.s.

This revision was automatically updated to reflect the committed changes. Closed by commit rL371513: Fix the git modified issue on the preserve-comments-crlf.s. (authored by hokein, committed by ). Changed prior to commit: https://reviews.llvm.org/D67391?vs=219522=219525#toc Repository: rL

[PATCH] D67391: Copy llvm .gitattributes to the monorepository.

hokein updated this revision to Diff 219522. hokein added a comment. Update the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67391/new/ https://reviews.llvm.org/D67391 Files: llvm/.gitattributes Index: llvm/.gitattributes

[PATCH] D66796: [clang] Loop pragma vectorize(disable)

SjoerdMeijer added a comment. > Now on the practical side. If whatever we decide here changes how the pragma > behaves from today, we need to have a wider discussion and agreement at > llvm-dev. Yep, forgot about that, thanks for the suggestion. I've just posted this message to the list:

[PATCH] D67391: Copy llvm .gitattributes to the monorepository.

hokein created this revision. hokein added a reviewer: gribozavr. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. This will fix the git "modified" change of llvm/trunk/test/MC/AsmParser/preserve-comments-crlf.s on linux. Repository: rG LLVM Github Monorepo

[PATCH] D67264: [clangd] Collect location of macro definition in the ParsedAST

This revision was automatically updated to reflect the committed changes. Closed by commit rL371504: [clangd] Collect location of macro definition in the ParsedAST (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[clang-tools-extra] r371504 - [clangd] Collect location of macro definition in the ParsedAST

Author: hokein Date: Tue Sep 10 03:10:36 2019 New Revision: 371504 URL: http://llvm.org/viewvc/llvm-project?rev=371504=rev Log: [clangd] Collect location of macro definition in the ParsedAST allows semantic hightlighting macro definition Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman,

[PATCH] D67065: [RISCV] Define __riscv_cmodel_medlow and __riscv_cmodel_medany correctly

lenary added a comment. LGTM, now I've looked at how LLVM itself supports code models. I don't mind if that TODO is or isn't deleted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67065/new/ https://reviews.llvm.org/D67065

[PATCH] D67341: [clangd] Simplify semantic highlighting visitor

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:169 private: - void addTokenForTypedef(SourceLocation Loc, const TypedefNameDecl *TD) { -auto *TSI = TD->getTypeSourceInfo(); -if (!TSI) - return; -// Try to

[PATCH] D67341: [clangd] Simplify semantic highlighting visitor

ilya-biryukov updated this revision to Diff 219503. ilya-biryukov marked 6 inline comments as done. ilya-biryukov added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67341/new/ https://reviews.llvm.org/D67341 Files:

[PATCH] D67264: [clangd] Collect location of macro definition in the ParsedAST

hokein updated this revision to Diff 219501. hokein marked an inline comment as done. hokein added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67264/new/ https://reviews.llvm.org/D67264 Files:

[PATCH] D67264: [clangd] Collect location of macro definition in the ParsedAST

hokein added a comment. In D67264#1663285 , @ilya-biryukov wrote: > LGTM. > > We should probably also take a look at highlighting macros inside the > preamble part of the main file. > @hokein, are you planning to do this or should we just file a bug

[PATCH] D67185: [RISCV] Add support for -ffixed-xX flags

lenary added a subscriber: luismarques. lenary added a comment. Nice, I like this new approach! One naming nit, but overall I think this is much better than the first version of the patch. LGTM but I would like @luismarques to take a look too. Comment at:

[PATCH] D67246: clang-format: Add support for formatting lambdas with explicit template parameters.

krasimir added a comment. I'll need some more time to investigate the implications of this with respect to Objective-C disambiguation stuff. Specifically, this may interact with funny ways with the heuristic outlined in (old) UnwrappedLineParser.cpp line 1453: // In a C++ lambda a template

[PATCH] D67140: [analyzer][NFC] Fix inconsistent references to checkers as "checks"

gribozavr added a comment. In D67140#1664106 , @NoQ wrote: > In D67140#1659982 , @gribozavr wrote: > > > We should take a page from desktop software here. If the messages were in a > > separate file, there would

[PATCH] D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type

zsrkmyn added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3002 false); llvm::Constant *Resolver = GetOrCreateLLVMFunction( MangledName + ".resolver", ResolverType, GlobalDecl{}, erichkeane wrote: > zsrkmyn wrote: > >

[libunwind] r371500 - Creating release candidate rc4 from release_900 branch

Author: hans Date: Tue Sep 10 02:05:55 2019 New Revision: 371500 URL: http://llvm.org/viewvc/llvm-project?rev=371500=rev Log: Creating release candidate rc4 from release_900 branch Added: libunwind/tags/RELEASE_900/rc4/ - copied from r371499, libunwind/branches/release_90/

[libclc] r371500 - Creating release candidate rc4 from release_900 branch

Author: hans Date: Tue Sep 10 02:05:55 2019 New Revision: 371500 URL: http://llvm.org/viewvc/llvm-project?rev=371500=rev Log: Creating release candidate rc4 from release_900 branch Added: libclc/tags/RELEASE_900/rc4/ - copied from r371499, libclc/branches/release_90/

[PATCH] D67341: [clangd] Simplify semantic highlighting visitor

hokein added a comment. thanks, looks good, just a few nits. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:34 +return true; + if (!Name.isIdentifier()) +return false; nit: I think the check is redundant, getAsIdentifierInfo() will

[PATCH] D67135: [clang-tidy] performance-inefficient-vector-operation: Support proto repeated field

hokein added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/InefficientVectorOperationCheck.cpp:227 +std::string MutableFieldName = +("mutable_" + ProtoAddFieldCall->getMethodDecl()->getName().substr(4)) +.str();

[PATCH] D67304: Emit -Wmicrosoft-enum-value warning instead of error in MS ABI

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67304/new/ https://reviews.llvm.org/D67304 ___

[PATCH] D66003: [RISCV] Make -march=rv{32, 64}gc the default in RISC-V Linux

This revision was automatically updated to reflect the committed changes. Closed by commit rL371496: [RISCV] Make -march=rv{32,64}gc the default in RISC-V Linux (authored by rogfer01, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r371496 - [RISCV] Make -march=rv{32, 64}gc the default in RISC-V Linux

Author: rogfer01 Date: Tue Sep 10 01:16:24 2019 New Revision: 371496 URL: http://llvm.org/viewvc/llvm-project?rev=371496=rev Log: [RISCV] Make -march=rv{32,64}gc the default in RISC-V Linux This is the logical follow-up of D65634. Differential Revision: https://reviews.llvm.org/D66003

  1   2   >