r371918 - [Driver] Fix multiple bugs related to dependency file options: -M -MM -MD -MMD -MT -MQ

Author: maskray Date: Fri Sep 13 23:01:22 2019 New Revision: 371918 URL: http://llvm.org/viewvc/llvm-project?rev=371918=rev Log: [Driver] Fix multiple bugs related to dependency file options: -M -MM -MD -MMD -MT -MQ -M -o test.i => dependency file is test.d, not test.i -MM -o test.i =>

r371917 - [Driver] Improve Clang::getDependencyFileName and its tests after rC371853

Author: maskray Date: Fri Sep 13 21:13:15 2019 New Revision: 371917 URL: http://llvm.org/viewvc/llvm-project?rev=371917=rev Log: [Driver] Improve Clang::getDependencyFileName and its tests after rC371853 The test file name metadata-with-dots.c is confusing because -MD and -MMD have nothing to do

[PATCH] D52193: RFC: [clang] Multithreaded compilation support -- NOT FOR SUBMIT

tycho added a comment. OK, those two problems were actually easy enough to fix. diff --git a/lib/Driver/Driver.cpp b/lib/Driver/Driver.cpp index 2f98cf9e04..93e974842f 100644 --- a/lib/Driver/Driver.cpp +++ b/lib/Driver/Driver.cpp @@ -3241,8 +3241,8 @@ void

[PATCH] D67368: [NFCI]Create CommonAttributeInfo Type as base type of *Attr and ParsedAttr.

MaskRay added inline comments. Comment at: cfe/trunk/include/clang/Basic/AttributeCommonInfo.h:166 + ? SpellingIndex + : calculateAttributeSpellingListIndex(); + } calculateAttributeSpellingListIndex is defined in clangSema. This can

[PATCH] D52193: RFC: [clang] Multithreaded compilation support -- NOT FOR SUBMIT

tycho added a comment. I rebased this myself on the release_90 branch and I was pleasantly surprised that I got the merge right on the first try (?!), and it actually works well without any significant changes (other than merge conflict resolutions). I've run into two problems with it though:

[PATCH] D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage

NoQ added a comment. FTR, we already have a similar Static Analyzer check, eg.: https://github.com/llvm-mirror/clang/blob/release_80/test/Analysis/dispatch-once.m#L15 Your check is a bit more aggressive but i don't see why didn't we do it that way in the first place :) CHANGES SINCE LAST

[PATCH] D67578: [clang-tidy] New check to warn when writing to a dispatch_once_t variable.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/misc-dispatch-once-assignment.rst:9 +and making such direct writes may potentially violate the run-once protections +intended by the library. Does library documentation

[PATCH] D67542: Fix depfile name construction

thakis added inline comments. Comment at: cfe/trunk/lib/Driver/ToolChains/Clang.cpp:6076 + + return Args.MakeArgString(std::string(getBaseInputStem(Args, Inputs)) + ".d"); } Can you use llvm::Twine() instead of std::string() here? Repository: rL LLVM

[PATCH] D66696: [ObjC generics] Fix not inheriting type bounds in categories/extensions.

vsapsai added a comment. In D66696#1663856 , @erik.pilkington wrote: > I'm a bit curious about clients that use `getCanonicalType()` to get a full > desugaring, instead of doing a single step. It seems like they'd still get > the out of date type

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

compnerd added inline comments. Comment at: clang/include/clang/Driver/Phases.h:24 +Link, +IfsMerge }; Trailing comma please Comment at: clang/lib/Driver/Driver.cpp:3341 llvm::SmallVector FullPL; -

[PATCH] D67425: [WebAssembly] Narrowing and widening SIMD ops

This revision was automatically updated to reflect the committed changes. Closed by commit rL371906: [WebAssembly] Narrowing and widening SIMD ops (authored by tlively, committed by ). Changed prior to commit: https://reviews.llvm.org/D67425?vs=219784=220189#toc Repository: rL LLVM CHANGES

r371906 - [WebAssembly] Narrowing and widening SIMD ops

Author: tlively Date: Fri Sep 13 15:54:41 2019 New Revision: 371906 URL: http://llvm.org/viewvc/llvm-project?rev=371906=rev Log: [WebAssembly] Narrowing and widening SIMD ops Summary: Implements target-specific LLVM intrinsics and clang builtins for these new SIMD operations, as described at

[PATCH] D67567: New ClangTidy check to warn when storing dispatch_once_t in non-static, non-global storage

mwyman added a comment. In D67567#1670035 , @lebedev.ri wrote: > In D67567#1670017 , @mwyman wrote: > > > In D67567#1669866 , @lebedev.ri > > wrote: > > > > > 1. Please

[PATCH] D67249: [Modules][PCH] Hash input files content

ributzka added a comment. xxhash64 is apparently faster than MD5 and SHA1, and produces good quality hashes. I am not sure about the hash quality of hash_code for this purpose. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67249/new/

[PATCH] D67578: New ClangTidy check to warn when writing to a dispatch_once_t variable.

mwyman created this revision. mwyman added reviewers: benhamilton, hokein, stephanemoore. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. Libdispatch documentation specifies that dispatch_once_ts must never have been non-zero, and assigning to them violates this.

r371903 - [clang-scan-deps] Fix for headers having the same name as a directory

Author: arphaman Date: Fri Sep 13 15:12:02 2019 New Revision: 371903 URL: http://llvm.org/viewvc/llvm-project?rev=371903=rev Log: [clang-scan-deps] Fix for headers having the same name as a directory Scan deps tool crashes when called on a C++ file, containing an include that has the same name

r371904 - Make test check position independent as they sometimes come out reversed. NFCI.

Author: dyung Date: Fri Sep 13 15:12:27 2019 New Revision: 371904 URL: http://llvm.org/viewvc/llvm-project?rev=371904=rev Log: Make test check position independent as they sometimes come out reversed. NFCI. Modified: cfe/trunk/test/Index/crash-recovery-modules.m Modified:

[PATCH] D67091: Fix for headers having the same name as a directory

This revision was automatically updated to reflect the committed changes. Closed by commit rL371903: [clang-scan-deps] Fix for headers having the same name as a directory (authored by arphaman, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D67573: Fix __atomic_is_lock_free's return type.

jyknight created this revision. jyknight added a reviewer: rsmith. Herald added subscribers: cfe-commits, jfb, kristof.beyls. Herald added a project: clang. It is specified to return a bool in GCC's documentation and implementation, but the clang builtin says it returns an int. This would be

[PATCH] D67567: New ClangTidy check to warn when storing dispatch_once_t in non-static, non-global storage

benhamilton added a comment. It definitely shouldn't be in an `osx` directory since it's available on iOS and other Darwin-like operating systems. Probably `darwin` would be OK. Adding a new subdirectory isn't trivial, there's a lot of places to update last I looked. Should we tackle moving

[PATCH] D67567: New ClangTidy check to warn when storing dispatch_once_t in non-static, non-global storage

lebedev.ri added a comment. In D67567#1670017 , @mwyman wrote: > In D67567#1669866 , @lebedev.ri > wrote: > > > 1. Please split each check into separate review. > > 2. Is `dispatch_once_t` OSX-specific thing?

[PATCH] D67567: New ClangTidy check to warn when storing dispatch_once_t in non-static, non-global storage

mwyman added a comment. In D67567#1669866 , @lebedev.ri wrote: > 1. Please split each check into separate review. > 2. Is `dispatch_once_t` OSX-specific thing? Should those checks be in `osx` > module? 1. I split the review. 2. I don't see an `osx`

[PATCH] D67567: New ClangTidy checks to warn when storing dispatch_once_t in non-static, non-global storage

mwyman updated this revision to Diff 220169. mwyman retitled this revision from "New ClangTidy checks to warn about misusing dispatch_once_t" to "New ClangTidy checks to warn when storing dispatch_once_t in non-static, non-global storage". mwyman added a comment. Moved the assignment check to a

r371897 - Fix test to use %t for newly created files.

Author: timshen Date: Fri Sep 13 14:06:47 2019 New Revision: 371897 URL: http://llvm.org/viewvc/llvm-project?rev=371897=rev Log: Fix test to use %t for newly created files. This is both for consistency with other `mkdir`s in tests, and fixing permission issues with the non-temporary cwd during

[PATCH] D67559: [Sema] Split of versions of -Wimplicit-{float,int}-conversion for Objective-C BOOL

aaron.ballman added a comment. Mostly LGTM but a few nits. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:65 +def ObjCSignedCharBoolImplicitIntConversion : + DiagGroup<"objc-signed-char-bool-implicit-int-conversion">; +def ImplicitIntConversion :

r371892 - [OPENMP5.0]Add basic support for declare variant directive.

Author: abataev Date: Fri Sep 13 13:18:17 2019 New Revision: 371892 URL: http://llvm.org/viewvc/llvm-project?rev=371892=rev Log: [OPENMP5.0]Add basic support for declare variant directive. Added basic support for declare variant directive and its match clause with user context selector. Added:

[PATCH] D67509: [CUDA][HIP] Diagnose defaulted constructor only if it is used

yaxunl added a comment. Sorry I found some issue with the fix. The following code: struct A { virtual ~A(); }; struct B: public A { B(); }; B::B() = default; will cause B::B() with external linkage emitted in IR, since `B::B() = default;` is a function definition. This somehow defeats

[PATCH] D66982: [Modules][Objective-C] Use complete decl from module when diagnosing missing import

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66982/new/ https://reviews.llvm.org/D66982

[clang-tools-extra] r371890 - [Support] Add overload writeFileAtomically(std::function Writer)

Author: jkorous Date: Fri Sep 13 13:08:27 2019 New Revision: 371890 URL: http://llvm.org/viewvc/llvm-project?rev=371890=rev Log: [Support] Add overload writeFileAtomically(std::function Writer) Differential Revision: https://reviews.llvm.org/D67424 Modified:

r371890 - [Support] Add overload writeFileAtomically(std::function Writer)

Author: jkorous Date: Fri Sep 13 13:08:27 2019 New Revision: 371890 URL: http://llvm.org/viewvc/llvm-project?rev=371890=rev Log: [Support] Add overload writeFileAtomically(std::function Writer) Differential Revision: https://reviews.llvm.org/D67424 Modified:

[PATCH] D67091: Fix for headers having the same name as a directory

arphaman added a comment. Sure, I can do that today. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67091/new/ https://reviews.llvm.org/D67091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D67091: Fix for headers having the same name as a directory

kousikk added a comment. I don't have commit access - do you mind submitting this for me? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67091/new/ https://reviews.llvm.org/D67091 ___

[PATCH] D67399: [ARM] Follow AACPS standard for volatile bitfields

rjmccall added a comment. In D67399#1669568 , @jfb wrote: > In D67399#1669038 , @dnsampaio wrote: > > > Indeed our main concern is regarding the access widths of loads. As > > mentioned by @rjmccall, most volatile

[PATCH] D67249: [Modules][PCH] Hash input files content

bruno added a comment. > Did you try xxHash64? No, and I'm not planning to. I believe `hash_code` is enough here, already has low overhead on performance and size, and bunch of prior use elsewhere in LLVM/Clang. If there's a strong reason to do it I wanna know why that's the case first.

[PATCH] D66982: [Modules][Objective-C] Use complete decl from module when diagnosing missing import

bruno added a comment. Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66982/new/ https://reviews.llvm.org/D66982 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D67091: Fix for headers having the same name as a directory

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM, Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67091/new/ https://reviews.llvm.org/D67091

[PATCH] D67567: New ClangTidy checks to warn about misusing dispatch_once_t

lebedev.ri added a comment. 1. Please split each check into separate review. 2. Is `dispatch_once_t` OSX-specific thing? Should those checks be in `osx` module? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67567/new/

[PATCH] D67567: New ClangTidy checks to warn about misusing dispatch_once_t

mwyman created this revision. mwyman added reviewers: benhamilton, hokein, stephanemoore. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. Adds two new ClangTidy checks: - misc-dispatch-once-assignment: warns about assignment to a dispatch_once_t variable. In code

[PATCH] D67135: [clang-tidy] performance-inefficient-vector-operation: Support proto repeated field

congliu added a comment. Could someone commit this for me? I failed to commit this change... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67135/new/ https://reviews.llvm.org/D67135 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D67368: [NFCI]Create CommonAttributeInfo Type as base type of *Attr and ParsedAttr.

erichkeane added a comment. In D67368#1669818 , @plotfi wrote: > I think this change might be breaking builds: > http://lab.llvm.org:8011/builders/clang-aarch64-linux-build-cache/builds/16888 Yep! I fixed it in r371876. Repository: rL LLVM CHANGES

[PATCH] D67368: [NFCI]Create CommonAttributeInfo Type as base type of *Attr and ParsedAttr.

plotfi added a comment. I think this change might be breaking builds: http://lab.llvm.org:8011/builders/clang-aarch64-linux-build-cache/builds/16888 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67368/new/ https://reviews.llvm.org/D67368

[PATCH] D67368: [NFCI]Create CommonAttributeInfo Type as base type of *Attr and ParsedAttr.

plotfi added a comment. I think this change might be breaking builds: Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67368/new/ https://reviews.llvm.org/D67368 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r371878 - Reland r371785: Add -Wpoison-system-directories warning

Author: manojgupta Date: Fri Sep 13 11:00:51 2019 New Revision: 371878 URL: http://llvm.org/viewvc/llvm-project?rev=371878=rev Log: Reland r371785: Add -Wpoison-system-directories warning When using clang as a cross-compiler, we should not use system headers to do the compilation. This CL adds

r371876 - Fix build error in 371875

Author: erichkeane Date: Fri Sep 13 10:56:38 2019 New Revision: 371876 URL: http://llvm.org/viewvc/llvm-project?rev=371876=rev Log: Fix build error in 371875 Apparently Clang complains about the name hiding here in a way that my GCC build does not, so a shocking number of buildbots decided to

[PATCH] D67559: [Sema] Split of versions of -Wimplicit-{float,int}-conversion for Objective-C BOOL

steven_wu added a comment. The diagnostics message looks good to me. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67559/new/ https://reviews.llvm.org/D67559 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

martong added a comment. I have reorganized the tests to group the ones which test ODR violation strategy independent behaviour. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66951/new/ https://reviews.llvm.org/D66951

[PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

martong updated this revision to Diff 220130. martong added a comment. - Reorganize ODRStrategy independent behaviour tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66951/new/ https://reviews.llvm.org/D66951 Files:

[PATCH] D65043: [Format] Add C++20 standard to style options

Quuxplusone added a comment. In D65043#1669410 , @sammccall wrote: > (For actual coroutine support, treating `co_return` and `co_yield` like > `return` everywhere might make sense) I agree, with one nit. `co_return` should be treated like `return`, but

[PATCH] D67414: [AST] Treat "inline gnu_inline" the same way as "extern inline gnu_inline" in C++ mode

tra added inline comments. Comment at: clang/test/SemaCUDA/gnu-inline.cu:8 void foo(); -inline __attribute__((gnu_inline)) void bar() { foo(); } +inline __attribute__((gnu_inline)) void bar() { foo(); } // expected-warning {{'gnu_inline' attribute without 'extern' in C++

[PATCH] D67414: [AST] Treat "inline gnu_inline" the same way as "extern inline gnu_inline" in C++ mode

mstorsjo marked an inline comment as done. mstorsjo added inline comments. Comment at: clang/test/SemaCUDA/gnu-inline.cu:8 void foo(); -inline __attribute__((gnu_inline)) void bar() { foo(); } +inline __attribute__((gnu_inline)) void bar() { foo(); } // expected-warning

[PATCH] D65917: [clang-tidy] Added check for the Google style guide's category method naming rule.

dgatwood updated this revision to Diff 220123. dgatwood added a comment. Switched to objcMethodDecl(hasDeclContext(objcCategoryDecl())). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65917/new/ https://reviews.llvm.org/D65917 Files: clang-tools-extra/clang-tidy/google/CMakeLists.txt

[PATCH] D67559: [Sema] Split of versions of -Wimplicit-{float,int}-conversion for Objective-C BOOL

erik.pilkington created this revision. erik.pilkington added reviewers: rjmccall, steven_wu, aaron.ballman. Herald added subscribers: ributzka, dexonsmith, jkorous. Herald added a project: clang. Also, add a diagnostic group, -Wobjc-signed-char-bool, to control all these related diagnostics.

[PATCH] D67368: [NFCI]Create CommonAttributeInfo Type as base type of *Attr and ParsedAttr.

aaron.ballman accepted this revision. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Thank you for this refactoring -- it was large, but I think the results from it are really good. Comment

[PATCH] D67399: [ARM] Follow AACPS standard for volatile bitfields

jfb added a comment. In D67399#1669038 , @dnsampaio wrote: > Indeed our main concern is regarding the access widths of loads. As mentioned > by @rjmccall, most volatile bitfields are used to perform memory mapped I/O, > and some hardware only support

[PATCH] D65044: [Format] Add option to enable coroutines keywords

modocache abandoned this revision. modocache added a comment. I work on a C++17 codebase with coroutines enabled, but yes just formatting the codebase as if it were C++20 seems fine. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65044/new/

[PATCH] D65043: [Format] Add C++20 standard to style options

modocache abandoned this revision. modocache added a comment. Oh, thank you! Yes, I had been meaning to abandon this and my other patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65043/new/ https://reviews.llvm.org/D65043

[PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

martong marked 3 inline comments as done. martong added inline comments. Comment at: clang/unittests/AST/ASTImporterODRStrategiesTest.cpp:118 + template + constexpr T X; + )"; shafik wrote: > shafik wrote: > > Note this is not well-formed b/c it

[PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

martong updated this revision to Diff 220104. martong marked an inline comment as done. martong added a comment. - Initialize the variable template in test - Clean up tests for fun templates and for specializations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D67515: [Sema][Typo Correction] Fix potential infite loop on ambiguity checks

This revision was automatically updated to reflect the committed changes. Closed by commit rL371859: [Sema][Typo Correction] Fix potential infite loop on ambiguity checks (authored by dgoldman, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository:

[PATCH] D67358: [clangd] Implement semantic selections.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice! Please make sure you run clang-format (I think it'll add missing newlines at EOF) Comment at: clang-tools-extra/clangd/SemanticSelection.cpp:22 +// Assumes

r371859 - [Sema][Typo Correction] Fix potential infite loop on ambiguity checks

Author: dgoldman Date: Fri Sep 13 07:43:24 2019 New Revision: 371859 URL: http://llvm.org/viewvc/llvm-project?rev=371859=rev Log: [Sema][Typo Correction] Fix potential infite loop on ambiguity checks Summary: This fixes a bug introduced in D62648, where Clang could infinite loop if it became

[PATCH] D67515: [Sema][Typo Correction] Fix potential infite loop on ambiguity checks

dgoldman updated this revision to Diff 220097. dgoldman added a comment. - Fix typo in test Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67515/new/ https://reviews.llvm.org/D67515 Files: lib/Sema/SemaExprCXX.cpp test/Sema/typo-correction-ambiguity.cpp

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

sammccall added a comment. Rather than a separate method with parallel implementation, this seems very closely related to the syntax highlighting feature. The minimal way to model this (no new protocol) would be for each disabled line, to add one token spanning the whole line with a TextMate

[PATCH] D65043: [Format] Add C++20 standard to style options

sammccall added a comment. Not sure if this patch is still live? I implemented the suggestion from the last round in D67541 . I didn't add the coroutine tests, as clang-format doesn't seem to get any coroutine cases right in 20 mode that it missed in 17 mode.

[PATCH] D67551: [AArch64][SVE] Implement sdot and udot (lane) intrinsics

kmclaughlin created this revision. kmclaughlin added reviewers: sdesmalen, SjoerdMeijer, greened. Herald added subscribers: psnobl, rkruppe, kristof.beyls, tschuett. Herald added a reviewer: rengolin. kmclaughlin added a parent revision: D67549: [IntrinsicEmitter] Add overloaded types for SVE

[PATCH] D67550: [AArch64][SVE] Implement unpack intrinsics

kmclaughlin created this revision. kmclaughlin added reviewers: sdesmalen, SjoerdMeijer, greened. Herald added subscribers: psnobl, rkruppe, kristof.beyls, tschuett. Herald added a reviewer: rengolin. kmclaughlin added a parent revision: D67549: [IntrinsicEmitter] Add overloaded types for SVE

[PATCH] D67549: [IntrinsicEmitter] Add overloaded types for SVE intrinsics (Subdivide2 & Subdivide4)

kmclaughlin created this revision. kmclaughlin added reviewers: sdesmalen, SjoerdMeijer, greened. Herald added subscribers: jdoerfert, tschuett. Herald added a project: LLVM. Both match the type of another intrinsic parameter of a vector type, but where each element is subdivided to form a

[PATCH] D67246: clang-format: Add support for formatting lambdas with explicit template parameters.

This revision was automatically updated to reflect the committed changes. Closed by commit rG41f4d68a50be: clang-format: Add support for formatting (some) lambdas with explicit template… (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE

r371854 - clang-format: Add support for formatting (some) lambdas with explicit template parameters.

Author: nico Date: Fri Sep 13 06:18:55 2019 New Revision: 371854 URL: http://llvm.org/viewvc/llvm-project?rev=371854=rev Log: clang-format: Add support for formatting (some) lambdas with explicit template parameters. This patch makes cases work where the lambda's template list doesn't contain

[PATCH] D67542: Fix depfile name construction

This revision was automatically updated to reflect the committed changes. Closed by commit rL371853: Fix depfile name construction (authored by LukeCheeseman, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r371853 - Fix depfile name construction

Author: lukecheeseman Date: Fri Sep 13 06:15:35 2019 New Revision: 371853 URL: http://llvm.org/viewvc/llvm-project?rev=371853=rev Log: Fix depfile name construction - When using -o, the provided filename is using for constructing the depfile name (when -MMD is passed). - The logic looks for

[PATCH] D66336: [ASTImporter] Add development internals docs

This revision was automatically updated to reflect the committed changes. Closed by commit rL371839: [ASTImporter] Add development internals docs (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r371839 - [ASTImporter] Add development internals docs

Author: martong Date: Fri Sep 13 04:21:52 2019 New Revision: 371839 URL: http://llvm.org/viewvc/llvm-project?rev=371839=rev Log: [ASTImporter] Add development internals docs Reviewers: a_sidorin, shafik, teemperor, gamesh411, balazske, dkrupp, a.sidorin Subscribers: rnkovacs, Szelethus,

[PATCH] D67358: [clangd] Implement semantic selections.

usaxena95 updated this revision to Diff 220075. usaxena95 added a comment. Remove extraneous namespace comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67358/new/ https://reviews.llvm.org/D67358 Files:

[PATCH] D67545: [clang-tidy] Added DefaultOperatorNewCheck.

balazske created this revision. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dexonsmith, steven_wu, dkrupp, xazax.hun, inglorion, mgorny, mehdi_amini. Herald added a project: clang. Added new checker 'cert-default-operator-new' that checks for CERT rule MEM57-CPP. Simple version.

[PATCH] D67358: [clangd] Implement semantic selections.

usaxena95 updated this revision to Diff 220074. usaxena95 added a comment. Minor changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67358/new/ https://reviews.llvm.org/D67358 Files: clang-tools-extra/clangd/CMakeLists.txt

[PATCH] D67358: [clangd] Implement semantic selections.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/SemanticSelection.cpp:33 + if (!Offset) { +llvm::errs() << "Unable to convert postion to offset"; +return {}; sammccall wrote: > we use log() or elog() for this, make sure you include

[PATCH] D67358: [clangd] Implement semantic selections.

usaxena95 updated this revision to Diff 220071. usaxena95 marked 13 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67358/new/ https://reviews.llvm.org/D67358 Files:

[libclc] r371837 - Creating release candidate rc5 from release_900 branch

Author: hans Date: Fri Sep 13 03:45:50 2019 New Revision: 371837 URL: http://llvm.org/viewvc/llvm-project?rev=371837=rev Log: Creating release candidate rc5 from release_900 branch Added: libclc/tags/RELEASE_900/rc5/ - copied from r371836, libclc/branches/release_90/

[libunwind] r371837 - Creating release candidate rc5 from release_900 branch

Author: hans Date: Fri Sep 13 03:45:50 2019 New Revision: 371837 URL: http://llvm.org/viewvc/llvm-project?rev=371837=rev Log: Creating release candidate rc5 from release_900 branch Added: libunwind/tags/RELEASE_900/rc5/ - copied from r371836, libunwind/branches/release_90/

[PATCH] D67542: Fix depfile name construction

chill accepted this revision. chill added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67542/new/ https://reviews.llvm.org/D67542 ___ cfe-commits mailing list

[PATCH] D67543: [Clang][ASTImporter] Added visibility check for ClassTemplateDecl.

balazske created this revision. Herald added subscribers: cfe-commits, teemperor, gamesh411, Szelethus, dkrupp. Herald added a reviewer: martong. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. ASTImporter makes now difference between class

[PATCH] D67414: [AST] Treat "inline gnu_inline" the same way as "extern inline gnu_inline" in C++ mode

mstorsjo marked an inline comment as done. mstorsjo added inline comments. Comment at: clang/lib/AST/Decl.cpp:3334 /// For an inline function definition in C, or for a gnu_inline function /// in C++, determine whether the definition will be externally visible. ///

[PATCH] D67414: [AST] Treat "inline gnu_inline" the same way as "extern inline gnu_inline" in C++ mode

mstorsjo updated this revision to Diff 220053. mstorsjo added a comment. Adapted based on the feedback so far, suggestions on naming and grouping the warning are welcome. The warning did trigger in an existing CUDA test as well - I'm not familiar with cuda and how it relates to other

[PATCH] D67542: Fix depfile name construction

LukeCheeseman updated this revision to Diff 220067. LukeCheeseman added a comment. - Add a requires shell CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67542/new/ https://reviews.llvm.org/D67542 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/metadata-with-dots.c

[PATCH] D67541: [ClangFormat] Future-proof Standard option, allow floating or pinning to arbitrary lang version

sammccall updated this revision to Diff 220066. sammccall added a comment. Add fairly contrived test that demonstrates the difference between c++17 and latest (20) parsing mode. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67541/new/

[PATCH] D67542: Fix depfile name construction

chill added a reviewer: chill. chill added inline comments. Comment at: clang/test/Driver/metadata-with-dots.c:2 +// RUN: mkdir -p out.dir +// RUN: cat %s > out.dir/test.c +// RUN: %clang -E -MMD %s -o out.dir/test Is this going to ruin on Windows ?

[PATCH] D67541: [ClangFormat] Future-proof Standard option, allow floating or pinning to arbitrary lang version

sammccall created this revision. sammccall added reviewers: klimek, modocache. Herald added a project: clang. Herald added a subscriber: cfe-commits. The historical context: - clang-format was written when C++11 was current, and the main language-version concern was >> vs > > template-closers.

r371832 - Fix a perl warning: Scalar value @ArgParts[0] better written as $ArgParts[0] at /usr/share/clang/scan-build-10/libexec/ccc-analyzer line 502.

Author: sylvestre Date: Fri Sep 13 02:31:19 2019 New Revision: 371832 URL: http://llvm.org/viewvc/llvm-project?rev=371832=rev Log: Fix a perl warning: Scalar value @ArgParts[0] better written as $ArgParts[0] at /usr/share/clang/scan-build-10/libexec/ccc-analyzer line 502. Modified:

[PATCH] D67135: [clang-tidy] performance-inefficient-vector-operation: Support proto repeated field

hokein accepted this revision. hokein added a comment. feel free to commit the patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67135/new/ https://reviews.llvm.org/D67135 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D66653: [clang-format] Turn include regrouping on for Google ObjC style

krasimir abandoned this revision. krasimir added a comment. This was for experimental purposes, abandoning. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66653/new/ https://reviews.llvm.org/D66653 ___ cfe-commits

[PATCH] D67399: [ARM] Follow AACPS standard for volatile bitfields

dnsampaio added a comment. Indeed our main concern is regarding the access widths of loads. As mentioned by @rjmccall, most volatile bitfields are used to perform memory mapped I/O, and some hardware only support them with a specific access width. The spurious load I am more than glad to leave

[PATCH] D67246: clang-format: Add support for formatting lambdas with explicit template parameters.

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. This looks good with the FIXME. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67246/new/ https://reviews.llvm.org/D67246 ___

[PATCH] D64146: [Clang Interpreter] Initial patch for the constexpr interpreter

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. Accepting this to remove the block Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64146/new/ https://reviews.llvm.org/D64146

[PATCH] D67405: Make FormatToken::Type private.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. This looks fine as it is, adding a side-effect to a function that's called `setType` and is called in lots of places may be hard to reason about. You haven't mentioned how the

[PATCH] D67160: [clang, ARM] Default to -fno-lax-vector-conversions in ARM v8.1-M.

dmgreen added a comment. FYI: rL371817 , in case it changes what is done here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67160/new/ https://reviews.llvm.org/D67160

Re: r371766 - [Clang][CodeGen] support alias attribute w/ gnu_inline

Merged to release_90 in r371821. On Thu, Sep 12, 2019 at 9:51 PM Nick Desaulniers via cfe-commits wrote: > > Author: nickdesaulniers > Date: Thu Sep 12 12:53:35 2019 > New Revision: 371766 > > URL: http://llvm.org/viewvc/llvm-project?rev=371766=rev > Log: > [Clang][CodeGen] support alias

[PATCH] D67490: [Clang][ASTImporter] Added visibility check for FunctionTemplateDecl.

This revision was automatically updated to reflect the committed changes. Closed by commit rL371820: [Clang][ASTImporter] Added visibility check for FunctionTemplateDecl. (authored by balazske, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

r371820 - [Clang][ASTImporter] Added visibility check for FunctionTemplateDecl.

Author: balazske Date: Fri Sep 13 01:03:49 2019 New Revision: 371820 URL: http://llvm.org/viewvc/llvm-project?rev=371820=rev Log: [Clang][ASTImporter] Added visibility check for FunctionTemplateDecl. Summary: ASTImporter makes now difference between function templates with same name in different

[PATCH] D61717: Fix arm_neon.h to be clean under -fno-lax-vector-conversions.

SjoerdMeijer added a comment. Yeah, sorry about that Do you perhaps have a test case or error that I can look at? Perhaps I or someone else here can help out a bit here. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61717/new/

  1   2   >