[PATCH] D66990: [clangd] Add distinct highlightings for declarations of functions and methods

nridge added a comment. Herald added a subscriber: usaxena95. In D66990#1656230 , @nridge wrote: > >> I think the way cquery does it > >>

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

nridge added a comment. The updated patch formulates this as a new semantic highlighting kind. The tokens created for inactive regions are one per line, with the character offset and length being zero; the idea is that the client will handle this highlighting specially (see D67537

[PATCH] D67537: [WIP] [clangd] Client-side support for inactive regions

nridge updated this revision to Diff 222337. nridge added a comment. Herald added a subscriber: usaxena95. Update to reflect changes to server side in D67536 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

nridge updated this revision to Diff 222336. nridge added a comment. Herald added subscribers: usaxena95, mgrang. Reformulate as an extension to semantic highlighting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67536/new/

[PATCH] D65543: [Windows] Autolink with basenames and add libdir to libpath

thakis added a comment. If you strongly feel that this is the right direction, go for it, you're code owner here :) To me, this feels like a regression. This change has no benefit that I can see (at least none that anybody's asked for that I'm aware of – then again I read llvm's bugzilla less

[PATCH] D68148: [clang-tidy] Rename objc-avoid-spinlock check to darwin-avoid-spinlock

stephanemoore accepted this revision. stephanemoore added a comment. This revision is now accepted and ready to land. I wasn't sure what the policy is for renaming checks so I dug into previous check renames. https://reviews.llvm.org/D43867 seems to indicate that it's acceptable for checks to

[PATCH] D67161: [clang,ARM] Initial ACLE intrinsics for MVE.

dmgreen added a comment. Sorry. I wasn't ignoring this (sort-of), I just knew that you were on holiday and this is a bit of a big one. But I like this. I still have to take a deeper look into the main tablegen parts, but it looks very powerful. I presume from here adding new intrinsics is

r373173 - Don't crash if a variable with a constexpr destructor has a

Author: rsmith Date: Sun Sep 29 13:30:13 2019 New Revision: 373173 URL: http://llvm.org/viewvc/llvm-project?rev=373173=rev Log: Don't crash if a variable with a constexpr destructor has a value-dependent initializer. Modified: cfe/trunk/lib/Sema/SemaDeclCXX.cpp

[PATCH] D64671: [clang-tidy] New check: misc-init-local-variables

jpakkane updated this revision to Diff 222335. jpakkane added a comment. Rebased against master to fix a merge conflict in release notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64671/new/ https://reviews.llvm.org/D64671 Files:

[PATCH] D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154)

nridge added a comment. I do feel strongly that types and non-types should be highlighted differently, so the updated patch adds two new dependent highlightings, one for types and one for variables/functions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154)

nridge updated this revision to Diff 222333. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67901/new/ https://reviews.llvm.org/D67901 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp

[PATCH] D68185: [Diagnostics] Warn when class implements a copy constructor/copy assignment operator, but missing the copy assignment operator/copy constructor

xbolva00 abandoned this revision. xbolva00 added a comment. Yeah, if we want to check rule of 3, clang-tidy is better choice. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68185/new/ https://reviews.llvm.org/D68185 ___ cfe-commits mailing

[PATCH] D68076: [AArch64] Enable unwind tables by default for Gnu targets

hiraditya added a comment. Can we add a test to verify cfi instructions are present without debug flag. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68076/new/ https://reviews.llvm.org/D68076 ___ cfe-commits

[PATCH] D68185: [Diagnostics] Warn when class implements a copy constructor/copy assignment operator, but missing the copy assignment operator/copy constructor

thakis added a comment. Since https://en.cppreference.com/w/cpp/language/rule_of_three says "almost always" (note "almost") I'd say this probably belongs more in clang-tidy territory – I'm guessing false positive rate is very high for this. Can you collect some true / false positive statistics

[PATCH] D68074: [clang-tidy] Add readability-make-member-function-const

mgehre added a comment. In D68074#1683770 , @lebedev.ri wrote: > Awesome! > I believe i have asked this question in the convert-to-static diff - can > ExprMutAnalyzer be used here? I believe in this case, we can get away with a simpler analysis.

[PATCH] D68074: [clang-tidy] Add readability-make-member-function-const

mgehre updated this revision to Diff 222331. mgehre marked 6 inline comments as done. mgehre added a comment. - Implement review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68074/new/ https://reviews.llvm.org/D68074 Files:

[PATCH] D53514: os_log: make buffer size an integer constant expression.

hiraditya closed this revision. hiraditya added a comment. Herald added a project: clang. closed in r345828, 314fbfa1c4c6665c54a220eefb10a6f23010a352 Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D57265: [PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting

fhahn added a comment. This seems fine to me. IIUC the only potential drawback with the old pass manager is that we potentially have to run the required passes unconditionally, even if we do not use them. Vedant, did you have a chance to check the impact on overall compile time?

[PATCH] D68193: In openFileForRead don't cache erroneous entries if the error relates to them being directories. Add tests.

kousikk created this revision. kousikk added a reviewer: arphaman. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. It seems that when the CachingFileSystem is first given a file to open that is actually a directory, it incorrectly caches that path to be errenous

[PATCH] D57265: [PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting

hiraditya added a comment. it will be great to merge this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57265/new/ https://reviews.llvm.org/D57265 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D68072: [clang-format] Reference qualifiers in member templates causing extra indentation.

This revision was automatically updated to reflect the committed changes. Closed by commit rL373165: [clang-format] Reference qualifiers in member templates causing extra… (authored by paulhoad, committed by ). Changed prior to commit: https://reviews.llvm.org/D68072?vs=99=222322#toc

r373165 - [clang-format] Reference qualifiers in member templates causing extra indentation.

Author: paulhoad Date: Sun Sep 29 06:45:38 2019 New Revision: 373165 URL: http://llvm.org/viewvc/llvm-project?rev=373165=rev Log: [clang-format] Reference qualifiers in member templates causing extra indentation. Summary: The following code ``` struct f { template void bar() && noexcept

[PATCH] D68072: [clang-format] Reference qualifiers in member templates causing extra indentation.

AndWass marked 2 inline comments as done. AndWass added a comment. Thanks! @MyDeveloperDay could you commit as well? Don't have access for that yet CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68072/new/ https://reviews.llvm.org/D68072

[PATCH] D68072: [clang-format] Reference qualifiers in member templates causing extra indentation.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68072/new/ https://reviews.llvm.org/D68072 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r373162 - [cxx_status] Mark P0784R7 as partially complete.

Author: rsmith Date: Sun Sep 29 00:16:13 2019 New Revision: 373162 URL: http://llvm.org/viewvc/llvm-project?rev=373162=rev Log: [cxx_status] Mark P0784R7 as partially complete. Modified: cfe/trunk/www/cxx_status.html Modified: cfe/trunk/www/cxx_status.html URL:

[PATCH] D60748: Fix i386 struct and union parameter alignment

LiuChen3 added a comment. In D60748#1681178 , @kib wrote: > In fact, can we have an option controlling this ? Does it have anything to > do with -malign-data gcc switch ? > > We do want to be able to optionally generate code ABI-compatible with modern

r373161 - For now, disallow lifetime-extended temporaries with non-trivial (but

Author: rsmith Date: Sat Sep 28 23:22:54 2019 New Revision: 373161 URL: http://llvm.org/viewvc/llvm-project?rev=373161=rev Log: For now, disallow lifetime-extended temporaries with non-trivial (but constexpr) destructors from being used in the values of constexpr variables. The standard rules