[PATCH] D68914: [clang-format] Remove duplciate code from Invalid BOM detection

klimek added inline comments. Comment at: clang/include/clang/Basic/SourceManager.h:232 +// nullptr +static const char *getInvalidBOM(StringRef BufStr); }; owenpan wrote: > Can you make the parameter `const`? StringRef is inherently const though,

[PATCH] D66733: [analyzer] Add a checker option to detect nested dead stores

sylvestre.ledru added a comment. It now shows for the llvm toolchain: http://llvm.org/reports/scan-build/ Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66733/new/ https://reviews.llvm.org/D66733 ___ cfe-commits

[PATCH] D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154)

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks, looks great now! Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:41 + if (auto *TD = dyn_cast(D)) { +if (auto *Templated = TD->getTemplatedDecl())

[PATCH] D68682: Clang-tidy fix removals removing all non-blank text from a line should remove the line

alexfh added a comment. In D68682#1706581 , @poelmanc wrote: > Thanks, from the name that sounds like the perfect place to do it. If > `cleanupAroundReplacements` also is used by clang-format, would we want to > make the functionality optional, e.g. via

[PATCH] D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154)

ilya-biryukov added a comment. LGTM from my side, but not marking as accepted yet to make sure @hokein has a chance to take a final look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67901/new/ https://reviews.llvm.org/D67901

Re: [llvm-dev] Attention bot owners

Hi Galina, Thanks for the heads up. On Fri, 11 Oct 2019 at 21:09, Galina Kistanova via llvm-dev wrote: > > Hello all bots owners, > > As all of you know we move to github monorepo very soon now. > We are actively working on the buildbot to prepare a solution to switch from > SVN to github when

[PATCH] D66199: [docs] loop pragmas

This revision was automatically updated to reflect the committed changes. Closed by commit rG52bfa73af841: [docs] loop pragmas: options implying transformations (authored by SjoerdMeijer). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

r374756 - [docs] loop pragmas: options implying transformations

Author: sjoerdmeijer Date: Mon Oct 14 00:40:36 2019 New Revision: 374756 URL: http://llvm.org/viewvc/llvm-project?rev=374756=rev Log: [docs] loop pragmas: options implying transformations Following our discussion on the cfe dev list:

<    1   2