[PATCH] D67787: Add 8548 CPU definition and attributes

jhibbits updated this revision to Diff 226529. jhibbits added a comment. Make 8548 actually denote e500 LLVM target, add SPE checks to 8548 preprocessor test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67787/new/

[PATCH] D69292: Proposal to add -Wtautological-compare to -Wall

thakis added a comment. This is imho basic enough that it doesn't need a test. A test for this doesn't add any value that I can see. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69292/new/ https://reviews.llvm.org/D69292 ___ cfe-commits

[PATCH] D69308: [analyzer] Test cases for the unsupported features for Clang Static Analyzer

NoQ added a comment. Thanks for the tests! Both of these features are relatively hard. Operator `new[]` requires invoking multiple (potentially unknown) amount of constructors with the same construct-expression. Apart from the technical difficulties of juggling program points around correctly

[clang] edb1a1d - Reland "[Clang][Bundler] Error reporting improvements"

Author: Sergey Dmitriev Date: 2019-10-25T19:00:06-07:00 New Revision: edb1a1de1b79c190ed7b76cf889a295c72e73729 URL: https://github.com/llvm/llvm-project/commit/edb1a1de1b79c190ed7b76cf889a295c72e73729 DIFF:

[PATCH] D68725: [analyzer] MemoryBlockRegion: Generalize AllocaRegion

NoQ added a comment. > This patch generalizes the `AllocaRegion` to store metadata about the > expression of the allocation of a memory block. Mmm, but you can easily obtain that expression from the existing `AllocaRegion`. I.e., you can obtain the expression on which the memory was

[clang] 93b29d3 - Revert "[Clang][Bundler] Error reporting improvements"

Author: Sergey Dmitriev Date: 2019-10-25T17:57:55-07:00 New Revision: 93b29d3882baf7df42e4e9bc26b977b00373ef56 URL: https://github.com/llvm/llvm-project/commit/93b29d3882baf7df42e4e9bc26b977b00373ef56 DIFF:

[PATCH] D69292: Proposal to add -Wtautological-compare to -Wall

rtrieu added a comment. In D69292#1718415 , @thakis wrote: > Abstractly this lgtm. Do you have any data on true / false positive rates? Looking at the various warnings in -Wtautological-compare, only -Wtautological-overlap-compare and

[PATCH] D68937: [clangd] Add parameter renaming to define-inline code action

merge_guards_bot added a comment. Build result: fail - 59631 tests passed, 1 failed and 805 were skipped. failed: LLVM.tools/llvm-ar/mri-utf8.test Log files: cmake-log.txt , ninja_check_all-log.txt

[clang] baf91d0 - [NFC] Add a tablegen node for the root of the AST node hierarchies.

Author: John McCall Date: 2019-10-25T16:39:21-07:00 New Revision: baf91d02da6e68c4ee6723ef68911fcd80ece6a5 URL: https://github.com/llvm/llvm-project/commit/baf91d02da6e68c4ee6723ef68911fcd80ece6a5 DIFF: https://github.com/llvm/llvm-project/commit/baf91d02da6e68c4ee6723ef68911fcd80ece6a5.diff

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

This revision was automatically updated to reflect the committed changes. Closed by commit rGdd501045cdea: [Clang][Bundler] Error reporting improvements (authored by sdmitriev). Changed prior to commit: https://reviews.llvm.org/D67031?vs=224726=226521#toc Repository: rG LLVM Github Monorepo

[clang] dd50104 - [Clang][Bundler] Error reporting improvements

Author: Sergey Dmitriev Date: 2019-10-25T16:29:57-07:00 New Revision: dd501045cdea1c80b6788f0266d2a79f8b412eea URL: https://github.com/llvm/llvm-project/commit/dd501045cdea1c80b6788f0266d2a79f8b412eea DIFF:

[PATCH] D68937: [clangd] Add parameter renaming to define-inline code action

kadircet updated this revision to Diff 226517. kadircet marked 4 inline comments as done. kadircet added a comment. - Use findExplicitReferences for decl traversals. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68937/new/

[clang] 8da2056 - [clang][DependencyScanning] 80-col.

Author: Michael Spencer Date: 2019-10-25T15:43:57-07:00 New Revision: 8da20560ab0da11c47d4718712c9c455e71c2b51 URL: https://github.com/llvm/llvm-project/commit/8da20560ab0da11c47d4718712c9c455e71c2b51 DIFF:

[PATCH] D69420: [clang][clang-scan-deps] Add support for extracting full module dependencies.

Bigcheese added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningTool.cpp:94 + +void printDependencies(std::string , StringRef MainFile) { + // Sort the modules by name to get a deterministic order. kousikk wrote: >

[PATCH] D69420: [clang][clang-scan-deps] Add support for extracting full module dependencies.

Bigcheese updated this revision to Diff 226508. Bigcheese marked 3 inline comments as done. Bigcheese added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69420/new/ https://reviews.llvm.org/D69420 Files:

Re: r374288 - Recommit "[Clang] Pragma vectorize_width() implies vectorize(enable)"

@sjoerdmeijer Before recommitting, please re-open the patch review. Michael Am Do., 24. Okt. 2019 um 18:45 Uhr schrieb Jordan Rupprecht : > > Reverted in 6d424a161bf3e52730371da0b9439ed93a8ce406 due to the issue > described here. Should hopefully be a trivial fix forward. > > On Tue, Oct 22,

Re: [PATCH] D69391: Add #pragma clang loop ivdep

What's the motivation of even allowing `#pragma clang loop ivdep(disable)`? It either has no effect or conflicts with other loop hints. Sorry, for not using Phabricator. When I try to submit a comment, I get the following error: You Shall Not Pass: D69391 You do not have permission to edit

[PATCH] D69393: [RFC][DebugInfo] emit user specified address_space in dwarf

probinson added a comment. In D69393#1720816 , @ast wrote: > > The address spaces envisioned by the Linux kernel appear to be more > > informational and not descriptive of hardware characteristics. > > From the kernel pov the `__user` and normal are two

[PATCH] D69433: [clang-format] [NFC] update the documentation in Format.h to allow dump_format_style.py to get a little closer to being correct. (part 2)

MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/docs/tools/dump_format_style.py:175 +val = line.replace(',', '') +pos = val.find(" // ") +if (pos != -1): mitchell-stellar wrote: >

[PATCH] D69433: [clang-format] [NFC] update the documentation in Format.h to allow dump_format_style.py to get a little closer to being correct. (part 2)

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/docs/tools/dump_format_style.py:175 +val = line.replace(',', '') +pos = val.find(" // ") +if (pos != -1): MyDeveloperDay wrote: >

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

ABataev added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:1987-2001 + /// Build a new OpenMP 'defaultmap' clause. + /// + /// By default, performs semantic analysis to build the new OpenMP clause. + /// Subclasses may override this routine to provide

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:1987-2001 + /// Build a new OpenMP 'defaultmap' clause. + /// + /// By default, performs semantic analysis to build the new OpenMP clause. + /// Subclasses may

[PATCH] D69433: [clang-format] [NFC] update the documentation in Format.h to allow dump_format_style.py to get a little closer to being correct. (part 2)

mitchell-stellar added inline comments. Comment at: clang/docs/tools/dump_format_style.py:175 +val = line.replace(',', '') +pos = val.find(" // ") +if (pos != -1): MyDeveloperDay wrote: > mitchell-stellar wrote: > > This seems quite

[PATCH] D69435: [clang-tidy] New checker performance-trivially-destructible-check

AntonBikineev updated this revision to Diff 226475. AntonBikineev marked 2 inline comments as done. AntonBikineev added a comment. Thanks for the suggestions! Addressed some of them. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69435/new/ https://reviews.llvm.org/D69435 Files:

[PATCH] D69435: [clang-tidy] New checker performance-trivially-destructible-check

AntonBikineev marked 9 inline comments as done. AntonBikineev added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/TriviallyDestructibleCheck.cpp:22 + +bool CheckPotentiallyTriviallyDestructible(const CXXDestructorDecl *Dtor) { + if (Dtor->isFirstDecl()

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:137-140 + SourceLocation Loc) { + ImplicitBehavior = IB; + VariableCategory = VC; + SLoc = Loc; Use member initializers in constructors.

[PATCH] D69420: [clang][clang-scan-deps] Add support for extracting full module dependencies.

kousikk added a comment. A few nit comments Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningService.h:34 +/// The format that is output by the dependency scanner. +enum class ScanningFormat { + /// This is the Makefile compatible dep format.

[PATCH] D69391: Add #pragma clang loop ivdep

hfinkel added a comment. This is the same as #pragma clang loop vectorize(assume_safety)? In D69391#1720845 , @xbolva00 wrote: > "#pragma ivdep" should work too (compatibiluty mode with intel, gcc). The semantics are not the same, unfortunately.

[PATCH] D69060: [Sema][Typo Correction] Fix another infinite loop on ambiguity

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG7a2b704bf0cf: [Sema][Typo Correction] Fix another infinite loop on ambiguity (authored by dgoldman). Changed prior to

[PATCH] D69435: [clang-tidy] New checker performance-trivially-destructible-check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/TriviallyDestructibleCheck.cpp:29 + // Check direct base classes. + const auto *RecordDecl = Dtor->getParent(); + for (auto *Field : RecordDecl->fields()) { Please

[clang] 7a2b704 - [Sema][Typo Correction] Fix another infinite loop on ambiguity

Author: David Goldman Date: 2019-10-25T13:20:27-04:00 New Revision: 7a2b704bf0cf65f9eb46fe3668a83b75aa2d80a6 URL: https://github.com/llvm/llvm-project/commit/7a2b704bf0cf65f9eb46fe3668a83b75aa2d80a6 DIFF: https://github.com/llvm/llvm-project/commit/7a2b704bf0cf65f9eb46fe3668a83b75aa2d80a6.diff

[PATCH] D68953: Enable most VFS tests on Windows

amccarth marked 2 inline comments as done. amccarth added a comment. Somehow Phabricator failed to notify me that you'd already left comments. I even searched my inbox to see if I'd just missed the notification. Nope. Nothing. I came here today to ping you for the review and discovered

[clang-tools-extra] 8e567b0 - [clangd] Revert define-inline action changes to un-break windows build-bots

Author: Kadir Cetinkaya Date: 2019-10-25T18:40:01+02:00 New Revision: 8e567b0730fa55d15e6c0ab20b0352d85e96b7bb URL: https://github.com/llvm/llvm-project/commit/8e567b0730fa55d15e6c0ab20b0352d85e96b7bb DIFF:

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:4463-4890 + if (AStmt && !CurContext->isDependentContext()) { assert(isa(AStmt) && "Captured statement expected"); // Check default data sharing attributes for referenced variables.

[PATCH] D69435: [clang-tidy] New checker performance-trivially-destructible-check

lebedev.ri added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/TriviallyDestructibleCheck.cpp:22 + +bool CheckPotentiallyTriviallyDestructible(const CXXDestructorDecl *Dtor) { + if (Dtor->isFirstDecl() || !Dtor->isExplicitlyDefaulted())

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:4463-4890 + if (AStmt && !CurContext->isDependentContext()) { assert(isa(AStmt) && "Captured statement expected"); // Check default data sharing

[PATCH] D69433: [clang-format] [NFC] update the documentation in Format.h to allow dump_format_style.py to get a little closer to being correct. (part 2)

MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/docs/tools/dump_format_style.py:175 +val = line.replace(',', '') +pos = val.find(" // ") +if (pos != -1): mitchell-stellar wrote: >

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:4463-4890 + if (AStmt && !CurContext->isDependentContext()) { assert(isa(AStmt) && "Captured statement expected"); // Check default data sharing attributes for referenced variables.

[PATCH] D69435: [clang-tidy] New checker performance-trivially-destructible-check

AntonBikineev created this revision. AntonBikineev added a reviewer: klimek. AntonBikineev added projects: clang, clang-tools-extra. Herald added subscribers: mgehre, xazax.hun, mgorny. Checks for types which can be made trivially-destructible by removing out-of-line defaulted destructor

[PATCH] D65433: [clangd] DefineInline action availability checks

thakis added a comment. The test fails in Windows: http://45.33.8.238/win/1112/step_7.txt Ptal, and if it takes a while to investigate please revert while you look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65433/new/

[PATCH] D69022: [coroutines] Remove assert on CoroutineParameterMoves in Sema::buildCoroutineParameterMoves

junparser added a subscriber: rjmccall. junparser added a comment. In D69022#1720645 , @rjmccall wrote: > Despite generally knowing about coroutines and generally knowing about Clang, > I actually don't know the Clang coroutine code and can't review this

[PATCH] D69250: [ARM][AArch64] Implement __cls, __clsl and __clsll intrinsics from ACLE

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Thanks for all the adjustments, this looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69250/new/ https://reviews.llvm.org/D69250

[PATCH] D69433: [clang-format] [NFC] update the documentation in Format.h to allow dump_format_style.py to get a little closer to being correct. (part 2)

mitchell-stellar added inline comments. Comment at: clang/docs/tools/dump_format_style.py:175 +val = line.replace(',', '') +pos = val.find(" // ") +if (pos != -1): This seems quite flimsy to me, as it depends on an undocumented comment

[PATCH] D68296: [clang-format] Add ability to wrap braces after multi-line control statements

MyDeveloperDay added inline comments. Comment at: cfe/trunk/docs/ClangFormatStyleOptions.rst:812 + Always wrap braces after a control statement. + + .. code-block:: c++ This text cannot be generated by dump_format_style.py in clang/docs/tools from the

[PATCH] D69250: [ARM][AArch64] Implement __cls, __clsl and __clsll intrinsics from ACLE

vhscampos marked an inline comment as done. vhscampos added a comment. Added support for `__clsll` as requested. Comment at: clang/lib/Headers/arm_acle.h:150 +__clsl(unsigned long __t) { +#if __SIZEOF_LONG__ == 4 + return __builtin_arm_cls(__t); compnerd

[PATCH] D69433: [clang-format] [NFC] update the documentation in Format.h to allow dump_format_style.py to get a little closer to being correct. (part 2)

MyDeveloperDay added a comment. For help for the reviewers...here is the before and after Before: F10399858: image.png After: F10399852: image.png Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D69433: [clang-format] [NFC] update the documentation in Format.h to allow dump_format_style.py to get a little closer to being correct. (part 2)

MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/include/clang/Format/Format.h:1971 + /// be affected. /// \code ///true: false: my assumption here was that the

[PATCH] D69250: [ARM][AArch64] Implement __cls and __clsl intrinsics from ACLE

vhscampos updated this revision to Diff 226430. vhscampos added a comment. Add support for __clsll. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69250/new/ https://reviews.llvm.org/D69250 Files: clang/include/clang/Basic/BuiltinsAArch64.def

[PATCH] D69382: [clangd] Do not insert parentheses when completing a using declaration

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. oops, thought I've LGTM'd it on previous cycle :D Comment at: clang-tools-extra/clangd/CodeComplete.cpp:483 bool EnableFunctionArgSnippets; + bool

[PATCH] D69433: [clang-format] [NFC] update the documentation in Format.h to allow dump_format_style.py to get a little closer to being correct. (part 2)

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: klimek, mitchell-stellar, sammccall. MyDeveloperDay added projects: clang, clang-format. a change D67541: [ClangFormat] Future-proof Standard option, allow floating or pinning to arbitrary lang version

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67031/new/ https://reviews.llvm.org/D67031 ___ cfe-commits mailing list

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:52-74 enum DefaultMapAttributes { - DMA_unspecified, /// Default mapping is not specified. - DMA_tofrom_scalar, /// Default mapping is 'tofrom:scalar'. + DMA_unspecified, /// Default

[PATCH] D69263: [clangd] Implement cross-file rename.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:269 +cat(Features), +desc("Enable cross-file rename feature."), +init(false), Could you document that the feature is highly experimental and may lead to

[PATCH] D69316: [OpenMP 5.0] target update list items need not be contiguous (Sema)

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:14450 + if (HasMeetPointer && !IsLastArraySection) { +SemaRef.Diag(ELoc, diag::err_omp_pointer_type_not_last) Ad the check for the version of OpenMP standard, it must be

[PATCH] D69382: [clangd] Do not insert parentheses when completing a using declaration

merge_guards_bot added a comment. Build result: pass - 59630 tests passed, 0 failed and 763 were skipped. Log files: cmake-log.txt , ninja_check_all-log.txt

[PATCH] D69382: [clangd] Do not insert parentheses when completing a using declaration

ilya-biryukov updated this revision to Diff 226426. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - Rename flag to GenerateSnippets, document it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69382/new/

[PATCH] D69404: [clang-format] [NFC] update the documentation in Format.h to allow dump_format_style.py to get a little closer to being correct.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6df7ef0d8baa: [clang-format] [NFC] update the documentation in Format.h to allow… (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D68391: [RISCV] Improve sysroot computation if no GCC install detected

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. Herald added a subscriber: sameer.abuasal. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68391/new/ https://reviews.llvm.org/D68391

[clang] 6df7ef0 - [clang-format] [NFC] update the documentation in Format.h to allow dump_format_style.py to get a little closer to being correct.

Author: paulhoad Date: 2019-10-25T14:46:19+01:00 New Revision: 6df7ef0d8baac34259e2c93043d843f27812c534 URL: https://github.com/llvm/llvm-project/commit/6df7ef0d8baac34259e2c93043d843f27812c534 DIFF: https://github.com/llvm/llvm-project/commit/6df7ef0d8baac34259e2c93043d843f27812c534.diff

[PATCH] D69356: [NFC] Rename LLVM_NO_DEAD_STRIP

This revision was automatically updated to reflect the committed changes. Closed by commit rG11c2a85db884: [NFC] Rename LLVM_NO_DEAD_STRIP (authored by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69356/new/

[PATCH] D69382: [clangd] Do not insert parentheses when completing a using declaration

kadircet added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:483 bool EnableFunctionArgSnippets; + bool CompleteArgumentList; }; maybe rather use `GenerateSnippets`? Since this doesn't generate completions for the snippets, but

[clang] 11c2a85 - [NFC] Rename LLVM_NO_DEAD_STRIP

Author: David Tenty Date: 2019-10-25T09:32:00-04:00 New Revision: 11c2a85db8849db1a5907e80d9966592248ef825 URL: https://github.com/llvm/llvm-project/commit/11c2a85db8849db1a5907e80d9966592248ef825 DIFF: https://github.com/llvm/llvm-project/commit/11c2a85db8849db1a5907e80d9966592248ef825.diff

[PATCH] D69404: [clang-format] [NFC] update the documentation in Format.h to allow dump_format_style.py to get a little closer to being correct.

mitchell-stellar accepted this revision. mitchell-stellar added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69404/new/ https://reviews.llvm.org/D69404

[PATCH] D69431: [clangd] Do not highlight keywords in semantic highlighting

merge_guards_bot added a comment. Build result: fail - 59585 tests passed, 2 failed and 805 were skipped. failed: Clangd.Clangd/semantic-highlighting.test failed: LLVM.tools/llvm-ar/mri-utf8.test Log files: cmake-log.txt ,

[PATCH] D69382: [clangd] Do not insert parentheses when completing a using declaration

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1466 Output.Completions.back().Score = C.second; Output.Completions.back().CompletionTokenRange = ReplacedRange; } kadircet wrote: > why not handle

Applying fixes in clang 8.0?

Hi all, I am currently running into issues with bug 41810. Now, this is fixed in 9.0, but I need to also support older versions of clang (up to 7.0, which luckily is unaffected). Now, looking through the commit list, it seems that it's commit 08d0c133ccb1b530ed743a021dc5995fbcdaf012 which fixes

[clang-tools-extra] 43e931c - [clangd][NFC] Get rid of raw string literals in macros to make stage1 compiler happy

Author: Kadir Cetinkaya Date: 2019-10-25T15:01:28+02:00 New Revision: 43e931cb5fc1830f6b9250f35d29e1377a66eee6 URL: https://github.com/llvm/llvm-project/commit/43e931cb5fc1830f6b9250f35d29e1377a66eee6 DIFF:

[PATCH] D69431: [clangd] Do not highlight keywords in semantic highlighting

ilya-biryukov created this revision. ilya-biryukov added a reviewer: hokein. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Editors are good at highlightings the keywords themselves. Note that this only affects highlightings of builtin

[clang] 3d9632a - [clang-rename] NFC, make getCanonicalSymbolDeclaration robust on nullptr input.

Author: Haojian Wu Date: 2019-10-25T14:33:04+02:00 New Revision: 3d9632a997fb3d59f0740bb00817b5c6115674cb URL: https://github.com/llvm/llvm-project/commit/3d9632a997fb3d59f0740bb00817b5c6115674cb DIFF: https://github.com/llvm/llvm-project/commit/3d9632a997fb3d59f0740bb00817b5c6115674cb.diff

[PATCH] D69263: [clangd] Implement cross-file rename.

merge_guards_bot added a comment. Build result: fail - 59520 tests passed, 1 failed and 763 were skipped. failed: Clangd.Clangd/rename.test Log files: cmake-log.txt , ninja_check_all-log.txt

[PATCH] D69427: Fix compilation error in clangd/refactor/tweaks/ExpandAutoType.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rGce1e249a688d: Fix compilation error in clangd/refactor/tweaks/ExpandAutoType.cpp (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] ce1e249 - Fix compilation error in clangd/refactor/tweaks/ExpandAutoType.cpp

Author: Kadir Cetinkaya Date: 2019-10-25T14:16:59+02:00 New Revision: ce1e249a688dced25735e38242df561e387b8e2b URL: https://github.com/llvm/llvm-project/commit/ce1e249a688dced25735e38242df561e387b8e2b DIFF:

[PATCH] D69263: [clangd] Implement cross-file rename.

hokein added a comment. In D69263#1718525 , @ilya-biryukov wrote: > Not sure that holds. What if the file in question is being rebuilt right now? > We do not wait until all ASTs are built (and the dynamic index gets the new > results). > Open files

[PATCH] D69263: [clangd] Implement cross-file rename.

hokein updated this revision to Diff 226414. hokein marked 5 inline comments as done. hokein added a comment. - simplify the code, addressing comments; - add unittests; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69263/new/

[PATCH] D69427: Fix compilation error in clangd/refactor/tweaks/ExpandAutoType.cpp

psamolysov added a comment. I have no commit access, can anyone land this small fix, please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69427/new/ https://reviews.llvm.org/D69427 ___ cfe-commits

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

Tyker added a comment. ping @rsmith CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63960/new/ https://reviews.llvm.org/D63960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69427: Fix compilation error in clangd/refactor/tweaks/ExpandAutoType.cpp

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69427/new/ https://reviews.llvm.org/D69427

[PATCH] D32478: [clang-format] Fix AlignOperands when BreakBeforeBinaryOperators is set

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. I've read back through the previous comments, and I'm slightly struggling to understand the reason for the objections. (other than the normal public style) I'd tend to be wary

[PATCH] D69297: [ARM][AArch64] Implement __arm_rsrf, __arm_rsrf64, __arm_wsrf & __arm_wsrf64

vhscampos updated this revision to Diff 226406. vhscampos added a comment. Use __builtin_bit_cast to perform the relevant bitcasts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69297/new/ https://reviews.llvm.org/D69297 Files:

[clang] 11ce19d - [clang] Switch arm-mve-intrinsics tests to use %clang_cc1.

Author: Simon Tatham Date: 2019-10-25T12:00:38+01:00 New Revision: 11ce19d2119e0870b2bf53eb23d215aa83cd5540 URL: https://github.com/llvm/llvm-project/commit/11ce19d2119e0870b2bf53eb23d215aa83cd5540 DIFF: https://github.com/llvm/llvm-project/commit/11ce19d2119e0870b2bf53eb23d215aa83cd5540.diff

[PATCH] D69426: [clang] Switch arm-mve-intrinsics tests to use %clang_cc1.

dmgreen added a comment. Ah, I see, that's why it was needed. That makes sense. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69426/new/ https://reviews.llvm.org/D69426 ___ cfe-commits mailing list

[PATCH] D69426: [clang] Switch arm-mve-intrinsics tests to use %clang_cc1.

This revision was automatically updated to reflect the committed changes. Closed by commit rG11ce19d2119e: [clang] Switch arm-mve-intrinsics tests to use %clang_cc1. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69427: Fix compilation error in clangd/refactor/tweaks/ExpandAutoType.cpp

psamolysov created this revision. psamolysov added projects: clang, clang-tools-extra. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. During the compilation of the `clangd/refactor/tweaks/ExpandAutoType.cpp`, MSVC returns the following

[PATCH] D69426: [clang] Switch arm-mve-intrinsics tests to use %clang_cc1.

simon_tatham added a comment. There's no need, as far as I can see. `-fno-discard-value-names` is a driver option only. On the cc1 command line the option is `-discard-value-names`, and it has no negative form: you turn it off by not specifying it in the first place, which indeed these command

[PATCH] D68539: [clang-tidy] fix for readability-identifier-naming incorrectly fixes variables which become keywords

Daniel599 updated this revision to Diff 226403. Daniel599 added a comment. removed curly braces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68539/new/ https://reviews.llvm.org/D68539 Files:

[PATCH] D69382: [clangd] Do not insert parentheses when completing a using declaration

kadircet added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1466 Output.Completions.back().Score = C.second; Output.Completions.back().CompletionTokenRange = ReplacedRange; } why not handle `SnippetSuffix` in here ?

[PATCH] D69426: [clang] Switch arm-mve-intrinsics tests to use %clang_cc1.

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Sounds good. But make sure that -fno-discard-value-names is still included. Otherwise the names like "entry" will not be output, so the tests fail in "non-assert" builds. Repository:

[PATCH] D32478: [clang-format] Fix AlignOperands when BreakBeforeBinaryOperators is set

Typz marked 2 inline comments as done. Typz added inline comments. Comment at: clang/include/clang/Format/Format.h:187 /// expressions. - /// - /// Specifically, this aligns operands of a single expression that needs to be - /// split over multiple lines, e.g.: - ///

[PATCH] D69426: [clang] Switch arm-mve-intrinsics tests to use %clang_cc1.

simon_tatham created this revision. simon_tatham added a reviewer: dmgreen. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. simon_tatham edited the summary of this revision. It isn't really necessary for them to run the clang driver, and it's more efficient

[PATCH] D69165: [clangd] Store Index in Tweak::Selection

This revision was automatically updated to reflect the committed changes. Closed by commit rG8aa84ad37db7: [clangd] Store Index in Tweak::Selection (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D69165?vs=225871=226399#toc Repository: rG LLVM Github Monorepo

[PATCH] D69383: [RISCV] Match GCC `-march`/`-mabi` driver defaults

lenary marked an inline comment as done. lenary added a comment. I agree backwards compatibility is hard here. - This method was introduced to have a single place to choose a default `march` string if none was chosen before. I think this change is useful (saves defaults being calculated in a

[clang-tools-extra] 8aa84ad - [clangd] Store Index in Tweak::Selection

Author: Kadir Cetinkaya Date: 2019-10-25T12:15:20+02:00 New Revision: 8aa84ad37db7ddbff5c1a2e4ef8ff2a616f1da57 URL: https://github.com/llvm/llvm-project/commit/8aa84ad37db7ddbff5c1a2e4ef8ff2a616f1da57 DIFF:

[PATCH] D68937: [clangd] Add parameter renaming to define-inline code action

ilya-biryukov added a comment. Ah, we're actually trying to rename parameters in the declaration to match the ones in the definition... So the try-catch blocks are not a problem, actually Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68937/new/

[PATCH] D68024: [clangd] Implement GetEligiblePoints

This revision was automatically updated to reflect the committed changes. Closed by commit rGd62e3ed3f4b9: [clangd] Implement GetEligiblePoints (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68024/new/

[PATCH] D32478: [clang-format] Fix AlignOperands when BreakBeforeBinaryOperators is set

MyDeveloperDay added inline comments. Comment at: clang/include/clang/Format/Format.h:187 /// expressions. - /// - /// Specifically, this aligns operands of a single expression that needs to be - /// split over multiple lines, e.g.: - /// \code - /// int aaa =

[PATCH] D68937: [clangd] Add parameter renaming to define-inline code action

ilya-biryukov added a comment. In D68937#1710915 , @kadircet wrote: > I totally agree that the solution you proposed would also work, but don't > think it would be any less code. Since one needs to correlate > parameters between two different

[PATCH] D32478: [clang-format] Fix AlignOperands when BreakBeforeBinaryOperators is set

Typz updated this revision to Diff 226393. Typz added a comment. Rebase on top of D50078 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D32478/new/ https://reviews.llvm.org/D32478 Files:

[PATCH] D65433: [clangd] DefineInline action availability checks

This revision was automatically updated to reflect the committed changes. Closed by commit rG74d39a42f109: [clangd] DefineInline action availability checks (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D65433?vs=222158=226394#toc Repository: rG LLVM Github

[PATCH] D66647: [clangd] DefineInline action apply logic with fully qualified names

This revision was automatically updated to reflect the committed changes. Closed by commit rGdfd6374c784f: [clangd] DefineInline action apply logic with fully qualified names (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D68937: [clangd] Add parameter renaming to define-inline code action

kadircet updated this revision to Diff 226389. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68937/new/ https://reviews.llvm.org/D68937 Files: clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp

  1   2   >