[PATCH] D14927: clang-format: Add SpaceBeforeTemplateParameterList option

MyDeveloperDay added a comment. This I believe is covered by `SpaceAfterTemplateKeyword` which does the same thing CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14927/new/ https://reviews.llvm.org/D14927 ___ cfe-commits mailing list

[PATCH] D69498: IR: Invert convergent attribute handling

Anastasia added a comment. In D69498#1725692 , @kariddi wrote: > In D69498#1725528 , @rjmccall wrote: > > > It absolutely makes sense for Clang as a GPU-programming frontend to set > > attributes appropriately

[PATCH] D69518: [Diagnostics] Warn for std::is_constant_evaluated in constexpr mode

xbolva00 added a comment. Thanks! Commited in rGdba83965722b540f6baf43163210943c41e1378a Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69518/new/

[PATCH] D69518: [Diagnostics] Warn for std::is_constant_evaluated in constexpr mode

davezarzycki added a comment. Hi @xbolva00 – Thanks. That does make the libcxx test suite pass. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69518/new/ https://reviews.llvm.org/D69518 ___ cfe-commits

[PATCH] D69707: [AArch64][SVE] Implement additional floating-point arithmetic intrinsics

kmclaughlin created this revision. kmclaughlin added reviewers: sdesmalen, huntergr, dancgr. Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a project: LLVM. Adds intrinsics for the following: - ftssel - fcadd, fcmla - fmla, fmls, fnmla, fnmls - fmad,

[PATCH] D69518: [Diagnostics] Warn for std::is_constant_evaluated in constexpr mode

xbolva00 added a comment. Line 918 Add: self.cxx.addWarningFlagIfSupported('-Wno-constant-evaluated') to libcxx/utils/libcxx/test/config.py Can you please try? cc @EricWF Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69518/new/

[PATCH] D69706: [Diagnostics] Teach -Wnull-dereference about address_space attribute

xbolva00 added a comment. (mistake) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69706/new/ https://reviews.llvm.org/D69706 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69706: [Diagnostics] Teach -Wnull-dereference about address_space attribute

xbolva00 created this revision. xbolva00 added reviewers: aaron.ballman, rsmith. xbolva00 added a project: clang. Herald added subscribers: libcxx-commits, christof. Herald added a project: libc++. Clang should not warn for: test.c:2:12: warning: indirection of non-volatile null pointer will be

[PATCH] D69518: [Diagnostics] Warn for std::is_constant_evaluated in constexpr mode

davezarzycki added a comment. This broke two stage builds of libc++. Can we revert this until a fix is ready? FAIL: libc++ :: std/utilities/meta/meta.const.eval/is_constant_evaluated.fail.cpp (55845 of 59103) TEST 'libc++ ::

[PATCH] D69383: [RISCV] Match GCC `-march`/`-mabi` driver defaults

lenary updated this revision to Diff 227418. lenary added a comment. - Update tests to reflect new defaults Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69383/new/ https://reviews.llvm.org/D69383 Files: clang/docs/ReleaseNotes.rst

[PATCH] D69242: [Sema] Make helper in TreeTransform.h 'inline' instead of 'static'. NFC

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. I agree. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69242/new/ https://reviews.llvm.org/D69242

[PATCH] D69233: [OpenCL] Support -fdeclare-opencl-builtins in C++ mode

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69233/new/ https://reviews.llvm.org/D69233

[PATCH] D69657: [AArch64][SVE] Implement several floating-point arithmetic intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rG5ec34dfdf733: [AArch64][SVE] Implement several floating-point arithmetic intrinsics (authored by kmclaughlin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

Re: [PATCH] D55802: Change CGObjC to use objc intrinsics instead of runtime methods

Hi, I think the assumption that intrinsics can't read any global is, indeed, the problem here. `@llvm.objc.autoreleasePoolPop` may call any number of `-dealloc` methods with arbitrary side effects (though if they cause resurrection then that's undefined behaviour), so there should be no

[PATCH] D69435: [clang-tidy] New checker performance-trivially-destructible-check

AntonBikineev added a comment. In D69435#1729580 , @gribozavr2 wrote: > Alright then. (Although I don't know whether the redeclaration chain always > models that wording in the standard, and what that wording means when we > don't have a linear ordering

[PATCH] D69573: [clang-format] [PR36294] AlwaysBreakAfterReturnType works incorrectly for some operator functions

merge_guards_bot added a comment. Build result: pass - 59827 tests passed, 0 failed and 762 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D69573: [clang-format] [PR36294] AlwaysBreakAfterReturnType works incorrectly for some operator functions

MyDeveloperDay updated this revision to Diff 227405. MyDeveloperDay set the repository for this revision to rG LLVM Github Monorepo. MyDeveloperDay added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69573/new/

[PATCH] D69573: [clang-format] [PR36294] AlwaysBreakAfterReturnType works incorrectly for some operator functions

MyDeveloperDay marked 5 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2105 + if ((Next->isSimpleTypeSpecifier() || Next->is(tok::identifier)) && + Next->Next && Next->Next->is(tok::star)) { +

[PATCH] D69520: [libc++] Disallow dynamic -> static span conversions

mclow.lists added inline comments. Comment at: libcxx/test/std/containers/views/span.cons/span.fail.cpp:78 - -// Try to remove const and/or volatile (static -> static) -{ Ok. The comment here is wrong; this is testing dynamic -> static. However, why are

[PATCH] D69393: [RFC][DebugInfo] emit user specified address_space in dwarf

yonghong-song added a comment. During experimenting with linux kernel codes, I found that clang does not allow address_space attribute for function pointers, specifically, in `clang/lib/Sema/SemaType.cpp`, // ISO/IEC TR 18037 S5.3 (amending C99 6.7.3): "A function type shall not be //

[PATCH] D69393: [RFC][DebugInfo] emit user specified address_space in dwarf

yonghong-song updated this revision to Diff 227400. yonghong-song edited the summary of this revision. yonghong-song added a comment. minor update to only support address_space 1 for user pointer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

<    1   2