[clang] b2b6a54 - [X86] Add support for -mvzeroupper and -mno-vzeroupper to match gcc

Author: Craig Topper Date: 2019-11-04T11:03:54-08:00 New Revision: b2b6a54f847f33f821f41e3e82bf3b86e08817a0 URL: https://github.com/llvm/llvm-project/commit/b2b6a54f847f33f821f41e3e82bf3b86e08817a0 DIFF: https://github.com/llvm/llvm-project/commit/b2b6a54f847f33f821f41e3e82bf3b86e08817a0.diff

[PATCH] D69745: [analyzer] Checker: check::BeginAnalysis

NoQ added a comment. In D69745#1732744 , @Charusso wrote: > I think every `UnknownSpaceRegion` stuff is tainted, and that is a strong > mark here. Mmm, no, that's definitely not true. Basically, if you analyze a method of a class as your top frame,

[PATCH] D57829: [CUDA][HIP] Disable emitting llvm.linker.options in device compilation

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM in general. Nit about test name and test scope. Comment at: clang/test/CodeGenCUDA/linker-options.cu:1-5 +// RUN: %clang_cc1 -emit-llvm -o - -fcuda-is-device -fms-extensions

[PATCH] D69662: [Checkers] Avoid using evalCall in StreamChecker.

NoQ added a comment. Yes, indeed, `evalCall` can only be performed by one checker. But if any, it is this checker that's fully responsible for stream functions. So i recommend doing evalCall in this particular checker and falling back to `PreCall`/`PostCall` in other checkers that model other

[PATCH] D69791: [ARM,MVE] Add intrinsics for gather/scatter load/stores.

dmgreen added inline comments. Comment at: clang/include/clang/Basic/arm_mve_defs.td:175 +// CopyKind expects t and u to be scalars. It returns a scalar +// whose kind (signed, unsigned or float) matches that of k, and whose Should the t and u be s and k?

[PATCH] D69745: [analyzer] Checker: check::BeginAnalysis

Charusso abandoned this revision. Charusso marked an inline comment as done. Charusso added a comment. In D69745#1732739 , @NoQ wrote: > Basically this, but the other way round: your `BeginAnalysis` is > `BeginFunction` with extra steps (namely, checking

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

ABataev added a comment. Some comments marked as ]Вщту] are not done actually, check them, please. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7246-7248 +// Set implicit behavior except for "default" for defaultmap +if ((Bits & OMP_MAP_IMPLICIT) && +

[PATCH] D69745: [analyzer] Checker: check::BeginAnalysis

NoQ added a comment. > I think we need to merge the `BeginFunction` into the `BeginWorklist`. Basically this, but the other way round: your `BeginAnalysis` is `BeginFunction` with extra steps (namely, checking `C.inTopFrame()`). Backstory: I wanted to add `BeginAnalysis` a few years ago

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

fghanim added inline comments. Comment at: llvm/include/llvm/IR/OpenMPIRBuilder.h:51 + /// potentially other helpers into the underlying module. Must be called + /// before any other other method and only once! + void initialize(); ///before any other method

[PATCH] D69308: [analyzer] Test cases for the unsupported features for Clang Static Analyzer

NoQ accepted this revision. NoQ added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69308/new/ https://reviews.llvm.org/D69308 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69810: [OpenCL] Fix address space for base method call (PR43145)

svenvh created this revision. svenvh added a reviewer: Anastasia. Herald added subscribers: cfe-commits, ebevhan, yaxunl. Herald added a project: clang. Potentially create an addrspacecast in case the argument is a pointer. Repository: rC Clang https://reviews.llvm.org/D69810 Files:

[PATCH] D68407: [WIP][RISCV] Use compiler-rt if no GCC installation detected

lenary added a comment. This patch is looking much better, thanks for updating it. Please may you clarify what RISC-V gcc does for `-lgcc`, `-lgcc_s`, `-lgcc_eh`? Is it different to what gcc does on other targets? Being closer to matching the linker arguments that gcc provides to ld seems like

[PATCH] D69626: Fix Microsoft compatibility handling of commas in nested macro expansions.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbe6ac471f613: [ms] Fix Microsoft compatibility handling of commas in nested macro expansions. (authored by epastor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] be6ac47 - [ms] Fix Microsoft compatibility handling of commas in nested macro expansions.

Author: Eric Astor Date: 2019-11-04T12:49:19-05:00 New Revision: be6ac471f613427f3b5b3a306fe033e526d59f76 URL: https://github.com/llvm/llvm-project/commit/be6ac471f613427f3b5b3a306fe033e526d59f76 DIFF: https://github.com/llvm/llvm-project/commit/be6ac471f613427f3b5b3a306fe033e526d59f76.diff

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert marked 7 inline comments as done. jdoerfert added inline comments. Comment at: llvm/include/llvm/IR/OpenMPIRBuilder.h:33 + /// IDs for all OpenMP directives. + enum DirektiveKind { +#define OMP_DIRECTIVE(Enum, ...) Enum, ABataev wrote: > jdoerfert

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM; thanks for your patience during all the rounds of review. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

ABataev added inline comments. Comment at: llvm/include/llvm/IR/OpenMPIRBuilder.h:33 + /// IDs for all OpenMP directives. + enum DirektiveKind { +#define OMP_DIRECTIVE(Enum, ...) Enum, jdoerfert wrote: > ABataev wrote: > > 1. `DirectiveKind` > > 2. Is it

[PATCH] D68407: [WIP][RISCV] Use compiler-rt if no GCC installation detected

edward-jones added a comment. In D68407#1709235 , @lenary wrote: > Please can you add a test for riscv32 and riscv64 without libgcc? I'm not sure what you mean here; I believe the existing tests already cover riscv{32,64} without libgcc. CHANGES

[PATCH] D68407: [WIP][RISCV] Use compiler-rt if no GCC installation detected

edward-jones updated this revision to Diff 227722. edward-jones retitled this revision from "[RISCV] Use compiler-rt if no GCC installation detected" to "[WIP][RISCV] Use compiler-rt if no GCC installation detected". edward-jones edited the summary of this revision. edward-jones added a comment.

[clang] ab76cfd - Recommit "[CodeView] Add option to disable inline line tables."

Author: Amy Huang Date: 2019-11-04T09:15:26-08:00 New Revision: ab76cfdd200d35177df2042a1c0c7e86868d01bc URL: https://github.com/llvm/llvm-project/commit/ab76cfdd200d35177df2042a1c0c7e86868d01bc DIFF: https://github.com/llvm/llvm-project/commit/ab76cfdd200d35177df2042a1c0c7e86868d01bc.diff

[PATCH] D68391: [RISCV] Improve sysroot computation if no GCC install detected

edward-jones updated this revision to Diff 227721. edward-jones added a comment. Rebased, added a comment to explain that this is using the user provided triple instead of the canonical one, and split out the tests requiring a shell into separate files

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert marked 12 inline comments as done. jdoerfert added inline comments. Comment at: clang/include/clang/Basic/OpenMPKinds.h:23-24 enum OpenMPDirectiveKind { -#define OPENMP_DIRECTIVE(Name) \ - OMPD_##Name, #define OPENMP_DIRECTIVE_EXT(Name, Str) \

[PATCH] D66049: [analyzer] PR41729: Fix some false positives and improve strlcat and strlcpy modeling

dkrupp added a comment. If this is good to go, could you please commit this? Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66049/new/ https://reviews.llvm.org/D66049 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69308: [analyzer] Test cases for the unsupported features for Clang Static Analyzer

dkrupp added a comment. In D69308#1727625 , @NoQ wrote: > Another interesting problem that we forgot to mention on the open projects > page is the modeling of C++17 bindings and decompositions: > https://bugs.llvm.org/show_bug.cgi?id=43042 > > Also, in

[PATCH] D69162: [clangd] Remove using-namespace present inside a namespace.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/RemoveUsingNamespace.cpp:179 + + if (ContainingNS) { +for (auto ReDeclNS : ContainingNS->redecls()) usaxena95 wrote: > ilya-biryukov wrote: > > Could you explain why

[PATCH] D69308: [analyzer] Test cases for the unsupported features for Clang Static Analyzer

dkrupp added a comment. In D69308#1727587 , @NoQ wrote: > In D69308#1727108 , @Szelethus wrote: > > > Would love to see this comment in its entirety on the open projects page :^) > > > I'd rather have a mention

[PATCH] D69577: [clang-format] [PR35518] C++17 deduction guides are wrongly formatted

curdeius added a comment. Minor comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1354 + static FormatToken *untilMatchingParen(FormatToken *Current) { +// for when MatchingParen is not yet established +int ParenLevel = 0; Please write

[PATCH] D69615: [clangd] Implement a function to lex the file to find candidate occurrences.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.cpp:769 +llvm::StringRef TokenName; +if (Tok.getKind() == tok::identifier) + TokenName = Tok.getIdentifierInfo()->getName(); Why do we have both

[PATCH] D69673: [clangd] Implement semantic highlightings via findExplicitReferences

ilya-biryukov updated this revision to Diff 227713. ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. - Rename to LangOpts and SourceMgr - Rename to CollectExtraHighlightings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69308: [analyzer] Test cases for the unsupported features for Clang Static Analyzer

dkrupp updated this revision to Diff 227714. dkrupp marked 2 inline comments as done. dkrupp added a comment. Thanks for your comments @NoQ I fixed them. Also added your implementation hints to the open projects page. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69308/new/

[PATCH] D69726: [analyzer] DynamicSize: Store the dynamic size

Charusso marked 3 inline comments as done. Charusso added a comment. In D69726#1732334 , @Szelethus wrote: > Changes to `MallocChecker` really highlight the positive effects of this > patch. Nice! Thanks! Comment at:

[PATCH] D69790: [ARM,MVE] Integer-type nitpicks in MVE intrinsics.

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. LGTM then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69790/new/ https://reviews.llvm.org/D69790

[PATCH] D69673: [clangd] Implement semantic highlightings via findExplicitReferences

ilya-biryukov marked 2 inline comments as done. ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:220 + bool VisitOverloadExpr(OverloadExpr *E) { +if (!E->decls().empty()) + return true; // handled by

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

Meinersbur added a comment. In D69764#1732232 , @MyDeveloperDay wrote: > @pollydev too (a previously clang-format clean directory) will generate > changes running `clang-format --const-style=west -i -n *.cpp` > > ScopBuilder.cpp:74:9: warning: code

[PATCH] D68969: [clang-format] Remove the dependency on frontend

thakis added a comment. Since this was reverted: are you looking into relanding this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68969/new/ https://reviews.llvm.org/D68969 ___ cfe-commits mailing

[PATCH] D69242: [Sema] Make helper in TreeTransform.h 'inline' instead of 'static'. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG9ba16615fa07: [Sema] Make helper in TreeTransform.h inline instead of static. NFC (authored by ilya-biryukov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69745: [analyzer] Checker: check::BeginAnalysis

Charusso marked 3 inline comments as done. Charusso added a comment. In D69745#1732348 , @Szelethus wrote: > YES PLEASE. Debug checkers that only dump from `check::EndAnalysis` won't > rely on the analysis not actually crashing. Which is ironically

[clang] 9ba1661 - [Sema] Make helper in TreeTransform.h 'inline' instead of 'static'. NFC

Author: Ilya Biryukov Date: 2019-11-04T17:07:53+01:00 New Revision: 9ba16615fa07c586965b1fa2dc6e88f13fe8031d URL: https://github.com/llvm/llvm-project/commit/9ba16615fa07c586965b1fa2dc6e88f13fe8031d DIFF: https://github.com/llvm/llvm-project/commit/9ba16615fa07c586965b1fa2dc6e88f13fe8031d.diff

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

ABataev added inline comments. Comment at: clang/include/clang/Basic/OpenMPKinds.h:23-24 enum OpenMPDirectiveKind { -#define OPENMP_DIRECTIVE(Name) \ - OMPD_##Name, #define OPENMP_DIRECTIVE_EXT(Name, Str) \ Better to make in a separate NFC patch.

[PATCH] D69745: [analyzer] Checker: check::BeginAnalysis

Charusso updated this revision to Diff 227710. Charusso edited the summary of this revision. Charusso added a comment. - Do not restrict what you supposed to do with the callback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69745/new/ https://reviews.llvm.org/D69745 Files:

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

MyDeveloperDay updated this revision to Diff 227708. MyDeveloperDay retitled this revision from "[clang-format] Add East Const / West Const fixer" to "[clang-format] Add Left/Right Const (East/West , Before/After) fixer capability". MyDeveloperDay edited the summary of this revision.

[PATCH] D69804: [clang-tidy] Update TransformerClangTidyCheck to use new Transformer bindings.

ymandel created this revision. ymandel added a reviewer: gribozavr. Herald added a subscriber: xazax.hun. Herald added a project: clang. ymandel added a child revision: D69613: [libTooling] Simplify type structure of `Stencil`s.. Updates the relevant source files to use bindings in

[PATCH] D69662: [Checkers] Avoid using evalCall in StreamChecker.

balazske added a comment. From the same book: There are multiple preconditions required for inlining to happen, including: — Source code of the callee function body needs to be available; — No checker should evaluate the function call via eval::Call; Abandon this change? Repository:

[clang] a0324e9 - SanitizerMask::bitPosToMask - fix operator precedence warnings. NFCI.

Author: Simon Pilgrim Date: 2019-11-04T15:12:01Z New Revision: a0324e911374441151903ed0d828e0fc1994c167 URL: https://github.com/llvm/llvm-project/commit/a0324e911374441151903ed0d828e0fc1994c167 DIFF: https://github.com/llvm/llvm-project/commit/a0324e911374441151903ed0d828e0fc1994c167.diff

[clang] 6c58279 - [OpenCL] Fix FileCheck pattern

Author: Sven van Haastregt Date: 2019-11-04T15:08:53Z New Revision: 6c5827975cf921563315de54ac7c6053d3995f40 URL: https://github.com/llvm/llvm-project/commit/6c5827975cf921563315de54ac7c6053d3995f40 DIFF: https://github.com/llvm/llvm-project/commit/6c5827975cf921563315de54ac7c6053d3995f40.diff

[clang] d142ec6 - Fix compilation warning. NFC.

Author: Michael Liao Date: 2019-11-04T10:01:50-05:00 New Revision: d142ec6fef9a053c9fd9edb5a388203cdb121e65 URL: https://github.com/llvm/llvm-project/commit/d142ec6fef9a053c9fd9edb5a388203cdb121e65 DIFF: https://github.com/llvm/llvm-project/commit/d142ec6fef9a053c9fd9edb5a388203cdb121e65.diff

[PATCH] D69263: [clangd] Implement cross-file rename.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:370 + for (auto : *Edits) { +if (auto Err = reformatEdit(E.getValue(), Style)) + elog("Failed to format replacements: {0}", std::move(Err)); hokein

[PATCH] D54214: [RISCV] Set triple based on -march flag

lenary added a comment. Herald added a subscriber: sameer.abuasal. I have no issue with the underlying logic here. Please rebase on top of D69383 and use `riscv::getRISCVArch(...)` defined in that patch rather than querying

[PATCH] D69263: [clangd] Implement cross-file rename.

merge_guards_bot added a comment. Build result: pass - 59816 tests passed, 0 failed and 762 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D69802: [libTooling] Further simplify `Stencil` type and introduce `MatchComputation`.

ymandel updated this revision to Diff 227702. ymandel added a comment. tweak. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69802/new/ https://reviews.llvm.org/D69802 Files: clang/include/clang/Tooling/Transformer/MatchConsumer.h

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. LGTM. Requires the changes in D69383 to land before this can. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:1544 + StringRef ABIName =

[PATCH] D69802: [libTooling] Further simplify `Stencil` type and introduce `MatchComputation`.

ymandel created this revision. ymandel added a reviewer: gribozavr. Herald added a project: clang. ymandel added a parent revision: D69613: [libTooling] Simplify type structure of `Stencil`s.. This revision introduces a new interface `MatchComputation` which generalizes the `Stencil` interface

[PATCH] D69263: [clangd] Implement cross-file rename.

hokein added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:766 + [File, Code, Params, Reply = std::move(Reply), + this](llvm::Expected Edits) mutable { +if (!Edits) ilya-biryukov wrote: > NIT: is capture of `this`

[PATCH] D69263: [clangd] Implement cross-file rename.

hokein updated this revision to Diff 227700. hokein marked 13 inline comments as done. hokein added a comment. address comments: - use VFS from AST; - simplify the interfaces; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69263/new/

[PATCH] D69745: [analyzer] Checker: check::BeginAnalysis

Szelethus added a comment. YES PLEASE. Debug checkers that only dump from `check::EndAnalysis` won't rely on the analysis not actually crashing. Which is ironically exactly when we want to use them. Comment at: clang/lib/StaticAnalyzer/Checkers/CheckerDocumentation.cpp:199 +

[PATCH] D69745: [analyzer] Checker: check::BeginAnalysis

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CheckerDocumentation.cpp:199 + /// + /// This callback should be used to construct the checker's fields. + /// Szelethus wrote: > Hmmm, what use case do you have in mind? Do we

[PATCH] D69726: [analyzer] DynamicSize: Store the dynamic size

Szelethus added a comment. Changes to `MallocChecker` really highlight the positive effects of this patch. Nice! Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:451 static ProgramStateRef MallocMemAux(CheckerContext , const CallExpr *CE, -

[PATCH] D69662: [Checkers] Avoid using evalCall in StreamChecker.

Szelethus added a comment. In D69662#1731974 , @balazske wrote: > I wanted to remove `eval::Call` because only one checker can do this > otherwise it is undefined behavior (according to the not very new "Analyzer > Guide"). If it is essentially needed

[PATCH] D69764: [clang-format] Add East Const / West Const fixer

aaron.ballman added a comment. In D69764#1732295 , @MyDeveloperDay wrote: > In D69764#1732235 , @aaron.ballman > wrote: > > > I like the functionality, but am slightly opposed to using "east/west" > >

[PATCH] D68781: [OpenCL] Fix address space for const method call from nonconst

This revision was automatically updated to reflect the committed changes. Closed by commit rG82888b78d47e: [OpenCL] Fix address space for const method call from nonconst (PR43145) (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 82888b7 - [OpenCL] Fix address space for const method call from nonconst (PR43145)

Author: Sven van Haastregt Date: 2019-11-04T13:12:17Z New Revision: 82888b78d47ed132aee4993e00669ce7cbd963e0 URL: https://github.com/llvm/llvm-project/commit/82888b78d47ed132aee4993e00669ce7cbd963e0 DIFF: https://github.com/llvm/llvm-project/commit/82888b78d47ed132aee4993e00669ce7cbd963e0.diff

[PATCH] D69764: [clang-format] Add East Const / West Const fixer

MyDeveloperDay added a comment. In D69764#1732235 , @aaron.ballman wrote: > I like the functionality, but am slightly opposed to using "east/west" > terminology -- that's not a ubiquitous phrase and it takes a bit of thinking > before it makes sense. I

[PATCH] D69790: [ARM,MVE] Integer-type nitpicks in MVE intrinsics.

simon_tatham updated this revision to Diff 227692. simon_tatham added a comment. Removed the `asValue` system, which (as you'd guessed) ought to have been part of D69791 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69789: [clang,MveEmitter] Fix sign/zero extension in range limits.

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69789/new/ https://reviews.llvm.org/D69789

[PATCH] D69790: [ARM,MVE] Integer-type nitpicks in MVE intrinsics.

dmgreen added inline comments. Comment at: clang/utils/TableGen/MveEmitter.cpp:559 + // Emit code to generate this result as a Value *. + std::string asValue() override { +if (AddressType) Can you explain this, is it related to something else?

[PATCH] D69800: [AArch64][SVE] Implement remaining floating-point arithmetic intrinsics

kmclaughlin created this revision. kmclaughlin added reviewers: huntergr, sdesmalen, dancgr, mgudim. Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a project: LLVM. Adds intrinsics for the following: - fabs & fneg - fexpa - frint[a|i|m|n|p|x|z] -

[PATCH] D69788: [ARM MVE] Remove accidental 64-bit vst2/vld2 intrinsics.

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. LGTM. I was trying to think of a way to test this, but couldn't come up with anything sensible. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69272: Restricted variant of '#pragma STDC FENV_ACCESS'

sepavloff updated this revision to Diff 227690. sepavloff added a comment. Removed diagnostics on inline functions As pointed out in review, strictfp attribute does not prevent from inlining, it only restrict cases where the inlining is possible. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D69764: [clang-format] Add East Const / West Const fixer

aaron.ballman added a comment. I like the functionality, but am slightly opposed to using "east/west" terminology -- that's not a ubiquitous phrase and it takes a bit of thinking before it makes sense. I think "left/right" is likely to be more universally understood. Also, should this apply

[PATCH] D69764: [clang-format] Add East Const / West Const fixer

MyDeveloperDay added a subscriber: pollydev. MyDeveloperDay added a comment. @pollydev too (a previously clang-format clean directory) will generate changes running `clang-format --const-style=west -i -n *.cpp` ScopBuilder.cpp:74:9: warning: code should be clang-formatted

[PATCH] D69764: [clang-format] Add East Const / West Const fixer

MyDeveloperDay added a comment. An example of even how setting the style to be West will generate new changes on a previously formatted lib/Format $ git diff . diff --git a/clang/lib/Format/WhitespaceManager.cpp b/clang/lib/Format/WhitespaceManager.cpp old mode 100644 new mode 100755

[PATCH] D69752: clang-format: Add a fallback style to Emacs mode

dottedmag added a comment. I am not a committer, so please commit. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69752/new/ https://reviews.llvm.org/D69752 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69752: clang-format: Add a fallback style to Emacs mode

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. I'm not an Emacs user, but this LGTM as much as I can read the rest of the file. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69752/new/

[PATCH] D69574: Remove lazy thread-initialisation

This revision was automatically updated to reflect the committed changes. Closed by commit rG91167e22eca5: [hwasan] Remove lazy thread-initialisation (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69574/new/

[clang] 91167e2 - [hwasan] Remove lazy thread-initialisation

Author: David Spickett Date: 2019-11-04T10:58:46Z New Revision: 91167e22eca535025f093335acece573bf19c525 URL: https://github.com/llvm/llvm-project/commit/91167e22eca535025f093335acece573bf19c525 DIFF: https://github.com/llvm/llvm-project/commit/91167e22eca535025f093335acece573bf19c525.diff

[PATCH] D69792: [NFC] Supress GCC "Bitfield too small to hold all values of enum" warning.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks, this seems fine to me. (It's unfortunate that the combination of MSVC's behavior and GCC's non-disableable warning forces this upon us, but so be it.) Repository: rG LLVM Github

[PATCH] D68781: [OpenCL] Fix address space for const method call from nonconst

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68781/new/ https://reviews.llvm.org/D68781 ___

[PATCH] D69263: [clangd] Implement cross-file rename.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:766 + [File, Code, Params, Reply = std::move(Reply), + this](llvm::Expected Edits) mutable { +if (!Edits) NIT: is capture of `this` redundant here?

[PATCH] D69673: [clangd] Implement semantic highlightings via findExplicitReferences

hokein added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:194 + const SourceManager + const LangOptions + std::vector Tokens; nit: I'd call it `LangOpts` Comment at:

[PATCH] D69780: [clang-format] DO NOT COMMIT - Demo of East/West Const Fixer on clang-format

JonasToth added a comment. Yeah! nice work :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69780/new/ https://reviews.llvm.org/D69780 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69743: [CGDebugInfo] Emit subprograms for decls when AT_tail_call is understood

djtodoro accepted this revision. djtodoro added a comment. This revision is now accepted and ready to land. @vsk Thanks for this! (lgtm) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69743/new/ https://reviews.llvm.org/D69743 ___

[PATCH] D69263: [clangd] Implement cross-file rename.

merge_guards_bot added a comment. Build result: pass - 59816 tests passed, 0 failed and 762 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D69792: [NFC] Supress GCC "Bitfield too small to hold all values of enum" warning.

tianqing created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. 974c8b7e2fd introduced a warning for GCC: llvm-project/clang/include/clang/Sema/Overload.h:835:48: warning: ‘clang::OverloadCandidate::RewriteKind’ is too small to hold all values of ‘enum

[PATCH] D69263: [clangd] Implement cross-file rename.

hokein updated this revision to Diff 227663. hokein marked 4 inline comments as done. hokein added a comment. Add comments for DirtyBufferGetter. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69263/new/ https://reviews.llvm.org/D69263 Files:

[PATCH] D69790: [ARM,MVE] Integer-type nitpicks in MVE intrinsics.

simon_tatham created this revision. simon_tatham added a reviewer: dmgreen. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. simon_tatham added a child revision: D69791: [ARM,MVE] Add intrinsics for gather/scatter load/stores.. A few integer types in the ACLE

[PATCH] D69788: [ARM MVE] Remove accidental 64-bit vst2/vld2 intrinsics.

simon_tatham created this revision. simon_tatham added a reviewer: dmgreen. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. ACLE defines no such intrinsic as vst2q_u64, and the MVE instruction set has no corresponding instruction. But I had accidentally added

[PATCH] D69789: [clang,MveEmitter] Fix sign/zero extension in range limits.

simon_tatham created this revision. simon_tatham added a reviewer: dmgreen. Herald added a project: clang. Herald added a subscriber: cfe-commits. simon_tatham added a child revision: D69791: [ARM,MVE] Add intrinsics for gather/scatter load/stores.. simon_tatham edited the summary of this

[PATCH] D69662: [Checkers] Avoid using evalCall in StreamChecker.

Charusso added a comment. On multiple evaluation of the same call the Analyzer will warn and prevent you to do so. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69662/new/ https://reviews.llvm.org/D69662

[PATCH] D69662: [Checkers] Avoid using evalCall in StreamChecker.

balazske marked an inline comment as done. balazske added a comment. I wanted to remove `eval::Call` because only one checker can do this otherwise it is undefined behavior (according to the not very new "Analyzer Guide"). If it is essentially needed in this checker it will remain.

[PATCH] D69764: [clang-format] Add East Const / West Const fixer

MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:768 LLVMStyle.CommentPragmas = "^ IWYU pragma:"; + LLVMStyle.ConstStyle = FormatStyle::CS_Leave; LLVMStyle.CompactNamespaces = false;

[PATCH] D69764: [clang-format] Add East Const / West Const fixer

lebedev.ri marked an inline comment as done. lebedev.ri added inline comments. Comment at: clang/lib/Format/Format.cpp:768 LLVMStyle.CommentPragmas = "^ IWYU pragma:"; + LLVMStyle.ConstStyle = FormatStyle::CS_Leave; LLVMStyle.CompactNamespaces = false;

[PATCH] D69764: [clang-format] Add East Const / West Const fixer

MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:768 LLVMStyle.CommentPragmas = "^ IWYU pragma:"; + LLVMStyle.ConstStyle = FormatStyle::CS_Leave; LLVMStyle.CompactNamespaces = false;

<    1   2