[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/unittests/CollectMacrosTests.cpp:80 +<< Test; +EXPECT_THAT(collectKnownReferences(AST.getMacros()), AreMacroRefsFrom(T)) +<< Test; hokein wrote: > usaxena95 wrote: > >

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

usaxena95 updated this revision to Diff 229529. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Modified tests for better error messages. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70008/new/

[PATCH] D70235: [clangd] Add isHeaderFile helper.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.h:302 +bool isHeaderFile(llvm::StringRef FileName, + llvm::Optional LangOpts = None); + nit: = llvm::None Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D70307: [CodeComplete] Constructor overload candidates report as vector(int) instead of vector(int)

sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clang/test/CodeCompletion/templates.cpp:35 +// CHECK-CONSTRUCTOR: OVERLOAD: X(<#double#>) +// (rather than X(<#double#>) hokein wrote: > shouldn't be now `X` after your

[PATCH] D70235: [clangd] Add isHeaderFile helper.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/SourceCode.cpp:1133 + Lang != types::TY_INVALID && types::onlyPrecompileType(Lang); + if (!LangOpts) +return

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

merge_guards_bot added a comment. Build result: pass - 60093 tests passed, 0 failed and 729 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70307: [CodeComplete] Constructor overload candidates report as vector(int) instead of vector(int)

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/CodeCompletion/templates.cpp:35 +// CHECK-CONSTRUCTOR: OVERLOAD: X(<#double#>) +// (rather than X(<#double#>) shouldn't be now

[PATCH] D70297: [ARM,MVE] Add intrinsics for vector comparisons.

simon_tatham marked 2 inline comments as done. simon_tatham added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:6798 +static llvm::Value *ARMMVEDupVector(CGBuilderTy , llvm::Value *V) { + // Helper function to duplicate a scalar value V into all lanes of an MVE

[PATCH] D67543: [Clang][ASTImporter] Added visibility check for ClassTemplateDecl.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc2f6efc732ef: [Clang][ASTImporter] Added visibility check for ClassTemplateDecl. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D70235: [clangd] Add isHeaderFile helper.

hokein added a comment. in case you miss this patch, I saw you have stamped the other patch depends on this patch, but this patch still needs approval. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70235/new/ https://reviews.llvm.org/D70235

[PATCH] D70157: Align branches within 32-Byte boundary

skan marked 3 inline comments as done. skan added inline comments. Comment at: llvm/test/MC/X86/i386-align-branch-1a.s:1 +# RUN: llvm-mc -filetype=obj -triple i386-unknown-unknown --x86-align-branch-boundary=32 --x86-align-branch=fused-jcc-jmp --x86-align-branch-prefix-size=5

[PATCH] D70299: [clangd] Replace getLangOpts().isHeaderFile usage with isHeaderFile helper.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/FindSymbolsTests.cpp:181 TEST_F(WorkspaceSymbolsTest, AnonymousNamespace) { - addFile("foo.h", R"cpp( + // header

[PATCH] D70157: Align branches within 32-Byte boundary

xbolva00 added a comment. > Even though core2 isn't affected by the erratum, core2 code can run on CPUs > that do have the bug (and core2 is a popular target for code that needs to > run "everywhere"), therefore all target CPUs that predate a hardware fix > really So perf of all code/generic

[PATCH] D70157: Align branches within 32-Byte boundary

skan added a comment. In D70157#1747428 , @davezarzycki wrote: > In D70157#1746793 , @MaskRay wrote: > > > On x86, the preferred function alignment is 16 > >

<    1   2   3