[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

michele.scandale added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2337 +<< "-ffp-contract=fast"; +optID = options::OPT_ffast_math; +FPModel = Val; Here it seems you are changing `optID` to `OPT_ffast_math` to

[PATCH] D70320: [Analyzer] [NFC] Iterator Checkers - Separate iterator modeling and the actual checkers

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:1308-1318 +ProgramStateRef removeIteratorPosition(ProgramStateRef State, const SVal ) { if (auto Reg =

[PATCH] D70446: [clangd] Treat UserDefinedLiteral as a leaf in SelectionTree, sidestepping tokenization issues

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70446/new/ https://reviews.llvm.org/D70446

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

michele.scandale added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2576 +CmdArgs.push_back("-ftrapping-math"); + } else if (TrappingMathPresent) CmdArgs.push_back("-fno-trapping-math"); mibintc wrote: > michele.scandale wrote: >

[PATCH] D59321: WIP: AMDGPU: Teach toolchain to link rocm device libs

arsenm updated this revision to Diff 230197. arsenm added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59321/new/ https://reviews.llvm.org/D59321 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clang/Driver/Options.td

[PATCH] D59321: WIP: AMDGPU: Teach toolchain to link rocm device libs

arsenm marked an inline comment as done. arsenm added inline comments. Comment at: lib/Driver/ToolChains/AMDGPU.h:25 +/// TODO: Generalize to handle libclc. +class RocmInstallationDetector { +private: arsenm wrote: > yaxunl wrote: > > I don't think we should

[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

SouraVX added a comment. In D70111#1751981 , @aprantl wrote: > There are two options here: > > - leave the C bindings as is (fine with me) > - add an overloaded function to the C bindings that has the extra argument > (also fine with me). In my opinon,

[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

SouraVX added a comment. Some how, this{eric response} doesn't got it's way to phabricator, anyways FYI > The C bindings, in general, don't have stability guarantees outside of a few > cases. > Whitequark owns all of this now though :) > -eric Repository: rG LLVM Github Monorepo

[PATCH] D67536: [clangd] Inactive regions support as an extension to semantic highlighting

nridge updated this revision to Diff 230195. nridge marked 4 inline comments as done. nridge added a comment. Address nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67536/new/ https://reviews.llvm.org/D67536 Files:

[PATCH] D67536: [clangd] Inactive regions support as an extension to semantic highlighting

nridge added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:469 + auto = DiffedLines.back(); + for (auto Iter = AddedLine.Tokens.begin(); + Iter != AddedLine.Tokens.end();) { hokein wrote: > nridge wrote: > >

[PATCH] D70284: Constant strings emitted when `-fno-constant-cfstrings` is passed should allow dead stripping

bendjones added a comment. In D70284#1752811 , @dexonsmith wrote: > For some reason this revision is locked down and I'm not allowed to "edit" > it, which includes adding inline review comments. Can you add me as a > reviewer? Thought I did. > The

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 9PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D70477: [Clang] Enable RISC-V support for Fuchsia

phosek created this revision. phosek added a reviewer: leonardchan. Herald added subscribers: cfe-commits, apazos, sameer.abuasal, pzheng, s.egerton, lenary, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD,

[clang] 6c6d348 - Revert "[clang][IFS] Fixing unsupported emulation mode on clang-ppc64be-linux bot."

Author: Puyan Lotfi Date: 2019-11-19T21:59:22-05:00 New Revision: 6c6d34883a3003693cbf0ab3edf19eb999c1a62d URL: https://github.com/llvm/llvm-project/commit/6c6d34883a3003693cbf0ab3edf19eb999c1a62d DIFF: https://github.com/llvm/llvm-project/commit/6c6d34883a3003693cbf0ab3edf19eb999c1a62d.diff

[clang] 27b229d - Revert "[clang][IFS][test] Removing driver-test.c. Test is still too brittle."

Author: Puyan Lotfi Date: 2019-11-19T21:59:10-05:00 New Revision: 27b229dc17b2ea1d06fe566df8631bb2fff7b1c8 URL: https://github.com/llvm/llvm-project/commit/27b229dc17b2ea1d06fe566df8631bb2fff7b1c8 DIFF: https://github.com/llvm/llvm-project/commit/27b229dc17b2ea1d06fe566df8631bb2fff7b1c8.diff

[clang] f37356d - [clang][IFS][test] Removing driver-test.c. Test is still too brittle.

Author: Puyan Lotfi Date: 2019-11-19T21:42:17-05:00 New Revision: f37356d6f60ae5db978611621d3a375ed87ec0f0 URL: https://github.com/llvm/llvm-project/commit/f37356d6f60ae5db978611621d3a375ed87ec0f0 DIFF: https://github.com/llvm/llvm-project/commit/f37356d6f60ae5db978611621d3a375ed87ec0f0.diff

Re: [PATCH] D70284: Constant strings emitted when `-fno-constant-cfstrings` is passed should allow dead stripping

Can you check the `#0` at the end of the globals and other strings that precede that? If you do so, we can also check that `no_dead_strip` isn’t added. > On Nov 19, 2019, at 6:05 PM, Duncan P. N. Exon Smith via Phabricator via > cfe-commits wrote: > > dexonsmith added a comment. > > For some

[PATCH] D70470: [analyzer] Add FuchsiaHandleCheck to catch handle leaks, use after frees and double frees

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/FuchsiaHandleChecker.cpp:207 + int PtrToHandleLevel = 0; + const Type *T = QT.getTypePtr(); + while (T->isAnyPointerType() || T->isReferenceType() || T->isArrayType()) { xazax.hun wrote:

[PATCH] D70470: [analyzer] Add FuchsiaHandleCheck to catch handle leaks, use after frees and double frees

xazax.hun updated this revision to Diff 230187. xazax.hun added a comment. - Addressed **some** of the review comments. More changes are planned :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70470/new/ https://reviews.llvm.org/D70470 Files:

[PATCH] D68346: [clang-format] Add new option to add spaces around conditions

timwoj added a comment. Thanks for the consideration on committer access, but I'm going to have to pass for the time being. That said, can someone land this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68346/new/

[clang] 8700831 - clang/Modules: Early return in CompilerInstance::createModuleManager, NFC

Author: Duncan P. N. Exon Smith Date: 2019-11-19T18:16:23-08:00 New Revision: 8700831734811cb89eafb72b75206f21e9f047e9 URL: https://github.com/llvm/llvm-project/commit/8700831734811cb89eafb72b75206f21e9f047e9 DIFF:

[PATCH] D70470: [analyzer] Add FuchsiaHandleCheck to catch handle leaks, use after frees and double frees

xazax.hun marked 13 inline comments as done. xazax.hun added a comment. Thanks for the review! I am not very well versed in Fuchsia's syscalls yet but my understanding is that not all of the syscalls can fail so we do not need all the users to check for errors. But this is something I will

[PATCH] D70284: Constant strings emitted when `-fno-constant-cfstrings` is passed should allow dead stripping

dexonsmith added a comment. For some reason this revision is locked down and I'm not allowed to "edit" it, which includes adding inline review comments. Can you add me as a reviewer? The two comments: - Please add a period at the end of the sentence in the comment. - Can you give more context

[PATCH] D70284: Constant strings emitted when `-fno-constant-cfstrings` is passed should allow dead stripping

bendjones added a comment. Any additional thoughts @dexonsmith @erik.pilkington @ahatanak? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70284/new/ https://reviews.llvm.org/D70284 ___ cfe-commits

[PATCH] D70470: [analyzer] Add FuchsiaHandleCheck to catch handle leaks, use after frees and double frees

NoQ added a comment. Yay, i see the "Schrödinger handle" pattern: until the return value of release is checked, the handle is believed to be both dead and alive at the same time. We usually use this pattern because a lot of code that's already written doesn't check their return values. But do

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:7287 + case ParsedAttr::AT_AcquireHandle: +handleSimpleAttribute(S, D, AL); +break; NoQ wrote: > xazax.hun wrote: > > NoQ wrote: > >

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

NoQ added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:7287 + case ParsedAttr::AT_AcquireHandle: +handleSimpleAttribute(S, D, AL); +break; xazax.hun wrote: > NoQ wrote: > > The next obvious step here would be to type-check the

[clang] 1b38748 - [clang][IFS] Fixing unsupported emulation mode on clang-ppc64be-linux bot.

Author: Puyan Lotfi Date: 2019-11-19T19:27:46-05:00 New Revision: 1b387484b9b38a4a1e98a9d22a9a26065b0d184e URL: https://github.com/llvm/llvm-project/commit/1b387484b9b38a4a1e98a9d22a9a26065b0d184e DIFF: https://github.com/llvm/llvm-project/commit/1b387484b9b38a4a1e98a9d22a9a26065b0d184e.diff

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:7287 + case ParsedAttr::AT_AcquireHandle: +handleSimpleAttribute(S, D, AL); +break; NoQ wrote: > The next obvious step here would be

[clang] 69242e9 - clang/Modules: Sink ASTReadResult in ReadControlBlock, NFC

Author: Duncan P. N. Exon Smith Date: 2019-11-19T16:10:44-08:00 New Revision: 69242e986823e3fdd11a8e51f47f36bec714363c URL: https://github.com/llvm/llvm-project/commit/69242e986823e3fdd11a8e51f47f36bec714363c DIFF:

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

NoQ added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:7287 + case ParsedAttr::AT_AcquireHandle: +handleSimpleAttribute(S, D, AL); +break; The next obvious step here would be to type-check the declaration to make sure that it's actually

[PATCH] D70411: [analyzer][WIP] StrChecker: 31.c

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/cert/StrChecker.cpp:279 +if (PredNode->getState() == ErrorNode->getState()) { + IsFalsePositiveFound = true; + PR->markInvalid(nullptr, nullptr); Why is this a

[PATCH] D70368: [clang-tidy] Rewrite modernize-avoid-bind check

zturner updated this revision to Diff 230162. zturner added a comment. Forgot to remove spurious `llvm::` namespace qualifications. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70368/new/ https://reviews.llvm.org/D70368 Files:

[PATCH] D70470: [analyzer] Add FuchsiaHandleCheck to catch handle leaks, use after frees and double frees

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/FuchsiaHandleChecker.cpp:67 +// functions: +// 1. __attribute__((clang::acquire_handle)) |handle will be acquired +// 2.

[PATCH] D69948: [Checkers] Added support for freopen to StreamChecker.

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:201 +std::tie(StateRetNotNull, StateRetNull) = +CM.assumeDual(StateStreamNull, RetVal); +if (StateRetNull) { Mmm, wait, this doesn't look right to me. You

[PATCH] D70368: [clang-tidy] Rewrite modernize-avoid-bind check

zturner updated this revision to Diff 230161. zturner added a comment. Updated with suggestions from @aaron.ballman CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70368/new/ https://reviews.llvm.org/D70368 Files: clang-tools-extra/clang-tidy/modernize/AvoidBindCheck.cpp

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

xazax.hun created this revision. xazax.hun added reviewers: aaron.ballman, NoQ. xazax.hun added a project: clang. Herald added subscribers: Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, whisperity. These are three new

[PATCH] D70470: [analyzer] Add FuchsiaHandleCheck to catch handle leaks, use after frees and double frees

xazax.hun created this revision. xazax.hun added reviewers: NoQ, haowei. xazax.hun added a project: clang. Herald added subscribers: Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, whisperity, mgorny. This check is based on

[clang] 29fd1e1 - [clang][IFS] Attempting to fix missing 'orbis-ld' on scei-ps4-ubuntu bot.

Author: Puyan Lotfi Date: 2019-11-19T18:34:49-05:00 New Revision: 29fd1e1f4a372f3870e054da24b57a4f45861808 URL: https://github.com/llvm/llvm-project/commit/29fd1e1f4a372f3870e054da24b57a4f45861808 DIFF: https://github.com/llvm/llvm-project/commit/29fd1e1f4a372f3870e054da24b57a4f45861808.diff

[PATCH] D69869: [clang-tools-extra] fix the check for if '-latomic' is necessary

gokturk added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69869/new/ https://reviews.llvm.org/D69869 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D70467: [Distro] Bypass distro detection on Windows

rnk added a comment. I'd rather avoid the ifdef if possible. I looked to see where these come from: $ git grep -l Distro ../clang/lib/Driver/ ../clang/lib/Driver/CMakeLists.txt ../clang/lib/Driver/Distro.cpp ../clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D70144: clang-tidy: modernize-use-equals-default avoid adding redundant semicolons

poelmanc added a subscriber: MyDeveloperDay. poelmanc added a comment. Just a quick update, I made some progress addressing the architectural limitation of `AnnotatedLines` and `evaluate()`. I changed the `AnnotatedLines` constructor to also take a `Line *PrevAnnotatedLine` argument and set

[clang] 377d70c - [clang][IFS] Fixing failing bots that do not have PPC target or "orbis-ld"

Author: Puyan Lotfi Date: 2019-11-19T18:12:07-05:00 New Revision: 377d70cdea733e36107e99d9148864d24797d51c URL: https://github.com/llvm/llvm-project/commit/377d70cdea733e36107e99d9148864d24797d51c DIFF: https://github.com/llvm/llvm-project/commit/377d70cdea733e36107e99d9148864d24797d51c.diff

[PATCH] D70149: [C-index] Fix annotate-deep-statements test in Debug target

aganea added a comment. Thanks Reid! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70149/new/ https://reviews.llvm.org/D70149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] ea8e028 - [clang][IFS] Driver Pipeline: generate stubs after standard pipeline (2)

Author: Puyan Lotfi Date: 2019-11-19T17:47:38-05:00 New Revision: ea8e02822341e2421b94167d828d3f224e767424 URL: https://github.com/llvm/llvm-project/commit/ea8e02822341e2421b94167d828d3f224e767424 DIFF: https://github.com/llvm/llvm-project/commit/ea8e02822341e2421b94167d828d3f224e767424.diff

[PATCH] D70149: [C-index] Fix annotate-deep-statements test in Debug target

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm I was wondering if Richard would add something since he created this stack size management code, but in the absence of that, this looks right to me. Repository: rG LLVM Github Monorepo

[PATCH] D70467: [Distro] Bypass distro detection on Windows

aganea created this revision. aganea added reviewers: sylvestre.ledru, rnk. Herald added a project: clang. Herald added a subscriber: cfe-commits. This skips distro detection on Windows, thus saving a few `stat` calls for each invocation of `clang.exe`. Repository: rG LLVM Github Monorepo

[PATCH] D68997: Allow searching for prebuilt implicit modules.

arames added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68997/new/ https://reviews.llvm.org/D68997 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D70245: [OPENMP50]Add device/kind context selector support.

ABataev added a comment. More comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70245/new/ https://reviews.llvm.org/D70245 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69950: Reapply "Fix crash on switch conditions of non-integer types in templates"

eandrews added a comment. In D69950#1752044 , @gribozavr2 wrote: > In D69950#1751894 , @eandrews wrote: > > > In D69950#1751859 , @gribozavr2 > > wrote: > > > > > > hence

[PATCH] D70320: [Analyzer] [NFC] Iterator Checkers - Separate iterator modeling and the actual checkers

NoQ added a comment. I love how this checker is pioneering in so many ways. Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:1308-1318 +ProgramStateRef removeIteratorPosition(ProgramStateRef State, const SVal ) { if (auto Reg = Val.getAsRegion()) {

[PATCH] D69825: [Clang][Driver] Bypass cc1 process and re-enter driver main

aganea updated this revision to Diff 230143. aganea marked 10 inline comments as done. aganea edited the summary of this revision. aganea added a comment. Addressed @hans' comments. I've also added a script in the summary, if you'd like to reproduce the results on your end, and to ensure we all

[PATCH] D69825: [Clang][Driver] Bypass cc1 process and re-enter driver main

aganea added inline comments. Comment at: clang/lib/Driver/Job.cpp:347 +StringRef DriverExe = llvm::sys::path::stem(D.ClangExecutable); +if (CommandExe.equals_lower(DriverExe)) +CC1Main = Driver::CC1Main; hans wrote: > Now that we're not calling

Re: [PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

The C bindings, in general, don't have stability guarantees outside of a few cases. Whitequark owns all of this now though :) -eric On Tue, Nov 19, 2019 at 1:38 PM Adrian Prantl via Phabricator wrote: > > aprantl added a subscriber: echristo. > aprantl added a comment. > > In D70111#1752215

[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

aprantl added a subscriber: echristo. aprantl added a comment. In D70111#1752215 , @dblaikie wrote: > I have some vague recollection that the DWARF C bindings didn't have > stability guarantees? Does that sound familiar to anyone? What sort of > changes

[PATCH] D69330: [AST] Add RecoveryExpr to retain expressions on semantic errors

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. In D69330#1752089 , @ilya-biryukov wrote: > In D69330#1746137 , @rsmith wrote: > > > I would prefer that we

[PATCH] D70285: Wrap C APIs with pragmas enforcing -Werror=strict-prototypes

dexonsmith closed this revision. dexonsmith added a comment. In D70285#1752361 , @dexonsmith wrote: > In D70285#1752164 , @Bigcheese wrote: > > > lgtm as long as other compilers don't warn on unknown pragmas by

[clang] 8c48405 - Wrap C APIs with pragmas enforcing -Werror=strict-prototypes

Author: Duncan P. N. Exon Smith Date: 2019-11-19T13:18:43-08:00 New Revision: 8c48405069085a2c8b6b80816eda99e5dad31fc1 URL: https://github.com/llvm/llvm-project/commit/8c48405069085a2c8b6b80816eda99e5dad31fc1 DIFF:

[PATCH] D70285: Wrap C APIs with pragmas enforcing -Werror=strict-prototypes

dexonsmith added a comment. In D70285#1752164 , @Bigcheese wrote: > lgtm as long as other compilers don't warn on unknown pragmas by default. godbolt.org says that GCC doesn't have `-Wunknown-pragmas` by default, but it is in `-Wall`. I'd better guard

[clang] d08c056 - [OPENMP50]Add if clause in simd directive.

Author: Alexey Bataev Date: 2019-11-19T15:58:19-05:00 New Revision: d08c056695a59fb1cfc7ccc9a2784bb9a6514551 URL: https://github.com/llvm/llvm-project/commit/d08c056695a59fb1cfc7ccc9a2784bb9a6514551 DIFF: https://github.com/llvm/llvm-project/commit/d08c056695a59fb1cfc7ccc9a2784bb9a6514551.diff

[PATCH] D70340: Add a key method to Sema to optimize debug info size

This revision was automatically updated to reflect the committed changes. Closed by commit rG586f65d31f32: Add a key method to Sema to optimize debug info size (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70340/new/

[PATCH] D69586: [profile] Support online merging with continuous sync mode

vsk marked an inline comment as done. vsk added inline comments. Comment at: compiler-rt/lib/profile/InstrProfilingFile.c:419 + * the open file object \p File. */ +static int writeProfileWithFileObject(const char *Filename, FILE *File) { + setProfileFile(File);

[PATCH] D70340: Add a key method to Sema to optimize debug info size

rnk marked an inline comment as done. rnk added inline comments. Comment at: clang/include/clang/Sema/Sema.h:335 + /// A key method to reduce duplicate type info from Sema. + virtual void anchor(); hans wrote: > I worry that this is going to look obscure to

[clang] 568db78 - [CGDebugInfo] Emit subprograms for decls when AT_tail_call is understood (reland with fixes)

Author: Vedant Kumar Date: 2019-11-19T12:49:27-08:00 New Revision: 568db780bb7267651a902da8e85bc59fc89aea70 URL: https://github.com/llvm/llvm-project/commit/568db780bb7267651a902da8e85bc59fc89aea70 DIFF: https://github.com/llvm/llvm-project/commit/568db780bb7267651a902da8e85bc59fc89aea70.diff

[PATCH] D70259: [Error] Add source location to cantFail

hintonda updated this revision to Diff 230131. hintonda added a comment. - Add back original llvm::cantFail signatures so they'll still be Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70259/new/ https://reviews.llvm.org/D70259 Files:

[clang] 586f65d - Add a key method to Sema to optimize debug info size

Author: Reid Kleckner Date: 2019-11-19T12:42:33-08:00 New Revision: 586f65d31f32ca6bc8cfdb8a4f61bee5057bf6c8 URL: https://github.com/llvm/llvm-project/commit/586f65d31f32ca6bc8cfdb8a4f61bee5057bf6c8 DIFF: https://github.com/llvm/llvm-project/commit/586f65d31f32ca6bc8cfdb8a4f61bee5057bf6c8.diff

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc updated this revision to Diff 230128. mibintc added a comment. Here's an update in response to comments from @michele.scandale I fixed the assertion error and added a test case I fixed the setting of ftrapping-math in CodeGenOpts I deleted an incorrect comment I added a diagnostic when

[PATCH] D70340: Add a key method to Sema to optimize debug info size

rnk updated this revision to Diff 230130. rnk added a comment. - add final, tweak comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70340/new/ https://reviews.llvm.org/D70340 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/Sema.cpp

[PATCH] D70340: Add a key method to Sema to optimize debug info size

rnk added a comment. Oh, yeah, I forgot this causes tons of -Wdelete-non-virtual-dtor warnings, so I'll have to look into that before landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70340/new/ https://reviews.llvm.org/D70340

[PATCH] D68351: [profile] Add a mode to continuously sync counter updates to a file

vsk marked an inline comment as done. vsk added inline comments. Comment at: compiler-rt/lib/profile/InstrProfilingFile.c:377 +#if defined(__Fuchsia__) || defined(_WIN32) + PROF_ERR("%s\n", "Continuous mode not yet supported on Fuchsia or Windows."); +#else //

[PATCH] D70259: [Error] Add source location to cantFail

hintonda updated this revision to Diff 230125. hintonda added a comment. Herald added subscribers: lldb-commits, cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added projects: clang, LLDB. - Replace macro magic with matching 3-parameter template functions. - Refactor cantFail move

[PATCH] D69586: [profile] Support online merging with continuous sync mode

aganea added inline comments. Comment at: compiler-rt/lib/profile/InstrProfilingFile.c:419 + * the open file object \p File. */ +static int writeProfileWithFileObject(const char *Filename, FILE *File) { + setProfileFile(File); These two functions are not used

[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

NoQ added a comment. See also https://llvm.org/docs/DeveloperPolicy.html#current-contributors-transfering-from-svn. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59516/new/ https://reviews.llvm.org/D59516 ___ cfe-commits mailing list

[PATCH] D68351: [profile] Add a mode to continuously sync counter updates to a file

dmajor added inline comments. Comment at: compiler-rt/lib/profile/InstrProfilingFile.c:377 +#if defined(__Fuchsia__) || defined(_WIN32) + PROF_ERR("%s\n", "Continuous mode not yet supported on Fuchsia or Windows."); +#else // defined(__Fuchsia__) || defined(_WIN32)

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

MyDeveloperDay updated this revision to Diff 230124. MyDeveloperDay added a comment. -update with missing files -clang-format test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D69810: [OpenCL] Fix address space for base method call (PR43145)

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:2721 + From = ImpCastExprToType(From, DestASTy, CK_AddressSpaceConversion, + From->getValueKind()).get(); +} Both the source and dest types here are

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

andrew.w.kaylor added inline comments. Comment at: llvm/include/llvm/IR/IRBuilder.h:262 Function *F = BB->getParent(); -if (!F->hasFnAttribute(Attribute::StrictFP)) { +if (F && !F->hasFnAttribute(Attribute::StrictFP)) { F->addFnAttr(Attribute::StrictFP);

[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

NoQ added a comment. You're now supposed to push directly to github. You might also have missed http://lists.llvm.org/pipermail/cfe-dev/2019-August/063219.html. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59516/new/ https://reviews.llvm.org/D59516

[clang] c444a01 - fixe leak found by asan build bot

Author: Tyker Date: 2019-11-19T21:11:37+01:00 New Revision: c444a01df3553d9405cbd4dac3c1074a71e6c2e1 URL: https://github.com/llvm/llvm-project/commit/c444a01df3553d9405cbd4dac3c1074a71e6c2e1 DIFF: https://github.com/llvm/llvm-project/commit/c444a01df3553d9405cbd4dac3c1074a71e6c2e1.diff LOG:

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc marked 4 inline comments as done. mibintc added a comment. inline replies to Michele, will upload a new patch shortly Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2408 +case options::OPT_frounding_math: + // The default setting for frounding-math is True

[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

dblaikie added a comment. I have some vague recollection that the DWARF C bindings didn't have stability guarantees? Does that sound familiar to anyone? What sort of changes have been made to them in the past? Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp:804-810 +

[PATCH] D70340: Add a key method to Sema to optimize debug info size

rnk added a comment. In D70340#1751148 , @hans wrote: > Nice! > > Silly questions, but for my own education: I thought the key function concept > only existed in the Itanium ABI, but from your numbers it sounds like it's a > concept, at least for debug

[PATCH] D69855: [clang-tidy] Fix llvm-namespace-comment for macro expansions

twardakm marked 9 inline comments as done. twardakm added a comment. Thanks for the review! @aaron.ballman take a look at new revision and let me know if something needs to be fixed. Thanks! Comment at:

[PATCH] D70285: Wrap C APIs with pragmas enforcing -Werror=strict-prototypes

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm as long as other compilers don't warn on unknown pragmas by default. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70285/new/ https://reviews.llvm.org/D70285

[PATCH] D69855: [clang-tidy] Fix llvm-namespace-comment for macro expansions

twardakm updated this revision to Diff 230113. twardakm added a comment. Apply Aaron's comments - Fix missing namespace to macro definition instead of extension - Print macro definition also in warning message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D70440: [Driver] Use VFS to check if sanitizer blacklists exist

jkorous added inline comments. Comment at: clang/unittests/Driver/SanitizerArgsTest.cpp:100 + Contains(StrEq(std::string("-fsanitize-system-blacklist=") + + ASanBlacklist))); + // User blacklists should also be added.

[PATCH] D69648: Add VFS support for sanitizers' blacklist' 2

jkorous added a comment. Ahh, right. I originally wanted to support `-ivfsoverlay` in Driver as it seemed reasonable to check the existence of blacklist in Driver and open it in cc1 using the same fs. I got talked out of it and I didn't touch the Driver but seems like I should've replaced the

[PATCH] D69620: Add AIX assembler support

stevewan marked an inline comment as done. stevewan added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:45 + // Acccept any mixture of instructions. + CmdArgs.push_back("-many"); + Xiangling_L wrote: > GCC invokes system assembler also with

[PATCH] D69330: [AST] Add RecoveryExpr to retain expressions on semantic errors

ilya-biryukov marked 13 inline comments as done. ilya-biryukov added a comment. In D69330#1746137 , @rsmith wrote: > I would prefer that we have dedicated tests for them rather than scattering > the tests throughout the existing test suite (for example,

[PATCH] D69959: [C-index] Fix test when using Debug target & MSVC STL

This revision was automatically updated to reflect the committed changes. Closed by commit rGf55cd39f1913: [C-index] Fix test when using Debug target MSVC STL (authored by aganea). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69959/new/

[PATCH] D69330: [AST] Add RecoveryExpr to retain expressions on semantic errors

ilya-biryukov updated this revision to Diff 230104. ilya-biryukov marked 7 inline comments as done. ilya-biryukov added a comment. - Rename ActOnSemanticError to CreateRecoveryExpr - Do not print anything for recovery expr in TextNodeDumper - canThrow(RecoveryExpr) now returns CT_Dependent -

[clang] f55cd39 - [C-index] Fix test when using Debug target & MSVC STL

Author: Alexandre Ganea Date: 2019-11-19T13:30:40-05:00 New Revision: f55cd39f19134392b16bc1fd6c558214778a3bb8 URL: https://github.com/llvm/llvm-project/commit/f55cd39f19134392b16bc1fd6c558214778a3bb8 DIFF:

[PATCH] D69950: Reapply "Fix crash on switch conditions of non-integer types in templates"

gribozavr2 added a comment. In D69950#1751894 , @eandrews wrote: > In D69950#1751859 , @gribozavr2 > wrote: > > > > hence not throwing the warning on any platform? > > > > The way I read the buildbot breakage, an

[PATCH] D69938: [OpenCL] Use __generic addr space when generating internal representation of lambda

rjmccall added a comment. Yes, in that case copy-elision into the global variable is guaranteed. You can write arbitrary expressions in global initializers, however, and those can use temporary lambdas. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69938/new/

[PATCH] D68155: [clang][NFC] Make various uses of Regex const

nlguillemot added a comment. In D68155#1751826 , @thopre wrote: > My sincere apologies, I forgot to change the author in the commit. I don't > often commit on behalf of others so didn't think enough. No worries. Thanks again for helping with the

[PATCH] D69810: [OpenCL] Fix address space for base method call (PR43145)

svenvh updated this revision to Diff 230096. svenvh edited the summary of this revision. svenvh added a comment. Rework fix to insert an addrspace conversion node into the AST instead of catching the addrspace cast in CGCall. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69810/new/

[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

aprantl added a comment. There are two options here: - leave the C bindings as is (fine with me) - add an overloaded function to the C bindings that has the extra argument (also fine with me). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69493: Add -fconvergent-functions flag

arsenm closed this revision. arsenm added a comment. e531750c6cf9ab6ca987ffbfe100b1d766269eb5 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69493/new/ https://reviews.llvm.org/D69493

[clang] e531750 - clang: Add -fconvergent-functions flag

Author: Matt Arsenault Date: 2019-11-19T23:20:15+05:30 New Revision: e531750c6cf9ab6ca987ffbfe100b1d766269eb5 URL: https://github.com/llvm/llvm-project/commit/e531750c6cf9ab6ca987ffbfe100b1d766269eb5 DIFF:

[PATCH] D68206: [clang] Remove the DIFlagArgumentNotModified debug info flag

vsk accepted this revision. vsk added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68206/new/ https://reviews.llvm.org/D68206 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

  1   2   3   >