[PATCH] D70764: build: reduce CMake handling for zlib

labath added a comment. Please take a look at D70519 for the issues with this approach. Also, while I do agree with you that we should not auto-select dependencies, I think this runs contrary to the llvm philosophy that the default built should "just work" (I

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

jdoerfert marked 4 inline comments as done. jdoerfert added inline comments. Comment at: clang/include/clang/Basic/OpenMPKinds.h:23 /// OpenMP directives. -enum OpenMPDirectiveKind { -#define OPENMP_DIRECTIVE(Name) \ - OMPD_##Name, -#define OPENMP_DIRECTIVE_EXT(Name, Str) \ -

[PATCH] D70765: LTOVisibility.rst: fix up syntax in example

dankamongmen created this revision. dankamongmen added a project: LLVM. Herald added subscribers: cfe-commits, dexonsmith, steven_wu, hiraditya, inglorion, mehdi_amini. Herald added a project: clang. dankamongmen added a reviewer: pcc. Pretty self-evident. This example was missing an lparen.

[PATCH] D70764: build: reduce CMake handling for zlib

compnerd created this revision. compnerd added reviewers: beanz, smeenai. Herald added subscribers: lldb-commits, Sanitizers, hiraditya, mgorny. Herald added projects: clang, Sanitizers, LLDB, LLVM. Rather than handling zlib handling manually, use `find_package` from CMake to find zlib properly.

[PATCH] D70739: [OPENMP50]Add device/isa context selector support.

jdoerfert added a comment. Thanks for working on this! One nit and one concern below. Comment at: clang/include/clang/Sema/Sema.h:9320 using OMPCtxSelectorData = - OpenMPCtxSelectorData, ExprResult>; + OpenMPCtxSelectorData, ExprResult>; I would

[PATCH] D70763: [clang][IFS] Allow 2 output files when using -o and -c with clang IFS stubs.

plotfi created this revision. plotfi added a reviewer: compnerd. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch allows for -o to be used with -c when compiling with clang interface stubs enabled. This is because the second file will be an intermediate ifs

[PATCH] D65410: [PassManager] First Pass implementation at -O1 pass pipeline

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit rGfd39b1bb20ce: Revert Revert As a follow-up to my initial mail to llvm-dev heres a first… (authored by echristo). Herald

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

MaskRay added a comment. The ugly path separator pattern `{{(/|)}}` appears in 60+ tests. Can we teach clang and other tools to 1. accept both `/` and `\` input 2. but only output `/` on Windows? We can probably remove `llvm::sys::path::Style::{windows,posix,native}` from

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

MaskRay added a comment. Does this work on Windows? --- i/clang/test/Preprocessor/file_test.c +++ w/clang/test/Preprocessor/file_test.c @@ -1,8 +1,7 @@ -// XFAIL: system-windows // RUN: %clang -E -ffile-prefix-map=%p=/UNLIKELY_PATH/empty -c -o - %s | FileCheck %s // RUN: %clang -E

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

MaskRay added a comment. In D49466#1761044 , @thakis wrote: > There's still one failing test on Windows after the fix attempt: > http://45.33.8.238/win/3052/step_6.txt > > Please take a look and revert if it's not an easy fix. (And please watch bots >

[clang] 82b4dc0 - XFAIL a test on Windows

Author: Fangrui Song Date: 2019-11-26T19:55:50-08:00 New Revision: 82b4dc0256d4ef27692308392766b2970249d9cf URL: https://github.com/llvm/llvm-project/commit/82b4dc0256d4ef27692308392766b2970249d9cf DIFF: https://github.com/llvm/llvm-project/commit/82b4dc0256d4ef27692308392766b2970249d9cf.diff

[PATCH] D70747: [Fuchsia] Don't fail for unknown architectures

This revision was automatically updated to reflect the committed changes. Closed by commit rGf7aeca45b23c: [Fuchsia] Dont fail for unknown architectures (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70747/new/

[clang] f7aeca4 - [Fuchsia] Don't fail for unknown architectures

Author: Petr Hosek Date: 2019-11-26T19:16:40-08:00 New Revision: f7aeca45b23c09522afd9f88c6782b2a2acd0783 URL: https://github.com/llvm/llvm-project/commit/f7aeca45b23c09522afd9f88c6782b2a2acd0783 DIFF: https://github.com/llvm/llvm-project/commit/f7aeca45b23c09522afd9f88c6782b2a2acd0783.diff

[PATCH] D70729: Workaround for EvalInfo ctor for MSVC 2017

This revision was automatically updated to reflect the committed changes. Closed by commit rGded249049429: Workaround for EvalInfo ctor for MSVC 2017 (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] ded2490 - Workaround for EvalInfo ctor for MSVC 2017

Author: Yaxun (Sam) Liu Date: 2019-11-26T21:43:29-05:00 New Revision: ded249049429a26d3748926c04bd7169f0170714 URL: https://github.com/llvm/llvm-project/commit/ded249049429a26d3748926c04bd7169f0170714 DIFF:

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

thakis added a comment. There's still one failing test on Windows after the fix attempt: http://45.33.8.238/win/3052/step_6.txt Please take a look and revert if it's not an easy fix. (And please watch bots after committing stuff.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 7ddc628 - [Preprocessor] Fix backslash tests on Windows after D49466

Author: Fangrui Song Date: 2019-11-26T17:27:58-08:00 New Revision: 7ddc6287a08ef758d66acb20d006c9ab0c579fcc URL: https://github.com/llvm/llvm-project/commit/7ddc6287a08ef758d66acb20d006c9ab0c579fcc DIFF: https://github.com/llvm/llvm-project/commit/7ddc6287a08ef758d66acb20d006c9ab0c579fcc.diff

[PATCH] D70755: [LifetimeAnalysis] Fix PR44150

xazax.hun created this revision. xazax.hun added reviewers: gribozavr, mgehre. xazax.hun added a project: clang. Herald added subscribers: Szelethus, Charusso, gamesh411, dkrupp, rnkovacs. We really wanted to avoid special handling of references but it looks like this is inevitable. The main

[clang] 3bb24bf - Fix tests on Windows after D49466

Author: Fangrui Song Date: 2019-11-26T16:15:39-08:00 New Revision: 3bb24bf25767ef5bbcef958b484e7a06d8689204 URL: https://github.com/llvm/llvm-project/commit/3bb24bf25767ef5bbcef958b484e7a06d8689204 DIFF: https://github.com/llvm/llvm-project/commit/3bb24bf25767ef5bbcef958b484e7a06d8689204.diff

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

dankm added a comment. In D49466#1760860 , @MaskRay wrote: > Add back remapDIPath that was unintentionally deleted by D69213 > , caught by a test. > > Small adjustment of the code Right. Can't believe I missed that.

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

MaskRay updated this revision to Diff 231142. MaskRay added a comment. Minimize diff in Options.td Properly rebase remapDIPath on top of D69213 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49466/new/

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

This revision was automatically updated to reflect the committed changes. Closed by commit rG6c92cdff7225: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map (authored by dankm, committed by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 6c92cdf - Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

Author: Dan McGregor Date: 2019-11-26T15:17:49-08:00 New Revision: 6c92cdff72251a7d13ab3958b04fba72dfcaebb1 URL: https://github.com/llvm/llvm-project/commit/6c92cdff72251a7d13ab3958b04fba72dfcaebb1 DIFF: https://github.com/llvm/llvm-project/commit/6c92cdff72251a7d13ab3958b04fba72dfcaebb1.diff

[PATCH] D70748: [clang test] Do not assume default target

thopre created this revision. thopre added a reviewer: thegameg. Herald added a project: clang. Herald added a subscriber: cfe-commits. clang test Driver/darwin-opt-record.c assumes the default target is x86_64 by its uses of the -arch x86_64 and -arch x86_64h and thus fail on systems where it is

[PATCH] D70693: [scan-build-py] Set of small fixes

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/tools/scan-build-py/libscanbuild/clang.py:47 cmd.insert(1, '-###') +cmd.append('-fno-color-diagnostics') Alternative would

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

MaskRay updated this revision to Diff 231140. MaskRay added a comment. Add back remapDIPath that was unintentionally deleted by D69213 , caught by a test. Small adjustment of the code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D70747: [Fuchsia] Don't fail for unknown architectures

phosek created this revision. phosek added a reviewer: leonardchan. Herald added subscribers: cfe-commits, s.egerton, simoncook. Herald added a project: clang. When selecting the set of default sanitizers, don't fail for unknown architectures. This may be the case e.g. with x86_64-unknown-fuchsia

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

MaskRay added a comment. In D49466#1760765 , @dankm wrote: > Ping? The tests need fixing... I can commit it. Now that we've migrated to the llvm monorepo, the git commit message can retain the author info properly... Repository: rG LLVM Github

[PATCH] D70746: [clangd] Highlighting dependent types in more contexts

nridge created this revision. nridge added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D70746 Files:

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

rsmith added inline comments. Comment at: clang/include/clang/AST/Expr.h:1033-1035 + bool IsCausedByImmediateInvocation() const { +return ConstantExprBits.IsCausedByImmediateInvocation; + } I'd remove the "CausedBy" here -- the `ConstantExpr` is our

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

dankm added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49466/new/ https://reviews.llvm.org/D49466 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D70203: [AST] Attach comment in `/** doc */ typedef struct A {} B` to B as well as A.

chrish_ericsson_atx added a comment. In D70203#1760299 , @bjope wrote: > Hi @sammccall . > Just a heads up. Looks like this might have caused: > https://bugs.llvm.org/show_bug.cgi?id=44143 . Yes indeed. I locally reverted commit a433e714

[PATCH] D70675: [AIX] Disable clang python binding tests

This revision was automatically updated to reflect the committed changes. Closed by commit rGa38fc6164879: [AIX] Disable clang python binding tests (authored by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70675/new/

[PATCH] D70740: [clangd] Find reference to template parameter in 'sizeof...' expression

nridge added a comment. Fixes https://github.com/clangd/clangd/issues/213 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70740/new/ https://reviews.llvm.org/D70740 ___ cfe-commits mailing list

[clang] a38fc61 - [AIX] Disable clang python binding tests

Author: David Tenty Date: 2019-11-26T15:30:38-05:00 New Revision: a38fc61648797a10629ed160779b5df6b8d577e7 URL: https://github.com/llvm/llvm-project/commit/a38fc61648797a10629ed160779b5df6b8d577e7 DIFF: https://github.com/llvm/llvm-project/commit/a38fc61648797a10629ed160779b5df6b8d577e7.diff

[PATCH] D70740: [clangd] Find reference to template parameter in 'sizeof...' expression

nridge created this revision. nridge added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D70740 Files:

[PATCH] D70470: [analyzer] Add FuchsiaHandleCheck to catch handle leaks, use after frees and double frees

xazax.hun added a comment. Ok, now I have some real world experience with the results of the check. The false positive ratio for double free and use after free seems to be quite good but the handle leak part is almost unusable at this point. The main problem is somewhat anticipated, we are not

[PATCH] D70739: [OPENMP50]Add device/isa context selector support.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added a subscriber: guansong. Herald added a project: clang. Added basic support for device/isa context selector. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D70739 Files:

[PATCH] D70675: [AIX] Disable clang python binding tests

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. Agreed. LGTM as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70675/new/ https://reviews.llvm.org/D70675

[PATCH] D70687: [WebAssembly] Add an llvm-lto path for compiler-rt.

sunfish abandoned this revision. sunfish added a comment. I've done some more experimenting with this, and it turns out not to work very well, because calls to these functions get generated after LTO runs, so I'll abandon this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D70729: Workaround for EvalInfo ctor for MSVC 2017

hliao accepted this revision. hliao added a comment. This revision is now accepted and ready to land. LGTM, anyway calling a virtual function inside the constructor is not encouraged. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70729/new/ https://reviews.llvm.org/D70729

[PATCH] D70675: [AIX] Disable clang python binding tests

jasonliu accepted this revision. jasonliu added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70675/new/ https://reviews.llvm.org/D70675

[PATCH] D55484: ComputeLineNumbers: delete SSE2 vectorization

MaskRay added a comment. In D55484#1760432 , @shi-yan wrote: > I'm hitting a crash by this code, > > getting: > > exception thrown: RuntimeError: unreachable,RuntimeError: unreachable > at ComputeLineNumbers(clang::DiagnosticsEngine&, >

[PATCH] D70729: Workaround for EvalInfo ctor for MSVC 2017

yaxunl updated this revision to Diff 231101. yaxunl added a comment. add a test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70729/new/ https://reviews.llvm.org/D70729 Files: clang/lib/AST/ExprConstant.cpp clang/test/Sema/eval-info.c Index: clang/test/Sema/eval-info.c

[PATCH] D70568: [Support] Possibly use exception handler in the Crash Recovery Context in the same way as global exceptions

aganea added a comment. In D70568#1760185 , @hans wrote: > Do I understand correctly that the main point is to get a stack trace when > CrashRecoveryContext::RunSafely() fails, instead of just returning an error? Correct. Otherwise, when running with

[PATCH] D70729: Workaround for EvalInfo ctor for MSVC 2017

yaxunl created this revision. yaxunl added reviewers: rjmccall, hliao. Current EvalInfo ctor causes EnableNewConstInterp to be true even though it is supposed to be false on MSVC 2017. This is because a virtual function getLangOpts() is called in member initializer lists, whereas on MSVC member

[PATCH] D69938: [OpenCL] Use __generic addr space when generating internal representation of lambda

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:891 +if (getLangOpts().OpenCL) + EPI.TypeQuals.addAddressSpace(LangAS::opencl_generic); + Anastasia wrote: > rjmccall wrote: > > This should probably check that there isn't

[PATCH] D70605: [OpenCL] Fix address space for implicit conversion (PR43145)

rjmccall added a comment. Great. Could you add that to the test, then, just to make sure we don't regress it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70605/new/ https://reviews.llvm.org/D70605 ___ cfe-commits mailing list

[PATCH] D70727: [clangd] Keep go-to-definition working at the end of an identifier (fixes #194)

nridge added a comment. By the way, may I get permissions to assign issues to myself (and make other such metadata changes to issues) on github? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70727/new/ https://reviews.llvm.org/D70727

[PATCH] D70728: [clang][IFS] Adding support for new clang interface stubs decl types.

plotfi created this revision. plotfi added a reviewer: compnerd. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adding support for NamespaceAliasDecl UnresolvedUsingTypenameDecl CXXDeductionGuideDecl ConstructorUsingShadowDecl Repository: rG LLVM Github Monorepo

[PATCH] D70726: [OpenMP50] Add parallel master construct

ABataev added a comment. Missing check for prohibited nesting of the barrier and worksharing directvies in the master regions. Plus, definitely no tests for this. Comment at: clang/include/clang/AST/StmtOpenMP.h:1857 + /// true if current directive has inner cancel

[PATCH] D70727: [clangd] Keep go-to-definition working at the end of an identifier (fixes #194)

nridge created this revision. nridge added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D70727 Files:

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

serge-sans-paille updated this revision to Diff 231092. serge-sans-paille added a comment. Handle all @Meinersbur comment, rebuild on github with extra flags pending. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61446/new/

[PATCH] D70725: [analyzer] Add path notes to FuchsiaHandleCheck

xazax.hun created this revision. xazax.hun added reviewers: NoQ, haowei. xazax.hun added a project: clang. Herald added subscribers: Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. xazax.hun added a reviewer: Szelethus.

[PATCH] D55484: ComputeLineNumbers: delete SSE2 vectorization

shi-yan added a comment. Herald added a project: LLVM. I'm hitting a crash by this code, getting: exception thrown: RuntimeError: unreachable,RuntimeError: unreachable at ComputeLineNumbers(clang::DiagnosticsEngine&, clang::SrcMgr::ContentCache*, llvm::BumpPtrAllocatorImpl&,

[PATCH] D70723: [clangd] Store index::SymbolKind in HoverInfo

merge_guards_bot added a comment. Build result: pass - 60291 tests passed, 0 failed and 732 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70726: [OpenMP50] Add parallel master construct

cchen created this revision. cchen added a reviewer: ABataev. Herald added subscribers: cfe-commits, jfb, arphaman, guansong, jholewinski. Herald added a reviewer: jdoerfert. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D70726 Files:

[PATCH] D70470: [analyzer] Add FuchsiaHandleCheck to catch handle leaks, use after frees and double frees

xazax.hun updated this revision to Diff 231089. xazax.hun added a comment. - Handle cases where the number of args/params mismatch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70470/new/ https://reviews.llvm.org/D70470 Files: clang/docs/analyzer/checkers.rst

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

aganea added a comment. In D69825#1760373 , @russell.gallop wrote: > It looks like the git apply didn't work, but the script continued so this was > a duff experiment, please ignore. I'll try to fix this and run it again. Thanks Russell! Can you try

[PATCH] D70723: [clangd] Store index::SymbolKind in HoverInfo

kadircet created this revision. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. LSP's SymbolKind has some shortcomings when it comes to C++ types, index::SymbolKind has more detailed info like Destructor, Parameter,

[PATCH] D69878: Consoldiate internal denormal flushing controls

Anastasia added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1775 -if (getLangOpts().OpenCL) - FuncAttrs.addAttribute("denorms-are-zero", - llvm::toStringRef(CodeGenOpts.FlushDenorm)); arsenm wrote: > Anastasia

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

russell.gallop added a comment. In D69825#1760279 , @russell.gallop wrote: > So in this case it saved 0.5% of time. Using the previous maths, with 2378 > clang-cl jobs, this implies process creation time of 29ms. This was fairly > soon after a reboot.

[clang] 49a2b2a - [OPENMP]Remove tab in message, NFC.

Author: Alexey Bataev Date: 2019-11-26T11:37:36-05:00 New Revision: 49a2b2a3d2c869cb10407c480fff2f832e080018 URL: https://github.com/llvm/llvm-project/commit/49a2b2a3d2c869cb10407c480fff2f832e080018 DIFF: https://github.com/llvm/llvm-project/commit/49a2b2a3d2c869cb10407c480fff2f832e080018.diff

[PATCH] D70424: clang/AMDGPU: Fix default for frame-pointer attribute

scott.linder added a comment. In D70424#1759379 , @t-tye wrote: > @scott.linder can answer about the -g question, but I would expect that the > CFI is capable of describing the address of the CFA regardless of whether > there is a frame pointer by

[PATCH] D46027: [clang-tidy] Fix PR35824

xazax.hun updated this revision to Diff 231078. xazax.hun added a comment. Herald added subscribers: Charusso, gamesh411. - Use matcher. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D46027/new/ https://reviews.llvm.org/D46027 Files:

[clang] 87c3f4a - [OPENMP]Simplify printing of declare variant attribute, NFC.

Author: Alexey Bataev Date: 2019-11-26T11:35:12-05:00 New Revision: 87c3f4a5e0bb53ca0d9799ca627e0897b10a82b3 URL: https://github.com/llvm/llvm-project/commit/87c3f4a5e0bb53ca0d9799ca627e0897b10a82b3 DIFF: https://github.com/llvm/llvm-project/commit/87c3f4a5e0bb53ca0d9799ca627e0897b10a82b3.diff

[PATCH] D70203: [AST] Attach comment in `/** doc */ typedef struct A {} B` to B as well as A.

bjope added a comment. Hi @sammccall . Just a heads up. Looks like this might have caused: https://bugs.llvm.org/show_bug.cgi?id=44143 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70203/new/ https://reviews.llvm.org/D70203

[PATCH] D70157: Align branches within 32-Byte boundary

jyknight added a comment. I have some other concerns about the code itself, but after pondering this a little bit, I'd like to instead bring up some rather more general concerns about the overall approach used here -- with some suggestions. (As these comments are not really comments on the

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

russell.gallop added a comment. In D69825#1758949 , @aganea wrote: > Thanks for the feedback Russell! > > Can you possibly try again with `/MT`? (ie. `-DLLVM_USE_CRT_RELEASE=MT`) I tried adding this to my stage 1 builds and it didn't make any

[clang] a913e87 - [OPENMP]Fix PR44133: crash on lambda reductions in templates.

Author: Alexey Bataev Date: 2019-11-26T10:55:54-05:00 New Revision: a913e872d6e7044ae77e55c45ab3ea5304eb7262 URL: https://github.com/llvm/llvm-project/commit/a913e872d6e7044ae77e55c45ab3ea5304eb7262 DIFF: https://github.com/llvm/llvm-project/commit/a913e872d6e7044ae77e55c45ab3ea5304eb7262.diff

[clang-tools-extra] aa0e92e - [clang-tidy] Use range-for for check registration. NFC

Author: Alexander Kornienko Date: 2019-11-26T16:34:23+01:00 New Revision: aa0e92e1f7069834852c08fdd32a92258e30555c URL: https://github.com/llvm/llvm-project/commit/aa0e92e1f7069834852c08fdd32a92258e30555c DIFF:

[PATCH] D70605: [OpenCL] Fix address space for implicit conversion (PR43145)

svenvh added a comment. In D70605#1759614 , @rjmccall wrote: > Is there a similar problem with reference parameters? It doesn't seem so, patching the test as follows gives reasonable output. @@ -73,8 +73,10 @@ void pr43145_3(int n) { // Implicit

[PATCH] D68862: [ARM] Allocatable Global Register Variables for ARM

carwil added a comment. Hi @efriedma, thanks your comments. You're right, that was hasty of me. Apologies for that, it won't happen again. RE: R6 Case in point: you're right. We're definitely not handling this correctly. I'll revert the patch, or

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

kadircet added inline comments. Comment at: clang/lib/Tooling/ExpandResponseFilesCompilationDatabase.cpp:167 +for (auto : Cmds) { + expandResponseFiles(Cmd, Tokenizer); +} lh123 wrote: > lh123 wrote: > > lh123 wrote: > > > kadircet wrote: > > > >

[PATCH] D70568: [Support] Possibly use exception handler in the Crash Recovery Context in the same way as global exceptions

hans added a comment. > This is a support patch for D69825 . Thanks for breaking this out! > It handles an exception in the same way as the global exception handler (same > side-effect, print call stack & cleanup), and can return the exception code. I'm not

[PATCH] D66564: [clang-tidy] new altera struct pack align check

aaron.ballman added inline comments. Comment at: clang-tidy/altera/StructPackAlignCheck.cpp:66-68 + // FIXME: Express this as CharUnit rather than a hardcoded 8-bits (Rshift3)i + // After computing the minimum size in bits, check for an existing alignment + // flag.

[PATCH] D70041: register cuda language activation event and activate for .cuh files

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. sorry for the delay, looks good, one more nit. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts:91 { scheme: 'file', language: 'cpp'

[PATCH] D70547: [ARM][MVE][Intrinsics] Add MVE VAND/VORR/VORN/VEOR/VBIC intrinsics.

simon_tatham accepted this revision. simon_tatham added a comment. This revision is now accepted and ready to land. LGTM, though I spotted a couple of even tinier last-minute nits. Comment at: clang/include/clang/Basic/arm_mve.td:68 +// Vector and UVector may be different

[PATCH] D70547: [ARM][MVE][Intrinsics] Add MVE VAND/VORR/VORN/VEOR/VBIC intrinsics.

MarkMurrayARM updated this revision to Diff 231057. MarkMurrayARM added a comment. Respond to review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70547/new/ https://reviews.llvm.org/D70547 Files: clang/include/clang/Basic/arm_mve.td

[PATCH] D70546: [ARM][MVE][Intrinsics] Add MVE VMUL intrinsics.

MarkMurrayARM updated this revision to Diff 231056. MarkMurrayARM added a comment. Respond to review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70546/new/ https://reviews.llvm.org/D70546 Files: clang/include/clang/Basic/arm_mve.td

[PATCH] D70545: [ARM][MVE][Intrinsics] Add MVE VABD intrinsics.

MarkMurrayARM updated this revision to Diff 231055. MarkMurrayARM added a comment. Respond to review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70545/new/ https://reviews.llvm.org/D70545 Files: clang/include/clang/Basic/arm_mve.td

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

lh123 marked an inline comment as done. lh123 added inline comments. Comment at: clang/lib/Tooling/ExpandResponseFilesCompilationDatabase.cpp:167 +for (auto : Cmds) { + expandResponseFiles(Cmd, Tokenizer); +} lh123 wrote: > lh123 wrote: > >

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

lh123 marked an inline comment as done. lh123 added inline comments. Comment at: clang/lib/Tooling/ExpandResponseFilesCompilationDatabase.cpp:167 +for (auto : Cmds) { + expandResponseFiles(Cmd, Tokenizer); +} lh123 wrote: > kadircet wrote: > > so

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

lh123 updated this revision to Diff 231051. lh123 added a comment. address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70222/new/ https://reviews.llvm.org/D70222 Files: clang/include/clang/Tooling/CompilationDatabase.h clang/lib/Tooling/CMakeLists.txt

Re: [clang] 7b86188 - [Diagnostic] add a warning which warns about misleading indentation

Hi Tyker, This patch generates lots of warnings on building Linux kernel, which seem to be false positives. E.g., === static inline bool atomic_inc_unless_negative(atomic_t *v) { int c = atomic_read(v); do { if (unlikely(c < 0)) return

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

lh123 marked an inline comment as done. lh123 added inline comments. Comment at: clang/lib/Tooling/CompilationDatabase.cpp:402 llvm::sys::path::append(DatabasePath, "compile_flags.txt"); -return FixedCompilationDatabase::loadFromFile(DatabasePath, ErrorMessage); +

[PATCH] D70528: [NFC] ASSERT_EQ before accessing items in containers

This revision was automatically updated to reflect the committed changes. Closed by commit rGc547c22f1897: [NFC] ASSERT_EQ before accessing items in containers (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70528/new/

[PATCH] D70441: [clangd] Speed up when building rename edit.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8805316172a6: [clangd] Speed up when building rename edit. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70441/new/

[PATCH] D70528: [NFC] ASSERT_EQ before accessing items in containers

kbobyrev updated this revision to Diff 231046. kbobyrev added a comment. Rebase on top of master. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70528/new/ https://reviews.llvm.org/D70528 Files: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp

[clang-tools-extra] c547c22 - [NFC] ASSERT_EQ before accessing items in containers

Author: Kirill Bobyrev Date: 2019-11-26T13:45:04+01:00 New Revision: c547c22f18973dceaf5b40dae1b4ad7d3dd4eab7 URL: https://github.com/llvm/llvm-project/commit/c547c22f18973dceaf5b40dae1b4ad7d3dd4eab7 DIFF:

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

lh123 marked an inline comment as done. lh123 added inline comments. Comment at: clang/lib/Tooling/ExpandResponseFilesCompilationDatabase.cpp:167 +for (auto : Cmds) { + expandResponseFiles(Cmd, Tokenizer); +} kadircet wrote: > so it looks like we

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

kadircet added inline comments. Comment at: clang/include/clang/Tooling/CompilationDatabase.h:223 +/// Returns a wrapped CompilationDatabase that will expand all response files on +/// commandline returned by underlying database. nit: `s/response

[PATCH] D70547: [ARM][MVE][Intrinsics] Add MVE VAND/VORR/VORN/VEOR/VBIC intrinsics.

simon_tatham added inline comments. Comment at: clang/include/clang/Basic/arm_mve.td:68 +def "": Intrinsic +(bitcast $a, UVector), I think it's worth adding a comment here explaining why this bitcasting isn't overcomplicating the IR in the

[PATCH] D70546: [ARM][MVE][Intrinsics] Add MVE VMUL intrinsics.

simon_tatham added inline comments. Comment at: llvm/test/CodeGen/Thumb2/LowOverheadLoops/wlstp.mir:219 ; CHECK: renamable $r3, dead $cpsr = tSUBi8 killed renamable $r3, 16, 14, $noreg - ; CHECK: renamable $q0 = MVE_VMULt1i8 killed renamable $q1, killed renamable $q0,

[PATCH] D70545: [ARM][MVE][Intrinsics] Add MVE VABD intrinsics.

simon_tatham added a comment. This mostly LGTM: only a handful of nits. Comment at: clang/include/clang/Basic/arm_mve.td:45 let params = T.Usual in { +def vabdq: Intrinsic $a, $b)>; +} Can you wrap this line to 80 columns, please? I've been trying to fit the

[PATCH] D70547: [ARM][MVE][Intrinsics] Add MVE VAND/VORR/VORN/VEOR/VBIC intrinsics.

MarkMurrayARM updated this revision to Diff 231037. MarkMurrayARM added a comment. Rebase and reupload patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70547/new/ https://reviews.llvm.org/D70547 Files: clang/include/clang/Basic/arm_mve.td

[PATCH] D70546: [ARM][MVE][Intrinsics] Add MVE VMUL intrinsics.

MarkMurrayARM updated this revision to Diff 231035. MarkMurrayARM added a comment. Rebase and reupload patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70546/new/ https://reviews.llvm.org/D70546 Files: clang/include/clang/Basic/arm_mve.td

[PATCH] D70545: [ARM][MVE][Intrinsics] Add MVE VABD intrinsics.

MarkMurrayARM updated this revision to Diff 231034. MarkMurrayARM added a comment. Rebase and reupload patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70545/new/ https://reviews.llvm.org/D70545 Files: clang/include/clang/Basic/arm_mve.td

[clang] e54c83e - [OpenCL] Add work-group and miscellaneous vector builtin functions

Author: Sven van Haastregt Date: 2019-11-26T10:44:49Z New Revision: e54c83ec4dd493f2c6a483be2f6f3fc93624d10a URL: https://github.com/llvm/llvm-project/commit/e54c83ec4dd493f2c6a483be2f6f3fc93624d10a DIFF: https://github.com/llvm/llvm-project/commit/e54c83ec4dd493f2c6a483be2f6f3fc93624d10a.diff

[PATCH] D69938: [OpenCL] Use __generic addr space when generating internal representation of lambda

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:891 +if (getLangOpts().OpenCL) + EPI.TypeQuals.addAddressSpace(LangAS::opencl_generic); + rjmccall wrote: > This should probably check

  1   2   >