[PATCH] D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

ruiu added a comment. lld is not that Linux-centric as you implied in your comment. We have code for FreeBSD, OpenBSD, AMDGPU and Fuchsia (which isn't even a POSIX system), and adding code for NetBSD is OK and is appreciated. However, the thing we've been trying to avoid is to hard-code a

[PATCH] D71248: [clangd] Introduce paragraph, the first part of new rendering structs

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60657 tests passed, 0 failed and 726 were skipped. {icon check-circle color=green} clang-format: pass. Build artifacts : console-log.txt

[PATCH] D71393: Default to -fno-use-init-array

sberg added a comment. The title should probably read "Default to -fuse-init-array" (dropping the "no-")? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71393/new/ https://reviews.llvm.org/D71393 ___

[PATCH] D71248: [clangd] Introduce paragraph, the first part of new rendering structs

kadircet updated this revision to Diff 233513. kadircet added a comment. - More tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71248/new/ https://reviews.llvm.org/D71248 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

[PATCH] D71393: Default to -fno-use-init-array

echristo added a comment. Fan of this change, but let's definitely wait for more reviews :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71393/new/ https://reviews.llvm.org/D71393 ___ cfe-commits

[clang] 7292c28 - Fix an error in the block ABI documentation sample code

Author: Akira Hatanaka Date: 2019-12-11T23:18:32-08:00 New Revision: 7292c2823063fdb9e2200ef7e4571d4f2443e6ca URL: https://github.com/llvm/llvm-project/commit/7292c2823063fdb9e2200ef7e4571d4f2443e6ca DIFF:

[PATCH] D71387: pass -mabi to LTO linker only in RISC-V targets, enable RISC-V LTO

khchen updated this revision to Diff 233508. khchen added a comment. update missed code.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71387/new/ https://reviews.llvm.org/D71387 Files: clang/lib/Driver/ToolChains/Arch/RISCV.cpp

[PATCH] D70856: [Syntax] Build nodes for simple cases of top level declarations

ilya-biryukov added a comment. Landing as is, but happy to address any comments in the follow-up patches. @gribozavr2, please feel free to leave any suggestions in the review comments, despite it being closed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D70856: [Syntax] Build nodes for simple cases of top level declarations

This revision was automatically updated to reflect the committed changes. Closed by commit rGbe14a22b47e5: [Syntax] Build nodes for simple cases of top level declarations (authored by ilya-biryukov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] be14a22 - [Syntax] Build nodes for simple cases of top level declarations

Author: Ilya Biryukov Date: 2019-12-12T08:04:22+01:00 New Revision: be14a22b47e5c61ff36e4183dcb4f8b138466157 URL: https://github.com/llvm/llvm-project/commit/be14a22b47e5c61ff36e4183dcb4f8b138466157 DIFF: https://github.com/llvm/llvm-project/commit/be14a22b47e5c61ff36e4183dcb4f8b138466157.diff

[PATCH] D48921: NFC - Typo fix in test/CodeGenCXX/runtime-dllstorage.cpp

Jim accepted this revision. Jim added a comment. This revision is now accepted and ready to land. Herald added a project: clang. Are you ready to land this patch? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48921/new/ https://reviews.llvm.org/D48921

[PATCH] D68161: [TimeProfiler] Fix "OptModule" section and add new "Backend" sections

anton-afanasyev closed this revision. anton-afanasyev added a comment. Commited long time ago (https://reviews.llvm.org/rL373142). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68161/new/ https://reviews.llvm.org/D68161

[PATCH] D71393: Default to -fno-use-init-array

MaskRay created this revision. MaskRay added reviewers: brad, kamleshbhalui, lenary, phosek, rnk. Herald added subscribers: cfe-commits, luismarques, apazos, sameer.abuasal, pzheng, s.egerton, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, atanasyan, edward-jones, zzheng, jrtc27,

[PATCH] D70157: Align branches within 32-Byte boundary

skan added a comment. In D70157#1777272 , @fedor.sergeev wrote: > In D70157#1776424 , @skan wrote: > > > > What if I insert explicit align(8) right *after* the sequence? > > > > If your insert explicit `.align

[clang] bdaf31e - [OpenMP][Docs] Mark 5.0 features worked on and list 5.1 features

Author: Johannes Doerfert Date: 2019-12-12T00:00:38-06:00 New Revision: bdaf31ec95e071b87e4cf160eb1ce570dc37a8c0 URL: https://github.com/llvm/llvm-project/commit/bdaf31ec95e071b87e4cf160eb1ce570dc37a8c0 DIFF:

[PATCH] D70919: [Hexagon] Avoid passing unsupported options to lld when -fuse-ld=lld is used

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Hexagon.cpp:212 bool UseG0 = false; + bool UseLLD = Args.getLastArgValue(options::OPT_fuse_ld_EQ).startswith("lld"); bool UseShared = IsShared && !IsStatic; bcain wrote: > Does this

[PATCH] D71387: pass -mabi to LTO linker only in RISC-V targets, enable RISC-V LTO

khchen created this revision. khchen added reviewers: efriedma, lenary, asb, shiva0217, tejohnson. khchen added a project: clang. Herald added subscribers: cfe-commits, luismarques, apazos, sameer.abuasal, pzheng, s.egerton, jocewei, PkmX, rkruppe, dexonsmith, the_o, brucehoult, MartinMosbeck,

[PATCH] D70919: [Hexagon] Avoid passing unsupported options to lld when -fuse-ld=lld is used

ruiu added a comment. In D70919#1771198 , @sidneym wrote: > Remove quotes around check-not. > > -fuse-ld=lld is the correct usage. -fuse-ld=ld.lld results in an error > message: > error: invalid linker name in argument '-fuse-ld=ld.lld' `-fuse-ld`

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

plotfi added a comment. In D71301#1778834 , @compnerd wrote: > Should probably add a check for `__block` variables. I looked into it, I am not sure if anything special needs to be done for block. ie: echo "void f() { __block int x = 42; void

[PATCH] D69471: [Coverage] Revise format to reduce binary size

rnk added a comment. I have a Windows build directory and am motivated to debug this. I'll try to do it tomorrow, but I have a couple of other deadlines so I can't make a very firm promise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69471/new/

[clang] 5d98695 - [IR] Split out target specific intrinsic enums into separate headers

Author: Reid Kleckner Date: 2019-12-11T18:02:14-08:00 New Revision: 5d986953c8b917bacfaa1f800fc1e242559f76be URL: https://github.com/llvm/llvm-project/commit/5d986953c8b917bacfaa1f800fc1e242559f76be DIFF: https://github.com/llvm/llvm-project/commit/5d986953c8b917bacfaa1f800fc1e242559f76be.diff

[PATCH] D71325: [Remarks][Driver] Ask for line tables when remarks are enabled

This revision was automatically updated to reflect the committed changes. Closed by commit rG60590b149b33: [Remarks][Driver] Ask for line tables when remarks are enabled (authored by thegameg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 60590b1 - [Remarks][Driver] Ask for line tables when remarks are enabled

Author: Francis Visoiu Mistrih Date: 2019-12-11T17:59:46-08:00 New Revision: 60590b149b33eb80d0b52c1c6723fe35817ee897 URL: https://github.com/llvm/llvm-project/commit/60590b149b33eb80d0b52c1c6723fe35817ee897 DIFF:

[clang] bc24014 - [c++20] Implement P1185R2 (as modified by P2002R0).

Hi Richard, http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/1353 The bots are broken for a long time now. When do you expect the fix? Thanks, Alex On Wed, Dec 11, 2019 at 12:13 AM Yvan Roux via cfe-commits wrote: Hi Richard, ARM bots are broken after this commit, logs are

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

jdoerfert added a comment. In D71241#1779097 , @ABataev wrote: > In D71241#1778963 , @jdoerfert wrote: > > > In D71241#1778736 , @ABataev wrote: > > > > > In D71241#1778717

[clang] 9fdcae7 - [analyzer] Do not cache out on some shared implicit AST nodes

Author: Gabor Horvath Date: 2019-12-11T17:15:12-08:00 New Revision: 9fdcae7c81f5ff92ad694f5d993a042a525fd6bc URL: https://github.com/llvm/llvm-project/commit/9fdcae7c81f5ff92ad694f5d993a042a525fd6bc DIFF: https://github.com/llvm/llvm-project/commit/9fdcae7c81f5ff92ad694f5d993a042a525fd6bc.diff

[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60744 tests passed, 0 failed and 726 were skipped. {icon check-circle color=green} clang-format: pass. Build artifacts : console-log.txt

[PATCH] D71371: [analyzer] Do not cache out on some shared implicit AST nodes.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9fdcae7c81f5: [analyzer] Do not cache out on some shared implicit AST nodes (authored by xazax.hun). Changed prior to commit: https://reviews.llvm.org/D71371?vs=233468=233475#toc Repository: rG LLVM

[PATCH] D71371: [analyzer] Do not cache out on some shared implicit AST nodes.

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks!! Comment at: clang/lib/StaticAnalyzer/Core/ExprEngine.cpp:1318 case Expr::MSDependentExistsStmtClass: llvm_unreachable("Stmt should not be in analyzer

[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:51 + /// at the time, and location, the callback is invoked. + using FinalizeCallbackTy = std::function; + ABataev wrote:

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

rupprecht marked an inline comment as done. rupprecht added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:13047 + F->setUsesFPIntrin(true); + printf("Enclosing function uses fp intrinsics\n"); +} rupprecht wrote: > Looks like this is

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

rupprecht added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:13047 + F->setUsesFPIntrin(true); + printf("Enclosing function uses fp intrinsics\n"); +} Looks like this is leftover debugging? I'm seeing log spam compiling some files -- this

[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

jdoerfert updated this revision to Diff 233472. jdoerfert marked an inline comment as done. jdoerfert added a comment. Update the unit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70258/new/ https://reviews.llvm.org/D70258 Files:

[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

ABataev added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:51 + /// at the time, and location, the callback is invoked. + using FinalizeCallbackTy = std::function; + jdoerfert wrote: > ABataev wrote: > > `llvm::function_ref`? >

[clang] 5bcd34a - Revert "[clang][clang-scan-deps] Aggregate the full dependency information."

Author: Michael Spencer Date: 2019-12-11T16:35:55-08:00 New Revision: 5bcd34a03ff343674c106b9a6a0406bf249b9b31 URL: https://github.com/llvm/llvm-project/commit/5bcd34a03ff343674c106b9a6a0406bf249b9b31 DIFF:

Re: [clang] f978ea4 - [clang][clang-scan-deps] Aggregate the full dependency information.

On Wed, Dec 11, 2019 at 2:41 PM Michael Spencer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Michael Spencer > Date: 2019-12-11T14:40:51-08:00 > New Revision: f978ea498309adaebab8fbf1cd6e520e7e0e11f1 > > URL: >

[PATCH] D71371: [analyzer] Do not cache out on some shared implicit AST nodes.

xazax.hun updated this revision to Diff 233468. xazax.hun added a comment. - Removed leftover code from previous approach. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71371/new/ https://reviews.llvm.org/D71371 Files: clang/include/clang/Analysis/CFG.h clang/lib/Analysis/CFG.cpp

[PATCH] D71371: [analyzer] Do not cache out on some shared implicit AST nodes.

xazax.hun updated this revision to Diff 233467. xazax.hun edited the summary of this revision. xazax.hun added a comment. - Omit nodes from CFG instead of trying to make the states distinct. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71371/new/ https://reviews.llvm.org/D71371

[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

jdoerfert marked 2 inline comments as done. jdoerfert added a comment. In D70258#1780611 , @ABataev wrote: > Tests? This changes the implementation and does not add features. Thus, this is covered by the existing tests for the functionality, e.g. the

[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

merge_guards_bot added a comment. {icon check-circle color=green} clang-format: pass. Build artifacts : console-log.txt , CMakeCache.txt

[PATCH] D71345: [clangd] Fall back to selecting token-before-cursor if token-after-cursor fails.

nridge added a comment. I tried to do a less general version of this (for go-to-definition only) in D70727 :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71345/new/ https://reviews.llvm.org/D71345

[PATCH] D71378: Modifying ImportDeclContext(...) to ensure that we complete each FieldDecl of a RecordDecl when we are importing the definiton

shafik created this revision. shafik added reviewers: martong, teemperor. Herald added a subscriber: rnkovacs. This fix was motivated by a crashes in expression parsing during code generation in which we had a `RecordDecl` that had incomplete `FieldDecl`. During code generation when computing

[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

ABataev added a comment. Tests? Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:51 + /// at the time, and location, the callback is invoked. + using FinalizeCallbackTy = std::function; + `llvm::function_ref`? Repository: rG LLVM Github

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

cameron.mcinally added a comment. In D62731#1779872 , @mibintc wrote: > In D62731#1778597 , > @michele.scandale wrote: > > > >> I've noticed you removed the change for `CompilerInvocation.cpp` about > > >> the

[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

jdoerfert updated this revision to Diff 233462. jdoerfert added a comment. rebase + ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70258/new/ https://reviews.llvm.org/D70258 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D71325: [Remarks][Driver] Ask for line tables when remarks are enabled

thegameg updated this revision to Diff 233459. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71325/new/ https://reviews.llvm.org/D71325 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/debug-options.c Index: clang/test/Driver/debug-options.c

[PATCH] D69471: [Coverage] Revise format to reduce binary size

vsk added a comment. Sorry for the delay here. An update: I tested this patch with a sanitized build on a Linux install, but could not reproduce the "malformed coverage data" errors seen on the Windows bots. At this point, it seems likely that there is a bug in CoverageMappingReader (this

[PATCH] D69922: [OpenMP] Use the OpenMP-IR-Builder

jdoerfert added a comment. > I applied D69853 , D69785 > , D69922 > to my local build and found that D69922 is > referring to OpenMPIRBuilder.h in llvm/Frontend

[PATCH] D69922: [OpenMP] Use the OpenMP-IR-Builder

This revision was automatically updated to reflect the committed changes. Closed by commit rGb3c06db45611: [OpenMP] Use the OpenMP-IR-Builder (authored by jdoerfert). Changed prior to commit: https://reviews.llvm.org/D69922?vs=233448=233458#toc Repository: rG LLVM Github Monorepo CHANGES

[clang] b3c06db - [OpenMP] Use the OpenMP-IR-Builder

Author: Johannes Doerfert Date: 2019-12-11T16:51:13-06:00 New Revision: b3c06db45611152f4ec22670bd83f4354078e6a7 URL: https://github.com/llvm/llvm-project/commit/b3c06db45611152f4ec22670bd83f4354078e6a7 DIFF:

[PATCH] D70268: [clang][clang-scan-deps] Aggregate the full dependency information.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf978ea498309: [clang][clang-scan-deps] Aggregate the full dependency information. (authored by Bigcheese). Changed prior to commit: https://reviews.llvm.org/D70268?vs=233233=233455#toc Repository:

[clang] f978ea4 - [clang][clang-scan-deps] Aggregate the full dependency information.

Author: Michael Spencer Date: 2019-12-11T14:40:51-08:00 New Revision: f978ea498309adaebab8fbf1cd6e520e7e0e11f1 URL: https://github.com/llvm/llvm-project/commit/f978ea498309adaebab8fbf1cd6e520e7e0e11f1 DIFF:

[clang] db4c7ad - Suppress false-positive -Wuninitialized warnings in the constructor of a

Author: Richard Smith Date: 2019-12-11T14:26:28-08:00 New Revision: db4c7adfa365282e8cb9a067c509fa711c4b96fe URL: https://github.com/llvm/llvm-project/commit/db4c7adfa365282e8cb9a067c509fa711c4b96fe DIFF: https://github.com/llvm/llvm-project/commit/db4c7adfa365282e8cb9a067c509fa711c4b96fe.diff

[PATCH] D70878: [analyzer] Add support for namespaces to GenericTaintChecker

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks great but i keep worrying that you're re-inventing `CallDescription` which already supports this feature (and many more) and we really need a single implementation of this logic because it

[PATCH] D70268: [clang][clang-scan-deps] Aggregate the full dependency information.

Bigcheese added a comment. Looks like the test for -full-command-line got dropped. I'll add that when I commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70268/new/ https://reviews.llvm.org/D70268

[PATCH] D69922: [OpenMP] Use the OpenMP-IR-Builder

jdoerfert updated this revision to Diff 233448. jdoerfert marked 3 inline comments as done. jdoerfert added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69922/new/ https://reviews.llvm.org/D69922 Files:

[PATCH] D70854: [Clang] In tests, do not always assume others permissions are set

rnk added a comment. I think we should remove it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70854/new/ https://reviews.llvm.org/D70854 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] e0e07a7 - Fix detection of __attribute__((may_alias)) to properly look through

Author: Richard Smith Date: 2019-12-11T14:04:37-08:00 New Revision: e0e07a7e414e818788144511de0c6328285c43cd URL: https://github.com/llvm/llvm-project/commit/e0e07a7e414e818788144511de0c6328285c43cd DIFF: https://github.com/llvm/llvm-project/commit/e0e07a7e414e818788144511de0c6328285c43cd.diff

[PATCH] D69770: [APFloat] Add recoverable string parsing errors to APFloat

ekatz added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69770/new/ https://reviews.llvm.org/D69770 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

george.burgess.iv added inline comments. Comment at: clang/lib/AST/Decl.cpp:3006 +bool FunctionDecl::isReplaceableSystemFunction() const { + FunctionDecl const *Definition; serge-sans-paille wrote: > george.burgess.iv wrote: > > serge-sans-paille wrote: > > >

[PATCH] D71371: [analyzer] Do not cache out on some shared implicit AST nodes.

NoQ added a comment. I doubt we'll ever need these callbacks. I can't imagine any kind of analysis that would need them. Like, these statements have absolutely no effect on the runtime program state. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71371: [analyzer] Do not cache out on some shared implicit AST nodes.

xazax.hun added a comment. Hmm loops. Right. So this solution is insufficient because it can prevent legitimate caching out in loops. If we remove those initializers from the CFG wouldn't we loose the Pre/PostStmt callbacks? Is that acceptable? If not, we might need to create a new program

[clang] 0b97894 - [OPENMP50]Add if clause in teams distribute parallel for simd directive.

Author: Alexey Bataev Date: 2019-12-11T16:11:41-05:00 New Revision: 0b9789456b616863ab4dd045a977758f527bab8b URL: https://github.com/llvm/llvm-project/commit/0b9789456b616863ab4dd045a977758f527bab8b DIFF: https://github.com/llvm/llvm-project/commit/0b9789456b616863ab4dd045a977758f527bab8b.diff

[PATCH] D71111: [Sema] Improve diagnostic about addr spaces for overload candidates

rjmccall added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3838 +"'this' object is in address space %3, but method expects object in " +"address space %4">; def note_ovl_candidate_bad_gc : Note< I think you need to move

[PATCH] D71374: Improve support of GNU mempcpy

serge-sans-paille added a comment. On going validation: https://github.com/serge-sans-paille/llvm-project/pull/5/checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71374/new/ https://reviews.llvm.org/D71374

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

serge-sans-paille marked an inline comment as done. serge-sans-paille added inline comments. Comment at: clang/lib/AST/Decl.cpp:3006 +bool FunctionDecl::isReplaceableSystemFunction() const { + FunctionDecl const *Definition; george.burgess.iv wrote: >

[PATCH] D70836: [analysis] Fix value tracking for pointers to qualified types

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Hmm, it was supposed to get a green tick mark. Let me re-accept. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70836/new/

[PATCH] D71374: Improve support of GNU mempcpy

serge-sans-paille created this revision. serge-sans-paille added a reviewer: ddunbar. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Lower to the memcpy intrinsic - Raise warnings when size/bounds are known Repository: rG LLVM Github Monorepo

[PATCH] D70854: [Clang] In tests, do not always assume others permissions are set

aganea added a comment. Yes this was added in rG18627115f4d2db5dc73207e0b5312f52536be7dd and rGe08b59f81d950bd5c8b8528fcb3ac4230c7b736c . It looks like it

[PATCH] D71371: [analyzer] Do not cache out on some shared implicit AST nodes.

NoQ added a comment. One way to criticize the current solution would be to put an `InitListExpr` in a loop and immediately discard it and see how states after different numbers of iterations no longer join together only because they have different `NoCachingOutForConsts` values. Repository:

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

This revision was automatically updated to reflect the committed changes. Closed by commit rGd23c61490c28: [OpenMP] Introduce the OpenMP-IR-Builder (authored by jdoerfert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69785/new/

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

NoQ added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:7424 + ParsedAttr ) { + if (CurType->isFunctionType()) { +State.getSema().Diag(Attr.getLoc(), diag::warn_type_attribute_wrong_type) xazax.hun wrote: >

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

plotfi updated this revision to Diff 233435. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71301/new/ https://reviews.llvm.org/D71301 Files: clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp clang/test/InterfaceStubs/blocks.c

[PATCH] D71317: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

plotfi abandoned this revision. plotfi added a comment. Abandoning. Duplicate diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71317/new/ https://reviews.llvm.org/D71317 ___ cfe-commits mailing list

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert marked 2 inline comments as done. jdoerfert added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:74 +/// +///{ +namespace types { ABataev wrote: > jdoerfert wrote: > > ABataev wrote: > > > Extra comments? > > I don't know

[PATCH] D70401: [WIP][RISCV] Implement ilp32e ABI

luismarques added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVCallingConv.td:36 +// The only physical register that isn't saved is x2 (SP), which is used by the +// processor when the interrupt happens. + Nitpick: "the interrupt happens" -> "an

[PATCH] D70872: [clangd] Implement "textDocument/documentLink" protocol support

MForster updated this revision to Diff 233433. MForster marked an inline comment as not done. MForster added a comment. Adress review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70872/new/ https://reviews.llvm.org/D70872 Files:

[PATCH] D70872: [clangd] Implement "textDocument/documentLink" protocol support

MForster marked 6 inline comments as done. MForster added a comment. I think I addressed all review comments. PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70872/new/ https://reviews.llvm.org/D70872

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

ABataev added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:74 +/// +///{ +namespace types { jdoerfert wrote: > ABataev wrote: > > Extra comments? > I don't know what you want to tell me. I mean, you have this `///{` here. Do you

[PATCH] D70520: [WebAssembly] Add new `export_name` clang attribute for controlling wasm export names

This revision was automatically updated to reflect the committed changes. sbc100 marked an inline comment as done. Closed by commit rG881d877846e2: [WebAssembly] Add new `export_name` clang attribute for controlling wasm export… (authored by sbc100). Changed prior to commit:

[PATCH] D71224: [analyzer] Escape symbols stored into specific region after a conservative evalcall.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5882e6f36fd9: [analyzer] Escape symbols conjured into specific regions during a conservative… (authored by xazax.hun). Changed prior to commit: https://reviews.llvm.org/D71224?vs=233235=233431#toc

[PATCH] D71248: [clangd] Introduce paragraph, the first part of new rendering structs

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60655 tests passed, 0 failed and 726 were skipped. {icon check-circle color=green} clang-format: pass. Build artifacts : console-log.txt

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert updated this revision to Diff 233429. jdoerfert marked 2 inline comments as done. jdoerfert added a comment. Remove call caching in anticipation of D69930 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 881d877 - [WebAssembly] Add new `export_name` clang attribute for controlling wasm export names

Author: Sam Clegg Date: 2019-12-11T11:54:57-08:00 New Revision: 881d877846e2904c731d616731969421ce8cc825 URL: https://github.com/llvm/llvm-project/commit/881d877846e2904c731d616731969421ce8cc825 DIFF: https://github.com/llvm/llvm-project/commit/881d877846e2904c731d616731969421ce8cc825.diff

[clang] 5882e6f - [analyzer] Escape symbols conjured into specific regions during a conservative EvalCall

Author: Gabor Horvath Date: 2019-12-11T11:44:10-08:00 New Revision: 5882e6f36fd9bfc7382e6763c5591b3497428d83 URL: https://github.com/llvm/llvm-project/commit/5882e6f36fd9bfc7382e6763c5591b3497428d83 DIFF: https://github.com/llvm/llvm-project/commit/5882e6f36fd9bfc7382e6763c5591b3497428d83.diff

[PATCH] D71371: [analyzer] Do not cache out on some shared implicit AST nodes.

NoQ added a comment. Ahaa. Ahaa. Okay. So the AST is like | |-DeclStmt 0x7f9f3b8932e0 | | `-VarDecl 0x7f9f3b892f50 col:7 used a 'int [5]' cinit | | `-InitListExpr 0x7f9f3b893268 'int [5]' | | |-array_filler: ImplicitValueInitExpr 0x7f9f3b8932d0 <> 'int' | |

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert marked 6 inline comments as done. jdoerfert added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:74 +/// +///{ +namespace types { ABataev wrote: > Extra comments? I don't know what you want to tell me.

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 60698 tests passed, 1 failed and 726 were skipped. failed: LLVM-Unit.Frontend/_/LLVMFrontendTests/OpenMPIRBuilderTest.CreateCancelBarrier {icon check-circle color=green} clang-format: pass. Build artifacts

Re: [clang] 878a24e - Reapply "Fix crash on switch conditions of non-integer types in templates"

After this commit clang started generating assertion failures on valid code. There are tons of instances in our codebase. Here's a reduced test case: template class a { int c : b; void f() { if (c) ; } }; Please take a look. On Wed, Dec 4, 2019 at 12:39 AM Elizabeth Andrews via

[PATCH] D71111: [Sema] Improve diagnostic about addr spaces for overload candidates

Anastasia updated this revision to Diff 233424. Anastasia added a comment. - Allow sending address spaces into diagnostics - Change wording of diagnostics for address spaces in overloading CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7/new/ https://reviews.llvm.org/D7 Files:

[PATCH] D71322: [analyzer] CStringChecker: Fix overly eager assumption that memcmp arguments overlap.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2b3f2071ec65: [analyzer] CStringChecker: Fix overly eager assumption that memcmp args overlap. (authored by dergachev.a). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71371: [analyzer] Do not cache out on some shared implicit AST nodes.

xazax.hun created this revision. xazax.hun added reviewers: NoQ, dcoughlin, Szelethus, baloghadamsoftware, haowei. xazax.hun added a project: clang. Herald added subscribers: Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet. Some AST nodes that stands for

[PATCH] D71356: [Tooling/Syntax] Helpers to find spelled tokens touching a location.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60699 tests passed, 0 failed and 726 were skipped. {icon check-circle color=green} clang-format: pass. Build artifacts : console-log.txt

[PATCH] D71321: [analyzer] CStringChecker: Warning text fixes.

This revision was automatically updated to reflect the committed changes. Closed by commit rG134faae04259: [analyzer] CStringChecker: Improve warning messages. (authored by dergachev.a). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71321/new/

[PATCH] D70854: [Clang] In tests, do not always assume others permissions are set

rnk added a comment. I see there is no setfacl on Mac. Personally, I feel like this test doesn't have much value. Rafael added it long ago when we changed how we opened files in some way that I guess affected umask. I'm not sure we really need this regression test given how unportable it seems

[clang] 2b3f207 - [analyzer] CStringChecker: Fix overly eager assumption that memcmp args overlap.

Author: Artem Dergachev Date: 2019-12-11T11:22:36-08:00 New Revision: 2b3f2071ec6561c3f10e5291289c47bb3629e354 URL: https://github.com/llvm/llvm-project/commit/2b3f2071ec6561c3f10e5291289c47bb3629e354 DIFF:

[clang] 134faae - [analyzer] CStringChecker: Improve warning messages.

Author: Artem Dergachev Date: 2019-12-11T11:22:36-08:00 New Revision: 134faae04259b0412a067c73069f61905fc451d7 URL: https://github.com/llvm/llvm-project/commit/134faae04259b0412a067c73069f61905fc451d7 DIFF:

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

ABataev added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:74 +/// +///{ +namespace types { Extra comments? Comment at: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:93 +} // namespace types +///} +

[PATCH] D71248: [clangd] Introduce paragraph, the first part of new rendering structs

kadircet updated this revision to Diff 233420. kadircet marked 12 inline comments as done. kadircet added a comment. - Move code blocks out of Paragraph - Provide a way to control vertical spacing - Address comments around naming Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71248: [clangd] Introduce paragraph, the first part of new rendering structs

kadircet added inline comments. Comment at: clang-tools-extra/clangd/FormattedString.cpp:95 +// Concatanates whitespace blocks into a single ` `. +std::string canonicalizeSpaces(std::string Input) { + // Goes over the string and preserves only a single ` ` for any whitespace

  1   2   3   >