[PATCH] D70401: [WIP][RISCV] Implement ilp32e ABI

Jim added inline comments. Comment at: llvm/test/CodeGen/RISCV/calling-conv-ilp32e-double-bug.ll:2 +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; RUN: llc -mtriple=riscv32 -target-abi ilp32e -mattr=+f -verify-machineinstrs < %s +; RUN: llc

[PATCH] D71846: [ASTMatchers] Fix for https://bugs.llvm.org/show_bug.cgi?id=44364

njames93 added a comment. Thanks for the pointers, I'll amend those changes and update the patch, thanks for pointing it out for me. Probably be after boxing day though Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71846/new/

[clang] 3732f4e - [OPENMP]Add extra checks and initialization for clause modifier.

Author: Alexey Bataev Date: 2019-12-24T16:12:28-05:00 New Revision: 3732f4e093f9aed7aad9740e460e00a248f28572 URL: https://github.com/llvm/llvm-project/commit/3732f4e093f9aed7aad9740e460e00a248f28572 DIFF: https://github.com/llvm/llvm-project/commit/3732f4e093f9aed7aad9740e460e00a248f28572.diff

[PATCH] D70876: [clang-tidy] Add spuriously-wake-up-functions check

abelkocsis updated this revision to Diff 235232. abelkocsis added a comment. `docs/clang-tidy/checks/lsit.rst` update Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70876/new/ https://reviews.llvm.org/D70876 Files:

[PATCH] D71857: Fixes -Wrange-loop-analysis warnings

merge_guards_bot added a comment. Herald added a subscriber: wuzish. {icon check-circle color=green} Unit tests: pass. 61116 tests passed, 0 failed and 728 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D71857: Fixes -Wrange-loop-analysis warnings

Mordante created this revision. Mordante added reviewers: aaron.ballman, xbolva00. Mordante added projects: LLVM, LLDB, clang. Herald added subscribers: bmahjour, usaxena95, kadircet, arphaman, jkorous, kbarton, hiraditya, nemanjai, qcolombet, MatzeB. This avoids new warnings due to D68912

[PATCH] D71463: Implement VectorType conditional operator GNU extension.

erichkeane added a comment. @eli.friedman @rjmccall Do you have further comments on these? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71463/new/ https://reviews.llvm.org/D71463 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59520: [WebAssembly] Address review comments on r352930

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:2594-2597 + else if (const auto *IMA = dyn_cast(Attr)) +NewAttr = S.mergeImportModuleAttr(D, *IMA); + else if (const auto *INA = dyn_cast(Attr)) +NewAttr = S.mergeImportNameAttr(D, *INA);

[PATCH] D71842: Allow newlines in AST Matchers in clang-query files

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-query/Query.cpp:106 + Source.split(Lines, "\n"); + auto firstLine = Lines[0]; + Lines.erase(Lines.begin(), Lines.begin() + 1); `firstLine` should be `FirstLine` and I have a

[clang] 3cb934c - [OPENMP][DOCS]Update status of OpenMP 5.0 features, NFC.

Author: Alexey Bataev Date: 2019-12-24T12:39:59-05:00 New Revision: 3cb934c94e518486a8cd066ff02d176ec040e87b URL: https://github.com/llvm/llvm-project/commit/3cb934c94e518486a8cd066ff02d176ec040e87b DIFF: https://github.com/llvm/llvm-project/commit/3cb934c94e518486a8cd066ff02d176ec040e87b.diff

[clang] 93dc40d - [OPENMP50]Basic support for conditional lastprivate.

Author: Alexey Bataev Date: 2019-12-24T12:22:05-05:00 New Revision: 93dc40e40cff2f54b68c66abb00927cdbcea URL: https://github.com/llvm/llvm-project/commit/93dc40e40cff2f54b68c66abb00927cdbcea DIFF: https://github.com/llvm/llvm-project/commit/93dc40e40cff2f54b68c66abb00927cdbcea.diff

[PATCH] D70270: clang-tidy: modernize-use-using uses AST and now supports struct defintions and multiple types in a typedef

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70270/new/ https://reviews.llvm.org/D70270

[PATCH] D70689: [analyzer] Fix SARIF column locations

jranieri-grammatech updated this revision to Diff 235219. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70689/new/ https://reviews.llvm.org/D70689 Files: clang/lib/StaticAnalyzer/Core/SarifDiagnostics.cpp

[PATCH] D71846: [ASTMatchers] Fix for https://bugs.llvm.org/show_bug.cgi?id=44364

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. Thank you for this! There's some missing test coverage for the changes to the clang-tidy check and for the new matcher. Also, the new matcher should be registered in

[PATCH] D71666: [clang-tidy] Fix readability-const-return-type identifying the wrong `const` token

aaron.ballman closed this revision. aaron.ballman added a comment. In D71666#1795068 , @ilya wrote: > @aaron.ballman, thanks for reviewing. Do you mind submitting this, as I don't > have commit access? Happy to do so, thank you for the fix! I've commit

[clang-tools-extra] f58f391 - Fix readability-const-return-type identifying the wrong `const` token

Author: Ilya Mirsky Date: 2019-12-24T10:10:01-05:00 New Revision: f58f39137c6e5a324ef684b1d72bddae244aa94d URL: https://github.com/llvm/llvm-project/commit/f58f39137c6e5a324ef684b1d72bddae244aa94d DIFF: https://github.com/llvm/llvm-project/commit/f58f39137c6e5a324ef684b1d72bddae244aa94d.diff

[PATCH] D71686: Fix false positive in magic number checker

aaron.ballman closed this revision. aaron.ballman added a comment. In D71686#1794377 , @0x8000- wrote: > @aaron.ballman updated as suggested; please commit/integrate when you have a > moment. Thank you! Happy to do so, thank you for the fix! I've

[clang-tools-extra] c16b3ec - Fix false positive in magic number checker.

Author: Florin Iucha Date: 2019-12-24T10:03:00-05:00 New Revision: c16b3ec597d277b5a7397db308f8ec730f3330a3 URL: https://github.com/llvm/llvm-project/commit/c16b3ec597d277b5a7397db308f8ec730f3330a3 DIFF: https://github.com/llvm/llvm-project/commit/c16b3ec597d277b5a7397db308f8ec730f3330a3.diff

[PATCH] D71854: [SystemZ] Use FNeg in s390x clang builtins

uweigand added a comment. Otherwise this LGTM. Thanks for taking care of those! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71854/new/ https://reviews.llvm.org/D71854 ___ cfe-commits mailing list

[clang] 0293b5d - [NFC] Remove some dead code from CGBuiltin.cpp.

Author: Kevin P. Neal Date: 2019-12-24T09:38:34-05:00 New Revision: 0293b5d67123786daf80528af9ef356b7bd9d2f6 URL: https://github.com/llvm/llvm-project/commit/0293b5d67123786daf80528af9ef356b7bd9d2f6 DIFF: https://github.com/llvm/llvm-project/commit/0293b5d67123786daf80528af9ef356b7bd9d2f6.diff

[PATCH] D71854: [SystemZ] Use FNeg in s390x clang builtins

uweigand requested changes to this revision. uweigand added a comment. This revision now requires changes to proceed. This also needs updating the test cases that are testing for the old behavior: Failing Tests (4): Clang :: CodeGen/builtins-systemz-vector.c Clang ::

[PATCH] D71854: [SystemZ] Use FNeg in s390x clang builtins

kpn created this revision. kpn added reviewers: cfe-commits, uweigand. Herald added a project: clang. The s390x builtins are still using FSub instead of FNeg. Correct that. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D71854 Files: clang/lib/CodeGen/CGBuiltin.cpp Index:

[clang-tools-extra] c96c606 - clang-doc remove trailing whitespaces

Author: Sylvestre Ledru Date: 2019-12-24T13:07:08+01:00 New Revision: c96c606b85c6a1e046fb8b1fb5bd1cbf28d80169 URL: https://github.com/llvm/llvm-project/commit/c96c606b85c6a1e046fb8b1fb5bd1cbf28d80169 DIFF:

[clang-tools-extra] 8131c04 - doc: Document that extra-arg/extra-arg-before can be used several times

Author: Sylvestre Ledru Date: 2019-12-24T13:07:08+01:00 New Revision: 8131c04836829e7f37f2feaa1d85b4ef62ad092f URL: https://github.com/llvm/llvm-project/commit/8131c04836829e7f37f2feaa1d85b4ef62ad092f DIFF:

[PATCH] D70876: [clang-tidy] Add spuriously-wake-up-functions check

whisperity added a comment. The `checks.rst` has recently been updated to show "normal" (main entry) checks and "aliases" in different tables in D36051 . Please register the alias-ness accordingly. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST

[PATCH] D70876: [clang-tidy] Add spuriously-wake-up-functions check

abelkocsis updated this revision to Diff 235212. abelkocsis added a comment. Adding matcher for `cnd_timedwait` and test cases. Small fix in documentation Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70876/new/ https://reviews.llvm.org/D70876

[PATCH] D71805: [clang] [ast] CXXRecordDecl::getVisibleConversionFunctions() could be const

This revision was automatically updated to reflect the committed changes. Closed by commit rG002e07208a67: [clang] [ast] CXXRecordDecl::getVisibleConversionFunctions() could be const (authored by whisperity). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 002e072 - [clang] [ast] CXXRecordDecl::getVisibleConversionFunctions() could be const

Author: Whisperity Date: 2019-12-24T11:09:24+01:00 New Revision: 002e07208a67351f75e306fdc025661e451df03c URL: https://github.com/llvm/llvm-project/commit/002e07208a67351f75e306fdc025661e451df03c DIFF: https://github.com/llvm/llvm-project/commit/002e07208a67351f75e306fdc025661e451df03c.diff

[PATCH] D71846: [ASTMatchers] Fix for https://bugs.llvm.org/show_bug.cgi?id=44364

njames93 added a comment. It does support the new range for loop, I'll add in a case for that in the AST matcher Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71846/new/ https://reviews.llvm.org/D71846

[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

djtodoro added inline comments. Comment at: llvm/docs/ReleaseNotes.rst:169 +* C DebugInfo API ``LLVMDIBuilderCreateTypedef`` is updated to include an extra +argument ``AlignInBits``, to facilitate / propagate specified Alignment information

[PATCH] D71846: [ASTMatchers] Fix for https://bugs.llvm.org/show_bug.cgi?id=44364

malcolm.parsons added a comment. Does Clang support C++20's range-based for statements with initializer? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71846/new/ https://reviews.llvm.org/D71846 ___