[PATCH] D72066: [clangd] Assert that the testcases in LocateSymbol.All have no diagnostics

2020-01-01 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61162 tests passed, 0 failed and 728 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72066: [clangd] Assert that the testcases in LocateSymbol.All have no diagnostics

2020-01-01 Thread Nathan Ridge via Phabricator via cfe-commits
nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Also fix some bugs in the testcases which this exposed. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72066

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

2020-01-01 Thread Brian Gesiak via Phabricator via cfe-commits
modocache planned changes to this revision. modocache marked 2 inline comments as done and an inline comment as not done. modocache added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1227 +

[PATCH] D71982: [docs] Update path to clang-tools-extra

2020-01-01 Thread Jim Lin via Phabricator via cfe-commits
Jim added a comment. @AlexanderLanin git commit --amend --author="What-is-your-name " ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71982/new/ https://reviews.llvm.org/D71982 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D71884: [OpenMP] Fix formatting of OpenMP error message.

2020-01-01 Thread Wang Tianqing via Phabricator via cfe-commits
tianqing added a comment. Could someone help commit this patch? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71884/new/ https://reviews.llvm.org/D71884 ___ cfe-commits mailing list

[PATCH] D70764: build: reduce CMake handling for zlib

2020-01-01 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd closed this revision. compnerd added a comment. GIT 68a235d07f9 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70764/new/ https://reviews.llvm.org/D70764

[PATCH] D71982: [docs] Update path to clang-tools-extra

2020-01-01 Thread Alexander Lanin via Phabricator via cfe-commits
AlexanderLanin updated this revision to Diff 235801. AlexanderLanin marked an inline comment as done. AlexanderLanin edited the summary of this revision. AlexanderLanin added a comment. Removed change in hacking page as discussed. Can someone commit this as apparently I cannot do it myself (I'll

[PATCH] D71857: [NFC] Fixes -Wrange-loop-analysis warnings

2020-01-01 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. I really like the new feature. Thanks for making the efforts! However, I am afraid I don't like some of the fixes here. You can replace `const auto` with `const auto &` and call that a fix... IMHO if the type is not obvious, `const ConcreteType &` will be better. In

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

2020-01-01 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 61172 tests passed, 1 failed and 728 were skipped. failed: Clang.CodeGen/builtin-align-array.c {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

2020-01-01 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61173 tests passed, 0 failed and 728 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

2020-01-01 Thread Alexander Richardson via Phabricator via cfe-commits
arichardson updated this revision to Diff 235798. arichardson added a comment. Address feedback: Avoid inttoptr by using ptrtoint + GEP instead. Using two GEPs for align_up seems to generate better code than select + a single GEP. See https://godbolt.org/z/UdPjZk Repository: rG LLVM Github

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

2020-01-01 Thread Alexander Richardson via Phabricator via cfe-commits
arichardson marked an inline comment as done. arichardson added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:14322 + if (SrcForMask->getType()->isPointerTy()) { +/// TODO: Use ptrmask instead of ptrtoint/inttoptr +// Result = Builder.CreateIntrinsic(

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

2020-01-01 Thread Alexander Richardson via Phabricator via cfe-commits
arichardson updated this revision to Diff 235799. arichardson added a comment. - Also update the other codegen test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71499/new/ https://reviews.llvm.org/D71499 Files:

[PATCH] D72057: [docs] Update dead anchor in hacking page

2020-01-01 Thread Alexander Lanin via Phabricator via cfe-commits
AlexanderLanin marked an inline comment as done. AlexanderLanin added inline comments. Comment at: clang/www/hacking.html:301 - It is also possible to https://llvm.org/docs/GettingStarted.html#sending-patches-with-git;>use git to contribute to Clang. + It is also possible

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

2020-01-01 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:14322 + if (SrcForMask->getType()->isPointerTy()) { +/// TODO: Use ptrmask instead of ptrtoint/inttoptr +// Result = Builder.CreateIntrinsic( Until we are there, can we still

[clang] 8ca79da - Revert "Adds -Wrange-loop-analysis to -Wall"

2020-01-01 Thread Mark de Wever via cfe-commits
Author: Mark de Wever Date: 2020-01-01T22:19:18+01:00 New Revision: 8ca79dac559219358b0c6bb00bded30935c7aa6a URL: https://github.com/llvm/llvm-project/commit/8ca79dac559219358b0c6bb00bded30935c7aa6a DIFF: https://github.com/llvm/llvm-project/commit/8ca79dac559219358b0c6bb00bded30935c7aa6a.diff

[PATCH] D71846: [ASTMatchers] Fix for https://bugs.llvm.org/show_bug.cgi?id=44364

2020-01-01 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. Yes please, I'm still very new to the llvm contributing system so I would have no idea what to do next. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71846/new/ https://reviews.llvm.org/D71846 ___ cfe-commits

[PATCH] D71174: [clang-tidy] new check: bugprone-signed-char-misuse

2020-01-01 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71174/new/ https://reviews.llvm.org/D71174

[PATCH] D71846: [ASTMatchers] Fix for https://bugs.llvm.org/show_bug.cgi?id=44364

2020-01-01 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. Still LG -- do you need someone to land this on your behalf? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71846/new/ https://reviews.llvm.org/D71846 ___ cfe-commits

[PATCH] D71982: [docs] Update path to clang-tools-extra

2020-01-01 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. As you mention, we're already inconsistent with how we designate where the repo lives on disk, so I'm fine with landing this as-is and making the root part of the path

[PATCH] D72057: [docs] Update dead anchor in hacking page

2020-01-01 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/www/hacking.html:301 - It is also possible to https://llvm.org/docs/GettingStarted.html#sending-patches-with-git;>use git to contribute to Clang. + It is also possible to

[PATCH] D69560: [clang-tidy] Add 'cppcoreguidelines-avoid-adjacent-arguments-of-same-type' check

2020-01-01 Thread Whisperity via Phabricator via cfe-commits
whisperity planned changes to this revision. whisperity added a comment. There are a few really minor bug fixes, test additions, documentation update, etc. coming along soon, but I've some more pressing matters. However, please feel free to review the patch as-is! CHANGES SINCE LAST ACTION

[PATCH] D71846: [ASTMatchers] Fix for https://bugs.llvm.org/show_bug.cgi?id=44364

2020-01-01 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 235791. njames93 added a comment. small reformat CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71846/new/ https://reviews.llvm.org/D71846 Files: clang-tools-extra/clang-tidy/readability/ElseAfterReturnCheck.cpp

[PATCH] D71846: [ASTMatchers] Fix for https://bugs.llvm.org/show_bug.cgi?id=44364

2020-01-01 Thread Nathan James via Phabricator via cfe-commits
njames93 marked an inline comment as done. njames93 added a comment. In D71846#1800503 , @aaron.ballman wrote: > The new option LGTM but one of the tests can be updated to have a less > complex RUN line. that was just put in when i was initially

[PATCH] D72056: [RISCV] Generate PIC address sequence for medany -fno-pic

2020-01-01 Thread James Clarke via Phabricator via cfe-commits
jrtc27 added inline comments. Comment at: llvm/lib/Target/TargetMachine.cpp:192 return false; +// RISC-V non-small code models prefer avoiding copy relocations. +if (TT.isRISCV() && getCodeModel() != CodeModel::Small) MaskRay wrote: > jrtc27

[PATCH] D71174: [clang-tidy] new check: bugprone-signed-char-misuse

2020-01-01 Thread Tamás Zolnai via Phabricator via cfe-commits
ztamas updated this revision to Diff 235790. ztamas added a comment. Update warning message in test files and rebase patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71174/new/ https://reviews.llvm.org/D71174 Files:

[PATCH] D71846: [ASTMatchers] Fix for https://bugs.llvm.org/show_bug.cgi?id=44364

2020-01-01 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 235788. njames93 added a comment. removed the unnecessary explicit setting of WarnOnUnfixable value for test case CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71846/new/ https://reviews.llvm.org/D71846 Files:

[PATCH] D72056: [RISCV] Generate PIC address sequence for medany -fno-pic

2020-01-01 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay marked 2 inline comments as done. MaskRay added a subscriber: bsdjhb. MaskRay added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVExpandPseudoInsts.cpp:680 + if (MF->getTarget().isPositionIndependent() || + MF->getTarget().getCodeModel() !=

[PATCH] D72056: [RISCV] Generate PIC address sequence for medany -fno-pic

2020-01-01 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D72056#1800524 , @jrtc27 wrote: > I am still of the view that we should support rewriting the instruction > stream in the linker when necessary like BFD does. We need to do this to be > able to link in GCC-compiled code,

[PATCH] D68913: Adds fixit hints to the Wrange-loop-analysis

2020-01-01 Thread Mark de Wever via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGf022a5a792fd: Adds fixit hints to the -Wrange-loop-analysis (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68913/new/

[PATCH] D71857: [NFC] Fixes -Wrange-loop-analysis warnings

2020-01-01 Thread Mark de Wever via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG8dc7b982b455: [NFC] Fixes -Wrange-loop-analysis warnings (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71857/new/

[PATCH] D68912: Adds -Wrange-loop-analysis to -Wall

2020-01-01 Thread Mark de Wever via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd8117542ac57: Adds -Wrange-loop-analysis to -Wall (authored by Mordante). Changed prior to commit: https://reviews.llvm.org/D68912?vs=226539=235783#toc Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D72056: [RISCV] Generate PIC address sequence for medany -fno-pic

2020-01-01 Thread James Clarke via Phabricator via cfe-commits
jrtc27 added a comment. I am still of the view that we should support rewriting the instruction stream in the linker when necessary like BFD does. We need to do this to be able to link in GCC-compiled code, including libraries. It is a very simple thing to do with a patch available that

[PATCH] D71806: Improve Wrange-loop-analyses for rvalue reference

2020-01-01 Thread Mark de Wever via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe5ab1e49f958: Improve Wrange-loop-analyses for rvalue reference (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71806/new/

[clang] 8dc7b98 - [NFC] Fixes -Wrange-loop-analysis warnings

2020-01-01 Thread Mark de Wever via cfe-commits
Author: Mark de Wever Date: 2020-01-01T20:01:37+01:00 New Revision: 8dc7b982b4556c243e0502e6e230bdd53ddd65ff URL: https://github.com/llvm/llvm-project/commit/8dc7b982b4556c243e0502e6e230bdd53ddd65ff DIFF: https://github.com/llvm/llvm-project/commit/8dc7b982b4556c243e0502e6e230bdd53ddd65ff.diff

[PATCH] D71982: [docs] Update path to clang-tools-extra

2020-01-01 Thread Alexander Lanin via Phabricator via cfe-commits
AlexanderLanin marked 3 inline comments as done. AlexanderLanin added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/Contributing.rst:66 -Once you are done, change to the ``llvm/tools/clang/tools/extra`` directory, and +Once you are done, change to the

[PATCH] D72057: [docs] Update dead anchor in hacking page

2020-01-01 Thread Alexander Lanin via Phabricator via cfe-commits
AlexanderLanin created this revision. AlexanderLanin added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72057 Files: clang/www/hacking.html Index: clang/www/hacking.html

[PATCH] D72056: [RISCV] Generate PIC address sequence for medany -fno-pic

2020-01-01 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay created this revision. Herald added subscribers: llvm-commits, cfe-commits, luismarques, apazos, sameer.abuasal, pzheng, s.egerton, lenary, Jim, benna, psnobl, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng,

[PATCH] D71846: [ASTMatchers] Fix for https://bugs.llvm.org/show_bug.cgi?id=44364

2020-01-01 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. The new option LGTM but one of the tests can be updated to have a less complex RUN line. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-else-after-return.cpp:2-3 +// RUN:

[PATCH] D71846: [ASTMatchers] Fix for https://bugs.llvm.org/show_bug.cgi?id=44364

2020-01-01 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 235775. njames93 added a comment. Added option to disable warning when an automatic fix can't be applied due to scope restrictions of variables, default option is to show all warnings CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71846/new/

[PATCH] D71846: [ASTMatchers] Fix for https://bugs.llvm.org/show_bug.cgi?id=44364

2020-01-01 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. In D71846#1800481 , @aaron.ballman wrote: > In D71846#1800480 , @njames93 wrote: > > > Definitely default to diagnosing everything, that's how my current > > implementation looks right

[PATCH] D71846: [ASTMatchers] Fix for https://bugs.llvm.org/show_bug.cgi?id=44364

2020-01-01 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D71846#1800480 , @njames93 wrote: > In D71846#1800411 , @aaron.ballman > wrote: > > > In D71846#1800401 , @njames93 > > wrote: > > > > >

[PATCH] D71846: [ASTMatchers] Fix for https://bugs.llvm.org/show_bug.cgi?id=44364

2020-01-01 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. In D71846#1800411 , @aaron.ballman wrote: > In D71846#1800401 , @njames93 wrote: > > > In D71846#1800381 , @aaron.ballman > > wrote: > > > > > In

[PATCH] D72053: [RFC] Handling implementation limits

2020-01-01 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61168 tests passed, 0 failed and 728 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D71174: [clang-tidy] new check: bugprone-signed-char-misuse

2020-01-01 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SignedCharMisuseCheck.cpp:97-98 + diag(CastExpression->getBeginLoc(), + "singed char -> integer (%0) conversion; " + "consider to cast to unsigned char first.") + <<

[PATCH] D71174: [clang-tidy] new check: bugprone-signed-char-misuse

2020-01-01 Thread Tamás Zolnai via Phabricator via cfe-commits
ztamas marked 2 inline comments as done. ztamas added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SignedCharMisuseCheck.cpp:97-98 + diag(CastExpression->getBeginLoc(), + "singed char -> integer (%0) conversion; " + "consider to cast to

[PATCH] D54395: [clang-tidy] implement utility-function to add 'const' to variables

2020-01-01 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I think this generally looks good, thank you for all the hard work on this! I just found some minor nits and testing requests. Assuming no surprises with the tests, LGTM.

[PATCH] D72053: [RFC] Handling implementation limits

2020-01-01 Thread Mark de Wever via Phabricator via cfe-commits
Mordante created this revision. Mordante added a project: clang. Herald added a subscriber: mgorny. This is a proof-of-concept patch to be discussed on the dev ml. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72053 Files: clang/docs/ImplementationQuantities.rst

[PATCH] D71857: [NFC] Fixes -Wrange-loop-analysis warnings

2020-01-01 Thread Mark de Wever via Phabricator via cfe-commits
Mordante marked 2 inline comments as done. Mordante added a comment. Thanks for the review! I'll commit all the -Wrange-loop-analysis patches later today. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71857/new/ https://reviews.llvm.org/D71857

[PATCH] D71174: [clang-tidy] new check: bugprone-signed-char-misuse

2020-01-01 Thread Tamás Zolnai via Phabricator via cfe-commits
ztamas updated this revision to Diff 235765. ztamas marked an inline comment as done. ztamas added a comment. Update docs / warning message, according to reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71174/new/

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

2020-01-01 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61172 tests passed, 0 failed and 728 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D71846: [ASTMatchers] Fix for https://bugs.llvm.org/show_bug.cgi?id=44364

2020-01-01 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D71846#1800401 , @njames93 wrote: > In D71846#1800381 , @aaron.ballman > wrote: > > > In D71846#1800344 , @njames93 > > wrote: > > > > >

[PATCH] D71857: [NFC] Fixes -Wrange-loop-analysis warnings

2020-01-01 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71857/new/ https://reviews.llvm.org/D71857 ___ cfe-commits

[PATCH] D72052: [UserManual] Update the C++ standard support

2020-01-01 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61168 tests passed, 0 failed and 728 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

2020-01-01 Thread Alexander Richardson via Phabricator via cfe-commits
arichardson updated this revision to Diff 235764. arichardson marked an inline comment as done. arichardson added a comment. - Address remaining comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71499/new/ https://reviews.llvm.org/D71499

[PATCH] D71846: [ASTMatchers] Fix for https://bugs.llvm.org/show_bug.cgi?id=44364

2020-01-01 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. In D71846#1800381 , @aaron.ballman wrote: > In D71846#1800344 , @njames93 wrote: > > > I'm in two minds about issuing a warning when scope restrictions prevent a > > fix. Do you think

[PATCH] D71857: [NFC] Fixes -Wrange-loop-analysis warnings

2020-01-01 Thread Mark de Wever via Phabricator via cfe-commits
Mordante marked 8 inline comments as done. Mordante added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptx86ABIFixups.cpp:22 #include "lldb/Target/Process.h" #include "lldb/Utility/Log.h"

[PATCH] D71857: [NFC] Fixes -Wrange-loop-analysis warnings

2020-01-01 Thread Mark de Wever via Phabricator via cfe-commits
Mordante updated this revision to Diff 235763. Mordante retitled this revision from "Fixes -Wrange-loop-analysis warnings" to "[NFC] Fixes -Wrange-loop-analysis warnings". Mordante added a comment. Reviewed the types and added a `*` for pointers and added a `const` when applicable. CHANGES

[PATCH] D72052: [UserManual] Update the C++ standard support

2020-01-01 Thread Mark de Wever via Phabricator via cfe-commits
Mordante created this revision. Mordante added a reviewer: rsmith. Mordante added a project: clang. This brings the state in sync with http://clang.llvm.org/cxx_status.html. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72052 Files: clang/docs/UsersManual.rst Index:

[PATCH] D71966: [Wdocumentation][RFC] Improve identifier's of \param

2020-01-01 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings . {icon times-circle color=red}

[PATCH] D72049: clang-tidy doc: Remove severities as they don't make consensus

2020-01-01 Thread Sylvestre Ledru via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG773667b8c20d: clang-tidy doc: Remove severities as they dont make consensus (authored by sylvestre.ledru). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 773667b - clang-tidy doc: Remove severities as they don't make consensus

2020-01-01 Thread Sylvestre Ledru via cfe-commits
Author: Sylvestre Ledru Date: 2020-01-01T15:42:46+01:00 New Revision: 773667b8c20d35c18334f8c7663df8ceacfdd2e5 URL: https://github.com/llvm/llvm-project/commit/773667b8c20d35c18334f8c7663df8ceacfdd2e5 DIFF:

[PATCH] D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

2020-01-01 Thread Kamil Rytarowski via Phabricator via cfe-commits
krytarowski added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70048/new/ https://reviews.llvm.org/D70048 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D71846: [ASTMatchers] Fix for https://bugs.llvm.org/show_bug.cgi?id=44364

2020-01-01 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D71846#1800344 , @njames93 wrote: > I'm in two minds about issuing a warning when scope restrictions prevent a > fix. Do you think creating an option to enable or disable emitting warnings > for cases where the scope

[PATCH] D72049: clang-tidy doc: Remove severities as they don't make consensus

2020-01-01 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for backing this out while we discuss the best way forward. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71963: clang-tidy doc: Add the severities description

2020-01-01 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D71963#1800102 , @sylvestre.ledru wrote: > ok, thanks! > I will remove them tomorrow or the next day. > > Do you have any guidance about the next steps to add them back? Yes, sorry about failing to talk about it! I

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

2020-01-01 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a few nits to be fixed. Comment at: clang/lib/AST/ExprConstant.cpp:8156-8158 + } else if (const Expr *E = Value.Base.dyn_cast()) { +return

Re: [PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

2020-01-01 Thread Florin Iucha via cfe-commits
Hi Jonas, Don't know how to attach another patch to Phabricator, but I have added some tests that fail. Happy New Year! florin On 12/31/19 10:11 AM, Jonas Toth via Phabricator wrote: JonasToth updated this revision to Diff 235712. JonasToth added a comment. - fix error from

[PATCH] D71846: [ASTMatchers] Fix for https://bugs.llvm.org/show_bug.cgi?id=44364

2020-01-01 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. I'm in two minds about issuing a warning when scope restrictions prevent a fix. Do you think creating an option to enable or disable emitting warnings for cases where the scope prevents a fix would be a good idea? CHANGES SINCE LAST ACTION

[PATCH] D71963: clang-tidy doc: Add the severities description

2020-01-01 Thread Sylvestre Ledru via Phabricator via cfe-commits
sylvestre.ledru added a comment. @aaron.ballman done in https://reviews.llvm.org/D72049 By the way, when you say: > There are other models that exist and are maintained. > Other models are also pretty good. which lists do you have in mind? thanks Repository: rG LLVM Github Monorepo

[PATCH] D72049: clang-tidy doc: Remove severities as they don't make consensus

2020-01-01 Thread Sylvestre Ledru via Phabricator via cfe-commits
sylvestre.ledru created this revision. Herald added subscribers: cfe-commits, whisperity. Herald added a reviewer: jdoerfert. Herald added a project: clang. sylvestre.ledru added a reviewer: aaron.ballman. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72049 Files:

[PATCH] D71980: [clang-tidy] Disable Checks on If constexpr statements in template Instantiations for BugproneBranchClone and ReadabilityBracesAroundStatements

2020-01-01 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 235755. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71980/new/ https://reviews.llvm.org/D71980 Files: clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp clang-tools-extra/clang-tidy/readability/BracesAroundStatementsCheck.cpp

[PATCH] D71846: [ASTMatchers] Fix for https://bugs.llvm.org/show_bug.cgi?id=44364

2020-01-01 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 235752. njames93 added a comment. hopefully adhered to all conventions :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71846/new/ https://reviews.llvm.org/D71846 Files: clang-tools-extra/clang-tidy/readability/ElseAfterReturnCheck.cpp

[clang] d2bb8c1 - [MC][TargetMachine] Delete MCTargetOptions::MCPIECopyRelocations

2020-01-01 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2020-01-01T00:50:18-08:00 New Revision: d2bb8c16e711602481c8b33d0e2ccc9994eb6641 URL: https://github.com/llvm/llvm-project/commit/d2bb8c16e711602481c8b33d0e2ccc9994eb6641 DIFF: https://github.com/llvm/llvm-project/commit/d2bb8c16e711602481c8b33d0e2ccc9994eb6641.diff