[PATCH] D73367: [clangd] Go-to-definition on 'override' jumps to overridden method(s)

sammccall added a comment. (the clang-tidy check doesn't reflect a style guideline and I'm not sure it's a good idea, raised on D72217 which added it) Comment at: clang-tools-extra/clangd/XRefs.cpp:287 +// We may be overridding

[PATCH] D72530: Set traversal explicitly where needed in clang-tidy

steveire updated this revision to Diff 240816. steveire added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72530/new/ https://reviews.llvm.org/D72530 Files: clang-tools-extra/clang-tidy/abseil/DurationDivisionCheck.cpp

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

sammccall added a comment. This check as configured for LLVM itself is pretty noisy, generating warnings like: > warning: 'auto *CTSD' can be declared as 'const auto *CTSD' > [llvm-qualified-auto] which the LLVM dev guide doesn't have an opinion about. AFAICS there's no option to disable

[PATCH] D73453: Preserve -nostdinc and --sysroot when calling query driver

topisani updated this revision to Diff 240815. topisani marked an inline comment as done. topisani added a comment. Address CR Comments I couldn't think of a good way to check for `--sysroot /my/sysroot` in the test in posix shell, so i hope the grep usage is OK. CHANGES SINCE LAST ACTION

[PATCH] D72508: [clangd] Support pseudo-obj expr, opaque values, and property references in findExplicitReferences()

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62195 tests passed, 0 failed and 815 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73536: [analyser][taint] Remove taint from symbolic expressions if used in comparisons

steakhal created this revision. steakhal added reviewers: NoQ, Szelethus. steakhal added a project: clang. Herald added subscribers: cfe-commits, JDevlieghere. steakhal added a subscriber: boga95. **Remove taint from symbolic expressions if used in comparison expressions.** **Problem statement

[PATCH] D72527: [clang-tidy] adjust scripts to subsubsections in Release Notes

njames93 added a comment. In D72527#1843475 , @Eugene.Zelenko wrote: > As I wrote, I don't have GitHub commit access, so I need help with commit. Needs rebasing on trunk, ReleaseNotes.rst is causing conflicts Repository: rG LLVM Github Monorepo

[PATCH] D73344: [clangd][Hover] Handle uninstantiated templates

This revision was automatically updated to reflect the committed changes. Closed by commit rGa31a61dafeaa: [clangd][Hover] Handle uninstantiated templates (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73344/new/

[clang-tools-extra] a31a61d - [clangd][Hover] Handle uninstantiated templates

Author: Kadir Cetinkaya Date: 2020-01-28T11:22:02+01:00 New Revision: a31a61dafeaa9110687110fc127ea6f7c91dd3e6 URL: https://github.com/llvm/llvm-project/commit/a31a61dafeaa9110687110fc127ea6f7c91dd3e6 DIFF:

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille updated this revision to Diff 240813. serge-sans-paille added a comment. @MaskRay should we add a verifier step to check that pie/pic/semanticinterposition module flags are consistent, or leave that to clang ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille marked 3 inline comments as done. serge-sans-paille added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:488 + if (Context.getLangOpts().SemanticInterposition && + (Context.getLangOpts().PICLevel && !Context.getLangOpts().PIE)) +//

[PATCH] D72508: [clangd] Support pseudo-obj expr, opaque values, and property references in findExplicitReferences()

This revision was automatically updated to reflect the committed changes. Closed by commit rGf4871ead55f5: [clangd] Support pseudo-obj expr, opaque values, and property references in… (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72634: [clangd] Improve ObjC property handling in SelectionTree.

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf071f03f379: [clangd] Improve ObjC property handling in SelectionTree. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72634/new/

[PATCH] D72508: [clangd] Support pseudo-obj expr, opaque values, and property references in findExplicitReferences()

sammccall updated this revision to Diff 240809. sammccall marked 4 inline comments as done. sammccall added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72508/new/ https://reviews.llvm.org/D72508 Files:

[PATCH] D72448: [clang-tidy] readability-redundant-string-init now flags redundant initialisation in Field Decls and Constructor Initialisers

njames93 marked 2 inline comments as done. njames93 added a comment. Hmm a lot of the code in the redundant-string-init check is designed to be macro unsafe. Not sure the best way to follow up, discard the old macro behaviour or keep it Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang-tools-extra] f4871ea - [clangd] Support pseudo-obj expr, opaque values, and property references in findExplicitReferences()

Author: Sam McCall Date: 2020-01-28T11:13:33+01:00 New Revision: f4871ead55f59a7dfee56ea97c32b5df4209d9ce URL: https://github.com/llvm/llvm-project/commit/f4871ead55f59a7dfee56ea97c32b5df4209d9ce DIFF: https://github.com/llvm/llvm-project/commit/f4871ead55f59a7dfee56ea97c32b5df4209d9ce.diff

[clang-tools-extra] af071f0 - [clangd] Improve ObjC property handling in SelectionTree.

Author: Sam McCall Date: 2020-01-28T11:07:19+01:00 New Revision: af071f03f379f7f1071e9da23ee4ca26d2c5c509 URL: https://github.com/llvm/llvm-project/commit/af071f03f379f7f1071e9da23ee4ca26d2c5c509 DIFF: https://github.com/llvm/llvm-project/commit/af071f03f379f7f1071e9da23ee4ca26d2c5c509.diff

[PATCH] D71920: [AST] Refactor propagation of dependency bits. NFC

ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments. Comment at: clang/include/clang/AST/DependencyFlags.h:17-28 +enum class DependencyFlags : uint8_t { + Type = 1, + Value = 2, + Instantiation = 4, + UnexpandedPack = 8, + + // Shorthands for

[PATCH] D73457: [Clang] Warn about 'z' printf modifier in old MSVC.

simon_tatham added a comment. In D73457#1842605 , @amccarth wrote: > clang will still (by default) use the MS runtime libraries for Windows > builds, in which case it's important for the compatibility version to match > the one for the libraries that

[PATCH] D71965: include missing for std::abort

kadircet closed this revision. kadircet added a comment. Looks like this has landed with https://github.com/llvm/llvm-project/commit/58592f6c49249293f79698cfcb31dba532e12603 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71965/new/

[PATCH] D69585: PerformPendingInstatiations() already in the PCH

llunak marked 2 inline comments as done. llunak added inline comments. Comment at: clang/lib/Sema/Sema.cpp:985-986 + +// FIXME: Instantiating implicit templates already in the PCH breaks some +// OpenMP-specific code paths, see https://reviews.llvm.org/D69585 . +

[PATCH] D73453: Preserve -nostdinc and --sysroot when calling query driver

kadircet added a comment. tests look good, but please upload the logs to the bug report for investigation. Comment at: clang-tools-extra/clangd/QueryDriverDatabase.cpp:137 +llvm::StringRef Arg = CommandLine[I]; +if (llvm::any_of(FlagsToPreserve, [](auto &) { return S

[PATCH] D73457: [Clang] Warn about 'z' printf modifier in old MSVC.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfe0d1b6a8ac5: [Clang] Warn about z printf modifier in old MSVC. (authored by simon_tatham). Changed prior to commit: https://reviews.llvm.org/D73457?vs=240626=240796#toc Repository: rG LLVM Github

[clang] fe0d1b6 - [Clang] Warn about 'z' printf modifier in old MSVC.

Author: Simon Tatham Date: 2020-01-28T09:04:45Z New Revision: fe0d1b6a8ac5048b8007e5e7cc2aeb4e3291bda0 URL: https://github.com/llvm/llvm-project/commit/fe0d1b6a8ac5048b8007e5e7cc2aeb4e3291bda0 DIFF: https://github.com/llvm/llvm-project/commit/fe0d1b6a8ac5048b8007e5e7cc2aeb4e3291bda0.diff LOG:

<    1   2   3