[PATCH] D72954: [clang-doc] Improving Markdown Output

Clayton reopened this revision. Clayton added a comment. This revision is now accepted and ready to land. Fixing build error CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72954/new/ https://reviews.llvm.org/D72954 ___ cfe-commits mailing

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

ABataev added inline comments. Comment at: clang/include/clang/Driver/Options.td:3412-3414 +def fsycl : Flag<["-"], "fsycl">, Group, + HelpText<"Enable SYCL kernels compilation for device">; +def sycl_std_EQ : Joined<["-"], "sycl-std=">, Group, Flags<[CC1Option]>,

[PATCH] D73876: [clang-tidy] Fix a false positive about C++17 deduced class template types in unused-using-decl check.

hokein updated this revision to Diff 242065. hokein marked an inline comment as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73876/new/ https://reviews.llvm.org/D73876 Files:

[PATCH] D73742: [Clang][Driver] After default -fintegrated-cc1, fix report_fatal_error no longer generates preprocessed source + reproducer.sh

hans added a comment. I think so, but I need to look closer at the CrashRecoveryContext changes, and it would help to do that separately. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73742/new/ https://reviews.llvm.org/D73742

[PATCH] D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check

alexeyr marked an inline comment as done. alexeyr added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc-redundant-expression.cpp:114 if (P.a[X++] != P.a[X++]) return 1; + if (X && X++ && X) return 1; aaron.ballman wrote: >

[PATCH] D72705: [clang][checkers] Added new checker 'alpha.unix.ErrorReturn'.

balazske updated this revision to Diff 242064. balazske added a comment. - Bug fixes in the generic code. - Added new check types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72705/new/ https://reviews.llvm.org/D72705 Files:

[PATCH] D72304: [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder.

jdoerfert reopened this revision. jdoerfert added a comment. This revision is now accepted and ready to land. Reverted in 9dcfc7cd64abb301124cafaa95661b76a1fc5032 because of breakages and warnings:

[PATCH] D73742: [Clang][Driver] After default -fintegrated-cc1, fix report_fatal_error no longer generates preprocessed source + reproducer.sh

aganea added a comment. In D73742#1854773 , @hans wrote: > > Evidently I can cut the patch in smaller pieces, let me know. > > Yes, I think this would be good. There's a lot going on in this patch, and it > would be good to separate the simple stuff from

[PATCH] D73876: [clang-tidy] Fix a false positive about C++17 deduced class template types in unused-using-decl check.

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc-unused-using-decls-cxx17.cpp:10 +}; +// Deduction hint (CTAD) +template Foo(T t) -> Foo;

[clang] 9dcfc7c - Revert "[OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder."

Author: Johannes Doerfert Date: 2020-02-03T08:59:14-06:00 New Revision: 9dcfc7cd64abb301124cafaa95661b76a1fc5032 URL: https://github.com/llvm/llvm-project/commit/9dcfc7cd64abb301124cafaa95661b76a1fc5032 DIFF:

[PATCH] D73742: [Clang][Driver] After default -fintegrated-cc1, fix report_fatal_error no longer generates preprocessed source + reproducer.sh

hans added a comment. > Evidently I can cut the patch in smaller pieces, let me know. Yes, I think this would be good. There's a lot going on in this patch, and it would be good to separate the simple stuff from the tricky parts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 84959ae - [Concepts] Instantiate invented template type parameter type-constraint along with function parameters

Author: Saar Raz Date: 2020-02-03T16:51:49+02:00 New Revision: 84959ae47f447fca9d56a9c61e8c46e993d0387a URL: https://github.com/llvm/llvm-project/commit/84959ae47f447fca9d56a9c61e8c46e993d0387a DIFF: https://github.com/llvm/llvm-project/commit/84959ae47f447fca9d56a9c61e8c46e993d0387a.diff

[PATCH] D72304: [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1ca740387b9b: [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder. (authored by fghanim, committed by jdoerfert). Changed prior to commit:

[PATCH] D73891: [RISCV] Support experimental/unratified extensions

simoncook created this revision. simoncook added reviewers: asb, lenary, PaoloS, s.egerton. Herald added subscribers: cfe-commits, luismarques, apazos, sameer.abuasal, pzheng, Jim, benna, psnobl, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, MaskRay,

[clang] 1ca7403 - [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder.

Author: Fady Ghanim Date: 2020-02-03T08:44:23-06:00 New Revision: 1ca740387b9bbdc142ac81c8bdd6370a8813e328 URL: https://github.com/llvm/llvm-project/commit/1ca740387b9bbdc142ac81c8bdd6370a8813e328 DIFF: https://github.com/llvm/llvm-project/commit/1ca740387b9bbdc142ac81c8bdd6370a8813e328.diff

[PATCH] D72705: [clang][checkers] Added new checker 'alpha.unix.ErrorReturn'.

baloghadamsoftware added a comment. Please add tests for all the functions in the list. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72705/new/ https://reviews.llvm.org/D72705 ___ cfe-commits mailing

[clang] 8c16d8b - Revert "[Concepts] Instantiate invented template type parameter type-constraint along with function parameters"

Author: Saar Raz Date: 2020-02-03T16:04:48+02:00 New Revision: 8c16d8b235b997389a26d0ac7efe7840e208bb4d URL: https://github.com/llvm/llvm-project/commit/8c16d8b235b997389a26d0ac7efe7840e208bb4d DIFF: https://github.com/llvm/llvm-project/commit/8c16d8b235b997389a26d0ac7efe7840e208bb4d.diff

[PATCH] D73873: [clangd] Mechanism to make update debounce responsive to rebuild speed.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. looks good, a few nits. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:249 + llvm::SmallVector + RebuildTimes; /* GUARDED_BY(Mutex) */ /// File that ASTWorker

[clang] eacca48 - [Concepts] Instantiate invented template type parameter type-constraint along with function parameters

Author: Saar Raz Date: 2020-02-03T15:47:32+02:00 New Revision: eacca4824463d8b96e2e1c9f8bbf886055218a16 URL: https://github.com/llvm/llvm-project/commit/eacca4824463d8b96e2e1c9f8bbf886055218a16 DIFF: https://github.com/llvm/llvm-project/commit/eacca4824463d8b96e2e1c9f8bbf886055218a16.diff

[PATCH] D72867: [clangd] Support renaming designated initializers

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62405 tests passed, 0 failed and 839 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73876: [clang-tidy] Fix a false positive about C++17 deduced class template types in unused-using-decl check.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62415 tests passed, 0 failed and 839 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running

[PATCH] D72742: Don't assume promotable integers are zero/sign-extended already in x86-64 ABI.

emilio added a comment. Could anyone update me with how do they want me to proceed here? Is fixing the coercions enough to allow this to land? Do I need to make it target-specific? If so, which targets should keep the current behavior? Another slightly more backwards-compatible alternative

[PATCH] D72867: [clangd] Support renaming designated initializers

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:639 +void VisitDesignatedInitExpr(const DesignatedInitExpr *DIE) { + for (const DesignatedInitExpr::Designator : DIE->designators()) { +if (!D.isFieldDesignator())

[PATCH] D72867: [clangd] Support renaming designated initializers

kbobyrev updated this revision to Diff 242040. kbobyrev marked an inline comment as done. kbobyrev added a comment. Add tests for nested designated initializers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72867/new/

[PATCH] D73856: [docu] Improve docu of misc-misplaced-const

aaron.ballman added a comment. > East const makes the problem more obvious. With west const people were > telling me the const is on the wrong side. I don't see how this makes the problem more obvious and it seems odd to me that we'd mix styles in code and prose. I prefer leaving this as a

[PATCH] D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc-redundant-expression.cpp:114 if (P.a[X++] != P.a[X++]) return 1; + if (X && X++ && X) return 1; What do you think about the following? ``` bool foo(int&);

[PATCH] D73876: [clang-tidy] Fix a false positive about C++17 deduced class template types in unused-using-decl check.

hokein created this revision. hokein added a reviewer: gribozavr2. Herald added a subscriber: xazax.hun. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73876 Files: clang-tools-extra/clang-tidy/misc/UnusedUsingDeclsCheck.cpp

[PATCH] D73090: [clang-tidy] Fix PR#44528 'modernize-use-using and enums'

aaron.ballman closed this revision. aaron.ballman added a comment. In D73090#1854031 , @f00kat wrote: > Sorry for my english. Sometimes it's more difficult than bug fixing It's not a problem at all, that's why we help one another out spotting those

[clang-tools-extra] 6423ae4 - Allow modernize-use-using to apply to enumerations as well.

Author: Karasev Nikita Date: 2020-02-03T07:54:38-05:00 New Revision: 6423ae417e17611c4ee529f5848e839e6d9cb795 URL: https://github.com/llvm/llvm-project/commit/6423ae417e17611c4ee529f5848e839e6d9cb795 DIFF:

Re: [clang] 1f3f8c3 - PR44721: Don't consider overloaded operators for built-in comparisons

Yes, go ahead. On Fri, Jan 31, 2020 at 2:19 AM Richard Smith wrote: > > Hi Hans, > > This is a pretty safe bugfix for a new feature in Clang 10. OK for branch? > > On Thu, 30 Jan 2020 at 17:17, Richard Smith via cfe-commits > wrote: >> >> >> Author: Richard Smith >> Date:

[clang] 0ce5773 - [clang] Add a missing change of bdbdf748225525bb18cd0ffeb51c3e713f7b8e1b, fix the buildbot.

Author: Haojian Wu Date: 2020-02-03T13:43:26+01:00 New Revision: 0ce57731da9bf5967d0332b0b1d35790b65007d7 URL: https://github.com/llvm/llvm-project/commit/0ce57731da9bf5967d0332b0b1d35790b65007d7 DIFF: https://github.com/llvm/llvm-project/commit/0ce57731da9bf5967d0332b0b1d35790b65007d7.diff

[PATCH] D73865: [CodeGenModule] Assume dso_local for -fpic -fno-semantic-interposition

merge_guards_bot added a comment. Herald added subscribers: wuzish, dexonsmith. {icon times-circle color=red} Unit tests: fail. 62284 tests passed, 121 failed and 839 were skipped. failed: Clang.CXX/modules-ts/basic/basic_link/p3.cppm failed: Clang.CXX/modules-ts/codegen-basics.cppm

[PATCH] D73865: [CodeGenModule] Assume dso_local for -fpic -fno-semantic-interposition

peter.smith added a comment. If I've understood correctly this would make LLVM more aggressive for PIC relocation models, but perhaps more honest in an inter procedural optimisation context? The code changes look fine to me, I'm wondering if we've discussed this widely enough with the

[PATCH] D73865: [CodeGenModule] Assume dso_local for -fpic -fno-semantic-interposition

MaskRay created this revision. MaskRay added reviewers: peter.smith, rnk, serge-sans-paille, sfertile. Herald added subscribers: cfe-commits, luismarques, apazos, sameer.abuasal, pzheng, s.egerton, lenary, Jim, jsji, jocewei, PkmX, arphaman, the_o, brucehoult, MartinMosbeck, rogfer01, atanasyan,

[PATCH] D72304: [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder.

fghanim added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72304/new/ https://reviews.llvm.org/D72304 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D73873: [clangd] Mechanism to make update debounce responsive to rebuild speed.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62406 tests passed, 0 failed and 839 were skipped. {icon times-circle color=red} clang-tidy: fail. clang-tidy found 0 errors and 1 warnings

[PATCH] D73873: [clangd] Mechanism to make update debounce responsive to rebuild speed.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, javed.absar, ilya-biryukov. Herald added a project: clang. Currently we delay AST rebuilds by 500ms after each edit, to wait for further

[PATCH] D73869: [clang][AST] Add an AST matcher for deducedTemplateSpeializationType.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62408 tests passed, 0 failed and 839 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running

[PATCH] D73834: Update for Clang 10 release notes

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Looks good to me, go a head and commit it to the branch. > Can you cherry-pick c03349e40f21 > for > D73434

[PATCH] D73536: [analyser][taint] Remove taint from symbolic expressions if used in comparisons

Szelethus added a comment. In D73536#1845031 , @NoQ wrote: > > Describing value constraints in the taint config file is unfeasible. > > This is the only correct way to go, because, as you yourself point out, every > sink function (or other use of tainted

[PATCH] D73869: [clang][AST] Add an AST matcher for deducedTemplateSpeializationType.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62408 tests passed, 0 failed and 839 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running

[PATCH] D73786: [ARM,MVE] Fix vreinterpretq in big-endian mode.

This revision was automatically updated to reflect the committed changes. Closed by commit rG961530fdc9f7: [ARM,MVE] Fix vreinterpretq in big-endian mode. (authored by simon_tatham). Changed prior to commit: https://reviews.llvm.org/D73786?vs=241727=242012#toc Repository: rG LLVM Github

[PATCH] D73357: [ARM,MVE] Add intrinsics for v[id]dupq and v[id]wdupq.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf8d4afc49ad2: [ARM,MVE] Add intrinsics for v[id]dupq and v[id]wdupq. (authored by simon_tatham). Changed prior to commit: https://reviews.llvm.org/D73357?vs=240207=242011#toc Repository: rG LLVM

[PATCH] D73356: [ARM,MVE] Add intrinsics for vdupq.

This revision was automatically updated to reflect the committed changes. Closed by commit rGcf7e98e6f780: [ARM,MVE] Add intrinsics for vdupq. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73356/new/

[clang] cf7e98e - [ARM,MVE] Add intrinsics for vdupq.

Author: Simon Tatham Date: 2020-02-03T11:20:06Z New Revision: cf7e98e6f7805f4e2693a6dbbd12c10fe06fde70 URL: https://github.com/llvm/llvm-project/commit/cf7e98e6f7805f4e2693a6dbbd12c10fe06fde70 DIFF: https://github.com/llvm/llvm-project/commit/cf7e98e6f7805f4e2693a6dbbd12c10fe06fde70.diff LOG:

[PATCH] D73869: [clang][AST] Add an AST matcher for deducedTemplateSpeializationType.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbdbdf7482255: [clang][AST] Add an AST matcher for deducedTemplateSpeializationType. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73869: [clang][AST] Add an AST matcher for deducedTemplateSpeializationType.

hokein updated this revision to Diff 242007. hokein marked an inline comment as done. hokein added a comment. address review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73869/new/ https://reviews.llvm.org/D73869 Files:

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 61851 tests passed, 6 failed and 780 were skipped. failed: libc++.std/language_support/cmp/cmp_partialord/partialord.pass.cpp failed: libc++.std/language_support/cmp/cmp_strongeq/cmp.strongeq.pass.cpp

[clang] bdbdf74 - [clang][AST] Add an AST matcher for deducedTemplateSpeializationType.

Author: Haojian Wu Date: 2020-02-03T12:11:44+01:00 New Revision: bdbdf748225525bb18cd0ffeb51c3e713f7b8e1b URL: https://github.com/llvm/llvm-project/commit/bdbdf748225525bb18cd0ffeb51c3e713f7b8e1b DIFF: https://github.com/llvm/llvm-project/commit/bdbdf748225525bb18cd0ffeb51c3e713f7b8e1b.diff

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 61851 tests passed, 6 failed and 780 were skipped. failed: libc++.std/language_support/cmp/cmp_partialord/partialord.pass.cpp failed: libc++.std/language_support/cmp/cmp_strongeq/cmp.strongeq.pass.cpp

[PATCH] D73869: [clang][AST] Add an AST matcher for deducedTemplateSpeializationType.

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:6043 +/// \endcode +/// \c deducedTemplateSpecializationType() matches the type in \c c. +extern const

[PATCH] D73413: [clang-tidy] Add check to detect external definitions with no header declaration

tonyelewis added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/MissingHeaderFileDeclarationCheck.cpp:75 + continue; +if (AnyHeader || File->NamePart.equals_lower(ThisFile->NamePart)) + return; // Found a good candidate for matching decl

[PATCH] D73869: [clang][AST] Add an AST matcher for deducedTemplateSpeializationType.

hokein created this revision. hokein added a reviewer: gribozavr2. Herald added a project: clang. misc-unused-using clang-tidy check needs this matcher to fix a false positive of C++17 deduced class template types. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73869 Files:

[PATCH] D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check

alexeyr marked 11 inline comments as done. alexeyr added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cpp:363 + ASTContext ) { + const auto OpKind = getOp(TheExpr); + // if there are no nested operators of the

[clang-tools-extra] 6b15a3d - [clangd] TUScheduler::run() (i.e. workspace/symbol) counts towards concurrent threads

Author: Sam McCall Date: 2020-02-03T11:32:33+01:00 New Revision: 6b15a3d722a98c8c4f99ac45cae118e4af9244af URL: https://github.com/llvm/llvm-project/commit/6b15a3d722a98c8c4f99ac45cae118e4af9244af DIFF: https://github.com/llvm/llvm-project/commit/6b15a3d722a98c8c4f99ac45cae118e4af9244af.diff

[PATCH] D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check

alexeyr updated this revision to Diff 242000. alexeyr added a comment. Followed Eugene Zelenko's comments and fixed a false positive. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73775/new/ https://reviews.llvm.org/D73775 Files:

[clang-tools-extra] b79cb54 - [clangd] Refactor TUScheduler options into a struct. NFC

Author: Sam McCall Date: 2020-02-03T11:20:48+01:00 New Revision: b79cb547121dbd9f4bd4eaaf05354829ab74ac8e URL: https://github.com/llvm/llvm-project/commit/b79cb547121dbd9f4bd4eaaf05354829ab74ac8e DIFF: https://github.com/llvm/llvm-project/commit/b79cb547121dbd9f4bd4eaaf05354829ab74ac8e.diff

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

kbobyrev updated this revision to Diff 241994. kbobyrev added a comment. Remove unnecessary include. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72746/new/ https://reviews.llvm.org/D72746 Files: clang-tools-extra/clangd/index/Ref.h

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

kbobyrev updated this revision to Diff 241993. kbobyrev marked 14 inline comments as done. kbobyrev added a comment. Address a number of comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72746/new/ https://reviews.llvm.org/D72746 Files:

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/Ref.h:32 + // + // class Foo {}; + // ^ Foo declaration hokein wrote: > could you confirm with it? this looks like a `Foo` class definition. Good point, I thought it should be

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

gchatelet added inline comments. Comment at: clang/docs/LanguageExtensions.rst:2252 + + * ``__builtin_memcpy_inline`` + efriedma wrote: > This is in the wrong section of the documentation. We could > constant-evaluate __builtin_memcpy_inline, I guess, but that

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

gchatelet updated this revision to Diff 241988. gchatelet marked 3 inline comments as done. gchatelet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73543/new/ https://reviews.llvm.org/D73543 Files:

[PATCH] D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates

awpandey updated this revision to Diff 241984. awpandey marked 2 inline comments as done. awpandey added a comment. Thanks, @aprantl, and @dblaikie. I have added two new test cases as per your suggestions. I have to update // dityperefs-3.8.ll// and //dityperefs-3.8.ll.bc// because they are no

[PATCH] D73354: clang-format: insert trailing commas into containers.

mprobst closed this revision. mprobst marked an inline comment as done. mprobst added a comment. This has landed as https://reviews.llvm.org/rGa324fcf1ae6 (not sure why this hasn't closed automatically). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69868: Allow "callbr" to return non-void values

void added a comment. Friendly ping. :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69868/new/ https://reviews.llvm.org/D69868 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

<    1   2