[PATCH] D74371: [DirectoryWatcher] Fix misuse of FSEvents API and data race

This revision was automatically updated to reflect the committed changes. Closed by commit rG2ac0c4b46ee2: [DirectoryWatcher] Fix misuse of FSEvents API and data race (authored by benlangmuir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74387: [SYCL] Do not diagnose use of __float128

Fznamznon added a comment. In D74387#1869819 , @ABataev wrote: > I would add a check for the use of unsupported types in kernels. They should > not be allowed to be used if target does not support it. Yeah, I think so. We tried to make it using

[clang] 2ac0c4b - [DirectoryWatcher] Fix misuse of FSEvents API and data race

Author: Ben Langmuir Date: 2020-02-11T09:25:38-08:00 New Revision: 2ac0c4b46ee2a3c22b85b4483f2fd4d0fb916720 URL: https://github.com/llvm/llvm-project/commit/2ac0c4b46ee2a3c22b85b4483f2fd4d0fb916720 DIFF: https://github.com/llvm/llvm-project/commit/2ac0c4b46ee2a3c22b85b4483f2fd4d0fb916720.diff

[PATCH] D74044: [ARM] Add initial support for Custom Datapath Extension (CDE)

miyuki updated this revision to Diff 243902. miyuki added a comment. Added IT and VPT predication. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74044/new/ https://reviews.llvm.org/D74044 Files: clang/test/Driver/arm-cde.c llvm/include/llvm/Support/ARMTargetParser.def

[PATCH] D73904: [clang] stop baremetal driver to append .a to lib

christof updated this revision to Diff 243896. christof added a comment. Added a test for arm-none-eabi selection Note that the selection mechanism in the Baremetal driver is rather weak. It does not seem to respond on `-mthumb`, `-march` and `-mcpu` options. The cc1 options show a normalized

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

lebedev.ri added a comment. Herald added a subscriber: wuzish. I would think `contract` change can be separated from the rest of the changes, and therefore should be a separate review (to reduce noise)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74412: Fix SFINAE in CFG.cpp.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74412/new/ https://reviews.llvm.org/D74412

[clang] 9a8defc - [OPENMP50]Add support for relaxed clause in atomic directive.

Author: Alexey Bataev Date: 2020-02-11T11:54:46-05:00 New Revision: 9a8defcc34853e2cdc7d97f12df98c95930556ad URL: https://github.com/llvm/llvm-project/commit/9a8defcc34853e2cdc7d97f12df98c95930556ad DIFF: https://github.com/llvm/llvm-project/commit/9a8defcc34853e2cdc7d97f12df98c95930556ad.diff

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

ABataev added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2548 + Opts.SYCL = Args.hasFlag(options::OPT_fsycl, options::OPT_fno_sycl, false); + Opts.SYCLIsDevice = Args.hasArg(options::OPT_fsycl_is_device); + if (Opts.SYCL || Opts.SYCLIsDevice) {

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc updated this revision to Diff 243888. mibintc added a comment. Herald added subscribers: kbarton, jvesely, nemanjai. This patch is a work in progress. The problem that I want to work on next is that the scope is wrong when the pragma token is seen following the right brace of a function

[PATCH] D73842: [xray][clang] Always add xray-skip-entry/exit and xray-ignore-loops attrs

smeenai added a comment. Is it worth adding a test that a function with an explicit xray-instrument attribute also has these other attributes applied? Comment at: clang/test/CodeGen/xray-attributes-skip-entry-exit.cpp:8 +// RUN: -std=c++11 -triple x86_64-unknown-unknown

[PATCH] D74385: [ARCMT][NFC] Reduce #include dependencies

nicolas17 added a comment. I don't have commit access, can someone push this for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74385/new/ https://reviews.llvm.org/D74385 ___ cfe-commits mailing

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader marked 2 inline comments as done. bader added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2548 + Opts.SYCL = Args.hasFlag(options::OPT_fsycl, options::OPT_fno_sycl, false); + Opts.SYCLIsDevice = Args.hasArg(options::OPT_fsycl_is_device); + if

[PATCH] D74417: [clang][ARC] Remove invalid assertion that can crash clangd

dgoldman created this revision. dgoldman added reviewers: erik.pilkington, jkorous. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, dexonsmith, MaskRay, ilya-biryukov. Herald added a project: clang. - This assertion will fire when functions are marked with

[PATCH] D74387: [SYCL] Do not diagnose use of __float128

rjmccall added a comment. The right approach here is probably what we do in ObjC ARC when we see types that are illegal in ARC: in system headers, we allow the code but add a special `UnavailableAttr` to the declaration so that it can't be directly used. That is straightforward enough that I

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

ABataev added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2548 + Opts.SYCL = Args.hasFlag(options::OPT_fsycl, options::OPT_fno_sycl, false); + Opts.SYCLIsDevice = Args.hasArg(options::OPT_fsycl_is_device); + if (Opts.SYCL || Opts.SYCLIsDevice) {

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader marked 2 inline comments as done. bader added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2548 + Opts.SYCL = Args.hasFlag(options::OPT_fsycl, options::OPT_fno_sycl, false); + Opts.SYCLIsDevice = Args.hasArg(options::OPT_fsycl_is_device); + if

[PATCH] D74333: [ARM,MVE] Add intrinsics for FP rounding operations.

simon_tatham added a comment. In D74333#1869788 , @miyuki wrote: > vrintx is not mentioned anywhere in the patch. Should it say "llvm.rint" > instead? No, I meant what I said: `vrintx` is the MVE machine instruction that `llvm.rint` already

[PATCH] D74387: [SYCL] Do not diagnose use of __float128

ABataev added a comment. I would add a check for the use of unsupported types in kernels. They should not be allowed to be used if target does not support it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74387/new/

[PATCH] D73904: [clang] stop baremetal driver to append .a to lib

psmith accepted this revision. psmith added a comment. This revision is now accepted and ready to land. Thanks for the update, looks good to me. The BareMetal driver tests are better than the location I suggested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73904/new/

[PATCH] D74333: [ARM,MVE] Add intrinsics for FP rounding operations.

miyuki added a comment. > vrintn behaves the same as vrintx vrintx is not mentioned anywhere in the patch. Should it say "llvm.rint" instead? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74333/new/ https://reviews.llvm.org/D74333

[PATCH] D74385: [ARCMT][NFC] Reduce #include dependencies

serge-sans-paille added a comment. LGTM, as long as it builds fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74385/new/ https://reviews.llvm.org/D74385 ___ cfe-commits mailing list

[PATCH] D73904: [clang] stop baremetal driver to append .a to lib

christof added a comment. Just noticed the comment from Peter asking for clang/test/Driver/arm-compiler-rt.c, I'll add that in a moment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73904/new/ https://reviews.llvm.org/D73904 ___

[PATCH] D74372: [OpenMP][IRBuilder] Perform finalization (incl. outlining) late

jdoerfert marked 7 inline comments as done. jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:113 + if (llvm::OpenMPIRBuilder *OMPBuilder = CGM.getOpenMPIRBuilder()) +OMPBuilder->finalize(); } fghanim wrote: > Does this

[PATCH] D74412: Fix SFINAE in CFG.cpp.

jlebar updated this revision to Diff 243877. jlebar added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74412/new/ https://reviews.llvm.org/D74412 Files: clang/lib/Analysis/CFG.cpp Index: clang/lib/Analysis/CFG.cpp

[PATCH] D74414: Use std::foo_t rather than std::foo in clang.

jlebar created this revision. jlebar added reviewers: bkramer, MaskRay. Herald added a reviewer: martong. Herald added a reviewer: shafik. Herald added subscribers: cfe-commits, martong. Herald added a project: clang. No functional change. Repository: rG LLVM Github Monorepo

[PATCH] D74412: Fix SFINAE in CFG.cpp.

jlebar created this revision. jlebar added reviewers: bkramer, MaskRay. Herald added subscribers: cfe-commits, martong. Herald added a project: clang. jlebar updated this revision to Diff 243877. jlebar added a comment. Rebase Used std::enable_if without ::type. Repository: rG LLVM Github

[PATCH] D74411: [clangd] Query constructors in the index during rename.

hokein created this revision. hokein added a reviewer: kbobyrev. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Though this is not needed when using clangd's own index, other indexes (e.g. kythe) need it, as classes and

[PATCH] D73261: [dwarf5] Support DebugInfo for constexpr for C++ variables and functions

dblaikie added a comment. In D73261#1868790 , @djtodoro wrote: > @awpandey Thanks for doing this, but could you please explain the motivation > of implementing this? +1 (as I asked earlier & don't think there's been a response for) CHANGES SINCE LAST

[PATCH] D73904: [clang] stop baremetal driver to append .a to lib

christof updated this revision to Diff 243868. christof added a comment. With updated tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73904/new/ https://reviews.llvm.org/D73904 Files: clang/lib/Driver/ToolChains/BareMetal.cpp clang/test/Driver/baremetal.cpp Index:

[PATCH] D74260: Change default relocation model for hexagon when triple includes musl

bcain added inline comments. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:923 + return ((getTriple().isAndroid() && !getTriple().isAndroidVersionLT(16)) || + getTriple().isMusl() || getSanitizerArgs().requiresPIE()) && + getTriple().getArch() !=

[PATCH] D73742: [Clang][Driver] After default -fintegrated-cc1, fix report_fatal_error no longer generates preprocessed source + reproducer.sh

aganea marked 2 inline comments as done. aganea added a comment. Side-note: Perhaps we would need to do the same as this patch, for calls to `::abort()`? Comment at: llvm/include/llvm/Support/Process.h:205 + + /// When integrated-cc1 is disabled, terminate the current

[PATCH] D74015: [AIX][Frontend] C++ ABI customizations for AIX boilerplate

daltenty added inline comments. Comment at: clang/include/clang/Basic/TargetCXXABI.h:116 +/// - static initialization is adjusted to use sinit and sterm functions; +XL_Clang, + Why the underscore in the name? This is a bit inconsistent with both the

[PATCH] D73742: [Clang][Driver] After default -fintegrated-cc1, fix report_fatal_error no longer generates preprocessed source + reproducer.sh

This revision was automatically updated to reflect the committed changes. Closed by commit rGfaace365088a: [Clang][Driver] After default -fintegrated-cc1, make llvm::report_fatal_error()… (authored by aganea). Changed prior to commit: https://reviews.llvm.org/D73742?vs=243380=243863#toc

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

ABataev added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2548 + Opts.SYCL = Args.hasFlag(options::OPT_fsycl, options::OPT_fno_sycl, false); + Opts.SYCLIsDevice = Args.hasArg(options::OPT_fsycl_is_device); + if (Opts.SYCL || Opts.SYCLIsDevice) {

[clang] faace36 - [Clang][Driver] After default -fintegrated-cc1, make llvm::report_fatal_error() generate preprocessed source + reproducer.sh again.

Author: Alexandre Ganea Date: 2020-02-11T10:17:30-05:00 New Revision: faace365088a2a3a4cb1050a9facfc34a7a56577 URL: https://github.com/llvm/llvm-project/commit/faace365088a2a3a4cb1050a9facfc34a7a56577 DIFF:

[clang] 9a3740c - [OPENMP50]Add restrictions for memory order clauses in atomic directive.

Author: Alexey Bataev Date: 2020-02-11T10:10:41-05:00 New Revision: 9a3740c33919287fd9aa4e0c6f761619e84c62a7 URL: https://github.com/llvm/llvm-project/commit/9a3740c33919287fd9aa4e0c6f761619e84c62a7 DIFF: https://github.com/llvm/llvm-project/commit/9a3740c33919287fd9aa4e0c6f761619e84c62a7.diff

[PATCH] D72932: [ARM] Follow AACPS standard for volatile bit-fields access width

dnsampaio added a comment. Hi @ostannard, thanks for your review. I updated the patch so it won't act when the computed volatile bit-field access will overlap a zero length bit-field, avoiding the conflict. We can update it accordingly to future versions of the AAPCS if required. Repository:

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader marked 3 inline comments as done. bader added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2548 + Opts.SYCL = Args.hasFlag(options::OPT_fsycl, options::OPT_fno_sycl, false); + Opts.SYCLIsDevice = Args.hasArg(options::OPT_fsycl_is_device); + if

[PATCH] D74051: Add a dependency on clang for check-llvm

arichardson updated this revision to Diff 243859. arichardson added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Move tests to clang/ instead Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74051/new/

[PATCH] D74372: [OpenMP][IRBuilder] Perform finalization (incl. outlining) late

fghanim added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:113 + if (llvm::OpenMPIRBuilder *OMPBuilder = CGM.getOpenMPIRBuilder()) +OMPBuilder->finalize(); } Does this mean that `finalize()` is being called twice everytime, here and

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader updated this revision to Diff 243856. bader marked 3 inline comments as done. bader added a comment. Applied review commits from Alexey. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72857/new/ https://reviews.llvm.org/D72857 Files:

[clang] 9ce6dc9 - CWG1423: don't permit implicit conversion of nullptr_t to bool.

Author: Richard Smith Date: 2020-02-11T06:52:45-08:00 New Revision: 9ce6dc9872be4081fb98f6161c28581e1cbbe7dc URL: https://github.com/llvm/llvm-project/commit/9ce6dc9872be4081fb98f6161c28581e1cbbe7dc DIFF: https://github.com/llvm/llvm-project/commit/9ce6dc9872be4081fb98f6161c28581e1cbbe7dc.diff

[clang] 7ef45f4 - P1957R2: conversion from a pointer to bool is considered narrowing.

Author: Richard Smith Date: 2020-02-11T06:52:44-08:00 New Revision: 7ef45f45f6721af4942f0e0bc38329e236b468cd URL: https://github.com/llvm/llvm-project/commit/7ef45f45f6721af4942f0e0bc38329e236b468cd DIFF: https://github.com/llvm/llvm-project/commit/7ef45f45f6721af4942f0e0bc38329e236b468cd.diff

[PATCH] D74214: [clang-tidy] Fix PR#34798 'readability-braces-around-statements breaks statements containing braces.'

ymandel added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/BracesAroundStatementsCheck.cpp:76-77 + + // We need to check that it is not 'InitListExpr' which ends with + // the tokens '};' because it will break the following analysis + tok::TokenKind

[PATCH] D74305: [clangd] Expose completion range in code completion results (C++ API)

This revision was automatically updated to reflect the committed changes. Closed by commit rGd4df372559ad: [clangd] Expose completion range in code completion results (C++ API) (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D74305?vs=243491=243848#toc Repository:

[PATCH] D74214: [clang-tidy] Fix PR#34798 'readability-braces-around-statements breaks statements containing braces.'

ymandel added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/BracesAroundStatementsCheck.cpp:21 -tok::TokenKind getTokenKind(SourceLocation Loc, const SourceManager , -const ASTContext *Context) { - Token Tok; +bool

[clang-tools-extra] d4df372 - [clangd] Expose completion range in code completion results (C++ API)

Author: Sam McCall Date: 2020-02-11T15:25:03+01:00 New Revision: d4df372559adb0ba3c652e85817a50db707c9858 URL: https://github.com/llvm/llvm-project/commit/d4df372559adb0ba3c652e85817a50db707c9858 DIFF: https://github.com/llvm/llvm-project/commit/d4df372559adb0ba3c652e85817a50db707c9858.diff

[PATCH] D74399: [Driver][RISCV] Add RedHat Linux RISC-V triple

lebedev.ri added a comment. passing-by remark: tests missing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74399/new/ https://reviews.llvm.org/D74399 ___ cfe-commits mailing list

[PATCH] D72304: [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder.

fghanim updated this revision to Diff 243839. fghanim added a comment. fixing unused variable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72304/new/ https://reviews.llvm.org/D72304 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp

[PATCH] D67052: Add reference type transformation builtins

miscco added subscribers: cjdb, miscco. miscco added a comment. Some nits, looks great, especially for library concepts. Pinging @cjdb Comment at: clang/lib/AST/TypePrinter.cpp:1020 switch (T->getUTTKind()) { case UnaryTransformType::EnumUnderlyingType:

[PATCH] D74399: [Driver][RISCV] Add RedHat Linux RISC-V triple

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74399/new/ https://reviews.llvm.org/D74399

[PATCH] D67052: Add reference type transformation builtins

zoecarver marked 3 inline comments as done. zoecarver added inline comments. Comment at: clang/lib/AST/TypePrinter.cpp:1028 +case UnaryTransformType::RemoveReferenceType: + OS << "__remove_reference"; + print(T->getBaseType(), OS, StringRef());

[PATCH] D67588: Add builtin trait for add/remove cv (and similar)

zoecarver abandoned this revision. zoecarver added a comment. Closing in favor of D67052 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67588/new/ https://reviews.llvm.org/D67588 ___ cfe-commits mailing

[PATCH] D67052: Add reference type transformation builtins

zoecarver updated this revision to Diff 243834. zoecarver added a comment. - Combine D67052 and D67588 . - Remove `__add*` type traits. - Update mangling/dumping/encoding of all traits. - Remove stress tests. - Address comments

[PATCH] D74033: [clang-tidy] Fix PR#44620 'readability-redundant-string-cstr quick-fix causes invalid code'

f00kat updated this revision to Diff 243833. f00kat added a comment. 1. Add full stops at the end of the lines. 2. Add some static. 3. Fix function 'checkParamDeclOfAncestorCallExprHasRValueRefType' to work well with the function pointer calls. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D74399: [Driver][RISCV] Add RedHat Linux RISC-V triple

luismarques created this revision. luismarques added reviewers: lenary, asb, dlj. Herald added subscribers: cfe-commits, evandro, sameer.abuasal, s.egerton, Jim, benna, psnobl, PkmX, rkruppe, rogfer01, shiva0217, kito-cheng, simoncook. Herald added a project: clang. Adds the RedHat Linux triple

[PATCH] D74331: [ARM,MVE] Add intrinsics for abs, neg and not operations.

MarkMurrayARM accepted this revision. MarkMurrayARM added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74331/new/ https://reviews.llvm.org/D74331

[PATCH] D74305: [clangd] Expose completion range in code completion results (C++ API)

usaxena95 accepted this revision. usaxena95 added a comment. This revision is now accepted and ready to land. Thanks. LG. Comment at: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp:2680 +TEST(CompletionTest, CompletionRange) { + const char* WithRange = "auto x =

[PATCH] D72932: [ARM] Follow AACPS standard for volatile bit-fields access width

ostannard added a comment. I think I've spotted a bug in the ABI spec, which you've faithfully implemented here. I don't know of any other compiler which has implemented this ABI change yet, so it's probably worth seeing if we can get the spec fixed. The intention of the ABI is to avoid

[PATCH] D74396: [clangd] Mention the CLANGD_TRACE env var in the overview as well.

sammccall added a comment. That comment is talking about how CLANGD_FLAGS corresponds to command-line flags in general. The CLANGD_TRACE environment variable controls only one piece of behavior, which doesn't correspond to any flag. (It'd be reasonable to add a matching flag and describe the

[PATCH] D72633: [ARM][MVE] Fix a corner case of checking for MVE-I with -mfpu=none

This revision was automatically updated to reflect the committed changes. Closed by commit rGda3f2b414ace: [ARM][MVE] Fix a corner case of checking for MVE-I with -mfpu=none (authored by chill). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[clang] da3f2b4 - [ARM][MVE] Fix a corner case of checking for MVE-I with -mfpu=none

Author: Momchil Velikov Date: 2020-02-11T12:03:41Z New Revision: da3f2b414ace1f24054ae9255f811b653d9cff99 URL: https://github.com/llvm/llvm-project/commit/da3f2b414ace1f24054ae9255f811b653d9cff99 DIFF: https://github.com/llvm/llvm-project/commit/da3f2b414ace1f24054ae9255f811b653d9cff99.diff

[clang] b46f925 - [clang-format] Improve handling of C# attributes

Author: Jonathan Coe Date: 2020-02-11T12:00:17Z New Revision: b46f925d68d480246e1447f26459bdc894631a88 URL: https://github.com/llvm/llvm-project/commit/b46f925d68d480246e1447f26459bdc894631a88 DIFF: https://github.com/llvm/llvm-project/commit/b46f925d68d480246e1447f26459bdc894631a88.diff LOG:

[PATCH] D74265: [clang-format] Improve handling of C# attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rGb46f925d68d4: [clang-format] Improve handling of C# attributes (authored by Jonathan Coe jb...@google.com). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM

[PATCH] D74396: [clangd] Mention the CLANGD_TRACE env var in the overview as well.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D74396 Files:

[PATCH] D74395: [clangd] Add tracer to the rename workflow, NFC

hokein created this revision. hokein added a reviewer: kbobyrev. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D74395 Files:

[PATCH] D73720: [Analyzer] Use note tags to track container begin and and changes

baloghadamsoftware updated this revision to Diff 243796. baloghadamsoftware added a comment. First real checker `IteratorRange` now marks container as interesting to benefit from container note tags. The other two iterator checkers will be updated after a second phase of container note tags

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

lewis-revill added a comment. Since the DebugInfo fix has been accepted, I'm looking to get this patch and that fix committed shortly if there are no problems caused by rebasing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62686/new/

[PATCH] D74334: [ARM,MVE] Add the vrev16q, vrev32q, vrev64q family.

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Sounds good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74334/new/ https://reviews.llvm.org/D74334

[PATCH] D74336: [ARM,MVE] Add the vmovlbq,vmovltq intrinsic family.

simon_tatham updated this revision to Diff 243793. simon_tatham added a comment. Spotted a mistake by myself: one of my new isel patterns was generating signed VMOVL where it should have been generating unsigned. Fixed, and updated the llc test that had the wrong expectation in it. Also

[PATCH] D74333: [ARM,MVE] Add intrinsics for FP rounding operations.

simon_tatham updated this revision to Diff 243790. simon_tatham added a comment. Rebased to current master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74333/new/ https://reviews.llvm.org/D74333 Files: clang/include/clang/Basic/arm_mve.td

[PATCH] D74337: [ARM,MVE] Add the vmovnbq,vmovntq intrinsic family.

simon_tatham updated this revision to Diff 243794. simon_tatham added a comment. Rebased on top of fixes to previous patches in the stack. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74337/new/ https://reviews.llvm.org/D74337 Files:

[PATCH] D74335: [ARM,MVE] Add intrinsics vclzq and vclsq.

simon_tatham updated this revision to Diff 243792. simon_tatham added a comment. Spotted a mistake by myself: I had accidentally implemented the `vclsq` intrinsics for unsigned integer types as well as signed. ACLE only defines them for signed integers. Also rebased to current master.

[PATCH] D74334: [ARM,MVE] Add the vrev16q, vrev32q, vrev64q family.

simon_tatham updated this revision to Diff 243791. simon_tatham added a comment. Rebased to current master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74334/new/ https://reviews.llvm.org/D74334 Files: clang/include/clang/Basic/arm_mve.td

[PATCH] D74332: [ARM,MVE] Add intrinsics for int <-> float conversion.

simon_tatham updated this revision to Diff 243789. simon_tatham added a comment. Rebased to current master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74332/new/ https://reviews.llvm.org/D74332 Files: clang/include/clang/Basic/arm_mve.td

[PATCH] D74331: [ARM,MVE] Add intrinsics for abs, neg and not operations.

simon_tatham updated this revision to Diff 243788. simon_tatham added a comment. Rebased to current master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74331/new/ https://reviews.llvm.org/D74331 Files: clang/include/clang/Basic/arm_mve.td

[PATCH] D74332: [ARM,MVE] Add intrinsics for int <-> float conversion.

MarkMurrayARM accepted this revision. MarkMurrayARM added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74332/new/ https://reviews.llvm.org/D74332

[PATCH] D73644: [Mips] Add intrinsics for 4-byte and 8-byte MSA loads/stores.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5ba931a84a34: [Mips] Add intrinsics for 4-byte and 8-byte MSA loads/stores. (authored by mbrkusanin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 5ba931a - [Mips] Add intrinsics for 4-byte and 8-byte MSA loads/stores.

Author: Mirko Brkusanin Date: 2020-02-11T11:47:30+01:00 New Revision: 5ba931a84a3466aebab5d6dde3525e7a27c40c28 URL: https://github.com/llvm/llvm-project/commit/5ba931a84a3466aebab5d6dde3525e7a27c40c28 DIFF:

[PATCH] D73687: [AArch64][SVE] Add SVE2 intrinsics for complex integer dot product

This revision was automatically updated to reflect the committed changes. Closed by commit rGe7755f9e4f48: [AArch64][SVE] Add SVE2 intrinsics for complex integer dot product (authored by kmclaughlin). Changed prior to commit: https://reviews.llvm.org/D73687?vs=241726=243781#toc Repository:

[PATCH] D70876: [clang-tidy] Add spuriously-wake-up-functions check

abelkocsis updated this revision to Diff 243779. abelkocsis added a comment. Checker update to analyse language, separated checks for C and C++. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70876/new/ https://reviews.llvm.org/D70876 Files:

[PATCH] D73644: [Mips] Add intrinsics for 4-byte and 8-byte MSA loads/stores.

mbrkusanin updated this revision to Diff 243775. mbrkusanin edited the summary of this revision. mbrkusanin added a comment. - Rebase - Rename **ldrq_w** to **ldr_w**; Rename **strq_w** to **str_w**. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73644/new/

[PATCH] D74384: Use std::foo_t rather than std::foo in LLVM.

bkramer accepted this revision. bkramer added a comment. Push and watch the bots Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74384/new/ https://reviews.llvm.org/D74384 ___ cfe-commits mailing list

[PATCH] D72872: [ObjC generics] Fix not inheriting type bounds in categories/extensions.

hans added a comment. I don't have the context here. Was I added as a subscriber because it's related to the clang 10 release? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72872/new/ https://reviews.llvm.org/D72872

[PATCH] D71110: [clangd] A tool to evaluate cross-file rename.

hokein updated this revision to Diff 243768. hokein marked 3 inline comments as done. hokein added a comment. - rebase to master - fix the breakage of the rename tool - add more symbol to the tests - some tweaks on the python script Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D71110: [clangd] A tool to evaluate cross-file rename.

hokein added a comment. sorry for the delay, I just saw the comment today. In D71110#1799960 , @kbobyrev wrote: > For some reason, running this patch on a recent version of the source tree > fails. The AST parsing fails with fatal diagnostics, but I

[PATCH] D74033: [clang-tidy] Fix PR#44620 'readability-redundant-string-cstr quick-fix causes invalid code'

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/RedundantStringCStrCheck.cpp:64 +// Trying to get CallExpr in which CxxConstructExpr is called +const clang::CallExpr * Missing a full stop at the end of the comment.

[PATCH] D73413: [clang-tidy] Add check to detect external definitions with no header declaration

tonyelewis added a comment. Thanks very much. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73413/new/ https://reviews.llvm.org/D73413 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D74129: Prefer __vector over vector keyword for altivec use

hans added a comment. In D74129#1861777 , @serge-sans-paille wrote: > @hans : clang 10.0.0rc1 doesn't build on ppc64le in Fedora without that > patch. Cherry-picked to 10.x as 699e2a6c5551eacf10be7e64f579120954f55b10

[PATCH] D70265: [clang-tidy] Add CppCoreGuidelines I.2 "Avoid non-const global variables" check

vingeldal added a comment. The pull request to C++ Core guidelines have been merged: https://github.com/isocpp/CppCoreGuidelines/pull/1553 Herb set me straight regarding the anonymous namespaces so I had to change that. While waiting for the pull request to be reviewed I looked at more

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

balazske updated this revision to Diff 243758. balazske marked 2 inline comments as done. balazske added a comment. Herald added a subscriber: martong. Improved tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72705/new/

[PATCH] D74214: [clang-tidy] Fix PR#34798 'readability-braces-around-statements breaks statements containing braces.'

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/BracesAroundStatementsCheck.cpp:30 Lexer::getRawToken(Beginning, Tok, SM, Context->getLangOpts()); - assert(!Invalid && "Expected a valid token."); + if (!Invalid) { +Kind =

[PATCH] D70265: [clang-tidy] Add CppCoreGuidelines I.2 "Avoid non-const global variables" check

vingeldal updated this revision to Diff 243757. vingeldal added a comment. Updating D70265 : [clang-tidy] Add CppCoreGuidelines I.2 "Avoid non-const global variables" check Created the requested pull request to C++ Core guidelines and since it is now merged

[clang] 2733ad2 - [clang-rename] Fix the failure rename test.

Author: Haojian Wu Date: 2020-02-11T10:07:00+01:00 New Revision: 2733ad2c244ab33553bbd1aaca4c76907fdd0760 URL: https://github.com/llvm/llvm-project/commit/2733ad2c244ab33553bbd1aaca4c76907fdd0760 DIFF: https://github.com/llvm/llvm-project/commit/2733ad2c244ab33553bbd1aaca4c76907fdd0760.diff

[PATCH] D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style)

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. This patch is nearly 2 years old, and there has been a lot of discussion and I can see you've put a lot of work into adding the tests which prove it works, from my perspective

[PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

aaron.ballman accepted this revision. aaron.ballman added reviewers: mclow.lists, EricWF. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but I think it would be helpful if someone from the libc++ side also double-checked the behavior of patch if possible.

[PATCH] D74216: [clang-rename] Fix the missing template constructors.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa7fd548a4f9e: [clang-rename] Fix the missing template constructors. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74216/new/

[PATCH] D74216: [clang-rename] Fix the missing template constructors.

hokein updated this revision to Diff 243753. hokein marked an inline comment as done. hokein added a comment. Fix the format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74216/new/ https://reviews.llvm.org/D74216 Files:

[clang-tools-extra] a7fd548 - [clang-rename] Fix the missing template constructors.

Author: Haojian Wu Date: 2020-02-11T09:41:39+01:00 New Revision: a7fd548a4f9e50e1aa2def57bae885604c9c5878 URL: https://github.com/llvm/llvm-project/commit/a7fd548a4f9e50e1aa2def57bae885604c9c5878 DIFF: https://github.com/llvm/llvm-project/commit/a7fd548a4f9e50e1aa2def57bae885604c9c5878.diff

<    1   2   3   >