JonChesterfield added a comment.
Patch looks good with the above nits.
I'm not totally sure about the callback vs running a separate IR pass after the
finalize() call, but when the callback is this simple it looks fine. I like
that this preserves the current semantics.
kbobyrev accepted this revision.
kbobyrev added a comment.
This revision is now accepted and ready to land.
Should be good to go, please run `git-clang-format` on the changes just to make
sure.
Thanks for fixing this!
Comment at:
Author: Haojian Wu
Date: 2020-02-11T09:27:00+01:00
New Revision: 487621237d2fe5a53ac40a29f6443d3e4f106c61
URL:
https://github.com/llvm/llvm-project/commit/487621237d2fe5a53ac40a29f6443d3e4f106c61
DIFF:
https://github.com/llvm/llvm-project/commit/487621237d2fe5a53ac40a29f6443d3e4f106c61.diff
hokein updated this revision to Diff 243752.
hokein marked 3 inline comments as done.
hokein added a comment.
address comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74216/new/
https://reviews.llvm.org/D74216
Files:
djtodoro added a comment.
@awpandey Thanks for doing this, but could you please explain the motivation of
implementing this? Can we use is (somehow) to generate more variables with the
`DW_AT_const_value`?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73261/new/
Fznamznon created this revision.
Herald added subscribers: cfe-commits, Anastasia, ebevhan.
Herald added a project: clang.
While SYCL does not support __float128 for some device targets, emitting the
diagnostic here prevents the compilation of host header files with
__float128 type usage.
For now
djtodoro added inline comments.
Comment at: llvm/include/llvm/IR/DebugInfoFlags.def:61
HANDLE_DI_FLAG((1 << 29), AllCallsDescribed)
+HANDLE_DI_FLAG((1 << 30), ConstExpr)
We are almost out of space here... I wouldn't add any additional flag here
before we do
201 - 207 of 207 matches
Mail list logo
