[PATCH] D74606: [clangd] Add add commit characters to the server capabilities

This revision was automatically updated to reflect the committed changes. Closed by commit rG2a095ff6f502: [clangd] Add add commit characters to the server capabilities (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74606/new/

[clang-tools-extra] 2a095ff - [clangd] Add add commit characters to the server capabilities

Author: Kirill Bobyrev Date: 2020-02-19T08:32:00+01:00 New Revision: 2a095ff6f5028b7612dae50358a2f6939b6cdc9f URL: https://github.com/llvm/llvm-project/commit/2a095ff6f5028b7612dae50358a2f6939b6cdc9f DIFF:

[PATCH] D74606: [clangd] Add add commit characters to the server capabilities

kbobyrev updated this revision to Diff 245331. kbobyrev added a comment. Add pipe and single quote to commit characters. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74606/new/ https://reviews.llvm.org/D74606 Files:

[PATCH] D74814: IR printing for single function with the new pass manager.

hoyFB created this revision. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. hoyFB added a reviewer: wenlei. hoyFB added a subscriber: wenlei. The IR printing always prints out all functions in a module with the new pass manager, even with

[PATCH] D74757: Fix compiler extension in standalone mode

serge-sans-paille updated this revision to Diff 245327. serge-sans-paille added a comment. Take @Meinersbur review into account. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74757/new/ https://reviews.llvm.org/D74757 Files:

[PATCH] D74813: [RFC] Add hash of block contents to function block names

alexbdv created this revision. alexbdv added reviewers: MaskRay, vsk, JonasToth, ruiu. Herald added a project: clang. Herald added a subscriber: cfe-commits. Function blocks don't have a name specified in source code. Currently their symbol name is based on the parent function's name and an

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

This revision was automatically updated to reflect the committed changes. Closed by commit rG048239e46e49: [Coroutines][6/6] Clang schedules new passes (authored by modocache). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71903/new/

[clang] 048239e - [Coroutines][6/6] Clang schedules new passes

Author: Brian Gesiak Date: 2020-02-19T01:03:28-05:00 New Revision: 048239e46e490d441f21f3e26073ec38f19e8a10 URL: https://github.com/llvm/llvm-project/commit/048239e46e490d441f21f3e26073ec38f19e8a10 DIFF: https://github.com/llvm/llvm-project/commit/048239e46e490d441f21f3e26073ec38f19e8a10.diff

[PATCH] D69868: Allow "callbr" to return non-void values

jdoerfert added a comment. In D69868#1881985 , @void wrote: > It's been almost a month since the last comments on this review. If you need > more time, please comment here. Otherwise, I will submit this with the > current approvals by the end of the

[PATCH] D69868: Allow "callbr" to return non-void values

void added a comment. It's been almost a month since the last comments on this review. If you need more time, please comment here. Otherwise, I will submit this with the current approvals by the end of the week. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72231: [Sema] Adds the pointer-to-int-cast diagnostic

nathanchance added a comment. In D72231#1881855 , @rjmccall wrote: > In D72231#1881797 , @nickdesaulniers > wrote: > > > In D72231#1881784 , @rjmccall > > wrote: > > > > >

[PATCH] D74812: [Sema] Teach -Warm-interrupt-safety about func ptrs

jroelofs marked an inline comment as done. jroelofs added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:5931 + if (Caller->hasAttr()) { +const Decl *CalleeDecl = FDecl; +if (const auto *UO = dyn_cast(Fn->IgnoreParens())) { This

[PATCH] D74812: [Sema] Teach -Warm-interrupt-safety about func ptrs

jroelofs created this revision. jroelofs added reviewers: efriedma, weimingz, EricWF. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. Fixes: https://bugs.llvm.org/show_bug.cgi?id=35527 https://bugs.llvm.org/show_bug.cgi?id=35528 Repository: rG LLVM

[PATCH] D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP

aganea added a comment. There seems to be still an issue with this patch, when linking the LLVM unit tests on a two-stage build, it ends with: FAILED: tools/clang/unittests/StaticAnalyzer/StaticAnalysisTests.exe cmd.exe /C "cd . && "C:\Program Files\CMake\bin\cmake.exe" -E vs_link_exe

[clang] 061f3a5 - P0593R6: Pseudo-destructor expressions end object lifetimes.

Author: Richard Smith Date: 2020-02-18T18:41:03-08:00 New Revision: 061f3a50dd824f1eb2394d0f699f3f2ee374b21a URL: https://github.com/llvm/llvm-project/commit/061f3a50dd824f1eb2394d0f699f3f2ee374b21a DIFF: https://github.com/llvm/llvm-project/commit/061f3a50dd824f1eb2394d0f699f3f2ee374b21a.diff

[PATCH] D74811: [Driver] Escape the program path for -frecord-command-line

ravi-ramaseshan created this revision. ravi-ramaseshan added reviewers: scott.linder, rjmccall. Herald added a project: clang. Similar to the rest of the command line that is recorded, the program path must also have spaces and backslashes escaped. Without this parsing the recorded command line

[clang-tools-extra] 28728bf - Fix a signed/unsigned warning promoted to error.

Author: Eric Christopher Date: 2020-02-18T17:49:22-08:00 New Revision: 28728bf06f556dc8be5bc1fa77129906ba68 URL: https://github.com/llvm/llvm-project/commit/28728bf06f556dc8be5bc1fa77129906ba68 DIFF:

[PATCH] D72231: [Sema] Adds the pointer-to-int-cast diagnostic

nickdesaulniers added a comment. In D72231#1881855 , @rjmccall wrote: > No, I understand the pattern, but they must have already done some sort of > pass over the code to make it warning-clean when they're working with a > smaller integer type. Or do

[clang] 492d4a9 - [NFC] Update the testcase clang_f_opts.c for the removed options

Author: Jim Lin Date: 2020-02-19T09:28:41+08:00 New Revision: 492d4a992d88516da471b60ecd9a37ea80dbf9a4 URL: https://github.com/llvm/llvm-project/commit/492d4a992d88516da471b60ecd9a37ea80dbf9a4 DIFF: https://github.com/llvm/llvm-project/commit/492d4a992d88516da471b60ecd9a37ea80dbf9a4.diff LOG:

[PATCH] D73649: [CodeComplete] Member completion for concept-constrained types.

sammccall marked 3 inline comments as done. sammccall added inline comments. Comment at: clang/lib/Sema/CodeCompleteConsumer.cpp:592 } +for (const FixItHint : Results[I].FixIts) { + const SourceLocation BLoc = FixIt.RemoveRange.getBegin(); (This

[PATCH] D72231: [Sema] Adds the pointer-to-int-cast diagnostic

rjmccall added a comment. In D72231#1881797 , @nickdesaulniers wrote: > In D72231#1881784 , @rjmccall wrote: > > > In D72231#1881760 , > > @nickdesaulniers wrote: > > > >

[PATCH] D74790: [Sema][CodeComplete] Handle symlinks for include code completion

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! I can't see this being a performance problem (famous last words...) Comment at: clang/lib/Sema/SemaCodeComplete.cpp:8780 + + // We need to manually

[PATCH] D74807: Add cl_khr_mipmap_image_writes as supported to AMDGPU

yaxunl created this revision. yaxunl added a reviewer: b-sumner. Herald added subscribers: kerbowa, t-tye, tpr, dstuttard, nhaehnle, wdng, jvesely, kzhuravl. https://reviews.llvm.org/D74807 Files: clang/lib/Basic/Targets/AMDGPU.h Index: clang/lib/Basic/Targets/AMDGPU.h

[PATCH] D72825: Remove unused option that gcc ignored

This revision was automatically updated to reflect the committed changes. Closed by commit rGea789f819f26: Remove unused option that gcc ignored (authored by Jim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72825/new/

[clang] ea789f8 - Remove unused option that gcc ignored

Author: Jim Lin Date: 2020-02-19T08:36:07+08:00 New Revision: ea789f819f26a1b003a1bf07466fc9fa2fe558ec URL: https://github.com/llvm/llvm-project/commit/ea789f819f26a1b003a1bf07466fc9fa2fe558ec DIFF: https://github.com/llvm/llvm-project/commit/ea789f819f26a1b003a1bf07466fc9fa2fe558ec.diff LOG:

[PATCH] D74806: [analyzer] NFCi: Refactor CStringChecker: use strongly typed internal API

steakhal created this revision. steakhal added reviewers: NoQ, baloghadamsoftware, Szelethus. steakhal added a project: clang. Herald added subscribers: cfe-commits, martong, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, whisperity. Herald added a

[PATCH] D74806: [analyzer] NFCi: Refactor CStringChecker: use strongly typed internal API

steakhal updated this revision to Diff 245300. steakhal added a comment. Upload the right diff. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74806/new/ https://reviews.llvm.org/D74806 Files: clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp

[PATCH] D74015: [AIX][Frontend] C++ ABI customizations for AIX boilerplate

Xiangling_L added a comment. In D74015#1880847 , @cebowleratibm wrote: > From my perspective, the only issue holding this up is settling on the name. > I'd like to hammer that out and get this committed. It looks everyone agrees on `XL` so far. As

[PATCH] D72231: [Sema] Adds the pointer-to-int-cast diagnostic

nickdesaulniers added a comment. In D72231#1881784 , @rjmccall wrote: > In D72231#1881760 , @nickdesaulniers > wrote: > > > In D72231#1879347 , @rjmccall > > wrote: > > >

[clang] 24ad121 - Add -std=c++20 flag, replace C++2a with C++20 throughout the Clang

Author: Richard Smith Date: 2020-02-18T16:16:37-08:00 New Revision: 24ad121582454e625bdad125c90d9ac0dae948c8 URL: https://github.com/llvm/llvm-project/commit/24ad121582454e625bdad125c90d9ac0dae948c8 DIFF: https://github.com/llvm/llvm-project/commit/24ad121582454e625bdad125c90d9ac0dae948c8.diff

[PATCH] D72231: [Sema] Adds the pointer-to-int-cast diagnostic

rjmccall added a comment. In D72231#1881760 , @nickdesaulniers wrote: > In D72231#1879347 , @rjmccall wrote: > > > In D72231#1878528 , @nathanchance > > wrote: > > > > >

[PATCH] D74801: [ADT][NFC] SCCIterator: Change hasLoop() to hasCycle()

baziotis updated this revision to Diff 245295. baziotis edited the summary of this revision. baziotis added a comment. Self-cycle to self-loop CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74801/new/ https://reviews.llvm.org/D74801 Files:

[PATCH] D72231: [Sema] Adds the pointer-to-int-cast diagnostic

nickdesaulniers added a comment. In D72231#1879347 , @rjmccall wrote: > In D72231#1878528 , @nathanchance > wrote: > > > There appear to a be semantic difference between GCC and clang with the > > current version

[PATCH] D74801: [ADT][NFC] SCCIterator: Change hasLoop() to hasCycle()

baziotis marked an inline comment as done. baziotis added inline comments. Comment at: llvm/tools/opt/PrintSCC.cpp:82-83 errs() << (*I)->getName() << ", "; -if (nextSCC.size() == 1 && SCCI.hasLoop()) - errs() << " (Has self-loop)."; +if (nextSCC.size() == 1

[PATCH] D74698: [Driver] -pg -mfentry should respect target specific decisions for -mframe-pointer=all

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b9cb1208124: [Driver] -pg -mfentry should respect target specific decisions for -mframe… (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74801: [ADT][NFC] SCCIterator: Change hasLoop() to hasCycle()

lebedev.ri added inline comments. Comment at: llvm/tools/opt/PrintSCC.cpp:82-83 errs() << (*I)->getName() << ", "; -if (nextSCC.size() == 1 && SCCI.hasLoop()) - errs() << " (Has self-loop)."; +if (nextSCC.size() == 1 && SCCI.hasCycle()) + errs() << "

[clang] 8b9cb12 - [Driver] -pg -mfentry should respect target specific decisions for -mframe-pointer=all

Author: Nick Desaulniers Date: 2020-02-18T15:33:46-08:00 New Revision: 8b9cb120812449dbe67d2252ebf619c4c9cac816 URL: https://github.com/llvm/llvm-project/commit/8b9cb120812449dbe67d2252ebf619c4c9cac816 DIFF:

[PATCH] D74801: [ADT][NFC] SCCIterator: Change hasLoop() to hasCycle()

baziotis marked an inline comment as done. baziotis added a comment. In D74801#1881693 , @lebedev.ri wrote: > While i certainly agree that it's kinda confusing, i'm not really sure this > is conceptually correct change. >

[PATCH] D74801: [ADT][NFC] SCCIterator: Change hasLoop() to hasCycle()

lebedev.ri added inline comments. Comment at: llvm/tools/opt/PrintSCC.cpp:82-83 errs() << (*I)->getName() << ", "; -if (nextSCC.size() == 1 && SCCI.hasLoop()) - errs() << " (Has self-loop)."; +if (nextSCC.size() == 1 && SCCI.hasCycle()) + errs() << "

[PATCH] D73649: [CodeComplete] Member completion for concept-constrained types.

nridge added a comment. Thanks for looking at this! Sorry for the late response, I was travelling for a few weeks. So far I've only had a chance to look at the tests. Comment at: clang/test/CodeCompletion/concepts.cpp:34 + // RUN: | FileCheck %s -check-prefix=DOT

[PATCH] D74801: [ADT][NFC] SCCIterator: Change hasLoop() to hasCycle()

baziotis added a subscriber: jdoerfert. baziotis added a comment. In D74801#1881679 , @efriedma wrote: > Seems fine. Great, thanks and to @jdoerfert! Any way I can find the correct reviewers next time? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D74801: [ADT][NFC] SCCIterator: Change hasLoop() to hasCycle()

lebedev.ri added a comment. While i certainly agree that it's kinda confusing, i'm not really sure this is conceptually correct change. https://en.wikipedia.org/wiki/Loop_(graph_theory) > In graph theory, a loop (also called a self-loop or a "buckle") is an edge > that connects a vertex to

[PATCH] D74801: [ADT][NFC] SCCIterator: Change hasLoop() to hasCycle()

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. Seems fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74801/new/ https://reviews.llvm.org/D74801

[PATCH] D74801: [ADT] SCCIterator: Change hasLoop() to hasCycle()

baziotis created this revision. baziotis added reviewers: dexonsmith, lattner, timshen, chandlerc. Herald added subscribers: llvm-commits, cfe-commits, arphaman, hiraditya. Herald added projects: clang, LLVM. Not a super important change but yesterday I had to look in this function and initially

[clang] e28d9ba - PR44958: Allow member calls and typeid / dynamic_cast on mutable objects

Author: Richard Smith Date: 2020-02-18T14:57:13-08:00 New Revision: e28d9bae4b3be60e90daa69a2eeb3254c952e051 URL: https://github.com/llvm/llvm-project/commit/e28d9bae4b3be60e90daa69a2eeb3254c952e051 DIFF: https://github.com/llvm/llvm-project/commit/e28d9bae4b3be60e90daa69a2eeb3254c952e051.diff

[PATCH] D72825: Remove unused option that gcc ignored

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72825/new/ https://reviews.llvm.org/D72825

[PATCH] D74724: [AArch64][SVE] CodeGen of ACLE Builtin Types

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74724/new/ https://reviews.llvm.org/D74724 ___ cfe-commits mailing list

[PATCH] D72231: [Sema] Adds the pointer-to-int-cast diagnostic

nathanchance added a comment. In D72231#1879347 , @rjmccall wrote: > Warning about casting to an enum seems clearly correct and in scope for this > warning. Warning about casting to `_Bool` seems clearly incorrect and should > not be warned about at

[PATCH] D74795: Make diagnostic reporting more robust in presence of corrupt PCH data.

dexonsmith added a comment. Thanks for working on this! I have a couple of comments inline. Comment at: clang/include/clang/Basic/Diagnostic.h:918-927 /// The ID of the current diagnostic that is in flight. /// /// This is set to std::numeric_limits::max() when there

[PATCH] D74769: [AArch64][SVE] Add SVE2 intrinsics for polynomial arithmetic

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74769/new/ https://reviews.llvm.org/D74769

[PATCH] D74698: [Driver] -pg -mfentry should respect target specific decisions for -mframe-pointer=all

nickdesaulniers added a comment. Ok, sorry for the excessive churn. I think this now accurately describes the logic of how this was expected to work, from the stance of GCC compatibility. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74698/new/

[PATCH] D74698: [Driver] -pg -mfentry should respect target specific decisions for -mframe-pointer=all

nickdesaulniers updated this revision to Diff 245279. nickdesaulniers added a comment. - respect target specific frame pointer optimizations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74698/new/ https://reviews.llvm.org/D74698 Files:

[PATCH] D74698: [Driver] -pg -mfentry should respect target specific decisions for -mframe-pointer=all

nickdesaulniers marked an inline comment as done. nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:592 + if (Args.hasArg(options::OPT_pg) && Args.hasArg(options::OPT_mfentry)) +return false; This hunk does nothing

[clang] cf45742 - [hexagon] Fix testcase issue with windows builder.

Author: Sid Manning Date: 2020-02-18T16:36:38-06:00 New Revision: cf4574299a279beeb8acb894583962ec0f41286c URL: https://github.com/llvm/llvm-project/commit/cf4574299a279beeb8acb894583962ec0f41286c DIFF: https://github.com/llvm/llvm-project/commit/cf4574299a279beeb8acb894583962ec0f41286c.diff

[PATCH] D74795: Make diagnostic reporting more robust in presence of corrupt PCH data.

neilmacintosh created this revision. neilmacintosh added reviewers: modocache, doug.gregor, hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, dexonsmith, ilya-biryukov. Herald added a project: clang. When running clangd, I found that occasionally, accessing a precompiled header

[PATCH] D74698: [Driver] -pg shouldn't unconditionally add -mframe-pointer=all w/ -mfentry

nickdesaulniers updated this revision to Diff 245274. nickdesaulniers added a comment. - drop implicit-check-nots, add check for no os target Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74698/new/ https://reviews.llvm.org/D74698 Files:

[PATCH] D74698: [Driver] -pg shouldn't unconditionally add -mframe-pointer=all w/ -mfentry

nickdesaulniers added inline comments. Comment at: clang/test/Driver/mfentry.c:6 +// RUN: %clang -target x86_64-linux-gnu -pg -mfentry -O2 -fno-omit-frame-pointer -### -E %s 2>&1 | FileCheck -check-prefix=FP --implicit-check-not='"-mframe-pointer=none"' %s +// RUN: %clang

[PATCH] D74698: [CodeGen] -pg shouldn't unconditionally add "frame-pointer"="all" fn attr w/ -mfentry

MaskRay added a comment. The title should be changed from CodeGen to Driver And `fn attr` is no longer appropriate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74698/new/ https://reviews.llvm.org/D74698

[PATCH] D70876: [clang-tidy] Add spuriously-wake-up-functions check

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, do you need me to commit on your behalf? Comment at: clang-tools-extra/test/clang-tidy/bugprone-spuriously-wake-up-functions.c:165 +int main() { return 0; } \ No newline at end of file

[PATCH] D74698: [CodeGen] -pg shouldn't unconditionally add "frame-pointer"="all" fn attr w/ -mfentry

nickdesaulniers updated this revision to Diff 245265. nickdesaulniers added a comment. - s/gnu-linux/linux-gnu/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74698/new/ https://reviews.llvm.org/D74698 Files:

[PATCH] D74698: [CodeGen] -pg shouldn't unconditionally add "frame-pointer"="all" fn attr w/ -mfentry

nickdesaulniers updated this revision to Diff 245263. nickdesaulniers added a comment. - use -### -E and check for -mframe-pointer={all|none} Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74698/new/ https://reviews.llvm.org/D74698 Files:

[PATCH] D74698: [CodeGen] -pg shouldn't unconditionally add "frame-pointer"="all" fn attr w/ -mfentry

nickdesaulniers updated this revision to Diff 245264. nickdesaulniers added a comment. - drop -o - Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74698/new/ https://reviews.llvm.org/D74698 Files: clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D74698: [CodeGen] -pg shouldn't unconditionally add "frame-pointer"="all" fn attr w/ -mfentry

nickdesaulniers updated this revision to Diff 245260. nickdesaulniers added a comment. - add explicit target and spacing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74698/new/ https://reviews.llvm.org/D74698 Files:

[PATCH] D74698: [CodeGen] -pg shouldn't unconditionally add "frame-pointer"="all" fn attr w/ -mfentry

MaskRay added inline comments. Comment at: clang/test/Driver/mfentry.c:5 +// RUN: %clang -pg -mfentry -O0 -emit-llvm -S -o - %s | FileCheck -check-prefix=FP --implicit-check-not='"frame-pointer"="none"' %s +// RUN: %clang -pg -mfentry -O2 -fno-omit-frame-pointer -emit-llvm -S

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

nickdesaulniers added a comment. As a heads up, Linaro's ToolChain Working Group's Linux kernel CI lit up on this change. I see it's been reverted (thank you). Please cc me on the updated patch and I can help test it against the Linux kernel. Edit: Link:

[PATCH] D74790: [Sema][CodeComplete] Handle symlinks for include code completion

dgoldman updated this revision to Diff 245256. dgoldman added a comment. - Add test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74790/new/ https://reviews.llvm.org/D74790 Files: clang/lib/Sema/SemaCodeComplete.cpp

[PATCH] D74698: [CodeGen] -pg shouldn't unconditionally add "frame-pointer"="all" fn attr w/ -mfentry

nickdesaulniers marked an inline comment as done. nickdesaulniers added inline comments. Comment at: clang/test/Driver/mfentry.c:5 +// RUN: %clang -pg -mfentry -O0 -emit-llvm -S -o - %s | FileCheck -check-prefix=FP --implicit-check-not='"frame-pointer"="none"' %s +// RUN:

[PATCH] D73916: [clang] Add `forceReload` clangd extension to 'textDocument/didChange'

nridge added a comment. Which client(s) use or plan to use this extension? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73916/new/ https://reviews.llvm.org/D73916 ___ cfe-commits mailing list

[PATCH] D74698: [CodeGen] -pg shouldn't unconditionally add "frame-pointer"="all" fn attr w/ -mfentry

MaskRay added inline comments. Comment at: clang/test/Driver/mfentry.c:5 +// RUN: %clang -pg -mfentry -O0 -emit-llvm -S -o - %s | FileCheck -check-prefix=FP --implicit-check-not='"frame-pointer"="none"' %s +// RUN: %clang -pg -mfentry -O2 -fno-omit-frame-pointer -emit-llvm -S

[PATCH] D74787: [IRBuilder] Always respect inserter/folder

nikic marked an inline comment as done. nikic added inline comments. Comment at: llvm/test/Transforms/InstCombine/saturating-add-sub.ll:2 ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py -; RUN: opt < %s -instcombine -S | FileCheck %s +; RUN: opt < %s

[PATCH] D74698: [CodeGen] -pg shouldn't unconditionally add "frame-pointer"="all" fn attr w/ -mfentry

nickdesaulniers updated this revision to Diff 245249. nickdesaulniers added a comment. - move test from clang/test/CodeGen/fentry to clang/test/Driver/mfentry Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74698/new/ https://reviews.llvm.org/D74698

[PATCH] D74790: [Sema][CodeComplete] Handle symlinks for include code completion

dgoldman created this revision. dgoldman added a reviewer: sammccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously any symlinks would be ignored since the directory traversal doesn't follow them. With this change we now follow symlinks (via a `stat` call in

[PATCH] D74698: [CodeGen] -pg shouldn't unconditionally add "frame-pointer"="all" fn attr w/ -mfentry

nickdesaulniers updated this revision to Diff 245245. nickdesaulniers added a comment. - add test for explicitly re-enabling -fno-omit-frame-pointer at -O2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74698/new/ https://reviews.llvm.org/D74698

[PATCH] D74698: [CodeGen] -pg shouldn't unconditionally add "frame-pointer"="all" fn attr w/ -mfentry

MaskRay added inline comments. Comment at: clang/test/CodeGen/fentry.c:6 +// RUN: %clang -pg -mfentry -O0 -emit-llvm -S -o - %s | FileCheck -check-prefix=FP --implicit-check-not='"frame-pointer"="none"' %s +// RUN: %clang -pg -mfentry -O2 -fno-omit-frame-pointer -emit-llvm -S

[PATCH] D74631: [clang][XCOFF] Indicate that XCOFF does not support COMDATs

This revision was automatically updated to reflect the committed changes. Closed by commit rG58817a0783ca: [clang][XCOFF] Indicate that XCOFF does not support COMDATs (authored by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74631/new/

[PATCH] D74698: [CodeGen] -pg shouldn't add "frame-pointer"="all" fn attr w/ -mfentry

nickdesaulniers updated this revision to Diff 245241. nickdesaulniers added a comment. - prefer implicit-check-not, add test for -O2 vs -O0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74698/new/ https://reviews.llvm.org/D74698 Files:

[PATCH] D74634: Remove "ELF Only" restriction from section flags

This revision was automatically updated to reflect the committed changes. Closed by commit rGa0a1f412fd1d: Remove ELF Only from -f*-sections help text (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74634/new/

[clang] 58817a0 - [clang][XCOFF] Indicate that XCOFF does not support COMDATs

Author: David Tenty Date: 2020-02-18T16:10:11-05:00 New Revision: 58817a0783ca405cd36a312c7ee80e061d1cecc5 URL: https://github.com/llvm/llvm-project/commit/58817a0783ca405cd36a312c7ee80e061d1cecc5 DIFF: https://github.com/llvm/llvm-project/commit/58817a0783ca405cd36a312c7ee80e061d1cecc5.diff

[clang] a0a1f41 - Remove "ELF Only" from -f*-sections help text

Author: Reid Kleckner Date: 2020-02-18T12:59:50-08:00 New Revision: a0a1f412fd1d86146c5b4ef5b7b66fcc57a8b56b URL: https://github.com/llvm/llvm-project/commit/a0a1f412fd1d86146c5b4ef5b7b66fcc57a8b56b DIFF: https://github.com/llvm/llvm-project/commit/a0a1f412fd1d86146c5b4ef5b7b66fcc57a8b56b.diff

[PATCH] D74689: [clang-tidy] Better custom class support for performance-inefficient-vector-operation

njames93 updated this revision to Diff 245240. njames93 added a comment. - Better template support - Removed excess code - Refactor alot of the check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74689/new/ https://reviews.llvm.org/D74689 Files:

[PATCH] D72231: [Sema] Adds the pointer-to-int-cast diagnostic

Mordante added a comment. In D72231#1879347 , @rjmccall wrote: > In D72231#1878528 , @nathanchance > wrote: > > > There appear to a be semantic difference between GCC and clang with the > > current version of

[PATCH] D74784: [driver][darwin] Don't use -platform_version flag by default

dexonsmith added a comment. Code change looks correct to me. Thanks for the fix! @arphaman, can you confirm the test changes are reasonable? My instinct would have been, instead of changing all of the 400s to 0s, to just adding a single `RUN` line somewhere to confirm we don't do the wrong

[PATCH] D74787: [IRBuilder] Always respect inserter/folder

Meinersbur added a comment. Nice work Comment at: llvm/test/Transforms/InstCombine/saturating-add-sub.ll:2 ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py -; RUN: opt < %s -instcombine -S | FileCheck %s +; RUN: opt < %s -instcombine

[PATCH] D74033: [clang-tidy] Fix PR#44620 'readability-redundant-string-cstr quick-fix causes invalid code'

aaron.ballman closed this revision. aaron.ballman added a comment. I've commit on your behalf in 47282b1b4bf3e18d2e2166b87159115ed520a2aa , thank you for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D73138: [libcxx] [test] Correct asserted type in subspan test; subspan with count should never produce dynamic_extent

BillyONeal added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73138/new/ https://reviews.llvm.org/D73138 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] 47282b1 - Fix PR#44620 'readability-redundant-string-cstr quick-fix causes invalid code'

Author: Karasev Nikita Date: 2020-02-18T15:33:52-05:00 New Revision: 47282b1b4bf3e18d2e2166b87159115ed520a2aa URL: https://github.com/llvm/llvm-project/commit/47282b1b4bf3e18d2e2166b87159115ed520a2aa DIFF:

[PATCH] D74776: [Hexagon] clang driver should consider --sysroot option when looking for includes

This revision was automatically updated to reflect the committed changes. Closed by commit rGfaa889b23587: [Hexagon] clang driver should consider --sysroot option (authored by sidneym). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74776/new/

[clang] faa889b - [Hexagon] clang driver should consider --sysroot option

Author: Sid Manning Date: 2020-02-18T14:25:55-06:00 New Revision: faa889b2358704c57febf2ad75ad88eec5debf31 URL: https://github.com/llvm/llvm-project/commit/faa889b2358704c57febf2ad75ad88eec5debf31 DIFF: https://github.com/llvm/llvm-project/commit/faa889b2358704c57febf2ad75ad88eec5debf31.diff

[PATCH] D74631: [clang][XCOFF] Indicate that XCOFF does not support COMDATs

sfertile accepted this revision. sfertile added a comment. This revision is now accepted and ready to land. LGTM. Comment at: llvm/docs/LangRef.rst:913 -Note that the Mach-O platform doesn't support COMDATs, and ELF and WebAssembly -only support ``any`` as a selection kind.

[PATCH] D74787: [IRBuilder] Always respect inserter/folder

nikic created this revision. nikic added reviewers: nhaehnle, Meinersbur, spatel, lebedev.ri. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added a reviewer: jdoerfert. Herald added projects: clang, LLVM. Some IRBuilder methods that were originally defined on

[PATCH] D73138: [libcxx] [test] Correct asserted type in subspan test; subspan with count should never produce dynamic_extent

This revision was automatically updated to reflect the committed changes. Closed by commit rGa7dcbe90cc2d: [libc++] Fix overly complicated test of std::spans extent (authored by ldionne). Herald added a project: libc++. Herald added a subscriber: libcxx-commits. Changed prior to commit:

[PATCH] D74529: [clang-tidy] Added a case to UnconventionalAssignOperatorCheck.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74529/new/ https://reviews.llvm.org/D74529

[PATCH] D73138: [libcxx] [test] Correct asserted type in subspan test; subspan with count should never produce dynamic_extent

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. In D73138#1881198 , @BillyONeal wrote: > @ldionne I think you're correct, though the test there is more complex than > it needs to be (because the

[PATCH] D74033: [clang-tidy] Fix PR#44620 'readability-redundant-string-cstr quick-fix causes invalid code'

f00kat added a comment. Yes, commit please. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74033/new/ https://reviews.llvm.org/D74033 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D74704: Support -fuse-ld=lld for riscv

MaskRay added a comment. The problem may be `-DCLANG_DEFAULT_LINKER=lld`. (FWIW I really don't like supporting numerous -D configurations and ask authors to revert because of some weird -D configurations.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74784: [driver][darwin] Don't use -platform_version flag by default

dmajor created this revision. dmajor added reviewers: arphaman, steven_wu, dexonsmith. dmajor added projects: clang, LLVM. Herald added a subscriber: cfe-commits. (Note, I don't currently have commit access.) The code in llvmorg-10-init-12188-g25ce33a6e4f is a breaking change for users of older

[PATCH] D73138: [libcxx] [test] Correct asserted type in subspan test; subspan with count should never produce dynamic_extent

BillyONeal added a comment. @ldionne I think you're correct, though the test there is more complex than it needs to be (because the ==Count cases are the only ever encountered here). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73138/new/ https://reviews.llvm.org/D73138

[PATCH] D74704: Support -fuse-ld=lld for riscv

serge-sans-paille added a comment. Reverted through b8bea9346af4f2644c9a1bd29710c5e3efbbd7d3 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74704/new/

[PATCH] D74704: Support -fuse-ld=lld for riscv

serge-sans-paille added a comment. I'll revert and propose an updated patch then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74704/new/ https://reviews.llvm.org/D74704 ___ cfe-commits mailing list

[libunwind] 1ae8d81 - [libunwind] Fix memory leak in handling of DW_CFA_remember_state and DW_CFA_restore_state

Author: Jorge Gorbe Moya Date: 2020-02-18T11:57:18-08:00 New Revision: 1ae8d81147a0724cc972054afbd72943032e4832 URL: https://github.com/llvm/llvm-project/commit/1ae8d81147a0724cc972054afbd72943032e4832 DIFF:

  1   2   3   >