[PATCH] D74572: [BPF] preserve debuginfo types for builtin __builtin__btf_type_id()

yonghong-song updated this revision to Diff 245582. yonghong-song added a comment. fix a typo (BPFPreserveType.cpp => BPFPreserveDIType.cpp) in the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74572/new/ https://reviews.llvm.org/D74572

[PATCH] D69868: Allow "callbr" to return non-void values

lattner accepted this revision. lattner added a comment. I'm super excited to see this progress towards supporting 'asm goto' with results! Great work! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69868/new/ https://reviews.llvm.org/D69868

[PATCH] D74757: Fix compiler extension in standalone mode

This revision was automatically updated to reflect the committed changes. Closed by commit rG3a0f6e699bb6: Fix compiler extension in standalone mode (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74757/new/

[clang] 3a0f6e6 - Fix compiler extension in standalone mode

Author: serge-sans-paille Date: 2020-02-20T07:19:04+01:00 New Revision: 3a0f6e699bb6d96dc62dce6faef20ac26cf103fd URL: https://github.com/llvm/llvm-project/commit/3a0f6e699bb6d96dc62dce6faef20ac26cf103fd DIFF:

[PATCH] D74871: Fix interaction between -fdiscard-value-names and LLVM Bitcode

serge-sans-paille added a comment. In D74871#1883884 , @EricWF wrote: > Why is this not a bug in w/e is handling the IR? It may totally be. Consider this review as a way to start the discussion. The problem, as it appears, is triggered when some value

[PATCH] D74871: Fix interaction between -fdiscard-value-names and LLVM Bitcode

serge-sans-paille updated this revision to Diff 245578. serge-sans-paille added a comment. Added test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74871/new/ https://reviews.llvm.org/D74871 Files:

[PATCH] D74572: [BPF] preserve debuginfo types for builtin __builtin__btf_type_id()

ast accepted this revision. ast added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Target/BPF/BPFPreserveDIType.cpp:1 +//===- BPFPreserveType.cpp - Preserve DebugInfo Types -===// +// ast wrote: >

[PATCH] D74811: [Driver] Escape the program path for -frecord-command-line

ravi-ramaseshan added a comment. Can you please land this change for me since I do not have commit rights. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74811/new/ https://reviews.llvm.org/D74811

[PATCH] D74572: [BPF] preserve debuginfo types for builtin __builtin__btf_type_id()

yonghong-song updated this revision to Diff 245574. yonghong-song added a comment. change llvm.bpf_pdit to llvm.btf_type_id variable name to make it easy to understand. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74572/new/

[PATCH] D74572: [BPF] preserve debuginfo types for builtin __builtin__btf_type_id()

yonghong-song marked an inline comment as done. yonghong-song added inline comments. Comment at: llvm/lib/Target/BPF/BPFPreserveDIType.cpp:95 + + std::string BaseName = "llvm.bpf_pdit."; + int Count = 0; ast wrote: > may be "llvm.btf_type_id." instead? > Oh,

[PATCH] D74692: [clang-tidy] Make bugprone-use-after-move ignore std::move for const values

Quuxplusone added a comment. (I sent this to the mailing list, but I guess it doesn't show up here unless I do it through Phab. Quoting myself—) I see your point about how users who care should always be passing this check alongside "performance-move-const-arg"; but IMHO it still makes sense

[PATCH] D69471: [Coverage] Revise format to reduce binary size

dexonsmith added a comment. In D69471#1883912 , @rnk wrote: > Everything is off-by-one because the empty bases are not zero sized. The MSVC > record layout algorithm is just different in this area. =/ Do all the MSVCs we support building with support

[PATCH] D73580: [clang-tidy] rename_check.py: maintain alphabetical order in Renamed checks section

Eugene.Zelenko added a comment. In D73580#1883861 , @njames93 wrote: > LGTM, For what this is trying to achieve I have no issue, follow up patches > can be submitted for the other enhancements needed. Please commit patch if you'll have time. See

[clang] 490a9a4 - [examples] Fix the clang-interpreter example for changes in 85fb997659b.

Author: Lang Hames Date: 2020-02-19T19:01:32-08:00 New Revision: 490a9a4b77ea23f388cae67d732af6bd8aa576f9 URL: https://github.com/llvm/llvm-project/commit/490a9a4b77ea23f388cae67d732af6bd8aa576f9 DIFF: https://github.com/llvm/llvm-project/commit/490a9a4b77ea23f388cae67d732af6bd8aa576f9.diff

[clang-tools-extra] 6730f39 - Fixup test after changes made in 709fd989.

Author: Douglas Yung Date: 2020-02-19T18:39:54-08:00 New Revision: 6730f390a1fb069e567ebd635390de381d21b994 URL: https://github.com/llvm/llvm-project/commit/6730f390a1fb069e567ebd635390de381d21b994 DIFF: https://github.com/llvm/llvm-project/commit/6730f390a1fb069e567ebd635390de381d21b994.diff

[PATCH] D69471: [Coverage] Revise format to reduce binary size

rnk added a comment. Compiling with -fdump-record-layouts revealed the problem: *** Dumping AST Record Layout 0 | struct llvm::coverage::CovMapFunctionRecordV3 0 | struct llvm::coverage::accessors::FuncHashAndDataSize (base) (empty) 1 | struct

[PATCH] D74669: [clang-tidy] New check: misc-no-include-cpp

njames93 added a comment. I'd suggest possibly adding 2 Options at Global Level SourceFileExtensions and HeaderFileExtensions, both would take semicolon seperated lists. Reason they are Global is there are probably other checks that could use them. The SourceFileExtensions could be defaulted to

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

rjmccall added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1514 + void visitUsedDecl(SourceLocation Loc, Decl *D) { +if (auto *TD = dyn_cast(D)) { + for (auto *DD : TD->decls()) { yaxunl wrote: > rjmccall wrote: > > erichkeane wrote: > > >

[PATCH] D74572: [BPF] preserve debuginfo types for builtin __builtin__btf_type_id()

ast added inline comments. Comment at: llvm/lib/Target/BPF/BPFPreserveDIType.cpp:1 +//===- BPFPreserveType.cpp - Preserve DebugInfo Types -===// +// BPFPreserveDIType.cpp Comment at:

[PATCH] D74668: [Clang][BPF] implement __builtin_btf_type_id() builtin function

ast accepted this revision. ast added a comment. This revision is now accepted and ready to land. lgtm. Thanks for explaining lvalue/value trick. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74668/new/ https://reviews.llvm.org/D74668

[PATCH] D74452: [MS] Mark vectorcall FP and vector args inreg

This revision was automatically updated to reflect the committed changes. Closed by commit rG0edb2129258c: [MS] Mark vectorcall FP and vector args inreg (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74452/new/

[PATCH] D74878: [remark][diagnostics] [codegen] Fix PR44896

xur created this revision. xur added reviewers: tejohnson, jeroen.dobbelaere. This patch fixes PR44896. For IR input files, option fdiscard-value-names should be ignored as we need named values in loadModule(). Commit 60d3947922

[PATCH] D73580: [clang-tidy] rename_check.py: maintain alphabetical order in Renamed checks section

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. LGTM, For what this is trying to achieve I have no issue, follow up patches can be submitted for the other enhancements needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D74871: Fix interaction between -fdiscard-value-names and LLVM Bitcode

EricWF added a comment. This seems wrong to me. Discarding value names is the default and has been forever in non-assert builds. Why is this not a bug in w/e is handling the IR? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74871/new/

[PATCH] D73245: Depend stddef.h to provide max_align_t for C++11 and provide better fallback in

EricWF added inline comments. Comment at: libcxx/include/new:229-237 +#if !defined(_LIBCPP_CXX03_LANG) +using __libcpp_max_align_t = max_align_t; +#else +union __libcpp_max_align_t { + void * __f1; + long long int __f2; + long double __f3; rsmith wrote: > Is

[PATCH] D74871: Fix interaction between -fdiscard-value-names and LLVM Bitcode

mehdi_amini added a comment. You mention a test case in the description but I don't see it? Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3607 +// Cannot discard value names when processing llvm-ir, because IR loading +// is conservative wrt. names. +if

[PATCH] D74564: libclang: Add static build support for Windows

thakis added inline comments. Comment at: clang/tools/libclang/CMakeLists.txt:117 if(ENABLE_SHARED) + target_compile_definitions(libclang PUBLIC CINDEX_EXPORTS) if(WIN32) Is this enough? Every target that depends on libclang now needs to define

[PATCH] D69868: Allow "callbr" to return non-void values

void added a comment. Would you be okay with me submitting this and working on making INLINEASM_BR a non-terminator? I'd like to give this feature some bake time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69868/new/

[PATCH] D74813: [RFC] Add hash of block contents to function block names

alexbdv added a comment. @vsk - about breaking existing workflows - I was referring only to if / when this gets shipped out as the default - all the names for the function blocks will change and this might cause issue with tooling that relies on symbol names being consistent across builds.

[clang] 0edb212 - [MS] Mark vectorcall FP and vector args inreg

Author: Reid Kleckner Date: 2020-02-19T16:37:50-08:00 New Revision: 0edb2129258c727e9efe6fa234b28880ff64c1b9 URL: https://github.com/llvm/llvm-project/commit/0edb2129258c727e9efe6fa234b28880ff64c1b9 DIFF: https://github.com/llvm/llvm-project/commit/0edb2129258c727e9efe6fa234b28880ff64c1b9.diff

[PATCH] D74795: Make diagnostic reporting more robust in presence of corrupt PCH data.

bruno added a comment. Thanks for working on this. > I'm not sure how (or if it's possible) to add a test that would demonstrate > the before/after here. Happy to take advice! Yea, those are some times hard. Did you try to write a unittest that hits the assertion and trigger this case?

[clang-tools-extra] d1d5180 - [NFC] Fix issues with clang-tidy checks list.rst

Author: Nathan James Date: 2020-02-19T23:19:09Z New Revision: d1d5180e6904b3fa86f750a05a6721163e115f4d URL: https://github.com/llvm/llvm-project/commit/d1d5180e6904b3fa86f750a05a6721163e115f4d DIFF: https://github.com/llvm/llvm-project/commit/d1d5180e6904b3fa86f750a05a6721163e115f4d.diff LOG:

[PATCH] D74800: [clang-tidy] fix readability-redundant-member-init auto-fix of Function-try-block

This revision was automatically updated to reflect the committed changes. Closed by commit rG709fd989b644: [clang-tidy] fix readability-redundant-member-init auto-fix of Function-try… (authored by AlexanderLanin, committed by njames93). Herald added a project: clang. Herald added a subscriber:

[clang] 709fd98 - [clang-tidy] fix readability-redundant-member-init auto-fix of Function-try-block

Author: Alexander Lanin Date: 2020-02-19T23:04:05Z New Revision: 709fd989b644a80527e0f4a22503d54255bc095c URL: https://github.com/llvm/llvm-project/commit/709fd989b644a80527e0f4a22503d54255bc095c DIFF: https://github.com/llvm/llvm-project/commit/709fd989b644a80527e0f4a22503d54255bc095c.diff

[PATCH] D69868: Allow "callbr" to return non-void values

void added a comment. In D69868#1883687 , @jyknight wrote: > Ugh, it's actually been that long, hasn't it...I'm really sorry about that. :( No worries. Thanks for getting back to us! > I've been actively spending time to look at this over the last

[PATCH] D74807: Add cl_khr_mipmap_image_writes as supported to AMDGPU

This revision was automatically updated to reflect the committed changes. Closed by commit rGed07c89fc50f: Add cl_khr_mipmap_image_writes as supported to AMDGPU (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73245: Depend stddef.h to provide max_align_t for C++11 and provide better fallback in

joerg added a comment. It is used both in `` and `` and the use in the latter is currently unconditional AFAICT. I don't have a problem splitting the conditional to avoid the typedef. That would address the ODR concern? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73245/new/

[clang] ed07c89 - Add cl_khr_mipmap_image_writes as supported to AMDGPU

Author: Yaxun (Sam) Liu Date: 2020-02-19T17:40:40-05:00 New Revision: ed07c89fc50f38c4f1403b19897468edd7e5cbf3 URL: https://github.com/llvm/llvm-project/commit/ed07c89fc50f38c4f1403b19897468edd7e5cbf3 DIFF:

[PATCH] D69868: Allow "callbr" to return non-void values

jyknight added a comment. Ugh, it's actually been that long, hasn't it...I'm really sorry about that. :( I've been actively spending time to look at this over the last couple weeks. I haven't been able to convince myself that the weird-successors and having allocatable registers across BBs

[PATCH] D74811: [Driver] Escape the program path for -frecord-command-line

scott.linder accepted this revision. scott.linder added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74811/new/ https://reviews.llvm.org/D74811

[clang] 4960eb4 - Another fix for 7d91633a2b9b1f563dc14c632cc0c461c3651f76

Author: David Goldman Date: 2020-02-19T17:15:11-05:00 New Revision: 4960eb4a1bdd6f469d5ad6d5049609cf97a982f3 URL: https://github.com/llvm/llvm-project/commit/4960eb4a1bdd6f469d5ad6d5049609cf97a982f3 DIFF: https://github.com/llvm/llvm-project/commit/4960eb4a1bdd6f469d5ad6d5049609cf97a982f3.diff

[PATCH] D74564: libclang: Add static build support for Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG7ff1f55a1219: libclang: Add static build support for Windows (authored by cristian.adam, committed by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1514 + void visitUsedDecl(SourceLocation Loc, Decl *D) { +if (auto *TD = dyn_cast(D)) { + for (auto *DD : TD->decls()) { rjmccall wrote: >

[clang] 7ff1f55 - libclang: Add static build support for Windows

Author: Cristian Adam Date: 2020-02-20T00:05:46+02:00 New Revision: 7ff1f55a1219719f57a6f7905c26ce41d1767e4c URL: https://github.com/llvm/llvm-project/commit/7ff1f55a1219719f57a6f7905c26ce41d1767e4c DIFF: https://github.com/llvm/llvm-project/commit/7ff1f55a1219719f57a6f7905c26ce41d1767e4c.diff

[PATCH] D74790: [Sema][CodeComplete] Handle symlinks for include code completion

dgoldman added a comment. Submitted https://github.com/llvm/llvm-project/commit/7d91633a2b9b1f563dc14c632cc0c461c3651f76 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74790/new/ https://reviews.llvm.org/D74790

[PATCH] D73245: Depend stddef.h to provide max_align_t for C++11 and provide better fallback in

rsmith added a comment. On the assumption that we will never get a `::max_align_t` in C++98 mode anyway (which will be the case if the `` is conforming), this looks like the best we can do to me. Comment at: libcxx/include/new:229-237 +#if !defined(_LIBCPP_CXX03_LANG) +using

[PATCH] D74813: [RFC] Add hash of block contents to function block names

dexonsmith added a comment. Thanks for working on this, I agree it's a really important problem. I'm as optimistic as Vedant that this is the right approach though. - On compile time, I do think there's reason to be concerned, since dumping IR was fairly expensive last I checked due to

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

yaxunl added a comment. In D70172#1883567 , @ABataev wrote: > Seems to me, it causes some other issues. See > https://bugs.llvm.org/show_bug.cgi?id=44948 for example I will fix that bug. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 7d91633 - Fix broken test on Windows caused by D74790

Author: David Goldman Date: 2020-02-19T16:58:22-05:00 New Revision: 7d91633a2b9b1f563dc14c632cc0c461c3651f76 URL: https://github.com/llvm/llvm-project/commit/7d91633a2b9b1f563dc14c632cc0c461c3651f76 DIFF: https://github.com/llvm/llvm-project/commit/7d91633a2b9b1f563dc14c632cc0c461c3651f76.diff

[PATCH] D74871: Fix interaction between -fdiscard-value-names and LLVM Bitcode

serge-sans-paille created this revision. serge-sans-paille added reviewers: EricWF, mehdi_amini. Herald added a project: clang. Herald added a subscriber: cfe-commits. Without that patch, the test case associated to this patch segfaults in Release mode. This also makes the llvm-test-suite build

[PATCH] D74813: [RFC] Add hash of block contents to function block names

vsk added a comment. In D74813#1883241 , @alexbdv wrote: > As for making it default - would rather have this under a flag as hashing the > block contents does have some overhead and I imagine this feature wouldn't be > beneficial in most scenarios.

[PATCH] D74790: [Sema][CodeComplete] Handle symlinks for include code completion

dgoldman added a comment. In D74790#1883466 , @dyung wrote: > `The test you added in this change seems to be failing on Windows, can you > take a look? > > http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/14409 > > FAIL: Clang ::

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

ABataev added a comment. Seems to me, it causes some other issues. See https://bugs.llvm.org/show_bug.cgi?id=44948 for example Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70172/new/ https://reviews.llvm.org/D70172

[PATCH] D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. LGTM with outstanding inline comments addressed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73462/new/ https://reviews.llvm.org/D73462

[PATCH] D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates

aprantl added inline comments. Comment at: llvm/include/llvm/IR/DebugInfoMetadata.h:2187 + DEFINE_MDNODE_GET(DITemplateTypeParameter, +(MDString * Name, Metadata *Type, bool IsDefault), +(Name, Type, IsDefault))

[PATCH] D74860: [Sema] Fix pointer-to-int-cast diagnostic for _Bool

nickdesaulniers added a comment. Also, make sure to run `git-clang-format HEAD~` on the patch, as the linter suggests. Thanks for the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74860/new/ https://reviews.llvm.org/D74860

[PATCH] D73245: Depend stddef.h to provide max_align_t for C++11 and provide better fallback in

joerg added a comment. Ping2? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73245/new/ https://reviews.llvm.org/D73245 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D74790: [Sema][CodeComplete] Handle symlinks for include code completion

dyung added a comment. The test you added in this change seems to be failing on Windows, can you take a look? http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/14409 FAIL: Clang :: CodeCompletion/included-symlinks.cpp (1779 of 16867) - TEST 'Clang ::

[PATCH] D74860: [Sema] Fix pointer-to-int-cast diagnostic for _Bool

rjmccall added a comment. Can we test the same thing in C++? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74860/new/ https://reviews.llvm.org/D74860 ___ cfe-commits mailing list

[PATCH] D74860: [Sema] Fix pointer-to-int-cast diagnostic for _Bool

Mordante created this revision. Mordante added reviewers: dblaikie, rjmccall, rsmith, nathanchance, nickdesaulniers. Mordante added a project: clang. The diagnostic added in D72231 also shows a diagnostic when casting to a _Bool. This is unwanted. This patch

[PATCH] D74455: [MS] Pass aligned, non-trivially copyable things indirectly on x86

rnk updated this revision to Diff 245491. rnk added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74455/new/ https://reviews.llvm.org/D74455 Files: clang/lib/CodeGen/MicrosoftCXXABI.cpp

[PATCH] D74452: [MS] Mark vectorcall FP and vector args inreg

rnk updated this revision to Diff 245490. rnk added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74452/new/ https://reviews.llvm.org/D74452 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/vectorcall.c

[PATCH] D74116: [Sema][C++] Propagate conversion type in order to specialize the diagnostics

rjmccall added a comment. Yeah, looks like returning true causes the variable to be marked as invalid (not unreasonable, since maybe its type is wrong), which causes downstream diagnostics to be suppressed. Both test cases should probably be fixed to assign into a different variable so that

[PATCH] D74452: [MS] Mark vectorcall FP and vector args inreg

rnk added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74452/new/ https://reviews.llvm.org/D74452 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D73996: [Sema] Demote call-site-based 'alignment is a power of two' check for AllocAlignAttr into a warning

lebedev.ri added a comment. In D73996#1883360 , @erichkeane wrote: > 1 nit, otherwise LGTM. Thank you for the review! Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2996 +def warn_alignment_not_power_of_two : Warning< +

[PATCH] D73996: [Sema] Demote call-site-based 'alignment is a power of two' check for AllocAlignAttr into a warning

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. 1 nit, otherwise LGTM. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2996 +def warn_alignment_not_power_of_two : Warning< + "requested alignment is

[PATCH] D74562: [OpenMP][OMPIRBuilder] Introducing the `OMPBuilderCBHelpers` helper class

This revision was automatically updated to reflect the committed changes. Closed by commit rGba3f863dfb9c: [OpenMP][OMPIRBuilder] Introducing the `OMPBuilderCBHelpers` helper class (authored by fghanim, committed by jdoerfert). Changed prior to commit:

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

rjmccall added inline comments. Comment at: clang/include/clang/Sema/Sema.h:11442 + ContextDecl = getCUDACurrentNonLocalVariable(); +return ContextDecl; + } This is tricky because we could be in a nested context, not just the initializer, and that

[PATCH] D74116: [Sema][C++] Propagate conversion type in order to specialize the diagnostics

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:14829 +if (getLangOpts().CPlusPlus) + isInvalid = true; break; rjmccall wrote: > Could you hoist this up to the place where we pick

[clang] ba3f863 - [OpenMP][OMPIRBuilder] Introducing the `OMPBuilderCBHelpers` helper class

Author: Fady Ghanim Date: 2020-02-19T14:11:17-06:00 New Revision: ba3f863dfb9c5f9bf5e6fdca2198b609df3b7761 URL: https://github.com/llvm/llvm-project/commit/ba3f863dfb9c5f9bf5e6fdca2198b609df3b7761 DIFF: https://github.com/llvm/llvm-project/commit/ba3f863dfb9c5f9bf5e6fdca2198b609df3b7761.diff

[PATCH] D73186: [AST] Add fixed-point multiplication constant evaluation.

rjmccall added inline comments. Comment at: clang/lib/Basic/FixedPoint.cpp:242 + } else +Overflowed = Result < Min || Result > Max; + leonardchan wrote: > ebevhan wrote: > > rjmccall wrote: > > > ebevhan wrote: > > > > rjmccall wrote: > > > > > leonardchan

[clang] f6875c4 - Reapply [IRBuilder] Always respect inserter/folder

Author: Nikita Popov Date: 2020-02-19T20:51:38+01:00 New Revision: f6875c434ec20eb4f24495317592f64334347784 URL: https://github.com/llvm/llvm-project/commit/f6875c434ec20eb4f24495317592f64334347784 DIFF: https://github.com/llvm/llvm-project/commit/f6875c434ec20eb4f24495317592f64334347784.diff

[PATCH] D72231: [Sema] Adds the pointer-to-int-cast diagnostic

Mordante added a comment. In D72231#1882658 , @rjmccall wrote: > Okay. Can we raise this with the kernel folks instead of just assuming > they'll be opposed? An obvious patch to fix a few dozen places where they're > hit by a warning they

[PATCH] D73186: [AST] Add fixed-point multiplication constant evaluation.

leonardchan added inline comments. Comment at: clang/lib/Basic/FixedPoint.cpp:242 + } else +Overflowed = Result < Min || Result > Max; + ebevhan wrote: > rjmccall wrote: > > ebevhan wrote: > > > rjmccall wrote: > > > > leonardchan wrote: > > > > > ebevhan

[PATCH] D74814: IR printing for single function with the new pass manager.

hoyFB updated this revision to Diff 245484. hoyFB added a comment. Updating D74814 : IR printing for single function with the new pass manager. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74814/new/

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. In D73534#1883022 , @nickdesaulniers wrote: > In D73534#1882136 , @djtodoro wrote: > > > - Address the issue with ARM `describeLoadedValue()` (thanks to @vsk, I've > > reduced the test

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

nickdesaulniers added a comment. In D73534#1883048 , @djtodoro wrote: > I’ve already pushed this. Please rebase on the latest commits. Ah faff707db82d7db12fcd9f7826b8741261230e63 .

[PATCH] D74813: [RFC] Add hash of block contents to function block names

alexbdv added a subscriber: vsk. alexbdv added a comment. @vsk - sure will add tests when removing from RFC. As for making it default - would rather have this under a flag as hashing the block contents does have some overhead and I imagine this feature wouldn't be beneficial in most scenarios.

[PATCH] D74814: IR printing for single function with the new pass manager.

wenlei accepted this revision. wenlei added a comment. This revision is now accepted and ready to land. Thanks for the making the changes, it would be nice to have some consistency (the same structure) between test cases for legacy PM and new PM, e.g. `EMPTY` is only tested for legacy PM, but

[PATCH] D74814: IR printing for single function with the new pass manager.

hoyFB updated this revision to Diff 245474. hoyFB added a comment. Updating D74814 : IR printing for single function with the new pass manager. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74814/new/

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

rjmccall added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1514 + void visitUsedDecl(SourceLocation Loc, Decl *D) { +if (auto *TD = dyn_cast(D)) { + for (auto *DD : TD->decls()) { erichkeane wrote: > rjmccall wrote: > > erichkeane wrote: > > >

[PATCH] D69868: Allow "callbr" to return non-void values

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. This code has now been tested on a running Linux kernel making use of the feature. I still would like @jyknight to clarify his comments, consider explicitly requesting

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

erichkeane added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1514 + void visitUsedDecl(SourceLocation Loc, Decl *D) { +if (auto *TD = dyn_cast(D)) { + for (auto *DD : TD->decls()) { rjmccall wrote: > erichkeane wrote: > > Note that when

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

hliao updated this revision to Diff 245461. hliao added a comment. Rebase to the latest trunk code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71227/new/ https://reviews.llvm.org/D71227 Files: clang/include/clang/Sema/Sema.h

[PATCH] D74811: [Driver] Escape the program path for -frecord-command-line

ravi-ramaseshan added a comment. In D74811#1882783 , @scott.linder wrote: > This LGTM, but could you add a simple test with a command-line that needs the > escaping? Done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74811: [Driver] Escape the program path for -frecord-command-line

ravi-ramaseshan updated this revision to Diff 245456. ravi-ramaseshan added a comment. Add a simple test with a command-line that needs the escaping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74811/new/ https://reviews.llvm.org/D74811 Files:

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

rjmccall added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1514 + void visitUsedDecl(SourceLocation Loc, Decl *D) { +if (auto *TD = dyn_cast(D)) { + for (auto *DD : TD->decls()) { erichkeane wrote: > Note that when recommitting this (if you

[PATCH] D74814: IR printing for single function with the new pass manager.

wenlei added a comment. > Sounds good. I was trying to figure out how to invoke the new pass manager > with OPT. Is there a command line switch to do that? If you just do `opt -passes=`, it will invoke new pass manager for `opt`. See https://reviews.llvm.org/D66560 for example - that was for

[PATCH] D74850: [clangd] Migrate Lexer usages in TypeHierarchy to TokenBuffers

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Also fixes a bug, resulting from directly using ND.getEndLoc() for end location of the range. As

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

nickdesaulniers added a comment. In D73534#1882136 , @djtodoro wrote: > - Address the issue with ARM `describeLoadedValue()` (thanks to @vsk, I've > reduced the test > `llvm/test/DebugInfo/MIR/ARM/dbgcallsite-noreg-is-imm-check.mir`) I'd like to help

[PATCH] D74847: [CodeGen][RISCV] Fix clang/test/CodeGen/atomic_ops.c for RISC-V

efriedma added a comment. On a side-note, we could enhance the test runner to support "XFAIL: riscv32-default-target" if we thought it would be useful. But again, I'm not a fan of tests that depend on the default target in the first place. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D74847: [CodeGen][RISCV] Fix clang/test/CodeGen/atomic_ops.c for RISC-V

efriedma added a comment. I'm not really a big fan of running tests with the host target triple, anyway; it seems to create work with almost no benefit. I'd be happy to just run the test with one target that has native atomics, and one target that doesn't. (The relevant code is all

[PATCH] D74784: [driver][darwin] Don't use -platform_version flag by default

dmajor added a comment. In D74784#1882974 , @steven_wu wrote: > I forgot if there is reason to use the option by default at all time (I did > ask that in the previous review but Alex might have given more context > offline). I would really like to

[PATCH] D74784: [driver][darwin] Don't use -platform_version flag by default

steven_wu added a comment. I forgot if there is reason to use the option by default at all time (I did ask that in the previous review but Alex might have given more context offline). You should definitely add test for this change. The fact that you change all `-mlinker-version=400` to

[PATCH] D74847: [CodeGen][RISCV] Fix clang/test/CodeGen/atomic_ops.c for RISC-V

luismarques created this revision. luismarques added reviewers: jyknight, eli.friedman, lenary. Herald added subscribers: cfe-commits, evandro, sameer.abuasal, s.egerton, Jim, benna, psnobl, PkmX, jfb, rkruppe, rogfer01, shiva0217, kito-cheng, simoncook. Herald added a project: clang. By default

[PATCH] D74845: [ARM,MVE] Add vqdmull[b,t]q intrinsic families

MarkMurrayARM accepted this revision. MarkMurrayARM added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74845/new/ https://reviews.llvm.org/D74845

[PATCH] D74015: [AIX][Frontend] C++ ABI customizations for AIX boilerplate

sfertile added a comment. Patch LGTM as far a formatting/naming/testing etc. C++ specifics is outside my wheelhouse though, so I can't confirm things like the tail padding rules are correct for AIX. Because of that I'm not comfortable being the one to accept the patch. CHANGES SINCE LAST

[PATCH] D74844: [clangd] Get rid of Lexer usage in CodeComplete

sammccall added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:593 + llvm::StringRef SpelledSpecifier = + syntax::FileRange(CCSema.SourceMgr, SemaSpecifier->getBeginLoc(), +SemaSpecifier->getEndLoc()) what if

[PATCH] D74846: fix -fcodegen-modules code when used with PCH (PR44958)

llunak created this revision. llunak added reviewers: hans, dblaikie. llunak added a project: clang. Herald added a subscriber: cfe-commits. In D69778 I incorrectly handled two cases (checking for -building-pch-with-obj without also checking -fmodules-codegen).

[PATCH] D68578: [HIP] Fix device stub name

tra added inline comments. Comment at: clang/include/clang/AST/GlobalDecl.h:40 + Stub = 1, +}; + rjmccall wrote: > tra wrote: > > rjmccall wrote: > > > tra wrote: > > > > rjmccall wrote: > > > > > The attribute here is `CUDAGlobalAttr`; should this be named in

  1   2   >