[PATCH] D74643: [Parse] Consider attributes in `TryParsePtrOperatorSeq`.

michele.scandale updated this revision to Diff 246095. michele.scandale added a comment. Fixed comment wording + rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74643/new/ https://reviews.llvm.org/D74643 Files:

[PATCH] D74643: [Parse] Consider attributes in `TryParsePtrOperatorSeq`.

rsmith accepted this revision. rsmith added inline comments. Comment at: clang/include/clang/Parse/Parser.h:2444 + /// Try to skip a possibly empty sequence of 'attribute-specifier' without of + /// full validation of the syntactic structure of attributes.

[PATCH] D74941: [OpenMP] `omp begin/end declare variant` - part 1, parsing

jdoerfert updated this revision to Diff 246094. jdoerfert added a comment. minor adjustment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74941/new/ https://reviews.llvm.org/D74941 Files: clang/include/clang/AST/OpenMPClause.h

[PATCH] D74813: [RFC] Add hash of block contents to function block names

alexbdv added a comment. @dexonsmith I did a benchmark with the worst case example I can come up with - 1000 regular functions and 1000 blocks : https://paste.ofcode.org/CFU6b46nuAA6ymxUEpkzka I didn't manage to measure any performance decrease (the performance decrease was within the noise of

[PATCH] D74935: [LangRef][AliasAnalysis] Clarify `noalias` affects only modified objects

jdoerfert added a comment. In D74935#1887960 , @nhaehnle wrote: > In D74935#1887245 , @efriedma wrote: > > > In D74935#1886020 , @nhaehnle > > wrote: > > > > > I find this

[PATCH] D74935: [LangRef][AliasAnalysis] Clarify `noalias` affects only modified objects

jdoerfert updated this revision to Diff 246088. jdoerfert added a comment. Update language to memory locations instead of objects Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74935/new/ https://reviews.llvm.org/D74935 Files:

[PATCH] D75012: [ReleaseNotes] Mention -fmacro-prefix-map and -ffile-prefix-map.

MaskRay added inline comments. Comment at: clang/docs/ReleaseNotes.rst:142 +- ``-fmacro-prefix-map=OLD=NEW`` allows a directory prefix ``OLD`` in + ``__FILE__`` preprocessor macros to be substituted for ``NEW``. This helps + with reproducible builds that are location

[PATCH] D75009: [Diagnostic] Improve discoverability of ftabstop for misleading indentation

jyknight added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:67 +def note_misleading_indentation_tab_space_mix : Note< + "there is a mix of tabs spaces; the tab size (-ftabstop=X) is set to %0">; Maybe "assuming tabstops every

[PATCH] D75012: [ReleaseNotes] Mention -fmacro-prefix-map and -ffile-prefix-map.

Lekensteyn created this revision. Lekensteyn added reviewers: dankm, MaskRay, hans. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D75012 Files: clang/docs/ReleaseNotes.rst Index: clang/docs/ReleaseNotes.rst

[PATCH] D72103: [Sema] Avoid using an invalid InsertPos

Mordante added a comment. Friendly ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72103/new/ https://reviews.llvm.org/D72103 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D74860: [Sema] Fix pointer-to-int-cast diagnostic for _Bool

This revision was automatically updated to reflect the committed changes. Closed by commit rG56eb15a1c710: [Sema] Fix pointer-to-int-cast diagnostic for _Bool (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74860/new/

[clang] 56eb15a - [Sema] Fix pointer-to-int-cast diagnostic for _Bool

Author: Mark de Wever Date: 2020-02-22T19:39:49+01:00 New Revision: 56eb15a1c71061043d50aa669407816bc08dfb5d URL: https://github.com/llvm/llvm-project/commit/56eb15a1c71061043d50aa669407816bc08dfb5d DIFF: https://github.com/llvm/llvm-project/commit/56eb15a1c71061043d50aa669407816bc08dfb5d.diff

[PATCH] D74860: [Sema] Fix pointer-to-int-cast diagnostic for _Bool

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. In D74860#1888024 , @Mordante wrote: > In D74860#1883415 , @rjmccall wrote: > > > Can we test the same

[PATCH] D74860: [Sema] Fix pointer-to-int-cast diagnostic for _Bool

Mordante updated this revision to Diff 246082. Mordante added a comment. Added some C++ tests for similar c-style casts. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74860/new/ https://reviews.llvm.org/D74860 Files: clang/lib/Sema/SemaCast.cpp

[PATCH] D74860: [Sema] Fix pointer-to-int-cast diagnostic for _Bool

Mordante added a comment. In D74860#1883415 , @rjmccall wrote: > Can we test the same thing in C++? I'll add some tests, but C++ uses a different codepath for c-style casts. In D74860#1883480 , @nickdesaulniers

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. If no other comments, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72857/new/ https://reviews.llvm.org/D72857

[PATCH] D74935: [LangRef][AliasAnalysis] Clarify `noalias` affects only modified objects

nhaehnle added a comment. In D74935#1887245 , @efriedma wrote: > In D74935#1886020 , @nhaehnle wrote: > > > I find this phrasing pretty confusing. How about the following: > > > > > This indicates that objects

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader updated this revision to Diff 246072. bader added a comment. Rebase. Any other comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72857/new/ https://reviews.llvm.org/D72857 Files: clang/include/clang/Basic/LangOptions.def

[PATCH] D75006: Wrap lines for C# property accessors

jbcoe updated this revision to Diff 246070. jbcoe added a comment. Code and test to avoid wrapping accessors with expression body definitions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75006/new/ https://reviews.llvm.org/D75006 Files: clang/lib/Format/UnwrappedLineFormatter.cpp

[PATCH] D71037: [Diagnostic] Add ftabstop to -Wmisleading-indentation

Tyker added a comment. In D71037#1871089 , @efriedma wrote: > I just ran into this warning, and I think there's a bit of a discoverability > problem related to the width of tabs and -ftabstop. If you have mixed tabs > and spaces, and you've correctly

[PATCH] D75009: [Diagnostic] Improve discoverability of ftabstop for misleading indentation

Tyker added a comment. i tried to find a good message but i don't think i succeeded. any suggestions. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75009/new/ https://reviews.llvm.org/D75009 ___ cfe-commits mailing

[PATCH] D75009: [Diagnostic] Improve discoverability of ftabstop for misleading indentation

Tyker created this revision. Tyker added a reviewer: eli.friedman. Herald added a project: clang. Herald added a subscriber: cfe-commits. Tyker added a comment. i tried to find a good message but i don't think i succeeded. any suggestions. This adds an additional note after the misleading

[PATCH] D74787: [IRBuilder] Always respect inserter/folder

jdoerfert added a comment. > There should be at most two iterations, one to perform folds and one to > verify the fixpoint. If there are more iterations, that's a bug in worklist > management FWIW, the Attributor uses basically the same scheme. It helps us to monitor iteration