[PATCH] D75406: Avoid including FileManager.h from SourceManager.h

2020-02-29 Thread Reid Kleckner via Phabricator via cfe-commits
rnk updated this revision to Diff 247479. rnk added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. - fixes on Linux Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75406/new/ https://reviews.llvm.org/D75406 Files:

[PATCH] D75414: [clangd] Resolve driver symlinks, and look up unknown relative drivers in PATH.

2020-02-29 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, jfb, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This fixes a reported bug: if clang and libc++ are installed under /usr/lib/llvm-11/... but

[PATCH] D75410: [Clang-Format] Fixed BraceWrapping.AfterExternBlock

2020-02-29 Thread Marcus Johnson via Phabricator via cfe-commits
MarcusJohnson91 updated this revision to Diff 247462. MarcusJohnson91 added a comment. Rewrote the AfterExternBlock code to rely on just that clang-format option and remove the ExternNamespace check. Fixed the tests as well. and clang-formatted everything CHANGES SINCE LAST ACTION

[clang] af450ea - Avoid including FileSystem.h from MemoryBuffer.h

2020-02-29 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2020-02-29T12:30:23-08:00 New Revision: af450eabb925a8735434282d4cab6280911c229a URL: https://github.com/llvm/llvm-project/commit/af450eabb925a8735434282d4cab6280911c229a DIFF: https://github.com/llvm/llvm-project/commit/af450eabb925a8735434282d4cab6280911c229a.diff

[PATCH] D16267: Handle C++11 brace initializers in readability-braces-around-statements

2020-02-29 Thread Alexander Lanin via Phabricator via cfe-commits
AlexanderLanin added a comment. Here is the r_brace use case: if (true) while ("ok") {} Unfortunately it looks quite similar to: if (true) s = {}; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D16267/new/ https://reviews.llvm.org/D16267

[PATCH] D75410: Fixed Extern Block Indentation in libFormat

2020-02-29 Thread Marcus Johnson via Phabricator via cfe-commits
MarcusJohnson91 updated this revision to Diff 247457. MarcusJohnson91 added a comment. Clang-Formatted UnwrappedLineParser.cpp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75410/new/ https://reviews.llvm.org/D75410 Files: clang/lib/Format/UnwrappedLineParser.cpp Index:

[PATCH] D75410: Fixed Extern Block Indentation in libFormat

2020-02-29 Thread Marcus Johnson via Phabricator via cfe-commits
MarcusJohnson91 added a comment. Not sure why it failed to compile, it compiles just fine on my machine... I'm gonna re-pull from master and see if it works. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75410/new/ https://reviews.llvm.org/D75410

[PATCH] D75410: Fixed Extern Block Indentation in libFormat

2020-02-29 Thread Marcus Johnson via Phabricator via cfe-commits
MarcusJohnson91 created this revision. MarcusJohnson91 added reviewers: clang, clang-tools-extra, clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. Not sure what else to say Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D75410 Files:

[PATCH] D75162: [X86][F16C] Remove cvtph2ps intrinsics and use generic half2float conversion (PR37554)

2020-02-29 Thread Simon Pilgrim via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG7e9747b50bcb: [X86][F16C] Remove cvtph2ps intrinsics and use generic half2float conversion… (authored by RKSimon). Changed prior to commit: https://reviews.llvm.org/D75162?vs=247288=247454#toc

[clang] 7e9747b - [X86][F16C] Remove cvtph2ps intrinsics and use generic half2float conversion (PR37554)

2020-02-29 Thread Simon Pilgrim via cfe-commits
Author: Simon Pilgrim Date: 2020-02-29T18:57:35Z New Revision: 7e9747b50bcb1be28d4a3236571e8050835497a6 URL: https://github.com/llvm/llvm-project/commit/7e9747b50bcb1be28d4a3236571e8050835497a6 DIFF: https://github.com/llvm/llvm-project/commit/7e9747b50bcb1be28d4a3236571e8050835497a6.diff

[PATCH] D61549: Fix use of 'is' operator for comparison

2020-02-29 Thread Jens Carl via Phabricator via cfe-commits
j-carl added a comment. In D61549#1785369 , @Jim wrote: > @j-carl Could you give a Python 3.8 syntax reference for this change. As @tambre mentioned it's not a language change, but information about the change can be found here

[PATCH] D75406: Avoid including FileManager.h from SourceManager.h

2020-02-29 Thread Reid Kleckner via Phabricator via cfe-commits
rnk created this revision. rnk added reviewers: arphaman, hans. Herald added subscribers: martong, usaxena95, jsji, kadircet, dexonsmith, jkorous, kbarton, nemanjai. Herald added a project: clang. Most clients of SourceManager.h need to do things like turning source locations into file & line

[PATCH] D75319: Remove unused parameter from CXXRecordDecl::forallBases [NFC]

2020-02-29 Thread Aaron Puchert via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG93184a8eda27: Remove unused parameter from CXXRecordDecl::forallBases [NFC] (authored by aaronpuchert). Changed prior to commit: https://reviews.llvm.org/D75319?vs=247136=247442#toc Repository: rG

[clang] 93184a8 - Remove unused parameter from CXXRecordDecl::forallBases [NFC]

2020-02-29 Thread Aaron Puchert via cfe-commits
Author: Aaron Puchert Date: 2020-02-29T14:23:44+01:00 New Revision: 93184a8eda272c65308906836b47cbf209de779e URL: https://github.com/llvm/llvm-project/commit/93184a8eda272c65308906836b47cbf209de779e DIFF: https://github.com/llvm/llvm-project/commit/93184a8eda272c65308906836b47cbf209de779e.diff

[PATCH] D75331: [clangd] Get rid of lexer usage in locateMacroAt

2020-02-29 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 247439. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75331/new/ https://reviews.llvm.org/D75331 Files:

[PATCH] D75259: [clangd] Get rid of unnecssary source transformations in locateMacroAt

2020-02-29 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 247438. kadircet marked an inline comment as done. kadircet added a comment. - Drop semicolon Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75259/new/ https://reviews.llvm.org/D75259 Files:

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

2020-02-29 Thread Kristof Beyls via Phabricator via cfe-commits
kristof.beyls added a comment. In D74918#1898191 , @__simt__ wrote: > In D74918#1897636 , @kristof.beyls > wrote: > > > If these values are part of the C++ target platform ABI, it seems to me the > > values for

[PATCH] D75402: [HIP] Make sure, unused hip-pinned-shadow global var is kept within device code

2020-02-29 Thread Mahesha S via Phabricator via cfe-commits
hsmhsm created this revision. hsmhsm added reviewers: yaxunl, tra. Herald added a project: clang. Herald added a subscriber: cfe-commits. hip-pinned-shadow global var should remain in the final code object irrespective of whether it is used or not within the code. Add it to used list, so that it