[clang] 1cb0e01 - [DebugInfo][DWARF5]: Added support for debuginfo generation for defaulted parameters

Author: Awanish Pandey Date: 2020-03-03T13:09:53+05:30 New Revision: 1cb0e01e42ca5e9de44d9b7cb03d23552a9a9ae1 URL: https://github.com/llvm/llvm-project/commit/1cb0e01e42ca5e9de44d9b7cb03d23552a9a9ae1 DIFF:

[PATCH] D75429: [clangd] DefineOutline won't copy virtual specifiers on methods

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks, LGTM with a few small comments, please address those before landing. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:262 + } +

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

PaulkaToast updated this revision to Diff 247794. PaulkaToast marked 11 inline comments as done. Herald added subscribers: jfb, arphaman. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75332/new/ https://reviews.llvm.org/D75332 Files:

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

PaulkaToast added a comment. In D75332#1897487 , @njames93 wrote: > The test cases need fixing as they are causing the build to fail. Done. > Also would it be wise to add a .clang-tidy file to libc/ to enable this > module for that subdirectory? Yes,

[PATCH] D75491: [CodeGenObjC] Privatize some ObjC metadata symbols

rjmccall accepted this revision. rjmccall added a comment. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75491/new/ https://reviews.llvm.org/D75491 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D75494: [PowerPC] Delete PPCMachObjectWriter and triple for darwin

MaskRay updated this revision to Diff 247784. MaskRay added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75494/new/ https://reviews.llvm.org/D75494

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

jroelofs marked 2 inline comments as done. jroelofs added a comment. In D74669#1902107 , @njames93 wrote: > Adding the parent revision means you don't need to have those changes in this > patch. IIUC, that is what I've already done:

[PATCH] D74104: Remove test dependency on the presence of an assembler

dyung added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74104/new/ https://reviews.llvm.org/D74104 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D75491: [CodeGenObjC] Privatize some ObjC metadata symbols

ahatanak accepted this revision. ahatanak added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75491/new/ https://reviews.llvm.org/D75491 ___ cfe-commits mailing list

[PATCH] D75492: [clang-tidy]: modernize-use-using: don't diagnose typedefs in `extern "C"` DeclContexts

Eugene.Zelenko added a comment. See also https://llvm.org/PR35924. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75492/new/ https://reviews.llvm.org/D75492 ___ cfe-commits mailing list

[PATCH] D75429: [clangd] DefineOutline won't copy virtual specifiers on methods

njames93 updated this revision to Diff 247779. njames93 added a comment. - Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75429/new/ https://reviews.llvm.org/D75429 Files:

[PATCH] D74361: [Clang] Undef attribute for global variables

JonChesterfield added a comment. I'm finally happy with the semantic checks here. Thanks for the guidance on where to look for the hooks. - attributed variable must be at global scope - all initializers are rejected - default constructors must be trivial (to reduce the scope of this patch) -

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

akhuang updated this revision to Diff 247774. akhuang added a comment. Add FlagNonTrivial to fwd declared records in CGDebugInfo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75215/new/ https://reviews.llvm.org/D75215 Files:

[PATCH] D74361: [Clang] Undef attribute for global variables

JonChesterfield updated this revision to Diff 247776. JonChesterfield added a comment. - Error on redeclaration with loader_uninit in C Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74361/new/ https://reviews.llvm.org/D74361 Files:

[PATCH] D66831: [ObjC] Fix type checking for qualified id block parameters.

smeenai added a comment. Thanks for that explanation; that makes sense. Do you think that the `@interface J : I` would also ideally be an error then? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66831/new/ https://reviews.llvm.org/D66831

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

akhuang added a comment. In D75215#1899224 , @rnk wrote: > Now that I've gone this far... maybe we should just say `isNonTrivial() || > isFwdDecl()` -> mark it CxxReturnUdt. Something like that. I just tried this but apparently it ends up marking

[PATCH] D66831: [ObjC] Fix type checking for qualified id block parameters.

vsapsai added a comment. In D66831#1901972 , @smeenai wrote: > I'm not very familiar with Objective-C semantics. Does saying `@interface J : > I ` mean we're overriding the conformance being specified by `@interface I > `? In that case, the Clang 10

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

njames93 added a comment. Adding the parent revision means you don't need to have those changes in this patch. It will cause issues down the line. best thing is to run a diff from this to the parent and just include those changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D75429: [clangd] DefineOutline won't copy virtual specifiers on methods

njames93 updated this revision to Diff 247766. njames93 added a comment. - Tweaked format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75429/new/ https://reviews.llvm.org/D75429 Files: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

jroelofs updated this revision to Diff 247764. jroelofs added a comment. implement review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74669/new/ https://reviews.llvm.org/D74669 Files:

[PATCH] D75489: [clang-tidy] Generalize HeaderFileExtensions.{h, cpp}. NFC

jroelofs updated this revision to Diff 247762. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75489/new/ https://reviews.llvm.org/D75489 Files: clang-tools-extra/clang-tidy/bugprone/DynamicStaticInitializersCheck.cpp

[PATCH] D75483: [Sema] Fix a crash when attaching comments to an implicit decl

This revision was automatically updated to reflect the committed changes. Closed by commit rG29a4239d31c6: [Sema] Fix a crash when attaching comments to an implicit decl (authored by erik.pilkington). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75492: [modernize-use-using] Don't diagnose typedefs in `extern "C"` DeclContexts

george.burgess.iv created this revision. george.burgess.iv added a reviewer: aaron.ballman. If code is shared between C and C++, converting a `typedef` to a `using` isn't possible. Being more conservative about emitting these lints in `extern "C"` blocks seems like a good compromise to me.

[clang] 29a4239 - [Sema] Fix a crash when attaching comments to an implicit decl

Author: Erik Pilkington Date: 2020-03-02T16:49:53-08:00 New Revision: 29a4239d31c6d8ccc557afbe0999aa096ca95cc6 URL: https://github.com/llvm/llvm-project/commit/29a4239d31c6d8ccc557afbe0999aa096ca95cc6 DIFF:

[PATCH] D75465: [clang-format] Do not merge target-name and : for C# attributes

krasimir added inline comments. Comment at: clang/unittests/Format/FormatTestCSharp.cpp:281 Style.ColumnLimit = 10; - verifyFormat(R"([assembly:InternalsVisibleTo( + verifyFormat(R"([assembly: InternalsVisibleTo( "SomeAssembly,

[PATCH] D75491: [CodeGenObjC] Privatize some ObjC metadata symbols

erik.pilkington created this revision. erik.pilkington added reviewers: rjmccall, ahatanak, vsk. Herald added subscribers: ributzka, dexonsmith, jkorous. Nobody needs these symbols, so there isn't any benefit in including them. This saves some code-size in Objective-C binaries. Partially

[PATCH] D75395: [clang][Modules] Add -fsystem-module flag

Bigcheese updated this revision to Diff 247755. Bigcheese added a comment. Cleaned up the test to not reference unused paths. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75395/new/ https://reviews.llvm.org/D75395 Files:

[PATCH] D75465: [clang-format] Do not merge target-name and : for C# attributes

krasimir added inline comments. Comment at: clang/unittests/Format/FormatTestCSharp.cpp:281 Style.ColumnLimit = 10; - verifyFormat(R"([assembly:InternalsVisibleTo( + verifyFormat(R"([assembly: InternalsVisibleTo( "SomeAssembly,

[PATCH] D73649: [CodeComplete] Member completion for concept-constrained types.

sammccall added a comment. > I'm not sure that I'm qualified to approve this patch (this is my first time > looking at clang's completion code) I feel the same way about writing the code :-) Thanks for the comments! I'll get another review from someone who's stared into this abyss before, too.

[PATCH] D74361: [Clang] Undef attribute for global variables

JonChesterfield updated this revision to Diff 247753. JonChesterfield added a comment. - error on extern variables, minor cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74361/new/ https://reviews.llvm.org/D74361 Files:

[PATCH] D73649: [CodeComplete] Member completion for concept-constrained types.

sammccall updated this revision to Diff 247751. sammccall marked 27 inline comments as done. sammccall added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73649/new/ https://reviews.llvm.org/D73649 Files:

[PATCH] D75489: [clang-tidy] Generalize HeaderFileExtensions.{h, cpp}. NFC

jroelofs created this revision. jroelofs added reviewers: njames93, aaron.ballman. Herald added subscribers: cfe-commits, xazax.hun, mgorny. Herald added a project: clang. jroelofs added a child revision: D74669: [clang-tidy] New check: bugprone-suspicious-include. jroelofs marked an inline

[PATCH] D75489: [clang-tidy] Generalize HeaderFileExtensions.{h, cpp}. NFC

jroelofs marked an inline comment as done. jroelofs added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/FileExtensionsUtils.h:14 #include "clang/Basic/SourceManager.h" +#include "llvm/ADT/Optional.h" #include "llvm/ADT/SmallSet.h" this

[PATCH] D66831: [ObjC] Fix type checking for qualified id block parameters.

smeenai added a comment. Sorry for the late feedback here – we're in the process of testing with Clang 10 and noticed a behavior change caused by this commit. Consider the following piece of code: @protocol P @end @protocol Q @end @interface I @end @interface J : I

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

rnk added a comment. BTW, I am curious to know if this helps V8 PDB size. IIRC you said there were some PDBs in Chrome that have this problem a lot. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75215/new/ https://reviews.llvm.org/D75215

[PATCH] D75395: [clang][Modules] Add -fsystem-module flag

dexonsmith added a comment. In D75395#1901859 , @Bigcheese wrote: > In D75395#1901778 , @dexonsmith > wrote: > > > > This is used when > > > converting an implicit build to an explicit build to match the > > >

[PATCH] D74361: [Clang] Undef attribute for global variables

JonChesterfield updated this revision to Diff 247745. JonChesterfield marked 2 inline comments as done. JonChesterfield added a comment. - Reduce scope to trivial default constructed types Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74361/new/

[PATCH] D74361: [Clang] Undef attribute for global variables

JonChesterfield added a comment. I've continued thinking about / experimenting with this. Curiously - `X x;` and `X x{};` are considered distinct by clang. The current patch will only accept the former. I'll add some tests for that. I think there's a reasonable chance that the developers who

[PATCH] D75486: [SVE] Make CompositeType not inherit from Type

ctetreau created this revision. Herald added subscribers: llvm-commits, cfe-commits, kerbowa, psnobl, rkruppe, hiraditya, tschuett, nhaehnle, jvesely, arsenm. Herald added a reviewer: efriedma. Herald added projects: clang, LLVM. This patch is a work in progress Make CompositeType not inherit

[PATCH] D74361: [Clang] Undef attribute for global variables

Quuxplusone added inline comments. Comment at: clang/test/CodeGenCXX/attr-loader-uninitialized.cpp:23 +// CHECK: @nominally_value_init = global i32 undef +int nominally_value_init [[clang::loader_uninitialized]] = 4; + rjmccall wrote: > JonChesterfield wrote: >

[PATCH] D75483: [Sema] Fix a crash when attaching comments to an implicit decl

jkorous accepted this revision. jkorous added a comment. This revision is now accepted and ready to land. Thanks a bunch for fixing this! That also means we can skip all the implicit declarations from the `for (const Decl *D : Decls) {` just a couple lines below your fix since implicit

[PATCH] D73852: [clang] detect switch fallthrough marked by a comment (PR43465)

rsmith added a comment. In D73852#1901836 , @aaron.ballman wrote: > FYI: it was reverted by Luboš in c61401b89742f230b7e6a2cc0548fbf7442e906d > Thank you, Luboš, and sorry for the

[PATCH] D75395: [clang][Modules] Add -fsystem-module flag

Bigcheese added a comment. In D75395#1901778 , @dexonsmith wrote: > > This is used when > > converting an implicit build to an explicit build to match the > > systemness the implicit build would have had for a given module. > > I had another thought.

[PATCH] D75483: [Sema] Fix a crash when attaching comments to an implicit decl

erik.pilkington created this revision. erik.pilkington added a reviewer: jkorous. Herald added subscribers: ributzka, dexonsmith. When an implicitly generated decl was the first entry in the group, we attempted to lookup comments with an empty FileID, leading to crashes. Avoid this by trying to

[PATCH] D73852: [clang] detect switch fallthrough marked by a comment (PR43465)

aaron.ballman added a comment. In D73852#1901793 , @rsmith wrote: > In any case, none of this has any bearing on whether this patch has had > sufficient review. It hasn't, so it needs to be reverted for now. FYI: it was reverted by Luboš in

[PATCH] D74361: [Clang] Undef attribute for global variables

rjmccall added inline comments. Comment at: clang/test/CodeGenCXX/attr-loader-uninitialized.cpp:23 +// CHECK: @nominally_value_init = global i32 undef +int nominally_value_init [[clang::loader_uninitialized]] = 4; + JonChesterfield wrote: > rjmccall wrote: > >

[PATCH] D74361: [Clang] Undef attribute for global variables

rjmccall added inline comments. Comment at: clang/test/CodeGenCXX/attr-loader-uninitialized.cpp:23 +// CHECK: @nominally_value_init = global i32 undef +int nominally_value_init [[clang::loader_uninitialized]] = 4; + Quuxplusone wrote: > rjmccall wrote: > >

[PATCH] D73852: [clang] detect switch fallthrough marked by a comment (PR43465)

rsmith added a comment. In D73852#1901699 , @llunak wrote: > In D73852#1901186 , @rsmith wrote: > > > We shouldn't enable the warning under -Wextra in language modes where > > there's no standard way to suppress

[PATCH] D75395: [clang][Modules] Add -fsystem-module flag

Bigcheese marked 2 inline comments as done. Bigcheese added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1912 +Diags.Report(diag::err_drv_argument_only_allowed_with) << "-fsystem-module" + <<

[PATCH] D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP

tejohnson added a comment. Reverted in 80bf137fa132ea33204e98bbefa924afe9258a4e Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73242/new/ https://reviews.llvm.org/D73242

[PATCH] D75395: [clang][Modules] Add -fsystem-module flag

dexonsmith added inline comments. Comment at: clang/include/clang/Driver/Options.td:1448 Flags<[CC1Option]>, Alias; +def fsystem_module : Flag<["-"], "fsystem-module">, Flags<[CC1Option]>, + HelpText<"Build this module as a system module. Only used with -emit-module">;

[PATCH] D75395: [clang][Modules] Add -fsystem-module flag

dexonsmith added a comment. > This is used when > converting an implicit build to an explicit build to match the > systemness the implicit build would have had for a given module. I had another thought. What if for the explicitly built "system" modules: - If `-Wsystem-headers` is on, leave

[clang] eb812ef - Explicitly include when using assert

Author: Joerg Sonnenberger Date: 2020-03-02T22:45:28+01:00 New Revision: eb812efa12fb82ca338794fa18b610ca9581aef5 URL: https://github.com/llvm/llvm-project/commit/eb812efa12fb82ca338794fa18b610ca9581aef5 DIFF:

[PATCH] D75139: [hexagon] Pickup the default crt and libs when the musl target is selected

sidneym updated this revision to Diff 247724. sidneym added a comment. address clang-tidy issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75139/new/ https://reviews.llvm.org/D75139 Files: clang/lib/Driver/ToolChains/Hexagon.cpp

[PATCH] D75479: [clangd] go-to-def on names in comments etc that are used nearby.

sammccall created this revision. sammccall added a reviewer: nridge. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This is intended as a companion to (and is inspired by) D72874

[PATCH] D75395: [clang][Modules] Add -fsystem-module flag

bruno added a comment. Hi Michael, thanks for improving this. Comment at: clang/include/clang/Driver/Options.td:1448 Flags<[CC1Option]>, Alias; +def fsystem_module : Flag<["-"], "fsystem-module">, Flags<[CC1Option]>, + HelpText<"Build this module as a system module. Only

[PATCH] D72874: [clangd] Add a textual fallback for go-to-definition

sammccall added a comment. In D72874#1901606 , @nridge wrote: > The "dependent code" use case is a pretty important one in my eyes. > > In one of the codebases I work on, we have a fair amount of code like this: Yep, fair enough. And I don't think that

[clang] c61401b - Revert "[clang] detect switch fallthrough marked by a comment (PR43465)"

Author: Luboš Luňák Date: 2020-03-02T22:33:25+01:00 New Revision: c61401b89742f230b7e6a2cc0548fbf7442e906d URL: https://github.com/llvm/llvm-project/commit/c61401b89742f230b7e6a2cc0548fbf7442e906d DIFF: https://github.com/llvm/llvm-project/commit/c61401b89742f230b7e6a2cc0548fbf7442e906d.diff

[PATCH] D73852: [clang] detect switch fallthrough marked by a comment (PR43465)

rsmith added a comment. Per http://llvm.org/PR43465#c37, this patch has not had proper review and we have not established consensus that we want this. Please revert for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73852/new/

[PATCH] D73852: [clang] detect switch fallthrough marked by a comment (PR43465)

llunak added a comment. In D73852#1901186 , @rsmith wrote: > We shouldn't enable the warning under -Wextra in language modes where there's > no standard way to suppress it. That may be true, but that is not what the bugreport is about, it explicitly

[PATCH] D74361: [Clang] Undef attribute for global variables

JonChesterfield marked 2 inline comments as done. JonChesterfield added inline comments. Comment at: clang/test/CodeGenCXX/attr-loader-uninitialized.cpp:23 +// CHECK: @nominally_value_init = global i32 undef +int nominally_value_init [[clang::loader_uninitialized]] = 4; +

[PATCH] D75373: [Clang] Fix Hurd toolchain class hierarchy

This revision was automatically updated to reflect the committed changes. Closed by commit rG7e77cf473ac9: [Clang] Fix Hurd toolchain test on a two-stage build with ThinLTO (authored by aganea). Changed prior to commit: https://reviews.llvm.org/D75373?vs=247542=247715#toc Repository: rG

[PATCH] D75447: [clangd] Make use of token buffers in semantic highlighting

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:162 +[&](const syntax::Token ) { return Tok.location() < Loc; }); +assert(Tok); +

[PATCH] D75139: [hexagon] Pickup the default crt and libs when the musl target is selected

sidneym updated this revision to Diff 247711. sidneym added a comment. Update testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75139/new/ https://reviews.llvm.org/D75139 Files: clang/lib/Driver/ToolChains/Hexagon.cpp

[clang] 7e77cf4 - [Clang] Fix Hurd toolchain test on a two-stage build with ThinLTO

Author: Alexandre Ganea Date: 2020-03-02T15:42:33-05:00 New Revision: 7e77cf473ac9d8f8b65db017d660892f1c8f4b75 URL: https://github.com/llvm/llvm-project/commit/7e77cf473ac9d8f8b65db017d660892f1c8f4b75 DIFF:

[PATCH] D74361: [Clang] Undef attribute for global variables

Quuxplusone added inline comments. Comment at: clang/test/CodeGenCXX/attr-loader-uninitialized.cpp:23 +// CHECK: @nominally_value_init = global i32 undef +int nominally_value_init [[clang::loader_uninitialized]] = 4; + rjmccall wrote: > JonChesterfield wrote: >

[PATCH] D72874: [clangd] Add a textual fallback for go-to-definition

nridge added a comment. Thanks for all the comments Sam! I'll have a detailed look tomorrow, but I wanted to follow up on this: In D72874#1901383 , @sammccall wrote: > I think having this trigger where the identifier is an actual token in the > program

[PATCH] D74361: [Clang] Undef attribute for global variables

rjmccall added inline comments. Comment at: clang/test/CodeGenCXX/attr-loader-uninitialized.cpp:23 +// CHECK: @nominally_value_init = global i32 undef +int nominally_value_init [[clang::loader_uninitialized]] = 4; + JonChesterfield wrote: > Quuxplusone wrote: >

[clang] 0858eeb - Revert "Add default paths to support musl target"

Author: Sid Manning Date: 2020-03-02T14:09:52-06:00 New Revision: 0858eebd2a48b931f2ef1dfa23042980bd6a773d URL: https://github.com/llvm/llvm-project/commit/0858eebd2a48b931f2ef1dfa23042980bd6a773d DIFF: https://github.com/llvm/llvm-project/commit/0858eebd2a48b931f2ef1dfa23042980bd6a773d.diff

[PATCH] D75298: [Clang][SVE] Parse builtin type string for scalable vectors

efriedma added a comment. > The main reason we couldn't remove the header file is because of the > short-forms/overloaded intrinsics How are you planning to handle them with your current approach? Anyway, that isn't really relevant to the question of why we need to `#define svld1_u8(...)

[PATCH] D74361: [Clang] Undef attribute for global variables

JonChesterfield marked 4 inline comments as done. JonChesterfield added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:4367 +This is useful for variables that are always written to before use where the +default zero initialization provided by the toolchain

[clang] 375437a - [OPENMP50]Support 'destroy' clause on 'depobj' directives.

Author: Alexey Bataev Date: 2020-03-02T14:40:53-05:00 New Revision: 375437ab92a879629cd6abef057428f3572514c2 URL: https://github.com/llvm/llvm-project/commit/375437ab92a879629cd6abef057428f3572514c2 DIFF: https://github.com/llvm/llvm-project/commit/375437ab92a879629cd6abef057428f3572514c2.diff

[PATCH] D75139: [hexagon] Pickup the default crt and libs when the musl target is selected

This revision was automatically updated to reflect the committed changes. Closed by commit rG637767665141: Add default paths to support musl target (authored by sidneym). Changed prior to commit: https://reviews.llvm.org/D75139?vs=247251=247701#toc Repository: rG LLVM Github Monorepo

[clang] 6377676 - Add default paths to support musl target

Author: Sid Manning Date: 2020-03-02T13:39:42-06:00 New Revision: 637767665141ae48c7a0558903bb29e03bf5ad6f URL: https://github.com/llvm/llvm-project/commit/637767665141ae48c7a0558903bb29e03bf5ad6f DIFF: https://github.com/llvm/llvm-project/commit/637767665141ae48c7a0558903bb29e03bf5ad6f.diff

[PATCH] D75387: [Sema] Look through OpaqueValueExpr when checking implicit conversions

This revision was automatically updated to reflect the committed changes. Closed by commit rGe392dcd5708b: [Sema] Look through OpaqueValueExpr when checking implicit conversions (authored by erik.pilkington). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D74361: [Clang] Undef attribute for global variables

JonChesterfield updated this revision to Diff 247696. JonChesterfield marked 2 inline comments as done. JonChesterfield added a comment. - Reject initialisers, update doc to recommended string Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75447: [clangd] Make use of token buffers in semantic highlighting

kadircet updated this revision to Diff 247695. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75447/new/ https://reviews.llvm.org/D75447 Files:

[PATCH] D74361: [Clang] Undef attribute for global variables

Quuxplusone added inline comments. Comment at: clang/test/CodeGenCXX/attr-loader-uninitialized.cpp:23 +// CHECK: @nominally_value_init = global i32 undef +int nominally_value_init [[clang::loader_uninitialized]] = 4; + This test case is identical to line 36 of

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

pcc added inline comments. Comment at: clang/test/CodeGenCXX/lto-visibility-inference.cpp:73 c1->f(); - // ITANIUM-NOT: type.test{{.*}}!"_ZTS2C2" + // ITANIUM: type.test{{.*}}!"_ZTS2C2" // MS: type.test{{.*}}!"?AUC2@@" tejohnson wrote: > evgeny777 wrote:

[PATCH] D75474: [clangd] Get rid of getTokenRange helper

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. kadircet added a parent revision: D75447: [clangd] Make use of token buffers in semantic

[PATCH] D75423: [OpenCL] Mark pointers to constant address space as invariant

rjmccall added a comment. In D75423#1901407 , @yaxunl wrote: > In D75423#1901362 , @rjmccall wrote: > > > Okay, then I have no problem taking a patch for this into IRGen. But I > > think it should be fine to do

[PATCH] D75194: [clang-format] Do not merge very long C# automatic properties

jbcoe planned changes to this revision. jbcoe added a comment. I will try to handle this in unwrapped line parser. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75194/new/ https://reviews.llvm.org/D75194

[PATCH] D75473: [clang-format] parse C# object initialisers

jbcoe created this revision. jbcoe added a reviewer: krasimir. jbcoe added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. Treat C# object initializers as braced lists. Allow lambdas inside C# braced lists. Repository: rG LLVM Github Monorepo

[PATCH] D75402: [HIP] Make sure, unused hip-pinned-shadow global var is kept within device code

hsmhsm updated this revision to Diff 247689. hsmhsm added a comment. Take care review comments by hliao. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75402/new/ https://reviews.llvm.org/D75402 Files: clang/lib/CodeGen/CodeGenModule.cpp

[clang] e392dcd - [Sema] Look through OpaqueValueExpr when checking implicit conversions

Author: Erik Pilkington Date: 2020-03-02T11:24:36-08:00 New Revision: e392dcd5708b3bb188ff4043b09ae151472a7632 URL: https://github.com/llvm/llvm-project/commit/e392dcd5708b3bb188ff4043b09ae151472a7632 DIFF:

[clang] c112e94 - [OPENMP50]Add basic support for depobj construct.

Author: Alexey Bataev Date: 2020-03-02T13:10:32-05:00 New Revision: c112e941a0c5d3b3423272c3f0024cdf6b50e44e URL: https://github.com/llvm/llvm-project/commit/c112e941a0c5d3b3423272c3f0024cdf6b50e44e DIFF: https://github.com/llvm/llvm-project/commit/c112e941a0c5d3b3423272c3f0024cdf6b50e44e.diff

[PATCH] D74500: clang: Treat ieee mode as the default for denormal-fp-math

spatel added inline comments. Comment at: llvm/include/llvm/ADT/FloatingPointMode.h:48 - DenormalMode() = default; - DenormalMode(DenormalModeKind Out, DenormalModeKind In) : + constexpr DenormalMode() = default; + constexpr DenormalMode(DenormalModeKind Out,

[PATCH] D73720: [Analyzer] Use note tags to track container begin and and changes

Szelethus requested changes to this revision. Szelethus added a comment. This revision now requires changes to proceed. Apologies -- I'd definitely prefer to address the debug related changes in a separate pack, similarly to D74541 . CHANGES SINCE LAST ACTION

[PATCH] D74541: [Analyzer] Use note tags to track iterator increments and decrements

Szelethus added a comment. See my related comment here: D73720#1901453 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74541/new/ https://reviews.llvm.org/D74541 ___ cfe-commits mailing list

[PATCH] D73720: [Analyzer] Use note tags to track container begin and and changes

Szelethus added a comment. In D73720#1874014 , @baloghadamsoftware wrote: > In case of multiple container-related bugs only mark the container > interesting on the correct bug path. Also a typo fixed. ~~Uh-oh, I'm not sure why this would ever be an

[PATCH] D75423: [OpenCL] Mark pointers to constant address space as invariant

yaxunl updated this revision to Diff 247688. yaxunl marked 2 inline comments as done. yaxunl added a comment. revised by John's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75423/new/ https://reviews.llvm.org/D75423 Files: clang/lib/CodeGen/CGDeclCXX.cpp

[PATCH] D74361: [Clang] Undef attribute for global variables

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:7436 + case ParsedAttr::AT_LoaderUninitialized: +handleLoaderUninitializedAttr(S, D, AL); +break; rjmccall wrote: > JonChesterfield wrote: > > aaron.ballman wrote: > > > If

[PATCH] D31343: Add an attribute plugin example

john.brawn marked 2 inline comments as done. john.brawn added inline comments. Comment at: clang/examples/Attribute/Attribute.cpp:35 +Spellings.push_back({ParsedAttr::AS_GNU, "example"}); +Spellings.push_back({ParsedAttr::AS_CXX11, "::example"}); +

[PATCH] D75356: [Analyzer][StreamChecker] Introduction of stream error state handling.

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:50-68 +struct StreamErrorState { + // The error state of an opened stream. + // EofError: EOF condition (feof returns true) + // OtherError: other (non-EOF) error (ferror returns

[PATCH] D75402: [HIP] Make sure, unused hip-pinned-shadow global var is kept within device code

yaxunl added a comment. In D75402#1901370 , @hsmhsm wrote: > In D75402#1901361 , @hliao wrote: > > > BTW, why that variable cannot have an initializer? Suppose that initializer > > is a trivial one, initializing

[PATCH] D75423: [OpenCL] Mark pointers to constant address space as invariant

yaxunl added a comment. In D75423#1901362 , @rjmccall wrote: > Okay, then I have no problem taking a patch for this into IRGen. But I think > it should be fine to do this by adding the invariant-load metadata when > loading from an l-value instead of

[PATCH] D72874: [clangd] Add a textual fallback for go-to-definition

sammccall added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.cpp:313 SourceLocation getBeginningOfIdentifier(const Position , const SourceManager , sammccall wrote: > @kadircet is working on getting

[PATCH] D75469: Add C standard upgrade in clang-11 release note

nickdesaulniers updated this revision to Diff 247682. nickdesaulniers added a comment. - s/following/next/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75469/new/ https://reviews.llvm.org/D75469 Files: clang/docs/ReleaseNotes.rst Index:

[PATCH] D75469: Add C standard upgrade in clang-11 release note

nickdesaulniers added a comment. pushed: https://github.com/llvm/llvm-project/commit/001c8aac80e3924c33a4cc644cca58401c72fe6b Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75469/new/ https://reviews.llvm.org/D75469

[PATCH] D72874: [clangd] Add a textual fallback for go-to-definition

sammccall added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.cpp:313 SourceLocation getBeginningOfIdentifier(const Position , const SourceManager , sammccall wrote: > sammccall wrote: > > @kadircet

  1   2   3   >