[PATCH] D76534: [clang/docs] Fix various sphinx warnings/errors in docs.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Is the option issue causing the documentation to be wrong in any way, or does it just produce a warning? If the latter, we could raise this issue with them. Repository: rG LLVM Github

[PATCH] D76538: [WebAssembly] Add SIMD integer abs builtins

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100, dschuff. Herald added a project: clang. Since the conditional operator cannot be used with vector conditions in C, we need a builtin to be able to express

[PATCH] D66094: [CodeGen] Emit destructor calls for non-trivial C structs returned by function calls and loaded from volatile objects

This revision was automatically updated to reflect the committed changes. Closed by commit rGd35a454170da: [CodeGen] Emit destructor calls to destruct non-trivial C struct objects… (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] a299178 - [cmake] Fix -stripped for umbrella library install targets

Author: Shoaib Meenai Date: 2020-03-20T18:46:48-07:00 New Revision: a299178ae77a9d0c7d66f50d17483b7d18898ef0 URL: https://github.com/llvm/llvm-project/commit/a299178ae77a9d0c7d66f50d17483b7d18898ef0 DIFF: https://github.com/llvm/llvm-project/commit/a299178ae77a9d0c7d66f50d17483b7d18898ef0.diff

[clang] ced7617 - PR45267: Don't reject pure-specifiers with escaped newlines in their '0' token.

Author: Richard Smith Date: 2020-03-20T18:44:55-07:00 New Revision: ced7617c3853d19ffa00a578e92ffd7c54b6c2fb URL: https://github.com/llvm/llvm-project/commit/ced7617c3853d19ffa00a578e92ffd7c54b6c2fb DIFF: https://github.com/llvm/llvm-project/commit/ced7617c3853d19ffa00a578e92ffd7c54b6c2fb.diff

[clang] d35a454 - [CodeGen] Emit destructor calls to destruct non-trivial C struct objects

Author: Akira Hatanaka Date: 2020-03-20T18:34:22-07:00 New Revision: d35a454170da3da9c9bb0b5627f5796113195283 URL: https://github.com/llvm/llvm-project/commit/d35a454170da3da9c9bb0b5627f5796113195283 DIFF:

[PATCH] D76438: ConstantExpr cached APValues if present for constant evaluation

This revision was automatically updated to reflect the committed changes. Closed by commit rGbe10b7e43a3a: Use values cached in ConstantExprs for expression evaluation where present. (authored by wchilders, committed by rsmith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] be10b7e - Use values cached in ConstantExprs for expression evaluation where

Author: Wyatt Childers Date: 2020-03-20T18:14:58-07:00 New Revision: be10b7e43a3a10fbd3244f826591f3f65c0b7e21 URL: https://github.com/llvm/llvm-project/commit/be10b7e43a3a10fbd3244f826591f3f65c0b7e21 DIFF:

[PATCH] D76365: [cuda][hip] Add CUDA builtin surface/texture reference support.

tra added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:701-713 + if (getLangOpts().CUDAIsDevice) { +// As CUDA builtin surface/texture types are replaced, skip generating TBAA +// access info. +if (AccessType->isCUDADeviceBuiltinSurfaceType()) {

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 251804. oontvoo added a comment. Removed accidentally committed file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/HeaderSearch.h

[PATCH] D76393: Allow remapping the sysroot with -fdebug-prefix-map.

aprantl added a comment. Yeah, screwed up during rebasing and accidentally committed an extra file from a different review I reverted and relanded the patch now and the bots are running again. Sorry for the noise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 251801. oontvoo marked an inline comment as done. oontvoo added a comment. Additional change: Also keep "Importers" and de/serialise these. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/

[PATCH] D76452: Use LLD by default for Android.

MaskRay added a comment. Thanks for abandoning this patch. I am glad Android does not need customization on top of the generic Linux behavior. (This makes clangDriver clean.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76452/new/

[PATCH] D76528: [clang codegen] Clean up handling of vectors with trivial-auto-var-init.

jfb added a comment. Oh good catch. Were there no vector tests which tripped this? Vectors can hold scalar types with padding (i.e. `long double`)? Tail padding in vectors do seem important to initialize as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

rjmccall added a comment. Let's make this patch be purely a representation change. I wouldn't expect *any* test changes from that; if there are, we should understand why. You can then add the stuff about tracking whether there's a pragma in a separate patch. Comment at:

[PATCH] D76393: Allow remapping the sysroot with -fdebug-prefix-map.

PaulkaToast added a comment. This seems to be causing a failure in our buildbot , mind taking a look? (: Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76393/new/

[PATCH] D76097: improve performance of getSDKName()

This revision was automatically updated to reflect the committed changes. Closed by commit rG0e916bf9f5e4: Driver: Improve performance of getSDKName() (authored by aprantl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 0e916bf - Driver: Improve performance of getSDKName()

Author: Adrian Prantl Date: 2020-03-20T16:41:59-07:00 New Revision: 0e916bf9f5e4a51af621fd72ccf4b00b7e6f86fa URL: https://github.com/llvm/llvm-project/commit/0e916bf9f5e4a51af621fd72ccf4b00b7e6f86fa DIFF: https://github.com/llvm/llvm-project/commit/0e916bf9f5e4a51af621fd72ccf4b00b7e6f86fa.diff

[clang] bde15de - Revert "Allow remapping the sysroot with -fdebug-prefix-map."

Author: Adrian Prantl Date: 2020-03-20T16:27:23-07:00 New Revision: bde15de3cabff6363008e67a999e6e4559743867 URL: https://github.com/llvm/llvm-project/commit/bde15de3cabff6363008e67a999e6e4559743867 DIFF: https://github.com/llvm/llvm-project/commit/bde15de3cabff6363008e67a999e6e4559743867.diff

[clang] ceae471 - Allow remapping the sysroot with -fdebug-prefix-map.

Author: Adrian Prantl Date: 2020-03-20T16:27:50-07:00 New Revision: ceae47143b1d2c5622e0318255e6663264d61299 URL: https://github.com/llvm/llvm-project/commit/ceae47143b1d2c5622e0318255e6663264d61299 DIFF: https://github.com/llvm/llvm-project/commit/ceae47143b1d2c5622e0318255e6663264d61299.diff

[PATCH] D76395: [clang-tidy] Merge common code between llvmlibc-restrict-system-libc-headers and portability-restrict-system-includes

This revision was automatically updated to reflect the committed changes. Closed by commit rG556b917fffcf: [clang-tidy] Merge common code between llvmlibc-restrict-system-libc-headers… (authored by PaulkaToast). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76393: Allow remapping the sysroot with -fdebug-prefix-map.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6725c4836a5b: Allow remapping the sysroot with -fdebug-prefix-map. (authored by aprantl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D76393?vs=251412=251798#toc

[PATCH] D76452: Use LLD by default for Android.

danalbert abandoned this revision. danalbert added a comment. Looks like we don't actually need this. Can achieve the same effect by installing `ld.lld` to the same directory as Clang as `ld` and it'll be preferred over the other locations. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D74619: [ARM] Enabling range checks on Neon intrinsics' lane arguments

leonardchan added a comment. Actually this may not need a reproducer since the error seems straightforward with just calling a builtin function. The main issue is that before this patch, something like #include float64x2_t func(int8x8_t x) { return __builtin_neon_splatq_lane_v(x, 1,

[clang-tools-extra] 556b917 - [clang-tidy] Merge common code between llvmlibc-restrict-system-libc-headers and portability-restrict-system-includes

Author: Paula Toth Date: 2020-03-20T15:53:05-07:00 New Revision: 556b917fffcfaa15ea11a277e1b0d87b8d13e0f1 URL: https://github.com/llvm/llvm-project/commit/556b917fffcfaa15ea11a277e1b0d87b8d13e0f1 DIFF: https://github.com/llvm/llvm-project/commit/556b917fffcfaa15ea11a277e1b0d87b8d13e0f1.diff

[clang] 6725c48 - Allow remapping the sysroot with -fdebug-prefix-map.

Author: Adrian Prantl Date: 2020-03-20T15:52:39-07:00 New Revision: 6725c4836a5b3c11227869a6f456019a244aa29f URL: https://github.com/llvm/llvm-project/commit/6725c4836a5b3c11227869a6f456019a244aa29f DIFF: https://github.com/llvm/llvm-project/commit/6725c4836a5b3c11227869a6f456019a244aa29f.diff

[PATCH] D76383: Allow remapping Clang module skeleton CU references with -fdebug-prefix-map

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG43580a5c5afc: Allow remapping Clang module skeleton CU references with -fdebug-prefix-map (authored by aprantl). Herald

[PATCH] D75853: [Clang][test] Add .i files for test discovery

This revision was automatically updated to reflect the committed changes. Closed by commit rGf75f19c23748: [Clang][test] Add .i files for test discovery (authored by saudi). Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76533: [clangd] Skip ClangdVFSTest.TestStackOverflow when address sanitizer is used

bjope added a comment. I don't know if this is a good solution. But we've had problems with our downstream bots that builds llvm with asan, and runs check-all, for awhile (probably since we merged https://reviews.llvm.org/D50993). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D76385: Allow remapping Clang module include paths

aprantl updated this revision to Diff 251789. aprantl added a comment. Rebased and addressed review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76385/new/ https://reviews.llvm.org/D76385 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D76504: [clang] Fix crash during template sema checking

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Sema/SemaChecking.cpp:1655 +// greater than 0. When `size` is value dependent we cannot evaluate its +// value so we bail<< out. +

[PATCH] D76534: [clang/docs] Fix various sphinx warnings/errors in docs.

fhahn created this revision. fhahn added reviewers: jfb, Bigcheese, dexonsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. There are a few places with unexpected indents that trip over sphinx and other syntax errors. Also, the C++ syntax highlighting does not work for

[PATCH] D76533: [clangd] Skip ClangdVFSTest.TestStackOverflow when address sanitizer is used

bjope created this revision. bjope added reviewers: sammccall, Dmitry.Kozhevnikov. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. bjope added a comment. bjope added subscribers: uabelho, dstenb. I don't know

[clang] f75f19c - [Clang][test] Add .i files for test discovery

Author: Sylvain Audi Date: 2020-03-20T18:21:27-04:00 New Revision: f75f19c2374807247e779a1e00bfeabc337ee446 URL: https://github.com/llvm/llvm-project/commit/f75f19c2374807247e779a1e00bfeabc337ee446 DIFF: https://github.com/llvm/llvm-project/commit/f75f19c2374807247e779a1e00bfeabc337ee446.diff

[clang] 43580a5 - Allow remapping Clang module skeleton CU references with -fdebug-prefix-map

Author: Adrian Prantl Date: 2020-03-20T15:15:56-07:00 New Revision: 43580a5c5afc3cd935e4e3d67f285fe81dd7e8c5 URL: https://github.com/llvm/llvm-project/commit/43580a5c5afc3cd935e4e3d67f285fe81dd7e8c5 DIFF: https://github.com/llvm/llvm-project/commit/43580a5c5afc3cd935e4e3d67f285fe81dd7e8c5.diff

[PATCH] D76504: [clang] Fix crash during template sema checking

gchatelet updated this revision to Diff 251780. gchatelet added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76504/new/ https://reviews.llvm.org/D76504 Files: clang/lib/Sema/SemaChecking.cpp

[PATCH] D74619: [ARM] Enabling range checks on Neon intrinsics' lane arguments

leonardchan added a comment. Hi, a bisect seems to show https://reviews.llvm.org/rGf56550cf7f12b581a237b48a7f4d8b6682d45a09 is causing us to see the following error: error: argument value 1 is outside the valid range [0, 0] v2 = vdupq_lane_f64(vget_high_f64(a.v), 1); ^

[PATCH] D76365: [cuda][hip] Add CUDA builtin surface/texture reference support.

hliao updated this revision to Diff 251777. hliao added a comment. Minor revising following reviewer's comment. Work on Sema checks and upload another review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76365/new/

[PATCH] D76365: [cuda][hip] Add CUDA builtin surface/texture reference support.

hliao marked 5 inline comments as done. hliao added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:701-713 + if (getLangOpts().CUDAIsDevice) { +// As CUDA builtin surface/texture types are replaced, skip generating TBAA +// access info. +if

[clang] fc8a009 - Clean up and simplify after collision of c48442c and 19fccc5, which

Author: Richard Smith Date: 2020-03-20T14:53:09-07:00 New Revision: fc8a009bf39d74ce0ee3f586e0b4056035db30cb URL: https://github.com/llvm/llvm-project/commit/fc8a009bf39d74ce0ee3f586e0b4056035db30cb DIFF: https://github.com/llvm/llvm-project/commit/fc8a009bf39d74ce0ee3f586e0b4056035db30cb.diff

[PATCH] D76377: Correctly initialize the DW_AT_comp_dir attribute of Clang module skeleton CUs

This revision was automatically updated to reflect the committed changes. Closed by commit rG079c6ddaf534: Correctly initialize the DW_AT_comp_dir attribute of Clang module skeleton CUs (authored by aprantl). Herald added a project: clang. Changed prior to commit:

[PATCH] D76438: ConstantExpr cached APValues if present for constant evaluation

wchilders updated this revision to Diff 251763. wchilders marked an inline comment as done. wchilders added a comment. Dropped the override for constexpr evaluator, LValue evaluation base class CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76438/new/ https://reviews.llvm.org/D76438

[PATCH] D76528: [clang codegen] Clean up handling of vectors with trivial-auto-var-init.

efriedma created this revision. efriedma added reviewers: glider, jfb. Herald added a subscriber: dexonsmith. Herald added a project: clang. The code was pretending to be doing something useful with vectors, but really it was doing nothing: the element type of a vector is always a scalar type,

[PATCH] D76438: ConstantExpr cached APValues if present for constant evaluation

wchilders added a comment. I should note, I don't have commit access, so I'm unable to commit this myself. Attribution would be `Wyatt Childers ` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76438/new/ https://reviews.llvm.org/D76438 ___

[PATCH] D76438: ConstantExpr cached APValues if present for constant evaluation

wchilders marked 2 inline comments as done. wchilders added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:7325-7329 + // Override to perform additional checks to ensure the cached APValue + // is actually an LValue. + bool VisitConstantExpr(const ConstantExpr

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

zoecarver updated this revision to Diff 251758. zoecarver added a comment. Fix based on review: - update comments - return 64 for Core2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74918/new/ https://reviews.llvm.org/D74918 Files:

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

zoecarver marked 2 inline comments as done. zoecarver added a comment. I've made the suggested changes. Is there a consensus that this should be moved to LLVM? I think it's fairly clang-specific (given the use case). We can also always move it to LLVM if the need arises in the future.

[clang] dc4259d - [c++20] Further extend the set of comparisons broken by C++20 that we

Author: Richard Smith Date: 2020-03-20T14:22:48-07:00 New Revision: dc4259d5a38409e65b60266a7df0f03c3b91a151 URL: https://github.com/llvm/llvm-project/commit/dc4259d5a38409e65b60266a7df0f03c3b91a151 DIFF: https://github.com/llvm/llvm-project/commit/dc4259d5a38409e65b60266a7df0f03c3b91a151.diff

[clang] 079c6dd - Correctly initialize the DW_AT_comp_dir attribute of Clang module skeleton CUs

Author: Adrian Prantl Date: 2020-03-20T14:18:14-07:00 New Revision: 079c6ddaf5344eb501652c2a874e3e4e8c466c2b URL: https://github.com/llvm/llvm-project/commit/079c6ddaf5344eb501652c2a874e3e4e8c466c2b DIFF: https://github.com/llvm/llvm-project/commit/079c6ddaf5344eb501652c2a874e3e4e8c466c2b.diff

[clang] 97f490d - Don't set the isOptimized flag in module skeleton DICompileUnits.

Author: Adrian Prantl Date: 2020-03-20T14:18:15-07:00 New Revision: 97f490d87b226b1deade74ec93b4378fb28d26cc URL: https://github.com/llvm/llvm-project/commit/97f490d87b226b1deade74ec93b4378fb28d26cc DIFF: https://github.com/llvm/llvm-project/commit/97f490d87b226b1deade74ec93b4378fb28d26cc.diff

[PATCH] D76527: Don't export symbols from clang/opt/llc if plugins are disabled.

efriedma created this revision. efriedma added reviewers: MaskRay, serge-sans-paille, Meinersbur. Herald added subscribers: cfe-commits, dexonsmith, mgorny. Herald added a project: clang. The only reason we export symbols from these tools is to support plugins; if we don't have plugins,

[PATCH] D76525: Expose cache line size in __builtin_get_cpu_cache_line_size

zoecarver created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. zoecarver added reviewers: jfb, EricWF, efriedma, jyknight, echristo, __simt__. Herald added a subscriber: dexonsmith. This patch creates the __builtin_get_cpu_cache_line_size to wrap the cpu

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

zoecarver added a comment. In D76525 I've added a builtin that uses this API. We can use that builtin in libc++. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74918/new/ https://reviews.llvm.org/D74918

[PATCH] D76438: ConstantExpr cached APValues if present for constant evaluation

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/AST/ExprConstant.cpp:7325-7329 + // Override to perform additional checks to ensure the cached APValue + // is actually an LValue. + bool

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc updated this revision to Diff 251746. mibintc added a comment. This revision fixes the clang-tidy,clang-format and removes the redundant accessors. Ready for your review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76384/new/

[PATCH] D73245: Depend stddef.h to provide max_align_t for C++11 and provide better fallback in

joerg marked 5 inline comments as done. joerg added inline comments. Comment at: libcxx/include/stddef.h:58 !defined(__DEFINED_max_align_t) && !defined(__NetBSD__) typedef long double max_align_t; #endif ldionne wrote: > Why do we need this at all

[PATCH] D74387: [SYCL] Defer __float128 type usage diagnostics

Fznamznon updated this revision to Diff 251735. Fznamznon added a comment. Herald added a subscriber: mgorny. Added diagnosing of __float128 type usage. See the summary of revision for details. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76520: [CUDA][HIP] Add -Xarch_device and -Xarch_host options

tra added a reviewer: echristo. tra added a comment. Does it handle options with values? E.g. if I want to pass `-mframe-pointer=none` ? I vaguely recall the current -Xarch_* implementation had some limitations. It may be worth adding a test for that. CHANGES SINCE LAST ACTION

[PATCH] D76452: Use LLD by default for Android.

srhines accepted this revision. srhines added a comment. This revision is now accepted and ready to land. Thanks, Dan, for setting this up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76452/new/ https://reviews.llvm.org/D76452

[PATCH] D76438: ConstantExpr cached APValues if present for constant evaluation

wchilders updated this revision to Diff 251732. wchilders added a comment. Updated to assume LValue `ConstantExpr`s have LValue `APValue`s, with verification in debug mode. Additionally, added a missing LValue -> RValue conversion for `VerifyIntegerConstantExpression`. CHANGES SINCE LAST

[PATCH] D76438: ConstantExpr cached APValues if present for constant evaluation

wchilders marked 2 inline comments as done. wchilders added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:7329 + if (Result.isLValue()) +return Success(Result, E); +} rsmith wrote: > wchilders wrote: > > rsmith wrote: > > >

[clang] 9b95929 - [OPENMP50]Do not allow several scan directives in the same parent

Author: Alexey Bataev Date: 2020-03-20T15:45:31-04:00 New Revision: 9b95929a26e133bc3cae9f29f91e8e351d233840 URL: https://github.com/llvm/llvm-project/commit/9b95929a26e133bc3cae9f29f91e8e351d233840 DIFF: https://github.com/llvm/llvm-project/commit/9b95929a26e133bc3cae9f29f91e8e351d233840.diff

[PATCH] D76520: [CUDA][HIP] Add -Xarch_device and -Xarch_host options

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added a reviewer: jdoerfert. The argument after -Xarch_device will be added to the arguments for CUDA/HIP device compilation and will be removed for host compilation. The argument after -Xarch_host will be added to the arguments

[PATCH] D72810: [LifetimeAnalysis] Add support for lifetime annotations on functions

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/LifetimeAttr.h:163 +// Maps each annotated entity to a lifetime set. +using LifetimeContracts = std::map; + xazax.hun wrote: > aaron.ballman wrote: > > xazax.hun wrote: > > > gribozavr2

[PATCH] D76365: [cuda][hip] Add CUDA builtin surface/texture reference support.

tra added inline comments. Comment at: clang/lib/CodeGen/CGCUDARuntime.h:51 +}; +unsigned Kind : 2; +unsigned Extern : 1; This should be `DeviceVarKind` Comment at: clang/lib/CodeGen/CGCUDARuntime.h:53 +unsigned Extern : 1; +

[PATCH] D76395: [clang-tidy] Merge common code between llvmlibc-restrict-system-libc-headers and portability-restrict-system-includes

PaulkaToast updated this revision to Diff 251713. PaulkaToast marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76395/new/ https://reviews.llvm.org/D76395 Files: clang-tools-extra/clang-tidy/llvmlibc/CMakeLists.txt

[PATCH] D76395: [clang-tidy] Merge common code between llvmlibc-restrict-system-libc-headers and portability-restrict-system-includes

PaulkaToast added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76395/new/ https://reviews.llvm.org/D76395 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

manojgupta added a comment. Thanks for the quick fix, verified that the crash is fixed on trunk. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://reviews.llvm.org/D73534 ___ cfe-commits mailing list

[PATCH] D76510: [analyzer] Change the default output type to PD_TEXT_MINIMAL, error if an output loc is missing for PathDiagConsumers that need it

baloghadamsoftware accepted this revision. baloghadamsoftware added a comment. This revision is now accepted and ready to land. Basically LGTM, but please wait for @NoQ or someone for the compatibility questions. Comment at:

[clang] 06dea73 - [OPENMP50]Initial support for inclusive clause.

Author: Alexey Bataev Date: 2020-03-20T14:20:38-04:00 New Revision: 06dea73307e75f0227ba24cab2adf2e4dad62b88 URL: https://github.com/llvm/llvm-project/commit/06dea73307e75f0227ba24cab2adf2e4dad62b88 DIFF: https://github.com/llvm/llvm-project/commit/06dea73307e75f0227ba24cab2adf2e4dad62b88.diff

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

vsk added a comment. @manojgupta I apologize for not catching this earlier. The issue should really be fixed by 636665331bbd4c369a9f33c4d35fb9a863c94646 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. In D73534#1933985 , @djtodoro wrote: > Oh sorry, I thought it all has been fixed, since all the tests pass. > > We should revert the D75036 until we fix > all the issues. @dstenb do you agree?

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. Oh sorry, I thought it all has been fixed, since all the tests pass. We should revert the D75036 until we fix all the issues. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://reviews.llvm.org/D73534

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

vsk added a comment. In D73534#1933988 , @djtodoro wrote: > In D73534#1933985 , @djtodoro wrote: > > > Oh sorry, I thought it all has been fixed, since all the tests pass. > > > > We should revert the D75036

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. In D73534#1934105 , @vsk wrote: > In D73534#1933988 , @djtodoro wrote: > > > In D73534#1933985 , @djtodoro > > wrote: > > > > > Oh sorry, I

[PATCH] D31343: Add an attribute plugin example

aaron.ballman added inline comments. Comment at: clang/examples/Attribute/Attribute.cpp:35 +Spellings.push_back({ParsedAttr::AS_GNU, "example"}); +Spellings.push_back({ParsedAttr::AS_CXX11, "::example"}); +Spellings.push_back({ParsedAttr::AS_CXX11,

[PATCH] D31342: Add ParsedAttrInfo::handleDeclAttribute

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31342/new/ https://reviews.llvm.org/D31342 ___ cfe-commits mailing

[PATCH] D75661: Remove SequentialType from the type heirarchy.

ctetreau added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:1078 } + // FIXME: Do we need to handle tail padding in vectors? return constant; efriedma wrote: > ctetreau wrote: > > The fact that you have to ask this question tells me that you

[PATCH] D76395: [clang-tidy] Merge common code between llvmlibc-restrict-system-libc-headers and portability-restrict-system-includes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some small nits! Comment at: clang-tools-extra/clang-tidy/llvmlibc/CMakeLists.txt:15 clangTooling + clangTidyPortabilityModule )

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc marked 3 inline comments as done. mibintc added a comment. In D76384#1929774 , @mibintc wrote: > There's a bug in this patch that i haven't solved yet. I think it's just 1 > bug. The bug is that the AST statement visitor is going to the

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

fghanim added a comment. My comments were nits so. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75591/new/ https://reviews.llvm.org/D75591 ___ cfe-commits mailing list

[PATCH] D76504: [clang] Fix crash during template sema checking

efriedma added a comment. Please post patches against master, not previous versions of the patch. I think you want to check isValueDependent(); isInstantiationDependent() includes some other stuff that isn't relevant here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75661: Remove SequentialType from the type heirarchy.

efriedma marked 2 inline comments as done. efriedma added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:1059 +llvm::Type *ElemTy = ArrayTy->getElementType(); +bool ZeroInitializer = constant->isNullValue(); llvm::Constant *OpValue, *PaddedOp;

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc updated this revision to Diff 251699. mibintc retitled this revision from "Move FPFeatures from BinaryOperator bitfields to Trailing storage - preliminary" to "Move FPFeatures from BinaryOperator bitfields to Trailing storage". mibintc added a comment. This revision has been rebased,

[PATCH] D76377: Correctly initialize the DW_AT_comp_dir attribute of Clang module skeleton CUs

aprantl marked an inline comment as done. aprantl added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2499 +DIB.createFile(Mod.getModuleName(), TheCU->getDirectory()), +TheCU->getProducer(), false, StringRef(), 0, Mod.getASTFile(), +

[PATCH] D52898: [Porting MergeSimilarFunctions 2/n] Changes to DataLayout

vish99 updated this revision to Diff 251696. vish99 added a comment. Changes to merge the 5 patches together Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52898/new/ https://reviews.llvm.org/D52898 Files:

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

manojgupta added a comment. Still causing a crash using a previously supplied test https://bugs.chromium.org/p/chromium/issues/detail?id=1061533#c7. Any reason this was not tested with a previous repro? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/

[PATCH] D76509: [analyzer][NFC] Move the text output type to its own file, move code to PathDiagnosticConsumer creator functions

Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:148 void DigestAnalyzerOptions() { -if (Opts->AnalysisDiagOpt != PD_NONE) { - // Create the PathDiagnosticConsumer. -

[clang] f59bb40 - Attempt to fix failing build-bot with [-Werror,-Wcovered-switch-default]

Author: Gabor Marton Date: 2020-03-20T18:04:55+01:00 New Revision: f59bb40e361c061adaa19e988f1f5769d3b8fac7 URL: https://github.com/llvm/llvm-project/commit/f59bb40e361c061adaa19e988f1f5769d3b8fac7 DIFF: https://github.com/llvm/llvm-project/commit/f59bb40e361c061adaa19e988f1f5769d3b8fac7.diff

[PATCH] D75063: [analyzer] StdLibraryFunctionsChecker: Add NotNull Arg Constraint

This revision was automatically updated to reflect the committed changes. Closed by commit rGededa65d559d: [analyzer] StdLibraryFunctionsChecker: Add NotNull Arg Constraint (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76361: [Analyzer] Iterator Modeling - Model `std::advance()`, `std::prev()` and `std::next()`

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:221 +if (Handler) { + if (!C.wasInlined) { +if (Call.getNumArgs() > 1) {

[PATCH] D76504: [clang] Fix crash during template sema checking

gchatelet updated this revision to Diff 251671. gchatelet marked an inline comment as done. gchatelet added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76504/new/ https://reviews.llvm.org/D76504 Files:

[PATCH] D76435: [[Clang CallGraph]] CallGraph should still record calls to decls.

lebedev.ri added a comment. Whoops, i did not see cfe-commits again got sidestepped. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76435/new/ https://reviews.llvm.org/D76435 ___ cfe-commits mailing

[PATCH] D75063: [analyzer] StdLibraryFunctionsChecker: Add NotNull Arg Constraint

martong added a comment. In D75063#1923780 , @NoQ wrote: > This is basically a shorthand for "outside [0, 0]", right? I don't mind ^.^ Yeah, and my first attempt was exactly to implement this with ranges. However, it failed when I realized that we

[PATCH] D76377: Correctly initialize the DW_AT_comp_dir attribute of Clang module skeleton CUs

probinson added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2499 +DIB.createFile(Mod.getModuleName(), TheCU->getDirectory()), +TheCU->getProducer(), false, StringRef(), 0, Mod.getASTFile(), +llvm::DICompileUnit::FullDebug, Signature);

[PATCH] D75063: [analyzer] StdLibraryFunctionsChecker: Add NotNull Arg Constraint

martong updated this revision to Diff 251674. martong marked 9 inline comments as done. martong added a comment. - Use report/bugpath verify prefixes in test - Address review nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75063/new/

[PATCH] D76509: [analyzer][NFC] Move the text output type to its own file, move code to PathDiagnosticConsumer creator functions

Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, baloghadamsoftware, martong, balazske, rnkovacs, dcoughlin, steakhal. Szelethus added a project: clang. Herald added subscribers: cfe-commits, ASDenysPetrov, usaxena95, Charusso, gamesh411, dkrupp, donat.nagy, kadircet,

[PATCH] D76510: [analyzer] Change the default output type to PD_TEXT_MINIMAL, error if an output loc is missing for PathDiagConsumers that need it

Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, baloghadamsoftware, rnkovacs, martong, balazske, dcoughlin. Szelethus added a project: clang. Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho,

[PATCH] D76504: [clang] Fix crash during template sema checking

gchatelet added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:1655 +clang::Expr *SizeOp = TheCall->getArg(2); +// If any arg is instantiation dependent we bail out. +if (DstOp->isInstantiationDependent() || courbet wrote: > Are the

[PATCH] D76323: [AST] Fix handling of long double and bool in __builtin_bit_cast

jfb added a comment. Maybe you should test `nullptr` as well, given that it's all padding? Comment at: clang/test/SemaCXX/constexpr-builtin-bit-cast.cpp:407 + +constexpr bool test_bad_bool = bit_cast('A'); // expected-error {{must be initialized by a constant expression}}

  1   2   >