[PATCH] D74183: [IRGen] Add an alignment attribute to underaligned sret parameters

rjmccall added a comment. Yeah, if emitting alignment assumptions in inlining is causing regressions when frontends provide better information, those assumptions need to be reverted until they can be fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74183: [IRGen] Add an alignment attribute to underaligned sret parameters

nikic added a comment. In D74183#1941741 , @efriedma wrote: > If it's just tramp3d-v4, I'm not that concerned... but that's a weird result. > On x86 in particular, alignment markings have almost no effect on > optimization, generally. I've just

[PATCH] D76725: [clangd] Build ASTs only with fresh preambles or after building a new preamble

kadircet updated this revision to Diff 252841. kadircet added a comment. - Invalidate cached AST in case of preamble/input changes when building golden ASTs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76725/new/ https://reviews.llvm.org/D76725

[PATCH] D76850: clang-format: Fix pointer alignment for overloaded operators (PR45107)

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76850/new/ https://reviews.llvm.org/D76850 ___ cfe-commits mailing

[PATCH] D76850: clang-format: Fix pointer alignment for overloaded operators (PR45107)

hans created this revision. hans added reviewers: sammccall, MyDeveloperDay, thakis. MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM This fixes a regression from D69573 which broke

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MyDeveloperDay added a comment. Could the default be `Style.IndentExternBlock = Style.BraceWrapping.AfterExternBlock` Then it would match the prior behaviour off AddLevel being `true` when AfterExternBlock is `true` extern "C" { int a; } extern "C" { int a; } CHANGES

[PATCH] D74054: [clangd] Include the underlying decls in go-to-definition.

sammccall added a comment. Sorry about being late coming back to this. Comment at: clang-tools-extra/clangd/XRefs.cpp:307 +// alias. +if (llvm::isa(D)) { + llvm::for_each(targetDecl(ast_type_traits::DynTypedNode::create(*D), I believe this is

[PATCH] D76696: [AST] Build recovery expressions by default for C++.

ebevhan added a comment. We found an odd case in our downstream fork after this patch landed. We have a diagnostic in `CheckVariableDeclarationType` that checks for automatic variables that are too large for the stack address space, and it chokes on the testcase

[PATCH] D76830: [Analyzer][MallocChecker] No warning for kfree of ZERO_SIZE_PTR.

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Herald added a subscriber: rnkovacs. LGTM! Comment at: clang/test/Analysis/kmalloc-linux-1.c:15 + +// FIXME: malloc checker expects kfree with 2 arguments, is this

[PATCH] D76546: [Hexagon] MaxAtomicPromoteWidth, MaxAtomicInlineWidth are not getting set.

bcain accepted this revision. bcain added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76546/new/ https://reviews.llvm.org/D76546 ___

[PATCH] D76365: [cuda][hip] Add CUDA builtin surface/texture reference support.

hliao updated this revision to Diff 252828. hliao added a comment. Rebase to the master code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76365/new/ https://reviews.llvm.org/D76365 Files: clang/include/clang/AST/Type.h

[PATCH] D76772: [AMDGPU] Add __builtin_amdgcn_workgroup_size_x/y/z

arsenm accepted this revision. arsenm added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/CodeGenCUDA/amdgpu-workgroup-size.cu:2 +// RUN: %clang_cc1 -triple amdgcn-amd-amdhsa \ +// RUN: -fcuda-is-device -emit-llvm -o - -x hip %s \

[PATCH] D76663: [clangd] Support new semanticTokens request from LSP 3.16.

hokein added a comment. In D76663#1942273 , @sammccall wrote: > For some context here, I was doing some digging as Heyward Fann is looking at > hooking up our existing syntax highlighting to coc.nvim, and he and Jack Guo > (of

[PATCH] D75685: Add MS Mangling for OpenCL Pipe types, add mangling test.

Anastasia added inline comments. Comment at: clang/test/CodeGenOpenCL/pipe_types_mangling.cl:12 +// WINDOWS: define dso_local void @"?test1@@YAXU?$ocl_pipe@H$00@__clang@@@Z" +// UNMANGLED: define {{.*}}void @test1( +} erichkeane wrote: > Anastasia wrote: > >

[PATCH] D75685: Add MS Mangling for OpenCL Pipe types, add mangling test.

Anastasia added inline comments. Comment at: clang/test/CodeGenOpenCL/pipe_types_mangling.cl:12 +// WINDOWS: define dso_local void @"?test1@@YAXU?$ocl_pipe@H$00@__clang@@@Z" +// UNMANGLED: define {{.*}}void @test1( +} Anastasia wrote: > erichkeane wrote: > >

[PATCH] D76830: [Analyzer][MallocChecker] No warning for kfree of ZERO_SIZE_PTR.

balazske updated this revision to Diff 252804. balazske added a comment. Improved documentation and handling of `KernelZeroSizePtrValue`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76830/new/ https://reviews.llvm.org/D76830 Files:

[PATCH] D76830: [Analyzer][MallocChecker] No warning for kfree of ZERO_SIZE_PTR.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:396 + /// yes was the value obtained or not. + mutable Optional> KernelZeroSizePtrValue; + martong wrote: > balazske

[PATCH] D75286: [clangd] Handle clang-tidy suppression comments for diagnostics inside macro expansions

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Sorry for taking a while to come back to this again. A bit chaotic right now :-) Looks good, some further simplification possible. Comment at:

[PATCH] D73649: [CodeComplete] Member completion for concept-constrained types.

kadircet added inline comments. Comment at: clang/include/clang/Sema/Scope.h:323 /// declared in. - bool isDeclScope(Decl *D) { -return DeclsInScope.count(D) != 0; - } + bool isDeclScope(const Decl *D) { return DeclsInScope.count(D) != 0; } also mark

[clang] 13dc21e - [AST] Make thinlto testcase robust to 159a9f7e76307734bcdcae3357640e42e0733194

Author: Sam McCall Date: 2020-03-26T12:47:39+01:00 New Revision: 13dc21e84168b73c0157fd909ba7f130f06ae0f5 URL: https://github.com/llvm/llvm-project/commit/13dc21e84168b73c0157fd909ba7f130f06ae0f5 DIFF: https://github.com/llvm/llvm-project/commit/13dc21e84168b73c0157fd909ba7f130f06ae0f5.diff

[clang] 38798d0 - Revert "[AST] Fix thinlto testcase missed in 159a9f7e76307734bcdcae3357640e42e0733194"

Author: Sam McCall Date: 2020-03-26T12:38:33+01:00 New Revision: 38798d03061ad400e0b900288cb9613907b2011a URL: https://github.com/llvm/llvm-project/commit/38798d03061ad400e0b900288cb9613907b2011a DIFF: https://github.com/llvm/llvm-project/commit/38798d03061ad400e0b900288cb9613907b2011a.diff

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 252791. oontvoo added a comment. Handle includes/import from outer mods Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/HeaderSearch.h

[PATCH] D76830: [Analyzer][MallocChecker] No warning for kfree of ZERO_SIZE_PTR.

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:396 + /// yes was the value obtained or not. + mutable Optional> KernelZeroSizePtrValue; + balazske wrote: > martong wrote: > > Which one is referred to the lazy

[PATCH] D76830: [Analyzer][MallocChecker] No warning for kfree of ZERO_SIZE_PTR.

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:1687 + if (ArgValKnown) { +if (!KernelZeroSizePtrValue) + KernelZeroSizePtrValue = balazske wrote: > martong wrote: > > martong wrote: > > > This is a bit

[PATCH] D76770: [CodeComplete] Don't replace the rest of line in #include completion.

This revision was automatically updated to reflect the committed changes. Closed by commit rG297a9dac43f3: [CodeComplete] Dont replace the rest of line in #include completion. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76830: [Analyzer][MallocChecker] No warning for kfree of ZERO_SIZE_PTR.

balazske marked 2 inline comments as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:396 + /// yes was the value obtained or not. + mutable Optional> KernelZeroSizePtrValue; + martong wrote: > Which one is

[PATCH] D74324: Tools emit the bug report URL on crash

This revision was automatically updated to reflect the committed changes. Closed by commit rGa945037e8fd0: Tools emit the bug report URL on crash (authored by gbreynoo). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] a945037 - Tools emit the bug report URL on crash

Author: gbreynoo Date: 2020-03-26T10:26:59Z New Revision: a945037e8fd0c30e250a62211469eea6765a36ae URL: https://github.com/llvm/llvm-project/commit/a945037e8fd0c30e250a62211469eea6765a36ae DIFF: https://github.com/llvm/llvm-project/commit/a945037e8fd0c30e250a62211469eea6765a36ae.diff LOG:

[clang-tools-extra] 7055cd4 - Remove extra ';', NFC

Author: Karl-Johan Karlsson Date: 2020-03-26T11:23:59+01:00 New Revision: 7055cd42b5ffc88757eb3d12192047abe63a3714 URL: https://github.com/llvm/llvm-project/commit/7055cd42b5ffc88757eb3d12192047abe63a3714 DIFF:

[clang-tools-extra] 297a9da - [CodeComplete] Don't replace the rest of line in #include completion.

Author: Haojian Wu Date: 2020-03-26T11:03:04+01:00 New Revision: 297a9dac43f31cdbc811de5ec63ad20812433f98 URL: https://github.com/llvm/llvm-project/commit/297a9dac43f31cdbc811de5ec63ad20812433f98 DIFF: https://github.com/llvm/llvm-project/commit/297a9dac43f31cdbc811de5ec63ad20812433f98.diff

[PATCH] D76831: [AST] Preserve the DeclRefExpr when it refers to an invalid decl.

hokein created this revision. hokein added reviewers: sammccall, adamcz. Herald added a project: clang. Previously, clang refused to build the AST nodes for them. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D76831 Files: clang/lib/AST/ComputeDependence.cpp

[PATCH] D69585: PerformPendingInstatiations() already in the PCH

llunak added a comment. In D69585#1942431 , @rsmith wrote: > This needs to be done behind a flag. It's an explicit design goal that > compilation behavior using a PCH or precompiled preamble behaves identically > to compilation not using a PCH /

[PATCH] D76830: [Analyzer][MallocChecker] No warning for kfree of ZERO_SIZE_PTR.

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:1687 + if (ArgValKnown) { +if (!KernelZeroSizePtrValue) + KernelZeroSizePtrValue = martong wrote: > This is a bit confusing for me. Perhaps alternatively we

[PATCH] D76062: [PATCH] [ARM] ARMv8.6-a command-line + BFloat16 Asm Support

This revision was automatically updated to reflect the committed changes. Closed by commit rG71ae267d1f41: [PATCH] [ARM] ARMv8.6-a command-line + BFloat16 Asm Support (authored by stuij). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76062/new/

[PATCH] D76830: [Analyzer][MallocChecker] No warning for kfree of ZERO_SIZE_PTR.

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:396 + /// yes was the value obtained or not. + mutable Optional> KernelZeroSizePtrValue; + Which one is referred to the lazy initialization? The inner or the outer?

[clang] 4bd1d55 - [AST] Fix thinlto testcase missed in 159a9f7e76307734bcdcae3357640e42e0733194

Author: Sam McCall Date: 2020-03-26T10:28:54+01:00 New Revision: 4bd1d55884aaeb582aa8f313e45823fe0f60b32d URL: https://github.com/llvm/llvm-project/commit/4bd1d55884aaeb582aa8f313e45823fe0f60b32d DIFF: https://github.com/llvm/llvm-project/commit/4bd1d55884aaeb582aa8f313e45823fe0f60b32d.diff

[clang] 71ae267 - [PATCH] [ARM] ARMv8.6-a command-line + BFloat16 Asm Support

Author: Ties Stuij Date: 2020-03-26T09:17:20Z New Revision: 71ae267d1f4117473eb00d9fd3391733b843ca3c URL: https://github.com/llvm/llvm-project/commit/71ae267d1f4117473eb00d9fd3391733b843ca3c DIFF: https://github.com/llvm/llvm-project/commit/71ae267d1f4117473eb00d9fd3391733b843ca3c.diff LOG:

[PATCH] D76801: [AST] Print a> without extra spaces in C++11 or later.

This revision was automatically updated to reflect the committed changes. Closed by commit rG159a9f7e7630: [AST] Print abc without extra spaces in C++11 or later. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76801/new/

[PATCH] D73369: [clangd] Simplify "preferred" vs "definition" logic a bit in XRefs AST code.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6324912592a1: [clangd] Simplify preferred vs definition logic a bit in XRefs AST code. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76830: [Analyzer][MallocChecker] No warning for kfree of ZERO_SIZE_PTR.

balazske created this revision. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: clang. balazske added

[PATCH] D76830: [Analyzer][MallocChecker] No warning for kfree of ZERO_SIZE_PTR.

balazske added a comment. FIXME: There is a test file "kmalloc-linux.c" but it seems to be non-maintained and buggy (has no //-verify// option so it passes always but produces multiple warnings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75514: [Analyzer] Only add container note tags to the operations of the affected container

This revision was automatically updated to reflect the committed changes. Closed by commit rG1a27d63a8891: [Analyzer] Only add container note tags to the operations of the affected… (authored by baloghadamsoftware). Herald added a subscriber: ASDenysPetrov. Changed prior to commit:

[PATCH] D76830: [Analyzer][MallocChecker] No warning for kfree of ZERO_SIZE_PTR.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/CheckerHelpers.cpp:146 return IntValue.getSExtValue(); } The function was changed to get the numeric value from the end of the macro in

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 252768. oontvoo added a comment. Handle textual headers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/HeaderSearch.h

[PATCH] D76770: [CodeComplete] Don't replace the rest of line in #include completion.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. In D76770#1943077 , @hokein wrote: > yes, it has a regression, but we don't change the behavior for the above > case. A regression case is like

[clang-tools-extra] 6324912 - [clangd] Simplify "preferred" vs "definition" logic a bit in XRefs AST code.

Author: Sam McCall Date: 2020-03-26T09:52:48+01:00 New Revision: 6324912592a1ff8d672e55e02ca63f769decb154 URL: https://github.com/llvm/llvm-project/commit/6324912592a1ff8d672e55e02ca63f769decb154 DIFF: https://github.com/llvm/llvm-project/commit/6324912592a1ff8d672e55e02ca63f769decb154.diff

[clang] 159a9f7 - [AST] Print a> without extra spaces in C++11 or later.

Author: Sam McCall Date: 2020-03-26T09:53:54+01:00 New Revision: 159a9f7e76307734bcdcae3357640e42e0733194 URL: https://github.com/llvm/llvm-project/commit/159a9f7e76307734bcdcae3357640e42e0733194 DIFF: https://github.com/llvm/llvm-project/commit/159a9f7e76307734bcdcae3357640e42e0733194.diff

[clang] 1a27d63 - [Analyzer] Only add container note tags to the operations of the affected container

Author: Adam Balogh Date: 2020-03-26T09:44:16+01:00 New Revision: 1a27d63a8891076ad9176f1a70f372003bc55c2f URL: https://github.com/llvm/llvm-project/commit/1a27d63a8891076ad9176f1a70f372003bc55c2f DIFF: https://github.com/llvm/llvm-project/commit/1a27d63a8891076ad9176f1a70f372003bc55c2f.diff

[PATCH] D76770: [CodeComplete] Don't replace the rest of line in #include completion.

hokein added a comment. In D76770#1941603 , @sammccall wrote: > Does this regress the case where you complete a file rather than a directory? > e.g. `#include "foo/^one.h"` > If you select "two.h", then we definitely want to replace "one.h", right?

[PATCH] D53272: Add target requirement to profile remap test.

yroux closed this revision. yroux added a comment. Herald added a subscriber: danielkiss. This was closed by commit r344593 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53272/new/ https://reviews.llvm.org/D53272

[PATCH] D76572: Replace `T(x)` with `reinterpret_cast(x)` everywhere it means reinterpret_cast. No functional change

jhenderson added a comment. In D76572#1942024 , @Quuxplusone wrote: > Btw, @jhenderson and @rsmith, if you wanted to land your own files' pieces of > this patch while waiting on whoever-it-is to approve the pieces in other > files, that'd be cool. As I

[PATCH] D76801: [AST] Print a> without extra spaces in C++11 or later.

kadircet accepted this revision. kadircet marked an inline comment as done. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks ! Comment at: clang/unittests/AST/DeclPrinterTest.cpp:1161 "A", -"Z > A")); -// Should be: with

[PATCH] D76764: [AST] Build recovery expressions for nonexistent member exprs.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa9ab11d40830: [AST] Build recovery expressions for nonexistent member exprs. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76764/new/

[PATCH] D73720: [Analyzer] Use note tags to track container begin and and changes

This revision was automatically updated to reflect the committed changes. Closed by commit rGa3f4d17a1a53: [Analyzer] Use note tags to track container begin and and changes (authored by baloghadamsoftware). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] a9ab11d - [AST] Build recovery expressions for nonexistent member exprs.

Author: Haojian Wu Date: 2020-03-26T08:50:33+01:00 New Revision: a9ab11d40830cc01c3a6ff97633140e8bd1e431e URL: https://github.com/llvm/llvm-project/commit/a9ab11d40830cc01c3a6ff97633140e8bd1e431e DIFF: https://github.com/llvm/llvm-project/commit/a9ab11d40830cc01c3a6ff97633140e8bd1e431e.diff

[clang] a3f4d17 - [Analyzer] Use note tags to track container begin and and changes

Author: Adam Balogh Date: 2020-03-26T07:56:28+01:00 New Revision: a3f4d17a1a53c4144a5bb7c14620a5d2790f36ea URL: https://github.com/llvm/llvm-project/commit/a3f4d17a1a53c4144a5bb7c14620a5d2790f36ea DIFF: https://github.com/llvm/llvm-project/commit/a3f4d17a1a53c4144a5bb7c14620a5d2790f36ea.diff

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 252760. oontvoo added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/HeaderSearch.h

[PATCH] D76365: [cuda][hip] Add CUDA builtin surface/texture reference support.

hliao marked an inline comment as done. hliao added inline comments. Comment at: clang/lib/Headers/__clang_cuda_runtime_wrapper.h:82-94 #undef __CUDACC__ #if CUDA_VERSION < 9000 #define __CUDABE__ #else +#define __CUDACC__ #define __CUDA_LIBDEVICE__ #endif

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 252761. oontvoo added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/HeaderSearch.h

[PATCH] D76365: [cuda][hip] Add CUDA builtin surface/texture reference support.

hliao updated this revision to Diff 252758. hliao added a comment. Fix windows build and revise header change. - When including `drivers_types.h` or `host_defines.h` with `__CUDACC__`, the only difference is the additional attributes added. No additional change. - After including

<    1   2