[PATCH] D77028: [NFC] Refactor DeferredDiagsEmitter and skip redundant visit

yaxunl created this revision. yaxunl added reviewers: rjmccall, ABataev. Move function emitDeferredDiags from Sema to DeferredDiagsEmitter since it is only used by DeferredDiagsEmitter. Also record number of diagnostics triggered by each function and skip a function if it is known not to emit

[clang] 9a7eda1 - PR45350: Handle unsized array CXXConstructExprs in constant evaluation

Author: Richard Smith Date: 2020-03-29T19:33:56-07:00 New Revision: 9a7eda1bece887ca9af085d79fe6e4fb8826dcda URL: https://github.com/llvm/llvm-project/commit/9a7eda1bece887ca9af085d79fe6e4fb8826dcda DIFF: https://github.com/llvm/llvm-project/commit/9a7eda1bece887ca9af085d79fe6e4fb8826dcda.diff

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel updated this revision to Diff 253470. atmnpatel added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75591/new/ https://reviews.llvm.org/D75591 Files:

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel updated this revision to Diff 253463. atmnpatel added a comment. Added error based on OpenMP version. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75591/new/ https://reviews.llvm.org/D75591 Files:

[PATCH] D77022: [analyzer] Use IgnoreImpCasts() instead of reimplementing it.

NoQ added a comment. Fair! Comment at: clang/lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp:512 + return E->IgnoreImpCasts(); } Charusso wrote: > I think it would make sense to remove the helper-function completely. (Being > used 2 times.) Yup.

[clang] 6e0afb5 - [ARMMVE] Create fewer temporary SmallVectors

Author: Benjamin Kramer Date: 2020-03-29T22:31:26+02:00 New Revision: 6e0afb5f108fe0570268978f4b32a0c8b4a43ee1 URL: https://github.com/llvm/llvm-project/commit/6e0afb5f108fe0570268978f4b32a0c8b4a43ee1 DIFF:

[clang] a5458bb - Don't claim template names that name non-templates are undeclared.

Author: Richard Smith Date: 2020-03-29T13:15:30-07:00 New Revision: a5458bb0d6b1c35c7dcca4f339e77c40f5fc5e06 URL: https://github.com/llvm/llvm-project/commit/a5458bb0d6b1c35c7dcca4f339e77c40f5fc5e06 DIFF: https://github.com/llvm/llvm-project/commit/a5458bb0d6b1c35c7dcca4f339e77c40f5fc5e06.diff

[PATCH] D77023: clang-format fixes in ClangTidyDiagnosticConsumer.cpp and DiagnosticsTets.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rG15f1fe1506f5: clang-format fixes in ClangTidyDiagnosticConsumer.cpp and DiagnosticsTets.cpp (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75286: [clangd] Handle clang-tidy suppression comments for diagnostics inside macro expansions

This revision was automatically updated to reflect the committed changes. Closed by commit rGb9d9968f63ab: [clangd] Handle clang-tidy suppression comments for diagnostics inside macro… (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] b9d9968 - [clangd] Handle clang-tidy suppression comments for diagnostics inside macro expansions

Author: Nathan Ridge Date: 2020-03-29T15:19:13-04:00 New Revision: b9d9968f63ab8f24b300c69be11eadda3d405ac5 URL: https://github.com/llvm/llvm-project/commit/b9d9968f63ab8f24b300c69be11eadda3d405ac5 DIFF: https://github.com/llvm/llvm-project/commit/b9d9968f63ab8f24b300c69be11eadda3d405ac5.diff

[clang-tools-extra] 15f1fe1 - clang-format fixes in ClangTidyDiagnosticConsumer.cpp and DiagnosticsTets.cpp

Author: Nathan Ridge Date: 2020-03-29T15:19:09-04:00 New Revision: 15f1fe1506f5e860409fddd8e62ed5508855ff79 URL: https://github.com/llvm/llvm-project/commit/15f1fe1506f5e860409fddd8e62ed5508855ff79 DIFF: https://github.com/llvm/llvm-project/commit/15f1fe1506f5e860409fddd8e62ed5508855ff79.diff

[PATCH] D75286: [clangd] Handle clang-tidy suppression comments for diagnostics inside macro expansions

nridge updated this revision to Diff 253446. nridge added a comment. Address last review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75286/new/ https://reviews.llvm.org/D75286 Files:

[PATCH] D77023: clang-format fixes in ClangTidyDiagnosticConsumer.cpp and DiagnosticsTets.cpp

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D77023 Files: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp

[clang] fe0723d - Fix -Wdocumentation warning. NFC.

Author: Simon Pilgrim Date: 2020-03-29T19:51:37+01:00 New Revision: fe0723dc9d45acfa4511961b208b7817b09297ec URL: https://github.com/llvm/llvm-project/commit/fe0723dc9d45acfa4511961b208b7817b09297ec DIFF: https://github.com/llvm/llvm-project/commit/fe0723dc9d45acfa4511961b208b7817b09297ec.diff

[PATCH] D77022: [analyzer] Use IgnoreImpCasts() instead of reimplementing it.

Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp:512 + return E->IgnoreImpCasts(); } I think it would make sense to remove the helper-function completely. (Being used 2 times.) CHANGES SINCE LAST ACTION

[PATCH] D77022: Use IgnoreImpCasts() instead of reimplementing it.

thakis created this revision. thakis added a reviewer: dcoughlin. Herald added subscribers: martong, Charusso. No intended behavior change. https://reviews.llvm.org/D77022 Files: clang/lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp Index:

[PATCH] D76990: [clang-tidy]: fix false positive of cert-oop54-cpp check.

ztamas updated this revision to Diff 253438. ztamas added a comment. Remove false TODO comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76990/new/ https://reviews.llvm.org/D76990 Files:

[PATCH] D77012: [analyzer] Fix StdLibraryFunctionsChecker NotNull Constraint Check

vabridgers updated this revision to Diff 253434. vabridgers added a comment. fix pre-merge lint checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77012/new/ https://reviews.llvm.org/D77012 Files:

[PATCH] D77010: [OpenMP] set_bits iterator yields unsigned elements, no reference (NFC).

This revision was automatically updated to reflect the committed changes. Closed by commit rG99913ef3d14f: [OpenMP] set_bits iterator yields unsigned elements, no reference (NFC). (authored by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77013: [AMDGPU] Add options -mamdgpu-ieee -mno-amdgpu-ieee

yaxunl created this revision. yaxunl added reviewers: arsenm, b-sumner, rjmccall. Herald added subscribers: kerbowa, t-tye, tpr, dstuttard, nhaehnle, wdng, jvesely, kzhuravl. AMDGPU backend need to know whether IEEE754-2008 NaN compliant instructions need to be emitted for a function, which is

[PATCH] D76990: [clang-tidy]: fix false positive of cert-oop54-cpp check.

njames93 added a comment. In D76990#1948516 , @ztamas wrote: > I agree, it seems suspicious that a BinaryOperator matcher does not work in > this case. However, I'm working on this level of the code, I'm looking at the > matchers like an API, what I'm

[PATCH] D76996: [analyzer] Improve PlacementNewChecker

NoQ added a comment. That was fast! Looks alright. Comment at: clang/lib/StaticAnalyzer/Checkers/CheckPlacementNew.cpp:25 public: void checkPreStmt(const CXXNewExpr *NE, CheckerContext ) const; Before i forget: Ideally @martong should have subscribed to

[PATCH] D77012: [analyzer] Fix StdLibraryFunctionsChecker NotNull Constraint Check

NoQ added a reviewer: Szelethus. NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks! @Szelethus can we make this checker depend on undefined value checker (probably CallAndMessage) so that uninitialized arguments were handled first? In fact,

[PATCH] D77012: [analyzer] Fix StdLibraryFunctionsChecker NotNull Constraint Check

vabridgers updated this revision to Diff 253419. vabridgers added a comment. fix pre-merge lint checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77012/new/ https://reviews.llvm.org/D77012 Files:

[PATCH] D77010: [OpenMP] set_bits iterator yields unsigned elements, no reference (NFC).

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Lgtm, thanks, I was seeing this locally Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77010/new/ https://reviews.llvm.org/D77010

[PATCH] D77012: [analyzer] Fix StdLibraryFunctionsChecker NotNull Constraint Check

vabridgers created this revision. vabridgers added reviewers: martong, NoQ. Herald added subscribers: ASDenysPetrov, Charusso, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun. Herald added a project: clang. This check was causing a crash in a test case where the

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

DmitryPolukhin updated this revision to Diff 253417. DmitryPolukhin added a comment. Rebase, all tests passes locally Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76594/new/ https://reviews.llvm.org/D76594 Files:

[PATCH] D76990: [clang-tidy]: fix false positive of cert-oop54-cpp check.

ztamas added a comment. In D76990#1948286 , @njames93 wrote: > I'm not entirely sure this is where the fix needs to be for this. The test > case code is whacky as hell, but from what I can see clang should always emit > a `BinaryOperator` for dependent

[PATCH] D76990: [clang-tidy]: fix false positive of cert-oop54-cpp check.

ztamas updated this revision to Diff 253412. ztamas added a comment. Rebase, TODO comment, remove unrelated change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76990/new/ https://reviews.llvm.org/D76990 Files:

[PATCH] D77010: [OpenMP] set_bits iterator yields unsigned elements, no reference (NFC).

fhahn created this revision. fhahn added reviewers: jdoerfert, rnk. Herald added subscribers: llvm-commits, guansong, hiraditya. Herald added a project: LLVM. BitVector::set_bits() returns an iterator range yielding unsinged elements, which always will be copied while const & gives the impression

[PATCH] D76996: [analyzer] Improve PlacementNewChecker

f00kat updated this revision to Diff 253408. f00kat added a comment. lint fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76996/new/ https://reviews.llvm.org/D76996 Files: clang/lib/StaticAnalyzer/Checkers/CheckPlacementNew.cpp