[PATCH] D77119: [AVR] Fix function pointer address space

This revision was automatically updated to reflect the committed changes. Closed by commit rG57fd86de879c: [AVR] Fix function pointer address space (authored by vlastik, committed by dylanmckay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77131: [clang] Move branch-protection from CodeGenOptions to LangOptions

tamas.petz added a comment. Tests pass, however, I am not sure ParseLangArgs is called in all the necessary cases (see the occurrences in the code). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77131/new/ https://reviews.llvm.org/D77131

[PATCH] D70411: [analyzer] CERT: STR31-C

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/cert/StrChecker.cpp:55 + // they can cause a not null-terminated string. In this case we store the + // string is being not null-terminated in the 'NullTerminationMap'. + // The

[PATCH] D77194: [clang] Persist Attr::IsPackExpansion into the serialized AST

kadircet added a comment. oh wow! thanks for looking into this. Looking at the history, it seems like an oversight. The patch that introduced packexpansion bit: https://github.com/llvm/llvm-project/commit/44c247f0f009eec70a193335c8a353d6f8602bfd. it didn't add that field to pchattr

[PATCH] D77194: [clang] Persist Attr::IsPackExpansion into the serialized AST

kadircet added a comment. also please update the commit message to mention "PCH" rather than "serialized ast". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77194/new/ https://reviews.llvm.org/D77194

[clang] 57fd86d - [AVR] Fix function pointer address space

Author: Vlastimil Labsky Date: 2020-04-01T21:08:37+13:00 New Revision: 57fd86de879cf2b4c7001b6d0a09df60877ce24d URL: https://github.com/llvm/llvm-project/commit/57fd86de879cf2b4c7001b6d0a09df60877ce24d DIFF:

[PATCH] D75181: [AArch64] Handle BTI/PAC in case of generated functions.

chill added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1828 + if (CodeGenOpts.BranchTargetEnforcement) { +FuncAttrs.addAttribute("branch-target-enforcement", "true"); + } danielkiss wrote: > chill wrote: > > I would really prefer to not set

[PATCH] D77142: [clangd] Add a flag to turn on recovery-expr.

This revision was automatically updated to reflect the committed changes. Closed by commit rG72439b6b9557: [clangd] Add a flag to turn on recovery-expr. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77142/new/

[PATCH] D77066: [analyzer] ApiModeling: Add buffer size arg constraint

Charusso added a comment. In D77066#1953280 , @Charusso wrote: > getDynamicSizeWithOffset(State, MR, SVB) { > Offset = State->getStoreManager().getStaticOffset(MR, SVB); > ... > } > Hm, the MemRegion's offset should be great. I was thinking

[PATCH] D77142: [clangd] Add a flag to turn on recovery-expr.

hokein updated this revision to Diff 254097. hokein added a comment. mention C++ only. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77142/new/ https://reviews.llvm.org/D77142 Files: clang-tools-extra/clangd/ClangdServer.cpp

[clang-tools-extra] 72439b6 - [clangd] Add a flag to turn on recovery-expr.

Author: Haojian Wu Date: 2020-04-01T09:03:56+02:00 New Revision: 72439b6b9557d5c58ec7f95a14722ef581906a17 URL: https://github.com/llvm/llvm-project/commit/72439b6b9557d5c58ec7f95a14722ef581906a17 DIFF: https://github.com/llvm/llvm-project/commit/72439b6b9557d5c58ec7f95a14722ef581906a17.diff

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

serge-sans-paille added a comment. @manojgupta prior to this patch, clang was using its version of `memcpy` and not the one provided inline. I slightly modified your reproducer to showcase that aspect: https://godbolt.org/z/NmxC0v Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D77193: [X86] Add SERIALIZE instruction.

craig.topper requested changes to this revision. craig.topper added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Headers/serializeintrin.h:17 + +static __inline__ void +__attribute__((__always_inline__, __nodebug__,

[PATCH] D77193: [X86] Add SERIALIZE instruction.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77193/new/ https://reviews.llvm.org/D77193

<    1   2   3