[PATCH] D77041: [AST] Fix a crash on invalid constexpr Ctorinitializer when building RecoveryExpr.

2020-04-07 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG041080c24735: [AST] Fix a crash on invalid constexpr Ctorinitializer when building… (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77209: [Syntax] Add mapping from spelled to expanded tokens for TokenBuffer

2020-04-07 Thread Marcel Hlopko via Phabricator via cfe-commits
hlopko updated this revision to Diff 255654. hlopko added a comment. Assert the Spelled subrange more effectively Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77209/new/ https://reviews.llvm.org/D77209 Files:

[PATCH] D77644: [clangd] Handle additional includes while parsing ASTs

2020-04-07 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, mgrang, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Depends on D77392 . Enables building ASTs with stale

[PATCH] D77527: [AST] Adjust existing tests for recovery-exprs

2020-04-07 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. I'm a bit leery about this because we lose test coverage of the "live" configuration. I know it's a pain, but maybe it's possible to keep this as a local patch/branch? :-( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 041080c - [AST] Fix a crash on invalid constexpr Ctorinitializer when building RecoveryExpr.

2020-04-07 Thread Haojian Wu via cfe-commits
Author: Haojian Wu Date: 2020-04-07T14:29:38+02:00 New Revision: 041080c247351da15b6bb21a7196c8dc9bc6babc URL: https://github.com/llvm/llvm-project/commit/041080c247351da15b6bb21a7196c8dc9bc6babc DIFF: https://github.com/llvm/llvm-project/commit/041080c247351da15b6bb21a7196c8dc9bc6babc.diff

[PATCH] D77585: Stop passing site cfg files via --param to llvm-lit.

2020-04-07 Thread Nico Weber via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG448b777b864a: Stop passing site cfg files via --param to llvm-lit. (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77641: [analyzer] StdLibraryFunctionsChecker: Associate summaries to FunctionDecls

2020-04-07 Thread Gabor Marton via Phabricator via cfe-commits
martong created this revision. martong added reviewers: NoQ, Szelethus, balazske. Herald added subscribers: cfe-commits, ASDenysPetrov, uenoku, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added

[PATCH] D77641: [analyzer] StdLibraryFunctionsChecker: Associate summaries to FunctionDecls

2020-04-07 Thread Gabor Marton via Phabricator via cfe-commits
martong marked an inline comment as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:570 +llvm::Optional +lookupGlobalCFunction(StringRef Name, const ASTContext ) { + IdentifierInfo = ACtx.Idents.get(Name);

[PATCH] D77585: Stop passing site cfg files via --param to llvm-lit.

2020-04-07 Thread Nico Weber via Phabricator via cfe-commits
thakis marked an inline comment as done. thakis added a comment. Thanks! Comment at: clang/test/CMakeLists.txt:113 -set(ANALYZER_TEST_PARAMS - USE_Z3_SOLVER=0) hans wrote: > This and ANALYZER_TEST_PARAMS_Z3 are just dropped because they're unused, > right?

[PATCH] D75364: [clang-format] Handle macros in function params and return value

2020-04-07 Thread Tamas Petz via Phabricator via cfe-commits
tamas.petz added a comment. Wow, I have missed that configuration option. I will try it, I assume it should work. Looks like this change should be abandoned. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75364/new/ https://reviews.llvm.org/D75364

[PATCH] D75682: [Analyzer][StreamChecker] Introduction of stream error handling.

2020-04-07 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus accepted this revision. Szelethus added a comment. Whoo! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75682/new/ https://reviews.llvm.org/D75682 ___ cfe-commits mailing list

[clang] 448b777 - Stop passing site cfg files via --param to llvm-lit.

2020-04-07 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2020-04-07T08:20:40-04:00 New Revision: 448b777b864a312e3b2ceae1e0cd59752a1fe90e URL: https://github.com/llvm/llvm-project/commit/448b777b864a312e3b2ceae1e0cd59752a1fe90e DIFF: https://github.com/llvm/llvm-project/commit/448b777b864a312e3b2ceae1e0cd59752a1fe90e.diff

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

2020-04-07 Thread Balogh, Ádám via Phabricator via cfe-commits
baloghadamsoftware marked an inline comment as done. baloghadamsoftware added a comment. Any idea for `LazyCompoundVal` parameters of functions not inlined? Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:231-235 +if

[PATCH] D75364: [clang-format] Handle macros in function params and return value

2020-04-07 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. Did you try putting 'ElfW and 'M' in the list of TypenameMacros? --- Language: Cpp BasedOnStyle: LLVM TypenameMacros: ['ElfW'] PointerAlignment: Left const ElfW(Addr)* foo(ElfW(Addr)* addr); const M(Addr) * foo(M(Addr) * addr); $ clang-format

[PATCH] D77309: [clangd] Get rid of ASTWorker::getCurrentFileInputs

2020-04-07 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG4ac7b805b7c4: [clangd] Get rid of ASTWorker::getCurrentFileInputs (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77309/new/

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

2020-04-07 Thread Balogh, Ádám via Phabricator via cfe-commits
baloghadamsoftware updated this revision to Diff 255641. baloghadamsoftware added a comment. Experimenting... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77229/new/ https://reviews.llvm.org/D77229 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h

[PATCH] D77581: Add map-type check for target and target data directive

2020-04-07 Thread Alexey Bataev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGa010ef8bd88f: Add map-type check for target and target data directive, by Chi Chun Chen (authored by cchen, committed by ABataev). Changed prior to commit:

[PATCH] D69088: [Lex] #pragma clang transform

2020-04-07 Thread Michael Kruse via Phabricator via cfe-commits
Meinersbur added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69088/new/ https://reviews.llvm.org/D69088 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

2020-04-07 Thread Michael Kruse via Phabricator via cfe-commits
Meinersbur added a comment. Herald added a subscriber: yaxunl. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76342/new/ https://reviews.llvm.org/D76342 ___ cfe-commits mailing list

[PATCH] D77058: [Clang] Add llvm.loop.unroll.disable to loops with -fno-unroll-loops.

2020-04-07 Thread Michael Kruse via Phabricator via cfe-commits
Meinersbur added a comment. LGTM, since it continues current practice. `optnone` will always be the more annoying. In D77058#1964714 , @fhahn wrote: > IIUC we don't need a patch similar like this one for optnone, as it already > gets added to the

[PATCH] D77637: [part 2] sancov/inline-bool-flag clang flags.

2020-04-07 Thread Pratyai Mazumder via Phabricator via cfe-commits
pratyai created this revision. pratyai added reviewers: kcc, vitalybuka. Herald added a project: clang. Herald added a subscriber: cfe-commits. pratyai updated this revision to Diff 255638. (must follow part 1: https://reviews.llvm.org/D77244) In the previous part, we implemented the

[PATCH] D77637: [part 2] sancov/inline-bool-flag clang flags.

2020-04-07 Thread Pratyai Mazumder via Phabricator via cfe-commits
pratyai updated this revision to Diff 255638. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77637/new/ https://reviews.llvm.org/D77637 Files: clang/docs/SanitizerCoverage.rst clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D77385: [clangd] Add index export to dexp

2020-04-07 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. Thanks, this looks pretty good! Comment at: clang-tools-extra/clangd/index/YAMLSerialization.cpp:36 namespace { using RefBundle = this is independent of adding the dump command - can we split this into a separate patch? Partly

[clang-tools-extra] 59c2810 - [clangd] Fix printing for Inclusion

2020-04-07 Thread Kadir Cetinkaya via cfe-commits
Author: Kadir Cetinkaya Date: 2020-04-07T13:48:00+02:00 New Revision: 59c28103a4a4d05db036157605a52a8075d60082 URL: https://github.com/llvm/llvm-project/commit/59c28103a4a4d05db036157605a52a8075d60082 DIFF:

[clang-tools-extra] 4ac7b80 - [clangd] Get rid of ASTWorker::getCurrentFileInputs

2020-04-07 Thread Kadir Cetinkaya via cfe-commits
Author: Kadir Cetinkaya Date: 2020-04-07T13:48:00+02:00 New Revision: 4ac7b805b7c4aa7af0a82d6187e3bd6ac0cf38cd URL: https://github.com/llvm/llvm-project/commit/4ac7b805b7c4aa7af0a82d6187e3bd6ac0cf38cd DIFF:

[clang] a010ef8 - Add map-type check for target and target data directive, by Chi Chun

2020-04-07 Thread Alexey Bataev via cfe-commits
Author: cchen Date: 2020-04-07T07:15:52-04:00 New Revision: a010ef8bd88fe28908c48362b04f59b89ad41250 URL: https://github.com/llvm/llvm-project/commit/a010ef8bd88fe28908c48362b04f59b89ad41250 DIFF: https://github.com/llvm/llvm-project/commit/a010ef8bd88fe28908c48362b04f59b89ad41250.diff LOG:

[PATCH] D77534: [clangd] DefineOutline: removes static token from static CXXMethodDecl

2020-04-07 Thread Nathan James via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG353a9883680e: [clangd] DefineOutline: removes static token from static CXXMethodDecl (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77614: [Syntax] Simplify TokenCollector::Builder, use captured expansion bounds. NFC

2020-04-07 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added a comment. still LG Comment at: clang/lib/Tooling/Syntax/Tokens.cpp:588 +auto = this->NextSpelled[File]; + +if (Tok.location().isFileID()) { sammccall wrote: > kadircet wrote: > > nit: maybe create mapping here and increment NextSpelled

[PATCH] D77393: [X86] Fix implicit sign conversion warnings in X86 headers.

2020-04-07 Thread pierre gousseau via Phabricator via cfe-commits
pgousseau marked 2 inline comments as done. pgousseau added inline comments. Comment at: clang/test/Headers/x86-header-warnings.c:12 +void test() { + // CHECK-NOT: warning: + _MM_SET_DENORMALS_ZERO_MODE(_MM_DENORMALS_ZERO_ON); RKSimon wrote: > Add a LABEL

[PATCH] D77309: [clangd] Get rid of ASTWorker::getCurrentFileInputs

2020-04-07 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 255632. kadircet marked an inline comment as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77309/new/ https://reviews.llvm.org/D77309 Files:

[clang] 3d1424b - Fixed licenses in dynamic ast matchers

2020-04-07 Thread Nathan James via cfe-commits
Author: Nathan James Date: 2020-04-07T12:08:06+01:00 New Revision: 3d1424bc7a0e9a6f9887727e2bc93a10f50e1709 URL: https://github.com/llvm/llvm-project/commit/3d1424bc7a0e9a6f9887727e2bc93a10f50e1709 DIFF: https://github.com/llvm/llvm-project/commit/3d1424bc7a0e9a6f9887727e2bc93a10f50e1709.diff

[clang-tools-extra] 353a988 - [clangd] DefineOutline: removes static token from static CXXMethodDecl

2020-04-07 Thread Nathan James via cfe-commits
Author: Nathan James Date: 2020-04-07T11:57:43+01:00 New Revision: 353a9883680e9d9666d02516a6692e8319af6d66 URL: https://github.com/llvm/llvm-project/commit/353a9883680e9d9666d02516a6692e8319af6d66 DIFF: https://github.com/llvm/llvm-project/commit/353a9883680e9d9666d02516a6692e8319af6d66.diff

[PATCH] D77393: [X86] Fix implicit sign conversion warnings in X86 headers.

2020-04-07 Thread Nico Weber via Phabricator via cfe-commits
thakis added inline comments. Comment at: clang/test/Headers/x86-header-warnings.c:3 +// in intrinsic headers. +// Preprocess file to workaround no warnings in system headers. +// RUN: %clang_cc1 %s -triple x86_64-pc-linux-gnu -ffreestanding -E 2>&1 \ Does

[PATCH] D77393: [X86] Fix implicit sign conversion warnings in X86 headers.

2020-04-07 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG08fab9ebecf7: [X86] Fix implicit sign conversion warnings in X86 headers. (authored by Pierre Gousseau pierre.gouss...@sony.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77393: [X86] Fix implicit sign conversion warnings in X86 headers.

2020-04-07 Thread pierre gousseau via Phabricator via cfe-commits
pgousseau updated this revision to Diff 255626. pgousseau added a comment. Added label CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77393/new/ https://reviews.llvm.org/D77393 Files: clang/lib/Headers/emmintrin.h clang/lib/Headers/xmmintrin.h

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

2020-04-07 Thread Matthew Riley via Phabricator via cfe-commits
mattdr added inline comments. Comment at: llvm/lib/Target/X86/ImmutableGraph.h:318 +} +auto *VertexArray = new Node[VertexSize + 1 /* terminator node */]; +auto *EdgeArray = new Edge[EdgeSize]; sconstab wrote: > mattdr wrote: > > sconstab wrote: > >

[PATCH] D77309: [clangd] Get rid of ASTWorker::getCurrentFileInputs

2020-04-07 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:459 /// be consumed by clients of ASTWorker. - std::shared_ptr FileInputs; /* GUARDED_BY(Mutex) */ +

[clang] 08fab9e - [X86] Fix implicit sign conversion warnings in X86 headers.

2020-04-07 Thread Pierre Gousseau via cfe-commits
Author: Pierre Gousseau Date: 2020-04-07T11:25:08+01:00 New Revision: 08fab9ebecf72a682279d75489dc2460121cbeed URL: https://github.com/llvm/llvm-project/commit/08fab9ebecf72a682279d75489dc2460121cbeed DIFF:

[PATCH] D77614: [Syntax] Simplify TokenCollector::Builder, use captured expansion bounds. NFC

2020-04-07 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 255621. sammccall added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77614/new/ https://reviews.llvm.org/D77614 Files: clang/lib/Tooling/Syntax/Tokens.cpp Index:

[PATCH] D77615: [Syntax] Merge overlapping top-level macros in TokenBuffer

2020-04-07 Thread Sam McCall via Phabricator via cfe-commits
sammccall marked 3 inline comments as done. sammccall added inline comments. Comment at: clang/lib/Tooling/Syntax/Tokens.cpp:461 + +// If the macro invocation B starts in a macro A but ends in a file, we'll +// create a merged mapping for A & B by overwriting the

[PATCH] D77614: [Syntax] Simplify TokenCollector::Builder, use captured expansion bounds. NFC

2020-04-07 Thread Sam McCall via Phabricator via cfe-commits
sammccall marked 4 inline comments as done. sammccall added inline comments. Comment at: clang/lib/Tooling/Syntax/Tokens.cpp:588 +auto = this->NextSpelled[File]; + +if (Tok.location().isFileID()) { kadircet wrote: > nit: maybe create mapping here and

[PATCH] D77244: [part 1] sancov/inline-bool-flag instrumentation.

2020-04-07 Thread Pratyai Mazumder via Phabricator via cfe-commits
pratyai updated this revision to Diff 255619. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77244/new/ https://reviews.llvm.org/D77244 Files: llvm/include/llvm/Transforms/Instrumentation.h

[PATCH] D77614: [Syntax] Simplify TokenCollector::Builder, use captured expansion bounds. NFC

2020-04-07 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77614/new/ https://reviews.llvm.org/D77614

[PATCH] D77614: [Syntax] Simplify TokenCollector::Builder, use captured expansion bounds. NFC

2020-04-07 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 255618. sammccall added a comment. Crash with a nice message if our loop gets stuck. Looks like ok Token(`void`, void, length = 4) ok Token(`test`, identifier, length = 4) ok Token(`(`, l_paren, length = 1) ok Token(`int`, int, length = 3) ok

[PATCH] D77614: [Syntax] Simplify TokenCollector::Builder, use captured expansion bounds. NFC

2020-04-07 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added inline comments. Comment at: clang/lib/Tooling/Syntax/Tokens.cpp:560 + SpelledTokens[NextSpelled].location() < Target) { + // If we know of mapping bounds at [Next, KnownEnd] (e.g. macro expansion) + // then we want to partition our (empty)

[PATCH] D77615: [Syntax] Merge overlapping top-level macros in TokenBuffer

2020-04-07 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang/lib/Tooling/Syntax/Tokens.cpp:452 + +// The *last* token of the macro reference is in the main file for A and B. +if

[PATCH] D75661: Remove SequentialType from the type heirarchy.

2020-04-07 Thread Alex Zinenko via Phabricator via cfe-commits
ftynse added a comment. LGTM for MLIR part. Comment at: mlir/lib/Target/LLVMIR/ModuleTranslation.cpp:60 + } else { emitError(loc) << "expected sequential LLVM types wrapping a scalar"; return nullptr; Nit: can we update the error message not to

[PATCH] D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang

2020-04-07 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:218 Opts.StackDepth = CGOpts.SanitizeCoverageStackDepth; - PM.add(createSanitizerCoverageModulePass(Opts)); + PM.add(createSanitizerCoverageModulePass(Opts,

[PATCH] D77209: [Syntax] Add mapping from spelled to expanded tokens for TokenBuffer

2020-04-07 Thread Marcel Hlopko via Phabricator via cfe-commits
hlopko added inline comments. Comment at: clang/lib/Tooling/Syntax/Tokens.cpp:264 + auto *FrontMapping = mappingStartingBeforeSpelled(File, ()); + unsigned SpelledFrontI = () - File.SpelledTokens.data(); + unsigned ExpandedBegin; gribozavr2 wrote: > hlopko

[PATCH] D77209: [Syntax] Add mapping from spelled to expanded tokens for TokenBuffer

2020-04-07 Thread Marcel Hlopko via Phabricator via cfe-commits
hlopko updated this revision to Diff 255610. hlopko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77209/new/ https://reviews.llvm.org/D77209 Files: clang/include/clang/Tooling/Syntax/Tokens.h

[PATCH] D77633: [Parser] Improve diagnostic and error recovery when C++ keywords are used as identifiers.

2020-04-07 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. Previously, clang emitted a less-usefull diagnostic and didnt recover well when the keywords is used as identifier in function paramter. void foo(int case, int x); // previously we drop all

[PATCH] D77491: [Sema] Fix incompatible builtin redeclarations in non-global scope

2020-04-07 Thread Yuichiro Utsumi via Phabricator via cfe-commits
yutsumi accepted this revision. yutsumi added a comment. This revision is now accepted and ready to land. Thank you very much. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77491/new/ https://reviews.llvm.org/D77491

[PATCH] D77491: [Sema] Fix incompatible builtin redeclarations in non-global scope

2020-04-07 Thread Yuichiro Utsumi via Phabricator via cfe-commits
yutsumi added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77491/new/ https://reviews.llvm.org/D77491 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D77585: Stop passing site cfg files via --param to llvm-lit.

2020-04-07 Thread Hans Wennborg via Phabricator via cfe-commits
hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/test/CMakeLists.txt:113 -set(ANALYZER_TEST_PARAMS - USE_Z3_SOLVER=0) This and ANALYZER_TEST_PARAMS_Z3 are just dropped because they're

[PATCH] D77209: [Syntax] Add mapping from spelled to expanded tokens for TokenBuffer

2020-04-07 Thread Marcel Hlopko via Phabricator via cfe-commits
hlopko updated this revision to Diff 255609. hlopko marked 6 inline comments as done. hlopko added a comment. Adressing comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77209/new/ https://reviews.llvm.org/D77209 Files:

[PATCH] D77502: [clang][CodeGen] Handle throw expression in conditional operator constant folding

2020-04-07 Thread Raul Tambre via Phabricator via cfe-commits
tambre marked an inline comment as done. tambre added a comment. Updated the comment. Please commit this for me, as I lack commit privileges. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77502/new/ https://reviews.llvm.org/D77502

[PATCH] D75364: [clang-format] Handle macros in function params and return value

2020-04-07 Thread Tamas Petz via Phabricator via cfe-commits
tamas.petz marked 2 inline comments as done. tamas.petz added a comment. @all, thank you for the review so far. The case I am trying to handle is way too ambiguous. IMHO looking at tokens only is not going to lead to a "perfect" formatter. The case I am trying to handle is quite common but it

[PATCH] D77574: [OpenMP] Fix layering problem with FrontendOpenMP

2020-04-07 Thread Sylvestre Ledru via Phabricator via cfe-commits
sylvestre.ledru added a comment. @lebedev.ri @jdoerfert Looks like it might have caused: https://bugs.llvm.org/show_bug.cgi?id=45453 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77574/new/ https://reviews.llvm.org/D77574

[PATCH] D77502: [clang][CodeGen] Handle throw expression in conditional operator constant folding

2020-04-07 Thread Raul Tambre via Phabricator via cfe-commits
tambre updated this revision to Diff 255607. tambre marked an inline comment as done. tambre added a comment. Update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77502/new/ https://reviews.llvm.org/D77502 Files:

[PATCH] D77379: [FPEnv] Use single enum to represent rounding mode

2020-04-07 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff marked an inline comment as done. sepavloff added inline comments. Comment at: llvm/include/llvm/ADT/FloatingPointMode.h:26 +/// assigned to the rounding modes must agree with the values used by FLT_ROUNDS +/// (C11, 5.2.4.2.2p8). +enum class RoundingMode : int8_t {

[PATCH] D77484: [Vector] Pass VectLib to LTO backend so TLI build correct vector function list

2020-04-07 Thread Wenlei He via Phabricator via cfe-commits
wenlei added a comment. In D77484#1965976 , @tejohnson wrote: > In D77484#1965629 , @wenlei wrote: > > > > Ok then it does sound like these could be handled on a per-function > > > basis, similar to how

[PATCH] D77632: [TLI] Per-function fveclib for math library used for vectorization

2020-04-07 Thread Wenlei He via Phabricator via cfe-commits
wenlei created this revision. Herald added subscribers: cfe-commits, dexonsmith, hiraditya. Herald added a project: clang. wenlei edited the summary of this revision. wenlei added reviewers: tejohnson, hoyFB, spatel, gchatelet. Encode `-fveclib` setting as per-function attribute so it can be

[PATCH] D77534: [clangd] DefineOutline: removes static token from static CXXMethodDecl

2020-04-07 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77534/new/ https://reviews.llvm.org/D77534

[PATCH] D75682: [Analyzer][StreamChecker] Introduction of stream error handling.

2020-04-07 Thread Balázs Kéri via Phabricator via cfe-commits
balazske updated this revision to Diff 255602. balazske marked an inline comment as done. balazske added a comment. Moved test checker to debug package, changed macro to function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75682/new/

[clang-tools-extra] 39e9149 - Fix unused variable warning in Protocol.cpp, NFCI

2020-04-07 Thread Karl-Johan Karlsson via cfe-commits
Author: Karl-Johan Karlsson Date: 2020-04-07T08:39:17+02:00 New Revision: 39e9149d8e12d77cd389f55860ac2cb9a30b4552 URL: https://github.com/llvm/llvm-project/commit/39e9149d8e12d77cd389f55860ac2cb9a30b4552 DIFF:

Re: [clang] a8c8b62 - [ObjC generics] Fix not inheriting type bounds in categories/extensions.

2020-04-07 Thread Mikael Holmén via cfe-commits
We see flakiness in the test in our bots too. Fails one time and then passes again. /Mikael On Mon, 2020-04-06 at 21:03 -0400, Nico Weber via cfe-commits wrote: > This isn't bot-dependent, it's been flaking on many different bots > over the last few days. Here's one from just now: >

<    1   2   3