[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

2020-04-16 Thread Melanie Blower via Phabricator via cfe-commits
mibintc marked an inline comment as done. mibintc added a subscriber: martong. mibintc added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:6821 + E->getFPFeatures(Importer.getFromContext()), + importChecked(Err, ToComputationLHSType), + importChecked(E

[clang] 30d5946 - [clang][AST] Support AST files larger than 512M

2020-04-16 Thread Dmitry Polukhin via cfe-commits
Author: Dmitry Polukhin Date: 2020-04-16T07:27:43-07:00 New Revision: 30d5946db95fa465d7ee6caceb2b1ff191e3727c URL: https://github.com/llvm/llvm-project/commit/30d5946db95fa465d7ee6caceb2b1ff191e3727c DIFF: https://github.com/llvm/llvm-project/commit/30d5946db95fa465d7ee6caceb2b1ff191e3727c.dif

[PATCH] D77940: [AArch64] Add NVIDIA Carmel support

2020-04-16 Thread Raul Tambre via Phabricator via cfe-commits
tambre updated this revision to Diff 258045. tambre marked 6 inline comments as done. tambre added a comment. Remove SVE, fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77940/new/ https://reviews.llvm.org/D77940 Files: clang/test/D

[PATCH] D77940: [AArch64] Add NVIDIA Carmel support

2020-04-16 Thread Raul Tambre via Phabricator via cfe-commits
tambre added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64.td:607 + FeatureSVE + ]>; + sdesmalen wrote: > Not sure how accurate the link you referenced is, but it doesn't mention S

[PATCH] D77872: [AArch32] Armv8.6-a Matrix Mult Assembly + Intrinsics

2020-04-16 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki accepted this revision. miyuki added a comment. This revision is now accepted and ready to land. LGTM, but please wait a couple more days before committing to see if anyone wants to chime in (I guess one week since the upload date should be enough). CHANGES SINCE LAST ACTION https://re

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

2020-04-16 Thread Gabor Marton via Phabricator via cfe-commits
martong added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:6821 + E->getFPFeatures(Importer.getFromContext()), + importChecked(Err, ToComputationLHSType), + importChecked(Err, ToComputationResultType)); This introduced an assertion fa

[clang] e033ec2 - [ASTImporter] Fix bug introduced in 2ba4e3a4598b

2020-04-16 Thread Gabor Marton via cfe-commits
Author: Gabor Marton Date: 2020-04-16T16:03:27+02:00 New Revision: e033ec291a1b72f307ab14569ca99822c127610b URL: https://github.com/llvm/llvm-project/commit/e033ec291a1b72f307ab14569ca99822c127610b DIFF: https://github.com/llvm/llvm-project/commit/e033ec291a1b72f307ab14569ca99822c127610b.diff

[PATCH] D78190: Add Bfloat IR type

2020-04-16 Thread Ties Stuij via Phabricator via cfe-commits
stuij marked an inline comment as done. stuij added a comment. @craig.topper : Yes, I thought to keep this patch confined to IR. Codegen and intrinsics patches are still to come. Comment at: llvm/docs/LangRef.rst:2896 + * - ``bfloat`` + - 16-bit brain floating-point valu

[PATCH] D78295: [clang-format] Do not interpret C# deconstruction in a foreach as a cast

2020-04-16 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG07c1978b15b4: [clang-format] Do not interpret C# deconstruction in a foreach as a cast (authored by Jonathan Coe ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D78295: [clang-format] Do not interpret C# deconstruction in a foreach as a cast

2020-04-16 Thread Jonathan B Coe via Phabricator via cfe-commits
jbcoe updated this revision to Diff 258035. jbcoe added a comment. Format patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78295/new/ https://reviews.llvm.org/D78295 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/FormatTestCSharp.cpp Index: clang/unittests/F

[PATCH] D78190: Add Bfloat IR type

2020-04-16 Thread Ties Stuij via Phabricator via cfe-commits
stuij updated this revision to Diff 258036. stuij marked 2 inline comments as done. stuij added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. addressing review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D77474: [analyzer][MallocChecker] Make NewDeleteLeaks depend on DynamicMemoryModeling rather than NewDelete

2020-04-16 Thread Balázs Kéri via Phabricator via cfe-commits
balazske added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h:195 +// Say this 3 times fast. +State = State ? State : getState(); +addTransition(State, generateSink(State, getPredecessor())); ``` i

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

2020-04-16 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. Ping again! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73967/new/ https://reviews.llvm.org/D73967 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D78123: [analyzer][NSOrCFError] Don't emit diagnostics under the name osx.NSOrCFErrorDerefChecker

2020-04-16 Thread Balázs Kéri via Phabricator via cfe-commits
balazske accepted this revision. balazske added a comment. This revision is now accepted and ready to land. I am not familiar with ObjC but the code change looks OK if the tests pass. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78123/new/ https:/

[clang] 2ec5520 - Disallow [[nodiscard]] on a function pointer declaration.

2020-04-16 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2020-04-16T09:28:49-04:00 New Revision: 2ec5520a54ef9b359c6154adf857ba690bc117f1 URL: https://github.com/llvm/llvm-project/commit/2ec5520a54ef9b359c6154adf857ba690bc117f1 DIFF: https://github.com/llvm/llvm-project/commit/2ec5520a54ef9b359c6154adf857ba690bc117f1.diff

[clang] 07c1978 - [clang-format] Do not interpret C# deconstruction in a foreach as a cast

2020-04-16 Thread Jonathan Coe via cfe-commits
Author: Jonathan Coe Date: 2020-04-16T14:22:34+01:00 New Revision: 07c1978b15b4e9daefbf358e6fd185b5aa269f98 URL: https://github.com/llvm/llvm-project/commit/07c1978b15b4e9daefbf358e6fd185b5aa269f98 DIFF: https://github.com/llvm/llvm-project/commit/07c1978b15b4e9daefbf358e6fd185b5aa269f98.diff

[PATCH] D78294: [Fixed Point] Move the compassign LHS type correction a bit further down. NFCI.

2020-04-16 Thread Bevin Hansson via Phabricator via cfe-commits
ebevhan created this revision. ebevhan added a reviewer: leonardchan. Herald added a project: clang. Herald added a subscriber: cfe-commits. We can simplify the LHSTy correction for fixed-point compassign by moving it below the point where we know we have a compound assignment. Also, we shouldn't

[PATCH] D77872: [AArch32] Armv8.6-a Matrix Mult Assembly + Intrinsics

2020-04-16 Thread Luke Geeson via Phabricator via cfe-commits
LukeGeeson marked 3 inline comments as done. LukeGeeson added inline comments. Comment at: clang/test/CodeGen/arm-v8.6a-neon-intrinsics.c:3 +// RUN: -fallow-half-arguments-and-returns -S -disable-O0-optnone -emit-llvm -o - %s \ +// RUN: | opt -S -mem2reg \ +// RUN: | FileCheck %

[PATCH] D78295: [clang-format] Do not interpret C# deconstruction in a foreach as a cast

2020-04-16 Thread Jonathan B Coe via Phabricator via cfe-commits
jbcoe created this revision. jbcoe added a reviewer: krasimir. jbcoe added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D78295 Files: clang/lib/Format/TokenAnnotator.cpp clang/un

[PATCH] D77872: [AArch32] Armv8.6-a Matrix Mult Assembly + Intrinsics

2020-04-16 Thread Luke Geeson via Phabricator via cfe-commits
LukeGeeson updated this revision to Diff 258030. LukeGeeson added a comment. - added -sroa to arm-v8.6a-neon-intrinsics test, updated test to remove redundant memory accesses - made class vusdot for new vusdot instructions with hasNoSchedulinginfo for new instructions. Existing instructions reta

[PATCH] D78295: [clang-format] Do not interpret C# deconstruction in a foreach as a cast

2020-04-16 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78295/new/ https://reviews.llvm.org/D78295 __

[PATCH] D77491: [Sema] Fix incompatible builtin redeclarations in non-global scope

2020-04-16 Thread Raul Tambre via Phabricator via cfe-commits
tambre added a comment. rsmith: ping 2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77491/new/ https://reviews.llvm.org/D77491 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

2020-04-16 Thread Thibault North via Phabricator via cfe-commits
tnorth updated this revision to Diff 258029. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ https://reviews.llvm.org/D72326 Files: clang/docs/ClangFormat.rst clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNotes.rst clang/include/clang/F

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

2020-04-16 Thread Melanie Blower via Phabricator via cfe-commits
mibintc added a comment. @rjmccall Can you check the patch added last night here, commit 3ee1ec0b9dd6ee2350f39ae8a418bf3ce28d06cf Author: Benjamin Kramer Date: Thu Apr 16 11:45:02 2020 +0200 LangOptions cannot depend on

[PATCH] D61716: [libclang] Expose AtomicType

2020-04-16 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman closed this revision. aaron.ballman added a comment. I've commit on your behalf in 38ca7b11db2d22e0fdfbff3f19276f9796f747d3 , thank you for the patch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61716/

[clang] 38ca7b1 - Expose AtomicType in the libclang C API.

2020-04-16 Thread Aaron Ballman via cfe-commits
Author: Henry Jen Date: 2020-04-16T08:06:58-04:00 New Revision: 38ca7b11db2d22e0fdfbff3f19276f9796f747d3 URL: https://github.com/llvm/llvm-project/commit/38ca7b11db2d22e0fdfbff3f19276f9796f747d3 DIFF: https://github.com/llvm/llvm-project/commit/38ca7b11db2d22e0fdfbff3f19276f9796f747d3.diff LOG

[PATCH] D77794: [clangd] Pull installed gRPC and introduce clangd-remote-(server|client)

2020-04-16 Thread Kirill Bobyrev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGcee80c0489e9: [clangd] Pull installed gRPC and introduce clangd-remote-(server|client) (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D78024: [FileCheck] - Fix the false positive when -implicit-check-not is used with an unknown -check-prefix.

2020-04-16 Thread George Rimar via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG65a2de7e6c98: [FileCheck] - Fix the false positive when -implicit-check-not is used with an… (authored by grimar). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to c

[PATCH] D78194: [ARM] Add __bf16 as new Bfloat16 C Type

2020-04-16 Thread Ties Stuij via Phabricator via cfe-commits
stuij abandoned this revision. stuij added a comment. This should not have been it's own revision. I wrongly trusted arc to update https://reviews.llvm.org/D76077. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78194/new/ https://reviews.llvm.org/D

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

2020-04-16 Thread Ties Stuij via Phabricator via cfe-commits
stuij updated this revision to Diff 258018. stuij added a comment. changes: depend on bfloat IR type, and resolve some conflicts that crept in Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76077/new/ https://reviews.llvm.org/D76077 Files: clang/

[PATCH] D77809: [Analyzer] Include typedef statements in CFG build.

2020-04-16 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/test/Analysis/cfg.cpp:570 } +// CHECK-LABEL: void vla_simple(int x) Can you also add tests for: ``` int vla_unevaluated(int x) { // Evaluates the ++x sizeof(int[++x]); // Does not evaluate the ++x

[PATCH] D78194: [ARM] Add __bf16 as new Bfloat16 C Type

2020-04-16 Thread Ties Stuij via Phabricator via cfe-commits
stuij updated this revision to Diff 258017. stuij added a comment. changes: depend on bfloat IR type, and resolve some conflicts that crept in Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78194/new/ https://reviews.llvm.org/D78194 Files: clang/

[clang] 65a2de7 - [FileCheck] - Fix the false positive when -implicit-check-not is used with an unknown -check-prefix.

2020-04-16 Thread Georgii Rymar via cfe-commits
Author: Georgii Rymar Date: 2020-04-16T15:00:50+03:00 New Revision: 65a2de7e6c986193a630e691686c527b08f292d5 URL: https://github.com/llvm/llvm-project/commit/65a2de7e6c986193a630e691686c527b08f292d5 DIFF: https://github.com/llvm/llvm-project/commit/65a2de7e6c986193a630e691686c527b08f292d5.diff

[clang-tools-extra] cee80c0 - [clangd] Pull installed gRPC and introduce clangd-remote-(server|client)

2020-04-16 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2020-04-16T13:55:08+02:00 New Revision: cee80c0489e96c36269388b2aacd4da1c5714a66 URL: https://github.com/llvm/llvm-project/commit/cee80c0489e96c36269388b2aacd4da1c5714a66 DIFF: https://github.com/llvm/llvm-project/commit/cee80c0489e96c36269388b2aacd4da1c5714a66.diff

[PATCH] D77809: [Analyzer] Include typedef statements in CFG build.

2020-04-16 Thread Balázs Kéri via Phabricator via cfe-commits
balazske updated this revision to Diff 258011. balazske added a comment. - Adding tests. - Type alias is supported. - Updated comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77809/new/ https://reviews.llvm.org/D77809 Files: clang/lib/Ana

[PATCH] D78189: [analyzer] StdLibraryFunctionsChecker: Add statistics

2020-04-16 Thread Balázs Kéri via Phabricator via cfe-commits
balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:67 +#define DEBUG_TYPE "StdLibraryFunctionsChecker" +STATISTIC(NumCall, "The # of calls handled by the checker"); +STATISTIC(NumFoundSummary, "The # of calls with associat

[PATCH] D78098: [CGExprAgg] Fix infinite loop in `findPeephole`

2020-04-16 Thread Ehud Katz via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG03a9526fe5ad: [CGExprAgg] Fix infinite loop in `findPeephole` (authored by ekatz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78098/new/ https://reviews.

[PATCH] D78284: [AST] Fix an undefine behavior when creating an empty recovery expr.

2020-04-16 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG94d6dd01ba43: [AST] Fix an undefine behavior when creating an empty recovery expr. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78284/

[PATCH] D78139: [clang-tidy] modernize-use-using: Fix broken fixit with 'template' keyword

2020-04-16 Thread Haojian Wu via Phabricator via cfe-commits
hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks for fixing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78139/new/ https://reviews.llvm.org/D78139

[PATCH] D78286: [analyzer] Track runtime types represented by Obj-C Class objects

2020-04-16 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko marked 6 inline comments as done. vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:135 + if (MsgE->getReceiverKind() == ObjCMessageExpr::Class) { +return {MsgE->getClassReceiver()->getAs(), true}; + }

[PATCH] D78286: [analyzer] Track runtime types represented by Obj-C Class objects

2020-04-16 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:135 + if (MsgE->getReceiverKind() == ObjCMessageExpr::Class) { +return {MsgE->getClassReceiver()->getAs(), true}; + } Let's explain what `true` means here, i

[clang] 94d6dd0 - [AST] Fix an undefine behavior when creating an empty recovery expr.

2020-04-16 Thread Haojian Wu via cfe-commits
Author: Haojian Wu Date: 2020-04-16T12:35:45+02:00 New Revision: 94d6dd01ba439ffcef7f7873622cf6ae99bcf5cb URL: https://github.com/llvm/llvm-project/commit/94d6dd01ba439ffcef7f7873622cf6ae99bcf5cb DIFF: https://github.com/llvm/llvm-project/commit/94d6dd01ba439ffcef7f7873622cf6ae99bcf5cb.diff LO

[clang] 03a9526 - [CGExprAgg] Fix infinite loop in `findPeephole`

2020-04-16 Thread Ehud Katz via cfe-commits
Author: Ehud Katz Date: 2020-04-16T13:26:23+03:00 New Revision: 03a9526fe5adae909f1d5fd2736703e69fc46e09 URL: https://github.com/llvm/llvm-project/commit/03a9526fe5adae909f1d5fd2736703e69fc46e09 DIFF: https://github.com/llvm/llvm-project/commit/03a9526fe5adae909f1d5fd2736703e69fc46e09.diff LOG

[PATCH] D77802: [analyzer] Improved RangeSet::Negate support of unsigned ranges

2020-04-16 Thread Denys Petrov via Phabricator via cfe-commits
ASDenysPetrov added a comment. @baloghadamsoftware Please, review my changes. If you think they are OK, could you, please, commit the patch on by behalf as an author: `git commit --amend --author="Denys Petrov "` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77802/new/ https://reviews.

[PATCH] D78289: [analyzer] Stability improvements for IteratorModeling functions

2020-04-16 Thread Denys Petrov via Phabricator via cfe-commits
ASDenysPetrov created this revision. ASDenysPetrov added reviewers: baloghadamsoftware, NoQ. ASDenysPetrov added a project: clang. Herald added subscribers: cfe-commits, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun. Some functions paths

[PATCH] D78286: [analyzer] Track runtime types represented by Obj-C Class objects

2020-04-16 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko updated this revision to Diff 258003. vsavchenko added a comment. Fix unfinished comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78286/new/ https://reviews.llvm.org/D78286 Files: clang/include/clang/StaticAnalyzer/Core/PathSensi

[clang] 61b9670 - [clang] Const correct ComputePreambleBounds

2020-04-16 Thread Kadir Cetinkaya via cfe-commits
Author: Kadir Cetinkaya Date: 2020-04-16T12:10:40+02:00 New Revision: 61b96704564b121210a3b83107f7867c9f2d89b3 URL: https://github.com/llvm/llvm-project/commit/61b96704564b121210a3b83107f7867c9f2d89b3 DIFF: https://github.com/llvm/llvm-project/commit/61b96704564b121210a3b83107f7867c9f2d89b3.dif

[PATCH] D78286: [analyzer] Track runtime types represented by Obj-C Class objects

2020-04-16 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Objective-C Clas

[PATCH] D77420: Also look for devtoolset-9 gcc toolchain

2020-04-16 Thread Benjamin Kramer via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG7b9c6c16c33d: Also look for devtoolset-9 gcc toolchain (authored by stephan.dollberg, committed by bkramer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77

[clang] 3ee1ec0 - LangOptions cannot depend on ASTContext, make it not use ASTContext directly

2020-04-16 Thread Benjamin Kramer via cfe-commits
Author: Benjamin Kramer Date: 2020-04-16T11:46:35+02:00 New Revision: 3ee1ec0b9dd6ee2350f39ae8a418bf3ce28d06cf URL: https://github.com/llvm/llvm-project/commit/3ee1ec0b9dd6ee2350f39ae8a418bf3ce28d06cf DIFF: https://github.com/llvm/llvm-project/commit/3ee1ec0b9dd6ee2350f39ae8a418bf3ce28d06cf.dif

[clang] 7b9c6c1 - Also look for devtoolset-9 gcc toolchain

2020-04-16 Thread Benjamin Kramer via cfe-commits
Author: Stephan Dollberg Date: 2020-04-16T11:17:39+02:00 New Revision: 7b9c6c16c33deb52e7081f94ad51e3910ca592c9 URL: https://github.com/llvm/llvm-project/commit/7b9c6c16c33deb52e7081f94ad51e3910ca592c9 DIFF: https://github.com/llvm/llvm-project/commit/7b9c6c16c33deb52e7081f94ad51e3910ca592c9.di

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

2020-04-16 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:2704 + if (ParserErrorCode == ParseError::Unsuitable) { +*IsSuitable = false; +return Style; I think this isn't needed won't it already be false from line @2695 Repository:

[PATCH] D78284: [AST] Fix an undefine behavior when creating an empty recovery expr.

2020-04-16 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. We forgot to initialize the NumExpr member in one of the constructors, which leads crashes in preamble serialization. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D78284 Files:

[PATCH] D77809: [Analyzer] Include typedef statements in CFG build.

2020-04-16 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:2855 + VarDecl *VD = dyn_cast(DS->getSingleDecl()); balazske wrote: > Szelethus wrote: > > How about `using`? How about some other shenanigans that obscure the size > > of the VLA? Can'

[PATCH] D75479: [clangd] go-to-def on names in comments etc that are used nearby.

2020-04-16 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 257989. sammccall added a comment. rebase - finally getting back to this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75479/new/ https://reviews.llvm.org/D75479 Files: clang-tools-extra/clangd/XRefs.cpp

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-04-16 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 updated this revision to Diff 257985. gamesh411 marked an inline comment as done. gamesh411 added a comment. Rebase and update the number of analyzer options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.or

[PATCH] D78162: [CodeGen] Mark inline definitions of builtins as nobuiltin only if we plan to emit them.

2020-04-16 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. This triggers failed asserts: $ cat dcpdecrypt.cpp extern "C" __inline__ __attribute__((__gnu_inline__)) void * memcpy(void *, const void *, unsigned) {} void *memcpy(void *, const void *, unsigned); void a() { memcpy; } $ clang++ -c dcpdecrypt.cpp -target i6

[PATCH] D77794: [clangd] Pull installed gRPC and introduce clangd-remote-(server|client)

2020-04-16 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Awesome, ship it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77794/new/ https://reviews.llvm.org/D77794

[PATCH] D78280: [Analyzer][StreamChecker] Track streams that were not found to be opened.

2020-04-16 Thread Balázs Kéri via Phabricator via cfe-commits
balazske created this revision. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: clang. If a stream ope

[PATCH] D77880: get scan-view executable from environment

2020-04-16 Thread Oliver Tušla via Phabricator via cfe-commits
asmar added a comment. Rather than globbing I would check whether there's a `scan-view` directory with the same version suffix as in the `scan-build`'s one. Getting "random" version from other directories doesn't seem transparent to me. When this fails, `which` for the system version is expecte

[PATCH] D77936: [Windows SEH] Fix abnormal-exits in _try

2020-04-16 Thread Ten Tzen via Phabricator via cfe-commits
tentzen updated this revision to Diff 257977. tentzen added a comment. remade a patch after re-sync Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77936/new/ https://reviews.llvm.org/D77936 Files: clang/lib/CodeGen/CGCleanup.cpp clang/lib/CodeG

[PATCH] D77809: [Analyzer] Include typedef statements in CFG build.

2020-04-16 Thread Balázs Kéri via Phabricator via cfe-commits
balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:2855 + VarDecl *VD = dyn_cast(DS->getSingleDecl()); Szelethus wrote: > How about `using`? How about some other shenanigans that obscure the size

[PATCH] D77809: [Analyzer] Include typedef statements in CFG build.

2020-04-16 Thread Balázs Kéri via Phabricator via cfe-commits
balazske added a comment. > I also see that the typedef constitutes a `DeclStmt` in the AST. Can we > include that in the CFG as well? In the static analyzer that'll be the place > where we actually start tracking that typedef, because without it the size > expression value will be quickly clea

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

2020-04-16 Thread Thibault North via Phabricator via cfe-commits
tnorth updated this revision to Diff 257970. tnorth added a comment. Sorry. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ https://reviews.llvm.org/D72326 Files: clang/docs/ClangFormat.rst clang/docs/ClangFormatStyleOptions.rst clang/docs/Release

<    1   2