[PATCH] D77392: [clangd] Make signatureHelp work with stale preambles

This revision was automatically updated to reflect the committed changes. Closed by commit rG2214b9076f1d: [clangd] Make signatureHelp work with stale preambles (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77392/new/

[clang] 2214b90 - [clangd] Make signatureHelp work with stale preambles

Author: Kadir Cetinkaya Date: 2020-04-21T10:27:26+02:00 New Revision: 2214b9076f1d3a4784820c4479e2417685e5c980 URL: https://github.com/llvm/llvm-project/commit/2214b9076f1d3a4784820c4479e2417685e5c980 DIFF:

[clang-tools-extra] 6e01718 - [clangd] Store ppdirective in Inclusion

Author: Kadir Cetinkaya Date: 2020-04-21T10:27:26+02:00 New Revision: 6e017188b7607eb0f0b248881319bfd803cb8f78 URL: https://github.com/llvm/llvm-project/commit/6e017188b7607eb0f0b248881319bfd803cb8f78 DIFF:

[PATCH] D78100: [AST] Suppress the spammy "attempt to use a deleted fucntion" diagnostic.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe90fb82f0f76: [AST] Suppress the spammy attempt to use a deleted fucntion diagnostic. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D78100?vs=257689=258918#toc Repository:

[PATCH] D77392: [WIP][clangd] Make signatureHelp work with stale preambles

kadircet updated this revision to Diff 258915. kadircet marked 2 inline comments as done. kadircet added a comment. - Make scanPreambleIncludes return an Expected> - Bail out in case of errors, document the rational. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77392: [WIP][clangd] Make signatureHelp work with stale preambles

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/Preamble.cpp:281 + // We are only interested in newly added includes. + llvm::StringSet<> ExistingIncludes; + for (const auto : Preamble.LexedIncludes)

[clang] e90fb82 - [AST] Suppress the spammy "attempt to use a deleted fucntion" diagnostic.

Author: Haojian Wu Date: 2020-04-21T09:43:46+02:00 New Revision: e90fb82f0f760703c14eafbad96c08b6019a2f0f URL: https://github.com/llvm/llvm-project/commit/e90fb82f0f760703c14eafbad96c08b6019a2f0f DIFF: https://github.com/llvm/llvm-project/commit/e90fb82f0f760703c14eafbad96c08b6019a2f0f.diff

[PATCH] D78374: [Analyzer][StreamChecker] Added evaluation of fread and fwrite.

balazske added a comment. Finally I had to make the decision to remove the `ErrorKindTy` enum and use boolean flags instead for every possible error (including no error). This is needed because we do not know always what error is possible if it is "unknown". It could be determined from the

[PATCH] D78491: Avoid relying on address space zero default parameter in llvm/IR

lebedev.ri added subscribers: llvm-commits, lebedev.ri. lebedev.ri added a comment. This should really be reviewed on llvm-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78491/new/ https://reviews.llvm.org/D78491

[PATCH] D78534: [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON

smeenai added reviewers: beanz, phosek. smeenai added subscribers: phosek, beanz. smeenai added a comment. This makes sense to me, but I'd like @beanz and/or @phosek to take a look as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78534/new/

[PATCH] D75479: [clangd] go-to-def on names in comments etc that are used nearby.

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Thanks, Sam, this looks great! Comment at: clang-tools-extra/clangd/SourceCode.cpp:883 +static bool isLikelyIdentifier(llvm::StringRef Word, StringRef Before, +

<    1   2