[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:1044 +class ParamWithoutVarRegion : public TypedValueRegion { + friend class MemRegionManager;

[PATCH] D78704: [analyzer][NFC] Add unittest for FalsePositiveRefutationBRVisitor

martong accepted this revision. martong added a comment. Other than Whispy's nits, LGTM! Comment at: clang/unittests/StaticAnalyzer/FalsePositiveRefutationBRVisitorTest.cpp:24 + do \ +if

[clang] 740a1dd - [ARM] Armv8.6-a Matrix Mul cmd line support

Author: Luke Geeson Date: 2020-04-24T15:54:06+01:00 New Revision: 740a1dd050eea93a875ec86780ad6ed4b0310113 URL: https://github.com/llvm/llvm-project/commit/740a1dd050eea93a875ec86780ad6ed4b0310113 DIFF: https://github.com/llvm/llvm-project/commit/740a1dd050eea93a875ec86780ad6ed4b0310113.diff

[clang] 7da1905 - [AArch32] Armv8.6-a Matrix Mult Assembly + Intrinsics

Author: Luke Geeson Date: 2020-04-24T15:54:06+01:00 New Revision: 7da19051253219d4bee2c50fe13f250201f1f7ec URL: https://github.com/llvm/llvm-project/commit/7da19051253219d4bee2c50fe13f250201f1f7ec DIFF: https://github.com/llvm/llvm-project/commit/7da19051253219d4bee2c50fe13f250201f1f7ec.diff

[clang] 832cd74 - [AArch64] Armv8.6-a Matrix Mult Assembly + Intrinsics

Author: Luke Geeson Date: 2020-04-24T15:54:06+01:00 New Revision: 832cd749131b1fa59d12486325f19e16eb392a42 URL: https://github.com/llvm/llvm-project/commit/832cd749131b1fa59d12486325f19e16eb392a42 DIFF: https://github.com/llvm/llvm-project/commit/832cd749131b1fa59d12486325f19e16eb392a42.diff

[PATCH] D78785: Fix x86/x86_64 calling convention for _ExtInt

erichkeane updated this revision to Diff 259875. erichkeane added a comment. Handle indirect return as well. @craig.topper : Anything else you can think of? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78785/new/ https://reviews.llvm.org/D78785 Files:

[PATCH] D46317: [clang-tidy] New check bugprone-map-subscript-operator-lookup

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/MapSubscriptOperatorLookupCheck.cpp:31 +void MapSubscriptOperatorLookupCheck::registerMatchers(MatchFinder *Finder) { + if (!getLangOpts().CPlusPlus) +return; Should be

[PATCH] D78784: [clangd] Add some logging to explain why textual fallback navigation failed

sammccall added a comment. This seems fine-grained even for `vlog`. Is this for debugging, can it be `dlog()`? (i.e. available in asserts-enabled builds behind `-debug` or `-debug-only=XRefs.cpp`) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78785: Fix x86/x86_64 calling convention for _ExtInt

erichkeane marked an inline comment as done. erichkeane added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:2804 +return; + } + Quuxplusone wrote: > Asking silly questions because I don't stand a chance of understanding either > the code or

[PATCH] D76451: [clangd] Enable textual fallback for go-to-definition on dependent names

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Great, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76451/new/ https://reviews.llvm.org/D76451

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn added a comment. ping. @rjmccall & @SjoerdMeijer thanks for all the comments. I hope they are no addressed adequately. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76612/new/ https://reviews.llvm.org/D76612

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:1044 +class ParamWithoutVarRegion : public TypedValueRegion { + friend class MemRegionManager;

[PATCH] D78807: Fix gendered documentation

sylvestre.ledru accepted this revision. sylvestre.ledru added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78807/new/ https://reviews.llvm.org/D78807

[PATCH] D77954: [CUDA][HIP] Fix host/device based overload resolution

yaxunl updated this revision to Diff 259870. yaxunl marked an inline comment as done. yaxunl added a comment. change the precedence of multiversion to be over host/device-ness. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77954/new/ https://reviews.llvm.org/D77954 Files:

[clang] 2da89df - Fix minor bug in CommonArgs.cpp

Author: Yaxun (Sam) Liu Date: 2020-04-24T08:46:33-04:00 New Revision: 2da89df4e8d240160d5f265ecac4b0c6a0705d65 URL: https://github.com/llvm/llvm-project/commit/2da89df4e8d240160d5f265ecac4b0c6a0705d65 DIFF:

Re: [PATCH] D78192: Support compiler extensions as a normal component

Thanks! On Fri, 24 Apr 2020 at 10:51, Serge Guelton wrote: > On Fri, Apr 24, 2020 at 10:15:15AM +0100, Russell Gallop wrote: > > Hi Serge, > > > > It looks like this is failing to build on Windows bots (e.g. [1]http:// > > >

[clang-tools-extra] 9774c34 - [clangd] NFC: Omit deduced template parameters

Author: Kirill Bobyrev Date: 2020-04-24T14:27:39+02:00 New Revision: 9774c34a84e336968f276591c200bd955631c5be URL: https://github.com/llvm/llvm-project/commit/9774c34a84e336968f276591c200bd955631c5be DIFF:

[PATCH] D77954: [CUDA][HIP] Fix host/device based overload resolution

yaxunl marked 6 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:9749 + if (isBetterMultiversionCandidate(Cand1, Cand2)) +return true; + rjmccall wrote: > tra wrote: > > rjmccall wrote: > > > erichkeane

[clang-tools-extra] 1ccfe47 - [clangd] Fix build when CLANGD_REMOTE is not enabled

Author: Kirill Bobyrev Date: 2020-04-24T14:07:39+02:00 New Revision: 1ccfe475a753a93d647be78edff000b9d6667ff7 URL: https://github.com/llvm/llvm-project/commit/1ccfe475a753a93d647be78edff000b9d6667ff7 DIFF:

[PATCH] D78807: Fix gendered documentation

pedro.gonnet created this revision. pedro.gonnet added reviewers: JDevlieghere, hokein. Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. Changed two references to developers as "he" or "him" to the more neutral "they". Repository: rG LLVM Github

[PATCH] D78521: [clangd] Extend dexp to support remote index

This revision was automatically updated to reflect the committed changes. Closed by commit rG67b2dbd5a335: [clangd] Extend dexp to support remote index (authored by kbobyrev). Changed prior to commit: https://reviews.llvm.org/D78521?vs=259859=259869#toc Repository: rG LLVM Github Monorepo

[PATCH] D78521: [clangd] Extend dexp to support remote index

sammccall accepted this revision. sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/remote/Client.cpp:64 + llvm::function_ref Callback) const { +streamRPC( +Request, ::SymbolIndex::Stub::Lookup, Callback); nit:

[clang-tools-extra] 67b2dbd - [clangd] Extend dexp to support remote index

Author: Kirill Bobyrev Date: 2020-04-24T13:59:21+02:00 New Revision: 67b2dbd5a33583fe148fd12f141e15301cfe99d1 URL: https://github.com/llvm/llvm-project/commit/67b2dbd5a33583fe148fd12f141e15301cfe99d1 DIFF:

[PATCH] D78521: [clangd] Extend dexp to support remote index

kbobyrev updated this revision to Diff 259859. kbobyrev marked 16 inline comments as done. kbobyrev added a comment. Address the last round of comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78521/new/ https://reviews.llvm.org/D78521

[PATCH] D75453: [Driver][ARM] fix undefined behaviour when checking architecture version

j0le added a comment. I would like to ask, whether I could "Accept the Revision" myself, or is this only allowed to be done by code owners or other reviewers? And when the revision is accepted, do I have to commit this, or can this only be done by people who have commit access or is this done

[PATCH] D77809: [Analyzer] Include typedef statements in CFG build.

aaron.ballman added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:2855 + VA = FindVA(VA->getElementType().getTypePtr())) { + if (CFGBlock *newBlock = addStmt(VA->getSizeExpr())) +LastBlock = newBlock; balazske wrote: >

[PATCH] D78648: [CMake] Bump CMake minimum version to 3.13.4

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. With the newer minimum CMake version, we can eliminate a bunch of the policy settings as well, but that can be a follow-up (especially given this isn't gonna ship for a few months).

[PATCH] D78477: [profile] Don't crash when forking in several threads

calixte updated this revision to Diff 259854. calixte added a comment. Fix nits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78477/new/ https://reviews.llvm.org/D78477 Files: clang/lib/Driver/ToolChains/Darwin.cpp

[PATCH] D78569: [SVE][CodeGen] Lower SDIV & UDIV to SVE intrinsics

kmclaughlin added a comment. Thank you both for your comments on this patch, @efriedma & @sdesmalen! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78569/new/ https://reviews.llvm.org/D78569 ___

[PATCH] D78674: [SveEmitter] Add builtins for contiguous prefetches

This revision was automatically updated to reflect the committed changes. Closed by commit rG823e2a670a9d: [SveEmitter] Add builtins for contiguous prefetches (authored by sdesmalen). Changed prior to commit: https://reviews.llvm.org/D78674?vs=259587=259851#toc Repository: rG LLVM Github

[PATCH] D78569: [SVE][CodeGen] Lower SDIV & UDIV to SVE intrinsics

This revision was automatically updated to reflect the committed changes. kmclaughlin marked an inline comment as done. Closed by commit rG53dd72a87aeb: [SVE][CodeGen] Lower SDIV UDIV to SVE intrinsics (authored by kmclaughlin). Changed prior to commit:

[PATCH] D78521: [clangd] Extend dexp to support remote index

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG, nits apart from the llvm_unreachable in unimplemented, let's discuss further if you disagree on that. We do have to go back and add unit tests for this stuff. I'm OK with doing that

[PATCH] D78748: [SveEmitter] Add builtins for svld1rq

This revision was automatically updated to reflect the committed changes. Closed by commit rGdb7997472bbd: [SveEmitter] Add builtins for svld1rq (authored by sdesmalen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78748/new/

[clang] 823e2a6 - [SveEmitter] Add builtins for contiguous prefetches

Author: Sander de Smalen Date: 2020-04-24T11:35:59+01:00 New Revision: 823e2a670a9da8e5cd8beed108355a168ca1a23b URL: https://github.com/llvm/llvm-project/commit/823e2a670a9da8e5cd8beed108355a168ca1a23b DIFF:

[clang] db79974 - [SveEmitter] Add builtins for svld1rq

Author: Sander de Smalen Date: 2020-04-24T11:10:28+01:00 New Revision: db7997472bbd01645f058b23a4ca9e991d5b8144 URL: https://github.com/llvm/llvm-project/commit/db7997472bbd01645f058b23a4ca9e991d5b8144 DIFF:

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

Typz added a comment. Thanks for trying the patch, too bad it does not work... I will see how to get the required setup/env, but it will probably take some time (esp. in the current situation). Thanks again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78751: [SveEmitter] Add builtins for scatter stores

This revision was automatically updated to reflect the committed changes. Closed by commit rGc84e1305c4fa: [SveEmitter] Add builtins for scatter stores (authored by sdesmalen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78751/new/

[PATCH] D46317: [clang-tidy] New check bugprone-map-subscript-operator-lookup

khuttun updated this revision to Diff 259843. khuttun added a comment. Documented the MapTypes check option. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D46317/new/ https://reviews.llvm.org/D46317 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp

[PATCH] D77597: [SveEmitter] Add IsAppendSVALL and builtins for svptrue and svcnt[bhwd]

sdesmalen added a comment. Gentle ping :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77597/new/ https://reviews.llvm.org/D77597 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D78521: [clangd] Extend dexp to support remote index

kbobyrev updated this revision to Diff 259839. kbobyrev added a comment. Don't use callback on the last message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78521/new/ https://reviews.llvm.org/D78521 Files:

[PATCH] D78704: [analyzer][NFC] Add unittest for FalsePositiveRefutationBRVisitor

whisperity added inline comments. Comment at: clang/unittests/StaticAnalyzer/FalsePositiveRefutationBRVisitorTest.cpp:24 + do \ +if (!LLVM_WITH_Z3)

[clang] c84e130 - [SveEmitter] Add builtins for scatter stores

Author: Sander de Smalen Date: 2020-04-24T10:57:43+01:00 New Revision: c84e1305c4faf92bb75cf265e022b39bf96da608 URL: https://github.com/llvm/llvm-project/commit/c84e1305c4faf92bb75cf265e022b39bf96da608 DIFF:

Re: [PATCH] D78192: Support compiler extensions as a normal component

On Fri, Apr 24, 2020 at 10:15:15AM +0100, Russell Gallop wrote: > Hi Serge, > > It looks like this is failing to build on Windows bots (e.g. [1]http:// > lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/ > builds/32003). Error below. > > Please could you take a look?

Re: [PATCH] D78192: Support compiler extensions as a normal component

On Fri, Apr 24, 2020 at 10:15:15AM +0100, Russell Gallop wrote: > Hi Serge, > > It looks like this is failing to build on Windows bots (e.g. [1]http:// > lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/ > builds/32003). Error below. > > Please could you take a look?

[PATCH] D78457: [analyzer][Z3-refutation] Fix refutation BugReporterVisitor bug and refactor

whisperity added a comment. @steakhal You might want to update the patch summary before committing this to the upstream (it still mentions "not needing a visitor" ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78457/new/

[PATCH] D78715: [clangd] Fix modernize-loop-convert "multiple diag in flight" crash.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa466e4be3831: [clangd] Fix modernize-loop-convert multiple diag in flight crash. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78477: [profile] Don't crash when forking in several threads

serge-sans-paille added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/GCOVProfiling.cpp:697 +Builder.CreateCall(WriteoutF); +if (NextInst != Parent->end()) { + DebugLoc Loc = E->getDebugLoc(); I'm puzzled by this test. ``F`` is a

[PATCH] D75068: libclang: Add static build support for Windows

cristian.adam marked an inline comment as done. cristian.adam added a comment. @mstorsjo can you merge (again) this on my behalf? Thank you in advance! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75068/new/ https://reviews.llvm.org/D75068

[PATCH] D77809: [Analyzer] Include typedef statements in CFG build.

balazske added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:2855 + VA = FindVA(VA->getElementType().getTypePtr())) { + if (CFGBlock *newBlock = addStmt(VA->getSizeExpr())) +LastBlock = newBlock; aaron.ballman wrote: > newBlock ->

[PATCH] D78521: [clangd] Extend dexp to support remote index

kbobyrev updated this revision to Diff 259836. kbobyrev marked 6 inline comments as done. kbobyrev added a comment. Resolve the last comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78521/new/ https://reviews.llvm.org/D78521 Files:

[clang-tools-extra] a466e4b - [clangd] Fix modernize-loop-convert "multiple diag in flight" crash.

Author: Haojian Wu Date: 2020-04-24T11:16:36+02:00 New Revision: a466e4be3831848d7ff6ffbe4f57d99de8fb66af URL: https://github.com/llvm/llvm-project/commit/a466e4be3831848d7ff6ffbe4f57d99de8fb66af DIFF: https://github.com/llvm/llvm-project/commit/a466e4be3831848d7ff6ffbe4f57d99de8fb66af.diff

Re: [PATCH] D78192: Support compiler extensions as a normal component

Hi Serge, It looks like this is failing to build on Windows bots (e.g. http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/32003). Error below. Please could you take a look? Thanks Russ FAILED:

[PATCH] D78715: [clangd] Fix modernize-loop-convert "multiple diag in flight" crash.

hokein added a comment. In D78715#1999236 , @sammccall wrote: > Ah, nice work! > Agree it's a hack (and how many more instances are lurking) but I don't know > how better to fix it and it's been reported 3 times... this is the only place in clang-tidy

[PATCH] D78715: [clangd] Fix modernize-loop-convert "multiple diag in flight" crash.

hokein updated this revision to Diff 259832. hokein marked 3 inline comments as done. hokein added a comment. refine the fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78715/new/ https://reviews.llvm.org/D78715 Files:

[PATCH] D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu

sthibaul added a comment. @MaskRay : Samuel Thibault CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73845/new/ https://reviews.llvm.org/D73845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D77621: Change BitcodeWriter buffer to std::vector instead of SmallVector.

nikic added a comment. In D77621#2000237 , @nikic wrote: > > Perhaps you could move the value computation into a constexpr variable & > > just return that as needed. (could be a static local constexpr, I guess - > > to avoid the issues around linkage of

[PATCH] D78642: [clang-format] Handle C# property accessors when parsing lines

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1344 addUnwrappedLine(); FormatTok->Type = TT_FunctionLBrace; parseBlock(/*MustBeDeclaration=*/false); jbcoe wrote: > MyDeveloperDay wrote: >

[PATCH] D70416: [Driver] Make -static-libgcc imply static libunwind

itollefsen added a comment. I only build libunwind as a static library because it's (so far) the approach that gets me the furthest in avoiding all of the trouble that comes from having multiple libunwind (on Linux). I'm also running with the patch from D26244

[PATCH] D78192: Support compiler extensions as a normal component

This revision was automatically updated to reflect the committed changes. Closed by commit rG8f766e382b77: Update compiler extension integration into the build system (authored by serge-sans-paille). Changed prior to commit: https://reviews.llvm.org/D78192?vs=259495=259827#toc Repository:

[clang] 8f766e3 - Update compiler extension integration into the build system

Author: serge-sans-paille Date: 2020-04-24T09:40:14+02:00 New Revision: 8f766e382b77eef3102798b49e087d1e4804b984 URL: https://github.com/llvm/llvm-project/commit/8f766e382b77eef3102798b49e087d1e4804b984 DIFF:

[PATCH] D77809: [Analyzer] Include typedef statements in CFG build.

balazske updated this revision to Diff 259820. balazske marked an inline comment as done. balazske added a comment. - Separating test files, fixing alignof problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77809/new/

[PATCH] D65543: [Windows] Autolink with basenames and add libdir to libpath

hans added a comment. The docs look great, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65543/new/ https://reviews.llvm.org/D65543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D77491: [Sema] Fix incompatible builtin redeclarations in non-global scope

tambre added a reviewer: MaskRay. tambre added a comment. Could someone please review this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77491/new/ https://reviews.llvm.org/D77491 ___ cfe-commits

[PATCH] D78629: [clangd] Look for compilation database in `build` subdirectory of parents.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. sorry this fell of my radar. LGTM. As discussed offline i am a little bit worried about regressing the case when there's a `build` in a subdirectory, and a (merged) compilation database

[PATCH] D78785: Fix x86/x86_64 calling convention for _ExtInt

craig.topper added a comment. I think you're missing a check for ExtInt in X86_64ABIInfo::getIndirectReturnResult Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78785/new/ https://reviews.llvm.org/D78785 ___

Re: [clang] 2214b90 - [clangd] Make signatureHelp work with stale preambles

On Thu, 2020-04-23 at 17:46 +0300, Kadir Çetinkaya wrote: > Thanks Mikael, sent out an ugly fix > at 89cb5d558895706e053bc3af972aa5b15aa82863 to get sanitizer build > bots running. > Nice, thanks! Now our buildbots went silent again. /Mikael > Will change the testing scheme for a proper fix. >

<    1   2