[PATCH] D79579: [SveEmitter] Add builtins for svmovlb and svmovlt

sdesmalen created this revision. sdesmalen added reviewers: efriedma, SjoerdMeijer. Herald added a subscriber: tschuett. These builtins are expanded in CGBuiltin to use intrinsics for (signed/unsigned) shift left long top/bottom. https://reviews.llvm.org/D79579 Files: clang/include/clang/Basi

[PATCH] D79072: [Analyzer][VLASizeChecker] Check VLA size in typedef and sizeof.

balazske updated this revision to Diff 262661. balazske marked 2 inline comments as done. balazske added a comment. Added better comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79072/new/ https://reviews.llvm.org/D79072 Files: clang/lib/

[PATCH] D79330: [Analyzer][VLASizeChecker] Check for VLA size overflow.

martong added a comment. Would it be possible to split this patch into two? 1. The refactoring part where you move code out from checkPreStmt to checkVLA. This should be an NFC. 2. Handling of the overflow. Would be much cleaner I guess. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D79354: [clang-format] [PR34574] Handle [[nodiscard]] attribute in class declaration

MyDeveloperDay planned changes to this revision. MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2405 tok::kw___attribute, tok::kw___declspec, -

[PATCH] D79210: Let clang print registered targets for --version

yaxunl added a comment. In D79210#2025058 , @thakis wrote: > In D79210#2025009 , @thakis wrote: > > > We've talked about this 3 years ago in https://reviews.llvm.org/D33900 and > > back then decided that this shoul

[clang] 48451ee - [MSan] Pass MSan command line options under new pass manager

Author: Arthur Eubanks Date: 2020-05-07T08:21:35-07:00 New Revision: 48451ee6a7eed95856d6290f14626e871a073601 URL: https://github.com/llvm/llvm-project/commit/48451ee6a7eed95856d6290f14626e871a073601 DIFF: https://github.com/llvm/llvm-project/commit/48451ee6a7eed95856d6290f14626e871a073601.diff

[clang] 96a581d - [SveEmitter] Add builtins for SVE2 svtbx (extended table lookup)

Author: Sander de Smalen Date: 2020-05-07T16:15:57+01:00 New Revision: 96a581d0f02441320b68d71fac47d51a68c8b7d0 URL: https://github.com/llvm/llvm-project/commit/96a581d0f02441320b68d71fac47d51a68c8b7d0 DIFF: https://github.com/llvm/llvm-project/commit/96a581d0f02441320b68d71fac47d51a68c8b7d0.di

[clang] e46043b - [SveEmitter] Add builtins for SVE2 Optional extensions (AES, SHA3, SM4, BITPERM)

Author: Sander de Smalen Date: 2020-05-07T16:15:57+01:00 New Revision: e46043bba7acbf7738801f199b6fb850b1cf70ad URL: https://github.com/llvm/llvm-project/commit/e46043bba7acbf7738801f199b6fb850b1cf70ad DIFF: https://github.com/llvm/llvm-project/commit/e46043bba7acbf7738801f199b6fb850b1cf70ad.di

[clang] ae65224 - [SveEmitter] Add builtins for SVE2 Vector histogram count instructions

Author: Sander de Smalen Date: 2020-05-07T16:15:57+01:00 New Revision: ae652241bd5b492332fb80e127e31964d3ba83f1 URL: https://github.com/llvm/llvm-project/commit/ae652241bd5b492332fb80e127e31964d3ba83f1 DIFF: https://github.com/llvm/llvm-project/commit/ae652241bd5b492332fb80e127e31964d3ba83f1.di

[clang] f22cdc3 - [SveEmitter] Add builtins for SVE2 Character match instructions

Author: Sander de Smalen Date: 2020-05-07T16:15:57+01:00 New Revision: f22cdc3cc32c60dfe068e7dab366009b5c68c9aa URL: https://github.com/llvm/llvm-project/commit/f22cdc3cc32c60dfe068e7dab366009b5c68c9aa DIFF: https://github.com/llvm/llvm-project/commit/f22cdc3cc32c60dfe068e7dab366009b5c68c9aa.di

[clang] 086722c - [SveEmitter] Add builtins for SVE2 Floating-point widening multiply-accumulate

Author: Sander de Smalen Date: 2020-05-07T16:15:57+01:00 New Revision: 086722c18e4748f8d250806abbf8d7fa5c05e51f URL: https://github.com/llvm/llvm-project/commit/086722c18e4748f8d250806abbf8d7fa5c05e51f DIFF: https://github.com/llvm/llvm-project/commit/086722c18e4748f8d250806abbf8d7fa5c05e51f.di

[clang] fa0371f - [SveEmitter] Add builtins for SVE2 Floating-point integer binary logarithm instructions

Author: Sander de Smalen Date: 2020-05-07T16:15:57+01:00 New Revision: fa0371f4fd97fe9f601991bb2341a1e0426173c6 URL: https://github.com/llvm/llvm-project/commit/fa0371f4fd97fe9f601991bb2341a1e0426173c6 DIFF: https://github.com/llvm/llvm-project/commit/fa0371f4fd97fe9f601991bb2341a1e0426173c6.di

[clang] e76256e - [SveEmitter] Add builtins for SVE2 Complex integer dot product

Author: Sander de Smalen Date: 2020-05-07T16:09:31+01:00 New Revision: e76256e7c1b27087288e8fceb3b6c4aec8359389 URL: https://github.com/llvm/llvm-project/commit/e76256e7c1b27087288e8fceb3b6c4aec8359389 DIFF: https://github.com/llvm/llvm-project/commit/e76256e7c1b27087288e8fceb3b6c4aec8359389.di

[clang] 867bfae - [SveEmitter] Add builtins for SVE2 Widening complex integer arithmetic

Author: Sander de Smalen Date: 2020-05-07T16:09:31+01:00 New Revision: 867bfae93fd7a6731be91024c71a95a79d552411 URL: https://github.com/llvm/llvm-project/commit/867bfae93fd7a6731be91024c71a95a79d552411 DIFF: https://github.com/llvm/llvm-project/commit/867bfae93fd7a6731be91024c71a95a79d552411.di

[clang] ce7f50c - [SveEmitter] Add builtins for SVE2 Uniform complex integer arithmetic

Author: Sander de Smalen Date: 2020-05-07T16:09:31+01:00 New Revision: ce7f50c2ce186ade48a3aba9c28a981978ec527a URL: https://github.com/llvm/llvm-project/commit/ce7f50c2ce186ade48a3aba9c28a981978ec527a DIFF: https://github.com/llvm/llvm-project/commit/ce7f50c2ce186ade48a3aba9c28a981978ec527a.di

[clang] e85bc00 - Revert "Let clang print registered targets for --version"

Author: Yaxun (Sam) Liu Date: 2020-05-07T11:01:42-04:00 New Revision: e85bc0056ef8e7a4ec5b91f20226df609f6f7f12 URL: https://github.com/llvm/llvm-project/commit/e85bc0056ef8e7a4ec5b91f20226df609f6f7f12 DIFF: https://github.com/llvm/llvm-project/commit/e85bc0056ef8e7a4ec5b91f20226df609f6f7f12.dif

[PATCH] D79276: [FileCheck] Support comment directives

jdenny marked 5 inline comments as done. jdenny added a comment. In D79276#2024411 , @jhenderson wrote: > LGTM, but might not hurt to have someone else looking at it. I'll probably wait until Monday to give others more time to participate. Thanks for th

[PATCH] D77491: [Sema] Fix incompatible builtin redeclarations in non-global scope

hokein added a subscriber: rjmccall. hokein added a comment. sorry for the long delay, unfortunately I'm not familiar enough with the code to do a good review. +cc @rjmccall may have more context (from the git log), could you take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D79210: Let clang print registered targets for --version

thakis added a comment. In D79210#2025009 , @thakis wrote: > We've talked about this 3 years ago in https://reviews.llvm.org/D33900 and > back then decided that this should go behind a different flag. Has anything > changed since then? To expand a bit:

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

ZarkoCA added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:691 AddGlobalDtor(Fn); + CXXGlobalDtors.clear(); } I may be missing something but why do we need this now, as opposed to not needing it before? Why didn't we need to clear the CXXGlo

[PATCH] D79257: [OPENMP50]Codegen for uses_allocators clause.

ABataev updated this revision to Diff 262649. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79257/new/ https://reviews.llvm.org/D79257 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOpenMPRunti

[PATCH] D79531: Make -Wnonportable-include-path ignore drive case on Windows.

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Looks reasonable to me, but Windows paths are scary.. Comment at: clang/lib/Lex/PPDirectives.cpp:2112 +// letter for absolute paths, but Name might start with either +//

[clang] b0348af - [SveEmitter] Add builtins for SVE2 widening pairwise arithmetic

Author: Sander de Smalen Date: 2020-05-07T15:21:37+01:00 New Revision: b0348af1082eb3070c34fed99496cdcd511f63e5 URL: https://github.com/llvm/llvm-project/commit/b0348af1082eb3070c34fed99496cdcd511f63e5 DIFF: https://github.com/llvm/llvm-project/commit/b0348af1082eb3070c34fed99496cdcd511f63e5.di

[clang] 5e9bc21 - [SveEmitter] Add builtins for SVE2 Multiplication by indexed elements

Author: Sander de Smalen Date: 2020-05-07T15:21:37+01:00 New Revision: 5e9bc21eea111df698cf45048b8b0e4c3c245dd5 URL: https://github.com/llvm/llvm-project/commit/5e9bc21eea111df698cf45048b8b0e4c3c245dd5 DIFF: https://github.com/llvm/llvm-project/commit/5e9bc21eea111df698cf45048b8b0e4c3c245dd5.di

[clang] 60615cf - [SveEmitter] Add builtins for SVE2 Large integer arithmetic

Author: Sander de Smalen Date: 2020-05-07T15:21:37+01:00 New Revision: 60615cfb43f540745fd38fd2ff6b35c9d5af16ee URL: https://github.com/llvm/llvm-project/commit/60615cfb43f540745fd38fd2ff6b35c9d5af16ee DIFF: https://github.com/llvm/llvm-project/commit/60615cfb43f540745fd38fd2ff6b35c9d5af16ee.di

[clang] 7ff0500 - [SveEmitter] Add builtins for SVE2 Non-widening pairwise arithmetic

Author: Sander de Smalen Date: 2020-05-07T15:21:37+01:00 New Revision: 7ff05002d0b5b73cb1d155e27cb15f5d459e86e8 URL: https://github.com/llvm/llvm-project/commit/7ff05002d0b5b73cb1d155e27cb15f5d459e86e8 DIFF: https://github.com/llvm/llvm-project/commit/7ff05002d0b5b73cb1d155e27cb15f5d459e86e8.di

[clang] 36aab0c - [SveEmitter] Add builtins for SVE2 Bitwise ternary logical instructions

Author: Sander de Smalen Date: 2020-05-07T15:21:37+01:00 New Revision: 36aab0c055a93d95e84606368e088bd1559e4ccb URL: https://github.com/llvm/llvm-project/commit/36aab0c055a93d95e84606368e088bd1559e4ccb DIFF: https://github.com/llvm/llvm-project/commit/36aab0c055a93d95e84606368e088bd1559e4ccb.di

[PATCH] D79186: [OPENMP]Consider 'omp_null_allocator' as a predefined allocator.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8026394d3cc7: [OPENMP]Consider 'omp_null_allocator' as a predefined allocator. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79186/new

[PATCH] D79210: Let clang print registered targets for --version

thakis added a comment. We've talked about this 3 years ago in https://reviews.llvm.org/D33900 and back then decided that this should go behind a different flag. Has anything changed since then? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79210/

[PATCH] D79423: [analyzer][NFC] StdLibraryFunctionsChecker: Add empty Signatures

martong added a comment. In D79423#2023150 , @balazske wrote: > Probably something like `IsCStdLibraryFunction` can be included in the > signature, and empty signature is allowed only for functions that are in a C > standard library. Yeah, we could do

[PATCH] D79576: [AST] Fix the PrintQualifiedName for ObjC instance variable in class extension.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, ilya-biryukov. Herald added a project: clang. Similar to property, we print the containing interface decl as the nested name specifier for ivar; otherwise we will get "::ivar_name". th

[PATCH] D79423: [analyzer][NFC] StdLibraryFunctionsChecker: Add empty Signatures

martong added a comment. In D79423#2022920 , @xazax.hun wrote: > In D79423#2022812 , @martong wrote: > > > I don't think that could be a concern. > > Actually, redefinition of a reserved name either in the C or in

[clang] 8026394 - [OPENMP]Consider 'omp_null_allocator' as a predefined allocator.

Author: Alexey Bataev Date: 2020-05-07T10:11:06-04:00 New Revision: 8026394d3cc77db6f8172eeaa83b9747979c8642 URL: https://github.com/llvm/llvm-project/commit/8026394d3cc77db6f8172eeaa83b9747979c8642 DIFF: https://github.com/llvm/llvm-project/commit/8026394d3cc77db6f8172eeaa83b9747979c8642.diff

[PATCH] D79186: [OPENMP]Consider 'omp_null_allocator' as a predefined allocator.

ABataev added a comment. In D79186#2023322 , @jdoerfert wrote: > LGTM. > > In D79186#2016893 , @ABataev wrote: > > > In D79186#2016737 , @jdoerfert > > wrote: > > > > > In D

[PATCH] D79072: [Analyzer][VLASizeChecker] Check VLA size in typedef and sizeof.

balazske marked 4 inline comments as done. balazske added a comment. I do not know what other than `typedef` or `sizeof` (and variable declaration) can contain VLA. To my knowledge VLA is not normally supported in C++ and should not be used anyway (there are better ways for doing it) so some fun

[PATCH] D78477: [profile] Don't crash when forking in several threads

This revision was automatically updated to reflect the committed changes. Closed by commit rGbec223a9bc4e: [profile] Don't crash when forking in several threads (authored by Calixte Denizet ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D73052: [clang-tidy] RenamerClangTidy now renames dependent member expr when the member can be resolved

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.h:44 + virtual void storeCheckOptions(ClangTidyOptions::OptionMap &Opts) {} + aaron.ballman wrote: > I'd appreciate

[PATCH] D79072: [Analyzer][VLASizeChecker] Check VLA size in typedef and sizeof.

Szelethus added a comment. We check now whether the argument of `typedef` and `sizeof` is an incorrect VLA, but what other examples are we potentially forgetting? The warning message states that "Declared variable-length array (VLA) has negative size", but we are not actually looking for declar

[PATCH] D79423: [analyzer][NFC] StdLibraryFunctionsChecker: Add empty Signatures

martong updated this revision to Diff 262620. martong added a comment. - Rename 'empty' -> 'irrelevant' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79423/new/ https://reviews.llvm.org/D79423 Files: clang/lib/StaticAnalyzer/Checkers/StdLibraryF

[clang] 0d22076 - [SveEmitter] Add builtins for SVE2 uniform DSP operations

Author: Sander de Smalen Date: 2020-05-07T13:31:46+01:00 New Revision: 0d22076531ce9f2757ae4c69e647f02e99394e05 URL: https://github.com/llvm/llvm-project/commit/0d22076531ce9f2757ae4c69e647f02e99394e05 DIFF: https://github.com/llvm/llvm-project/commit/0d22076531ce9f2757ae4c69e647f02e99394e05.di

[clang] 5fa0eee - [SveEmitter] Add more SVE2 builtins for shift operations

Author: Sander de Smalen Date: 2020-05-07T13:31:46+01:00 New Revision: 5fa0eeec6eb1d1f6946d3e6ee2455e95bb79d870 URL: https://github.com/llvm/llvm-project/commit/5fa0eeec6eb1d1f6946d3e6ee2455e95bb79d870 DIFF: https://github.com/llvm/llvm-project/commit/5fa0eeec6eb1d1f6946d3e6ee2455e95bb79d870.di

[clang] cac0626 - [SveEmitter] Add builtins for svinsr

Author: Sander de Smalen Date: 2020-05-07T13:31:46+01:00 New Revision: cac06263a426c28892090c6abc7ee8c6b724838d URL: https://github.com/llvm/llvm-project/commit/cac06263a426c28892090c6abc7ee8c6b724838d DIFF: https://github.com/llvm/llvm-project/commit/cac06263a426c28892090c6abc7ee8c6b724838d.di

[clang] 35de496 - [SveEmitter] Add builtins for svqdecp and svqincp

Author: Sander de Smalen Date: 2020-05-07T13:31:46+01:00 New Revision: 35de49655023207a888c0469b24f39fc2e5eaa8a URL: https://github.com/llvm/llvm-project/commit/35de49655023207a888c0469b24f39fc2e5eaa8a DIFF: https://github.com/llvm/llvm-project/commit/35de49655023207a888c0469b24f39fc2e5eaa8a.di

[clang] bec223a - [profile] Don't crash when forking in several threads

Author: Calixte Denizet Date: 2020-05-07T14:13:11+02:00 New Revision: bec223a9bc4eb9747993ee9a4c1aa135c32123e6 URL: https://github.com/llvm/llvm-project/commit/bec223a9bc4eb9747993ee9a4c1aa135c32123e6 DIFF: https://github.com/llvm/llvm-project/commit/bec223a9bc4eb9747993ee9a4c1aa135c32123e6.dif

[PATCH] D79486: [clang] Make arrangeCXX{Constructor,Method}Call() publicly available

mboehme added a comment. Abandoning this change as I've realized I'm going to need additional features, specifically those related to extra args passed for virtual base classes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79486/new/ https://revi

[clang] ddfe588 - Revert "[cmake] Allow std::filesystem tests in CrossWinToARMLinux.cmake"

Author: Sergej Jaskiewicz Date: 2020-05-07T15:01:39+03:00 New Revision: ddfe58822eca2ea9b279a01a512d49f736789fca URL: https://github.com/llvm/llvm-project/commit/ddfe58822eca2ea9b279a01a512d49f736789fca DIFF: https://github.com/llvm/llvm-project/commit/ddfe58822eca2ea9b279a01a512d49f736789fca.d

[PATCH] D79400: [CMAKE] Fix build failure when source directory is read only

pdhaliwal added a comment. Removing `find_first_existing_vc_file` makes a lot of sense, as since llvm has moved from svn to git, there is no need to have logic for svn dependency. Even the generation script is dependent on git executable only. I will keep my patch ready just in case other revie

[PATCH] D77249: [MSan] Pass command line options to MSan with new pass manager

vitalybuka added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1232 PB.registerScalarOptimizerLateEPCallback( [](FunctionPassManager &FPM, PassBuilder::OptimizationLevel Level) { FPM.addPass(BoundsCheckingPass()); ---

[PATCH] D77249: [MSan] Pass command line options to MSan with new pass manager

vitalybuka added inline comments. Comment at: compiler-rt/test/msan/chained_origin_empty_stack_npm.cpp:4 +// this test. +// RUN: %clangxx_msan -fsanitize-memory-track-origins=2 \ +// RUN: -fexperimental-new-pass-manager -O3 %s -o %t && \ rnk wrote: > leonardc

[PATCH] D79400: [CMAKE] Fix build failure when source directory is read only

scott.linder added a comment. Thank you for the explanation; I'm also still lost as to why `.git/logs/HEAD` is referenced at all then. I would propose removing `find_first_existing_vc_file` entirely, as it seems to be completely redundant if there is another mechanism for ensuring the VCS heade

[PATCH] D79210: Let clang print registered targets for --version

yaxunl added a comment. In D79210#2024555 , @hans wrote: > I think this is worth a short note in docs/ReleaseNotes.rst. https://reviews.llvm.org/D79565 Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D79565: Document outputing registered targets with -v in release notes

yaxunl created this revision. yaxunl added a reviewer: hans. https://reviews.llvm.org/D79565 Files: clang/docs/ReleaseNotes.rst Index: clang/docs/ReleaseNotes.rst === --- clang/docs/ReleaseNotes.rst +++ clang/docs/ReleaseNotes.rs

[clang] 4f94e1a - [SveEmitter] Add builtins for svasrd (zeroing/undef predication)

Author: Sander de Smalen Date: 2020-05-07T12:28:18+01:00 New Revision: 4f94e1a9f7018418b8a5605b86ac170651726e8b URL: https://github.com/llvm/llvm-project/commit/4f94e1a9f7018418b8a5605b86ac170651726e8b DIFF: https://github.com/llvm/llvm-project/commit/4f94e1a9f7018418b8a5605b86ac170651726e8b.di

[clang] dbc6a07 - [SveEmitter] Add builtins for address calculations.

Author: Sander de Smalen Date: 2020-05-07T12:28:18+01:00 New Revision: dbc6a07bcc6a72ffb79bd6cafd5dbfe50db16804 URL: https://github.com/llvm/llvm-project/commit/dbc6a07bcc6a72ffb79bd6cafd5dbfe50db16804 DIFF: https://github.com/llvm/llvm-project/commit/dbc6a07bcc6a72ffb79bd6cafd5dbfe50db16804.di

[clang] ac894a5 - [SveEmitter] Add builtins for FFR manipulation

Author: Sander de Smalen Date: 2020-05-07T12:28:18+01:00 New Revision: ac894a5181ef622139a2c09b66a006e8fd450849 URL: https://github.com/llvm/llvm-project/commit/ac894a5181ef622139a2c09b66a006e8fd450849 DIFF: https://github.com/llvm/llvm-project/commit/ac894a5181ef622139a2c09b66a006e8fd450849.di

[clang] 827c8b0 - [SveEmitter] Add builtins for svcntp

Author: Sander de Smalen Date: 2020-05-07T12:28:18+01:00 New Revision: 827c8b06d33de9d19db8f0c79fb022b4ae815a08 URL: https://github.com/llvm/llvm-project/commit/827c8b06d33de9d19db8f0c79fb022b4ae815a08 DIFF: https://github.com/llvm/llvm-project/commit/827c8b06d33de9d19db8f0c79fb022b4ae815a08.di

[clang] 91cb13f - [SveEmitter] Add builtins for svqadd, svqsub and svdot

Author: Sander de Smalen Date: 2020-05-07T12:28:18+01:00 New Revision: 91cb13f90d0f066a02c2a79db194624f02896fa6 URL: https://github.com/llvm/llvm-project/commit/91cb13f90d0f066a02c2a79db194624f02896fa6 DIFF: https://github.com/llvm/llvm-project/commit/91cb13f90d0f066a02c2a79db194624f02896fa6.di

[PATCH] D79496: [clangd] Fix AddUsing tweak for out-of-line functions.

This revision was automatically updated to reflect the committed changes. Closed by commit rG910871532101: [clangd] Fix AddUsing tweak for out-of-line functions. (authored by adamcz, committed by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D78573: [Clang][Sema] Capturing section type conflicts between #pragma clang section and section attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rG9d39df03a984: [Clang][Sema] Capturing section type conflicts between #pragma clang section… (authored by pratlucas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D79480: [SveEmitter] Add builtins for SVE2 Polynomial arithmetic

This revision was automatically updated to reflect the committed changes. Closed by commit rG3cb8b4c193c1: [SveEmitter] Add builtins for SVE2 Polynomial arithmetic (authored by sdesmalen). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D79480?vs=262341&id=26260

[PATCH] D79478: [CodeGen][SVE] Lowering of shift operations with scalable types

This revision was automatically updated to reflect the committed changes. Closed by commit rG3bcd3dd4734d: [CodeGen][SVE] Lowering of shift operations with scalable types (authored by kmclaughlin). Changed prior to commit: https://reviews.llvm.org/D79478?vs=262333&id=262600#toc Repository: r

[PATCH] D78572: [Clang][Sema] Capturing section type conflicts on #pragma clang section

This revision was automatically updated to reflect the committed changes. Closed by commit rG0dac639f285a: [Clang][Sema] Capturing section type conflicts on #pragma clang section (authored by pratlucas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D72281: [Matrix] Add matrix type to Clang.

fhahn marked 4 inline comments as done. fhahn added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:2109 +if (!RowExprTemplateParam || !ColumnExprTemplateParam) + return Sema::TDK_Success; + rjmccall wrote: > fhahn wrote: >

[PATCH] D78743: [clangd] Preserve line information while build PreamblePatch

This revision was automatically updated to reflect the committed changes. Closed by commit rG717bef662329: [clangd] Preserve line information while build PreamblePatch (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78743/new/

[PATCH] D79496: [clangd] Fix AddUsing tweak for out-of-line functions.

hokein added inline comments. Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:2673 +void foo::fun() { + one::two::f^f(); +})cpp", adamcz wrote: > hokein wrote: > > IIUC, before this patch, the using was added inside the above namespace > > `foo`,

[PATCH] D78933: [analyzer] RangeConstraintManager optimizations in comparison expressions

ASDenysPetrov marked an inline comment as done. ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:588 + // AnyX2 means that two expressions marked as `Any` are met in code, + // and there is a special column for that, for

[PATCH] D78572: [Clang][Sema] Capturing section type conflicts on #pragma clang section

pratlucas updated this revision to Diff 262592. pratlucas added a comment. Addressing review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78572/new/ https://reviews.llvm.org/D78572 Files: clang/include/clang/AST/ASTContext.h clang/li

[PATCH] D79480: [SveEmitter] Add builtins for SVE2 Polynomial arithmetic

sdesmalen marked an inline comment as done. sdesmalen added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:7813 + llvm::ScalableVectorType *Ty = getSVEType(TypeFlags); + return Builder.CreateBitCast(Call, Ty); +} efriedma wrote: > Please add a FIX

[PATCH] D78573: [Clang][Sema] Capturing section type conflicts between #pragma clang section and section attributes

pratlucas updated this revision to Diff 262594. pratlucas added a comment. Addressing review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78573/new/ https://reviews.llvm.org/D78573 Files: clang/include/clang/AST/ASTContext.h clang/li

[clang] 9d39df0 - [Clang][Sema] Capturing section type conflicts between #pragma clang section and section attributes

Author: Lucas Prates Date: 2020-05-07T11:54:46+01:00 New Revision: 9d39df03a984ff4bed7d441a110d44976a8ab21b URL: https://github.com/llvm/llvm-project/commit/9d39df03a984ff4bed7d441a110d44976a8ab21b DIFF: https://github.com/llvm/llvm-project/commit/9d39df03a984ff4bed7d441a110d44976a8ab21b.diff

[clang] 0dac639 - [Clang][Sema] Capturing section type conflicts on #pragma clang section

Author: Lucas Prates Date: 2020-05-07T11:53:30+01:00 New Revision: 0dac639f285a53dffe3239ec5561fa0fc2da0daf URL: https://github.com/llvm/llvm-project/commit/0dac639f285a53dffe3239ec5561fa0fc2da0daf DIFF: https://github.com/llvm/llvm-project/commit/0dac639f285a53dffe3239ec5561fa0fc2da0daf.diff

[clang] 3cb8b4c - [SveEmitter] Add builtins for SVE2 Polynomial arithmetic

Author: Sander de Smalen Date: 2020-05-07T11:53:04+01:00 New Revision: 3cb8b4c193c1904543511dfe892475c4e733a778 URL: https://github.com/llvm/llvm-project/commit/3cb8b4c193c1904543511dfe892475c4e733a778 DIFF: https://github.com/llvm/llvm-project/commit/3cb8b4c193c1904543511dfe892475c4e733a778.di

[clang-tools-extra] 9108715 - [clangd] Fix AddUsing tweak for out-of-line functions.

Author: Adam Czachorowski Date: 2020-05-07T12:50:04+02:00 New Revision: 91087153210132a4c2d3cf19a4526d8f395cb5a4 URL: https://github.com/llvm/llvm-project/commit/91087153210132a4c2d3cf19a4526d8f395cb5a4 DIFF: https://github.com/llvm/llvm-project/commit/91087153210132a4c2d3cf19a4526d8f395cb5a4.d

[clang-tools-extra] 717bef6 - [clangd] Preserve line information while build PreamblePatch

Author: Kadir Cetinkaya Date: 2020-05-07T12:24:28+02:00 New Revision: 717bef6623291b550d3cd66c32092cc0ca1c236b URL: https://github.com/llvm/llvm-project/commit/717bef6623291b550d3cd66c32092cc0ca1c236b DIFF: https://github.com/llvm/llvm-project/commit/717bef6623291b550d3cd66c32092cc0ca1c236b.dif

[PATCH] D79496: [clangd] Fix AddUsing tweak for out-of-line functions.

adamcz marked an inline comment as done. adamcz added inline comments. Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:2673 +void foo::fun() { + one::two::f^f(); +})cpp", hokein wrote: > IIUC, before this patch, the using was added inside the above

[PATCH] D78812: [SVE][CodeGen] Fix legalisation for scalable types

This revision was automatically updated to reflect the committed changes. Closed by commit rGa31f4c52bf85: [SVE][CodeGen] Fix legalisation for scalable types (authored by kmclaughlin). Changed prior to commit: https://reviews.llvm.org/D78812?vs=260603&id=262580#toc Repository: rG LLVM Github

[PATCH] D60193: [OpenCL] Added addrspace_cast operator

mantognini added a comment. Thanks for your clarifications and updates. Just one tiny question about a test file, but otherwise LGTM. Comment at: clang/test/SemaOpenCLCXX/addrspace_cast.cl:19-24 +template +void test_temp(__global int *par) { + T *var1 = addrspace_cast(par);

[PATCH] D79210: Let clang print registered targets for --version

hans added a comment. I think this is worth a short note in docs/ReleaseNotes.rst. Also this broke Goma which we use in Chromium (https://chromium.googlesource.com/infra/goma/client/) because it's a bit too strict when parsing the output of "clang -v" -- but that's our problem and we'll fix. :

[PATCH] D77491: [Sema] Fix incompatible builtin redeclarations in non-global scope

tambre added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77491/new/ https://reviews.llvm.org/D77491 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D78374: [Analyzer][StreamChecker] Added evaluation of fread and fwrite.

balazske added a comment. I am not sure if this FEOF thing is such a big problem. The modeling is not exact but practically this does not cause big problems and still better than before this patch. The problem is, if a `fread` is made and the stream is already in **EOF** state the (modeled) `fr

[PATCH] D78129: Add Marvell ThunderX3T110 support

SjoerdMeijer added a comment. Agreed about the UnsupportedFeatures list. But I just wanted to unblock this work, create a first version that compiles, so you can pick it up and clean things further up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D79494: [clang-tidy] Exclude function calls in std namespace for bugprone-argument-comment.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2a3498e24f97: [clang-tidy] Exclude function calls in std namespace for bugprone-argument… (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D79276: [FileCheck] Support comment directives

jhenderson accepted this revision. jhenderson added a comment. This revision is now accepted and ready to land. LGTM, but might not hurt to have someone else looking at it. Comment at: llvm/test/FileCheck/comment/bad-comment-prefix.txt:40 +RUN:

[PATCH] D79510: [PATCH] When pragma FENV_ACCESS is ignored do not modify Sema.CurFPFeatures

uabelho added a comment. Great! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79510/new/ https://reviews.llvm.org/D79510 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D79494: [clang-tidy] Exclude function calls in std namespace for bugprone-argument-comment.

hokein added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/ArgumentCommentCheck.cpp:68 + // them does more harm than good. + unless(hasDeclaration((isFromStdNamespace() + .bind("expr"), gribozavr2 wrot

[clang-tools-extra] 2a3498e - [clang-tidy] Exclude function calls in std namespace for bugprone-argument-comment.

Author: Haojian Wu Date: 2020-05-07T09:00:49+02:00 New Revision: 2a3498e24f97d85ddd2bb25467ff6fc1f6baa5f1 URL: https://github.com/llvm/llvm-project/commit/2a3498e24f97d85ddd2bb25467ff6fc1f6baa5f1 DIFF: https://github.com/llvm/llvm-project/commit/2a3498e24f97d85ddd2bb25467ff6fc1f6baa5f1.diff LO

[PATCH] D79494: [clang-tidy] Exclude function calls in std namespace for bugprone-argument-comment.

hokein updated this revision to Diff 262556. hokein marked 3 inline comments as done. hokein added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79494/new/ https://reviews.llvm.org/D79494 Files: clang-tools-extra/clan

<    1   2